Re: Master is slow

2019-05-13 Thread Scott Kostyshak
On Mon, May 13, 2019 at 10:35:54AM +0200, Jean-Marc Lasgouttes wrote: > Le 13/05/2019 à 07:11, Scott Kostyshak a écrit : > > Has the situation of Buffer::updateMacros improved in the last couple of > > years? If not, would it be worth considering tracking whether a document > > uses a macro? This w

Re: Master is slow

2019-05-13 Thread Jean-Marc Lasgouttes
Le 13/05/2019 à 07:11, Scott Kostyshak a écrit : Has the situation of Buffer::updateMacros improved in the last couple of years? If not, would it be worth considering tracking whether a document uses a macro? This way, users who do not use macros would not have the performance hit? I tried to i

Re: Master is slow

2019-05-12 Thread Scott Kostyshak
On Mon, Oct 24, 2016 at 06:08:59PM +0200, Jean-Marc Lasgouttes wrote: > Le 22/10/2016 à 19:39, Guillaume Munch a écrit : > > After improvements by Richard and Jean-Marc, GuiView::getStatus is down > > to 10% (mostly lyx::to_utf8) and there is no trace of tabs updating. > > Thanks for checking. >

Re: Master is slow

2016-11-07 Thread racoon
On 01.11.2016 19:14, racoon wrote: On 22.10.2016 19:39, Guillaume Munch wrote: Le 18/10/2016 à 21:44, Guillaume Munch a écrit : Profiling shows that calls to BufferParams::isExportableFormat are numerous and expensive when doing char-forward (33% of the total amount of CPU). This is called fro

Re: Master is slow

2016-11-01 Thread racoon
On 22.10.2016 19:39, Guillaume Munch wrote: Le 18/10/2016 à 21:44, Guillaume Munch a écrit : Profiling shows that calls to BufferParams::isExportableFormat are numerous and expensive when doing char-forward (33% of the total amount of CPU). This is called from GuiView::updateToolbars -> GuiView

Re: Master is slow

2016-10-24 Thread Jean-Marc Lasgouttes
Le 22/10/2016 à 19:39, Guillaume Munch a écrit : After improvements by Richard and Jean-Marc, GuiView::getStatus is down to 10% (mostly lyx::to_utf8) and there is no trace of tabs updating. Thanks for checking. New bottlenecks are Buffer::updateMacros (25%, of course depends on the document)

Re: Master is slow

2016-10-22 Thread Richard Heck
On 10/22/2016 01:39 PM, Guillaume Munch wrote: > Le 18/10/2016 à 21:44, Guillaume Munch a écrit : >> >> Profiling shows that calls to BufferParams::isExportableFormat >> are numerous and expensive when doing char-forward (33% of the total >> amount of CPU). This is called from GuiView::updateToolba

Re: Master is slow

2016-10-22 Thread Guillaume Munch
Le 18/10/2016 à 21:44, Guillaume Munch a écrit : Profiling shows that calls to BufferParams::isExportableFormat are numerous and expensive when doing char-forward (33% of the total amount of CPU). This is called from GuiView::updateToolbars -> GuiView::getStatus. There is room for improvement, b

Re: Master is slow

2016-10-18 Thread racoon
On 19.10.2016 07:08, racoon wrote: On 19.10.2016 07:03, racoon wrote: On 18.10.2016 21:44, Guillaume Munch wrote: Le 15/10/2016 à 11:39, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debug

Re: Master is slow

2016-10-18 Thread racoon
On 19.10.2016 07:03, racoon wrote: On 18.10.2016 21:44, Guillaume Munch wrote: Le 15/10/2016 à 11:39, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging running in the background or so

Re: Master is slow

2016-10-18 Thread racoon
On 18.10.2016 21:44, Guillaume Munch wrote: Le 15/10/2016 à 11:39, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging running in the background or so? A minimal working example to rep

Re: Master is slow

2016-10-18 Thread racoon
On 18.10.2016 18:43, Kornel Benko wrote: Am Dienstag, 18. Oktober 2016 um 18:30:22, schrieb racoon On 18.10.2016 10:13, Kornel Benko wrote: Am Dienstag, 18. Oktober 2016 um 09:58:14, schrieb Jean-Marc Lasgouttes Le 18/10/2016 à 09:55, racoon a écrit : On 18.10.2016 09:46, Jean-Marc Lasgo

Re: Master is slow

2016-10-18 Thread Jean-Marc Lasgouttes
Le 18/10/16 à 22:10, Richard Heck a écrit : I also found that calls to TabWorkArea::updateTabTexts are expensive and repeatedb. This amounts to 31% of the total amount of CPU, shared between QTabWidget::setTabText and QTabWidget::setTabIcon. TabWorkArea::updateTabTexts is connected to the signal

Re: Master is slow

2016-10-18 Thread Richard Heck
On 10/18/2016 03:44 PM, Guillaume Munch wrote: > Le 15/10/2016 à 11:39, racoon a écrit : >> Typing within the master's work area is slow on my computer (while it is >> fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging >> running in the background or so? >> > > > Profiling show

Re: Master is slow

2016-10-18 Thread Guillaume Munch
Le 15/10/2016 à 11:39, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging running in the background or so? Profiling shows that calls to BufferParams::isExportableFormat are numerous

Re: Master is slow

2016-10-18 Thread Kornel Benko
Am Dienstag, 18. Oktober 2016 um 18:30:22, schrieb racoon > On 18.10.2016 10:13, Kornel Benko wrote: > > Am Dienstag, 18. Oktober 2016 um 09:58:14, schrieb Jean-Marc Lasgouttes > > > >> Le 18/10/2016 à 09:55, racoon a écrit : > >>> > >>> > >>> On 18.10.2016 09:46, Jean-Marc Lasgouttes wrote: > >

Re: Master is slow

2016-10-18 Thread racoon
On 18.10.2016 10:13, Kornel Benko wrote: Am Dienstag, 18. Oktober 2016 um 09:58:14, schrieb Jean-Marc Lasgouttes Le 18/10/2016 à 09:55, racoon a écrit : On 18.10.2016 09:46, Jean-Marc Lasgouttes wrote: Le 15/10/2016 à 19:53, racoon a écrit : Yes, I think so. Does compiling in normal mod

Re: Master is slow

2016-10-18 Thread Kornel Benko
Am Dienstag, 18. Oktober 2016 um 09:58:14, schrieb Jean-Marc Lasgouttes > Le 18/10/2016 à 09:55, racoon a écrit : > > > > > > On 18.10.2016 09:46, Jean-Marc Lasgouttes wrote: > >> Le 15/10/2016 à 19:53, racoon a écrit : > >>> Yes, I think so. > >> > >> Does compiling in normal mode help to recove

Re: Master is slow

2016-10-18 Thread Jean-Marc Lasgouttes
Le 18/10/2016 à 09:55, racoon a écrit : On 18.10.2016 09:46, Jean-Marc Lasgouttes wrote: Le 15/10/2016 à 19:53, racoon a écrit : Yes, I think so. Does compiling in normal mode help to recover the original speed? Could you remind me how to compile in non-debug mode? Is that a setting in CM

Re: Master is slow

2016-10-18 Thread racoon
On 18.10.2016 09:46, Jean-Marc Lasgouttes wrote: Le 15/10/2016 à 19:53, racoon a écrit : Yes, I think so. Does compiling in normal mode help to recover the original speed? Could you remind me how to compile in non-debug mode? Is that a setting in CMAKE that I have to uncheck or so? Dani

Re: Master is slow

2016-10-18 Thread Jean-Marc Lasgouttes
Le 15/10/2016 à 19:53, racoon a écrit : Yes, I think so. Does compiling in normal mode help to recover the original speed? JMarc On 15.10.2016 18:39, Jean-Marc Lasgouttes wrote: Did you compile in debug mode ?

Re: Master is slow

2016-10-16 Thread racoon
On 15.10.2016 20:27, Jean-Marc Lasgouttes wrote: Le 15/10/2016 à 19:53, racoon a écrit : Yes, I think so. This adds some run time checks in windows that can make things slower. Another thing to check: did you compile against Qt5 or Qt4? Qt5.

Re: Master is slow

2016-10-16 Thread racoon
On 15.10.2016 21:46, Guillaume Munch wrote: Le 15/10/2016 à 11:39, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). What is the qt version? Qt 5.6.1 Daniel

Re: Master is slow

2016-10-15 Thread Guillaume Munch
Le 15/10/2016 à 11:39, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). What is the qt version?

Re: Master is slow

2016-10-15 Thread Jean-Marc Lasgouttes
Le 15/10/2016 à 19:53, racoon a écrit : Yes, I think so. This adds some run time checks in windows that can make things slower. Another thing to check: did you compile against Qt5 or Qt4? From the top of my head, I cannot think of big changes in master that could slow things down. JMarc

Re: Master is slow

2016-10-15 Thread racoon
Yes, I think so. Daniel On 15.10.2016 18:39, Jean-Marc Lasgouttes wrote: Dis you compilé in debug mode ? JMarc Le 15 octobre 2016 11:39:55 GMT+02:00, racoon a écrit : Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). Maybe this just h

Re: Master is slow

2016-10-15 Thread Jean-Marc Lasgouttes
Dis you compilé in debug mode ? JMarc Le 15 octobre 2016 11:39:55 GMT+02:00, racoon a écrit : >Typing within the master's work area is slow on my computer (while it >is >fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging > >running in the background or so? > >Daniel

Re: Master is slow

2016-10-15 Thread racoon
On 15.10.2016 16:18, Scott Kostyshak wrote: On Sat, Oct 15, 2016 at 11:39:55AM +0200, racoon wrote: Typing within the master's work area is slow on my computer (while it is fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging running in the background or so? I haven't notice

Re: Master is slow

2016-10-15 Thread Scott Kostyshak
On Sat, Oct 15, 2016 at 11:39:55AM +0200, racoon wrote: > Typing within the master's work area is slow on my computer (while it is > fine in 2.2.2 and 2.1.5). Maybe this just has to do with some debugging > running in the background or so? I haven't noticed this. Do you by chance have the code pre