Herbert Voss wrote:
I have an image with an unknown format, so LyX returns user.
If I save all these files as *.user then I am able to define
a converter so that all these images can be previewed inside
LyX. which is not possible when '' is returned, if I am not
wrong here. Defining a
Herbert Voss wrote:
> I have an image with an unknown format, so LyX returns user.
> If I save all these files as *.user then I am able to define
> a converter so that all these images can be previewed inside
> LyX. which is not possible when '' is returned, if I am not
> wrong here. Defining a
Georg Baum wrote:
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
I am quite happy with your patch...
Good.
with this fixed.
Of course ;-)
I am applying this now. I'll fix the users format later if it is needed
after Herberts explanation (which he hopefully gives).
I have an
Georg Baum wrote:
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
I am quite happy with your patch...
Good.
with this fixed.
Of course ;-)
I am applying this now. I'll fix the "users" format later if it is needed
after Herberts explanation (which he hopefully gives).
I have an
Lars Gullik Bjønnes wrote:
Georg Baum [EMAIL PROTECTED]
writes:
This is a wrapper...
Yes, it was a misunderstanding, I was thinking you suggested a wrapper
around the wrapper, and I could not see why we want two wrappers ;-)
is formatlist a member of something, or a global var?
It is a
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
I am quite happy with your patch...
Good.
with this fixed.
Of course ;-)
I am applying this now. I'll fix the users format later if it is needed
after Herberts explanation (which he hopefully gives).
Georg
Lars Gullik Bjønnes wrote:
> Georg Baum <[EMAIL PROTECTED]>
> writes:
> This is a wrapper...
Yes, it was a misunderstanding, I was thinking you suggested a wrapper
around the wrapper, and I could not see why we want two wrappers ;-)
> is formatlist a member of something, or a global var?
It is
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
> I am quite happy with your patch...
Good.
> with this fixed.
Of course ;-)
I am applying this now. I'll fix the "users" format later if it is needed
after Herberts explanation (which he hopefully gives).
Georg
diff -u -p -r1.5 ChangeLog
--- src/client/ChangeLog 29 Oct 2004 15:47:53 - 1.5
+++ src/client/ChangeLog 8 Nov 2004 18:22:34 -
@@ -1,3 +1,7 @@
+2004-11-08 Georg Baum [EMAIL PROTECTED]
+
+ * client.C: remove format hack
+
2004-10-29 Georg Baum [EMAIL PROTECTED]
* client.C (formats): new
Georg Baum wrote:
Here comes the patch. I removed the useless user format in the process.
Now getFormatFromContents() either returns a format name or an empty string
if it cannot determine the format. I even found two cases where the return
value of getFormatFromContents() needed to be checked.
Georg Baum [EMAIL PROTECTED] writes:
| Lars Gullik Bjønnes wrote:
Georg Baum [EMAIL PROTECTED]
writes:
| Would it be ok with you to have something like
| Format const *Formats::getFormatFromFile(string filename)
| that does what getFormatFromContents() did before your patch?
Yes.
One
Herbert Voss [EMAIL PROTECTED] writes:
| Georg Baum wrote:
Here comes the patch. I removed the useless user format in the process.
Now getFormatFromContents() either returns a format name or an empty string
if it cannot determine the format. I even found two cases where the return
value of
Georg Baum [EMAIL PROTECTED] writes:
| +string Formats::getFormatFromFile(string const filename) const
| +{
| + if (filename.empty())
| + return string();
| +
| + string const format =
| lyx::support::getFormatFromContents(filename)
This is a wrapper...
is formatlist a
Herbert Voss wrote:
Georg Baum wrote:
Here comes the patch. I removed the useless user format in the process.
Now getFormatFromContents() either returns a format name or an empty
string if it cannot determine the format. I even found two cases where
the return value of
mp; filename) const;
///
int getNumber(std::string const & name) const;
///
Index: src/client/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/client/ChangeLog,v
retrieving revision 1.5
diff -u -p -r1.5 ChangeLog
--- s
Georg Baum wrote:
Here comes the patch. I removed the useless "user" format in the process.
Now getFormatFromContents() either returns a format name or an empty string
if it cannot determine the format. I even found two cases where the return
value of getFormatFromContents() needed to be checked.
Georg Baum <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> Georg Baum <[EMAIL PROTECTED]>
>> writes:
>> | Would it be ok with you to have something like
>> | Format const *Formats::getFormatFromFile(string filename)
>> | that does what getFormatFromContents() did before your patch?
Herbert Voss <[EMAIL PROTECTED]> writes:
| Georg Baum wrote:
>
>> Here comes the patch. I removed the useless "user" format in the process.
>> Now getFormatFromContents() either returns a format name or an empty string
>> if it cannot determine the format. I even found two cases where the return
Georg Baum <[EMAIL PROTECTED]> writes:
| +string Formats::getFormatFromFile(string const & filename) const
| +{
| + if (filename.empty())
| + return string();
| +
| + string const format =
| lyx::support::getFormatFromContents(filename)
This is a wrapper...
is formatlist a
Herbert Voss wrote:
> Georg Baum wrote:
>
>> Here comes the patch. I removed the useless "user" format in the process.
>> Now getFormatFromContents() either returns a format name or an empty
>> string if it cannot determine the format. I even found two cases where
>> the return value of
This hack (dummy Format object to make libsupport link), is not
acceptable.
This means that the usage for Format and format.h in
support/filetools.C is not acceptable and must go away.
libsupport should should not include anything from core. It is a
support library. I am going to apply the
Am Sonntag, 7. November 2004 13:52 schrieb Lars Gullik Bjønnes:
This hack (dummy Format object to make libsupport link), is not
acceptable.
Then it needs to be removed from tex2lyx, too.
This means that the usage for Format and format.h in
support/filetools.C is not acceptable and must go
Georg Baum [EMAIL PROTECTED] writes:
| Am Sonntag, 7. November 2004 13:52 schrieb Lars Gullik Bjønnes:
This hack (dummy Format object to make libsupport link), is not
acceptable.
| Then it needs to be removed from tex2lyx, too.
This means that the usage for Format and format.h in
This hack (dummy Format object to make libsupport link), is not
acceptable.
This means that the usage for Format and format.h in
support/filetools.C is not acceptable and must go away.
libsupport should should not include anything from "core". It is a
support library. I am going to apply the
Am Sonntag, 7. November 2004 13:52 schrieb Lars Gullik Bjønnes:
>
> This hack (dummy Format object to make libsupport link), is not
> acceptable.
Then it needs to be removed from tex2lyx, too.
> This means that the usage for Format and format.h in
> support/filetools.C is not acceptable and
Georg Baum <[EMAIL PROTECTED]> writes:
| Am Sonntag, 7. November 2004 13:52 schrieb Lars Gullik Bjønnes:
>>
>> This hack (dummy Format object to make libsupport link), is not
>> acceptable.
>
| Then it needs to be removed from tex2lyx, too.
>
>> This means that the usage for Format and format.h
26 matches
Mail list logo
