[MediaWiki-commits] [Gerrit] marvin[master]: Chore: don't exclude ESLint config from linting

2018-01-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406076 ) Change subject: Chore: don't exclude ESLint config from linting .. Chore: don't exclude ESLint config from linting Specify that the

[MediaWiki-commits] [Gerrit] marvin[master]: WIP: Update: add search box UI

2018-01-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406077 ) Change subject: WIP: Update: add search box UI .. WIP: Update: add search box UI Refactor the Header component to use the Grid and add

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Fix: check old revision for deletion when diffing

2018-01-19 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405346 ) Change subject: Fix: check old revision for deletion when diffing .. Fix: check old revision for deletion when diffing When

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Hygiene: improve Math formula print styling comment

2018-01-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404481 ) Change subject: Hygiene: improve Math formula print styling comment .. Hygiene: improve Math formula print styling comment Add an

[MediaWiki-commits] [Gerrit] marvin[master]: Update: favor rem to em and use CSS variables

2018-01-12 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403975 ) Change subject: Update: favor rem to em and use CSS variables .. Update: favor rem to em and use CSS variables Replace em units with

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Fix: style printed math formulas with serif font

2018-01-11 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403777 ) Change subject: Fix: style printed math formulas with serif font .. Fix: style printed math formulas with serif font When printed,

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Update: show placeholder preview for more failures

2018-01-11 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403722 ) Change subject: Update: show placeholder preview for more failures .. Update: show placeholder preview for more failures Functional

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: add more fetch failure test cases

2018-01-11 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403684 ) Change subject: Hygiene: add more fetch failure test cases .. Hygiene: add more fetch failure test cases Add fetch failure tests for

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Update: missing preview copy

2018-01-11 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403683 ) Change subject: Update: missing preview copy .. Update: missing preview copy Update the placeholder extract and button text shown when

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Fix: preview page URL for 404 RESTBase responses

2018-01-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403580 ) Change subject: Fix: preview page URL for 404 RESTBase responses .. Fix: preview page URL for 404 RESTBase responses Functional

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Update: hide section expansion option on large displays

2018-01-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402116 ) Change subject: Update: hide section expansion option on large displays .. Update: hide section expansion option on large displays On

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Update: hide section expansion option on large displays

2018-01-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402082 ) Change subject: Update: hide section expansion option on large displays .. Update: hide section expansion option on large displays On

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Docs: update browser test documentation

2018-01-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402046 ) Change subject: Docs: update browser test documentation .. Docs: update browser test documentation - Match `$ip` casing used in

[MediaWiki-commits] [Gerrit] marvin[master]: Update: add grid

2017-12-22 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399877 ) Change subject: Update: add grid .. Update: add grid Add extensible, responsive grid component for positioning elements according to a

[MediaWiki-commits] [Gerrit] marvin[master]: Update: make Paper full-bleed

2017-12-21 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399665 ) Change subject: Update: make Paper full-bleed .. Update: make Paper full-bleed Extend the Paper component to fill the screen

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: convert CSS media query breakpoints to symbols

2017-12-21 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399664 ) Change subject: Chore: convert CSS media query breakpoints to symbols .. Chore: convert CSS media query breakpoints to symbols Declare

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add postcss with autoprefixer

2017-12-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399436 ) Change subject: Chore: add postcss with autoprefixer .. Chore: add postcss with autoprefixer Add postcss with the autoprefixer plugin.

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: remove unused Domino types

2017-12-18 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398912 ) Change subject: Chore: remove unused Domino types .. Chore: remove unused Domino types These types are no longer in use but have been

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: only render the last requested route

2017-12-18 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398913 ) Change subject: Fix: only render the last requested route .. Fix: only render the last requested route Route.getProps() resolves

[MediaWiki-commits] [Gerrit] marvin[master]: WIP: add support for page transitions

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398541 ) Change subject: WIP: add support for page transitions .. WIP: add support for page transitions Bug: T179489 Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: upgrade Preact, Domino, and Wikimedia UI styles

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398539 ) Change subject: Chore: upgrade Preact, Domino, and Wikimedia UI styles .. Chore: upgrade Preact, Domino, and Wikimedia UI styles

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: upgrade Sinon, nodemon, and npm-run-all

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398540 ) Change subject: Chore: upgrade Sinon, nodemon, and npm-run-all .. Chore: upgrade Sinon, nodemon, and npm-run-all Upgrade @types/sinon

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: upgrade TypeScript dependencies

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398538 ) Change subject: Chore: upgrade TypeScript dependencies .. Chore: upgrade TypeScript dependencies Upgrade @types/compression v0.0.34 →

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: horizontally scroll sections as needed

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398535 ) Change subject: Fix: horizontally scroll sections as needed .. Fix: horizontally scroll sections as needed When all other CSS

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: use concise syntax for optional methods

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398536 ) Change subject: Chore: use concise syntax for optional methods .. Chore: use concise syntax for optional methods Replace: {

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add size test for bundled client CSS

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398534 ) Change subject: Chore: add size test for bundled client CSS .. Chore: add size test for bundled client CSS The client is Marvin's only

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: upgrade lint and style dependencies

2017-12-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398537 ) Change subject: Chore: upgrade lint and style dependencies .. Chore: upgrade lint and style dependencies Upgrade eslint v4.10.0 →

[MediaWiki-commits] [Gerrit] marvin[master]: Update: use content header margins for section headers

2017-12-12 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397902 ) Change subject: Update: use content header margins for section headers .. Update: use content header margins for section headers Wrap

[MediaWiki-commits] [Gerrit] marvin[master]: Update: move hatnotes to the top of the page

2017-12-12 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397893 ) Change subject: Update: move hatnotes to the top of the page .. Update: move hatnotes to the top of the page Move wiki page hatnotes

[MediaWiki-commits] [Gerrit] marvin[master]: Update: change revision path param to oldid query param

2017-12-12 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397860 ) Change subject: Update: change revision path param to oldid query param .. Update: change revision path param to oldid query param

[MediaWiki-commits] [Gerrit] marvin[master]: Update: add query parameter parser

2017-12-12 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397859 ) Change subject: Update: add query parameter parser .. Update: add query parameter parser Bug: T178617 Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Update: allow query parameters in URL

2017-12-08 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396463 ) Change subject: Update: allow query parameters in URL .. Update: allow query parameters in URL • Permit query parameters to be

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add query parameter typing

2017-12-08 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396464 ) Change subject: Chore: add query parameter typing .. Chore: add query parameter typing • Refactor route#RouteParams into path and

[MediaWiki-commits] [Gerrit] marvin[master]: Update: browser window / tab title per page

2017-12-08 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396418 ) Change subject: Update: browser window / tab title per page .. Update: browser window / tab title per page Bug: T180465 Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Update: reset scroll position when visiting a new page

2017-12-08 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396364 ) Change subject: Update: reset scroll position when visiting a new page .. Update: reset scroll position when visiting a new page Bug:

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: image links don't load destination in place

2017-12-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396091 ) Change subject: Fix: image links don't load destination in place .. Fix: image links don't load destination in place Check the parent

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add router tests for fetch errors

2017-12-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396038 ) Change subject: Chore: add router tests for fetch errors .. Chore: add router tests for fetch errors Add router tests for errors

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: visiting a missing wiki page causes a server error

2017-12-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396015 ) Change subject: Fix: visiting a missing wiki page causes a server error .. Fix: visiting a missing wiki page causes a server error

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: rename PageResolver

2017-12-06 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395810 ) Change subject: Chore: rename PageResolver .. Chore: rename PageResolver • Rename PageResolver from verb to noun, RequestPageModule.

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add type checking to error and 404 page props

2017-12-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395658 ) Change subject: Chore: add type checking to error and 404 page props .. Chore: add type checking to error and 404 page props Validate

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: update router test style to return Promises

2017-12-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395657 ) Change subject: Chore: update router test style to return Promises .. Chore: update router test style to return Promises • Return

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: return not found wiki pages as 404s

2017-12-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395656 ) Change subject: Fix: return not found wiki pages as 404s .. Fix: return not found wiki pages as 404s The wiki route may fail when

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: remove isomorphic unfetch extras

2017-12-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395654 ) Change subject: Chore: remove isomorphic unfetch extras .. Chore: remove isomorphic unfetch extras IsomorphicHeaders no longer appear

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: replace fetch header type assertion

2017-12-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395571 ) Change subject: Chore: replace fetch header type assertion .. Chore: replace fetch header type assertion Replace fetch header type

[MediaWiki-commits] [Gerrit] marvin[master]: Update: handle redirects manually on the client too

2017-12-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395572 ) Change subject: Update: handle redirects manually on the client too .. Update: handle redirects manually on the client too If the

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: remove AnyRoute

2017-12-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395171 ) Change subject: Chore: remove AnyRoute .. Chore: remove AnyRoute Route now only has one type parameter which makes `Route` just as

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: use function keyword in client and server

2017-12-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395038 ) Change subject: Chore: use function keyword in client and server .. Chore: use function keyword in client and server Use the function

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: show original server errors

2017-12-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395039 ) Change subject: Fix: show original server errors .. Fix: show original server errors When the server encounters an error, show the

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: force File page images to wrap

2017-12-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394992 ) Change subject: Fix: force File page images to wrap .. Fix: force File page images to wrap • Limit the width of file page images to

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: disable powered by Express header

2017-12-02 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394778 ) Change subject: Chore: disable powered by Express header .. Chore: disable powered by Express header Marvin is open source but it

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: encode all slashes in page titles

2017-11-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394474 ) Change subject: Fix: encode all slashes in page titles .. Fix: encode all slashes in page titles When issuing requests to RESTBase,

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add fetch wrapper tests

2017-11-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394476 ) Change subject: Chore: add fetch wrapper tests .. Chore: add fetch wrapper tests Bug: T177681 Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: rename RESTBase HTTP modules

2017-11-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394473 ) Change subject: Chore: rename RESTBase HTTP modules .. Chore: rename RESTBase HTTP modules Move page-redirect to restbase-redirect and

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: rename fetch-with-redirect to fetch

2017-11-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394475 ) Change subject: Chore: rename fetch-with-redirect to fetch .. Chore: rename fetch-with-redirect to fetch The fetch-with-redirect

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: gracefully handle redirects to external sites

2017-11-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392573 ) Change subject: Fix: gracefully handle redirects to external sites .. Fix: gracefully handle redirects to external sites When

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: don't log redirects

2017-11-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392572 ) Change subject: Chore: don't log redirects .. Chore: don't log redirects RedirectErrors are exceptional but expected operation and

[MediaWiki-commits] [Gerrit] marvin[master]: Update: capture wiki link clicks and navigation

2017-11-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392570 ) Change subject: Update: capture wiki link clicks and navigation .. Update: capture wiki link clicks and navigation Extract

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: wiki and summary page title decoding

2017-11-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392571 ) Change subject: Fix: wiki and summary page title decoding .. Fix: wiki and summary page title decoding Wiki and summary page title

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: don't reference the manifest in the client

2017-11-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392429 ) Change subject: Fix: don't reference the manifest in the client .. Fix: don't reference the manifest in the client The client cannot

[MediaWiki-commits] [Gerrit] marvin[master]: Update: show 404 page when content cannot be found

2017-11-17 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392093 ) Change subject: Update: show 404 page when content cannot be found .. Update: show 404 page when content cannot be found • Detect and

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: update page summaries for new endpoint responses

2017-11-17 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392076 ) Change subject: Fix: update page summaries for new endpoint responses .. Fix: update page summaries for new endpoint responses The MCS

[MediaWiki-commits] [Gerrit] marvin[master]: Update: show image on image File pages

2017-11-17 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392078 ) Change subject: Update: show image on image File pages .. Update: show image on image File pages Add the missing image to File

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: extract Thumbnail to separate component

2017-11-17 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392077 ) Change subject: Chore: extract Thumbnail to separate component .. Chore: extract Thumbnail to separate component Thumbnail is

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: improve audio player CSS presentation

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391994 ) Change subject: Fix: improve audio player CSS presentation .. Fix: improve audio player CSS presentation Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: Mocha TypeScript project reference

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391976 ) Change subject: Fix: Mocha TypeScript project reference .. Fix: Mocha TypeScript project reference It's unclear why but running with

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: pin package versions to patch revision

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391901 ) Change subject: Fix: pin package versions to patch revision .. Fix: pin package versions to patch revision From 5105645: Don't

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: refactor manifest according to current styles

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391895 ) Change subject: Chore: refactor manifest according to current styles .. Chore: refactor manifest according to current styles Refactor

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: load wordmark as a separate request

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391899 ) Change subject: Chore: load wordmark as a separate request .. Chore: load wordmark as a separate request Instead of inlining the

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: consolidate manifest logic

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391898 ) Change subject: Chore: consolidate manifest logic .. Chore: consolidate manifest logic Move all manifest logic into manifest.ts since

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: move assets to common

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391896 ) Change subject: Chore: move assets to common .. Chore: move assets to common Both the server and client need the ability to use assets

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: move config code to common

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391897 ) Change subject: Chore: move config code to common .. Chore: move config code to common Both server and client need access to config

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: allow clean plugin to delete build products

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391880 ) Change subject: Fix: allow clean plugin to delete build products .. Fix: allow clean plugin to delete build products The clean plugin

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: improve chunk size

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391881 ) Change subject: Chore: improve chunk size .. Chore: improve chunk size Use path hashes for referencing chunks instead of the paths

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add Webpack performance requirements

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391851 ) Change subject: Chore: add Webpack performance requirements .. Chore: add Webpack performance requirements Webpack has some simple but

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: add bundlesize test

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391842 ) Change subject: Chore: add bundlesize test .. Chore: add bundlesize test This patch adds production build output gzipped file size

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: inject server environment variables at compilation time

2017-11-16 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391818 ) Change subject: Fix: inject server environment variables at compilation time .. Fix: inject server environment variables at compilation

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: move Webpack client config to subdirectory

2017-11-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391750 ) Change subject: Chore: move Webpack client config to subdirectory .. Chore: move Webpack client config to subdirectory Move the client

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: remove superfluous typing on about page

2017-11-15 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391749 ) Change subject: Chore: remove superfluous typing on about page .. Chore: remove superfluous typing on about page Now that route page

[MediaWiki-commits] [Gerrit] marvin[master]: WIP: use Webpack for server production builds

2017-11-14 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391467 ) Change subject: WIP: use Webpack for server production builds .. WIP: use Webpack for server production builds Bug: T177235 Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: replace IgnorePlugin usage with __non_webpack_require__

2017-11-14 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391363 ) Change subject: Chore: replace IgnorePlugin usage with __non_webpack_require__ .. Chore: replace IgnorePlugin usage with

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: replace clean script with Webpack plugin

2017-11-14 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391283 ) Change subject: Chore: replace clean script with Webpack plugin .. Chore: replace clean script with Webpack plugin Remove the clean

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: use Uglify version with ES6 support

2017-11-14 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391285 ) Change subject: Chore: use Uglify version with ES6 support .. Chore: use Uglify version with ES6 support According to the docs,

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: don't restart client on server changes

2017-11-14 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391284 ) Change subject: Chore: don't restart client on server changes .. Chore: don't restart client on server changes It's true that the

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: improve about page component typing

2017-11-14 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391212 ) Change subject: Chore: improve about page component typing .. Chore: improve about page component typing Use undefined for the render

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: RedirectError prototype chain

2017-11-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389784 ) Change subject: Fix: RedirectError prototype chain .. Fix: RedirectError prototype chain Add missed call to Object.setPrototypeOf()

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: improve RouteParams comments

2017-11-06 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389538 ) Change subject: Chore: improve RouteParams comments .. Chore: improve RouteParams comments Change-Id:

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: lint against ES8

2017-11-06 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389500 ) Change subject: Chore: lint against ES8 .. Chore: lint against ES8 Configure ESLint to match the expectations of the common TypeScript

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: upgrade dependencies

2017-11-02 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388275 ) Change subject: Chore: upgrade dependencies .. Chore: upgrade dependencies • typescript v2.5.3 → 2.6.1 • Strict function types

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: refactor page modules

2017-11-02 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/388069 ) Change subject: Chore: refactor page modules .. Chore: refactor page modules - Rename PageModule to PageComponents. - Add PageModule

[MediaWiki-commits] [Gerrit] marvin[master]: Update: use CSS border-box box model

2017-10-31 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387589 ) Change subject: Update: use CSS border-box box model .. Update: use CSS border-box box model We don't yet know what all the

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: upgrade dependencies

2017-10-31 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387583 ) Change subject: Chore: upgrade dependencies .. Chore: upgrade dependencies • preact v8.2.5 → 8.2.6 • Fix: AnyComponent type to allow

[MediaWiki-commits] [Gerrit] marvin[master]: Update: report server URL redirect statuses

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387328 ) Change subject: Update: report server URL redirect statuses .. Update: report server URL redirect statuses When a redirect occurs on a

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: refactor page and summary data client request methods

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387329 ) Change subject: Chore: refactor page and summary data client request methods .. Chore: refactor page and summary data client request

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: remove unused Router interface

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387327 ) Change subject: Chore: remove unused Router interface .. Chore: remove unused Router interface Move the Router typing into the

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: reduce console usage to a warning

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387238 ) Change subject: Chore: reduce console usage to a warning .. Chore: reduce console usage to a warning Reduce the severity of ESLint

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: split out summary unmarshaller

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387234 ) Change subject: Chore: split out summary unmarshaller .. Chore: split out summary unmarshaller Split out page summary unmarshalling

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: move page marshallers to subdirectories

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387235 ) Change subject: Chore: move page marshallers to subdirectories .. Chore: move page marshallers to subdirectories Move page-base, page,

[MediaWiki-commits] [Gerrit] marvin[master]: Chore: rename data-clients to http

2017-10-30 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387233 ) Change subject: Chore: rename data-clients to http .. Chore: rename data-clients to http Rename "data clients" to "HTTP clients": -

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: require navbox contents to occupy 100% available width

2017-10-18 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385097 ) Change subject: Fix: require navbox contents to occupy 100% available width .. Fix: require navbox contents to occupy 100% available

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: handle question marks

2017-10-18 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385093 ) Change subject: Fix: handle question marks .. Fix: handle question marks - Treat question marks as part of the path passed to the

  1   2   3   4   5   6   7   8   9   10   >