[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix: Reading Lists: Articles without lead image should show...

2018-01-23 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405921 ) Change subject: Fix: Reading Lists: Articles without lead image should show placeholders .. Fix: Reading Lists: Articles without

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Empty state and minor bug fix

2018-01-22 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405805 ) Change subject: Empty state and minor bug fix .. Empty state and minor bug fix String correction to "No saved pages yet" when there

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Create option to Delete Lists and multiple Test article lists

2018-01-19 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405359 ) Change subject: Create option to Delete Lists and multiple Test article lists .. Create option to Delete Lists and multiple Test

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix: Random Cards never load when swiped quickly

2018-01-18 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405220 ) Change subject: Fix: Random Cards never load when swiped quickly .. Fix: Random Cards never load when swiped quickly -Logic added to

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [WIP] Reading List Sync :User education message for not logg...

2018-01-18 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405020 ) Change subject: [WIP] Reading List Sync :User education message for not logged in users .. [WIP] Reading List Sync :User education

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Show message when article limit is reached on reading lists

2018-01-12 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404059 ) Change subject: Show message when article limit is reached on reading lists .. Show message when article limit is reached on reading

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Split large reading lists

2018-01-11 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403756 ) Change subject: Split large reading lists .. Split large reading lists - Split existing lists > 1000 on version update - Split lists

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [WIP] Split large reading lists

2018-01-05 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402464 ) Change subject: [WIP] Split large reading lists .. [WIP] Split large reading lists - Split existing lists > 1000 on version update -

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix: Layout alignment for WikiErrorView

2018-01-03 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401777 ) Change subject: Fix: Layout alignment for WikiErrorView .. Fix: Layout alignment for WikiErrorView - The bottom margin on the retry

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Existing user created reading list named 'saved'

2018-01-02 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401637 ) Change subject: Existing user created reading list named 'saved' .. Existing user created reading list named 'saved' - on updating

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update empty state of reading lists

2017-12-23 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400087 ) Change subject: Update empty state of reading lists .. Update empty state of reading lists - Updated logic for showing empty

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update empty state of reading lists

2017-12-23 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400086 ) Change subject: Update empty state of reading lists .. Update empty state of reading lists - Updated logic for showing empty

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Expose default list

2017-12-22 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399973 ) Change subject: Expose default list .. Expose default list - Creates a new default reading list called 'Saved' list for all users,

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update the user education message when user first saves an a...

2017-12-22 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399875 ) Change subject: Update the user education message when user first saves an article to a reading list .. Update the user education

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: On-this-day minor ui fix

2017-12-22 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399810 ) Change subject: On-this-day minor ui fix .. On-this-day minor ui fix - Fixes the month string style - Fixes indicator date

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [WIP] Unit tests for reading lists

2017-12-20 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399541 ) Change subject: [WIP] Unit tests for reading lists .. [WIP] Unit tests for reading lists - Created instrumented tests for dbHelper -

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Use animation for dice in Randomizer

2017-12-14 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398415 ) Change subject: Use animation for dice in Randomizer .. Use animation for dice in Randomizer - Added animated Vector for dice

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Randomizer offline behavior - Remove perpetual spinner

2017-12-14 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398267 ) Change subject: Randomizer offline behavior - Remove perpetual spinner .. Randomizer offline behavior - Remove perpetual spinner -

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: On this day event text not shown fully

2017-12-11 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397703 ) Change subject: On this day event text not shown fully .. On this day event text not shown fully - Removed the 5 line max limit on

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [WIP] Add hidden developer setting to create reading lists

2017-12-06 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395891 ) Change subject: [WIP] Add hidden developer setting to create reading lists .. [WIP] Add hidden developer setting to create reading

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: [WIP] Add DatePicker on on-this-day full screen

2017-12-06 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395808 ) Change subject: [WIP] Add DatePicker on on-this-day full screen .. [WIP] Add DatePicker on on-this-day full screen - Date Picker has

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: OnThisDay endpoint change

2017-12-05 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395602 ) Change subject: OnThisDay endpoint change .. OnThisDay endpoint change - Deriving the response from aggregate feed response instead

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Feed page cannot be updated by swiping down after changing l...

2017-12-05 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395588 ) Change subject: Feed page cannot be updated by swiping down after changing language at search .. Feed page cannot be updated by

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix OnThisDayPagesViewHolder crash

2017-12-01 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394631 ) Change subject: Fix OnThisDayPagesViewHolder crash .. Fix OnThisDayPagesViewHolder crash - App crash on null pages response fixed by

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: On this day

2017-11-29 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394217 ) Change subject: On this day .. On this day - Design tweaks - Changed UtcDate to Date to get default TimeZone. BUG: T175995

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: EventLogging for Android

2017-11-17 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392092 ) Change subject: EventLogging for Android .. EventLogging for Android - Persistent event records - Post events on exit - If the

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: On this day card

2017-11-13 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391145 ) Change subject: On this day card .. On this day card - Feed card has been changed per design Todo: Design changes for detail

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: EventLogging for Android

2017-11-09 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390287 ) Change subject: EventLogging for Android .. EventLogging for Android Requirements for EventLogging : - Post events on exit

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: List all 'on this day' events

2017-10-30 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387349 ) Change subject: List all 'on this day' events .. List all 'on this day' events - Feed card shows 'selected' event - List shows all

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: List all trending posts

2017-10-24 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386332 ) Change subject: List all trending posts .. List all trending posts - Added a view to display an option to view all the posts - Added

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: WIP: On this day card

2017-09-29 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381444 ) Change subject: WIP: On this day card .. WIP: On this day card - On This day card appears on the feed below continueReading. - Card

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Change Window Background Light mode color

2017-09-26 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380796 ) Change subject: Change Window Background Light mode color .. Change Window Background Light mode color - Base color light mode is

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: WIP: Design consolidation

2017-09-22 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379774 ) Change subject: WIP: Design consolidation .. WIP: Design consolidation - Repetition of style attributes has been removed. - Standard

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Format Code

2017-09-21 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379526 ) Change subject: Format Code .. Format Code - Ran a format on /app [ option + command + L ] Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: WIP : Consolidate Light and Dark mode colors

2017-09-18 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378747 ) Change subject: WIP : Consolidate Light and Dark mode colors .. WIP : Consolidate Light and Dark mode colors - 16 colors that were

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: UX : Consolidate Light and Dark modes

2017-09-08 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376788 ) Change subject: UX : Consolidate Light and Dark modes .. UX : Consolidate Light and Dark modes -Consolidating expected Light and

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Merge branch 'master' into dark_mode_card_colors

2017-08-30 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374821 ) Change subject: Merge branch 'master' into dark_mode_card_colors .. Merge branch 'master' into dark_mode_card_colors Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Dark Mode : Change card colors for dark mode

2017-08-30 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374820 ) Change subject: Dark Mode : Change card colors for dark mode .. Dark Mode : Change card colors for dark mode - Changed Search bar

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Dark Mode : Change card colors for dark mode

2017-08-25 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373986 ) Change subject: Dark Mode : Change card colors for dark mode .. Dark Mode : Change card colors for dark mode - Changed Search bar

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: dummy commit

2017-08-23 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373365 ) Change subject: dummy commit .. dummy commit Change-Id: I4132bc70c96121c5fa5606fe3e244881bad3 --- A dummy 1 file changed, 1

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: dummy commit

2017-08-23 Thread Sharvaniharan (Code Review)
Sharvaniharan has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373358 ) Change subject: dummy commit .. dummy commit Change-Id: I753b00198cc7ad55b1d57878230557c1d6f07871 --- A