[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Add dropdown indicator to namespace selection field

2017-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398251 ) Change subject: Add dropdown indicator to namespace selection field .. Add dropdown indicator to namespace selection field

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Adding placeholder text to namespace selection field

2017-12-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398245 ) Change subject: Adding placeholder text to namespace selection field .. Adding placeholder text to namespace selection field

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Remove Main Page as default value and add hint

2017-10-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383118 ) Change subject: Remove Main Page as default value and add hint .. Remove Main Page as default value and add hint We don't

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: New beta feature description text

2017-10-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382150 ) Change subject: New beta feature description text .. New beta feature description text Bug: T170375 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: onSpecialPage_initList get user from context & check type

2017-10-05 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/382432 ) Change subject: onSpecialPage_initList get user from context & check type .. onSpecialPage_initList get user from

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Check for Wikidiff2 version 0.3 NOT for 0.3.0

2017-09-04 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375784 ) Change subject: Check for Wikidiff2 version 0.3 NOT for 0.3.0 .. Check for Wikidiff2 version 0.3 NOT for 0.3.0

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[REL1_27]: Fix errors leading to wrong slider scroll positions

2017-06-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/361037 ) Change subject: Fix errors leading to wrong slider scroll positions .. Fix errors leading to wrong slider scroll

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Configure AdvancedSearch as a betafeature

2017-06-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358597 ) Change subject: Configure AdvancedSearch as a betafeature .. Configure AdvancedSearch as a betafeature Bug: T167277 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Introduce config var for moved-paragraph-detection threshold

2017-06-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357826 ) Change subject: Introduce config var for moved-paragraph-detection threshold .. Introduce config var for

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Configure AdvancedSearch as a betafeature

2017-06-08 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357843 ) Change subject: Configure AdvancedSearch as a betafeature .. Configure AdvancedSearch as a betafeature Bug: T167277 Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Add CI jobs for AdvancedSearch extension

2017-06-06 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357370 ) Change subject: Add CI jobs for AdvancedSearch extension .. Add CI jobs for AdvancedSearch extension Bug: T11 Change-Id:

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: Report contributions to AdvancedSearch to wikimedia-de-tech ...

2017-06-06 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357357 ) Change subject: Report contributions to AdvancedSearch to wikimedia-de-tech channel .. Report contributions to AdvancedSearch

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Replace deprecated method zone() with utcOffset()

2017-04-05 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346533 ) Change subject: Replace deprecated method zone() with utcOffset() .. Replace deprecated method zone() with utcOffset() Also

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add an alternative ssh-key for goransm

2017-03-30 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345587 ) Change subject: Add an alternative ssh-key for goransm .. Add an alternative ssh-key for goransm Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Adjust credits

2017-03-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342223 ) Change subject: Adjust credits .. Adjust credits Andrew actually did more relevant work than me in this extension :)

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Revert "Do not run selenium-Wikibase Jenkins job on test wiki"

2017-02-14 Thread Tobias Gritschacher (Code Review)
Hello Daniel Kinzler, Lydia Pintscher, Aude, Hoo man, Jonas Kress (WMDE), Zfilipin, Addshore, jenkins-bot, Thiemo Mättig (WMDE), I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/337607 to review the following change. Change subject: Revert "Do not run

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Login when creating new items in browsertests

2017-02-14 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337577 ) Change subject: Login when creating new items in browsertests .. Login when creating new items in browsertests Bug: T157050

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Don't set min-height and min-width for oo-ui buttons

2017-02-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337024 ) Change subject: Don't set min-height and min-width for oo-ui buttons .. Don't set min-height and min-width for oo-ui buttons

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Check if QUnit tests are language-setting-proof

2016-12-20 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328365 ) Change subject: Check if QUnit tests are language-setting-proof .. Check if QUnit tests are language-setting-proof Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Revert "Reset custom separator transform tables in number fo...

2016-12-20 Thread Tobias Gritschacher (Code Review)
Hello WMDE-leszek, Addshore, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/328360 to review the following change. Change subject: Revert "Reset custom separator transform tables in number formatting tests"

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Respect $wgTwoColConflictBetaFeature setting

2016-12-15 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327487 ) Change subject: Respect $wgTwoColConflictBetaFeature setting .. Respect $wgTwoColConflictBetaFeature setting Bug: T153311

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Script to recalculate normalized hashes

2016-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/321011 ) Change subject: Script to recalculate normalized hashes .. Script to recalculate normalized hashes Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Use ConnectionManager from Core

2016-12-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/322409 ) Change subject: Use ConnectionManager from Core .. Use ConnectionManager from Core Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Include namespace when setting hidden form field

2016-12-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326436 ) Change subject: Include namespace when setting hidden form field .. Include namespace when setting hidden form field

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: RevisionSlider should always be on top of the page

2016-12-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326431 ) Change subject: RevisionSlider should always be on top of the page .. RevisionSlider should always be on top of the page E.g.

[MediaWiki-commits] [Gerrit] integration/config[master]: Change reciepients for Wikibase browsertests

2016-12-01 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/324698 Change subject: Change reciepients for Wikibase browsertests .. Change reciepients for Wikibase browsertests We've got a

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: Add Vagrant role for Wikibase Repo

2016-11-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/323841 Change subject: Add Vagrant role for Wikibase Repo .. Add Vagrant role for Wikibase Repo Adding a simple Wikibase-repo role for

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Don't show opt-out preference for betafeature

2016-11-25 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/323510 Change subject: Don't show opt-out preference for betafeature .. Don't show opt-out preference for betafeature Bug: T151452

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Extend browsertests to test new conflict-view

2016-11-22 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/322890 Change subject: Extend browsertests to test new conflict-view .. Extend browsertests to test new conflict-view Bug: T149720

[MediaWiki-commits] [Gerrit] integration/config[master]: Notify wikidata-monitoring on WIkibase browsertest failures

2016-11-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/322082 Change subject: Notify wikidata-monitoring on WIkibase browsertest failures .. Notify wikidata-monitoring on WIkibase browsertest

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Check for unitsuggester in browsertests

2016-11-17 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/322104 Change subject: Check for unitsuggester in browsertests .. Check for unitsuggester in browsertests Bug: T150161 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Exclude authority control gadget tests with debug=true from ...

2016-11-15 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/321629 Change subject: Exclude authority control gadget tests with debug=true from browsertests .. Exclude authority control gadget

[MediaWiki-commits] [Gerrit] integration/config[master]: Enable browsertests for TwoColConflict extension

2016-11-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320770 Change subject: Enable browsertests for TwoColConflict extension .. Enable browsertests for TwoColConflict extension Bug:

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Fix default setting

2016-11-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320762 Change subject: Fix default setting .. Fix default setting setting $wgElectronPdfServiceMaxDocumentSize to exactly 1 GByte to

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Add browsertests for two column edit conflict page

2016-11-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320613 Change subject: Add browsertests for two column edit conflict page .. Add browsertests for two column edit conflict page Bug:

[MediaWiki-commits] [Gerrit] integration/config[master]: Enable experimental browsertests for TwoColConflict extension

2016-11-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320595 Change subject: Enable experimental browsertests for TwoColConflict extension .. Enable experimental browsertests for

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Fix browsertests README

2016-11-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320585 Change subject: Fix browsertests README .. Fix browsertests README Change-Id: Id90b33de9d4a84e1bb1afb365c4fe06f3af24fe3 --- M

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Fix browsertests README

2016-11-09 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320586 Change subject: Fix browsertests README .. Fix browsertests README Change-Id: I4ec4c22a69b4cf896b0f5a719f47ea84b7faaec3 --- M

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Introduce hard limit for document byte size

2016-11-07 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320195 Change subject: Introduce hard limit for document byte size .. Introduce hard limit for document byte size Bug: T149780

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Run scenario that shows quantity precision issue

2016-11-07 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/320171 Change subject: Run scenario that shows quantity precision issue .. Run scenario that shows quantity precision issue Some recent

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Change labelling of selection options

2016-11-04 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/319865 Change subject: Change labelling of selection options .. Change labelling of selection options per discussion in T149097 Bug:

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Use MW StreamFile class to stream PDF file to browser

2016-11-04 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/319863 Change subject: Use MW StreamFile class to stream PDF file to browser .. Use MW StreamFile class to stream PDF file to browser

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Use MW function to generate Content-Disposition header

2016-11-03 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/319595 Change subject: Use MW function to generate Content-Disposition header .. Use MW function to generate Content-Disposition header

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Call checkUrlExtension() when doing pdf download

2016-11-02 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/319340 Change subject: Call checkUrlExtension() when doing pdf download .. Call checkUrlExtension() when doing pdf download Bug:

[MediaWiki-commits] [Gerrit] labs...grrrit[master]: 2ColConflict has been renamed to TwoColConflict

2016-10-31 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/318908 Change subject: 2ColConflict has been renamed to TwoColConflict .. 2ColConflict has been renamed to TwoColConflict Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Add margin to pin button

2016-10-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/318543 Change subject: Add margin to pin button .. Add margin to pin button This also fixes the "border-overlapping-issue" when

[MediaWiki-commits] [Gerrit] mediawiki/selenium[master]: Avoid endless recursion when environments.yml is missing

2016-10-27 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/318305 Change subject: Avoid endless recursion when environments.yml is missing .. Avoid endless recursion when environments.yml is

[MediaWiki-commits] [Gerrit] integration/config[master]: Turn on browsertests for ElectronPdfService extension

2016-10-27 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/318284 Change subject: Turn on browsertests for ElectronPdfService extension .. Turn on browsertests for ElectronPdfService extension

[MediaWiki-commits] [Gerrit] integration/config[master]: Enable experimental browsertests for ELectronPdfService

2016-10-26 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/318091 Change subject: Enable experimental browsertests for ELectronPdfService .. Enable experimental browsertests for

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Adding basic browsertests

2016-10-26 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/318088 Change subject: Adding basic browsertests .. Adding basic browsertests Change-Id: I080be6304e7be3cfadbead182a23302d6de9d72f ---

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Apply to view & purge action only

2016-10-24 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/317496 Change subject: Apply to view & purge action only .. Apply to view & purge action only also added additional check for potential

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Fix selecting betafeature in browsertests

2016-10-21 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/317161 Change subject: Fix selecting betafeature in browsertests .. Fix selecting betafeature in browsertests this broke due to

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Don't replace printable version link

2016-10-20 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/316961 Change subject: Don't replace printable version link .. Don't replace printable version link Removing functionality that

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: [WIP] Wiring up form and service

2016-10-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/316783 Change subject: [WIP] Wiring up form and service .. [WIP] Wiring up form and service Bug: T146895 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Refactor tooltips browsertests

2016-10-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315509 Change subject: Refactor tooltips browsertests .. Refactor tooltips browsertests - Applied the Given-When-Then rule Bug:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update pointer position attributes immediately

2016-10-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315506 Change subject: Update pointer position attributes immediately .. Update pointer position attributes immediately Update

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Remove obsolete step

2016-10-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315483 Change subject: Remove obsolete step .. Remove obsolete step Bug: T146276 Change-Id: I9b1b8e2aa87b88bd18d58a46834e6090284314ee

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: [WIP] Refactor timeline browsertests

2016-10-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315476 Change subject: [WIP] Refactor timeline browsertests .. [WIP] Refactor timeline browsertests - Applied the Given-When-Then rule

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use Chrome for selenium-Wikibase job

2016-10-11 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315231 Change subject: Use Chrome for selenium-Wikibase job .. Use Chrome for selenium-Wikibase job Bug: T147401 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Always apply data-pos attribute to pointers as well

2016-10-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315094 Change subject: Always apply data-pos attribute to pointers as well .. Always apply data-pos attribute to pointers as well

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use when_present instead of when_visible in badges test

2016-10-10 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/315058 Change subject: Use when_present instead of when_visible in badges test .. Use when_present instead of when_visible in badges

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: [WIP] Refactor history browsertests

2016-10-07 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/314706 Change subject: [WIP] Refactor history browsertests .. [WIP] Refactor history browsertests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Refactor help browsertest

2016-10-07 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/314696 Change subject: Refactor help browsertest .. Refactor help browsertest - Applied the Given-When-Then rule - Created alias of

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Refactor expand browsertests

2016-10-07 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/314692 Change subject: Refactor expand browsertests .. Refactor expand browsertests - Applied the Given-When-Then rule to scenarios

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Avoid duplicate "printable version" link

2016-09-29 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/313402 Change subject: Avoid duplicate "printable version" link .. Avoid duplicate "printable version" link When the Collection

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Use "page" instead of "article" for parameter and settings

2016-09-29 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/313398 Change subject: Use "page" instead of "article" for parameter and settings .. Use "page" instead of "article" for parameter and

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Always urlencode url parameter

2016-09-29 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/313395 Change subject: Always urlencode url parameter .. Always urlencode url parameter Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Use Electron service for printable version

2016-09-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/313212 Change subject: Use Electron service for printable version .. Use Electron service for printable version This is replacing the

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Add fixed padding for scrollbar

2016-09-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/313203 Change subject: Add fixed padding for scrollbar .. Add fixed padding for scrollbar This is not very nice but the simplest I was

[MediaWiki-commits] [Gerrit] labs...grrrit[master]: Add 2ColConflict and ElectronPdfService extensions

2016-09-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/311414 Change subject: Add 2ColConflict and ElectronPdfService extensions .. Add 2ColConflict and ElectronPdfService extensions Should

[MediaWiki-commits] [Gerrit] integration/config[master]: Add ElectronPdfService extension to integration

2016-09-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/311412 Change subject: Add ElectronPdfService extension to integration .. Add ElectronPdfService extension to integration Bug: T142201

[MediaWiki-commits] [Gerrit] mediawiki...ElectronPdfService[master]: Create boilerplate extension for Electron PDF Service

2016-09-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/311411 Change subject: Create boilerplate extension for Electron PDF Service .. Create boilerplate extension for Electron PDF Service

[MediaWiki-commits] [Gerrit] integration/config[master]: Add 2ColConflict extension to integration

2016-09-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/311408 Change subject: Add 2ColConflict extension to integration .. Add 2ColConflict extension to integration Bug: T145411 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...2ColConflict[master]: Create boilerplate extension for side-by-side edit merge screen

2016-09-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/311404 Change subject: Create boilerplate extension for side-by-side edit merge screen .. Create boilerplate extension for side-by-side

[MediaWiki-commits] [Gerrit] analytics...toolkit-analyzer[master]: Remove redundant cast to snak

2016-09-19 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Remove redundant cast to snak .. Remove redundant cast to snak Change-Id: Ic6b277e7b614c2757338f66c0cf2ef76e5ac9c0b --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix empty references removal

2016-09-16 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Fix empty references removal .. Fix empty references removal Change-Id: I4d4c88f07b4ae06118c7c67e56711a63b7ea15e4 --- M

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Adjust pin button tooltip

2016-09-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/310298 Change subject: Adjust pin button tooltip .. Adjust pin button tooltip Bug: T145068 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Expand Revision Slider when user sctivates pin button

2016-09-13 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/310297 Change subject: Expand Revision Slider when user sctivates pin button .. Expand Revision Slider when user sctivates pin button

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Use firefox for integration tests

2016-09-05 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/308572 Change subject: Use firefox for integration tests .. Use firefox for integration tests Change-Id:

[MediaWiki-commits] [Gerrit] integration/config[master]: Remove job selenium-Wikidata

2016-09-01 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/307940 Change subject: Remove job selenium-Wikidata .. Remove job selenium-Wikidata Bug: T144487 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Attempt to make reference test more stable

2016-09-01 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Attempt to make reference test more stable .. Attempt to make reference test more stable Bug: T144190 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Attempt to make reference test more stable

2016-08-31 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/307771 Change subject: Attempt to make reference test more stable .. Attempt to make reference test more stable Bug: T144190 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DNM] Revert "Remove browsertests that need to create proper...

2016-08-31 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/307696 Change subject: [DNM] Revert "Remove browsertests that need to create properties from integration" .. [DNM] Revert "Remove

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove browsertests that need to create properties from inte...

2016-08-30 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/307491 Change subject: Remove browsertests that need to create properties from integration .. Remove browsertests that need to create

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Using user factory for loggin in

2016-08-26 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Using user factory for loggin in .. Using user factory for loggin in Change-Id: Ie1bd00edf74e7c7c2115a986bf1bcf4f62dfea09 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Update browser tests from most recent wikidata/browsertests

2016-08-26 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Update browser tests from most recent wikidata/browsertests .. Update browser tests from most recent wikidata/browsertests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Add certain tests to integration

2016-07-29 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301764 Change subject: [WIP] Add certain tests to integration .. [WIP] Add certain tests to integration Change-Id:

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: Fix off-by-one error in badge tests

2016-07-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301598 Change subject: Fix off-by-one error in badge tests .. Fix off-by-one error in badge tests The tests should select the 1. and 2.

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: [DNM] Making reference browsertests more robust

2016-07-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301595 Change subject: [DNM] Making reference browsertests more robust .. [DNM] Making reference browsertests more robust Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add delete_item feature to integration

2016-07-28 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301589 Change subject: Add delete_item feature to integration .. Add delete_item feature to integration Change-Id:

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: Run browsertests on test.wikidata.org

2016-07-27 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301378 Change subject: Run browsertests on test.wikidata.org .. Run browsertests on test.wikidata.org Change-Id:

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: Do not fail tests when ajax_requests are stuck

2016-07-27 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301376 Change subject: Do not fail tests when ajax_requests are stuck .. Do not fail tests when ajax_requests are stuck Changing the

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: Load modules relative to file

2016-07-26 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/301079 Change subject: Load modules relative to file .. Load modules relative to file This should work regardless from which directory

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: [DNM] Run sitelink tests on test.wikidata.org

2016-07-25 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/300888 Change subject: [DNM] Run sitelink tests on test.wikidata.org .. [DNM] Run sitelink tests on test.wikidata.org Change-Id:

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: Avoid logging in when not necessary

2016-07-25 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/300885 Change subject: Avoid logging in when not necessary .. Avoid logging in when not necessary Change-Id:

[MediaWiki-commits] [Gerrit] wikidata/browsertests[master]: Remove unused method from entity_module

2016-07-25 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/300876 Change subject: Remove unused method from entity_module .. Remove unused method from entity_module Change-Id:

[MediaWiki-commits] [Gerrit] Migration of browsertests* Jenkins jobs to selenium* jobs - change (mediawiki...Wikibase)

2016-05-25 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has submitted this change and it was merged. Change subject: Migration of browsertests* Jenkins jobs to selenium* jobs .. Migration of browsertests* Jenkins jobs to selenium* jobs selenium* jobs are a new

[MediaWiki-commits] [Gerrit] [WIP] Add label.feature - change (mediawiki...Wikibase)

2016-05-23 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/289846 Change subject: [WIP] Add label.feature .. [WIP] Add label.feature Change-Id: I53351d9fc7219d095e2aa44fe4f31c18bbea103e --- M

[MediaWiki-commits] [Gerrit] Remove Adrian from list of notified persons (per request) - change (integration/config)

2015-04-21 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/205561 Change subject: Remove Adrian from list of notified persons (per request) .. Remove Adrian from list of notified persons (per

[MediaWiki-commits] [Gerrit] Include ValueView version 0.14.0 - change (mediawiki...Wikibase)

2015-03-12 Thread Tobias Gritschacher (Code Review)
Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/196219 Change subject: Include ValueView version 0.14.0 .. Include ValueView version 0.14.0 Change-Id:

  1   2   3   4   5   6   7   8   9   10   >