[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make newExternalLB() public to match newMainLB()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312466 Change subject: Make newExternalLB() public to match newMainLB() .. Make newExternalLB() public to match newMainLB() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Inject "srvCache" and local DB connections into LockManagerDB

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Inject "srvCache" and local DB connections into LockManagerDB .. Inject "srvCache" and local DB connections into LockManagerDB * Also simplified the

[MediaWiki-commits] [Gerrit] mediawiki...OpenID[master]: Use openConnection() instead of making a new LoadBalancer

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312465 Change subject: Use openConnection() instead of making a new LoadBalancer .. Use openConnection() instead of making a new LoadBalancer

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move FileBackendMultiWrite to /libs

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312464 Change subject: Move FileBackendMultiWrite to /libs .. Move FileBackendMultiWrite to /libs Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Create ShellExec service

2016-09-22 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/312463 Change subject: [WIP] Create ShellExec service .. [WIP] Create ShellExec service To replace most of the wfShell* global functions.

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.20]: Call setTransactionTicket() on DeferredUpdates sub-queue ite...

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Call setTransactionTicket() on DeferredUpdates sub-queue items too .. Call setTransactionTicket() on DeferredUpdates sub-queue items too This should

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Reduce queries in CategoryViewer via addGoodLinkObjFromRow()

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Reduce queries in CategoryViewer via addGoodLinkObjFromRow() .. Reduce queries in CategoryViewer via addGoodLinkObjFromRow() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Call setTransactionTicket() on DeferredUpdates sub-queue ite...

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Call setTransactionTicket() on DeferredUpdates sub-queue items too .. Call setTransactionTicket() on DeferredUpdates sub-queue items too This should

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add IMaintainableDatabase for non-OLTP type methods

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312462 Change subject: Add IMaintainableDatabase for non-OLTP type methods .. Add IMaintainableDatabase for non-OLTP type methods Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: upload storage: finish esams (cp3048+cp3049)

2016-09-22 Thread BBlack (Code Review)
BBlack has submitted this change and it was merged. Change subject: upload storage: finish esams (cp3048+cp3049) .. upload storage: finish esams (cp3048+cp3049) Bug: T145661 Change-Id: I7269c9b1630410de1a78ad440b3583c94cf359a4

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Minor installer/upgrader cleanups

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312461 Change subject: Minor installer/upgrader cleanups .. Minor installer/upgrader cleanups Change-Id:

[MediaWiki-commits] [Gerrit] wikimedia...SmashPig[master]: Add placeholder class for NotificationOfFraud messages

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312460 Change subject: Add placeholder class for NotificationOfFraud messages .. Add placeholder class for NotificationOfFraud messages Not doing

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused Database::isView()/clearViewsCache() methods

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312459 Change subject: Remove unused Database::isView()/clearViewsCache() methods .. Remove unused Database::isView()/clearViewsCache() methods

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Reduce queries in CategoryViewer via addGoodLinkObjFromRow()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312458 Change subject: Reduce queries in CategoryViewer via addGoodLinkObjFromRow() .. Reduce queries in CategoryViewer via

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: Follow-up Ide89c59f: Update ferm rules too

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312455 Change subject: tcpircbot: Follow-up Ide89c59f: Update ferm rules too .. tcpircbot: Follow-up Ide89c59f: Update ferm rules too Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: remove localhost from ferm rule

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312456 Change subject: tcpircbot: remove localhost from ferm rule .. tcpircbot: remove localhost from ferm rule It's not needed, ferm accepts all

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: Follow-up Ide89c59f: Fix missing CIDR prefix on p...

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312457 Change subject: tcpircbot: Follow-up Ide89c59f: Fix missing CIDR prefix on puppetmaster2001 .. tcpircbot: Follow-up Ide89c59f: Fix missing

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tcpircbot: update comment detailing each IP in the ferm rule

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312454 Change subject: tcpircbot: update comment detailing each IP in the ferm rule .. tcpircbot: update comment detailing each IP in the ferm

[MediaWiki-commits] [Gerrit] mediawiki...GlobalUsage[master]: Use provided transaction ticket in onLinksUpdateComplete()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312453 Change subject: Use provided transaction ticket in onLinksUpdateComplete() .. Use provided transaction ticket in onLinksUpdateComplete()

[MediaWiki-commits] [Gerrit] mediawiki...GeoData[master]: Use provided transaction ticket in onLinksUpdateComplete()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312452 Change subject: Use provided transaction ticket in onLinksUpdateComplete() .. Use provided transaction ticket in onLinksUpdateComplete()

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add transaction ticket to LinksUpdateComplete hook

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312451 Change subject: Add transaction ticket to LinksUpdateComplete hook .. Add transaction ticket to LinksUpdateComplete hook This lets

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[wmf/1.28.0-wmf.20]: Fix fatal

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix fatal .. Fix fatal The base class has no constructor since c64c3ef9a8f33d89df9a801efa6c1d498f8722b1 Bug: T146440 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[master]: Fix fatal

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix fatal .. Fix fatal The base class has no constructor since c64c3ef9a8f33d89df9a801efa6c1d498f8722b1 Bug: T146440 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[wmf/1.28.0-wmf.20]: Fix fatal

2016-09-22 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/312450 Change subject: Fix fatal .. Fix fatal The base class has no constructor since c64c3ef9a8f33d89df9a801efa6c1d498f8722b1 Bug: T146440

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove see comment

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove see comment .. Remove see comment Change-Id: I58fcd682dba6c778c0975baf67a6b87f36b1aff2 --- M includes/libs/rdbms/database/Database.php 1 file

[MediaWiki-commits] [Gerrit] mediawiki...SecurePoll[master]: Fix fatal

2016-09-22 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/312449 Change subject: Fix fatal .. Fix fatal The base class has no constructor since c64c3ef9a8f33d89df9a801efa6c1d498f8722b1 Bug: T146440

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Remove use of a removed function

2016-09-22 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/312448 Change subject: Remove use of a removed function .. Remove use of a removed function Change-Id: Iac8bec0a0a2625e40c5c70a715ffb4784224f164 ---

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: CodeSniffer fixes

2016-09-22 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/312446 Change subject: CodeSniffer fixes .. CodeSniffer fixes Change-Id: I8bdcd2250bd3163fe40ce4685eb04bffe53afdca --- M

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: Minor fixes

2016-09-22 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/312447 Change subject: Minor fixes .. Minor fixes * Annotations * Deprecated functions * Namespace tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add a continuation button to ApiSandbox

2016-09-22 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/312445 Change subject: Add a continuation button to ApiSandbox .. Add a continuation button to ApiSandbox Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up 3ca658ed, e3192e2d: avoid JS errors when checking ...

2016-09-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/312444 Change subject: Follow-up 3ca658ed, e3192e2d: avoid JS errors when checking for rAF .. Follow-up 3ca658ed, e3192e2d: avoid JS errors when

[MediaWiki-commits] [Gerrit] operations/puppet[production]: upload storage: transition cp3046+cp3047

2016-09-22 Thread BBlack (Code Review)
BBlack has submitted this change and it was merged. Change subject: upload storage: transition cp3046+cp3047 .. upload storage: transition cp3046+cp3047 Bug: T145661 Change-Id: Iaf7641d4725a6e0c9940859c79d0ff44a066a02f --- A

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Eradicate Stomp from crm repo

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312443 Change subject: Eradicate Stomp from crm repo .. Eradicate Stomp from crm repo Well, except for composer.lock, since DI still has a dependency

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Stop mirroring to stomp from audit processors

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312442 Change subject: Stop mirroring to stomp from audit processors .. Stop mirroring to stomp from audit processors Not sure if those try/catch

[MediaWiki-commits] [Gerrit] wikimedia...crm[master]: Remove obsolete and broken wmf_unsubscribe module

2016-09-22 Thread Ejegg (Code Review)
Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/312441 Change subject: Remove obsolete and broken wmf_unsubscribe module .. Remove obsolete and broken wmf_unsubscribe module This is now handled by

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove phantom config variables

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: Remove phantom config variables .. Hygiene: Remove phantom config variables These config option dates back to mobile uploads (remember that?!)

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove pre-1.25 API compatibility code

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove pre-1.25 API compatibility code .. Remove pre-1.25 API compatibility code Since this extension uses extension.json, it already requires 1.25+ so

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Remove BogusMobileContext

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: Remove BogusMobileContext .. Hygiene: Remove BogusMobileContext The BogusMobileContext and MobileContext::setInstanceForTesting method were used

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Name singleton overriding methods more clearly

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Name singleton overriding methods more clearly .. Name singleton overriding methods more clearly MobileContext::setInstance is only used in PHPUnit test

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove MFPageActions/MFEnableSiteNotice vars

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove MFPageActions/MFEnableSiteNotice vars .. Remove MFPageActions/MFEnableSiteNotice vars The MFPageActions and MFEnableSiteNotice config variables

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Rename includes/Services to includes/services for consistency

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Rename includes/Services to includes/services for consistency .. Rename includes/Services to includes/services for consistency Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()"

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()" .. Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()" Apparently it is possible

[MediaWiki-commits] [Gerrit] wikimedia...golden[master]: Ungroup last_action_country and first_visits_country

2016-09-22 Thread Chelsyx (Code Review)
Chelsyx has submitted this change and it was merged. Change subject: Ungroup last_action_country and first_visits_country .. Ungroup last_action_country and first_visits_country I checked the function wmf::rewrite_conditional

[MediaWiki-commits] [Gerrit] wikimedia...golden[master]: Ungroup last_action_country and first_visits_country

2016-09-22 Thread Chelsyx (Code Review)
Chelsyx has uploaded a new change for review. https://gerrit.wikimedia.org/r/312440 Change subject: Ungroup last_action_country and first_visits_country .. Ungroup last_action_country and first_visits_country I checked the

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()"

2016-09-22 Thread Legoktm (Code Review)
Legoktm has uploaded a new change for review. https://gerrit.wikimedia.org/r/312439 Change subject: Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()" .. Revert "Move wfEscapeWikiText() to Parser::escapeWikitext()"

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove see comment

2016-09-22 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/312438 Change subject: Remove see comment .. Remove see comment Change-Id: I58fcd682dba6c778c0975baf67a6b87f36b1aff2 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Cleanup deprecated MobileFrontend variables

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: Cleanup deprecated MobileFrontend variables .. Cleanup deprecated MobileFrontend variables * Remove no longer used central notice and upload config

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Scap: Bump installed version to 3.3.0-1

2016-09-22 Thread Thcipriani (Code Review)
Thcipriani has uploaded a new change for review. https://gerrit.wikimedia.org/r/312437 Change subject: Scap: Bump installed version to 3.3.0-1 .. Scap: Bump installed version to 3.3.0-1 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: UsersLinkedToSpecificGroup

2016-09-22 Thread Kmuthu (Code Review)
Kmuthu has uploaded a new change for review. https://gerrit.wikimedia.org/r/312436 Change subject: UsersLinkedToSpecificGroup .. UsersLinkedToSpecificGroup Users routed to the group they are added/removed. Bug: T55860

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[wmf/1.28.0-wmf.20]: Fix I9839283c: new_text is actually a Content object

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix I9839283c: new_text is actually a Content object .. Fix I9839283c: new_text is actually a Content object Bug: T146423 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.20]: Call setTransactionTicket() on DeferredUpdates sub-queue ite...

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312435 Change subject: Call setTransactionTicket() on DeferredUpdates sub-queue items too .. Call setTransactionTicket() on DeferredUpdates

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Call setTransactionTicket() on DeferredUpdates sub-queue ite...

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312434 Change subject: Call setTransactionTicket() on DeferredUpdates sub-queue items too .. Call setTransactionTicket() on DeferredUpdates

[MediaWiki-commits] [Gerrit] mediawiki...ArticleRatings[master]: I18n capitalization tweaks for consistency

2016-09-22 Thread SamanthaNguyen (Code Review)
SamanthaNguyen has submitted this change and it was merged. Change subject: I18n capitalization tweaks for consistency .. I18n capitalization tweaks for consistency Bug: T146246 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Use native Set where possible instead of string keys

2016-09-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/312433 Change subject: mw.loader: Use native Set where possible instead of string keys .. mw.loader: Use native Set where possible instead of string

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Initiate Hovercards A/B test on ruwiki and itwiki

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has submitted this change and it was merged. Change subject: Initiate Hovercards A/B test on ruwiki and itwiki .. Initiate Hovercards A/B test on ruwiki and itwiki ON rate of 10% and 20%, respectively. EL sampling

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Rename includes/Services to include/services for consistency

2016-09-22 Thread Reedy (Code Review)
Reedy has uploaded a new change for review. https://gerrit.wikimedia.org/r/312432 Change subject: Rename includes/Services to include/services for consistency .. Rename includes/Services to include/services for consistency

[MediaWiki-commits] [Gerrit] mediawiki...ArticleRatings[master]: Delete the old PHP i18n file for good

2016-09-22 Thread SamanthaNguyen (Code Review)
SamanthaNguyen has submitted this change and it was merged. Change subject: Delete the old PHP i18n file for good .. Delete the old PHP i18n file for good Bug: T145313 Change-Id: I9bd3062132c71e9865c9aad8bded54f8918b3a40 --- D

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Support multiple limits and arbitrary periods in account cre...

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Support multiple limits and arbitrary periods in account creation throttle .. Support multiple limits and arbitrary periods in account creation throttle

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.20]: Follow-up 764cd6a1: unbreak quiet buttons

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Follow-up 764cd6a1: unbreak quiet buttons .. Follow-up 764cd6a1: unbreak quiet buttons Quiet buttons are supposed to be initially gray, not initially

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Improve documentation for render methods

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Improve documentation for render methods .. Improve documentation for render methods The parameter types are incorrect and this leads to confusion Use $

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Beta: Allow displaying Related Articles in the footer

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Beta: Allow displaying Related Articles in the footer .. Beta: Allow displaying Related Articles in the footer Even if 'minerva' is blacklisted, show

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix doc typo for wasConnectionError()

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix doc typo for wasConnectionError() .. Fix doc typo for wasConnectionError() Change-Id: I70eaeb630e2a4bb8f2940c2dcc938f7305014d48 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: upload storage: transition cp3044+cp3045

2016-09-22 Thread BBlack (Code Review)
BBlack has submitted this change and it was merged. Change subject: upload storage: transition cp3044+cp3045 .. upload storage: transition cp3044+cp3045 Bug: T145661 Change-Id: Idd813ab0ccb46957328513cfac316c39834db66a --- A

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Split out new ObjectCache::newWANCacheFromParams() method

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Split out new ObjectCache::newWANCacheFromParams() method .. Split out new ObjectCache::newWANCacheFromParams() method Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.20]: Add DBConnRef sanity check to LoadBalancer::reuseConnection()

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add DBConnRef sanity check to LoadBalancer::reuseConnection() .. Add DBConnRef sanity check to LoadBalancer::reuseConnection() Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Improve documentation/parameter names of openPopup method

2016-09-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312431 Change subject: Improve documentation/parameter names of openPopup method .. Improve documentation/parameter names of openPopup method

[MediaWiki-commits] [Gerrit] analytics/dashiki[master]: Upgrade to semantic 2 everywhere

2016-09-22 Thread Milimetric (Code Review)
Milimetric has uploaded a new change for review. https://gerrit.wikimedia.org/r/312430 Change subject: Upgrade to semantic 2 everywhere .. Upgrade to semantic 2 everywhere * upgrades all metrics-by-project to use semantic

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.28.0-wmf.20]: Add DBConnRef sanity check to LoadBalancer::reuseConnection()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312429 Change subject: Add DBConnRef sanity check to LoadBalancer::reuseConnection() .. Add DBConnRef sanity check to

[MediaWiki-commits] [Gerrit] mediawiki...DonationInterface[master]: Remove pre-1.25 API compatibility code

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Remove pre-1.25 API compatibility code .. Remove pre-1.25 API compatibility code Since this extension uses extension.json, it already requires 1.25+ so

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove redundant code from FeedView

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: remove redundant code from FeedView .. Hygiene: remove redundant code from FeedView Remove programmatic configuration of minColumnWidth. This

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Simplify and clean up FileBackend exceptions

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Simplify and clean up FileBackend exceptions .. Simplify and clean up FileBackend exceptions Use standard exceptions for unexpected errors and remove

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add DBConnRef sanity check to LoadBalancer::reuseConnection()

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Add DBConnRef sanity check to LoadBalancer::reuseConnection() .. Add DBConnRef sanity check to LoadBalancer::reuseConnection() Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: add legal contactgroup to legal footer checks

2016-09-22 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: icinga: add legal contactgroup to legal footer checks .. icinga: add legal contactgroup to legal footer checks Let the new legal contact group get email

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Improve documentation for render methods

2016-09-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312425 Change subject: Improve documentation for render methods .. Improve documentation for render methods The parameter types are incorrect and

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Not necessary for private methods to be globally av...

2016-09-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312428 Change subject: Hygiene: Not necessary for private methods to be globally available .. Hygiene: Not necessary for private methods to be

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Only allow calls to closePopup on an active link

2016-09-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312427 Change subject: Hygiene: Only allow calls to closePopup on an active link .. Hygiene: Only allow calls to closePopup on an active link

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: Add set and get methods for active link

2016-09-22 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/312426 Change subject: Hygiene: Add set and get methods for active link .. Hygiene: Add set and get methods for active link Named functions help

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix I9839283c: new_text is actually a Content object

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Fix I9839283c: new_text is actually a Content object .. Fix I9839283c: new_text is actually a Content object Bug: T146423 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: add legal contactgroup to legal footer checks

2016-09-22 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/312424 Change subject: icinga: add legal contactgroup to legal footer checks .. icinga: add legal contactgroup to legal footer checks Let the new

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[wmf/1.28.0-wmf.20]: Fix I9839283c: new_text is actually a Content object

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312423 Change subject: Fix I9839283c: new_text is actually a Content object .. Fix I9839283c: new_text is actually a Content object Bug: T146423

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Output a better deprecated message

2016-09-22 Thread Bmansurov (Code Review)
Bmansurov has uploaded a new change for review. https://gerrit.wikimedia.org/r/312422 Change subject: Output a better deprecated message .. Output a better deprecated message Make deprecated instructions clearer by telling

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add DBConnRef sanity check to LoadBalancer::reuseConnection()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312421 Change subject: Add DBConnRef sanity check to LoadBalancer::reuseConnection() .. Add DBConnRef sanity check to

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: move FeedViewCallback to FeedAdapter

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: move FeedViewCallback to FeedAdapter .. Hygiene: move FeedViewCallback to FeedAdapter Change-Id: Id9f302237469637405de51c4bd413cf311186bb0 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: add contactgroup for legal

2016-09-22 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. Change subject: icinga: add contactgroup for legal .. icinga: add contactgroup for legal Bug: T146227 Change-Id: I2ef1d30f98891c322c9b9a64fa0a7bbbdb1d0357 --- M

[MediaWiki-commits] [Gerrit] operations/puppet[production]: icinga: add contactgroup for legal

2016-09-22 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/312420 Change subject: icinga: add contactgroup for legal .. icinga: add contactgroup for legal Bug: T146227 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix doc typo for wasConnectionError()

2016-09-22 Thread Aaron Schulz (Code Review)
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/312419 Change subject: Fix doc typo for wasConnectionError() .. Fix doc typo for wasConnectionError() Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: encapsulate NewsListCardView's callback

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: encapsulate NewsListCardView's callback .. Hygiene: encapsulate NewsListCardView's callback Change-Id: I63539c2a7f2c351f8da0b1c0b46e1764fc224419

[MediaWiki-commits] [Gerrit] mediawiki...CiteThisPage[master]: Rewrite to avoid messing with global state

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Rewrite to avoid messing with global state .. Rewrite to avoid messing with global state The main goal of this rewrite is to not use or mess with any

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make MigrateFileRepoLayout use getErrors()

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Make MigrateFileRepoLayout use getErrors() .. Make MigrateFileRepoLayout use getErrors() Change-Id: I5281c4ded9eba42eccaf5a67e809a0175fa057ce --- M

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Fix I9839283c: new_text is actually a Content object

2016-09-22 Thread Alex Monk (Code Review)
Alex Monk has uploaded a new change for review. https://gerrit.wikimedia.org/r/312418 Change subject: Fix I9839283c: new_text is actually a Content object .. Fix I9839283c: new_text is actually a Content object Bug: T146423

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move wfEscapeWikiText() to Parser::escapeWikitext()

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Move wfEscapeWikiText() to Parser::escapeWikitext() .. Move wfEscapeWikiText() to Parser::escapeWikitext() wfEscapeWikiText() used $wgEnableMagicLinks,

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: encapsulate SearchCardView's callback

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: encapsulate SearchCardView's callback .. Hygiene: encapsulate SearchCardView's callback Change-Id: Icf476bca12b3b8901acd781e2e1283770a8c93d8 ---

[MediaWiki-commits] [Gerrit] integration/config[master]: Limit performance jobs IRC notification channels

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Limit performance jobs IRC notification channels .. Limit performance jobs IRC notification channels The performance-webpagetest-wpt-org job is reporting

[MediaWiki-commits] [Gerrit] mediawiki...CentralNotice[master]: jQuery usage tweaks

2016-09-22 Thread Ejegg (Code Review)
Ejegg has submitted this change and it was merged. Change subject: jQuery usage tweaks .. jQuery usage tweaks Use .text() instead of .html() where unneeded, break up node creation and setting value instead of concatenating

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Generalize core schema docs in DatabasePostgres

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Generalize core schema docs in DatabasePostgres .. Generalize core schema docs in DatabasePostgres Change-Id: I52e64867c1533c50406623d5bc121c1e4da2459a

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.28.0-wmf.20]: Allow readable queries for externaldata in geojson

2016-09-22 Thread MaxSem (Code Review)
MaxSem has uploaded a new change for review. https://gerrit.wikimedia.org/r/312406 Change subject: Allow readable queries for externaldata in geojson .. Allow readable queries for externaldata in geojson TBD: Should we do

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add 'message-format' log channel

2016-09-22 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/312404 Change subject: Add 'message-format' log channel .. Add 'message-format' log channel Logging is added in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Log when Message::__toString has an unexpected format

2016-09-22 Thread Code Review
Gergő Tisza has uploaded a new change for review. https://gerrit.wikimedia.org/r/312401 Change subject: Log when Message::__toString has an unexpected format .. Log when Message::__toString has an unexpected format Message

[MediaWiki-commits] [Gerrit] operations/puppet[production]: upload storage: transition cp3038+cp3039

2016-09-22 Thread BBlack (Code Review)
BBlack has submitted this change and it was merged. Change subject: upload storage: transition cp3038+cp3039 .. upload storage: transition cp3038+cp3039 Bug: T145661 Change-Id: I232ad2ebb368be8fe44a5cab630f57c4ae37283e --- A

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: move FeaturedImageCardView callback

2016-09-22 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. Change subject: Hygiene: move FeaturedImageCardView callback .. Hygiene: move FeaturedImageCardView callback Encapsulate FeaturedImageCardView's callback as

  1   2   3   4   >