[MediaWiki-commits] [Gerrit] 'wikpedia' typo in API example - change (mediawiki...CentralNotice)

2015-12-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/256637 Change subject: 'wikpedia' typo in API example .. 'wikpedia' typo in API example To see the problem, visit

[MediaWiki-commits] [Gerrit] Add helloWorld.php sample maintenance script - change (mediawiki/core)

2015-11-20 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/254583 Change subject: Add helloWorld.php sample maintenance script .. Add helloWorld.php sample maintenance script It doesn't hurt and it makes it

[MediaWiki-commits] [Gerrit] Rename README to README.md - change (mediawiki...BoilerPlate)

2015-11-10 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/252373 Change subject: Rename README to README.md .. Rename README to README.md This way

[MediaWiki-commits] [Gerrit] Allow AUTHOR|CREDITS with .{media, }wiki extension - change (mediawiki/core)

2015-11-05 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/251440 Change subject: Allow AUTHOR|CREDITS with .{media,}wiki extension .. Allow AUTHOR|CREDITS with .{media,}wiki extension With this fix,

[MediaWiki-commits] [Gerrit] Add example of help for all query submodules - change (mediawiki/core)

2015-11-04 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/251190 Change subject: Add example of help for all query submodules .. Add example of help for all query submodules It's useful and shows difference

[MediaWiki-commits] [Gerrit] Allow empty lang parameter - change (mediawiki...SyntaxHighlight_GeSHi)

2015-10-29 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/249941 Change subject: Allow empty lang parameter .. Allow empty lang parameter This did not cause visible errors or warnings, it just added the page

[MediaWiki-commits] [Gerrit] Rename to CREDITS.mediawiki, add symlink - change (mediawiki/core)

2015-10-27 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/249307 Change subject: Rename to CREDITS.mediawiki, add symlink .. Rename to CREDITS.mediawiki, add symlink Diffusion and GitHub don't render CREDITS

[MediaWiki-commits] [Gerrit] [WIP] Structure the sidebar to be more Vector-like - change (mediawiki...Blueprint)

2015-10-01 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/243056 Change subject: [WIP] Structure the sidebar to be more Vector-like .. [WIP] Structure the sidebar to be more Vector-like Separate lists for

[MediaWiki-commits] [Gerrit] Output dataAfterContent like other skins - change (mediawiki...Blueprint)

2015-09-29 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/242372 Change subject: Output dataAfterContent like other skins .. Output dataAfterContent like other skins Other skins output this piece of data at

[MediaWiki-commits] [Gerrit] Revert "Localisation updates from https://translatewiki.net." - change (mediawiki...Blueprint)

2015-09-29 Thread Spage (Code Review)
Spage has submitted this change and it was merged. Change subject: Revert "Localisation updates from https://translatewiki.net.; .. Revert "Localisation updates from https://translatewiki.net.; This reverts commit

[MediaWiki-commits] [Gerrit] Add support for PHP CodeSniffer checks - change (mediawiki...Blueprint)

2015-09-28 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/242038 Change subject: Add support for PHP CodeSniffer checks .. Add support for PHP CodeSniffer checks There were no errors or warnings, once

[MediaWiki-commits] [Gerrit] PHP CodeSniffer tweaks - change (mediawiki...BoilerPlate)

2015-09-28 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/242046 Change subject: PHP CodeSniffer tweaks .. PHP CodeSniffer tweaks Update composer.json and phpcs.xml per Legoktm's comments in I54025d5.

[MediaWiki-commits] [Gerrit] Ensure class within personal_urls is a string - change (mediawiki...Blueprint)

2015-09-23 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/240632 Change subject: Ensure class within personal_urls is a string .. Ensure class within personal_urls is a string The personal_urls array items

[MediaWiki-commits] [Gerrit] Add 'APIs' search profile to mw.org Special:Search - change (mediawiki...WikimediaMessages)

2015-09-22 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/240046 Change subject: Add 'APIs' search profile to mw.org Special:Search .. Add 'APIs' search profile to mw.org Special:Search In a

[MediaWiki-commits] [Gerrit] Minor BLueprint sidebar CSS cleanup. - change (mediawiki...Blueprint)

2015-09-20 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/239661 Change subject: Minor BLueprint sidebar CSS cleanup. .. Minor BLueprint sidebar CSS cleanup. Specify .side-menu-heading margins in a single

[MediaWiki-commits] [Gerrit] Rename files to ext.boilerPlate so jenkins passes - change (mediawiki...BoilerPlate)

2015-09-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/237057 Change subject: Rename files to ext.boilerPlate so jenkins passes .. Rename files to ext.boilerPlate so jenkins passes

[MediaWiki-commits] [Gerrit] Remove unused file, update README - change (mediawiki...BoilerPlate)

2015-09-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/237033 Change subject: Remove unused file, update README .. Remove unused file, update README SpecialIncludable.php is still in extensions/examples.

[MediaWiki-commits] [Gerrit] Explain npm and composer setup better in README - change (mediawiki...BoilerPlate)

2015-09-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/237058 Change subject: Explain npm and composer setup better in README .. Explain npm and composer setup better in README Change-Id:

[MediaWiki-commits] [Gerrit] Add extension.json, reduce PHP entry point. - change (mediawiki...BoilerPlate)

2015-09-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/237066 Change subject: Add extension.json, reduce PHP entry point. .. Add extension.json, reduce PHP entry point. This is I629e04f2 applied to new

[MediaWiki-commits] [Gerrit] Don't cache "current" page in left nav - change (mediawiki...Blueprint)

2015-09-01 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/235200 Change subject: Don't cache "current" page in left nav .. Don't cache "current" page in left nav Bug: T111010 Change-Id:

[MediaWiki-commits] [Gerrit] Rename mediawiki.log.js so anti-virus won't delete - change (mediawiki/core)

2015-08-27 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/234463 Change subject: Rename mediawiki.log.js so anti-virus won't delete .. Rename mediawiki.log.js so anti-virus won't delete Comodo Antivirus

[MediaWiki-commits] [Gerrit] Improve docs/lua.wiki - change (mediawiki...Wikibase)

2015-08-10 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/230717 Change subject: Improve docs/lua.wiki .. Improve docs/lua.wiki Fix some typos that are already fixed in

[MediaWiki-commits] [Gerrit] Remove leftover addModuleStyles() call - change (mediawiki...Blueprint)

2015-08-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/228613 Change subject: Remove leftover addModuleStyles() call .. Remove leftover addModuleStyles() call It's loading non-existent

[MediaWiki-commits] [Gerrit] Simply return from entry point. - change (mediawiki...Blueprint)

2015-08-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/228767 Change subject: Simply return from entry point. .. Simply return from entry point. Bug: T107628 Change-Id:

[MediaWiki-commits] [Gerrit] promote BoilerPlate files to top level - change (mediawiki...BoilerPlate)

2015-07-21 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/226258 Change subject: promote BoilerPlate files to top level .. promote BoilerPlate files to top level So BoilerPlate acts like other extensions.

[MediaWiki-commits] [Gerrit] remove BoilerPlate files now in separate extension - change (mediawiki...examples)

2015-07-21 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/226262 Change subject: remove BoilerPlate files now in separate extension .. remove BoilerPlate files now in separate extension BoilerPlate needs to

[MediaWiki-commits] [Gerrit] Latest test entry points - change (mediawiki...BoilerPlate)

2015-07-21 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/226259 Change subject: Latest test entry points .. Latest test entry points Don't require grunt, instead test: jshint . jscs . README points to

[MediaWiki-commits] [Gerrit] Add id to Parser tags/hooks headings - change (mediawiki/core)

2015-07-20 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/226035 Change subject: Add id to Parser tags/hooks headings .. Add id to Parser tags/hooks headings All h2 headings in Special:Version had an id

[MediaWiki-commits] [Gerrit] Improve Doxygen template used by mwdocgen.php - change (mediawiki/core)

2015-07-17 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/225371 Change subject: Improve Doxygen template used by mwdocgen.php .. Improve Doxygen template used by mwdocgen.php Document the template's

[MediaWiki-commits] [Gerrit] phpcs fixups - change (mediawiki...examples)

2015-07-14 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/224654 Change subject: phpcs fixups .. phpcs fixups The directory now passes phpcs apart from 'Duplicate class name SpecialHelloWorld' warnings.

[MediaWiki-commits] [Gerrit] API: mention how to get page property names - change (mediawiki/core)

2015-07-13 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/224497 Change subject: API: mention how to get page property names .. API: mention how to get page property names Mention

[MediaWiki-commits] [Gerrit] API: improve pageswithprop explanation - change (mediawiki/core)

2015-07-13 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/224498 Change subject: API: improve pageswithprop explanation .. API: improve pageswithprop explanation Minor rephrase. Change-Id:

[MediaWiki-commits] [Gerrit] API: request all pagepropnames in example API call - change (mediawiki/core)

2015-07-13 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/224518 Change subject: API: request all pagepropnames in example API call .. API: request all pagepropnames in example API call The default request

[MediaWiki-commits] [Gerrit] [WIP] switch to core's server-side HTML templating - change (mediawiki...Blueprint)

2015-07-06 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/223165 Change subject: [WIP] switch to core's server-side HTML templating .. [WIP] switch to core's server-side HTML templating Copy template setup

[MediaWiki-commits] [Gerrit] Typo in repo name in .gitreview - change (mediawiki...Blueprint)

2015-07-06 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/223077 Change subject: Typo in repo name in .gitreview .. Typo in repo name in .gitreview Change-Id: Icf94ba8943f51b0a115379979d7c1bac109eab1f --- M

[MediaWiki-commits] [Gerrit] Support mustache partials in server-side templates - change (mediawiki/core)

2015-07-06 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/223218 Change subject: Support mustache partials in server-side templates .. Support mustache partials in server-side templates This is sufficient to

[MediaWiki-commits] [Gerrit] Test commit for review, ignore - change (mediawiki...Blueprint)

2015-07-05 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/222990 Change subject: Test commit for review, ignore .. Test commit for review, ignore Change-Id: I0d3d84a07bd16facd5533a7d4fd374f6b392f088 --- M

[MediaWiki-commits] [Gerrit] convert to skin.json registration - change (mediawiki...Blueprint)

2015-07-03 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/222559 Change subject: convert to skin.json registration .. convert to skin.json registration Change-Id: I63a8f069e816a3aff2dd1ca714cd7b3481ffcd5e

[MediaWiki-commits] [Gerrit] Use actual booleans in API request - change (mediawiki...Popups)

2015-06-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/221081 Change subject: Use actual booleans in API request .. Use actual booleans in API request Popups' API query request specifies the string 'true'

[MediaWiki-commits] [Gerrit] API query improvements - change (mediawiki...Popups)

2015-06-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/221097 Change subject: API query improvements .. API query improvements Don't request unused prop=info and its rvprop=watched; use formatversion=2

[MediaWiki-commits] [Gerrit] Don't use data['title'] in sidebar logic - change (mediawiki...Blueprint)

2015-06-23 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/220084 Change subject: Don't use data['title'] in sidebar logic .. Don't use data['title'] in sidebar logic title can have extraneous HTML in it if a

[MediaWiki-commits] [Gerrit] Use titletext in sidebar (doesn't show namespace) - change (mediawiki...Blueprint)

2015-06-23 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/220088 Change subject: Use titletext in sidebar (doesn't show namespace) .. Use titletext in sidebar (doesn't show namespace) Might not be right in

[MediaWiki-commits] [Gerrit] Move styles and scripts in one module and set position top - change (mediawiki...Blueprint)

2015-06-23 Thread Spage (Code Review)
Spage has submitted this change and it was merged. Change subject: Move styles and scripts in one module and set position top .. Move styles and scripts in one module and set position top This affects the font-size, so remove

[MediaWiki-commits] [Gerrit] Improve the srsearch API param doc - change (mediawiki/core)

2015-06-08 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/216899 Change subject: Improve the srsearch API param doc .. Improve the srsearch API param doc Mention that it may be a way to invoke fancy search

[MediaWiki-commits] [Gerrit] Improve doc of maxage and s-maxage API parameters - change (mediawiki/core)

2015-06-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/215299 Change subject: Improve doc of maxage and s-maxage API parameters .. Improve doc of maxage and s-maxage API parameters They set HTTP cache

[MediaWiki-commits] [Gerrit] Display the bad lang parameter - change (mediawiki...SyntaxHighlight_GeSHi)

2015-05-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/213963 Change subject: Display the bad lang parameter .. Display the bad lang parameter If an editor garbles the syntaxhighlight lang=foo parameter,

[MediaWiki-commits] [Gerrit] Mistake in error testing - change (mediawiki...SyntaxHighlight_GeSHi)

2015-05-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/213960 Change subject: Mistake in error testing .. Mistake in error testing The method $geshi-error() returns string or boolean, so it's wrong for

[MediaWiki-commits] [Gerrit] [WIP] Add lang=mediawiki syntax highlighting - change (mediawiki...SyntaxHighlight_GeSHi)

2015-05-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/213964 Change subject: [WIP] Add lang=mediawiki syntax highlighting .. [WIP] Add lang=mediawiki syntax highlighting This is the attachment from

[MediaWiki-commits] [Gerrit] Add HTMLForm example code to special page - change (mediawiki...examples)

2015-05-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/213786 Change subject: Add HTMLForm example code to special page .. Add HTMLForm example code to special page I pasted in the code from

[MediaWiki-commits] [Gerrit] Fix tabbing - change (mediawiki...Interwiki)

2015-05-22 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/212835 Change subject: Fix tabbing .. Fix tabbing Remove tabindex on input fields, add autofocus to first one. Test Plan: With this, tabbing through

[MediaWiki-commits] [Gerrit] Fix spelling of labledsectiontransclusion role - change (mediawiki/vagrant)

2015-05-18 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/211937 Change subject: Fix spelling of labledsectiontransclusion role .. Fix spelling of labledsectiontransclusion role The previous commit renamed

[MediaWiki-commits] [Gerrit] Fix spelling of labledsectiontransclusion role - change (mediawiki/vagrant)

2015-05-18 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/211936 Change subject: Fix spelling of labledsectiontransclusion role .. Fix spelling of labledsectiontransclusion role Bug: 699514 Change-Id:

[MediaWiki-commits] [Gerrit] Clarify Data types doc applies to API requests - change (mediawiki/core)

2015-05-11 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/210185 Change subject: Clarify Data types doc applies to API requests .. Clarify Data types doc applies to API requests A minor tweak only to i18n

[MediaWiki-commits] [Gerrit] More Trello username mappings - change (phabricator/tools)

2015-04-23 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/206086 Change subject: More Trello username mappings .. More Trello username mappings From the https://trello.com/b/yg3BS0KD/user-research board.

[MediaWiki-commits] [Gerrit] Better example for query categoryinfo - change (mediawiki/core)

2015-04-07 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/202351 Change subject: Better example for query categoryinfo .. Better example for query categoryinfo Use Category:Featured articles, which exists on

[MediaWiki-commits] [Gerrit] Update getHelpUrls() for reworked mw.org API pages - change (mediawiki/core)

2015-04-07 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/202368 Change subject: Update getHelpUrls() for reworked mw.org API pages .. Update getHelpUrls() for reworked mw.org API pages Community members

[MediaWiki-commits] [Gerrit] Better pageprops API example - change (mediawiki/core)

2015-04-07 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/202374 Change subject: Better pageprops API example .. Better pageprops API example Change example query from non-existent Category:Foo to querying

[MediaWiki-commits] [Gerrit] Note pageterms query behavior if no wbptterms - change (mediawiki...Wikibase)

2015-04-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/201630 Change subject: Note pageterms query behavior if no wbptterms .. Note pageterms query behavior if no wbptterms Based on behavior and a comment

[MediaWiki-commits] [Gerrit] BoilerPlate: add std. composer and npm/grunt setup - change (mediawiki...examples)

2015-03-27 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/200226 Change subject: BoilerPlate: add std. composer and npm/grunt setup .. BoilerPlate: add std. composer and npm/grunt setup cd BoilerPlate

[MediaWiki-commits] [Gerrit] Redirect dev.wikimedia.org URLs - change (operations/puppet)

2015-03-23 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/199182 Change subject: Redirect dev.wikimedia.org URLs .. Redirect dev.wikimedia.org URLs Top-level URL to API:Data_and_developer_hub, everything

[MediaWiki-commits] [Gerrit] Handle Trello attachments - change (phabricator/tools)

2015-03-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/195501 Change subject: Handle Trello attachments .. Handle Trello attachments If a card has attachments, write the list of attachments names linked

[MediaWiki-commits] [Gerrit] Don't update card.closed, don't even run changes - change (phabricator/tools)

2015-03-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/195502 Change subject: Don't update card.closed, don't even run changes .. Don't update card.closed, don't even run changes Some change actions were

[MediaWiki-commits] [Gerrit] Specify max compatible kss version - change (mediawiki/core)

2015-03-05 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/194785 Change subject: Specify max compatible kss version .. Specify max compatible kss version core/docs/kss/styleguide-template/index.html uses

[MediaWiki-commits] [Gerrit] More Trello-Phab username mappings; comments - change (phabricator/tools)

2015-02-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/193316 Change subject: More Trello-Phab username mappings; comments .. More Trello-Phab username mappings; comments I migrated the Gather backlog

[MediaWiki-commits] [Gerrit] Improve the API help for format=xmlfm - change (mediawiki/core)

2015-02-24 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/192767 Change subject: Improve the API help for format=xmlfm .. Improve the API help for format=xmlfm I thought it dumped raw text with attached JSON

[MediaWiki-commits] [Gerrit] Tweak the new-topic API help. - change (mediawiki...Flow)

2015-02-24 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/192726 Change subject: Tweak the new-topic API help. .. Tweak the new-topic API help. Mention page before workflow. Change-Id:

[MediaWiki-commits] [Gerrit] Add cburroughs file from P1407 - change (phabricator/tools)

2015-02-20 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/191935 Change subject: Add cburroughs file from P1407 .. Add cburroughs file from P1407 This fine individual uploaded

[MediaWiki-commits] [Gerrit] Make Special:ApiHelp query string parameters work - change (mediawiki/core)

2015-02-17 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/191250 Change subject: Make Special:ApiHelp query string parameters work .. Make Special:ApiHelp query string parameters work With this

[MediaWiki-commits] [Gerrit] Add link to Special:ApiSandbox to api.php examples - change (mediawiki...ApiSandbox)

2015-02-17 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/191006 Change subject: Add link to Special:ApiSandbox to api.php examples .. Add link to Special:ApiSandbox to api.php examples Since ApiSandbox

[MediaWiki-commits] [Gerrit] Document mw.libs better - change (mediawiki/core)

2015-02-16 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/190968 Change subject: Document mw.libs better .. Document mw.libs better Per Krinkle in IRC. This is a comment-only change. Change-Id:

[MediaWiki-commits] [Gerrit] Api help examples add links to Special:ApiSandbox - change (mediawiki/core)

2015-02-11 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/189921 Change subject: Api help examples add links to Special:ApiSandbox .. Api help examples add links to Special:ApiSandbox Takes advantage of

[MediaWiki-commits] [Gerrit] Add example to ApiBase::getExamples() - change (mediawiki...PageImages)

2015-02-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/189587 Change subject: Add example to ApiBase::getExamples() .. Add example to ApiBase::getExamples() Bug: T89035 Change-Id:

[MediaWiki-commits] [Gerrit] Don't add empty objects to mw.templates - change (mediawiki/core)

2015-02-06 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/189158 Change subject: Don't add empty objects to mw.templates .. Don't add empty objects to mw.templates Test isEmptyObject() before adding module's

[MediaWiki-commits] [Gerrit] Use export_trello logic and trello_PHIds mapping - change (phabricator/tools)

2015-02-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/188287 Change subject: Use export_trello logic and trello_PHIds mapping .. Use export_trello logic and trello_PHIds mapping * Refactor to use a

[MediaWiki-commits] [Gerrit] Add Dev namespace on mediawiki.org - change (operations/mediawiki-config)

2015-01-28 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/187278 Change subject: Add Dev namespace on mediawiki.org .. Add Dev namespace on mediawiki.org For wiki pages in a hub for developers and

[MediaWiki-commits] [Gerrit] README.txt fixes - change (mediawiki/vagrant)

2015-01-26 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/186824 Change subject: README.txt fixes .. README.txt fixes Capitalize USB_FLASH_DRIVE, explain GERRIT_USER, fix cp command to not create

[MediaWiki-commits] [Gerrit] Generate Trello name - Phabricator PHID mappings - change (phabricator/tools)

2015-01-19 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/185964 Change subject: Generate Trello name - Phabricator PHID mappings .. Generate Trello name - Phabricator PHID mappings A human being has to map

[MediaWiki-commits] [Gerrit] Explain how to get [phab] certificate - change (phabricator/tools)

2015-01-05 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/182998 Change subject: Explain how to get [phab] certificate .. Explain how to get [phab] certificate Change-Id:

[MediaWiki-commits] [Gerrit] recent_changes_page is generic, so no Flow prefix - change (mediawiki...Flow)

2014-12-31 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/182394 Change subject: recent_changes_page is generic, so no Flow prefix .. recent_changes_page is generic, so no Flow prefix Change-Id:

[MediaWiki-commits] [Gerrit] QA: should be in RecentChanges in more scenarios - change (mediawiki...Flow)

2014-12-31 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/182400 Change subject: QA: should be in RecentChanges in more scenarios .. QA: should be in RecentChanges in more scenarios Make new topic should be

[MediaWiki-commits] [Gerrit] Fix PageTriage JS dialog parameter - change (mediawiki...PageTriage)

2014-12-24 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181752 Change subject: Fix PageTriage JS dialog parameter .. Fix PageTriage JS dialog parameter It was using .attr( 'value' ) to retrieve deletion

[MediaWiki-commits] [Gerrit] Fix PageTriage JS dialog parameter - change (mediawiki...PageTriage)

2014-12-24 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181753 Change subject: Fix PageTriage JS dialog parameter .. Fix PageTriage JS dialog parameter It was using .attr( 'value' ) to retrieve deletion

[MediaWiki-commits] [Gerrit] Update PageTriage with easy JS fix - change (mediawiki/core)

2014-12-24 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181759 Change subject: Update PageTriage with easy JS fix .. Update PageTriage with easy JS fix Change-Id: I71583e82baa145b752df2d430b079c694af55069

[MediaWiki-commits] [Gerrit] Update PageTriage with easy JS fix - change (mediawiki/core)

2014-12-24 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181761 Change subject: Update PageTriage with easy JS fix .. Update PageTriage with easy JS fix Change-Id: I11ae3467037617fce40331f871dc1aa68ba7e505

[MediaWiki-commits] [Gerrit] Update PageTriage with easy JS fix - change (mediawiki/core)

2014-12-24 Thread Spage (Code Review)
Spage has submitted this change and it was merged. Change subject: Update PageTriage with easy JS fix .. Update PageTriage with easy JS fix Change-Id: I71583e82baa145b752df2d430b079c694af55069 --- M extensions/PageTriage 1

[MediaWiki-commits] [Gerrit] Fix PageTriage JS dialog parameter - change (mediawiki...PageTriage)

2014-12-22 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181532 Change subject: Fix PageTriage JS dialog parameter .. Fix PageTriage JS dialog parameter It was using .attr( 'value' ) to retrieve deletion

[MediaWiki-commits] [Gerrit] WIP towards JSHint passing - change (mediawiki...PageTriage)

2014-12-22 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181537 Change subject: WIP towards JSHint passing .. WIP towards JSHint passing Exclude most modules/external , fix the easy ones. Start on

[MediaWiki-commits] [Gerrit] Another global wgXxx access - change (mediawiki...PageTriage)

2014-12-22 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181538 Change subject: Another global wgXxx access .. Another global wgXxx access Wrap a naked wgFoo variable access with mw.config.get(). Fixes

[MediaWiki-commits] [Gerrit] Correct MWPageTriageMissingRevisionException name - change (mediawiki...PageTriage)

2014-12-19 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/181214 Change subject: Correct MWPageTriageMissingRevisionException name .. Correct MWPageTriageMissingRevisionException name This fixes

[MediaWiki-commits] [Gerrit] WIP: Trello JSON processing for Phabricator - change (phabricator/tools)

2014-12-10 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/179057 Change subject: WIP: Trello JSON processing for Phabricator .. WIP: Trello JSON processing for Phabricator Currently just outputs fields for

[MediaWiki-commits] [Gerrit] Comment with rationale for Flow on catalan pages - change (operations/mediawiki-config)

2014-12-09 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/178701 Change subject: Comment with rationale for Flow on catalan pages .. Comment with rationale for Flow on catalan pages Documents If2e67467

[MediaWiki-commits] [Gerrit] Explain operation in README - change (phabricator/tools)

2014-12-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/177178 Change subject: Explain operation in README .. Explain operation in README Point to bugrun.sh, say what scripts do. Change-Id:

[MediaWiki-commits] [Gerrit] Improve README and phabtools.conf.example - change (phabricator/tools)

2014-12-02 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/177181 Change subject: Improve README and phabtools.conf.example .. Improve README and phabtools.conf.example Mention phabtools.conf.example in

[MediaWiki-commits] [Gerrit] QA: allow longer class definition - change (mediawiki...Flow)

2014-11-25 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/175783 Change subject: QA: allow longer class definition .. QA: allow longer class definition class FlowPage is big! With this the

[MediaWiki-commits] [Gerrit] QA: delete duplicate .rubocop_todo.yml - change (mediawiki...Flow)

2014-11-25 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/175785 Change subject: QA: delete duplicate .rubocop_todo.yml .. QA: delete duplicate .rubocop_todo.yml The CI mwext-Flow-bundle-rubocop test runs

[MediaWiki-commits] [Gerrit] Update 1.25wmf9 Flow with cherry-pick I5e0490d0 - change (mediawiki/core)

2014-11-25 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/175941 Change subject: Update 1.25wmf9 Flow with cherry-pick I5e0490d0 .. Update 1.25wmf9 Flow with cherry-pick I5e0490d0 Change-Id:

[MediaWiki-commits] [Gerrit] Fix rubocop style complaints - change (mediawiki...Flow)

2014-11-21 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/175187 Change subject: Fix rubocop style complaints .. Fix rubocop style complaints Rubocop wants no space inside parenthese, while spaces within

[MediaWiki-commits] [Gerrit] Fix jenkins CI complaining of comments in Gemfile - change (mediawiki...Flow)

2014-11-18 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/174339 Change subject: Fix jenkins CI complaining of comments in Gemfile .. Fix jenkins CI complaining of comments in Gemfile Lifted from

[MediaWiki-commits] [Gerrit] build: Implement Grunt workflow (via npm test) - change (mediawiki...Flow)

2014-11-18 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/174352 Change subject: build: Implement Grunt workflow (via npm test) .. build: Implement Grunt workflow (via npm test) Slims down the already-merged

[MediaWiki-commits] [Gerrit] Enable Flow on some testwiki pages - change (operations/mediawiki-config)

2014-11-13 Thread Spage (Code Review)
Spage has uploaded a new change for review. https://gerrit.wikimedia.org/r/173196 Change subject: Enable Flow on some testwiki pages .. Enable Flow on some testwiki pages Request from Jonathan Morgan Change-Id:

  1   2   3   4   5   6   7   >