Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174679
Change subject: Do not call click on undefined
..
Do not call click on undefined
Not all pages in a MediaWiki installation do
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174699
Change subject: Fix/update inline documentation of LoadBalancer
..
Fix/update inline documentation of LoadBalancer
Plus two
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174775
Change subject: Phase out hasClaim and newClaim
..
Phase out hasClaim and newClaim
I focused on the deprecated methods hasClaim
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174836
Change subject: Rework and drop unused code from EditEntityAction
..
Rework and drop unused code from EditEntityAction
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174842
Change subject: Remove unused use clauses and fix typo in a class name
..
Remove unused use clauses and fix typo in a class name
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174848
Change subject: Small clean ups in Changes related code
..
Small clean ups in Changes related code
This are some small bits
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175761
Change subject: Fix call on undefined in entityselector.js
..
Fix call on undefined in entityselector.js
The .label property
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175803
Change subject: Narrow TermSqlIndex interface to EntityId
..
Narrow TermSqlIndex interface to EntityId
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175823
Change subject: Make stuff in CachingEntityRevisionLookup private
..
Make stuff in CachingEntityRevisionLookup private
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175968
Change subject: Rework and clean up MockRepository and related
..
Rework and clean up MockRepository and related
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175973
Change subject: Drop unused code from EntityViewTest
..
Drop unused code from EntityViewTest
If all tests succeed this can
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/175976
Change subject: Drop unused code from SpecialEntityDataTest
..
Drop unused code from SpecialEntityDataTest
If all tests succeed
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/171569
Change subject: Clean up ChangeHandler
..
Clean up ChangeHandler
Change-Id: If258b63807930aacd89cd24da57a1a27648800d6
---
M
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172275
Change subject: Narrow EntityParserOutputGeneratorFactory interface
..
Narrow EntityParserOutputGeneratorFactory interface
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172289
Change subject: Simplify remoteExtPath regex
..
Simplify remoteExtPath regex
The complexity of this regular expression is just
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172541
Change subject: Consistent SiteLink naming and dead code removed
..
Consistent SiteLink naming and dead code removed
I started
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172545
Change subject: Add irc to the allowed URL schemas
..
Add irc to the allowed URL schemas
I considered adding
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172564
Change subject: Remove my email address
..
Remove my email address
I did this for a very short time and later decided
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172572
Change subject: More consistent variable naming, e.g. $languageCode
..
More consistent variable naming, e.g. $languageCode
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Add missing test resources
..
Add missing test resources
Change-Id: I8b3309efce1602a1901072b869c59167638c3a1b
---
M resources.php
A tests
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Bump data-values/javascript dependency to match Wikibase.git's
..
Bump data-values/javascript dependency to match Wikibase.git's
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Remove dependency on wikibase resource loader module
..
Remove dependency on wikibase resource loader module
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Shorten overly long lines
..
Shorten overly long lines
Change-Id: I0dde5d6251420bf43636a1e8e0f19f44592aa7e7
---
M .jshintrc
M src
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176230
Change subject: Fix broken @see in Number(Un)Localizer doc
..
Fix broken @see in Number(Un)Localizer doc
Also see https
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176356
Change subject: [WIP] Clean up UsageTablePrimer and related
..
[WIP] Clean up UsageTablePrimer and related
Two problems
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Inject siteLinkGroups into ItemView
..
Inject siteLinkGroups into ItemView
Change-Id: Icd9af0daf0353245eeb73c225dd9121a762d5e98
---
M repo
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Rewrite completely broken EntityView tests
..
Rewrite completely broken EntityView tests
Change-Id: Ibc373a9017c25cc2bdacbabeea2b97d283e31b00
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176652
Change subject: Clean up SiteLinkLookup and related
..
Clean up SiteLinkLookup and related
I found this in my stashes. It's
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176655
Change subject: Move all Hooks to Hooks folder and namespace
..
Move all Hooks to Hooks folder and namespace
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176660
Change subject: Move client Hooks classes to Hooks folder/namespace
..
Move client Hooks classes to Hooks folder/namespace
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176661
Change subject: Move Repo Hooks classes to Hooks folder/namespace
..
Move Repo Hooks classes to Hooks folder/namespace
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176725
Change subject: Narrow RdfBuilder interfaces as much as possible
..
Narrow RdfBuilder interfaces as much as possible
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176903
Change subject: Remove unused imports from Client
..
Remove unused imports from Client
Some are not reported by PHPStorm, I
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176913
Change subject: Make EntityPerPageBuilderTest fields/methods private
..
Make EntityPerPageBuilderTest fields/methods private
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/176915
Change subject: Avoid getDefaultInstance method name in tests
..
Avoid getDefaultInstance method name in tests
This is split
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177193
Change subject: Remove repeated var name from @var doc tags
..
Remove repeated var name from @var doc tags
This is a copy
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177194
Change subject: Rename getSiteLinkTable to getSiteLinkLookup
..
Rename getSiteLinkTable to getSiteLinkLookup
Looks like
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177195
Change subject: Clean up ItemsPerSiteBuilderTest
..
Clean up ItemsPerSiteBuilderTest
I may be wrong but I don't think it's
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177197
Change subject: Clean up MockClientStore
..
Clean up MockClientStore
Again, I don't think it's a good idea to make
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177198
Change subject: Clean up MockPropertyLabelResolver
..
Clean up MockPropertyLabelResolver
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177200
Change subject: Rename ambiguous $repo to $wikibaseRepo
..
Rename ambiguous $repo to $wikibaseRepo
This is split from I04767f2
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177206
Change subject: Fix mistakes in AffectedPagesFinder and UsageAspectTransformer
..
Fix mistakes in AffectedPagesFinder
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177214
Change subject: Remove redundant variable names from @return tags
..
Remove redundant variable names from @return tags
Reason
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177215
Change subject: Delete unused TermMatchScoreCalculator
..
Delete unused TermMatchScoreCalculator
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177234
Change subject: Use switch in EntityIdTitleFormatters
..
Use switch in EntityIdTitleFormatters
If it looks like a switch why
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177237
Change subject: Use 'property' string constant to avoid dependencies
..
Use 'property' string constant to avoid dependencies
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177239
Change subject: Use 'item' string constant to avoid dependencies
..
Use 'item' string constant to avoid dependencies
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177258
Change subject: Formatters for JSON?
..
Formatters for JSON?
A Formatter that outputs JSON is not a Formatter, that's
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177532
Change subject: Fix wrong SqlUsageTrackerSchemaUpdater filename
..
Fix wrong SqlUsageTrackerSchemaUpdater filename
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177537
Change subject: Fix doc tags in EntityUsageTableBuilder
..
Fix doc tags in EntityUsageTableBuilder
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179114
Change subject: Drop dead and redundant special page code
..
Drop dead and redundant special page code
* SpecialPage::execute
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179135
Change subject: Fall back to page title if wikibase-titletext is n/a
..
Fall back to page title if wikibase-titletext is n
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179473
Change subject: Rework WikibaseRepo tests
..
Rework WikibaseRepo tests
* Use willReturn() and willReturnCallback() shortcuts
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179881
Change subject: Rework and cleanup ApiWikibase and subclasses
..
Rework and cleanup ApiWikibase and subclasses
Main changes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179915
Change subject: Rework importInterlang/Properties maintainance scripts
..
Rework importInterlang/Properties maintainance scripts
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179931
Change subject: Rework and clean up TermIndex interfaces
..
Rework and clean up TermIndex interfaces
This is a direct follow up
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179937
Change subject: Drop useless docs from Store interface
..
Drop useless docs from Store interface
Some comments were wrong, must
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179950
Change subject: SpecialPage::execute doesn't return anything
..
SpecialPage::execute doesn't return anything
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180163
Change subject: Stop EntityIdFormatter extending ValueFormatterBase
..
Stop EntityIdFormatter extending ValueFormatterBase
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180185
Change subject: Fix minor issues in JSDoc tags
..
Fix minor issues in JSDoc tags
Change-Id
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Fixed creating an empty entity
..
Fixed creating an empty entity
Change-Id: Ib26abf43cd8edf5412c9867d2fc30fded850d162
---
M README.md
M src
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Updated code documentation
..
Updated code documentation
Updated code documentation to be able to generate documentation using JSDuck.
Includes
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180498
Change subject: Clean up and refactor TemplateFactory introduction
..
Clean up and refactor TemplateFactory introduction
Main
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172675
Change subject: Replaced caseInsensitive option
..
Replaced caseInsensitive option
See https://github.com/wmde/ValueView/pull
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172678
Change subject: Add missing method visibility everywhere
..
Add missing method visibility everywhere
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172679
Change subject: Fix visibility of setUp/tearDown
..
Fix visibility of setUp/tearDown
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172688
Change subject: Fix visibility of setUp/tearDown
..
Fix visibility of setUp/tearDown
Required for Idf44d31.
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172691
Change subject: Add missing visibility keywords everywhere
..
Add missing visibility keywords everywhere
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172703
Change subject: Unify top factory getter implementations
..
Unify top factory getter implementations
The fact
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172709
Change subject: Fix visibility issues in Scribunto tests
..
Fix visibility issues in Scribunto tests
This needs If6d2705
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172711
Change subject: Move all client tests to Wikibase\Client\Tests
..
Move all client tests to Wikibase\Client\Tests
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172977
Change subject: Change @throw to @throws
..
Change @throw to @throws
Change-Id: I40067da35283f99ccf49f7fbc2cd76f9b62bc302
---
M
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172997
Change subject: Optimize all use sections in Repo
..
Optimize all use sections in Repo
Stuff that's not in a namespace needs
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172998
Change subject: Optimize all use sections in Lib
..
Optimize all use sections in Lib
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172999
Change subject: Optimize all use sections in Client
..
Optimize all use sections in Client
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173017
Change subject: Increase selector precedence for aliasesview in fingerprintview
..
Increase selector precedence for aliasesview
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Move parsers from lib to repo
..
Move parsers from lib to repo
They are only used in repo.
Change-Id: I08bd8883614f1c85b71b52a3f5f56a9646b9f410
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173262
Change subject: Use $this-settings instead of $this-getSettings
..
Use $this-settings instead of $this-getSettings
Also see
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173773
Change subject: Rename dataTypes to dataTypeStore
..
Rename dataTypes to dataTypeStore
wbDataTypes is the settings array
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173786
Change subject: Move Client tests to namespace Wikibase\Client\Tests
..
Move Client tests to namespace Wikibase\Client\Tests
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173787
Change subject: Fix namespace of all Wikibase\Client\DataAccess tests
..
Fix namespace of all Wikibase\Client\DataAccess tests
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173788
Change subject: Move all remaining client tests to specific namespaces
..
Move all remaining client tests to specific namespaces
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173797
Change subject: Change namespace of all Client Scribunto tests
..
Change namespace of all Client Scribunto tests
To be honest
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173819
Change subject: Fix covers tag in WikibaseClientTest
..
Fix covers tag in WikibaseClientTest
Found by Adrian in I9140582
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173828
Change subject: Replace some Claims with StatementList
..
Replace some Claims with StatementList
I wanted to replace some
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174109
Change subject: Replace some deprecated setClaims with getStatements
..
Replace some deprecated setClaims with getStatements
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174110
Change subject: Reduce inheritance in EntityContentTest
..
Reduce inheritance in EntityContentTest
Especially the redirect
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174112
Change subject: Drop optional empty array() constructor parameters
..
Drop optional empty array() constructor parameters
Change
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174123
Change subject: More descriptive names for $repo variables and methods
..
More descriptive names for $repo variables and methods
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/174387
Change subject: Fix entitysearch to support Firefox smart keyword
..
Fix entitysearch to support Firefox smart keyword
Bug
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Implemented $.util.getDirectionality
..
Implemented $.util.getDirectionality
By acting as an interface to ULS, the function allows move ULS
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180737
Change subject: getDirectionality may return undefined
..
getDirectionality may return undefined
Either this or change the doc
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180760
Change subject: Rework and clean up badge related code
..
Rework and clean up badge related code
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/180762
Change subject: Refactoring of ChangeOpSiteLink
..
Refactoring of ChangeOpSiteLink
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181050
Change subject: Fix broken/missing @covers tags in Lib\Store
..
Fix broken/missing @covers tags in Lib\Store
Change-Id
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181051
Change subject: Fix broken emails in @author tags
..
Fix broken emails in @author tags
... and use the same @author tag
Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/181056
Change subject: Suggester visibility depend on spinner visibility
..
Suggester visibility depend on spinner visibility
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Add/correct comments in SpecialListDatatypes.php
..
Add/correct comments in SpecialListDatatypes.php
Adds comments for missing messages or ones
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Added type checks to wikibase.api.RepoApi functions
..
Added type checks to wikibase.api.RepoApi functions
Actually reflecting parameter
Thiemo Mättig (WMDE) has submitted this change and it was merged.
Change subject: Added RepoApi tests for functions not yet tested
..
Added RepoApi tests for functions not yet tested
Change-Id
1 - 100 of 6021 matches
Mail list logo