[MediaWiki-commits] [Gerrit] Fix wrong version range for DataValues Interfaces - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232243 Change subject: Fix wrong version range for DataValues Interfaces .. Fix wrong version range for DataValues Interfaces I am to

[MediaWiki-commits] [Gerrit] Enable more PHPCS sniffs the code base already conforms to - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232244 Change subject: Enable more PHPCS sniffs the code base already conforms to .. Enable more PHPCS sniffs the code base already

[MediaWiki-commits] [Gerrit] Drop some dead function parameters from tests - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232245 Change subject: Drop some dead function parameters from tests .. Drop some dead function parameters from tests I found these

[MediaWiki-commits] [Gerrit] Remove entity view loading spinner - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232246 Change subject: Remove entity view loading spinner .. Remove entity view loading spinner Bug: T108365 Change-Id

[MediaWiki-commits] [Gerrit] Enable two groups of PHPCS sniffs instead of individual sniffs - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232248 Change subject: Enable two groups of PHPCS sniffs instead of individual sniffs .. Enable two groups of PHPCS sniffs instead of

[MediaWiki-commits] [Gerrit] Disallow YDM format in TimeParserFactoryTest for now - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232251 Change subject: Disallow YDM format in TimeParserFactoryTest for now .. Disallow YDM format in TimeParserFactoryTest for now A

[MediaWiki-commits] [Gerrit] Add trimming test to SummaryFormatterTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232254 Change subject: Add trimming test to SummaryFormatterTest .. Add trimming test to SummaryFormatterTest Change-Id

[MediaWiki-commits] [Gerrit] Add proper null check to ChangeRow - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232263 Change subject: Add proper null check to ChangeRow .. Add proper null check to ChangeRow Both json_decode and unserialize calls

[MediaWiki-commits] [Gerrit] Revert to use non-deprecated Item::copy and Property::copy - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232271 Change subject: Revert to use non-deprecated Item::copy and Property::copy .. Revert to use non-deprecated Item::copy and

[MediaWiki-commits] [Gerrit] Narrow interfaces to StatementListProvider - change (mediawiki...WikibaseQualityExternalValidation)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232279 Change subject: Narrow interfaces to StatementListProvider .. Narrow interfaces to StatementListProvider Change-Id

[MediaWiki-commits] [Gerrit] Follow up on compatibility breaks in Wikibase - change (mediawiki...WikibaseQualityExternalValidation)

Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Follow up on compatibility breaks in Wikibase .. Follow up on compatibility breaks in Wikibase EntityLookup and LanguageLabelDescriptionLookup

[MediaWiki-commits] [Gerrit] Fix incomplete PHPDoc parameter tags - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232451 Change subject: Fix incomplete PHPDoc parameter tags .. Fix incomplete PHPDoc parameter tags I did a regex search for @param

[MediaWiki-commits] [Gerrit] Fix PHPDoc in RdfVocabulary - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232452 Change subject: Fix PHPDoc in RdfVocabulary .. Fix PHPDoc in RdfVocabulary Change-Id: I49a974139342cf410b76502d75de51f839a477af

[MediaWiki-commits] [Gerrit] Fix PHPDocs in InterwikiSorter - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232453 Change subject: Fix PHPDocs in InterwikiSorter .. Fix PHPDocs in InterwikiSorter Change-Id

[MediaWiki-commits] [Gerrit] Drop dead code from ItemMergeInteractorTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232455 Change subject: Drop dead code from ItemMergeInteractorTest .. Drop dead code from ItemMergeInteractorTest This function uses

[MediaWiki-commits] [Gerrit] Remove incomplete param PHPDocs from dataProviders - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232456 Change subject: Remove incomplete param PHPDocs from dataProviders .. Remove incomplete param PHPDocs from dataProviders The

[MediaWiki-commits] [Gerrit] Use factory instead of accessing configuration - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232471 Change subject: Use factory instead of accessing configuration .. Use factory instead of accessing configuration Change-Id

[MediaWiki-commits] [Gerrit] Simplify hasOwnProperty checks in wikibase.getLanguageNameBy... - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232481 Change subject: Simplify hasOwnProperty checks in wikibase.getLanguageNameByCode .. Simplify hasOwnProperty checks in

[MediaWiki-commits] [Gerrit] Fix unchecked loop in wikibase.special.itemByTitle - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232482 Change subject: Fix unchecked loop in wikibase.special.itemByTitle .. Fix unchecked loop in wikibase.special.itemByTitle Change

[MediaWiki-commits] [Gerrit] Remove duplicate whitespaces in arrays - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232509 Change subject: Remove duplicate whitespaces in arrays .. Remove duplicate whitespaces in arrays Change-Id

[MediaWiki-commits] [Gerrit] Add default badges for Wikisource - change (mediawiki...WikimediaBadges)

Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Add default badges for Wikisource .. Add default badges for Wikisource With site css, each Wikisource community can override these defaults

[MediaWiki-commits] [Gerrit] Add lots of array type hints to tests - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232690 Change subject: Add lots of array type hints to tests .. Add lots of array type hints to tests The idea is pretty simple: This

[MediaWiki-commits] [Gerrit] Remove Entity from ChangeOpAliasesTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232692 Change subject: Remove Entity from ChangeOpAliasesTest .. Remove Entity from ChangeOpAliasesTest Entity is just not needed here

[MediaWiki-commits] [Gerrit] Replace Iterator with Traversable and replace - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232693 Change subject: Replace Iterator with Traversable and replace .. Replace Iterator with Traversable and replace This fixes two

[MediaWiki-commits] [Gerrit] Add array type hints to private functions - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232695 Change subject: Add array type hints to private functions .. Add array type hints to private functions I found these candidates

[MediaWiki-commits] [Gerrit] Add array type hints to public methods - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232696 Change subject: Add array type hints to public methods .. Add array type hints to public methods Please be careful and double

[MediaWiki-commits] [Gerrit] Fix incomplete wbsearchentities options in entityselector - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232724 Change subject: Fix incomplete wbsearchentities options in entityselector .. Fix incomplete wbsearchentities options in

[MediaWiki-commits] [Gerrit] Fix incomplete wbsearchentities options in entityselector - change (mediawiki...WikibaseJavaScriptApi)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232725 Change subject: Fix incomplete wbsearchentities options in entityselector .. Fix incomplete wbsearchentities options in

[MediaWiki-commits] [Gerrit] Fix all issues found while reviewing language code canonical... - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232751 Change subject: Fix all issues found while reviewing language code canonicalization .. Fix all issues found while reviewing

[MediaWiki-commits] [Gerrit] Fix failing empty( ArrayIterator ) check in ChangeHandler - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232926 Change subject: Fix failing empty( ArrayIterator ) check in ChangeHandler .. Fix failing empty( ArrayIterator ) check in

[MediaWiki-commits] [Gerrit] Remove unused return from ChangeHandler::handleChange - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232927 Change subject: Remove unused return from ChangeHandler::handleChange .. Remove unused return from ChangeHandler::handleChange

[MediaWiki-commits] [Gerrit] Make TextInjector optional in EntityTermsView - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232928 Change subject: Make TextInjector optional in EntityTermsView .. Make TextInjector optional in EntityTermsView Change-Id

[MediaWiki-commits] [Gerrit] Tests for more edge cases in InterwikiSorter - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/232939 Change subject: Tests for more edge cases in InterwikiSorter .. Tests for more edge cases in InterwikiSorter Bug: T103044

[MediaWiki-commits] [Gerrit] Add lots of array type hints to tests - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233348 Change subject: Add lots of array type hints to tests .. Add lots of array type hints to tests The idea is pretty simple: This

[MediaWiki-commits] [Gerrit] Add array type hints to GenericEntityInfoBuilder classes - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233351 Change subject: Add array type hints to GenericEntityInfoBuilder classes .. Add array type hints to GenericEntityInfoBuilder

[MediaWiki-commits] [Gerrit] Introduce HARD_LIMIT constant in TermIndexSearchInteractor - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233352 Change subject: Introduce HARD_LIMIT constant in TermIndexSearchInteractor .. Introduce HARD_LIMIT constant in

[MediaWiki-commits] [Gerrit] Add array type hints to OutputPageJsConfigBuilder - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233353 Change subject: Add array type hints to OutputPageJsConfigBuilder .. Add array type hints to OutputPageJsConfigBuilder Change

[MediaWiki-commits] [Gerrit] Add array type hints to NotEntityIdValidator - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233354 Change subject: Add array type hints to NotEntityIdValidator .. Add array type hints to NotEntityIdValidator Change-Id

[MediaWiki-commits] [Gerrit] Add array type hints to GetEntities - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233355 Change subject: Add array type hints to GetEntities .. Add array type hints to GetEntities Change-Id

[MediaWiki-commits] [Gerrit] Fix misleading/incomplete array type hints in repo classes - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233356 Change subject: Fix misleading/incomplete array type hints in repo classes .. Fix misleading/incomplete array type hints in repo

[MediaWiki-commits] [Gerrit] Private by default in ClaimHtmlGenerator - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233357 Change subject: Private by default in ClaimHtmlGenerator .. Private by default in ClaimHtmlGenerator Change-Id

[MediaWiki-commits] [Gerrit] Introduce assert methods in EditEntity - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233380 Change subject: Introduce assert methods in EditEntity .. Introduce assert methods in EditEntity The intention is to reduce

[MediaWiki-commits] [Gerrit] Drop unused use from RepoHooksTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/233381 Change subject: Drop unused use from RepoHooksTest .. Drop unused use from RepoHooksTest Change-Id

[MediaWiki-commits] [Gerrit] More general .teahouse-ask button styling - change (mediawiki...Teahouse)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230060 Change subject: More general .teahouse-ask button styling .. More general .teahouse-ask button styling This removes the

[MediaWiki-commits] [Gerrit] Enable two Generic.CodeAnalysis... PHPCS sniffs - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230082 Change subject: Enable two Generic.CodeAnalysis... PHPCS sniffs .. Enable two Generic.CodeAnalysis... PHPCS sniffs This enables

[MediaWiki-commits] [Gerrit] Do not use globals in ChangeHandlerTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230089 Change subject: Do not use globals in ChangeHandlerTest .. Do not use globals in ChangeHandlerTest This code makes the custom

[MediaWiki-commits] [Gerrit] More specific return types in SpecialWikibaseQueryPage - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230110 Change subject: More specific return types in SpecialWikibaseQueryPage .. More specific return types in SpecialWikibaseQueryPage

[MediaWiki-commits] [Gerrit] TimeParserFactory should be able to parse "1991 1 1" - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230506 Change subject: TimeParserFactory should be able to parse "1991 1 1" .. TimeParserFactory should be able to parse

[MediaWiki-commits] [Gerrit] Make 'en' explicit in MwTimeIsoFormatter - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230511 Change subject: Make 'en' explicit in MwTimeIsoFormatter .. Make 'en' explicit in MwTimeIso

[MediaWiki-commits] [Gerrit] Fix mistakes in entityselector - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230580 Change subject: Fix mistakes in entityselector .. Fix mistakes in entityselector Change-Id

[MediaWiki-commits] [Gerrit] Enable disabled SpaceAfterKeyword PHPCS sniff - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230984 Change subject: Enable disabled SpaceAfterKeyword PHPCS sniff .. Enable disabled SpaceAfterKeyword PHPCS sniff This was

[MediaWiki-commits] [Gerrit] Fix switched @var PHPDoc tags - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/230986 Change subject: Fix switched @var PHPDoc tags .. Fix switched @var PHPDoc tags Change-Id

[MediaWiki-commits] [Gerrit] Fix minor bug in LanguageFallbackChainFactoryTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/231245 Change subject: Fix minor bug in LanguageFallbackChainFactoryTest .. Fix minor bug in LanguageFallbackChainFactoryTest Change

[MediaWiki-commits] [Gerrit] Drop dead code from ClaimHtmlGenerator - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/231248 Change subject: Drop dead code from ClaimHtmlGenerator .. Drop dead code from ClaimHtmlGenerator Change-Id

[MediaWiki-commits] [Gerrit] Rename "Statement $claim" variables to $statement - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/231249 Change subject: Rename "Statement $claim" variables to $statement .. Rename "Statement $claim" variables t

[MediaWiki-commits] [Gerrit] End all Claim's - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/231264 Change subject: End all Claim's .. End all Claim's Change-Id: I420b1cbcd05c161c8736994808898783562356ad --- M rep

[MediaWiki-commits] [Gerrit] Remove unused use clauses - change (mediawiki...WikibaseQualityConstraints)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/231273 Change subject: Remove unused use clauses .. Remove unused use clauses Change-Id: I38fad101d14b57885775615db39c838bf23f4aa3

[MediaWiki-commits] [Gerrit] Replace all remaining usages of the Claim alias - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/231274 Change subject: Replace all remaining usages of the Claim alias .. Replace all remaining usages of the Claim alias Change-Id

[MediaWiki-commits] [Gerrit] Drop dead code and narrow interfaces in WikibaseApiTestCase - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/202704 Change subject: Drop dead code and narrow interfaces in WikibaseApiTestCase .. Drop dead code and narrow interfaces in

[MediaWiki-commits] [Gerrit] Un-deprecate $revisionId = 0 in EntityRevisionLookup - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/202723 Change subject: Un-deprecate $revisionId = 0 in EntityRevisionLookup .. Un-deprecate $revisionId = 0 in EntityRevisionLookup As

[MediaWiki-commits] [Gerrit] Remove broken unlocalization from MwTimeIsoFormatter - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203018 Change subject: Remove broken unlocalization from MwTimeIsoFormatter .. Remove broken unlocalization from MwTimeIsoFormatter

[MediaWiki-commits] [Gerrit] Make deprecated Settings class final - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203037 Change subject: Make deprecated Settings class final .. Make deprecated Settings class final This also adds deprecation tags to

[MediaWiki-commits] [Gerrit] [DNM] Disallow EntityRevision to represent current revision - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203045 Change subject: [DNM] Disallow EntityRevision to represent current revision .. [DNM] Disallow EntityRevision to represent

[MediaWiki-commits] [Gerrit] Simplify StringNormalizer regex - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203112 Change subject: Simplify StringNormalizer regex .. Simplify StringNormalizer regex This does not change any semantics. All it

[MediaWiki-commits] [Gerrit] Fix broken EntityViewFactoryTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203086 Change subject: Fix broken EntityViewFactoryTest .. Fix broken EntityViewFactoryTest Why does Jenkins not fail? Is this not

[MediaWiki-commits] [Gerrit] Do not fail hard if badgeItems setting is not set - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203089 Change subject: Do not fail hard if badgeItems setting is not set .. Do not fail hard if badgeItems setting is not set It

[MediaWiki-commits] [Gerrit] Make stuff in SetClaimTest private - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203793 Change subject: Make stuff in SetClaimTest private .. Make stuff in SetClaimTest private This patch contains some very simple

[MediaWiki-commits] [Gerrit] Replace last remaining Claims::hasClaim call - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203795 Change subject: Replace last remaining Claims::hasClaim call .. Replace last remaining Claims::hasClaim call This reduces the

[MediaWiki-commits] [Gerrit] Replace deprecated Claims::hasClaimWithGuid method - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203801 Change subject: Replace deprecated Claims::hasClaimWithGuid method .. Replace deprecated Claims::hasClaimWithGuid method This

[MediaWiki-commits] [Gerrit] Avoid static access to global settings object where possible. - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has submitted this change and it was merged. Change subject: Avoid static access to global settings object where possible. .. Avoid static access to global settings object where possible. Note that some

[MediaWiki-commits] [Gerrit] Avoid constructing message keys if not necesarry - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/203867 Change subject: Avoid constructing message keys if not necesarry .. Avoid constructing message keys if not necesarry Change-Id

[MediaWiki-commits] [Gerrit] Temporarily disable calendar model output in HtmlTimeFormatter - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204037 Change subject: Temporarily disable calendar model output in HtmlTimeFormatter .. Temporarily disable calendar model output in

[MediaWiki-commits] [Gerrit] Remove last remaining wfProfileIn/wfProfileOut calls - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204228 Change subject: Remove last remaining wfProfileIn/wfProfileOut calls .. Remove last remaining wfProfileIn/wfProfileOut calls

[MediaWiki-commits] [Gerrit] Fix code smell issues in lib/includes/store - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204229 Change subject: Fix code smell issues in lib/includes/store .. Fix code smell issues in lib/includes/store This patch fixes a

[MediaWiki-commits] [Gerrit] Drop unused code from ChunkCache - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204231 Change subject: Drop unused code from ChunkCache .. Drop unused code from ChunkCache I'm not 100% sure if this is a good

[MediaWiki-commits] [Gerrit] Fix mistakes in ContentLanguages loopups - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204235 Change subject: Fix mistakes in ContentLanguages loopups .. Fix mistakes in ContentLanguages loopups Change-Id

[MediaWiki-commits] [Gerrit] Prefer WebRequest::getCheck if possible - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204236 Change subject: Prefer WebRequest::getCheck if possible .. Prefer WebRequest::getCheck if possible Change-Id

[MediaWiki-commits] [Gerrit] Fix various code smell issues in RDF related code - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204249 Change subject: Fix various code smell issues in RDF related code .. Fix various code smell issues in RDF related code E.g

[MediaWiki-commits] [Gerrit] Fix 2 broken tests on repo - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204250 Change subject: Fix 2 broken tests on repo .. Fix 2 broken tests on repo 1. TimeValue will not support empty strings any more

[MediaWiki-commits] [Gerrit] Prepare RDF test data for new data-values/time release - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204258 Change subject: Prepare RDF test data for new data-values/time release .. Prepare RDF test data for new data-values/time release

[MediaWiki-commits] [Gerrit] Fix undefined class warnings in repo - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204270 Change subject: Fix undefined class warnings in repo .. Fix undefined class warnings in repo This patch fixes a whole bunch of

[MediaWiki-commits] [Gerrit] Drop unused use clauses from client/lib/repo/view - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204472 Change subject: Drop unused use clauses from client/lib/repo/view .. Drop unused use clauses from client/lib/repo/view I have a

[MediaWiki-commits] [Gerrit] Drop dead class properties, variables and methods - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204474 Change subject: Drop dead class properties, variables and methods .. Drop dead class properties, variables and methods Random

[MediaWiki-commits] [Gerrit] Fix non-existing ConnectionManager class name in DirectSqlStore - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204475 Change subject: Fix non-existing ConnectionManager class name in DirectSqlStore .. Fix non-existing ConnectionManager class name

[MediaWiki-commits] [Gerrit] Specific return types in MockClientStore - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204476 Change subject: Specific return types in MockClientStore .. Specific return types in MockClientStore All these methods are

[MediaWiki-commits] [Gerrit] Split mock creation in UnDeserializableValueFormatterTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204478 Change subject: Split mock creation in UnDeserializableValueFormatterTest .. Split mock creation in

[MediaWiki-commits] [Gerrit] Fix type warning snippets all over the code base - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/204479 Change subject: Fix type warning snippets all over the code base .. Fix type warning snippets all over the code base This fixes

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Generic.ControlStructures - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/215877 Change subject: Enable PHPCS sniff Generic.ControlStructures .. Enable PHPCS sniff Generic.ControlStructures There is only 1

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Generic.Formatting.DisallowMultipleStatem... - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/215878 Change subject: Enable PHPCS sniff Generic.Formatting.DisallowMultipleStatements .. Enable PHPCS sniff

[MediaWiki-commits] [Gerrit] Enable PHPCS sniff Generic.Functions.OpeningFunctionBraceKer... - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/215886 Change subject: Enable PHPCS sniff Generic.Functions.OpeningFunctionBraceKernighanRitchie .. Enable PHPCS sniff

[MediaWiki-commits] [Gerrit] Rename ChangeOpClaimRemove to ChangeOpStatementRemove - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/216659 Change subject: Rename ChangeOpClaimRemove to ChangeOpStatementRemove .. Rename ChangeOpClaimRemove to ChangeOpStatementRemove

[MediaWiki-commits] [Gerrit] Reduce number of $claimGuid variables in repo - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/216744 Change subject: Reduce number of $claimGuid variables in repo .. Reduce number of $claimGuid variables in repo This is a very

[MediaWiki-commits] [Gerrit] Do not mock precision int with a string - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/216769 Change subject: Do not mock precision int with a string .. Do not mock precision int with a string This is a wild guess for

[MediaWiki-commits] [Gerrit] Try different mocking in HtmlTimeFormatterTest - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/216862 Change subject: Try different mocking in HtmlTimeFormatterTest .. Try different mocking in HtmlTimeFormatterTest An other try

[MediaWiki-commits] [Gerrit] More expressive doc tags for formatter implementations - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/217028 Change subject: More expressive doc tags for formatter implementations .. More expressive doc tags for formatter implementations

[MediaWiki-commits] [Gerrit] Rework EntityTermsViewTest to not break on Travis - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/217029 Change subject: Rework EntityTermsViewTest to not break on Travis .. Rework EntityTermsViewTest to not break on Travis This

[MediaWiki-commits] [Gerrit] Fix EntityFactory calling a non-existing newEmpty method - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/217159 Change subject: Fix EntityFactory calling a non-existing newEmpty method .. Fix EntityFactory calling a non-existing newEmpty

[MediaWiki-commits] [Gerrit] Phase out deprecated EntityFactory::singleton - change (mediawiki...Wikibase)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/217243 Change subject: Phase out deprecated EntityFactory::singleton .. Phase out deprecated EntityFactory::singleton This patch

[MediaWiki-commits] [Gerrit] Fix incomplete PHPDoc tags in ApiBase - change (mediawiki/core)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/235447 Change subject: Fix incomplete PHPDoc tags in ApiBase .. Fix incomplete PHPDoc tags in ApiBase Change-Id

[MediaWiki-commits] [Gerrit] Remove non-existing param PHPDoc tag from Title - change (mediawiki/core)

Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/235448 Change subject: Remove non-existing param PHPDoc tag from Title .. Remove non-existing param PHPDoc tag from Title Change-Id

  1   2   3   4   5   6   7   8   9   10   >