Re: [Mesa-dev] [PATCH 6/6] ac: use llvm.amdgcn.s.buffer.load

2019-01-14 Thread Marek Olšák
Yes, I'll remove this patch. Marek On Sun, Jan 13, 2019 at 10:17 AM Bas Nieuwenhuizen wrote: > I think this is done with > > https://patchwork.freedesktop.org/series/55025/ > > ? > > On Sat, Jan 12, 2019 at 12:53 AM Marek Olšák wrote: > > > > From: Marek Olšák

Re: [Mesa-dev] [PATCH 1/7] mesa: implement ARB/KHR_parallel_shader_compile

2019-01-11 Thread Marek Olšák
On Thu, Jan 3, 2019 at 2:40 PM Ian Romanick wrote: > On 11/28/18 6:59 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > Tested by piglit. > > It doesn't look like there are any piglit test > > > --- > > docs/features.txt

Re: [Mesa-dev] [PATCH 2/6] radeonsi: fix rendering to tiny viewports where the viewport center is > 8K

2019-01-11 Thread Marek Olšák
On Fri, Jan 11, 2019 at 6:53 PM Marek Olšák wrote: > From: Marek Olšák > > This fixes an assertion failure with GLCTX when cts-runner is used. > (not a specific test) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108877 > Cc: 18.3 > --- > .../drivers/r

[Mesa-dev] [PATCH 5/6] radeonsi: compile clear and copy buffer compute shaders on demand

2019-01-11 Thread Marek Olšák
From: Marek Olšák same as all other shaders --- src/gallium/drivers/radeonsi/si_compute_blit.c | 14 ++ src/gallium/drivers/radeonsi/si_pipe.c | 8 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute_blit.c b/src

[Mesa-dev] [PATCH 3/6] radeonsi: use buffer_store_format_x & xy

2019-01-11 Thread Marek Olšák
From: Marek Olšák --- .../drivers/radeonsi/si_shader_tgsi_mem.c | 25 +-- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c index 6decedc4cce..727def56f65

[Mesa-dev] [PATCH 2/6] radeonsi: fix rendering to tiny viewports where the viewport center is > 8K

2019-01-11 Thread Marek Olšák
From: Marek Olšák This fixes an assertion failure with GLCTX when cts-runner is used. (not a specific test) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108877 Cc: 18.3 --- .../drivers/radeonsi/si_state_viewport.c | 21 --- 1 file changed, 18 insertions(+), 3

[Mesa-dev] [PATCH 1/6] radeonsi: fix a u_blitter crash after a shader with FBFETCH

2019-01-11 Thread Marek Olšák
From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108877 Cc: 18.3 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 6/6] ac: use llvm.amdgcn.s.buffer.load

2019-01-11 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 18 +- .../drivers/radeonsi/si_shader_tgsi_mem.c | 4 ++-- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 4/6] radeonsi: remove redundant call to emit_cache_flush in compute clear/copy

2019-01-11 Thread Marek Olšák
From: Marek Olšák launch_grid calls it. --- src/gallium/drivers/radeonsi/si_compute_blit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute_blit.c b/src/gallium/drivers/radeonsi/si_compute_blit.c index 086793637f0..11da04bed85 100644 --- a/src/gallium

[Mesa-dev] [PATCH] st/dri: fix dri2_format_table for argb1555 and rgb565

2019-01-11 Thread Marek Olšák
From: Marek Olšák The bug caused that rgb565 framebuffers used argb1555. Fixes: 433ca3127a3b94bfe9a513e7c7ce594e09e1359f --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny wrote: > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Woll

Re: [Mesa-dev] Please bring back __GL_FSAA_MODE

2019-01-10 Thread Marek Olšák
t; nvidia __GL_FSAA_MODE works as intended provided you set wine's > OffScreenRenderingMode to "backbuffer" which slightly impacts performance > but doesn't matter for older games. I'd love to see the functionality > return for AMD GPUs. > > Kind Regards, > > Tom >

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-09 Thread Marek Olšák
On Wed, Jan 9, 2019 at 11:58 AM Roland Scheidegger wrote: > Am 08.01.19 um 21:03 schrieb Marek Olšák: > > On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger > <mailto:srol...@vmware.com>> wrote: > > > > Am 08.01.19 um 17:17 schrieb Marek Olšák: > >

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019, 7:55 PM Ilia Mirkin On Tue, Jan 8, 2019 at 7:26 PM Marek Olšák wrote: > > > > On Tue, Jan 8, 2019 at 7:18 PM Ilia Mirkin wrote: > >> > >> On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: > >> > > >> &g

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019 at 7:18 PM Ilia Mirkin wrote: > On Tue, Jan 8, 2019 at 6:21 PM Marek Olšák wrote: > > > > On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: > >> > >> Why does this need to be in p_state? And who is responsible for > >> setting i

Re: [Mesa-dev] [PATCH] gallium: add pipe_grid_info::partial_block

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019 at 5:25 PM Ilia Mirkin wrote: > Why does this need to be in p_state? And who is responsible for > setting it (and how will it be set)? > Oh right, there is a way to get it out of p_state.h if needed. It should be set to 0 by default. If your thread block is 8x8x1, but you

Re: [Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Marek Olšák
On Tue, Jan 8, 2019 at 12:54 PM Roland Scheidegger wrote: > Am 08.01.19 um 17:17 schrieb Marek Olšák: > > From: Marek Olšák > > > > We have found some pipe_surface leaks internally. > > > > This is the same code as surface_destroy in radeonsi. &

[Mesa-dev] [PATCH] st/mesa: don't leak pipe_surface if pipe_context is not current

2019-01-08 Thread Marek Olšák
From: Marek Olšák We have found some pipe_surface leaks internally. This is the same code as surface_destroy in radeonsi. Ideally, surface_destroy would be in pipe_screen. No, pipe_surfaces are not context objects. Cc: 18.3 19.0 --- src/gallium/auxiliary/util/u_inlines.h | 19

[Mesa-dev] [PATCH 2/2] st/mesa: don't reference pipe_surface locally in PBO code

2019-01-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_texture.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 45918e425ac..ff4694da9e0 100644 --- a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH 1/2] st/mesa: unify window-system renderbuffer initialization

2019-01-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_cb_eglimage.c | 11 + src/mesa/state_tracker/st_manager.c | 32 - src/mesa/state_tracker/st_manager.h | 6 + 3 files changed, 28 insertions(+), 21 deletions(-) diff --git a/src/mesa/state_tracker

[Mesa-dev] [PATCH] winsys/amdgpu: use the new BO list API

2019-01-07 Thread Marek Olšák
From: Marek Olšák --- I'll bump the libdrm version requirement after the libdrm patch lands. src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 74 --- 1 file changed, 25 insertions(+), 49 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi: Fix use of 1- or 2- component GL_DOUBLE vbo's.

2019-01-07 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Jan 7, 2019 at 1:42 PM Mario Kleiner wrote: > With Mesa 18.1, commit be973ed21f6e, si_llvm_load_input_vs() > changed the number of source 32-bit wide dword components > used for fetching vertex attributes into the vertex shader > from

Re: [Mesa-dev] [PATCH 2/3] ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs()

2019-01-07 Thread Marek Olšák
On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri wrote: > The following patch will use this with the radeonsi NIR backend > but I've added it to ac so we can use it with RADV in future. > > This is a NIR implementation of the tgsi function > tgsi_scan_tess_ctrl(). > --- >

Re: [Mesa-dev] [PATCH 1/7] mesa: implement ARB/KHR_parallel_shader_compile

2019-01-02 Thread Marek Olšák
Ping. I'll push this by the end of the week. Marek On Wed, Nov 28, 2018 at 9:59 PM Marek Olšák wrote: > From: Marek Olšák > > Tested by piglit. > --- > docs/features.txt | 2 +- > docs/relnotes/19.0.0.html | 2 ++ > src/mapi

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Marek Olšák
a stable API. In tree state trackers can be fixed easily. We shouldn't worry too much about closed source state trackers. Marek > --Ken > > On Friday, December 21, 2018 1:24:32 PM PST Marek Olšák wrote: > > The series looks good. Another way to distinguish between return one and &g

Re: [Mesa-dev] [PATCH 6/6] st/nir: Drop unused gl_program parameter in VS input handling helper.

2018-12-21 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Mon, Dec 17, 2018 at 1:37 PM Kenneth Graunke wrote: > Nobody uses this, so let's drop it. This makes the helper callable > from places without a gl_program. > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 ++-- > 1

Re: [Mesa-dev] [PATCH 1/3] st/mesa: Make an enum for pipeline statistics query result indices.

2018-12-21 Thread Marek Olšák
The series looks good. Another way to distinguish between return one and return all is to use "index". index <= 11 returns one. index == ~0 returns all. This is the least intrusive. st/mesa and gallium/hud always want to get one. st/nine and util/u_helpers always want to get all. Marek On Sat,

Re: [Mesa-dev] [PATCH 3/3] radeonsi: make use of ac_are_tessfactors_def_in_all_invocs()

2018-12-21 Thread Marek Olšák
Nice. For the series: Reviewed-by: Marek Olšák Marek On Mon, Dec 17, 2018 at 8:18 PM Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/

Re: [Mesa-dev] [PATCH 2/2] tgsi/scan: correctly walk instructions in tgsi_scan_tess_ctrl()

2018-12-21 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:33 AM Timothy Arceri wrote: > The previous code used a do while loop and continues after walking > a nested loop/if-statement. This means we end up evaluating the > last instruction from the nested bloc

Re: [Mesa-dev] [PATCH] amd/surface: fix setting of ADDR2_SURFACE_FLAGS::color

2018-12-20 Thread Marek Olšák
On Thu, Dec 20, 2018, 4:05 AM Bas Nieuwenhuizen On Thu, Dec 20, 2018 at 9:00 AM Marek Olšák wrote: > > > > I prefer Nicolai's patch because it's shorter and doesn't need driver > changes. > > > > Reviewed-by: Marek Olšák > > This patch still needs driver

Re: [Mesa-dev] [PATCH] ac/nir: remove the bitfield_extract workaround for LLVM 8

2018-12-20 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Dec 19, 2018 at 11:50 AM Samuel Pitoiset wrote: > This workaround has been introduced by 3d41757788a and it > is no longer needed since LLVM r346422. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_

Re: [Mesa-dev] [PATCH] amd/surface: fix setting of ADDR2_SURFACE_FLAGS::color

2018-12-20 Thread Marek Olšák
I prefer Nicolai's patch because it's shorter and doesn't need driver changes. Reviewed-by: Marek Olšák Marek On Tue, Dec 18, 2018 at 12:50 PM Haehnle, Nicolai wrote: > On 18.12.18 18:36, Bas Nieuwenhuizen wrote: > > Hi Nicolai, > > > > I happened to be writing somethi

Re: [Mesa-dev] [PATCH 01/38] ac: add various helpers for float16/int16/int8

2018-12-19 Thread Marek Olšák
; On Tue, 18 Dec 2018 at 02:48, Marek Olšák wrote: > > > > On Fri, Dec 7, 2018 at 12:22 PM Rhys Perry > wrote: > >> > >> Signed-off-by: Rhys Perry > >> --- > >> src/amd/common/ac_llvm_build.c | 123 ++--

Re: [Mesa-dev] [PATCH 08/16] freedreno: a2xx: enable early-Z testing

2018-12-19 Thread Marek Olšák
On Wed, Dec 19, 2018, 3:32 PM Eric Anholt Jonathan marek writes: > > > Hi, > > > > I didn't verify it, but both r600 and a3xx disable earlyZ when alpha > > test is enabled, so this is almost certainly right. > > > > We don't need to worry about the shader writing Z, it is not part of > > OpenGL

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2018-12-19 Thread Marek Olšák
FWIW, with all the feedback I've given, I think autotools is not better than meson. The issues that I reported won't make me switch back to autotools. Marek On Wed, Dec 19, 2018, 12:45 PM Jason Ekstrand On Wed, Dec 19, 2018 at 10:32 AM Ilia Mirkin wrote: > >> On Wed, Dec 19, 2018 at 11:03 AM

Re: [Mesa-dev] [PATCH 35/38] ac,radv: run LLVM's SLP vectorizer

2018-12-17 Thread Marek Olšák
Can you remove AC_TM_SLP_VECTORIZE and run the pass unconditionally on >= gfx9? Thanks, Marek On Fri, Dec 7, 2018 at 12:23 PM Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_llvm_util.c | 9 ++--- > src/amd/common/ac_llvm_util.h | 1 + >

Re: [Mesa-dev] [PATCH 26/38] ac/nir: implement 8 and 16 bit ac_build_imsb

2018-12-17 Thread Marek Olšák
On Fri, Dec 7, 2018 at 12:23 PM Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_llvm_build.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/amd/common/ac_llvm_build.c > b/src/amd/common/ac_llvm_build.c > index 0123f3e31d..2172d81f8b 100644 > ---

Re: [Mesa-dev] [PATCH 01/38] ac: add various helpers for float16/int16/int8

2018-12-17 Thread Marek Olšák
On Fri, Dec 7, 2018 at 12:22 PM Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/amd/common/ac_llvm_build.c | 123 ++-- > src/amd/common/ac_llvm_build.h | 22 +- > src/amd/common/ac_nir_to_llvm.c | 30 > 3 files changed, 154 insertions(+),

Re: [Mesa-dev] last call for autotools

2018-12-17 Thread Marek Olšák
On Mon, Dec 17, 2018 at 1:18 PM Eric Anholt wrote: > Eero Tamminen writes: > > > Hi, > > > > On 17.12.2018 8.08, Marek Olšák wrote: > > [...] > >> I think one of the serious usability issues is that environment > >> variables such a

Re: [Mesa-dev] last call for autotools

2018-12-16 Thread Marek Olšák
On Sun, Dec 16, 2018 at 9:19 PM Marek Olšák wrote: > On Thu, Dec 13, 2018 at 7:48 PM Dylan Baker wrote: > >> Quoting Marek Olšák (2018-12-13 11:28:10) >> > Another issue with meson is this: >> > >> > I have to set PKG_CONFIG_PATH when I type meson f

Re: [Mesa-dev] [PATCH 25/25] radeonsi: const-ify the si_query_ops

2018-12-16 Thread Marek Olšák
Except for patch 3, the series is: Reviewed-by: Marek Olšák Marek On Thu, Dec 6, 2018 at 9:01 AM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- > src/gallium/drivers/radeonsi/si_query.c | 6 +++--- > s

Re: [Mesa-dev] [PATCH 03/25] amd/common: cleanup DATA_FORMAT/NUM_FORMAT field names

2018-12-16 Thread Marek Olšák
The definitions weren't changed, but the values were. The names need to be different, so that si_debug.c prints both the GFX6 and GFX9 values. Marek On Thu, Dec 6, 2018 at 9:01 AM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The definition wasn't actually changed in gfx9, so having the

Re: [Mesa-dev] [PATCH] st/mesa: remove sampler associated with buffer texture in pbo logic

2018-12-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 8:43 PM Ilia Mirkin wrote: > A long time ago, when this was first implemented, not having a sampler > bound would cause problems on Fermi. I didn't work out the reasons, but > the solution was simple -- just put the samp

Re: [Mesa-dev] [PATCH 1/2] ddebug: simplify watchdog loop and fix crash in the no-timeout case

2018-12-16 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Dec 6, 2018 at 7:57 AM Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The following race condition could occur in the no-timeout case: > > API thread Gallium thread

Re: [Mesa-dev] [PATCH 4/8] st/mesa: expose GL_NV_shader_atomic_float when ATOMFADD is supported

2018-12-16 Thread Marek Olšák
For patches 1-4: Reviewed-by: Marek Olšák Marek On Wed, Dec 5, 2018 at 12:29 AM Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_extensions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mesa/state_tracker/st_extensi

Re: [Mesa-dev] last call for autotools

2018-12-16 Thread Marek Olšák
On Thu, Dec 13, 2018 at 7:48 PM Dylan Baker wrote: > Quoting Marek Olšák (2018-12-13 11:28:10) > > Another issue with meson is this: > > > > I have to set PKG_CONFIG_PATH when I type meson for 32-bit builds. If I > do > > meson configure --clearcache and then typ

Re: [Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

2018-12-14 Thread Marek Olšák
t buffers that are written > to only once, thus always unmapping on first unmap. > For the buffers often written to, the cost of the first unmap will be > negligible. > > What do you think ? > > Axel > > On 14/12/2018 22:24, Marek Olšák wrote: > > From

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

2018-12-14 Thread Marek Olšák
On Fri, Dec 14, 2018 at 9:16 PM Timothy Arceri wrote: > On 15/12/18 7:32 am, Marek Olšák wrote: > > For patches 1-3: > > > > Reviewed-by: Marek Olšák marek.ol...@amd.com>> > > > > Thanks! > > > I'm not so knowledgeable to be able to comment

[Mesa-dev] [PATCH 4/6] radeonsi: use u_decomposed_prims_for_vertices instead of u_prims_for_vertices

2018-12-14 Thread Marek Olšák
From: Marek Olšák It seems to be the same, but this doesn't use integer division with a variable divisor. --- src/gallium/drivers/radeonsi/si_state_draw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers

[Mesa-dev] [PATCH 6/6] radeonsi: always unmap texture CPU mappings on 32-bit CPU architectures

2018-12-14 Thread Marek Olšák
From: Marek Olšák Team Fortress 2 32-bit version runs out of the CPU address space. --- src/gallium/drivers/radeonsi/si_texture.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_texture.c b/src/gallium/drivers/radeonsi/si_texture.c index

[Mesa-dev] [PATCH 2/6] radeonsi: call si_fix_resource_usage for the GS copy shader as well

2018-12-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index ee0c668431c..68afff449fd 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++ b

[Mesa-dev] [PATCH 5/6] radeonsi: remove unused variables in si_insert_input_ptr

2018-12-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 68afff449fd..250e0cc5db4 100644 --- a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 1/6] radeonsi: don't emit redundant PKT3_NUM_INSTANCES packets

2018-12-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.h | 3 +++ src/gallium/drivers/radeonsi/si_state_draw.c | 9 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.h b/src/gallium/drivers/radeonsi/si_pipe.h index

[Mesa-dev] [PATCH 3/6] radeonsi: make si_cp_wait_mem more configurable

2018-12-14 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_fence.c | 6 ++ src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_query.c | 3 ++- src/gallium/drivers/radeonsi/si_state_draw.c | 3

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

2018-12-14 Thread Marek Olšák
d to the opposite direction. > > BR, > -R > > > On Fri, Dec 14, 2018 at 3:38 PM Marek Olšák wrote: > > > > Can you please call it invalidate_subresource and inline relevant > pipe_surface variables inside the parameters? > > > > Thanks, > > Marek

Re: [Mesa-dev] [PATCH v2 3/6] gallium: add pipe->invalidate_surface()

2018-12-14 Thread Marek Olšák
Can you please call it invalidate_subresource and inline relevant pipe_surface variables inside the parameters? Thanks, Marek On Wed, Dec 12, 2018 at 10:48 AM Rob Clark wrote: > A new API to implement glInvalidateFramebuffer() and friends. It is > similar to invalidate_resource() but can be

Re: [Mesa-dev] [PATCH 4/4] nir: link time opt duplicate varyings

2018-12-14 Thread Marek Olšák
For patches 1-3: Reviewed-by: Marek Olšák I'm not so knowledgeable to be able to comment on patch 4. Does it also merge varyings such as (x,y,undef,undef) and (x,undef,undef,w)? There is a game which outputs (x,y,z,undef) and (x,y,undef,undef) where the vertex shader is a SSO. Marek On Mon

Re: [Mesa-dev] [PATCH] st/nir: Use nir_src_as_uint for tokens

2018-12-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:20 PM Jason Ekstrand wrote: > --- > src/mesa/state_tracker/st_nir_lower_builtin.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/src/mesa/state_tracker/st_nir_lower_builtin.c > b/src/

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] pci_ids: add new vega10 pci ids

2018-12-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Dec 14, 2018 at 12:01 PM Alex Deucher wrote: > Ping? > > Alex > On Fri, Dec 7, 2018 at 4:11 PM Alex Deucher wrote: > > > > Signed-off-by: Alex Deucher > > Cc: mesa-sta...@lists.freedesktop.org > > --- > &g

Re: [Mesa-dev] last call for autotools

2018-12-13 Thread Marek Olšák
So your issue is that meson upgrade broke the build and you are unable to get config.log. Let me tell you something. Ninja upgrade also breaks the build. I think that's the way it's going to be now. I think people will use the new build system anyway as conf and compile time is all that matters.

Re: [Mesa-dev] last call for autotools

2018-12-13 Thread Marek Olšák
Another issue with meson is this: I have to set PKG_CONFIG_PATH when I type meson for 32-bit builds. If I do meson configure --clearcache and then type "ninja", it will reconfigure, but will use 64-bit libraries instead because PKG_CONFIG_PATH is not set when ninja is run, which will fail to

Re: [Mesa-dev] Let's talk about -DDEBUG

2018-12-12 Thread Marek Olšák
On Wed, Dec 12, 2018 at 7:35 PM Rob Clark wrote: > On Wed, Dec 12, 2018 at 7:14 PM Dylan Baker wrote: > > > > Quoting Rob Clark (2018-12-12 15:52:47) > > > On Wed, Dec 12, 2018 at 6:25 PM Dylan Baker > wrote: > > > > > > > > In the autotools discussion I've come to realize that we also need >

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Marek Olšák
On Wed, Dec 12, 2018 at 5:14 PM Dylan Baker wrote: > Quoting Marek Olšák (2018-12-12 12:42:01) > > Most assertions and checks are enabled, because NDEBUG is not defined, > but > > DEBUG is not defined either, which is a Mesa-specific definition. > > > > The def

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Marek Olšák
On Wed, Dec 12, 2018 at 3:52 PM Rob Clark wrote: > On Wed, Dec 12, 2018 at 3:45 PM Marek Olšák wrote: > > > > On Wed, Dec 12, 2018 at 3:37 PM Rob Clark wrote: > >> > >> On Wed, Dec 12, 2018 at 3:13 PM Bas Nieuwenhuizen > >> wrote: > >> &

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Marek Olšák
On Wed, Dec 12, 2018 at 3:37 PM Rob Clark wrote: > On Wed, Dec 12, 2018 at 3:13 PM Bas Nieuwenhuizen > wrote: > > > > On Wed, Dec 12, 2018 at 8:59 PM Marek Olšák wrote: > > > > > > There are 2 issues with meson: > > > * -DDEBUG is not present in de

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Marek Olšák
doesn't re-run llvm-config. Marek On Wed, Dec 12, 2018 at 3:13 PM Bas Nieuwenhuizen wrote: > On Wed, Dec 12, 2018 at 8:59 PM Marek Olšák wrote: > > > > There are 2 issues with meson: > > * -DDEBUG is not present in debugoptimized builds. > > Do people expect -DDEB

Re: [Mesa-dev] last call for autotools

2018-12-12 Thread Marek Olšák
There are 2 issues with meson: * -DDEBUG is not present in debugoptimized builds. * meson ignores CFLAGS with --reconfigure, for example: CFLAGS="-DDEBUG" meson --reconfigure ... doesn't update CFLAGS. Marek On Mon, Dec 10, 2018 at 6:11 PM Dylan Baker wrote: > Meson 0.49.0 has been out for a

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: adjust the VGT workaround for prim restart on GFX9

2018-12-11 Thread Marek Olšák
It's up to you as long as you're OK with downgraded performance of triangle strips with primitive restart. Marek On Tue, Dec 11, 2018 at 10:08 AM Samuel Pitoiset wrote: > ping? > > After looking into this again today, I can't find any better solutions. > We should probably push this patch

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Marek Olšák
On Tue, Dec 4, 2018 at 7:18 PM Dylan Baker wrote: > Quoting Marek Olšák (2018-12-04 16:04:11) > > On Tue, Dec 4, 2018 at 7:01 PM Dylan Baker wrote: > > > > Quoting Marek Olšák (2018-12-04 14:52:19) > > > CFLAGS="-fno-omit-frame-pointer" \ >

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Marek Olšák
On Tue, Dec 4, 2018 at 7:01 PM Dylan Baker wrote: > Quoting Marek Olšák (2018-12-04 14:52:19) > > CFLAGS="-fno-omit-frame-pointer" \ > > CXXFLAGS="-fno-omit-frame-pointer" \ > > LDFLAGS="-fuse-ld=gold" \ > > meson $reconfigure

Re: [Mesa-dev] [PATCH v2] build: remove autotools

2018-12-04 Thread Marek Olšák
CFLAGS="-fno-omit-frame-pointer" \ CXXFLAGS="-fno-omit-frame-pointer" \ LDFLAGS="-fuse-ld=gold" \ meson $reconfigure build \ --prefix /usr --libdir /usr/lib/$archdir --buildtype debugoptimized --native-file $llvm_config \ -Dgallium-va=false -Dgallium-xvmc=false -Dgallium-omx=disabled

Re: [Mesa-dev] [PATCH v2 1/5] mesa: Add core support for EXT_multisampled_render_to_texture2

2018-12-04 Thread Marek Olšák
On Thu, Nov 29, 2018 at 7:50 PM Kristian Høgsberg wrote: > On Tue, Nov 6, 2018 at 3:03 PM Ilia Mirkin wrote: > > > > On Tue, Nov 6, 2018 at 5:18 PM Kristian H. Kristensen > > wrote: > > > > > > This also turns on EXT_multisampled_render_to_texture which is a > > > subset of

Re: [Mesa-dev] [PATCH] gallium: Android build fixes

2018-12-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 4, 2018 at 1:51 PM Kristian H. Kristensen wrote: > A couple of simple fixes for building on Android with autotools. > --- > src/gallium/auxiliary/util/u_debug_stack_android.cpp | 2 +- > src/gallium/drivers/freedreno/Makefile.am

Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Marek Olšák
There is still the issue that DEBUG is not defined in debug builds if I set CFLAGS and CXXFLAGS. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2

2018-12-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 4, 2018 at 6:51 AM Erik Faye-Lund wrote: > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make > sure the enums are accepted. > > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3&q

[Mesa-dev] [PATCH 1/2] mesa: expose EXT_texture_compression_rgtc on GLES

2018-12-04 Thread Marek Olšák
From: Marek Olšák The spec was modified to support GLES. Tested by piglit. v2: rebase Reviewed-by: Ilia Mirkin (v1) --- docs/relnotes/19.0.0.html| 1 + src/mesa/main/extensions_table.h | 2 +- src/mesa/main/glformats.c| 19 ++- src/mesa/main/texcompress.c

[Mesa-dev] [PATCH 2/2] mesa: expose EXT_texture_compression_bptc in GLES

2018-12-04 Thread Marek Olšák
From: Marek Olšák tested by piglit. v2: rebase Reviewed-by: Ilia Mirkin (v1) --- docs/relnotes/19.0.0.html| 1 + src/mesa/main/extensions_table.h | 1 + src/mesa/main/glformats.c| 13 - src/mesa/main/texcompress.c | 8 4 files changed, 22

Re: [Mesa-dev] Make Jordan an Owner of the mesa project?

2018-12-03 Thread Marek Olšák
Ack. On Mon, Dec 3, 2018, 7:49 PM Jason Ekstrand Jordan has requested to be made an Owner of the mesa project. As much as > I may be the guy who pushed to get everything set up, I don't want to do > this sort of thing on my own. As such, I'm asking for some ACKs. If I can > get 5 ACKs (at

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-12-03 Thread Marek Olšák
Looks good. Feel free to push this. Marek On Mon, Dec 3, 2018 at 5:05 AM Erik Faye-Lund wrote: > On Fri, 2018-11-30 at 18:15 -0500, Marek Olšák wrote: > > On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick > > wrote: > > > On 11/30/2018 02:17 PM, Marek Olšák wrote: > &

Re: [Mesa-dev] [PATCH] android: st/mesa: fix building error due to sched_getcpu()

2018-11-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Nov 30, 2018 at 7:03 PM Mauro Rossi wrote: > Android has cpufeatures library but pinning of threads is not supported > PIPE_OS_LINUX code path causes build error due to sched_getcpu() > unavailable > thus we need to avoid setting HAVE_

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
thing. Maybe to expose the GCN functionality we could do something > like > > PIPE_CAP_SURFACE_SAMPLE_COUNT: > 0 - unsupported > 1 - msaa per draw > 2 - msaa per renderpass > > ?? > > BR, > -R > > On Fri, Nov 30, 2018 at 3:41 PM Marek Olšák

Re: [Mesa-dev] [PATCH 03/30] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
Assuming you use _mesa_has_EXT_texture_compression_s3tc in the second hunk, the series is: Reviewed-by: Marek Olšák Marek On Mon, Nov 19, 2018 at 7:15 AM Erik Faye-Lund wrote: > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for th

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
On Fri, Nov 30, 2018 at 5:57 PM Ian Romanick wrote: > On 11/30/2018 02:17 PM, Marek Olšák wrote: > > > > > > On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund > > mailto:erik.faye-l...@collabora.com>> > wrote: > > > > S3_s3tc is the extension

Re: [Mesa-dev] [PATCH v2 03/29] mesa/main: clean up S3_s3tc check

2018-11-30 Thread Marek Olšák
On Fri, Nov 23, 2018 at 5:54 AM Erik Faye-Lund wrote: > S3_s3tc is the extension that enables this functionality on desktop, so > let's check for that one. The _mesa_has_S3_s3tc() helper already > verifies the API according to the extension-table. > > Signed-off-by: Erik Faye-Lund > --- >

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
GCN calls it overrasterization multisampling, but it's really only useful for polygon smoothing, because there is no temporary buffer. Marek On Fri, Nov 30, 2018 at 3:35 PM Rob Clark wrote: > On Fri, Nov 30, 2018 at 3:25 PM Marek Olšák wrote: > > > &

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
Suggestions: - PIPE_CAP_TILED_BASED_MSAA_OVERSAMPLING - pipe_surface::tile_based_oversample_count I'm assuming this feature isn't possible without tile-based rendering. Marek On Fri, Nov 30, 2018 at 1:23 PM Kristian Høgsberg wrote: > On Fri, Nov 30, 2018 at 10:17 AM Marek Olšák wr

Re: [Mesa-dev] [PATCH v2 2/5] gallium: Add new PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE

2018-11-30 Thread Marek Olšák
On Fri, Nov 30, 2018 at 1:13 PM Kristian Høgsberg wrote: > On Fri, Nov 16, 2018 at 7:48 PM Marek Olšák wrote: > > > > I think the name PIPE_CAP_MULTISAMPLED_RENDER_TO_TEXTURE is slightly > misleading, because it doesn't imply anything about the OpenGL ES behavior, > wh

[Mesa-dev] [PATCH] st/mesa: expose EXT_render_snorm on GLES

2018-11-29 Thread Marek Olšák
From: Marek Olšák --- docs/relnotes/19.0.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 8 2 files changed, 9 insertions(+) diff --git a/docs/relnotes/19.0.0.html b/docs/relnotes/19.0.0.html index f4522b654c6..04e06cdd758 100644 --- a/docs/relnotes/19.0.0.html

[Mesa-dev] [PATCH 5/7] util/queue: hold a lock when reading num_threads in util_queue_finish

2018-11-28 Thread Marek Olšák
From: Marek Olšák --- src/util/u_queue.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 5aaf60ae78e..612ad5e83c6 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c @@ -582,29 +582,29 @@ util_queue_finish_execute(void

[Mesa-dev] [PATCH 4/7] util/queue: add ability to kill a subset of threads

2018-11-28 Thread Marek Olšák
From: Marek Olšák for ARB_parallel_shader_compile --- src/util/u_queue.c | 49 +- src/util/u_queue.h | 5 ++--- 2 files changed, 33 insertions(+), 21 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 48c5c79552d..5aaf60ae78e

[Mesa-dev] [PATCH 6/7] util/queue: add util_queue_adjust_num_threads

2018-11-28 Thread Marek Olšák
From: Marek Olšák for ARB_parallel_shader_compile --- src/util/u_queue.c | 50 -- src/util/u_queue.h | 8 2 files changed, 52 insertions(+), 6 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 612ad5e83c6..383a9c09919

[Mesa-dev] [PATCH 1/7] mesa: implement ARB/KHR_parallel_shader_compile

2018-11-28 Thread Marek Olšák
From: Marek Olšák Tested by piglit. --- docs/features.txt | 2 +- docs/relnotes/19.0.0.html | 2 ++ src/mapi/glapi/gen/gl_API.xml | 15 ++- src/mesa/main/dd.h | 7 +++ src/mesa/main/extensions_table.h

[Mesa-dev] [PATCH 7/7] radeonsi: implement ARB/KHR_parallel_shader_compile callbacks

2018-11-28 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 503d8331906..cc56ce0c446 100644 --- a/src/gallium/drivers/radeonsi

[Mesa-dev] [PATCH 3/7] util/queue: move thread creation into a separate function

2018-11-28 Thread Marek Olšák
From: Marek Olšák --- src/util/u_queue.c | 56 ++ 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/src/util/u_queue.c b/src/util/u_queue.c index 3812c824b6d..48c5c79552d 100644 --- a/src/util/u_queue.c +++ b/src/util/u_queue.c

[Mesa-dev] [PATCH 2/7] gallium: implement ARB/KHR_parallel_shader_compile

2018-11-28 Thread Marek Olšák
From: Marek Olšák --- src/gallium/include/pipe/p_screen.h| 13 ++ src/mesa/state_tracker/st_cb_program.c | 59 +- 2 files changed, 71 insertions(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index

Re: [Mesa-dev] [PATCH 3/3] mesa: expose AMD_texture_texture4

2018-11-28 Thread Marek Olšák
PONENTS_ARB == 1, i.e. it's the > user's fault if something doesn't work. > > -ilia > On Wed, Nov 28, 2018 at 8:22 PM Marek Olšák wrote: > > > > From: Marek Olšák > > > > because the closed driver exposes it. Tested by piglit. > > --- > > docs/relno

Re: [Mesa-dev] [PATCH 1/3] radeonsi: allow si_cp_dma_clear_buffer to clear GDS from any IB

2018-11-28 Thread Marek Olšák
.com> wrote: > Are those committed yet? They don't seem to apply cleanly on master. > > Christian. > > Am 27.11.18 um 02:56 schrieb Marek Olšák: > > From: Marek Olšák > > > > --- > > .../drivers/radeonsi/si_compute_blit.c| 4 +- >

[Mesa-dev] [PATCH 3/3] mesa: expose AMD_texture_texture4

2018-11-28 Thread Marek Olšák
From: Marek Olšák because the closed driver exposes it. Tested by piglit. --- docs/relnotes/19.0.0.html| 1 + src/compiler/glsl/builtin_functions.cpp | 10 ++ src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ src/mesa

[Mesa-dev] [PATCH 2/3] mesa: expose EXT_texture_compression_bptc in GLES

2018-11-28 Thread Marek Olšák
From: Marek Olšák tested by piglit. --- docs/relnotes/19.0.0.html| 1 + src/mesa/main/extensions_table.h | 1 + src/mesa/main/glformats.c| 13 +++-- src/mesa/main/texcompress.c | 9 + 4 files changed, 22 insertions(+), 2 deletions(-) diff --git a/docs

[Mesa-dev] [PATCH 1/3] mesa: expose EXT_texture_compression_rgtc on GLES

2018-11-28 Thread Marek Olšák
From: Marek Olšák The spec was modified to support GLES. Tested by piglit. --- docs/relnotes/19.0.0.html| 1 + src/mesa/main/extensions_table.h | 2 +- src/mesa/main/glformats.c| 19 +-- src/mesa/main/texcompress.c | 9 + 4 files changed, 24

<    2   3   4   5   6   7   8   9   10   11   >