Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

Boris Brezillon writes: > Hello, > > Alyssa recently proposed that I push my own panfrost-related > submissions once they received proper review and are considered > ready to merged (meaning that received enough A-b/R-b tags). > > In order to do that, I'd need to obtain write permissions on the

Re: [Mesa-dev] [MR] Update README to recommend MRs instead of `git send-email`

Jason Ekstrand writes: > On Tue, Jul 9, 2019 at 11:19 AM Kristian Høgsberg > wrote: > >> On Tue, Jul 9, 2019 at 12:17 AM Daniel Stone wrote: >> > >> > Hi, >> > >> > On Sat, 6 Jul 2019 at 18:39, Ilia Mirkin wrote: >> > > I see this as driving away contributions, esp from new people. MR's >> >

Re: [Mesa-dev] [PATCH] radv/gfx10: do not set alignment on the ngg_emit pointer

R-b On Thu, Jul 11, 2019, 6:33 PM Samuel Pitoiset wrote: > This is invalid and this fixes a crash in LLVM. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_nir_to_llvm.c >

Re: [Mesa-dev] [PATCH 2/2] radv: report shader stage name when dumping LLVM IR

R-b for the series On Thu, Jul 11, 2019, 6:04 PM Samuel Pitoiset wrote: > For debugging purposes. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 21 + > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 2/2] radv/gfx10: fix exporting clip/cull distances for GS

R-b On Thu, Jul 11, 2019, 5:02 PM Samuel Pitoiset wrote: > This fixes dEQP-VK.clipping.user_defined.clip_distance.*geom*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] radv/gfx10: fix exporting the subpass view index for GS

R-b On Thu, Jul 11, 2019, 5:02 PM Samuel Pitoiset wrote: > This fixes dEQP-VK.multiview.*geometry*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] radeon/vcn: adding engine type for new fw interface

From: Boyuan Zhang Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.h | 2 ++ src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 1 + src/gallium/drivers/radeon/radeon_vcn_enc_2_0.c | 4 ++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radv/gfx10: update OVERWRITE_COMBINER_{MRT_SHARING, WATERMARK}

r-b. On Thu, 11 Jul 2019 at 23:51, Samuel Pitoiset wrote: > > DCC related, mirror RadeonSI. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 20 > 1 file changed, 4 insertions(+), 16 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] radv/gfx10: enable 1D textures

r-b On Thu, Jul 11, 2019 at 5:22 PM Samuel Pitoiset wrote: > > Mirror RadeonSI. This also fixes crashes in addrlib. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_image.c| 4 ++-- > src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 6 -- > 2 files

Re: [Mesa-dev] [PATCH] mesa: save/restore SSO flag when using ARB_get_program_binary

Reviewed-by: Jordan Justen On 2019-07-10 17:39:24, Timothy Arceri wrote: > Ping! The spec bug was updated and they have agreed to update the spec > to define this behavior. > > I've also sent a piglit test for this: > > https://patchwork.freedesktop.org/patch/317112/ > > On 1/7/19 12:25 pm,

Re: [Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

The test passes here. I wouldn't push a commit that doesn't pass. It looks like v3d can't blit stencil. Marek On Thu, Jul 11, 2019 at 6:29 AM apinheiro wrote: > Hi, the following piglit test: > > ./bin/fbo-stencil copypixels GL_DEPTH32F_STENCIL8 -auto -fbo > > regressed after this patch landed

[Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used

From: Jeremy Newton The amdgpu dri is used for the closed source AMD driver. Since this driver does not implement multimedia, we fall back to radeonsi in mesa to do multimedia. This corrects the dri driver name for when it is set to amdgpu. Signed-off-by: Jeremy Newton Signed-off-by: Marek

[Mesa-dev] [PATCH] radv/gfx10: do not set alignment on the ngg_emit pointer

This is invalid and this fixes a crash in LLVM. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index bf712b7fe45..32548857b57 100644 ---

[Mesa-dev] [PATCH] radv/gfx10: enable 1D textures

Mirror RadeonSI. This also fixes crashes in addrlib. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c| 4 ++-- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radv: report shader stage name when dumping LLVM IR

For debugging purposes. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index 32548857b57..e4ab5847729 100644

[Mesa-dev] [PATCH 1/2] radv: tidy up radv_get_shader_name() and add NGG stages

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.c | 4 ++-- src/amd/vulkan/radv_shader.c | 37 +++- src/amd/vulkan/radv_shader.h | 3 ++- 3 files changed, 32 insertions(+), 12 deletions(-) diff --git a/src/amd/vulkan/radv_debug.c

[Mesa-dev] [PATCH] radv/gfx10: enable 1D textures

Mirror RadeonSI. This also fixes crashes in addrlib. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c| 4 ++-- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radv/gfx10: fix exporting clip/cull distances for GS

This fixes dEQP-VK.clipping.user_defined.clip_distance.*geom*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index

[Mesa-dev] [PATCH 1/2] radv/gfx10: fix exporting the subpass view index for GS

This fixes dEQP-VK.multiview.*geometry*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index

Re: [Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

On 2019-07-11 12:29 p.m., apinheiro wrote: > Hi, the following piglit test: > > ./bin/fbo-stencil copypixels GL_DEPTH32F_STENCIL8 -auto -fbo > > regressed after this patch landed master with the v3d driver. So Marek > and anyone reading this email, could you execute that test and confirms > if

[Mesa-dev] [PATCH] radv/gfx10: update OVERWRITE_COMBINER_{MRT_SHARING, WATERMARK}

DCC related, mirror RadeonSI. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index b7ee0ff6422..a2a4cb0adb2 100644

[Mesa-dev] [Bug 111109] mythtv rendering on gles surface gives black screen on lima/mali450

https://bugs.freedesktop.org/show_bug.cgi?id=09 Bug ID: 09 Summary: mythtv rendering on gles surface gives black screen on lima/mali450 Product: Mesa Version: git Hardware: ARM OS: Linux (All)

Re: [Mesa-dev] [PATCH] panfrost/midgard: Use _safe iterator

R-b signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] panfrost: Place the height value in the height field

This hunk is R-b, the rest are NAK-ed due to reasons I'm sure you realize (breaking MFBD ;) ) signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radv/gfx10: fix maximum number of mip levels for 3D images

r-b On Thu, Jul 11, 2019 at 2:24 PM Samuel Pitoiset wrote: > > The dimensions also have to be adjusted if the number of supported > mip levels is changed. > > This fixes dEQP-VK.api.info.image_format_properties.3d.*. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_formats.c | 14

[Mesa-dev] [PATCH] radv/gfx10: fix maximum number of mip levels for 3D images

The dimensions also have to be adjusted if the number of supported mip levels is changed. This fixes dEQP-VK.api.info.image_format_properties.3d.*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_formats.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [Bug 111107] 726a31df705b causes the in memory shader cache to use up to 5x more memory

https://bugs.freedesktop.org/show_bug.cgi?id=07 Bug ID: 07 Summary: 726a31df705b causes the in memory shader cache to use up to 5x more memory Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] radv/gfx10: disable TC-compat HTILE for multisampled D32_SFLOAT format

r-b On Thu, Jul 11, 2019 at 11:54 AM Samuel Pitoiset wrote: > > For some reasons D32_SFLOAT is also affected on GFX10, it works > fine with previous generations. > > This fixes some dEQP-VK.renderpass2.depth_stencil_resolve.*. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] st/mesa: accelerate glCopyPixels(STENCIL)

Hi, the following piglit test: ./bin/fbo-stencil copypixels GL_DEPTH32F_STENCIL8 -auto -fbo regressed after this patch landed master with the v3d driver. So Marek and anyone reading this email, could you execute that test and confirms if only regress with v3d? Thanks in advance. On 25/6/19

[Mesa-dev] [PATCH] panfrost/midgard: Use _safe iterator

Fixes this assertion: ../mesa/src/panfrost/midgard/midgard_schedule.c:507:schedule_block: Assertion `ins == __next && "use _safe iterator"' failed. Trace/breakpoint trap Signed-off-by: Tomeu Vizoso --- src/panfrost/midgard/midgard_schedule.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH v2] panfrost: Place the height value in the height field

In the mali_single_framebuffer descriptor. Signed-off-by: Tomeu Vizoso v2: Remove unwanted chunks --- src/gallium/drivers/panfrost/pan_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_context.c

[Mesa-dev] [PATCH] panfrost: Place the height value in the height field

In the mali_single_framebuffer descriptor. Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_context.c | 12 src/gallium/drivers/panfrost/pan_tiler.c | 12 src/gallium/drivers/panfrost/pan_tiler.h | 6 -- 3 files changed, 20 insertions(+), 10

[Mesa-dev] [PATCH] radv/gfx10: disable TC-compat HTILE for multisampled D32_SFLOAT format

For some reasons D32_SFLOAT is also affected on GFX10, it works fine with previous generations. This fixes some dEQP-VK.renderpass2.depth_stencil_resolve.*. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/9] radv/gfx10: implement support for GS as NGG

Reviewed-by: Bas Nieuwenhuizen for the series. On Thu, Jul 11, 2019 at 8:44 AM Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_nir_to_llvm.c | 540 +- > src/amd/vulkan/radv_pipeline.c| 5 +- >

[Mesa-dev] [Bug 111104] aaki_bug1

https://bugs.freedesktop.org/show_bug.cgi?id=04 Bug ID: 04 Summary: aaki_bug1 Product: Mesa Version: unspecified Hardware: Other OS: Windows (All) Status: NEW Severity: normal Priority:

Re: [Mesa-dev] EGL_BAD_CONTEXT error when creating shared context

Hi， Is there a solution to this problem? Because the following problems have arisen now: [ERROR:gl_context_egl.cc(198)] eglCreateContext failed with error EGL_BAD_MATCH [ERROR:gles2_command_buffer_stub.cc(263)] ContextResult::kFatalFailure: Failed to create shared context for

[Mesa-dev] [PATCH 1/9] radv/gfx10: fix number of GS invocations for NGG

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index f259f01bd75..2ea984c8328 100644 --- a/src/amd/vulkan/radv_pipeline.c +++

[Mesa-dev] [PATCH 8/9] radv/gfx10: Fix NGG GS output mask handlings for LDS indexing.

From: Bas Nieuwenhuizen In emit_vertex we optimize storage if the output mask does not have all bits set. Do the same in the epilogue so the indices actually match up. Fixes dEQP-VK.geometry.input.basic_primitive.points because it outputs PSIZE with an output mask of 1, which cause the generic

[Mesa-dev] [PATCH 2/9] radv/gfx10: fix VGT_SHADER_STAGES_EN for GS as NGG

The driver shouldn't set the copy shader bit. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH 9/9] radv/gfx10: enable geometry shaders

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index bfd72caa693..273078239c4 100644 --- a/src/amd/vulkan/radv_device.c +++

[Mesa-dev] [PATCH 4/9] radv/gfx10: Use correct ES shader for es_vgpr_comp_cnt for GS.

From: Bas Nieuwenhuizen Reviewed-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 79418b401fb..1987d439612 100644 --- a/src/amd/vulkan/radv_shader.c

[Mesa-dev] [PATCH 7/9] radv/gfx10: Simplify output mask handling for NGG GS.

From: Bas Nieuwenhuizen We only ever get in this function for a NGG GS proper. Reviewed-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c

[Mesa-dev] [PATCH 5/9] radv/gfx10: implement support for GS as NGG

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 540 +- src/amd/vulkan/radv_pipeline.c| 5 +- src/amd/vulkan/radv_private.h | 24 ++ src/amd/vulkan/radv_shader.c | 5 + 4 files changed, 568 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH 3/9] radv/gfx10: Do not allocate a gs_copy_shader on gfx10.

From: Bas Nieuwenhuizen Will use ngg for any gs anyway. Reviewed-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 5 +++-- src/amd/vulkan/radv_pipeline.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [PATCH 6/9] radv/gfx10: Do GS prologue outside of gs_threads if.

From: Bas Nieuwenhuizen Mirror radeonsi. Reviewed-by: Samuel Pitoiset --- src/amd/vulkan/radv_nir_to_llvm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c index dc37c937155..490b16a1f25