bad commit touching stmmac_ptp.c

2016-10-18 Thread Nicolas Pitre
Hello, I noticed a recently added commit 7086605a6a ("stmmac: fix error check when init ptp") to the mainline linux tree from you. This commit is wrong. The affected code now reads as: int stmmac_ptp_register(struct stmmac_priv *priv) { spin_lock_init(>ptp_lock);

Re: [PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > From: Simon Horman > > This allows GRE tunnels to send and receive both > layer 2 packets (packets with an ethernet header) and > layer 3 packets (packets without an ethernet header). > >

Re: [PATCH net-next v12 1/9] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > On tx, use hard_header_len while deciding whether to refragment or drop the > packet. That way, all combinations are calculated correctly: > > * L2 packet going to L2 interface (the L2 header len is subtracted), > * L2 packet

Re: [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly,

[RFC 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for iscsiuio interface using Light L2 (LL2) qed interface. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis

Re: [PATCH net-next v12 4/9] openvswitch: support MPLS push and pop for L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Update Ethernet header only if there is one. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar

Re: [PATCH net-next v12 3/9] openvswitch: pass mac_proto to ovs_vport_send

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > We'll need it to alter packets sent to ARPHRD_NONE interfaces. > > Change do_output() to use the actual L2 header size of the packet when > deciding on the minimum cutlen. The assumption here is that what matters is > not the

Re: [PATCH net-next v12 2/9] openvswitch: add mac_proto field to the flow key

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Use a hole in the structure. We support only Ethernet so far and will add > a support for L2-less packets shortly. We could use a bool to indicate > whether the Ethernet header is present or not but the approach with the >

Re: [RFC PATCH net-next] bpf: fix potential percpu map overcopy to user.

2016-10-18 Thread William Tu
> ... >> - if (copy_to_user(uvalue, value, value_size) != 0) >> + if (copy_to_user(uvalue, value, min_t(u32, usize, value_size)) != 0) >> goto free_value; > > I think such approach won't actually fix anything. User space > may lose some of the values and won't have any idea

Re: tg3 BUG: spinlock lockup suspected

2016-10-18 Thread Siva Reddy Kallam
On Mon, Oct 17, 2016 at 6:35 PM, Meelis Roos wrote: >> > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will >> > test further. >> >> It gets stranger and stranger - my old 4.7 image worked fine, freshly >> compiled 4.7 exhibits the same problem. >> >>

Re: [PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > At the core of this patch set is removing the assumption in Open vSwitch > datapath that all packets have Ethernet header. Support for layer 3 GRE > tunnels is also added by this patchset. > > The implementation relies on the

[RFC 5/6] qedi: Add support for iSCSI session management.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for iscsi_transport LLD Login, Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing and Firmware async event handling support. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi

[RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module for 41000 Series Converged Network Adapters by QLogic. This patch consists of following changes: - MAINTAINERS Makefile and Kconfig changes for qedi, - PCI driver

[RFC 6/6] qedi: Add support for data path.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis

[RFC 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This series introduces hardware offload iSCSI initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Qlogic. The overall driver design includes a common module ('qed') and protocol specific dependent modules ('qedi'

[RFC 2/6] qed: Add iSCSI out of order packet handling.

2016-10-18 Thread manish.rangankar
From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz

[RFC 1/6] qed: Add support for hardware offloaded iSCSI.

2016-10-18 Thread manish.rangankar
From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-18 Thread Herbert Xu
On Mon, Oct 17, 2016 at 06:21:14PM +0100, Ard Biesheuvel wrote: > > Annoyingly, all this complication with scatterlists etc is for doing > asynchronous crypto via DMA capable crypto accelerators, and the > networking code (ipsec as well as mac80211, afaik) only allow > synchronous in the first

[PATCH] tcp: Remove unused but set variable

2016-10-18 Thread Tobias Klauser
Remove the unused but set variable icsk in listening_get_next to fix the following GCC warning when building with 'W=1': net/ipv4/tcp_ipv4.c: In function ‘listening_get_next’: net/ipv4/tcp_ipv4.c:1890:31: warning: variable ‘icsk’ set but not used [-Wunused-but-set-variable] Signed-off-by:

utilisateur salut

2016-10-18 Thread Zimbra
utilisateur salut Votre compte Zimbra doit être vérifié pour éviter De-activation. 00:28:50 -0500 Octobre 2016 Vous avez moins de 24 heures. Cliquez sur le lien ci-dessous pour continuer le bouton en utilisant ce service http://frenchunivgrade-001-dept-nakjsak.tripod.com/ Continuer avec

[PATCH v3 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c

2016-10-18 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren ---

[PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

2016-10-18 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 12 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_common.h |

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Raju Lakkaraju
Hi Andrew, On Tue, Oct 18, 2016 at 12:58:20PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > > In fact, this looks a lot like netdev features (e.g: checksum > > > offload), and there seems to be some commonality here between at > > > least Marvell and Microsemi (for the faster link down

[PATCH v3 net-next 1/8] net: qualcomm: remove unnecessary includes

2016-10-18 Thread Stefan Wahren
Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c

[PATCH v3 net-next 7/8] net: qualcomm: make qca_common a separate kernel module

2016-10-18 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile | 5

RE: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-18 Thread Yotam Gigi
>-Original Message- >From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] >Sent: Tuesday, October 18, 2016 3:17 AM >To: Jamal Hadi Salim >Cc: Jiri Pirko ; netdev@vger.kernel.org; da...@davemloft.net; >Yotam Gigi ; Ido Schimmel

PowerEdge R530 show rx dropped packet with BCM5720

2016-10-18 Thread Roberto Fichera
Hi All, I'm having a problem with a Dell PowerEdge R530 running a Fedora 24 with kernel 4.7.7-200.fc24.x86_64 that is showing RX dropped packet on all the onboard BCM5720 4x1Gbits interfaces. I've done several tests replacing cables and switches as well as disabling all rx offload features

[PATCH] cxgb4: Fix number of queue sets corssing the limit

2016-10-18 Thread Ganesh Goudar
Do not let number of offload queue sets to go more than MAX_OFLD_QSETS, which would otherwise crash the driver on machines with cores more than MAX_OFLD_QSETS. Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- 1 file changed, 1

Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-10-18 Thread Sergei Shtylyov
Hello! On 9/28/2016 8:14 PM, Florian Fainelli wrote: The PHY interrupts are now handled in a threaded interrupt handler, which can sleep. The work queue is no longer needed, phy_change() can be called directly. Additionally, none of the callers of phy_mac_interrupt() did so in interrupt

[PATCH] ipv4: Remove unused but set variable

2016-10-18 Thread Tobias Klauser
Remove the unused but set variable dev in ip_do_fragment to fix the following GCC warning when building with 'W=1': net/ipv4/ip_output.c: In function ‘ip_do_fragment’: net/ipv4/ip_output.c:541:21: warning: variable ‘dev’ set but not used [-Wunused-but-set-variable] Signed-off-by: Tobias

RE: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-18 Thread Koehrer Mathias (ETAS/ESW5)
Hi all, > > >> > > >> Can you continue your bisection using 'git bisect'? You've already > > >> narrowed it down between 4.0 and 4.1, so you're well on your way. > > >> > > > > > > OK - done. > > > And finally I was successful! > > > The following git commit is the one that is causing the

Re: [STLinux Kernel] [PATCH 18/19] stmmac: dwmac-sti: Remove obsolete STi platforms

2016-10-18 Thread Patrice Chotard
On 10/18/2016 10:05 AM, Patrice Chotard wrote: > > > On 09/23/2016 05:11 PM, Rob Herring wrote: >> On Wed, Sep 14, 2016 at 02:27:56PM +0100, Peter Griffin wrote: >>> This patch removes support for STiH415/6 SoC's from the >>> dwmac-sti driver and dt binding doc, as support for these >>>

Re: [v12, 0/8] Fix eSDHC host version register bug

2016-10-18 Thread Ulf Hansson
On 21 September 2016 at 08:57, Yangbo Lu wrote: > This patchset is used to fix a host version register bug in the > T4240-R1.0-R2.0 > eSDHC controller. To match the SoC version and revision, 10 previous version > patchsets had tried many methods but all of them were rejected

Re: [PATCH RFC 3/6] net: phy: Threaded interrupts allow some simplification

2016-10-18 Thread Andrew Lunn
>Actually, I still don't know how to call phy_mac_interrupt() from > the ravb driver because of the 'new_link' parameter -- I won't > always have that signal connected to the MAC... I'm not sure that parameter is of any use. I really think the semantics of this call should be, something has

Re: [PATCH net] conntrack: perform a full scan in gc

2016-10-18 Thread Florian Westphal
Nicolas Dichtel wrote: > After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove > timed-out entries"), netlink conntrack deletion events may be sent with a > huge delay (5 minutes). > > There is two ways to evict conntrack: > - during a conntrack

Re: [PATCH net-next 1/2] net: phy: Add Speed downshift set driver for Microsemi PHYs.

2016-10-18 Thread Raju Lakkaraju
Hi Florian, Thank you for review comments. On Mon, Oct 17, 2016 at 05:38:46AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On October 17, 2016 12:31:54 AM PDT, Raju Lakkaraju > wrote: > >Hi Andrew, > > > >Thank you for code review and comments. > > >

Re: [PATCH net] conntrack: perform a full scan in gc

2016-10-18 Thread Nicolas Dichtel
Le 18/10/2016 à 10:47, Florian Westphal a écrit : > Nicolas Dichtel wrote: >> After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove >> timed-out entries"), netlink conntrack deletion events may be sent with a >> huge delay (5 minutes). >> >> There is

Re: Need help with mdiobus_register and phy

2016-10-18 Thread Zefir Kurtisi
On 10/17/2016 10:53 PM, Timur Tabi wrote: > Zefir Kurtisi wrote: >> Anyway, since the SGMII reset is required, instead of reverting the patch in >> full >> I suggest to move the SGMII power down from at803x_suspend() and do a SerDes >> power >> cycle in at803x_resume(). Could you please test if

[PATCH net] conntrack: perform a full scan in gc

2016-10-18 Thread Nicolas Dichtel
After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove timed-out entries"), netlink conntrack deletion events may be sent with a huge delay (5 minutes). There is two ways to evict conntrack: - during a conntrack lookup; - during a conntrack dump. Let's do a full scan of

[PATCH v4 2/4] net: phy: dp83867: add support for MAC impedance configuration

2016-10-18 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N --- drivers/net/phy/dp83867.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..1b63924

[PATCH v4 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-10-18 Thread Mugunthan V N
Add support for configurable impedance control for TI dp83867 phy via devicetree. More documentation in [1]. CPSW second ethernet is not working, fix it by enabling impedance configuration on the phy. Verified the patch on DRA72 Rev C evm, logs at [2]. Also pushed a branch [3] for others to test.

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Andrew Lunn
> > In fact, this looks a lot like netdev features (e.g: checksum > > offload), and there seems to be some commonality here between at > > least Marvell and Microsemi (for the faster link down reporting), > > so maybe we should start adding PHY features similar to netdev > > features? > Sure. >

[PATCH v4 1/4] net: phy: dp83867: Add documentation for optional impedance control

2016-10-18 Thread Mugunthan V N
Add documention of ti,min-output-impedance and ti,max-output-impedance which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 1 file changed,

[PATCH v4 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay

2016-10-18 Thread Mugunthan V N
The current delay settings of the phy are not the optimal value, fix it with correct values. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/dra72-evm-revc.dts | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v4 3/4] ARM: dts: dra72-evm-revc: add phy impedance settings

2016-10-18 Thread Mugunthan V N
The default impedance settings of the phy is not the optimal value, due to this the second ethernet is not working. Fix it with correct values which makes the second ethernet port to work. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++ 1 file

[PATCH v3 net-next 0/8] net: qualcomm: add QCA7000 UART driver

2016-10-18 Thread Stefan Wahren
The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces: UART and SPI. This patch series adds the missing support for UART. This driver based on the Qualcomm code [1], but contains some changes: * use random MAC address per default * use net_device_stats from device * share frame decoding

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Andrew Lunn
> Do i need to change Ethtool application and submit along with > downshift driver patch (i.e. ethtool.c, phy.c, cpsw.c and mscc.c changes) ? Yes, please submit two patchset. One patchset for ethtool and its man page and a second patchset for all the kernel changes. Thanks Andrew

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread Andrew Lunn
On Tue, Oct 18, 2016 at 02:12:40PM +0200, John Crispin wrote: > The shutdown code only stopped the PHYs but does not diconnect them > properly. This could lead to null pointer deref related kernel oopses > during reboot. Fix this by calling phy_disconnect() after the PHYs are > stopped. Humm, i

Re: [PATCH net v2] flow_dissector: Check skb for VLAN only if skb specified.

2016-10-18 Thread Jakub Sitnicki
On Mon, Oct 17, 2016 at 08:30 PM GMT, Eric Garver wrote: > Fixes a panic when calling eth_get_headlen(). Noticed on i40e driver. > > Fixes: d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from > skb->vlan_tci") > Signed-off-by: Eric Garver > --- >

Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:13, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > get_user_pages_unlocked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [PATCH 3/9] ipv6: sr: add support for SRH encapsulation and injection with lwtunnels

2016-10-18 Thread David Lebrun
On 10/17/2016 07:17 PM, Tom Herbert wrote: >> > + err = ip6_dst_lookup(net, sk, , ); > Please look at the use of dst_cache that I added in ila_lwt.c, I think > the SR has similar properties and might be able to use dst_cache which > is a significant performance improvement when source

Re: [PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked()

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:11, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > __get_user_pages_locked() > to make the use of FOLL_FORCE explicit in callers as use of this flag can > result > in surprising behaviour (and hence bugs) within the mm subsystem. > >

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread John Crispin
On 18/10/2016 14:29, Andrew Lunn wrote: > On Tue, Oct 18, 2016 at 02:12:40PM +0200, John Crispin wrote: >> The shutdown code only stopped the PHYs but does not diconnect them >> properly. This could lead to null pointer deref related kernel oopses >> during reboot. Fix this by calling

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread John Crispin
On 18/10/2016 15:24, Andrew Lunn wrote: >> Hi Andrew >> >> i am testing on v4.4 which did not have a phy_disconnect() call. this >> seems to have been fixed by cda5c15b so please ignore this patch > > Hi John > > All patches must be against net-next, or net if it is a fix. Anything > else is

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-18 Thread Lorenzo Stoakes
On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote: > > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned > > long nr_pages, > > int write, int force, struct page **pages, > > struct vm_area_struct **vmas); > > long

Re: Need help with mdiobus_register and phy

2016-10-18 Thread Timur Tabi
Zefir Kurtisi wrote: I have never seen the original problem that you noticed. When I use the generic phy driver instead of the at803x driver, everything works great for me. Perhaps the problem that you noticed only occurs with the Gianfar NIC? You mean it works for you in SGMII mode without

RE: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-18 Thread Yotam Gigi
>-Original Message- >From: Or Gerlitz [mailto:gerlitz...@gmail.com] >Sent: Sunday, October 16, 2016 1:27 PM >To: Jiri Pirko >Cc: Linux Netdev List ; David Miller >; Yotam Gigi ; Ido Schimmel

Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked()

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:12, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from > __get_user_pages_unlocked() to make the use of FOLL_FORCE explicit in callers > as > use of this flag can result in surprising behaviour (and hence bugs) within > the > mm subsystem. > >

Re: [PATCH net v2] flow_dissector: Check skb for VLAN only if skb specified.

2016-10-18 Thread Or Gerlitz
On Mon, Oct 17, 2016 at 11:30 PM, Eric Garver wrote: > Fixes a panic when calling eth_get_headlen(). Noticed on i40e driver. > > Fixes: d5709f7ab776 ("flow_dissector: For stripped vlan, get vlan info from > skb->vlan_tci") > Signed-off-by: Eric Garver Dave, Hadar

[PATCH net-next] openvswitch: remove unnecessary EXPORT_SYMBOLs

2016-10-18 Thread Jiri Benc
Many symbols exported to other modules are really used only by openvswitch.ko. Remove the exports. Tested by loading all 4 openvswitch modules, nothing breaks. Signed-off-by: Jiri Benc --- net/openvswitch/datapath.c | 2 -- net/openvswitch/vport-netdev.c | 1 -

Re: [PATCH net-next 09/15] ethernet/dlink: use core min/max MTU checking

2016-10-18 Thread Denis Kirjanov
On 10/17/16, Jarod Wilson wrote: > dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware > - Removed change_mtu, does nothing productive anymore > > sundance: min_mtu 68, max_mtu 8191 > > CC: netdev@vger.kernel.org > CC: Denis Kirjanov >

Re: [PATCH 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

2016-10-18 Thread David Lebrun
On 10/17/2016 07:07 PM, Tom Herbert wrote: >> +static inline void seg6_pernet_lock(struct net *net) >> +{ >> + mutex_lock(_pernet(net)->lock); >> +} >> + >> +static inline void seg6_pernet_unlock(struct net *net) >> +{ >> + mutex_unlock(_pernet(net)->lock); >> +} >> + > IMO it's better

[PATCH iproute2] tc, ipt: don't enforce iproute2 dependency on iptables-devel

2016-10-18 Thread Daniel Borkmann
Since 5cd1adba79d3 ("Update to current iptables headers") compilation of iproute2 broke for systems without iptables-devel package [1]. Reason is that even though we fall back to build m_ipt.c, the include depends on a xtables-version.h header, which only ships with iptables-devel. Machines not

[PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread John Crispin
The shutdown code only stopped the PHYs but does not diconnect them properly. This could lead to null pointer deref related kernel oopses during reboot. Fix this by calling phy_disconnect() after the PHYs are stopped. Signed-off-by: John Crispin --- net/dsa/slave.c |4 +++-

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

2016-10-18 Thread Jan Kara
On Thu 13-10-16 01:20:14, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages_locked() > and replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit in callers as use of this flag can result in surprising behaviour > (and >

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread Andrew Lunn
> Hi Andrew > > i am testing on v4.4 which did not have a phy_disconnect() call. this > seems to have been fixed by cda5c15b so please ignore this patch Hi John All patches must be against net-next, or net if it is a fix. Anything else is wrong Andrew

Re: [PATCH v3 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c

2016-10-18 Thread Greg Kroah-Hartman
On Tue, Oct 18, 2016 at 01:27:30PM +0200, Stefan Wahren wrote: > As preparation for the upcoming UART driver we need a module > which contains common functions for both interfaces. The module > qca_framing is a good candidate but renaming to qca_common would > make it clear. > > Signed-off-by:

Re: [PATCH 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

2016-10-18 Thread David Lebrun
On 10/17/2016 07:01 PM, Tom Herbert wrote: >> +struct ipv6_sr_hdr { >> + __u8nexthdr; >> + __u8hdrlen; >> + __u8type; >> + __u8segments_left; >> + __u8first_segment; >> + __be16 flags; > > Bad alignment for 16 bit field could be unpleasant

Re: [PATCH 4/9] ipv6: sr: add core files for SR HMAC support

2016-10-18 Thread David Lebrun
On 10/17/2016 07:24 PM, Tom Herbert wrote: > A lot of this looks generic and potentially useful in other cases > where we we want to do HMAC over some headers (I'm thinking GUE can > probably use some of this for header authentication). Might be nice to > split out the generic pieces at some

[PATCH net] bridge: multicast: restore perm router ports on multicast enable

2016-10-18 Thread Nikolay Aleksandrov
Satish reported a problem with the perm multicast router ports not getting reenabled after some series of events, in particular if it happens that the multicast snooping has been disabled and the port goes to disabled state then it will be deleted from the router port list, but if it moves into

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-18 Thread Michal Hocko
On Thu 13-10-16 01:20:10, Lorenzo Stoakes wrote: > This patch series adjusts functions in the get_user_pages* family such that > desired FOLL_* flags are passed as an argument rather than implied by flags. > > The purpose of this change is to make the use of FOLL_FORCE explicit so it is > easier

Re: [PATCH v2 net-next 0/7] udp: Flow dissection for tunnels

2016-10-18 Thread David Miller
From: Tom Herbert Date: Mon, 17 Oct 2016 12:41:55 -0700 > Now that we have a means to perform a UDP socket lookup without taking > a reference, it is feasible to have flow dissector crack open UDP > encapsulated packets. Generally, we would expect that the UDP source > port

[PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning

2016-10-18 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/net/dsa/mv88e6xxx/chip.c:2866:5: warning: symbol 'mv88e6xxx_g1_set_switch_mac' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/dsa/mv88e6xxx/chip.c

Re: [PATCH net v2 0/3] Tunneling fixes

2016-10-18 Thread Juerg Haefliger
> This series fixes a problem that was reported where encapsulated packets > do not have their encapsulation offload markers stripped off when being > decapsulated. This causes a significant performance drop if the packets > are later retransmitted. > > Fixing this revealed two other bugs which

Re: [PATCH 18/19] stmmac: dwmac-sti: Remove obsolete STi platforms

2016-10-18 Thread Patrice Chotard
On 09/23/2016 05:11 PM, Rob Herring wrote: > On Wed, Sep 14, 2016 at 02:27:56PM +0100, Peter Griffin wrote: >> This patch removes support for STiH415/6 SoC's from the >> dwmac-sti driver and dt binding doc, as support for these >> platforms is being removed from the kernel. It also removes >>

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

2016-10-18 Thread Raju Lakkaraju
Hi Florian, Thank you for review comments. On Mon, Oct 17, 2016 at 05:51:11AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On October 17, 2016 1:13:14 AM PDT, Raju Lakkaraju > wrote: > >Hi Andrew, > > > >Thank you for code review and comments. > > > >On

[PATCH v3 net-next 5/8] net: qualcomm: move MTU handling to qca_common

2016-10-18 Thread Stefan Wahren
The MTU of the QCA7000 is independent from it's host interface (UART,SPI). So move the change_mtu function to qca_common. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_common.c | 11 +++ drivers/net/ethernet/qualcomm/qca_common.h | 3 +++

[PATCH v3 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2016-10-18 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 -

[PATCH v3 net-next 6/8] net: qualcomm: prepare frame decoding for UART driver

2016-10-18 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren

[PATCH v3 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call

2016-10-18 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2 files

[PATCH -next] qed: Remove useless set memory to zero use memset()

2016-10-18 Thread Wei Yongjun
From: Wei Yongjun The memory return by kzalloc() has already be set to zero, so remove useless memset(0). Signed-off-by: Wei Yongjun --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v3 net-next 00/11] net: Fix netdev adjacency tracking

2016-10-18 Thread David Ahern
On 10/18/16 9:46 AM, David Miller wrote: > Series applied, but the recursion is disappointing. > > If we run into problems due to kernel stack depth because of this with > some configurations (reasonable or not, if we allow it then it can't > crash the kernel), we will either need to find a way

[PATCH net-next] ethernet/sfc: use core min/max MTU checking

2016-10-18 Thread Bert Kenward
Fixes: 61e84623 ("net: centralize net_device min/max MTU checking") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-18 Thread David Miller
From: Jarod Wilson Date: Mon, 17 Oct 2016 15:54:02 -0400 > Now that the network stack core min/max MTU checking infrastructure is in > place, time to start making drivers use it. We'll start with the easiest > ones, the ethernet drivers, split roughly by vendor, with a

Re: [PATCH net-next 0/2] Move to BPF selftests

2016-10-18 Thread David Miller
From: Daniel Borkmann Date: Mon, 17 Oct 2016 14:28:34 +0200 > This set improves the test_verifier and test_maps suite and moves > it over to a new BPF selftest directory, so we can keep improving > it under kernel selftest umbrella. This also integrates a test > script for

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-18 Thread David Miller
From: Jarod Wilson Date: Mon, 17 Oct 2016 16:29:43 -0400 > On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote: >> From: Jarod Wilson >> Date: Mon, 17 Oct 2016 15:54:02 -0400 >> >> > For the most part, every patch does the same essential thing:

Re: [PATCH v3 net-next 00/11] net: Fix netdev adjacency tracking

2016-10-18 Thread David Miller
From: David Ahern Date: Mon, 17 Oct 2016 19:15:42 -0700 > The netdev adjacency tracking is failing to create proper dependencies > for some topologies. For example this topology ... > hits 1 of 2 problems depending on the order of enslavement. The base set of >

Re: [PATCH v2 net-next 0/7] udp: Flow dissection for tunnels

2016-10-18 Thread David Miller
From: David Miller Date: Tue, 18 Oct 2016 11:48:37 -0400 (EDT) > Series applied, thanks Tom. Actually, reverted. Tom, would you mind build testing with ipv6 enabled? :-) net/ipv6/udp_offload.c:208:19: error: initialization from incompatible pointer type

Re: [PATCH v5 0/4] Add support for led triggers on phy link state change

2016-10-18 Thread David Miller
From: Zach Brown Date: Mon, 17 Oct 2016 10:49:51 -0500 > Fix skge driver that declared enum contants that conflicted with enum > constants in linux/leds.h > > Create function that encapsulates actions taken during the adjust phy link > step > of phy state changes. > >

Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning

2016-10-18 Thread Andrew Lunn
On Tue, Oct 18, 2016 at 03:53:37PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/dsa/mv88e6xxx/chip.c:2866:5: warning: > symbol 'mv88e6xxx_g1_set_switch_mac' was not declared. Should it be static? > >

[PATCH net v2] bridge: multicast: restore perm router ports on multicast enable

2016-10-18 Thread Nikolay Aleksandrov
Satish reported a problem with the perm multicast router ports not getting reenabled after some series of events, in particular if it happens that the multicast snooping has been disabled and the port goes to disabled state then it will be deleted from the router port list, but if it moves into

Re: [PATCH v3 4/4] net: smsc91x: add u16 workaround for pxa platforms

2016-10-18 Thread Rob Herring
On Mon, Oct 17, 2016 at 09:45:32PM +0200, Robert Jarzmik wrote: > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > which must be aligned on 32 bits addresses. > > Signed-off-by: Robert Jarzmik > Cc: Jeremy Linton > --- >

[patch net 1/6] switchdev: Execute bridge ndos only for bridge ports

2016-10-18 Thread Jiri Pirko
From: Ido Schimmel We recently got the following warning after setting up a vlan device on top of an offloaded bridge and executing 'bridge link': WARNING: CPU: 0 PID: 18566 at drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:81

Re: [RFC PATCH 2/2] mac80211: aes_ccm: cache AEAD request structures per CPU

2016-10-18 Thread Johannes Berg
On Tue, 2016-10-18 at 15:18 +0100, Ard Biesheuvel wrote: >  > > Hmm. Is it really worth having a per-CPU variable for each possible > > key? You could have a large number of those (typically three when > > you're a client on an AP, and 1 + 1 for each client when you're the > > AP). 2 + 1 for each

[RFC PATCH 2/2] mac80211: aes_ccm: cache AEAD request structures per CPU

2016-10-18 Thread Ard Biesheuvel
Now that we can no longer invoke AEAD transforms with the aead_request structure allocated on the stack, we perform a kmalloc/kfree for every packet, which is expensive. Since the CCMP routines execute in softirq context, we know there can never be more than one request in flight on each CPU, and

Re: [RFC PATCH 2/2] mac80211: aes_ccm: cache AEAD request structures per CPU

2016-10-18 Thread Johannes Berg
On Tue, 2016-10-18 at 15:08 +0100, Ard Biesheuvel wrote: >  > + aead_req = *this_cpu_ptr(ccmp->reqs); > + if (!aead_req) { > + aead_req = kzalloc(reqsize + CCM_AAD_LEN, GFP_ATOMIC); > + if (!aead_req) > + return -ENOMEM; > +

Re: [PATCH net] bridge: multicast: restore perm router ports on multicast enable

2016-10-18 Thread Nikolay Aleksandrov
On 18/10/16 15:10, Nikolay Aleksandrov wrote: > Satish reported a problem with the perm multicast router ports not getting > reenabled after some series of events, in particular if it happens that the > multicast snooping has been disabled and the port goes to disabled state > then it will be

Re: [RFC PATCH 2/2] mac80211: aes_ccm: cache AEAD request structures per CPU

2016-10-18 Thread Ard Biesheuvel
On 18 October 2016 at 15:16, Johannes Berg wrote: > On Tue, 2016-10-18 at 15:08 +0100, Ard Biesheuvel wrote: >> >> + aead_req = *this_cpu_ptr(ccmp->reqs); >> + if (!aead_req) { >> + aead_req = kzalloc(reqsize + CCM_AAD_LEN, GFP_ATOMIC); >> +

Re: [PATCH] vlan: Remove unnecessary comparison of unsigned against 0

2016-10-18 Thread David Miller
From: Tobias Klauser Date: Tue, 18 Oct 2016 08:44:17 +0200 > args.u.name_type is of type unsigned int and is always >= 0. > > This fixes the following GCC warning: > > net/8021q/vlan.c: In function ‘vlan_ioctl_handler’: > net/8021q/vlan.c:574:14: warning: comparison of

Re: [PATCH net v2] bnx2: fix locking when netconsole is used

2016-10-18 Thread David Miller
From: Ivan Vecera Date: Tue, 18 Oct 2016 08:16:03 +0200 > Functions bnx2_reg_rd_ind(), bnx2_reg_wr_ind() and bnx2_ctx_wr() > can be called with IRQs disabled when netconsole is enabled. So they > should use spin_{,un}lock_irq{save,restore} instead of _bh variants. > >

  1   2   >