Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-12 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3285 ) Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O .. Patch Set 8: Verified+1 (1 comment)

Change in asterixdb[master]: [ASTERIXDB-2540] Optimize Storage Disk I/O

2019-06-12 Thread Till Westmann (Code Review)
Till Westmann has removed Anon. E. Moose (1000171) from this change. ( https://asterix-gerrit.ics.uci.edu/3285 ) Change subject: [ASTERIXDB-2540] Optimize Storage Disk I/O .. Removed reviewer null with the following votes: *

Change in asterixdb[master]: [NO ISSUE][OTH] Simplify ResultJobRecord APIs

2019-06-12 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3432 ) Change subject: [NO ISSUE][OTH] Simplify ResultJobRecord APIs .. Patch Set 2: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3433 ) Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round() .. Patch Set 7: (2 comments)

Change in asterixdb[master]: [NO ISSUE][COMP] Better error messages for dump_index

2019-06-08 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3431 ) Change subject: [NO ISSUE][COMP] Better error messages for dump_index .. [NO ISSUE][COMP] Better error messages for

Change in asterixdb[master]: [NO ISSUE][COMP] Better error messages for dump_index

2019-06-07 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3431 ) Change subject: [NO ISSUE][COMP] Better error messages for dump_index .. Patch Set 1: Code-Review+1 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][COMP] Better error messages for dump_index

2019-06-07 Thread Till Westmann (Code Review)
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3431 Change subject: [NO ISSUE][COMP] Better error messages for dump_index .. [NO ISSUE][COMP] Better error messages for dump_index -

Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...

2019-06-07 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3350 ) Change subject: [NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash join - user model changes: no - storage format changes : no - interface changes: no

Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-07 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3426 ) Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. [NO ISSUE][RT][COMP] Use more

Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3426 ) Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. Patch Set 3: (1 comment) > Patch Set 2: > >

Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-06 Thread Till Westmann (Code Review)
Hello Anon. E. Moose (1000171), Hussain Towaileb, Jenkins, Murtadha Hubail, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3426 to look at the new patch set (#3). Change subject: [NO ISSUE][RT][COMP] Use more components to identify a

Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-05 Thread Till Westmann (Code Review)
Hello Anon. E. Moose (1000171), Jenkins, Murtadha Hubail, Dmitry Lychagin, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3426 to look at the new patch set (#2). Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource

Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-04 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3426 ) Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. Patch Set 1: Code-Review+1 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][RT][COMP] Use more components to identify a datasource

2019-06-04 Thread Till Westmann (Code Review)
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3426 Change subject: [NO ISSUE][RT][COMP] Use more components to identify a datasource .. [NO ISSUE][RT][COMP] Use more components to

Change in asterixdb[master]: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and P...

2019-06-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3421 ) Change subject: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and PartitionsManager .. Patch Set 1: (1 comment)

Change in asterixdb[master]: Step1-Making partitionManager for hash join

2019-06-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3422 ) Change subject: Step1-Making partitionManager for hash join .. Patch Set 4: (2 comments)

Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions

2019-06-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3412 ) Change subject: [ASTERIXDB-2577]One frame per spilled partitions .. Patch Set 5: (3 comments)

Change in asterixdb[master]: Merge commit '79b243' from stabilization-f69489

2019-05-30 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3418 ) Change subject: Merge commit '79b243' from stabilization-f69489 .. Patch Set 2: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][OTH] Make ClusterControllerService Extensible

2019-05-30 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3417 ) Change subject: [NO ISSUE][OTH] Make ClusterControllerService Extensible .. Patch Set 1: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2579][DOC] Document uuid/upsert/insert behavior

2019-05-30 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3414 ) Change subject: [ASTERIXDB-2579][DOC] Document uuid/upsert/insert behavior .. Patch Set 3: Code-Review+2 -- To view, visit

Change in asterixdb-bad[master]: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter

2019-05-28 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3411 ) Change subject: [NO ISSUE][BAD] Coordinated Change for ResponsePrinter .. Patch Set 4: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][OTH] Introduce ResponsePrinter

2019-05-28 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3410 ) Change subject: [NO ISSUE][OTH] Introduce ResponsePrinter .. Patch Set 3: Code-Review+2 (1 comment)

Change in asterixdb[master]: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator

2019-05-24 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3404 ) Change subject: [ASTERIXDB-2547][COMP] Disallow passing UNION tag to get comparator .. Patch Set 2: (1 comment)

Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3401 ) Change subject: [NO ISSUE][API] Return Async Query Results As JSON .. Patch Set 2: Code-Review+2 (1 comment)

Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement

2019-05-13 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 10: Code-Review+1 -- To view,

Change in asterixdb[master]: [NO ISSUE] Additional constructor for TaggedValuePointable

2019-05-13 Thread Till Westmann (Code Review)
Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3242 to look at the new patch set (#6). Change subject: [NO ISSUE] Additional constructor for TaggedValuePointable

Change in asterixdb[master]: [ASTERIXDB-2563][API] Allow All Nodes To Receive Queries

2019-05-13 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3388 ) Change subject: [ASTERIXDB-2563][API] Allow All Nodes To Receive Queries .. Patch Set 3: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison

2019-05-09 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3387 ) Change subject: [ASTERIXDB-2555][RT][COMP] Make hash join use logical comparison .. Patch Set 2: (3 comments)

Change in asterixdb[master]: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries

2019-05-09 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3385 ) Change subject: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries .. Patch Set 2: Code-Review+2 -- To view,

Change in asterixdb[master]: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries

2019-05-09 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3385 ) Change subject: [NO ISSUE][COMP] Reduce memory requirements for metadata only queries .. Patch Set 2: (1 comment)

Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement

2019-05-08 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 7: (5 comments) Added we few more

Change in asterixdb[master]: [NO ISSUE][DOC] Refresh and update text-example

2019-05-08 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3356 ) Change subject: [NO ISSUE][DOC] Refresh and update text-example .. Patch Set 3: For nicer rendering on GitHub, it might be useful

Change in asterixdb[master]: [NO ISSUE] show aggregate functions in JSON plan

2019-05-08 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3384 ) Change subject: [NO ISSUE] show aggregate functions in JSON plan .. [NO ISSUE] show aggregate functions in JSON plan - user

Change in asterixdb[master]: [NO ISSUE] show aggregate functions in JSON plan

2019-05-08 Thread Till Westmann (Code Review)
Hello Anon. E. Moose (1000171), Jenkins, Murtadha Hubail, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3384 to look at the new patch set (#3). Change subject: [NO ISSUE] show aggregate functions in JSON plan

Change in asterixdb[master]: [NO ISSUE] show aggregate functions in JSON plan

2019-05-08 Thread Till Westmann (Code Review)
Hello Anon. E. Moose (1000171), Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3384 to look at the new patch set (#2). Change subject: [NO ISSUE] show aggregate functions in JSON plan

Change in asterixdb[master]: MB-34087: show aggregate functions in JSON plan

2019-05-08 Thread Till Westmann (Code Review)
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3384 Change subject: MB-34087: show aggregate functions in JSON plan .. MB-34087: show aggregate functions in JSON plan Change-Id:

Change in asterixdb[master]: [NO ISSUE][FUN] Simplify error message + cleanup

2019-05-07 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3381 ) Change subject: [NO ISSUE][FUN] Simplify error message + cleanup .. Patch Set 3: Code-Review+2 Forwarding Hussain's +2 after a

Change in asterixdb[master]: [NO ISSUE][FUN] Simplify error message + cleanup

2019-05-07 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. ( https://asterix-gerrit.ics.uci.edu/3381 ) Change subject: [NO ISSUE][FUN] Simplify error message + cleanup .. [NO ISSUE][FUN] Simplify error message + cleanup - user

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-05-06 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new patch set (#38) to the change originally created by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT]

Change in asterixdb[master]: [NO ISSUE][CONF] Add compilation provider to NC application context

2019-05-06 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3378 ) Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context .. Patch Set 3: Code-Review+2 -- To view,

Change in asterixdb[master]: [NO ISSUE][CONF] Add compilation provider to NC application context

2019-05-06 Thread Till Westmann (Code Review)
Till Westmann has removed a vote on this change. Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context .. Removed Contrib-2 by Anon. E. Moose (1000171) -- To view, visit

Change in asterixdb[master]: Finished translating all old aql files with the exception of a few st...

2019-05-06 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3383 ) Change subject: Finished translating all old aql files with the exception of a few straglers and fuzzyjoin. Should be up to date with master

Change in asterixdb[master]: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement

2019-05-06 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3370 ) Change subject: [ASTERIXDB-2535][COMP] Fix uuid present in insert/upsert statement .. Patch Set 4: (2 comments)

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-05-06 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. Patch Set 36: (11 comments)

Change in asterixdb[master]: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager

2019-05-04 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3372 ) Change subject: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager .. Patch Set 2: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][FUN] Simplify error message + cleanup

2019-05-03 Thread Till Westmann (Code Review)
Till Westmann has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/3381 Change subject: [NO ISSUE][FUN] Simplify error message + cleanup .. [NO ISSUE][FUN] Simplify error message + cleanup - user model

Change in asterixdb[master]: [NO ISSUE][CONF] Add compilation provider to NC application context

2019-05-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3378 ) Change subject: [NO ISSUE][CONF] Add compilation provider to NC application context .. Patch Set 2: (2 comments)

Change in asterixdb[master]: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager

2019-05-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3372 ) Change subject: [ASTERIXDB-2552][RT] Reuse objects on reseting buffer manager .. Patch Set 2: (1 comment)

Change in asterixdb[master]: [NO ISSUE][FUN] Introduce data generator function

2019-04-29 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [NO ISSUE][FUN] Introduce data generator function .. Patch Set 11: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [WIP] Introduce data generator data source functions

2019-04-29 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. Patch Set 10: (4 comments)

Change in asterixdb[master]: [WIP] Introduce data generator data source functions

2019-04-28 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. Patch Set 7: (8 comments)

Change in asterixdb[master]: [WIP] Introduce data generator data source functions

2019-04-28 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. Patch Set 6: (3 comments)

Change in asterixdb[master]: [WIP] Introduce data generator data source functions

2019-04-27 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new patch set (#5) to the change originally created by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. [WIP]

Change in asterixdb[master]: [WIP] Introduce data generator data source functions

2019-04-27 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new patch set (#4) to the change originally created by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. [WIP]

Change in asterixdb[master]: [WIP] Introduce data generator data source functions

2019-04-27 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3360 ) Change subject: [WIP] Introduce data generator data source functions .. Patch Set 4: (17 comments) Looks good so far - just a few

Change in asterixdb[master]: [NO ISSUE][CONF] Introduce ConfigValidator

2019-04-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3359 ) Change subject: [NO ISSUE][CONF] Introduce ConfigValidator .. Patch Set 1: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-04-21 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new patch set (#30) to the change originally created by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. [ASTERIXDB-2532][RT]

Change in asterixdb[master]: [NO ISSUE][FUN] Return elapsedTime in Seconds

2019-04-17 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3348 ) Change subject: [NO ISSUE][FUN] Return elapsedTime in Seconds .. Patch Set 1: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-04-17 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. Patch Set 27: (12 comments)

Change in asterixdb[master]: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider

2019-04-16 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 ) Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider .. Patch Set 3: Code-Review+2 Looks good.

Change in asterixdb[master]: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider

2019-04-16 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 ) Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider .. Patch Set 3: > Patch Set 3: Contrib-2 > >

Change in asterixdb[master]: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider

2019-04-16 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3336 ) Change subject: [ASTERIXDB-2516][RT] Prevent passing null type to comparator provider .. Patch Set 2: (2 comments)

Change in asterixdb[master]: [NO ISSUE][COMP] Minor cleanup in VariableCheckAndRewriteVisitor

2019-04-15 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3343 ) Change subject: [NO ISSUE][COMP] Minor cleanup in VariableCheckAndRewriteVisitor .. Patch Set 2: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-04-14 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3226 ) Change subject: [ASTERIXDB-2532][RT] per-operator profiling .. Patch Set 25: (30 comments)

Change in asterixdb[master]: [ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Re...

2019-04-11 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3322 ) Change subject: [ASTERIXDB-2539][COMP] Exclude LET variables from "Single Variable Resolution" rule .. Patch Set 4: Code-Review+2

Change in asterixdb[stabilization-f69489]: [NO ISSUE][*DB][CLUS] Add failed nodes API to ClusterStateManager

2019-04-11 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3335 ) Change subject: [NO ISSUE][*DB][CLUS] Add failed nodes API to ClusterStateManager .. Patch Set 1: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][API] Rename Request Cancellation API Parameter

2019-04-08 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][API] Rename Request Cancellation API Parameter .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3334 To

Change in asterixdb[master]: [NO ISSUE][FUN] Make Dump_Index Function Return An Array of ...

2019-04-07 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Make Dump_Index Function Return An Array of Values .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3332 To

Change in asterixdb[stabilization-f69489]: [NO ISSUE][STO] Ensure Invalid Merged Components Are Deleted

2019-04-07 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][STO] Ensure Invalid Merged Components Are Deleted .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3331 To

Change in asterixdb[master]: [NO ISSUE][RT] Fail Fast On Request Cancellation After Job C...

2019-04-07 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][RT] Fail Fast On Request Cancellation After Job Completion .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3321

Change in asterixdb[master]: [NO ISSUE] Use RuntimeMXBean.getPid() when available

2019-04-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Use RuntimeMXBean.getPid() when available .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3312 To unsubscribe,

Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...

2019-04-03 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions .. [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions -

Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...

2019-04-03 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions .. Patch Set 6: Verified+1 Apparently all tests ran - not sure why there is no vote.

Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...

2019-04-02 Thread Till Westmann (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3298 to look at the new patch set (#6). Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions

Change in asterixdb[master]: [NO ISSUE][COMP] Multiple parameters for two-step aggregatio...

2019-04-02 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][COMP] Multiple parameters for two-step aggregation functions .. Patch Set 6: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [NO ISSUE][RT] Make StreamSelectRuntimeFactory Extensible

2019-04-02 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][RT] Make StreamSelectRuntimeFactory Extensible .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3308 To

Change in asterixdb[master]: [NO ISSUE] SonarQube fixes

2019-04-02 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] SonarQube fixes .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3307 To unsubscribe, visit

Change in asterixdb[master]: [NO ISSUE][FUN] Add Completed_Requests Function

2019-04-01 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Add Completed_Requests Function .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3301 To unsubscribe, visit

Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2536][COMP] Do not push Select through RunningAgg...

2019-03-29 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2536][COMP] Do not push Select through RunningAggregate .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3305 To

Change in asterixdb[master]: [NO ISSUE][FUN] Add Completed_Requests Function

2019-03-29 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][FUN] Add Completed_Requests Function .. Patch Set 3: (2 comments) Looks good, but the "elapsedTime" is strange - it seems to include time that

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-03-27 Thread Till Westmann (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3226 to look at the new patch set (#23). Change subject: [ASTERIXDB-2532][RT] per-operator profiling

Change in asterixdb[master]: [NO ISSUE] Use correct type tag

2019-03-27 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Use correct type tag .. Patch Set 1: Integration-Tests+1 Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3292 To unsubscribe, visit

Change in asterixdb[master]: [NO ISSUE] Use correct type tag

2019-03-27 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. Change subject: [NO ISSUE] Use correct type tag .. [NO ISSUE] Use correct type tag - user model changes: no - storage format changes: no - interface changes: no

Change in asterixdb[master]: [NO ISSUE][FUN] active_requests() returns more requests

2019-03-27 Thread Till Westmann (Code Review)
Till Westmann has abandoned this change. Change subject: [NO ISSUE][FUN] active_requests() returns more requests .. Abandoned use a different (additional) function instead -- To view, visit

Change in asterixdb[master]: [NO ISSUE][*DB] Update version to 0.9.5-SNAPSHOT

2019-03-27 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][*DB] Update version to 0.9.5-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3297 To unsubscribe, visit

Change in asterixdb[master]: [NO ISSUE][FUN] active_requests() returns more requests

2019-03-26 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new patch set (#2). Change subject: [NO ISSUE][FUN] active_requests() returns more requests .. [NO ISSUE][FUN] active_requests() returns more requests - user model changes: yes - storage format

Change in asterixdb[master]: [NO ISSUE][FUN] active_requests() return more requests

2019-03-26 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/3295 Change subject: [NO ISSUE][FUN] active_requests() return more requests .. [NO ISSUE][FUN] active_requests() return more requests -

Change in asterixdb[master]: [NO ISSUE] Additional constructor for TaggedValuePointable

2019-03-25 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Additional constructor for TaggedValuePointable .. Patch Set 5: (1 comment)

Change in asterixdb[master]: [NO ISSUE] Use correct type tag

2019-03-25 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/3292 Change subject: [NO ISSUE] Use correct type tag .. [NO ISSUE] Use correct type tag - user model changes: no - storage format

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-03-25 Thread Till Westmann (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3226 to look at the new patch set (#22). Change subject: [ASTERIXDB-2532][RT] per-operator profiling

Change in asterixdb[master]: [ASTERIXDB-2532][RT] per-operator profiling

2019-03-25 Thread Till Westmann (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3226 to look at the new patch set (#21). Change subject: [ASTERIXDB-2532][RT] per-operator profiling

Change in asterixdb[master]: [ASTERIXDB-2516][RT] Make asterix types comparators singleto...

2019-03-22 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Make asterix types comparators singleton and stateless .. Patch Set 3: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [NO ISSUE] Apply / enforce java import order

2019-03-22 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Apply / enforce java import order .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3288 To unsubscribe, visit

Change in asterixdb[master]: [ASTERIXDB-2516][RT] Make asterix types comparators singleto...

2019-03-22 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Make asterix types comparators singleton and stateless .. Patch Set 2: (2 comments)

Change in asterixdb[master]: [NO ISSUE][OTH] Make Query Service Parameters Extensible

2019-03-21 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] Make Query Service Parameters Extensible .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3283 To

Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] IApplication interface change to allow confi...

2019-03-20 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] IApplication interface change to allow configuring loggers .. Patch Set 3: Verified+1 -- To view, visit

Change in asterixdb[stabilization-f69489]: [NO ISSUE][OTH] IApplication interface change to allow confi...

2019-03-20 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] IApplication interface change to allow configuring loggers .. Patch Set 3: Code-Review+2 -- To view, visit

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Avoid writing field names & values wh...

2019-03-18 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing field names & values when comparing records .. Patch Set 1: Code-Review+1 (2 comments)

Change in asterixdb[master]: [NO ISSUE][TYPE] Avoid 'null' collection types

2019-03-18 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged. Change subject: [NO ISSUE][TYPE] Avoid 'null' collection types .. [NO ISSUE][TYPE] Avoid 'null' collection types - user model changes: no - storage format changes: no

Change in asterixdb[master]: [ASTERIXDB-2516][COMP] Avoid writing into buffer when compar...

2019-03-15 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing into buffer when comparing numbers .. Patch Set 3: Code-Review+2 -- To view, visit

  1   2   3   4   5   6   7   8   9   10   >