Change in asterixdb[master]: Introduce MessagingNetworkManager for NC2NC AppMessaging

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Introduce MessagingNetworkManager for NC2NC AppMessaging
..


Patch Set 4:

(10 comments)

https://asterix-gerrit.ics.uci.edu/#/c/897/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessageBroker.java:

Line 292: public void run() {
It seems that this never stops. Would there be an issue, if we leave the loop 
on an InterruptedException?


https://asterix-gerrit.ics.uci.edu/#/c/897/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingHelper.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingHelper.java:

Line 33: import org.apache.asterix.external.feed.management.ConcurrentFramePool;
I think that we shouldn't depend on the external package here. Can we move 
those classes to a better (more general) place?


Line 50: //TODO make these values configurable and account for their memory 
usage
Yes, please.


https://asterix-gerrit.ics.uci.edu/#/c/897/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/messaging/api/INCMessageBroker.java:

Line 49: public void reportMaxResourceId() throws Exception;
I know that it's not part of this change, but do we still need this method on 
the interface. Isn't this just one special message that we sent to the CC?


https://asterix-gerrit.ics.uci.edu/#/c/897/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IChannelReadInterface.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IChannelReadInterface.java:

Line 63: public void setFlushOnCompleteRead(boolean flushOnCompleteRead);
Would it make sense, to remove this interface and to make this a property of 
the channel that is passed in on construction? It seems that this property 
should no change during the lifetime of a channel.


https://asterix-gerrit.ics.uci.edu/#/c/897/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IChannelWriteInterface.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/IChannelWriteInterface.java:

Line 22:  * Represents the write interface of a {@link ChannelControlBlock}.
Update comment


https://asterix-gerrit.ics.uci.edu/#/c/897/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/messages/IMessageBroker.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/messages/IMessageBroker.java:

Line 27: public default void registerMessagingChannel(String nodeId, 
IChannelControlBlock ccb) {
This method looks strange on this interface. It's not clear, why we need to 
register one kind of channels, but not the other one. Can we remove this or 
move it to another (parallel) interface or ...?


https://asterix-gerrit.ics.uci.edu/#/c/897/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

Line 256: ncConfig.messagingPublicPort);
Can we make the creation (and availability) of this dependent on the 
application. I think that not every Hyracks application will need (or want) to 
have this service.


https://asterix-gerrit.ics.uci.edu/#/c/897/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/MessagingNetworkManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/MessagingNetworkManager.java:

Line 30: import org.apache.hyracks.api.exceptions.HyracksDataException;
Could we stick with NetException in this file?


Line 48: private final IMessageBroker messageBroker;
It seems that this is only needed to register a new channel, but not to route 
an messages. If so, it doesn't need to be a message broker and the 
IMessageBroker interface wouldn't need the registration API. 
Is that right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/897
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c0bd7c11c1e78954ebceff49cb274d8073a64bd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Inline variable

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/848

to look at the new patch set (#5).

Change subject: Inline variable
..

Inline variable

Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/48/848/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/848
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: less code

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/916

Change subject: less code
..

less code

Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
3 files changed, 18 insertions(+), 35 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/916/1

diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
index c922054..b155895 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
@@ -230,39 +230,24 @@
 if (serRecord[0 + offset] == ATypeTag.RECORD.serialize()) {
 // 5 is the index of the byte that determines whether the 
record
 // is expanded or not, i.e. it has an open part.
-if (serRecord[5 + offset] == 1) { // true
-if (nullBitmapSize > 0) {
-// 14 = tag (1) + record Size (4) + isExpanded (1) +
-// offset of openPart (4) + number of closed fields (4)
-int pos = 14 + offset + fieldId / 4;
-if ((serRecord[pos] & nullTestCode) == 0) {
-// the field value is null
-return 0;
-}
-if ((serRecord[pos] & missingTestCode) == 0) {
-// the field value is missing
-return -1;
-}
+// 14 = tag (1) + record Size (4) + isExpanded (1) +
+// offset of openPart (4) + number of closed fields (4)
+// 10 = tag (1) + record Size (4) + isExpanded (1) +
+// number of closed fields (4)
+final int baseOffset = (serRecord[5 + offset] == 1) ? 14 : 10;
+if (nullBitmapSize > 0) {
+final byte flagsForField = serRecord[baseOffset + offset + 
fieldId / 4];
+if ((flagsForField & nullTestCode) == 0) {
+// the field value is null
+return 0;
 }
-return offset + 
AInt32SerializerDeserializer.getInt(serRecord,
-14 + offset + nullBitmapSize + (4 * fieldId));
-} else {
-if (nullBitmapSize > 0) {
-// 9 = tag (1) + record Size (4) + isExpanded (1) +
-// number of closed fields (4)
-int pos = 10 + offset + fieldId / 4;
-if ((serRecord[pos] & nullTestCode) == 0) {
-// the field value is null
-return 0;
-}
-if ((serRecord[pos] & missingTestCode) == 0) {
-// the field value is missing
-return -1;
-}
+if ((flagsForField & missingTestCode) == 0) {
+// the field value is missing
+return -1;
 }
-return offset + 
AInt32SerializerDeserializer.getInt(serRecord,
-10 + offset + nullBitmapSize + (4 * fieldId));
 }
+return offset + AInt32SerializerDeserializer.getInt(serRecord,
+baseOffset + offset + nullBitmapSize + (4 * fieldId));
 } else {
 return -1;
 }
diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
index 68fff2f..78e7306 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
@@ -65,8 +65,6 @@
 private final PointableAllocator allocator = new PointableAllocator();
 
 private final ResettableByteArrayOutputStream typeBos = new 
ResettableByteArrayOutputStream();
-private final DataOutputStream typeDos = new 

Change in asterixdb[master]: Adding functions to return unit-time from date, datetime, an...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Adding functions to return unit-time from date, datetime, and 
time.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/913
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a71d73680d2ad47e5bb2c2d9ceec2ec0d676d09
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1477 Fix Drop Feed If Not Exists

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1477 Fix Drop Feed If Not Exists
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/918/1/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml:

Line 157:   
Why do we move these tests around?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ce76ff5fd6611df5060a1de77742aba9d146ab5
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Supports Left Outer Join and Left Outer Unnest in SQL++.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Supports Left Outer Join and Left Outer Unnest in SQL++.
..


Patch Set 12:

(16 comments)

Looks great, just a few minor comments.

https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ByNameToByIndexFieldAccessRule.java:

Line 99: IOptimizationContext context) throws AlgebricksException {
Remove template params in this method?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/LoadRecordFieldsRule.java:

Line 246:  * @param toPush
update comment?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java:

Line 425: new 
MutableObject(makeUnnestExpression(eo.first)), pVar,
remove the template parameter?


Line 481: throw new IllegalStateException(ERR_MSG);
Should this just be an UnsupportedOperationException? Do we have a "usual" way 
to choose these?


Line 487: throw new IllegalStateException(ERR_MSG);
Should this just be an UnsupportedOperationException?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectUtil.java:

Line 329: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(recordType);
rename this variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java
File 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/ClassAdParser.java:

Line 358: "Field: " + 
recType.getFieldNames()[optionalFieldId] + " can not be null");
s/null/optional/?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java:

Line 112: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(this.recordType);
rename variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java:

Line 191: boolean hasNullableFields = 
NonTaggedFormatUtil.hasOptionalField(inputRecType);
rename variable?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 111: missingTypeTag.set(bos.getByteArray(), start, end - 
start);
What's the difference between missingReference and missingTypeTag? 

Also, shouldn't we always write using writeByte (which is unsynchronized)?


Line 142: } catch (AsterixException e) {
This seems to be the only place where we use TypeException. Could we remove it?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/nonvisitor/ARecordPointable.java:

Line 159: 
s/getExpendedOffset/getExpandedOffset/


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/ARecordPrinter.java:

Line 81: 
.deserialize(nextFieldValue.getByteArray()[nextFieldValue.getStartOffset()]);
Would it make sense to re-use this typeTag for the next iteration (and get the 
first type tag before the loop?


https://asterix-gerrit.ics.uci.edu/#/c/899/12/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java:

Line 337: } else {
Should we just remove this else and fall through to the default case (adding a 

Change in asterixdb[master]: small cleanup

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/902

Change subject: small cleanup
..

small cleanup

Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
1 file changed, 56 insertions(+), 101 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/902/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index 5cd049d..6f9d82a 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -97,55 +97,42 @@
 }
 
 private static List> buildDefaultLogicalRewrites() {
-List> 
defaultLogicalRewrites = new ArrayList>();
+List> 
defaultLogicalRewrites = new ArrayList<>();
 SequentialFixpointRuleController seqCtrlNoDfs = new 
SequentialFixpointRuleController(false);
 SequentialFixpointRuleController seqCtrlFullDfs = new 
SequentialFixpointRuleController(true);
 SequentialOnceRuleController seqOnceCtrl = new 
SequentialOnceRuleController(true);
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildInitialTranslationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildTypeInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildAutogenerateIDRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildNormalizationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildLoadFieldsRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildInitialTranslationRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildTypeInferenceRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildAutogenerateIDRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildNormalizationRuleCollection()));
+defaultLogicalRewrites
+.add(new Pair<>(seqCtrlNoDfs, 
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildLoadFieldsRuleCollection()));
 // fj
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildFuzzyJoinRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildFuzzyJoinRuleCollection()));
 //
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildNormalizationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildLoadFieldsRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildDataExchangeRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildConsolidationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildAccessMethodRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildPlanCleanupRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildNormalizationRuleCollection()));
+defaultLogicalRewrites
+.add(new Pair<>(seqCtrlNoDfs, 
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
+

Change in asterixdb[master]: small cleanup in APIFramework

[Till Westmann (Code Review)]

Till Westmann has uploaded a new patch set (#2).

Change subject: small cleanup in APIFramework
..

small cleanup in APIFramework

Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
1 file changed, 62 insertions(+), 108 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/02/902/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/902
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: ASTERIXDB-1025: a test case to verify the fix.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1025: a test case to verify the fix.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/905
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3297cdd00a3e9dd2bf0cf209c75eb1e1cc564c4b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Preston Carman 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1438: BufferCache spins indefinitely...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1438: BufferCache spins indefinitely...
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/894
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I327a7423bd630c96e16601b1a3a2a21f558f9f50
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Doc for single node installation using NCService

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/895

Change subject: Doc for single node installation using NCService
..

Doc for single node installation using NCService

Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
---
A asterixdb/asterix-doc/src/site/markdown/ncservice.md
M asterixdb/asterix-doc/src/site/site.xml
2 files changed, 104 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/895/1

diff --git a/asterixdb/asterix-doc/src/site/markdown/ncservice.md 
b/asterixdb/asterix-doc/src/site/markdown/ncservice.md
new file mode 100644
index 000..b724bd7
--- /dev/null
+++ b/asterixdb/asterix-doc/src/site/markdown/ncservice.md
@@ -0,0 +1,103 @@
+
+
+# Starting a small cluster using the NCService
+
+When running a cluster using the `NCService` there are 3 different kind of
+processes involved:
+
+1. `NCDriver` does the work of a NodeController
+2. `NCService` configures and starts an `NCDriver`
+3. `CCDriver` does the work of a ClusterController and sends the
+configuration to the `NCServices`
+
+To start a small cluster consisting of 2 NodeControllers (`red` and `blue`)
+and 1 ClusterController (`cc`) on a single machine only 2 configuration
+files are required.
+The first one is
+
+`blue.conf`:
+
+[ncservice]
+port=9091
+
+It is a configuration file for the second `NCService`.
+This contains only the port that the `NCService` of the second
+NodeControllers listens to as it is non-standard.
+The first `NCService` does not need a configuration file, as it only uses
+default parameters.
+In a distributed environment with 1 NodeController per machine, no
+`NCService` needs a configuration file.
+
+The second configuration file is 
+
+`cc.conf`:
+
+[nc/red]
+txnlogdir=/tmp/asterix/red/txnlog
+coredumpdir=/tmp/asterix/red/coredump
+iodevices=/tmp/asterix/red
+
+[nc/blue]
+port=9091
+txnlogdir=/tmp/asterix/blue/txnlog
+coredumpdir=/tmp/asterix/blue/coredump
+iodevices=/tmp/asterix/blue
+
+[nc]
+app.class=org.apache.asterix.hyracks.bootstrap.NCApplicationEntryPoint
+storagedir=storage
+address=127.0.0.1
+command=asterixnc
+
+[cc]
+cluster.address = 127.0.0.1
+http.port = 12345
+
+This is the configuration file for the cluster and it contains information
+that each `NCService` will use when starting the corresponding `NCDriver` as
+well as information for the `CCDriver`.
+
+To start the cluster simply use the following commands
+
+$ export BINDIR=[..]/asterix-server-0.8.9-SNAPSHOT-binary-assembly/bin
+
+$ $BINDIR/asterixncservice -config-file blue.conf &> blue-service.log &
+$ $BINDIR/asterixncservice &>red-service.log &
+$ $BINDIR/asterixcc -config-file cc.conf &> cc.log &
+
+These will first start the 2 `NCServices` for `red` and `blue` and then
+start the `CCDriver`.
+The `CCDriver` will connect to the `NCServices` and thus initiate the
+configuration and the start of the `NCDrivers`.
+After running these scripts, `jps` should show a result similar to this:
+
+$ jps
+13184 NCService
+13200 NCDriver
+13185 NCService
+13186 CCDriver
+13533 Jps
+13198 NCDriver
+
+To stop the cluster again simply run
+
+$ kill `jps | egrep '(CDriver|NCService)' | awk '{print $1}'`
+
+to kill all processes.
\ No newline at end of file
diff --git a/asterixdb/asterix-doc/src/site/site.xml 
b/asterixdb/asterix-doc/src/site/site.xml
index 4dadc09..9d5ce6e 100644
--- a/asterixdb/asterix-doc/src/site/site.xml
+++ b/asterixdb/asterix-doc/src/site/site.xml
@@ -74,6 +74,7 @@
 
 
 
+  
   
   
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/895
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 

Change in asterixdb[master]: Eliminate Hard Tabs From Java Files

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Eliminate Hard Tabs From Java Files
..


Patch Set 1:

Can we fail the build now, if a java file contains a tab?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/921
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dfbeaa9b9b24d3da106ead85afd9df02b14ddaa
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Eliminate Hard Tabs From Java Files

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Eliminate Hard Tabs From Java Files
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/921
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dfbeaa9b9b24d3da106ead85afd9df02b14ddaa
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: some code reduction/cleanup

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/916

to look at the new patch set (#4).

Change subject: some code reduction/cleanup
..

some code reduction/cleanup

Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
3 files changed, 88 insertions(+), 117 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/916/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: small cleanup in APIFramework

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: small cleanup in APIFramework
..


small cleanup in APIFramework

Change-Id: If65bc1360dce582980725859bdb0bec93973c6e0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/902
Tested-by: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
1 file changed, 62 insertions(+), 108 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index 5cd049d..f07fb76 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -97,55 +97,42 @@
 }
 
 private static List> buildDefaultLogicalRewrites() {
-List> 
defaultLogicalRewrites = new ArrayList>();
+List> 
defaultLogicalRewrites = new ArrayList<>();
 SequentialFixpointRuleController seqCtrlNoDfs = new 
SequentialFixpointRuleController(false);
 SequentialFixpointRuleController seqCtrlFullDfs = new 
SequentialFixpointRuleController(true);
 SequentialOnceRuleController seqOnceCtrl = new 
SequentialOnceRuleController(true);
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildInitialTranslationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildTypeInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildAutogenerateIDRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildNormalizationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildLoadFieldsRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildInitialTranslationRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildTypeInferenceRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqOnceCtrl, 
RuleCollections.buildAutogenerateIDRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildNormalizationRuleCollection()));
+defaultLogicalRewrites
+.add(new Pair<>(seqCtrlNoDfs, 
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildLoadFieldsRuleCollection()));
 // fj
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildFuzzyJoinRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildFuzzyJoinRuleCollection()));
 //
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildNormalizationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-
RuleCollections.buildCondPushDownAndJoinInferenceRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlFullDfs,
-RuleCollections.buildLoadFieldsRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqOnceCtrl,
-RuleCollections.buildDataExchangeRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildConsolidationRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildAccessMethodRuleCollection()));
-defaultLogicalRewrites.add(new Pair(seqCtrlNoDfs,
-RuleCollections.buildPlanCleanupRuleCollection()));
+defaultLogicalRewrites.add(new Pair<>(seqCtrlFullDfs, 
RuleCollections.buildNormalizationRuleCollection()));
+

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: WIP - QueryService API updates
..


Patch Set 9:

patch set 9 is just a rebase

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#9).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- API returns non-JSON results (ADM/CSV) as arrays of (escaped) strings
- fix encoding and content-length of response
- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/JSONUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
10 files changed, 640 insertions(+), 356 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Files necessary for initial perf regression tests

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Files necessary for initial perf regression tests
..


Patch Set 7:

(2 comments)

Ok, I guess that's not really a secret :)

https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java
File 
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java:

Line 71: if(aqlFilePath.toFile().isDirectory()){
> Hm, how so? Lack of spaces between closing paren and bracket?
Yep, doesn't look like our formatter ran over this one.


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp:

Line 1: use experiments;
> I mean, I guess I can add them. Are SQL++ comments the same as AQL ones?
Yep.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/884
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21e2d44ca46a4a28478d9ef256c4fa8d53f03dc9
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Young-Seok Kim 
Gerrit-HasComments: Yes

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#2).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
6 files changed, 412 insertions(+), 178 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#4).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- API returns non-JSON results (ADM/CSV) as arrays of (escaped) strings
- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
9 files changed, 506 insertions(+), 224 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#3).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
9 files changed, 506 insertions(+), 224 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1220: print nested values using visitors

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/882

to look at the new patch set (#17).

Change subject: ASTERIXDB-1220: print nested values using visitors
..

ASTERIXDB-1220: print nested values using visitors

- remove named printer classes
- remove redundancy between AObjectPrinterFactory and PrintVisitor
- remove redundant List- and RecordPrinters
- introduce AbstractPrintVisitor

Change-Id: I692c04dd1b3aa8e7adccfe960615f0fc2df6fe26
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryBase64Printer.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryHexPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ACirclePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ACirclePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADatePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADatePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADateTimePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADateTimePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADayTimeDurationPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADayTimeDurationPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADurationPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADurationPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt16Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt16PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt32Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt32PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt64Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt64PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt8Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt8PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ALinePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ALinePrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullableFieldPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java
D 

Change in asterixdb[master]: ASTERIXDB-1220: print nested values using visitors

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1220: print nested values using visitors
..


Patch Set 17:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/882/17/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java:

Line 39: private AOrderedListType orderedlistType;
> final?
Done


Line 47: final PointableAllocator allocator = new PointableAllocator();
> private final for all fields?
These are local variables in the method that become members. Those can't have 
access modifiers.


Line 52: final Pair arg = new Pair(null, null);
> Pair --> Pair<>?
Done


https://asterix-gerrit.ics.uci.edu/#/c/882/17/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AOrderedlistPrinterFactory.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AOrderedlistPrinterFactory.java:

Line 48: final IAType inputType = orderedlistType == null
> private final?
Done


Line 50: final IVisitablePointable listAccessor = 
allocator.allocateListValue(inputType);
> private final?
Access modifiers not allowed here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/882
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I692c04dd1b3aa8e7adccfe960615f0fc2df6fe26
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Files necessary for initial perf regression tests

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Files necessary for initial perf regression tests
..


Patch Set 7:

(12 comments)

Got a few questions/comments, but it generally looks ok (even though I don't 
understand the details..). 

One thing I'm wondering about is what we should do about hostnames/paths. Is it 
ok to submit those? Would be nice if we didn't have to ...

https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java
File 
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java:

Line 71: if(aqlFilePath.toFile().isDirectory()){
The formatting looks strange here.


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/client/LSMExperimentSetRunner.java
File 
asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/client/LSMExperimentSetRunner.java:

Line 29: import org.apache.asterix.experiment.builder.*;
Could we undo this?


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp:

Line 1: use experiments;
Do we need license headers here? Can we add them?


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-3-months.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-3-months.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-6-months.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-6-months.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-day.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-day.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-hour.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-hour.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-minute.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-minute.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-month.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-month.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-week.sqlpp
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-week.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/asterix-agg.xml
File 
asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/asterix-agg.xml:

Line 1: 

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#7).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- API returns non-JSON results (ADM/CSV) as arrays of (escaped) strings
- fix encoding and content-length of response
- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
9 files changed, 511 insertions(+), 229 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1428: Config-management improvements for AsterixDB

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1428: Config-management improvements for AsterixDB
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/887
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f2ad32d489ffc27adbb06aebcc1f22a9fcf784e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Doc for single node installation using NCService

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/895

to look at the new patch set (#6).

Change subject: Doc for single node installation using NCService
..

Doc for single node installation using NCService

Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
---
A asterixdb/asterix-doc/src/site/markdown/ncservice.md
M asterixdb/asterix-doc/src/site/site.xml
2 files changed, 112 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/895/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/895
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Doc for single node installation using NCService

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: Doc for single node installation using NCService
..


Doc for single node installation using NCService

Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/895
Reviewed-by: Chris Hillery 
Reviewed-by: Jenkins 
Tested-by: Jenkins 
---
A asterixdb/asterix-doc/src/site/markdown/ncservice.md
M asterixdb/asterix-doc/src/site/site.xml
2 files changed, 112 insertions(+), 0 deletions(-)

Approvals:
  Chris Hillery: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git a/asterixdb/asterix-doc/src/site/markdown/ncservice.md 
b/asterixdb/asterix-doc/src/site/markdown/ncservice.md
new file mode 100644
index 000..769c551
--- /dev/null
+++ b/asterixdb/asterix-doc/src/site/markdown/ncservice.md
@@ -0,0 +1,111 @@
+
+
+# Starting a small cluster using the NCService
+
+When running a cluster using the `NCService` there are 3 different kind of
+processes involved:
+
+1. `NCDriver` does the work of a NodeController
+2. `NCService` configures and starts an `NCDriver`
+3. `CCDriver` does the work of a ClusterController and sends the
+configuration to the `NCServices`
+
+To start a small cluster consisting of 2 NodeControllers (`red` and `blue`)
+and 1 ClusterController (`cc`) on a single machine only 2 configuration
+files are required.
+The first one is
+
+`blue.conf`:
+
+[ncservice]
+port=9091
+
+It is a configuration file for the second `NCService`.
+This contains only the port that the `NCService` of the second
+NodeControllers listens to as it is non-standard.
+The first `NCService` does not need a configuration file, as it only uses
+default parameters.
+In a distributed environment with 1 NodeController per machine, no
+`NCService` needs a configuration file.
+
+The second configuration file is
+
+`cc.conf`:
+
+[nc/red]
+txnlogdir=/tmp/asterix/red/txnlog
+coredumpdir=/tmp/asterix/red/coredump
+iodevices=/tmp/asterix/red
+
+[nc/blue]
+port=9091
+txnlogdir=/tmp/asterix/blue/txnlog
+coredumpdir=/tmp/asterix/blue/coredump
+iodevices=/tmp/asterix/blue
+
+[nc]
+app.class=org.apache.asterix.hyracks.bootstrap.NCApplicationEntryPoint
+storagedir=storage
+address=127.0.0.1
+command=asterixnc
+
+[cc]
+cluster.address = 127.0.0.1
+http.port = 12345
+
+This is the configuration file for the cluster and it contains information
+that each `NCService` will use when starting the corresponding `NCDriver` as
+well as information for the `CCDriver`.
+
+To start the cluster simply use the following steps
+
+1. Set BASEDIR to location of an unzipped asterix-server binary assembly (in
+the source tree that's at `asterixdb/asterix-server/target`).
+
+$ export BASEDIR=[..]/asterix-server-0.8.9-SNAPSHOT-binary-assembly
+
+2. Start the 2 `NCServices` for `red` and `blue`.
+
+$ $BASEDIR/bin/asterixncservice -config-file blue.conf > 
blue-service.log 2>&1 &
+$ $BASEDIR/bin/asterixncservice >red-service.log 2>&1 &
+
+3. Start the `CCDriver`.
+
+$ $BASEDIR/bin/asterixcc -config-file cc.conf > cc.log 2>&1 &
+
+The `CCDriver` will connect to the `NCServices` and thus initiate the
+configuration and the start of the `NCDrivers`.
+After running these scripts, `jps` should show a result similar to this:
+
+$ jps
+13184 NCService
+13200 NCDriver
+13185 NCService
+13186 CCDriver
+13533 Jps
+13198 NCDriver
+
+The logs for the `NCDrivers` will be in `$BASEDIR/logs`.
+
+To stop the cluster again simply run
+
+$ kill `jps | egrep '(CDriver|NCService)' | awk '{print $1}'`
+
+to kill all processes.
\ No newline at end of file
diff --git a/asterixdb/asterix-doc/src/site/site.xml 
b/asterixdb/asterix-doc/src/site/site.xml
index 4dadc09..9d5ce6e 100644
--- a/asterixdb/asterix-doc/src/site/site.xml
+++ b/asterixdb/asterix-doc/src/site/site.xml
@@ -74,6 +74,7 @@
 
 
 
+  
   
   
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/895
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#8).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- API returns non-JSON results (ADM/CSV) as arrays of (escaped) strings
- fix encoding and content-length of response
- run SQL++ query tests through QueryService API
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/JSONUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
10 files changed, 640 insertions(+), 356 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Doc for single node installation using NCService

[Till Westmann (Code Review)]

Hello Chris Hillery, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/895

to look at the new patch set (#7).

Change subject: Doc for single node installation using NCService
..

Doc for single node installation using NCService

Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
---
A asterixdb/asterix-doc/src/site/markdown/ncservice.md
M asterixdb/asterix-doc/src/site/site.xml
2 files changed, 112 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/895/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/895
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Doc for single node installation using NCService

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/895

to look at the new patch set (#5).

Change subject: Doc for single node installation using NCService
..

Doc for single node installation using NCService

Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
---
A asterixdb/asterix-doc/src/site/markdown/ncservice.md
M asterixdb/asterix-doc/src/site/site.xml
2 files changed, 112 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/895/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/895
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Doc for single node installation using NCService

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/895

to look at the new patch set (#3).

Change subject: Doc for single node installation using NCService
..

Doc for single node installation using NCService

Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
---
A asterixdb/asterix-doc/src/site/markdown/ncservice.md
M asterixdb/asterix-doc/src/site/site.xml
2 files changed, 104 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/95/895/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/895
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id0a5ad6e88d72ce2fcaaeabc79fd86c374005ad3
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Add the documentation for the `binary` data type

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add the documentation for the `binary` data type
..


Patch Set 1:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/934/1/asterixdb/asterix-doc/src/site/markdown/aql/datamodel.md
File asterixdb/asterix-doc/src/site/markdown/aql/datamodel.md:

Line 129: The total length of the sequence can be up to 2,147,483,648.
It seems to me that know about the maximal length is useful for an AQL user, 
but the implementation details are not really relevant (and we should be able 
to change those without modifying the semantics of the data type.


Line 161: "base64_2": hex("41737465726978") }
The documentation looks good to me but, again, I would not talk about the 
internal representation.


https://asterix-gerrit.ics.uci.edu/#/c/934/1/asterixdb/asterix-doc/src/site/markdown/aql/functions.md
File asterixdb/asterix-doc/src/site/markdown/aql/functions.md:

Line 598:   parse-binary(string, encoded_type)  
WS


Line 603: * `encoded_type` : A string notation specifies the encoding type 
of the given `string`. Currently we support `hex` and `base64` format.
Could we put a line-break here to stick to 120 chars?


Line 626: * `encoding_type` : A string notation specifies the expected 
encoding type. Currently we support `hex` and `base64` format.
Could we put a line-break here to stick to 120 chars?

Also, should we just call the "encoded_type" and "encoding_type" parameters 
"encoding"? I think that people will understand it and it'd be a bit shorter 
and consistent between the functions.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/934
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea9b29a1a8ff37617fb94cd562a1f885f8867ad3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1499: remove incorrect Content-Length
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/956/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java:

Line 71: Accept("Accept");
> MAJOR SonarQube violation:
This is fixed in my branch, not fixing it here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id260b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/956

Change subject: ASTERIXDB-1499: remove incorrect Content-Length
..

ASTERIXDB-1499: remove incorrect Content-Length

Change-Id: Id260b6400653bb95950f62ed80419dd5e85b
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/56/956/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 4376b22..35a780b 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -68,8 +68,7 @@
 }
 
 public enum Header {
-Accept("Accept"),
-ContentLength("Content-Length");
+Accept("Accept");
 
 private final String str;
 
@@ -334,7 +333,6 @@
 GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, result);
 //result = JSONUtil.indent(result);
 
-response.setIntHeader(Header.ContentLength.str(), result.length());
 response.getWriter().print(result);
 if (response.getWriter().checkError()) {
 LOGGER.warning("Error flushing output writer");

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id260b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 

Change in asterixdb[master]: ASTERIXDB-1499: remove incorrect Content-Length

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: ASTERIXDB-1499: remove incorrect Content-Length
..


ASTERIXDB-1499: remove incorrect Content-Length

Change-Id: Id260b6400653bb95950f62ed80419dd5e85b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/956
Tested-by: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 4376b22..35a780b 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -68,8 +68,7 @@
 }
 
 public enum Header {
-Accept("Accept"),
-ContentLength("Content-Length");
+Accept("Accept");
 
 private final String str;
 
@@ -334,7 +333,6 @@
 GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, result);
 //result = JSONUtil.indent(result);
 
-response.setIntHeader(Header.ContentLength.str(), result.length());
 response.getWriter().print(result);
 if (response.getWriter().checkError()) {
 LOGGER.warning("Error flushing output writer");

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/956
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id260b6400653bb95950f62ed80419dd5e85b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1286 Add User Documentation for Upsert

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1286 Add User Documentation for Upsert
..


Patch Set 2:

(2 comments)

Looks good, but the whitespace should be fixed.

https://asterix-gerrit.ics.uci.edu/#/c/640/2/asterix-doc/src/site/markdown/aql/primer.md
File asterix-doc/src/site/markdown/aql/primer.md:

Line 935:   "screen-name":$user.screen-name,
WS


Line 943:   
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I677dbeb5cbc7e8a83aa50db0c3cd59f91f6a2e69
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Update adm.grammar and printers for double/float

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Update adm.grammar and printers for double/float
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/932/6/asterixdb/asterix-external-data/src/main/resources/adm.grammar
File asterixdb/asterix-external-data/src/main/resources/adm.grammar:

Line 90: FLOAT_LITERAL   = token(DOUBLE_LITERAL), caseInsensitiveChar(f)
> These last two patchsets introduce NaN[fd], [-]Infinity[fd].  Do we want th
I think that the NaN and Infinity variants are not a problem. 

However, removing the tabs would be really nice :)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Reduce object creation in Unnest.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Reduce object creation in Unnest.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/957
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b2d1f281dca0655c212aad328fb737d5fec9c71
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Reduce object creation in Unnest.

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: Reduce object creation in Unnest.
..


Reduce object creation in Unnest.

If an Unnest is run in a Subplan operator, open/close need to be
called many times.

Change-Id: I5b2d1f281dca0655c212aad328fb737d5fec9c71
Reviewed-on: https://asterix-gerrit.ics.uci.edu/957
Reviewed-by: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git 
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java
 
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java
index 3afa808..300be34 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/UnnestRuntimeFactory.java
@@ -94,14 +94,15 @@
 int missingBytesLen = bos.size();
 return new AbstractOneInputOneOutputOneFramePushRuntime() {
 private IPointable p = VoidPointable.FACTORY.createPointable();
-private ArrayTupleBuilder tupleBuilder;
+private ArrayTupleBuilder tupleBuilder = new 
ArrayTupleBuilder(projectionList.length);
 private IUnnestingEvaluator unnest = 
unnestingFactory.createUnnestingEvaluator(ctx);
 
 @Override
 public void open() throws HyracksDataException {
 writer.open();
-initAccessAppendRef(ctx);
-tupleBuilder = new ArrayTupleBuilder(projectionList.length);
+if (tRef == null) {
+initAccessAppendRef(ctx);
+}
 }
 
 @Override

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/957
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5b2d1f281dca0655c212aad328fb737d5fec9c71
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: ASTERIXDB-1286 Add User Documentation for Upsert

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: ASTERIXDB-1286 Add User Documentation for Upsert
..


ASTERIXDB-1286 Add User Documentation for Upsert

Documentation for upsert has been added. It includes multiple examples:
1. Example with a single record upsert.
2. Example with a query based upsert.
3. Example of an upsert with self query.
The documentation explains the transaction properties of upserts as well.

Change-Id: I677dbeb5cbc7e8a83aa50db0c3cd59f91f6a2e69
Reviewed-on: https://asterix-gerrit.ics.uci.edu/640
Reviewed-by: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M asterixdb/asterix-doc/src/site/markdown/aql/manual.md
M asterixdb/asterix-doc/src/site/markdown/aql/primer.md
2 files changed, 72 insertions(+), 1 deletion(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git a/asterixdb/asterix-doc/src/site/markdown/aql/manual.md 
b/asterixdb/asterix-doc/src/site/markdown/aql/manual.md
index a7d1669..510bc83 100644
--- a/asterixdb/asterix-doc/src/site/markdown/aql/manual.md
+++ b/asterixdb/asterix-doc/src/site/markdown/aql/manual.md
@@ -480,11 +480,12 @@
   | SetStatement
   | InsertStatement
   | DeleteStatement
+  | UpsertStatement
   | Query
 
 In addition to expresssions for queries, AQL supports a variety of statements 
for data
 definition and manipulation purposes as well as controlling the context to be 
used in
-evaluating AQL expressions. AQL supports record-level ACID transactions that 
begin and terminate implicitly for each record inserted, deleted, or searched 
while a given AQL statement is being executed.
+evaluating AQL expressions. AQL supports record-level ACID transactions that 
begin and terminate implicitly for each record inserted, deleted, upserted, or 
searched while a given AQL statement is being executed.
 
 This section details the statements supported in the AQL language.
 
@@ -861,6 +862,27 @@
 
 delete $user from dataset FacebookUsers where $user.id = 8;
 
+ Upsert
+
+UpsertStatement ::= "upsert" "into" "dataset" QualifiedName Query
+
+The AQL upsert statement is used to couple delete (if found) with insert data 
into a dataset.
+The data to be upserted comes from an AQL query expression.
+The expression can be as simple as a constant expression, or in general it can 
be any legal AQL query.
+Upserts in AsterixDB are processed transactionally, with the scope of each 
upsert transaction
+being the upsertion (deletion if found + insertion) of a single object plus 
its affiliated
+secondary index entries (if any).
+If the query part of an upsert returns a single object, then the upsert 
statement itself will
+be a single, atomic transaction.
+If the query part returns multiple objects, then each object upserted will be 
handled independently
+as a tranaction.
+
+The following example illustrates a query-based upsertion.
+
+# Example
+
+upsert into dataset Users (for $user in dataset FacebookUsers return $user)
+
 We close this guide to AQL with one final example of a query expression.
 
 # Example
diff --git a/asterixdb/asterix-doc/src/site/markdown/aql/primer.md 
b/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
index b1ffec7..d99ba6d 100644
--- a/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
+++ b/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
@@ -900,6 +900,55 @@
 dataset where it resides, and another to insert the new replacement record 
(with the same primary key but with
 different field values for some of the associated data content).
 
+### Upserting Data  ###
+In addition to loading, querying, inserting, and deleting data, AsterixDB 
supports upserting
+records using the AQL _upsert_ statement.
+
+The following example deletes the tweet with the tweetid = 20 (if exists) and 
inserts the
+new tweet with tweetid=20 and the user "SwanSmitty" to the TweetMessages 
dataset. The two
+operations (delete if found and insert) are performed as an atomic operation 
that is either
+performed completely or not at all.
+
+use dataverse TinySocial;
+upsert into dataset TweetMessages
+(
+   {"tweetid":"20",
+"user":
+{"screen-name":"SwanSmitty",
+ "lang":"en",
+ "friends_count":91345,
+ "statuses_count":4079,
+ "name":"Swanson Smith",
+ "followers_count":50420
+},
+"sender-location":point("47.44,80.65"),
+"send-time":datetime("2008-04-26T10:10:35"),
+"referred-topics":{{"football"}},
+"message-text":"football is the best sport, period.!"
+   }

Change in asterixdb[master]: ASTERIXDB-1286 Add User Documentation for Upsert

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1286 Add User Documentation for Upsert
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/640
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I677dbeb5cbc7e8a83aa50db0c3cd59f91f6a2e69
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Carey 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Update adm.grammar and printers for double/float

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Update adm.grammar and printers for double/float
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6164d74f6c286fa160a30cff9ad47e97a30e0770
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: some graduation and branding fixes

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/959

Change subject: some graduation and branding fixes
..

some graduation and branding fixes

Change-Id: Idc1a81a611c032fa39ec624800380df83f513578
---
M README.md
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
M asterixdb/asterix-doc/src/site/markdown/aql/primer.md
M asterixdb/asterix-doc/src/site/markdown/index.md
M asterixdb/asterix-doc/src/site/markdown/overview.md
M asterixdb/asterix-doc/src/site/markdown/udf.md
M asterixdb/asterix-doc/src/site/markdown/yarn.md
8 files changed, 11 insertions(+), 21 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/959/1

diff --git a/README.md b/README.md
index cb76fd9..f522fc6 100644
--- a/README.md
+++ b/README.md
@@ -22,7 +22,7 @@
 
  * A semistructured NoSQL style data model (ADM) resulting from extending JSON 
with object database ideas
  * An expressive and declarative query language (AQL) that supports a broad 
range of queries and analysis over semistructured data
- * A parallel runtime query execution engine, Hyracks, that has been 
scale-tested on up to 1000+ cores and 500+ disks
+ * A parallel runtime query execution engine, Apache Hyracks, that has been 
scale-tested on up to 1000+ cores and 500+ disks
  * Partitioned LSM-based data storage and indexing to support efficient 
ingestion and management of semistructured data
  * Support for query access to externally stored data (e.g., data in HDFS) as 
well as to data stored natively by AsterixDB
  * A rich set of primitive data types, including spatial and temporal data in 
addition to integer, floating point, and textual data
@@ -52,7 +52,7 @@
 
 * Build AsterixDB master:
 
-$cd incubator-asterixdb
+$cd asterixdb
 $mvn clean package -DskipTests
 
 
diff --git a/asterixdb/asterix-doc/pom.xml b/asterixdb/asterix-doc/pom.xml
index 43dba09..5b18c79 100644
--- a/asterixdb/asterix-doc/pom.xml
+++ b/asterixdb/asterix-doc/pom.xml
@@ -24,7 +24,7 @@
 0.8.9-SNAPSHOT
   
 
-  http://asterixdb.incubator.apache.org/
+  http://asterixdb.apache.org/
 
   
 
@@ -72,7 +72,7 @@
 
   site
   site
-  file:../../../../site/incubator-asterixdb-site
+  file:../../../../site/asterixdb-site
 
   
 
diff --git a/asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md 
b/asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
index 6bff861..397140f 100644
--- a/asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
+++ b/asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
@@ -903,5 +903,5 @@
 AsterixDB is powerful, so use it wisely, and remember: "With great power comes 
great responsibility..." :-)
 
 Please e-mail the AsterixDB user group
-(users (at) asterixdb.incubator.apache.org)
+(users (at) asterixdb.apache.org)
 if you run into any problems or simply have further questions about the 
AsterixDB system, its features, or their proper use.
diff --git a/asterixdb/asterix-doc/src/site/markdown/aql/primer.md 
b/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
index d99ba6d..f56eb93 100644
--- a/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
+++ b/asterixdb/asterix-doc/src/site/markdown/aql/primer.md
@@ -961,5 +961,5 @@
 AsterixDB is powerful, so use it wisely, and remember: "With great power comes 
great responsibility..." :-)
 
 Please e-mail the AsterixDB user group
-(users (at) asterixdb.incubator.apache.org)
+(users (at) asterixdb.apache.org)
 if you run into any problems or simply have further questions about the 
AsterixDB system, its features, or their proper use.
diff --git a/asterixdb/asterix-doc/src/site/markdown/index.md 
b/asterixdb/asterix-doc/src/site/markdown/index.md
index bb74f1b..f117d93 100644
--- a/asterixdb/asterix-doc/src/site/markdown/index.md
+++ b/asterixdb/asterix-doc/src/site/markdown/index.md
@@ -28,7 +28,7 @@
with object database ideas
  * An expressive and declarative query language (AQL) that supports a broad
range of queries and analysis over semistructured data
- * A parallel runtime query execution engine, Hyracks, that has been
+ * A parallel runtime query execution engine, Apache Hyracks, that has been
scale-tested on up to 1000+ cores and 500+ disks
  * Partitioned LSM-based data storage and indexing to support efficient
ingestion and management of semistructured data
@@ -42,13 +42,3 @@
parametric queries
  * Basic transactional (concurrency and recovery) capabilities akin to those of
a NoSQL store
-
-### Disclaimer ###
-Apache AsterixDB is an effort undergoing incubation at The Apache Software
-Foundation (ASF), sponsored by the Apache incubator.
-Incubation is required of all newly accepted projects until a further review
-indicates that the infrastructure, communications, and decision making process
-have stabilized in a 

Change in asterixdb[master]: some graduation and branding fixes

[Till Westmann (Code Review)]

Till Westmann has uploaded a new patch set (#2).

Change subject: some graduation and branding fixes
..

some graduation and branding fixes

Change-Id: Idc1a81a611c032fa39ec624800380df83f513578
---
M README.md
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
M asterixdb/asterix-doc/src/site/markdown/aql/primer.md
M asterixdb/asterix-doc/src/site/markdown/index.md
M asterixdb/asterix-doc/src/site/markdown/overview.md
M asterixdb/asterix-doc/src/site/markdown/udf.md
M asterixdb/asterix-doc/src/site/markdown/yarn.md
8 files changed, 11 insertions(+), 21 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/959/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/959
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idc1a81a611c032fa39ec624800380df83f513578
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: ASTERIXDB-1501: add units for timings

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: ASTERIXDB-1501: add units for timings
..


ASTERIXDB-1501: add units for timings

Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/960
Reviewed-by: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 75 insertions(+), 2 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 35a780b..a080c83 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -125,6 +125,34 @@
 resultSize
 }
 
+public enum TimeUnit {
+SEC("s", 9),
+MILLI("ms", 6),
+MICRO("µs", 3),
+NANO("ns", 0);
+
+String unit;
+int nanoDigits;
+
+TimeUnit(String unit, int nanoDigits) {
+this.unit = unit;
+this.nanoDigits = nanoDigits;
+}
+
+static String formatNanos(long nanoTime) {
+final String strTime = String.valueOf(nanoTime);
+final int len = strTime.length();
+for (TimeUnit tu : TimeUnit.values()) {
+if (len > tu.nanoDigits) {
+final String integer = strTime.substring(0, len - 
tu.nanoDigits);
+final String fractional = strTime.substring(len - 
tu.nanoDigits);
+return integer + (fractional.length() > 0 ? "." + 
fractional : "") + tu.unit;
+}
+}
+return "illegal string value: " + strTime;
+}
+}
+
 private final ILangCompilationProvider compilationProvider = new 
SqlppCompilationProvider();
 
 static SessionConfig.OutputFormat getFormat(HttpServletRequest request) {
@@ -246,9 +274,9 @@
 pw.print(ResultFields.metrics.name());
 pw.print("\": {\n");
 pw.print("\t");
-printField(pw, Metrics.elapsedTime.name(), 
String.valueOf(elapsedTime));
+printField(pw, Metrics.elapsedTime.name(), 
TimeUnit.formatNanos(elapsedTime));
 pw.print("\t");
-printField(pw, Metrics.executionTime.name(), 
String.valueOf(executionTime));
+printField(pw, Metrics.executionTime.name(), 
TimeUnit.formatNanos(executionTime));
 pw.print("\t");
 printField(pw, Metrics.resultCount.name(), 
String.valueOf(resultCount));
 pw.print("\t");
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
new file mode 100644
index 000..f4889a0
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.asterix.api.http.servlet;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class QueryServiceServletTest {
+
+@Test
+public void testTimeUnitFormatNanos() throws Exception {
+Assert.assertEquals("123.456789012s", 
QueryServiceServlet.TimeUnit.formatNanos(123456789012l));
+Assert.assertEquals("12.345678901s", 
QueryServiceServlet.TimeUnit.formatNanos(12345678901l));
+Assert.assertEquals("1.234567890s", 
QueryServiceServlet.TimeUnit.formatNanos(1234567890l));
+Assert.assertEquals("123.456789ms", 
QueryServiceServlet.TimeUnit.formatNanos(123456789l));

Change in asterixdb[master]: WORK IN PROGRESS

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/694

to look at the new patch set (#10).

Change subject: WORK IN PROGRESS
..

WORK IN PROGRESS

symbolic constants in lock manager

Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/94/694/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/694
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: ASTERIXDB-1375 - New Query UI implementation

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1375 - New Query UI implementation
..


Patch Set 7:

(1 comment)

Just a few comments so far:

I think that would should find a more descriptive name than "newui". 
"Newui"will get old soon and then we're stuck with a strange name. Is there a 
more technical name for the package?

Since we've got potentially new outside code here (Angular, Bootstrap, ...) we 
need to find out what needs to be added to the LICENSE and NOTICE for it.

https://asterix-gerrit.ics.uci.edu/#/c/935/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryWebInterfaceServlet.java:

Line 42: public class QueryWebInterfaceServlet extends HttpServlet {
I think that this Servlet only serves static resources. Is that right? If so, 
could we call it something like "StaticResourceServlet"? I think that this 
would make it clearer what it does. Also it seems that the functionality might 
be useful to support other interfaces than the query web interface and a 
generic name could help to express that.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/935
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9aa6fb0a6bebaaa58f288e621dbfe76a604c689
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Kaveen Rodrigo 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: WIP - QueryService API updates

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/896

to look at the new patch set (#10).

Change subject: WIP - QueryService API updates
..

WIP - QueryService API updates

- API returns non-JSON results (ADM/CSV) as arrays of (escaped) strings
- fix encoding and content-length of response
- run SQL++ query tests through QueryService API
- fix tests/expected errors
- correct execution times in the case of errors
- re-structure printing of CSV headers
- improve parameter handling
- small API cleanup

Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/SessionConfig.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
D 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/JSONUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/records/RecordsQueries.xml
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf30/udf30.1.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/JSONUtil.java
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/ResultExtractor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
13 files changed, 702 insertions(+), 390 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/96/896/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1501: add units for timings

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/960

to look at the new patch set (#2).

Change subject: ASTERIXDB-1501: add units for timings
..

ASTERIXDB-1501: add units for timings

Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/QueryServiceServletTest.java
2 files changed, 76 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/960/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/960
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If95a717b3f6ffceb8235409519ed602180c124dc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: some graduation and branding fixes

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/959

to look at the new patch set (#3).

Change subject: some graduation and branding fixes
..

some graduation and branding fixes

Change-Id: Idc1a81a611c032fa39ec624800380df83f513578
---
M README.md
M asterixdb/asterix-doc/pom.xml
M asterixdb/asterix-doc/src/site/markdown/aql/primer-sql-like.md
M asterixdb/asterix-doc/src/site/markdown/aql/primer.md
M asterixdb/asterix-doc/src/site/markdown/index.md
M asterixdb/asterix-doc/src/site/markdown/overview.md
M asterixdb/asterix-doc/src/site/markdown/udf.md
M asterixdb/asterix-doc/src/site/markdown/yarn.md
8 files changed, 11 insertions(+), 21 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/959/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/959
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idc1a81a611c032fa39ec624800380df83f513578
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1228: Add MISSING into the data model.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1228: Add MISSING into the data model.
..


Patch Set 12: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/846
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49ed8474bfc5d6604231819065117468c5b0897
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: fewer copies

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: fewer copies
..


fewer copies

Change-Id: Ia409bf61140816c8246ab79c11732654613b20bf
Reviewed-on: https://asterix-gerrit.ics.uci.edu/823
Reviewed-by: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/parser/FunctionParser.java
1 file changed, 9 insertions(+), 12 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified



diff --git 
a/asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/parser/FunctionParser.java
 
b/asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/parser/FunctionParser.java
index 96086a1..1f58d08 100644
--- 
a/asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/parser/FunctionParser.java
+++ 
b/asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/parser/FunctionParser.java
@@ -19,7 +19,6 @@
 
 package org.apache.asterix.lang.aql.parser;
 
-import java.io.StringReader;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -30,6 +29,7 @@
 import org.apache.asterix.lang.common.statement.FunctionDecl;
 import org.apache.asterix.lang.common.struct.VarIdentifier;
 import org.apache.asterix.metadata.entities.Function;
+import org.apache.commons.io.input.CharSequenceReader;
 
 public class FunctionParser {
 
@@ -48,23 +48,20 @@
 builder.append(" use dataverse " + function.getDataverseName() + ";");
 builder.append(" declare function " + 
function.getName().split("@")[0]);
 builder.append("(");
+boolean first = true;
 for (String param : params) {
 VarIdentifier varId = new VarIdentifier(param);
 varIdentifiers.add(varId);
+if (first) {
+first = false;
+} else {
+builder.append(",");
+}
 builder.append(param);
-builder.append(",");
 }
-if (params.size() > 0) {
-builder.delete(builder.length() - 1, builder.length());
-}
-builder.append(")");
-builder.append("{");
-builder.append("\n");
-builder.append(functionBody);
-builder.append("\n");
-builder.append("}");
+builder.append("){\n").append(functionBody).append("\n}");
 
-IParser parser = parserFactory.createParser(new StringReader(new 
String(builder)));
+IParser parser = parserFactory.createParser(new 
CharSequenceReader(builder));
 List statements = parser.parse();
 FunctionDecl decl = (FunctionDecl) statements.get(1);
 return decl;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/823
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia409bf61140816c8246ab79c11732654613b20bf
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1190, ASTERIXDB-1216, ASTERIXDB-1317: fixes and r...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1190, ASTERIXDB-1216, ASTERIXDB-1317:  fixes and 
regression tests.
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If21ad96b1bff59fa2da601b920d4a61900cad81f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: some printer cleanup

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/882

to look at the new patch set (#4).

Change subject: some printer cleanup
..

some printer cleanup

Change-Id: I692c04dd1b3aa8e7adccfe960615f0fc2df6fe26
---
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryBase64Printer.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryHexPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ACirclePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ACirclePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADatePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADatePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADateTimePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADateTimePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADayTimeDurationPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADayTimeDurationPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADurationPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADurationPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt16Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt16PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt32Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt32PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt64Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt64PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt8Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt8PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ALinePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ALinePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullableFieldPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/APoint3DPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/APoint3DPrinterFactory.java
D 

Change in asterixdb[master]: some printer cleanup

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/882

to look at the new patch set (#6).

Change subject: some printer cleanup
..

some printer cleanup

Change-Id: I692c04dd1b3aa8e7adccfe960615f0fc2df6fe26
---
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryBase64Printer.java
R 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryHexPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABinaryPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ABooleanPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ACirclePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ACirclePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADatePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADatePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADateTimePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADateTimePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADayTimeDurationPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADayTimeDurationPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADoublePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADurationPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ADurationPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AFloatPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt16Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt16PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt32Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt32PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt64Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt64PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt8Printer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AInt8PrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AIntervalPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ALinePrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ALinePrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/ANullableFieldPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AObjectPrinterFactory.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AOrderedlistPrinterFactory.java
D 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/APoint3DPrinter.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/APoint3DPrinterFactory.java
D 

Change in asterixdb[master]: Fix query plans for constant aggregates.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Fix query plans for constant aggregates.
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/876
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c2b9f4d566e62d56efe14a317ea333420a6
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Support CASE expression in SQL++.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Support CASE expression in SQL++.
..


Patch Set 18: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1015
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9de7c3df70be43456e38a61ce767cc14f09e661
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Extension Points For Servlets

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Extension Points For Servlets
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1019
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff794b1c21296c50867b7430a0652924b5cf31d2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Support CASE expression in SQL++.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Support CASE expression in SQL++.
..


Patch Set 16: Code-Review+2

(2 comments)

Feel free to forward the +2 if you decide to address the comment in 
AbstractTypeCheckEvaluator.

https://asterix-gerrit.ics.uci.edu/#/c/1015/16/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractTypeCheckEvaluator.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/AbstractTypeCheckEvaluator.java:

Line 37: protected enum VALUE {
Why is this ALL_CAPS? Don't we usually use the same rules for enum names as for 
class names?


https://asterix-gerrit.ics.uci.edu/#/c/1015/16/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java:

Line 452: PA.invokeMethod(fd, 
"reset(org.apache.asterix.om.types.IAType, 
org.apache.asterix.om.types.IAType)", rt,
What is the cost of finding a "cleaner" solution than PA.invokeMethod? It's 
just a question, I know that there are many other uses as well.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1015
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9de7c3df70be43456e38a61ce767cc14f09e661
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Configure Log Level.INFO For Sample Local Cluster

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Configure Log Level.INFO For Sample Local Cluster
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1024
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I702cc150c46b8c35f2f46aebe297443e3dae928d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Non-Managix Sample Local Cluster Scripts

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add Non-Managix Sample Local Cluster Scripts
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1023
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I036fd27141721012d5c6486a73400678d824c741
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in incubator-asterixdb-site[asf-site]: ASTERIXDB-1526: remove "Cross-project Dependencies"

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/991

Change subject: ASTERIXDB-1526: remove "Cross-project Dependencies"
..

ASTERIXDB-1526: remove "Cross-project Dependencies"

Change-Id: I192b840fec49ccc6444c18ead35599ad3b777f7a
---
M content/dev-setup.html
M dev-setup.md
2 files changed, 40 insertions(+), 62 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/incubator-asterixdb-site 
refs/changes/91/991/1

diff --git a/content/dev-setup.html b/content/dev-setup.html
index 0112075..0208abc 100644
--- a/content/dev-setup.html
+++ b/content/dev-setup.html
@@ -129,7 +129,6 @@
   Using Jenkins with Gerrit

   Verification
   Retrigggering
 builds and triggering builds manually
-  Cross-project Dependencies
 
   
 
@@ -159,7 +158,7 @@
 
   A suitable *nix environment (Linux, OSX)
   JDK 1.8+
-  Maven 3.1.1 or greater
+  Maven 3.3.9 or greater
   A relatively recent version of Eclipse
 
 
@@ -169,7 +168,7 @@
   
 Check out AsterixDB master in one folder via git in the command line. 
Assume that the path is $HOME/workspace.
 
- git clone https://github.com/apache/asterixdb/
+ git clone https://github.com/apache/asterixdb/
 
 
 You will now have $HOME/workspace/asterixdb/.
@@ -177,8 +176,8 @@
   
 Go to the asterixdb folder and install it’s artifacts to the local 
Maven repository by executing the following commands:
 
- cd asterixdb/
- mvn install -DskipTests
+ cd asterixdb/
+ mvn install -DskipTests
 
   
   In Eclipse, import asterixdb as an existing Maven Project.
@@ -220,8 +219,8 @@
   
 Lastly, go to the asterixdb folder and execute following command again. 
This is required since Eclipse might have cleaned the projects and rebuilt the 
them without creating all necessary classes. Currently, some of the class files 
can be only built using mvn command.
 
- cd asterixdb/
- mvn install -DskipTests
+ cd asterixdb/
+ mvn install -DskipTests
 
   
 
@@ -293,12 +292,14 @@
   
 To work on (say) Asterix, first clone the GitHub mirror or the ASF 
repository (if you already have a local clone, great!), e.g.
 
-git clone https://github.com/apache/incubator-asterixdb
+git clone https://github.com/apache/incubator-asterixdb
+
   
   
 cd into the clone repo directory, and then run the 
following command to create the “gerrit” remote.
 
-git gerrit init
+git gerrit init
+
   
 
 
@@ -311,7 +312,7 @@
 When you want to start working on a bug, feature, etc, first make a 
local git branch. Never work directly on 
 master! master should always be a pure mirror of 
origin/master, i.e., the GitHub mirror or the ASF repository.
 
-   git checkout -b my_branch
+git checkout -b my_branch
 
   
   
@@ -323,27 +324,27 @@
   
 Every so often, you should update your local master 
mirror, and then merge that onto your working branch. This will prevent your 
branch from falling too far out of date, and ensure that your code review 
proposals will merge successfully with master. There are a number 
of ways to do this, but git-gerrit provides a convenience 
function:
 
-   git gerrit update
+git gerrit update
 
   
   
 When you are ready to submit changes for code review, first ensure that 
you have committed everything locally that is necessary (git 
status should report “nothing to commit, working directory clean”). This 
is also a good time to update (see step 4). Then run:
 
-   git gerrit submit
+git gerrit submit
 
   
   This will pop open your editor to invite you to create a good commit 
message. This will be the single commit message which will be the only one to 
appear in the project’s master git history. Take the time to make it clear. The 
editor will contain the log messages of everything you committed on your branch 
as a reminder, but generally you will want to delete all this and replace it 
with a comprehensive message. Also: As noted in the initial message, the last 
line of the buffer will contain a Change-Id field. Do not delete 
that line! It is used by Gerrit to identify this particular merge proposal.
   
 When you save your commit message, git-gerrit will push all of the 
changes from your working branch up to Gerrit. Assuming no errors, you should 
see output similar to the following:
 
-   remote: Resolving deltas: 100% (1/1)
-   remote: Processing changes: new: 1, refs: 1, done
-   remote: 
-   remote: New Changes:
-   remote:   http://fulliautomatix.ics.uci.edu:8443/30
-   remote: 
-   To ssh://c...@fulliautomatix.ics.uci.edu:29418/ceej-gerrit-test
-* [new branch]  HEAD - refs/for/master
+remote: Resolving deltas: 100% (1/1)
+remote: Processing changes: new: 1, refs: 1, done
+remote: 
+remote: New Changes:
+remote:   http://fulliautomatix.ics.uci.edu:8443/30
+remote: 
+To 

Change in asterixdb[master]: ASTERIXDB-1269 Fix Extraction of Query Segment and Refactor ...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1269 Fix Extraction of Query Segment and Refactor AQL 
Parser
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/988
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18ac4f8d86b3c5c7bfe226c98114499671649e93
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Some Cleanup, Additions to .gitignore

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Some Cleanup, Additions to .gitignore
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1013
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I624e42a2719065c26ff4cb70ab317bcce150471c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Implement EXPLAIN for SQL++

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1020

to look at the new patch set (#2).

Change subject: Implement EXPLAIN for SQL++
..

Implement EXPLAIN for SQL++

- move some code from static methods in ResultUtils to a stateful
  ResultPrinter to facilitate reuse (we create one ResultWriter per request)
- tiny cleanup in LogicalOperatorPrettyPrintVisitor

Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_simple/explain_simple.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_simple/explain_simple.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
10 files changed, 275 insertions(+), 131 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/20/1020/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1020
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Implement EXPLAIN for SQL++

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1020

Change subject: Implement EXPLAIN for SQL++
..

Implement EXPLAIN for SQL++

- move some code from static methods in ResultUtils to a stateful
  ResultPrinter to facilitate reuse (we create one ResultWriter per request)

Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_simple/explain_simple.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_simple/explain_simple.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
9 files changed, 271 insertions(+), 126 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/20/1020/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
index af17c05..d6864c1 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
@@ -18,6 +18,7 @@
  */
 package org.apache.asterix.api.common;
 
+import java.io.IOException;
 import java.io.PrintWriter;
 import java.rmi.RemoteException;
 import java.util.ArrayList;
@@ -48,6 +49,7 @@
 import org.apache.asterix.metadata.declared.AqlMetadataProvider;
 import org.apache.asterix.om.util.AsterixAppContextInfo;
 import org.apache.asterix.optimizer.base.RuleCollections;
+import org.apache.asterix.result.ResultUtils;
 import org.apache.asterix.runtime.job.listener.JobEventListenerFactory;
 import 
org.apache.asterix.transaction.management.service.transaction.JobIdFactory;
 import org.apache.asterix.translator.CompiledStatements.ICompiledDmlStatement;
@@ -279,6 +281,16 @@
 }
 }
 }
+if (rwQ != null && rwQ.isExplain()) {
+try {
+LogicalOperatorPrettyPrintVisitor pvisitor = new 
LogicalOperatorPrettyPrintVisitor();
+PlanPrettyPrinter.printPlan(plan, pvisitor, 0);
+ResultUtils.displayResults(pvisitor.get().toString(), conf, 
new ResultUtils.Stats(), null);
+return null;
+} catch (IOException e) {
+throw new AlgebricksException(e);
+}
+}
 
 if (!conf.isGenerateJobSpec()) {
 return null;
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
index 05d9b3d..d6065fb 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
@@ -2529,14 +2529,16 @@
 boolean bActiveTxn = true;
 metadataProvider.setMetadataTxnContext(mdTxnCtx);
 MetadataLockManager.INSTANCE.queryBegin(activeDefaultDataverse, 
query.getDataverses(), query.getDatasets());
-JobSpecification compiled = null;
 try {
-compiled = rewriteCompileQuery(metadataProvider, query, null);
+JobSpecification compiled = rewriteCompileQuery(metadataProvider, 
query, null);
 
 MetadataManager.INSTANCE.commitTransaction(mdTxnCtx);
 bActiveTxn = false;
 
-if (sessionConfig.isExecuteQuery() && compiled != null) {
+if (query.isExplain()) {
+sessionConfig.out().flush();
+return;
+} else if (sessionConfig.isExecuteQuery() && compiled != null) {
 
GlobalConfig.ASTERIX_LOGGER.info(compiled.toJSON().toString(1));
 JobId jobId = JobUtils.runJob(hcc, compiled, false);
 
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
new file mode 100644
index 000..c2dda75
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for 

Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 8: Code-Review+2

I think that I got confused by the big number of added constructors. 

I think that we should reduce that number again in the future as we make better 
and more consistent use of error codes and components.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

[Till Westmann (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/997

to look at the new patch set (#9).

Change subject: Cast Record Before Insert for Open Indexes
..

Cast Record Before Insert for Open Indexes

This change modifies the insert plan to perform cast for open
indexes before inserting to primary index. This avoids modification
of indexes and then doing complex work to try and undo the insert.
In addition, feeds can simply log and remove tuples which have
open fields of incompatible type.

Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
A asterixdb/asterix-app/data/external-parser/dropbox2/jobads3.txt
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.2.lib.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.3.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.4.update.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.5.query.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.6.lib.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.7.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.1.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.2.lib.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.3.ddl.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.4.update.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.5.query.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.6.lib.aql
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.7.ddl.aql
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser-with-open-index/feed-with-external-parser-with-open-index.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/feeds/feed-with-external-parser-with-two-open-indexes/feed-with-external-parser-with-two-open-indexes.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
M 
hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/InlineVariablesRule.java
M 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/HyracksDataException.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/utils/ExceptionUtils.java
30 files changed, 8,088 insertions(+), 448 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 

Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

[Till Westmann (Code Review)]

Hello Yingyi Bu, Ian Maxon,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/998

to look at the new patch set (#4).

Change subject: community and dev-setup fixes
..

community and dev-setup fixes

* remove incubator from mailing lists
* specify Eclipse version
* add IntelliJ IDEA to prerequisites
* some code formatting
* fix the "Manual Trigger" section

Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
---
M community.md
M content/community.html
M content/dev-setup.html
M dev-setup.md
4 files changed, 131 insertions(+), 103 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/incubator-asterixdb-site 
refs/changes/98/998/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/998
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Gerrit-PatchSet: 4
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Cast Record Before Insert for Open Indexes

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Cast Record Before Insert for Open Indexes
..


Patch Set 6: Code-Review+1

(3 comments)

Still needs Yingyi's rewriting expertise ...

https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java:

Line 145: }
This indicates that we haven't gotten this part of exception handling right 
yet. Needs to be fixed, but not in this change.


https://asterix-gerrit.ics.uci.edu/#/c/997/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/cast/ARecordCaster.java:

Line 238: requiredTypeTag.toString());
Don't need the toString() here ..


https://asterix-gerrit.ics.uci.edu/#/c/997/6/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
File 
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java:

Line 181: "Error evaluating tuple %1$s in 
AssignRuntime", e, tupleIndex);
Seems that $1s would be replaced by 'e', not 'tupleIndex'. 
Is that intended?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/997
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eef5813ddbfe1b9c518cd7f92d37c95e8486914
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Refactor General Active Classes

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Refactor General Active Classes
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/977
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a8f33ee5b45c5e090b08c24a102e369aae43c04
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in incubator-asterixdb-site[asf-site]: community and dev-setup fixes

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: community and dev-setup fixes
..


community and dev-setup fixes

* remove incubator from mailing lists
* specify Eclipse version
* add IntelliJ IDEA to prerequisites
* some code formatting
* fix the "Manual Trigger" section

Change-Id: Ic7b3c53ed39b1465954162e7e1f31b67f9df699c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/998
Reviewed-by: Yingyi Bu 
---
M community.md
M content/community.html
M content/dev-setup.html
M dev-setup.md
4 files changed, 131 insertions(+), 103 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved



diff --git a/community.md b/community.md
index 0755fbc..593be05 100644
--- a/community.md
+++ b/community.md
@@ -14,12 +14,12 @@
 Most AsterixDB and Hyracks related discussion takes place on these mailing 
lists. To subscribe, send a blank email to the subscription address.
 
 {:.table .table-striped .table-bordered}
-| Name  | Address  | Subscribe 
Address  | Archives |
-|---|--||--|
-| dev   | d...@asterixdb.incubator.apache.org   | 
dev-subscr...@asterixdb.incubator.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-dev/)|
-| users | us...@asterixdb.incubator.apache.org | 
users-subscr...@asterixdb.incubator.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-users/)|
-| commits   | comm...@asterixdb.incubator.apache.org   | 
commits-subscr...@asterixdb.incubator.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-commits/)|
-| notifications | notificati...@asterixdb.incubator.apache.org | 
notifications-subscr...@asterixdb.incubator.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-notifications/)|
+| Name  | Address| Subscribe Address   
 | Archives |
+|---||--|--|
+| dev   | d...@asterixdb.apache.org   | 
dev-subscr...@asterixdb.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-dev/)|
+| users | us...@asterixdb.apache.org | 
users-subscr...@asterixdb.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-users/)|
+| commits   | comm...@asterixdb.apache.org   | 
commits-subscr...@asterixdb.apache.org   | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-commits/)|
+| notifications | notifications@asterixdb.apache.org | 
notifications-subscr...@asterixdb.apache.org | 
[link](https://mail-archives.apache.org/mod_mbox/asterixdb-notifications/)|
 
 ### IRC
 
diff --git a/content/community.html b/content/community.html
index a9f0987..d4e0b8a 100644
--- a/content/community.html
+++ b/content/community.html
@@ -129,27 +129,27 @@
   
 
   dev
-  d...@asterixdb.incubator.apache.org
-  dev-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-dev/;>link
+  d...@asterixdb.apache.org
+  dev-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-dev/;>link
 
 
   users
-  us...@asterixdb.incubator.apache.org
-  users-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-users/;>link
+  us...@asterixdb.apache.org
+  users-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-users/;>link
 
 
   commits
-  comm...@asterixdb.incubator.apache.org
-  commits-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-commits/;>link
+  comm...@asterixdb.apache.org
+  commits-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-commits/;>link
 
 
   notifications
-  notificati...@asterixdb.incubator.apache.org
-  notifications-subscr...@asterixdb.incubator.apache.org
-  https://mail-archives.apache.org/mod_mbox/incubator-asterixdb-notifications/;>link
+  notifications@asterixdb.apache.org
+  notifications-subscr...@asterixdb.apache.org
+  https://mail-archives.apache.org/mod_mbox/asterixdb-notifications/;>link
 
   
 
diff --git a/content/dev-setup.html b/content/dev-setup.html
index 09fe42e..d252ee6 100644
--- a/content/dev-setup.html
+++ b/content/dev-setup.html
@@ -159,7 +159,7 @@
   A suitable *nix environment (Linux, OSX)
   JDK 1.8+
   Maven 3.3.9 or greater
-  A relatively recent 

Change in asterixdb[master]: ASTERIX-1135 Fix Feed Policy Creation From File

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIX-1135 Fix Feed Policy Creation From File
..


Patch Set 1:

Is there maybe a disabled test that could be re-enabled?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: small ADMParser/AdmLexer cleanup

[Till Westmann (Code Review)]

Till Westmann has uploaded a new patch set (#2).

Change subject: small ADMParser/AdmLexer cleanup
..

small ADMParser/AdmLexer cleanup

- do not declare IOExceptions that are not thrown
- improve formatting of lexer template

Change-Id: Id032f0c83ebef108a9eddb7242c586d5481217e4
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
M 
asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
4 files changed, 81 insertions(+), 92 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1032/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1032
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id032f0c83ebef108a9eddb7242c586d5481217e4
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Implement EXPLAIN for SQL++

[Till Westmann (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1020

to look at the new patch set (#7).

Change subject: Implement EXPLAIN for SQL++
..

Implement EXPLAIN for SQL++

- move some code from static methods in ResultUtils to a stateful
  ResultPrinter to facilitate reuse (we create one ResultWriter per request)
- tiny cleanup in LogicalOperatorPrettyPrintVisitor

Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
---
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_simple/explain_simple.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_simple/explain_simple.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/AqlDeleteRewriteVisitor.java
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/CloneAndSubstituteVariablesVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppDeleteRewriteVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
18 files changed, 292 insertions(+), 152 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/20/1020/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1020
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in incubator-asterixdb-site[asf-site]: fix download URLs

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: fix download URLs
..


fix download URLs

Change-Id: I09a689b0aae5685ce4e7139af2c0344e00ee6f1d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1034
Reviewed-by: Yingyi Bu 
---
M _config.yml
M content/download.html
M content/index.html
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved



diff --git a/_config.yml b/_config.yml
index a24ff52..90afade 100644
--- a/_config.yml
+++ b/_config.yml
@@ -3,9 +3,9 @@
 
 STABLE_VERSION: 0.8.8-incubating
 UNSTABLE_VERSION: 0.8.9-SNAPSHOT
-STABLE_DOWNLOAD_URL: 
"http://www.apache.org/dyn/closer.lua/asterixdb/asterix-installer-0.8.8-incubating-binary-assembly.zip;
+STABLE_DOWNLOAD_URL: 
"http://www.apache.org/dyn/closer.lua/asterixdb/asterixdb-0.8.8-incubating/asterix-installer-0.8.8-incubating-binary-assembly.zip;
 UNSTABLE_DOWNLOAD_URL: 
"https://asterix-jenkins.ics.uci.edu/job/asterix-integration-tests/lastSuccessfulBuild/org.apache.asterix$asterix-installer/artifact/org.apache.asterix/asterix-installer/0.8.9-SNAPSHOT/asterix-installer-0.8.9-SNAPSHOT-binary-assembly.zip;
-STABLE_YARN_URL: 
"http://www.apache.org/dyn/closer.lua/asterixdb/asterix-yarn-0.8.8-incubating-binary-assembly.zip;
+STABLE_YARN_URL: 
"http://www.apache.org/dyn/closer.lua/asterixdb/asterixdb-0.8.8-incubating/asterix-yarn-0.8.8-incubating-binary-assembly.zip;
 UNSTABLE_YARN_URL: 
"https://asterix-jenkins.ics.uci.edu/job/asterix-integration-tests/lastSuccessfulBuild/org.apache.asterix$asterix-yarn/artifact/org.apache.asterix/asterix-yarn/0.8.9-SNAPSHOT/asterix-yarn-0.8.9-SNAPSHOT-binary-assembly.zip;
 DOCS_BASE_URL: "docs"
 UNSTABLE_DOCS_BASE_URL: "https://ci.apache.org/projects/asterixdb/;
diff --git a/content/download.html b/content/download.html
index 8c9cbff..bf2505e 100644
--- a/content/download.html
+++ b/content/download.html
@@ -141,7 +141,7 @@
 
 
 
-http://www.apache.org/dyn/closer.lua/asterixdb/asterix-installer-0.8.8-incubating-binary-assembly.zip;
 role="button">Download AsterixDB 0.8.8-incubating  
+http://www.apache.org/dyn/closer.lua/asterixdb/asterixdb-0.8.8-incubating/asterix-installer-0.8.8-incubating-binary-assembly.zip;
 role="button">Download AsterixDB 0.8.8-incubating  
 
   
 
@@ -164,7 +164,7 @@
 
 
 
-http://www.apache.org/dyn/closer.lua/asterixdb/asterix-yarn-0.8.8-incubating-binary-assembly.zip;
 role="button">Download AsterixDB 0.8.8-incubating  
+http://www.apache.org/dyn/closer.lua/asterixdb/asterixdb-0.8.8-incubating/asterix-yarn-0.8.8-incubating-binary-assembly.zip;
 role="button">Download AsterixDB 0.8.8-incubating  
 
   
 
diff --git a/content/index.html b/content/index.html
index 547457f..7e5e59c 100644
--- a/content/index.html
+++ b/content/index.html
@@ -186,7 +186,7 @@
   
   
 Download
-http://www.apache.org/dyn/closer.lua/asterixdb/asterix-installer-0.8.8-incubating-binary-assembly.zip;
 role="button">Download AsterixDB 0.8.8-incubating 
+http://www.apache.org/dyn/closer.lua/asterixdb/asterixdb-0.8.8-incubating/asterix-installer-0.8.8-incubating-binary-assembly.zip;
 role="button">Download AsterixDB 0.8.8-incubating 
   https://github.com/apache/asterixdb/; role="button">GitHub 
 Installation Guide
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1034
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09a689b0aae5685ce4e7139af2c0344e00ee6f1d
Gerrit-PatchSet: 2
Gerrit-Project: incubator-asterixdb-site
Gerrit-Branch: asf-site
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: small ADMParser/AdmLexer cleanup

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: small ADMParser/AdmLexer cleanup
..


small ADMParser/AdmLexer cleanup

- do not declare IOExceptions that are not thrown
- improve formatting of lexer template

Change-Id: Id032f0c83ebef108a9eddb7242c586d5481217e4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1032
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: abdullah alamoudi 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
M 
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
M 
asterixdb/asterix-maven-plugins/lexer-generator-maven-plugin/src/main/resources/Lexer.java
4 files changed, 81 insertions(+), 92 deletions(-)

Approvals:
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
index 58d7c83..eb81d3f 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/ADMDataParser.java
@@ -124,11 +124,11 @@
 }
 }
 
-public ADMDataParser(ARecordType recordType, boolean isStream) throws 
IOException {
+public ADMDataParser(ARecordType recordType, boolean isStream) {
 this(null, recordType, isStream);
 }
 
-public ADMDataParser(String filename, ARecordType recordType, boolean 
isStream) throws IOException {
+public ADMDataParser(String filename, ARecordType recordType, boolean 
isStream) {
 this.filename = filename;
 this.recordType = recordType;
 this.isStreamParser = isStream;
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
index 7732820..efc9574 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/ADMDataParserFactory.java
@@ -18,9 +18,9 @@
  */
 package org.apache.asterix.external.parser.factory;
 
-import 
org.apache.asterix.external.api.IExternalDataSourceFactory.DataSourceType;
 import org.apache.asterix.external.api.IRecordDataParser;
 import org.apache.asterix.external.api.IStreamDataParser;
+import 
org.apache.asterix.external.api.IExternalDataSourceFactory.DataSourceType;
 import org.apache.asterix.external.parser.ADMDataParser;
 import org.apache.asterix.external.util.ExternalDataUtils;
 import org.apache.asterix.om.types.ARecordType;
@@ -32,18 +32,13 @@
 private static final long serialVersionUID = 1L;
 
 @Override
-public IRecordDataParser createRecordParser(IHyracksTaskContext 
ctx) throws HyracksDataException {
+public IRecordDataParser createRecordParser(IHyracksTaskContext 
ctx) {
 return createParser();
 }
 
-private ADMDataParser createParser() throws HyracksDataException {
-try {
-ADMDataParser parser = new ADMDataParser(recordType,
-
ExternalDataUtils.getDataSourceType(configuration).equals(DataSourceType.STREAM));
-return parser;
-} catch (Exception e) {
-throw new HyracksDataException(e);
-}
+private ADMDataParser createParser() {
+return new ADMDataParser(recordType,
+
ExternalDataUtils.getDataSourceType(configuration).equals(DataSourceType.STREAM));
 }
 
 @Override
diff --git 
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
 
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
index 6850c2b..d45097a 100644
--- 
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
+++ 
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java
@@ -83,18 +83,12 @@
 .getApplicationObject();
 ClusterPartition nodePartition = 
propertiesProvider.getMetadataProperties().getNodePartitions()

Change in asterixdb[master]: Extension Points For Servlets

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Extension Points For Servlets
..


Patch Set 2:

(11 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java:

Line 58: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java:

Line 46: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryResultAPIServlet.java:

Line 41: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java:

Line 56: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryStatusAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryStatusAPIServlet.java:

Line 39: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/RESTAPIServlet.java:

Line 52: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java:

Line 38: import static org.apache.asterix.api.http.servlet.ServletConstants.*;
Can we do non-* static includes?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/VersionAPIServlet.java:

Line 39: AsterixAppContextInfo props = (AsterixAppContextInfo) 
context.getAttribute(ServletConstants.ASTERIX_BUILD_PROP_ATTR);
Static include for this one?


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java:

Line 207: switch (key) {
If it were me, I'd have a method createServlet(Servlets key) that only has a 
big switch with returns. We could save all of those "breaks" :)


https://asterix-gerrit.ics.uci.edu/#/c/1019/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionAPIServletTest.java:

Line 43: import static org.mockito.Mockito.*;
Can we do non-* static includes?


Line 71: 
when(mockContext.getAttribute(ServletConstants.HYRACKS_CONNECTION_ATTR)).thenReturn(mockHcc);
Static includes for these?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1019
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff794b1c21296c50867b7430a0652924b5cf31d2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1553: ClusterControllerService Dir/File Creation O...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1553: ClusterControllerService Dir/File Creation 
On-Demand
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1029
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2e65cf083b3eb2db3e716f2b34fb28fe01debca
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
..


Patch Set 6:

(55 comments)

Most comments are one the comments for the tests. There's quite q bit of 
strange whitespace in there. Also the comments often seem unrelated to the test 
...

https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS

Also, this seems to use the file adapter, not a simulator.


Line 21:   Begin ingestion and verify contents of the dataset 
post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS

Also, this seems to use the file adapter, not a simulator.


Line 21:   Begin ingestion and verify contents of the dataset 
post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS

Also, this seems to use the file adapter, not a simulator.


Line 21:   Begin ingestion and verify contents of the dataset 
post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset with an associated function 
and verify contents in Metadata
Where does the content verification in Metadata happen?


Line 35: }  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.1.ddl.sqlpp:

Line 21:   Create a dataset that has an associated rtree index.
There seems to be no index created ...


Line 22:   The synthetic feed simulator uses the Social-Data 
generator to generate data and simulate a feed.
Is "twitter_firehose" a synthetic feed simulator?


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.2.update.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator 
adapter.   
WS

Other comments as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_07/feeds_07.3.query.sqlpp:

Line 20:  * Description  : Create a feed using the synthetic feed simulator 
adapter.   
WS

Other comments as before.


Line 32: case 
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.1.ddl.sqlpp:

Line 22:   The synthetic feed simulator uses the Social-Data 
generator
Again, wondering if twitter_firehose is a synthetic feed.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.2.update.sqlpp:

Line 22:   The synthetic feed simulator uses the Social-Data 
generator
Comment as before.


https://asterix-gerrit.ics.uci.edu/#/c/1018/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_08/feeds_08.3.query.sqlpp:

Line 22:   The synthetic feed simulator uses the Social-Data 
generator
Comment as before.


Line 34: case 
WS

Change in asterixdb[master]: ASTERIXDB-1527: fix operator precedence order.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1527: fix operator precedence order.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1025
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib16477c4fad341685e9b1349f40eeabfc74b0165
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1552: Test Case for Sample Local Cluster

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1552: Test Case for Sample Local Cluster
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1028
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eacbd033a65661d22dc2a848afd83bbcc43677f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Implement EXPLAIN for SQL++

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1020

to look at the new patch set (#5).

Change subject: Implement EXPLAIN for SQL++
..

Implement EXPLAIN for SQL++

- move some code from static methods in ResultUtils to a stateful
  ResultPrinter to facilitate reuse (we create one ResultWriter per request)
- tiny cleanup in LogicalOperatorPrettyPrintVisitor

Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
---
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_simple/explain_simple.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_simple/explain_simple.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/AqlDeleteRewriteVisitor.java
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/CloneAndSubstituteVariablesVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppDeleteRewriteVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
18 files changed, 292 insertions(+), 152 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/20/1020/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1020
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Implement EXPLAIN for SQL++

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Implement EXPLAIN for SQL++
..


Patch Set 4:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1020/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java:

Line 51: private boolean wrap_array = false;
> camel case convention?
Done


Line 53: private boolean notfirst = false;
> camel case convention?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1020/4/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
File 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java:

Line 32: private boolean explain = false;
> make that part of the constructor so that we can set that right in visitors
Done


Line 109: public int hashCode() {
> make "explain" part of the hash code calculation?
Done


Line 120: }
> make "explain" part of the equality check?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1020
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
..


Patch Set 7: Code-Review+2

(9 comments)

So happy you left some whitespace in there for me to find.

https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.1.ddl.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS


Line 21:   Begin ingestion and verify contents of the dataset 
post completion.  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.2.update.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS


Line 21:   Begin ingestion and verify contents of the dataset 
post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_02/feeds_02.3.query.sqlpp:

Line 20:  * Description  : Create a feed dataset that uses the feed simulator 
adapter. 
WS


Line 21:   Begin ingestion and verify contents of the dataset 
post completion.  
WS


Line 25:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1018/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/feeds_03/feeds_03.1.ddl.sqlpp:

Line 35: }  
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Refactor Metadata Record Types

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Refactor Metadata Record Types
..


Patch Set 3: Code-Review+2

Checked for whitespace ... :)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1031
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10bc8c0bc255a377dba724f04b6b588910f26cb2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-769: adds a regression test.

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-769: adds a regression test.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1027
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaa6a37de981c5f60a416db85d3485d042558f63
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Implement EXPLAIN for SQL++

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1020

to look at the new patch set (#6).

Change subject: Implement EXPLAIN for SQL++
..

Implement EXPLAIN for SQL++

- move some code from static methods in ResultUtils to a stateful
  ResultPrinter to facilitate reuse (we create one ResultWriter per request)
- tiny cleanup in LogicalOperatorPrettyPrintVisitor

Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
---
M asterixdb/asterix-algebra/src/main/javacc/AQLPlus.jj
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
A 
asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultPrinter.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/result/ResultUtils.java
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_simple/explain_simple.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_simple/explain_simple.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/statement/SubscribeFeedStatement.java
M 
asterixdb/asterix-lang-aql/src/main/java/org/apache/asterix/lang/aql/visitor/AqlDeleteRewriteVisitor.java
M asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/statement/Query.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/AbstractInlineUdfsVisitor.java
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/CloneAndSubstituteVariablesVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/DeepCopyVisitor.java
M 
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/visitor/SqlppDeleteRewriteVisitor.java
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
M 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
18 files changed, 292 insertions(+), 152 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/20/1020/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1020
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b7028fb243d494150cac525c73b2d77b0068646
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: ASTERIXDB-1135 Fix Feed Policy Creation From File

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1135 Fix Feed Policy Creation From File
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1018
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I452ac11714e20e2ecc31ab8b96a9964ca9d9d6cd
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1561: EXPLAIN should be case insensitive

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1042

Change subject: ASTERIXDB-1561: EXPLAIN should be case insensitive
..

ASTERIXDB-1561: EXPLAIN should be case insensitive

Change-Id: I5add61c5ca07f0653f6811fdd4be215ce4f67eee
---
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1042/1

diff --git a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj 
b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
index 0bb0b87..a0a9742 100644
--- a/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
+++ b/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
@@ -1568,7 +1568,7 @@
   Query query;
 }
 {
-  "explain" query = Query(true)
+   query = Query(true)
   {
 return query;
   }
@@ -2878,6 +2878,7 @@
   | 
   | 
   | 
+  | 
   | 
   | 
   | 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1042
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5add61c5ca07f0653f6811fdd4be215ce4f67eee
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 

Change in asterixdb[master]: ASTERIXDB-1561: EXPLAIN should be case insensitive

[Till Westmann (Code Review)]

Till Westmann has uploaded a new patch set (#2).

Change subject: ASTERIXDB-1561: EXPLAIN should be case insensitive
..

ASTERIXDB-1561: EXPLAIN should be case insensitive

Change-Id: I5add61c5ca07f0653f6811fdd4be215ce4f67eee
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/explain/explain_caps/explain_caps.1.query.sqlpp
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
3 files changed, 31 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/42/1042/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1042
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5add61c5ca07f0653f6811fdd4be215ce4f67eee
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: WIP - inline variable

[Till Westmann (Code Review)]

Hello Michael Blow, Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/848

to look at the new patch set (#7).

Change subject: WIP - inline variable
..

WIP - inline variable

Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/48/848/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/848
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: WIP - stop transaction subsystem

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/847

to look at the new patch set (#8).

Change subject: WIP - stop transaction subsystem
..

WIP - stop transaction subsystem

Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IAsterixAppRuntimeContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionSubsystem.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointThread.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionSubsystem.java
6 files changed, 37 insertions(+), 16 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/47/847/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/847
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a67a977fa1f2718e02b2bfb28a2b0ed2d5242a7
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet

[Till Westmann (Code Review)]

Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1043

Change subject: Pass compilation provider to QueryServiceServlet
..

Pass compilation provider to QueryServiceServlet

Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/43/1043/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 2e6ee58..f208694 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -61,7 +61,7 @@
 
 private static final Logger LOGGER = 
Logger.getLogger(QueryServiceServlet.class.getName());
 
-private transient final ILangCompilationProvider compilationProvider = new 
SqlppCompilationProvider();
+private transient final ILangCompilationProvider compilationProvider;
 
 public enum Parameter {
 // Standard
@@ -210,6 +210,10 @@
 }
 }
 
+public QueryServiceServlet(final ILangCompilationProvider 
compilationProvider) {
+this.compilationProvider = compilationProvider;
+}
+
 private static String getParameterValue(String content, String attribute) {
 int sc = content.indexOf(';');
 if (sc < 0) {
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index b77544e..916c81f 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -233,7 +233,7 @@
 case QUERY_RESULT:
 return new QueryResultAPIServlet();
 case QUERY_SERVICE:
-return new QueryServiceServlet();
+return new QueryServiceServlet(new SqlppCompilationProvider());
 case CONNECTOR:
 return new ConnectorAPIServlet();
 case SHUTDOWN:

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 

Change in asterixdb[master]: WIP - DO NOT REVIEW YET

[Till Westmann (Code Review)]

Till Westmann has abandoned this change.

Change subject: WIP - DO NOT REVIEW YET
..


Abandoned

too old

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/690
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If76d261f7b5526269ad3ecda5e172bff58f2b4bc
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Pass compilation provider to QueryServiceServlet

[Till Westmann (Code Review)]

Till Westmann has submitted this change and it was merged.

Change subject: Pass compilation provider to QueryServiceServlet
..


Pass compilation provider to QueryServiceServlet

Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1043
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
2 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
index 2e6ee58..f208694 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
@@ -61,7 +61,7 @@
 
 private static final Logger LOGGER = 
Logger.getLogger(QueryServiceServlet.class.getName());
 
-private transient final ILangCompilationProvider compilationProvider = new 
SqlppCompilationProvider();
+private transient final ILangCompilationProvider compilationProvider;
 
 public enum Parameter {
 // Standard
@@ -210,6 +210,10 @@
 }
 }
 
+public QueryServiceServlet(final ILangCompilationProvider 
compilationProvider) {
+this.compilationProvider = compilationProvider;
+}
+
 private static String getParameterValue(String content, String attribute) {
 int sc = content.indexOf(';');
 if (sc < 0) {
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index b77544e..916c81f 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -233,7 +233,7 @@
 case QUERY_RESULT:
 return new QueryResultAPIServlet();
 case QUERY_SERVICE:
-return new QueryServiceServlet();
+return new QueryServiceServlet(new SqlppCompilationProvider());
 case CONNECTOR:
 return new ConnectorAPIServlet();
 case SHUTDOWN:

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1043
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I795a2dab622ab40b39f6aaf548a27ffbd40c9efd
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: some code reduction/cleanup

[Till Westmann (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/916

to look at the new patch set (#8).

Change subject: some code reduction/cleanup
..

some code reduction/cleanup

Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/ARecordVisitablePointable.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/RecordRemoveFieldsTypeComputer.java
3 files changed, 90 insertions(+), 117 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/916/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I179a16fc183bd50d5d58cc12321234df1615abfd
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Cameron Samak 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 

Change in asterixdb[master]: Inline variable

[Till Westmann (Code Review)]

Hello Michael Blow, Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/848

to look at the new patch set (#9).

Change subject: Inline variable
..

Inline variable

Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/48/848/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/848
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Inline variable

[Till Westmann (Code Review)]

Hello Michael Blow, Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/848

to look at the new patch set (#8).

Change subject: Inline variable
..

Inline variable

Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
---
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/ClusterPartition.java
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/48/848/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/848
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fe6572686a494bfbc2d4de64eae84e625dece4d
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu