ptupitsyn merged PR #3658:
URL: https://github.com/apache/ignite-3/pull/3658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zstan commented on code in PR #3642:
URL: https://github.com/apache/ignite-3/pull/3642#discussion_r1580508874
##
modules/sql-engine/src/integrationTest/sql/join/inner/test_table_from_outer_join_used_in_inner.test:
##
@@ -0,0 +1,55 @@
+# name:
zstan opened a new pull request, #3666:
URL: https://github.com/apache/ignite-3/pull/3666
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
###
ptupitsyn merged PR #3662:
URL: https://github.com/apache/ignite-3/pull/3662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ptupitsyn merged PR #3663:
URL: https://github.com/apache/ignite-3/pull/3663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ptupitsyn closed issue #11325: IBinarizable : Mapping complex objects
URL: https://github.com/apache/ignite/issues/11325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ptupitsyn commented on issue #11325:
URL: https://github.com/apache/ignite/issues/11325#issuecomment-2078627474
Adding `address object` column to your DDL script fixes the issue.
SQL engine does not drill down the nested object if there is no matching
column.
--
This is an
denis-chudov commented on code in PR #3591:
URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1579026948
##
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionTestUtils.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
AMashenkov commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579069437
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##
@@ -1167,14 +1180,9 @@ public void catalogActivationTime()
Vladsz83 opened a new pull request, #11332:
URL: https://github.com/apache/ignite/pull/11332
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
PakhomovAlexander commented on code in PR #3655:
URL: https://github.com/apache/ignite-3/pull/3655#discussion_r1579100049
##
modules/compute/jobs.gradle:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license
korlov42 commented on code in PR #3608:
URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1579037309
##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java:
##
@@ -0,0 +1,718 @@
+/*
+ * Licensed to the Apache Software
korlov42 commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579111608
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##
@@ -1748,19 +1754,12 @@ public void
korlov42 commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579110626
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##
@@ -1719,14 +1728,11 @@ public void testColumnEvents() {
alievmirza closed pull request #3422: IGNITE-18991 Move stable/planned/pending
assignments from table to distribution zone root keys
URL: https://github.com/apache/ignite-3/pull/3422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AMashenkov commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579072271
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##
@@ -1748,19 +1754,12 @@ public void
PakhomovAlexander merged PR #3646:
URL: https://github.com/apache/ignite-3/pull/3646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AMashenkov commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579071207
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##
@@ -1719,14 +1728,11 @@ public void testColumnEvents() {
AMashenkov commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579069437
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##
@@ -1167,14 +1180,9 @@ public void catalogActivationTime()
denis-chudov commented on code in PR #3591:
URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1579029801
##
modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTxResourcesVacuumTest.java:
##
@@ -0,0 +1,559 @@
+/*
+ * Licensed to the Apache
tkalkirill merged PR #3650:
URL: https://github.com/apache/ignite-3/pull/3650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
denis-chudov commented on code in PR #3591:
URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1578374314
##
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/VolatileTxStateMetaStorage.java:
##
@@ -118,35 +129,56 @@ public Collection states() {
ygerzhedovich merged PR #3652:
URL: https://github.com/apache/ignite-3/pull/3652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ygerzhedovich commented on code in PR #3642:
URL: https://github.com/apache/ignite-3/pull/3642#discussion_r1579147174
##
modules/sql-engine/src/integrationTest/sql/join/inner/test_table_from_outer_join_used_in_inner.test:
##
@@ -0,0 +1,55 @@
+# name:
ygerzhedovich opened a new pull request, #3660:
URL: https://github.com/apache/ignite-3/pull/3660
https://issues.apache.org/jira/browse/IGNITE-21953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sashapolo opened a new pull request, #3659:
URL: https://github.com/apache/ignite-3/pull/3659
https://issues.apache.org/jira/browse/IGNITE-22105
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask
PakhomovAlexander merged PR #3655:
URL: https://github.com/apache/ignite-3/pull/3655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sashapolo commented on code in PR #3659:
URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579473233
##
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##
@@ -350,52 +352,66 @@ private
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579522019
##
modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/BaseCatalogManagerTest.java:
##
@@ -104,19 +102,16 @@ void setUp() {
() ->
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579590642
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579604057
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579617708
##
modules/compute/src/test/java/org/apache/ignite/internal/compute/ComputeComponentImplTest.java:
##
@@ -477,12 +478,12 @@ void remoteExecutionReleasesStopLock()
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579619834
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
ptupitsyn commented on PR #3397:
URL: https://github.com/apache/ignite-3/pull/3397#issuecomment-2077338901
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579572557
##
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##
@@ -228,10 +230,16 @@ public void stop() throws Exception {
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579640666
##
modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java:
##
@@ -1175,24 +1176,58 @@ public static byte[] byteBufferToByteArray(ByteBuffer
ptupitsyn commented on PR #3648:
URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077487178
Build failed.
@dependabot ignore this major version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dependabot[bot] commented on PR #3648:
URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077487393
OK, I won't notify you about version 11.x.x again, unless you re-open this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dependabot[bot] closed pull request #3648: Bump
fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3
URL: https://github.com/apache/ignite-3/pull/3648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ptupitsyn merged PR #3397:
URL: https://github.com/apache/ignite-3/pull/3397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ptupitsyn merged PR #3494:
URL: https://github.com/apache/ignite-3/pull/3494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ptupitsyn merged PR #3657:
URL: https://github.com/apache/ignite-3/pull/3657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579468084
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java:
##
@@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest
sashapolo merged PR #3659:
URL: https://github.com/apache/ignite-3/pull/3659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579528313
##
modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java:
##
@@ -126,10 +124,8 @@ public void beforeNodeStop() {
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579578818
##
modules/client/src/test/java/org/apache/ignite/client/TestServer.java:
##
@@ -315,10 +317,11 @@ public FakePlacementDriver placementDriver() {
/**
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579605232
##
modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java:
##
@@ -102,12 +102,12 @@ public void setup() {
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579604057
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579636368
##
modules/core/src/main/java/org/apache/ignite/internal/manager/IgniteComponent.java:
##
@@ -47,7 +47,7 @@ default void beforeNodeStop() {
* Stops the
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579654791
##
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java:
##
@@ -138,11 +134,11 @@ public void
sashapolo commented on code in PR #3659:
URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579471498
##
modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/raft/AbstractClusterStateStorageTest.java:
##
@@ -371,11 +330,26 @@ void
rpuch commented on code in PR #3659:
URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579306454
##
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##
@@ -350,52 +352,66 @@ private
rpuch commented on code in PR #3659:
URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579525030
##
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##
@@ -350,52 +352,66 @@ private
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579524843
##
modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java:
##
@@ -91,11 +92,8 @@ public void beforeNodeStop() {
}
Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675
##
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List addrs,
ptupitsyn commented on PR #3494:
URL: https://github.com/apache/ignite-3/pull/3494#issuecomment-2077339983
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ptupitsyn commented on PR #3648:
URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077339817
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579648035
##
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java:
##
@@ -297,7
alievmirza commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579656780
##
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##
@@ -363,6 +361,30 @@ public CompletableFuture compactCatalog(long
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579694364
##
modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java:
##
@@ -226,7 +226,10 @@ private void createAndStartComponents() {
dependabot[bot] opened a new pull request, #3661:
URL: https://github.com/apache/ignite-3/pull/3661
Bumps
[io.github.bonede:tree-sitter](https://github.com/bonede/tree-sitter-ng) from
0.22.2 to 0.22.5.
Release notes
Sourced from
dependabot[bot] opened a new pull request, #3662:
URL: https://github.com/apache/ignite-3/pull/3662
Bumps org.openapi.generator from 7.4.0 to 7.5.0.
[![Dependabot compatibility
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579703433
##
modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageServiceTest.java:
##
@@ -201,8 +201,8 @@ private static class
dependabot[bot] opened a new pull request, #3663:
URL: https://github.com/apache/ignite-3/pull/3663
Bumps `bouncycastle` from 1.76 to 1.78.1.
Updates `org.bouncycastle:bcprov-jdk18on` from 1.76 to 1.78.1
Commits
See full diff in
dependabot[bot] opened a new pull request, #3664:
URL: https://github.com/apache/ignite-3/pull/3664
Bumps
[io.github.bonede:tree-sitter-json](https://github.com/bonede/tree-sitter-ng)
from 0.20.1 to 0.21.0.
Release notes
Sourced from
korlov42 commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579707204
##
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/NewZoneEntry.java:
##
@@ -72,13 +72,17 @@ public CatalogEventParameters
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579723031
##
modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java:
##
@@ -178,24 +177,12 @@ public CompletableFuture
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579728997
##
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java:
##
@@ -221,8 +221,8 @@ String name() {
}
void
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579729570
##
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java:
##
@@ -258,7 +258,10 @@ void beforeNodeStop() throws Exception {
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579727992
##
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java:
##
@@ -120,8 +120,8 @@ Peer asPeer() {
}
void start()
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579823834
##
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java:
##
@@ -97,14 +100,12 @@ void before() throws Exception {
NSAmelchev commented on code in PR #11331:
URL: https://github.com/apache/ignite/pull/11331#discussion_r1579675414
##
docs/_docs/monitoring-metrics/custom-metrics.adoc:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor
NSAmelchev commented on code in PR #11331:
URL: https://github.com/apache/ignite/pull/11331#discussion_r1579679939
##
docs/_docs/monitoring-metrics/custom-metrics.adoc:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor
NSAmelchev commented on code in PR #11331:
URL: https://github.com/apache/ignite/pull/11331#discussion_r1579687570
##
docs/_docs/monitoring-metrics/custom-metrics.adoc:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579697076
##
modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java:
##
@@ -139,9 +139,9 @@ void setUp(
NSAmelchev commented on code in PR #11331:
URL: https://github.com/apache/ignite/pull/11331#discussion_r1579683015
##
docs/_docs/monitoring-metrics/custom-metrics.adoc:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor
korlov42 commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579702498
##
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##
@@ -363,6 +361,30 @@ public CompletableFuture compactCatalog(long
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579701159
##
modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java:
##
@@ -123,8 +123,8 @@ public void setUp() {
}
@AfterEach
-void
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579724136
##
modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/Node.java:
##
@@ -52,13 +55,13 @@ class Node implements AutoCloseable {
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579724921
##
modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/PlacementDriverManagerTest.java:
##
@@ -209,14 +209,14 @@ private void
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579824596
##
modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/JraftAbstractTest.java:
##
@@ -171,7 +173,7 @@ protected JraftServerImpl startServer(int idx,
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579840663
##
modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java:
##
@@ -195,19 +197,19 @@ public void
NSAmelchev commented on code in PR #11331:
URL: https://github.com/apache/ignite/pull/11331#discussion_r1579683015
##
docs/_docs/monitoring-metrics/custom-metrics.adoc:
##
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579697076
##
modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java:
##
@@ -139,9 +139,9 @@ void setUp(
valepakh opened a new pull request, #3665:
URL: https://github.com/apache/ignite-3/pull/3665
https://issues.apache.org/jira/browse/IGNITE-22064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579841013
##
modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java:
##
@@ -195,19 +197,19 @@ public void
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579840663
##
modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java:
##
@@ -195,19 +197,19 @@ public void
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579846730
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##
@@ -698,7 +698,9 @@ public CompletableFuture>
Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579857130
##
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java:
##
@@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579857581
##
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##
@@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable
e)
Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1580051040
##
modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java:
##
@@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {
Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579989020
##
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##
@@ -228,10 +230,16 @@ public void stop() throws Exception {
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579859118
##
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##
@@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable
e)
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579864902
##
modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java:
##
@@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {
Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579870204
##
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##
@@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable
e)
sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579867816
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java:
##
@@ -53,18 +53,18 @@ public class
Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579880642
##
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##
@@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable
e)
1 - 100 of 130 matches
Mail list logo