[GitHub] wu-sheng commented on issue #1124: Duplicated service search result

[GitBox]

wu-sheng commented on issue #1124: Duplicated service search result
URL: 
https://github.com/apache/incubator-skywalking/issues/1124#issuecomment-386185825
 
 
   I am moving this issue to beta2, because this is caused by this service is 
out of date. I guess, some one sets the application code wrong accidently, but 
service register info could not be removed by now.
   
   So, I proposal that, we should support auto remove if the service has no 
call in the certain time(could config) 
   
   @peng-yongsheng please consider to provide this feature in beta2.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

[GitBox]

chidaodezhongsheng commented on issue #1220: support shardingjdbc database 
storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682
 
 
   @wu-sheng thanks a lot, I will resolve the conflicts and mentions.
   
   技术部·架构部·林嘉琦
   手机：18710075837
   Email：linji...@dangdang.com
   QQ：928926755
   
   发件人: 吴晟 Wu Sheng [mailto:notificati...@github.com]
   发送时间: 2018年5月14日 15:45
   收件人: apache/incubator-skywalking
   抄送: 林嘉琦; Mention
   主题: Re: [apache/incubator-skywalking] support shardingjdbc database storage 
feature (#1220)
   
   
   @wu-sheng commented on this pull request.
   
   @chidaodezhongsheng The 
implementation codes are under incubating. So you will take charge. I just 
reviewed the licenses and documents related things.
   
   Some things need to change.
   
   
   
   In 
apm-collector/apm-collector-boot/src/main/resources/application.yml:
   
   > +contextPath: /
   
   +storage:
   
   +  elasticsearch:
   
   +clusterName: CollectorDBCluster
   
   +clusterTransportSniffer: true
   
   +clusterNodes: localhost:9300
   
   +indexShardsNumber: 2
   
   +indexReplicasNumber: 0
   
   +highPerformanceMode: true
   
   +ttl: 7
   
   +#storage:
   
   +#  h2:
   
   +#url: jdbc:h2:~/memorydb
   
   +#userName: sa
   
   +#storage:
   
   +#  shardingjdbc:
   
   ShardingJDBC is an incubating feature, no use cases yet. And none of the 
contributors are committer yet. So, by that, please don't put Sharding JDBC in 
default application.yml. Even it is under comments.
   
   
   
   In 
apm-dist/release-docs/LICENSE:
   
   > @@ -255,6 +256,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
   
Apache: commons-configuration 1.8: 
https://github.com/apache/commons-configuration, Apache 2.0
   
Apache: commons-io 2.4: https://github.com/apache/commons-io, Apache 2.0
   
Apache: tomcat 8.5.27: https://github.com/apache/tomcat/tree/trunk, 
Apache 2.0
   
   +Apache: groovy 2.4.5-indy: https://github.com/apache/groovy, Apache 2.0
   
   Groovy has a NOTICE file. Please change NOTICE in same folder. And follow 
the file structure. Ref here: 
https://github.com/apache/groovy/blob/master/NOTICE
   
   
   
   In 
docs/README.md:
   
   > -* [Agent or collector version upgrade](en/FAQ/Upgrade.md)
   
   -
   
   +## Documents
   
   +[![cn 
doc](https://img.shields.io/badge/document-中文-blue.svg)](README_ZH.md)
   
   +
   
   +  * Getting Started
   
   +* [Quick start](en/Quick-start.md)
   
   +* [Supported middlewares, frameworks and libraries](Supported-list.md)
   
   +  * [How to disable plugins?](en/How-to-disable-plugin.md)
   
   +  * Advanced Features
   
   +* [Override settings through System.properties or 
System.env](en/Setting-override.md)
   
   +* [Direct uplink and disable naming discovery](en/Direct-uplink.md)
   
   +* [Open TLS](en/TLS.md)
   
   +* [Namespace Isolation](en/Namespace.md)
   
   +* [Token Authentication](en/Token-auth.md)
   
   +* [Open Database Sharding Storage](en/Shardingjdbc.md)
   
   This should a section in Incubating Features. named: Use Sharding JDBC as 
storage implementor.
   
   
   
   In 
docs/en/Shardingjdbc.md:
   
   > @@ -0,0 +1,13 @@
   
   +# Supported Database Sharding Storage
   
   +Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
   
   +Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need to import MYSQL Driver manually.
   
   +
   
   +## Supported version
   
   +5.0.0-beta +
   
   +
   
   +## Requirement
   
   +- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to 
collector-libs directory.
   
   collector-libs is not the directory name.
   
   
   
   In 
docs/en/Shardingjdbc.md:
   
   > @@ -0,0 +1,13 @@
   
   +# Supported Database Sharding Storage
   
   +Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
   
   +Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need 

[GitHub] liuwei881 commented on issue #1221: sky walking是否提供python 的api，就是直接通过python调取skywalking的相关信息？

[GitBox]

liuwei881 commented on issue #1221: sky walking是否提供python 
的api，就是直接通过python调取skywalking的相关信息？
URL: 
https://github.com/apache/incubator-skywalking/issues/1221#issuecomment-388707922
 
 
   sky walking是否提供python 的api?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

[GitBox]

chidaodezhongsheng commented on issue #1220: support shardingjdbc database 
storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682
 
 
   @wu-sheng thanks a lot, I will resolve the conflicts and mentions.
   
   技术部·架构部·林嘉琦
   手机：18710075837
   Email：linji...@dangdang.com
   QQ：928926755
   
   发件人: 吴晟 Wu Sheng [mailto:notificati...@github.com]
   发送时间: 2018年5月14日 15:45
   收件人: apache/incubator-skywalking
   抄送: 林嘉琦; Mention
   主题: Re: [apache/incubator-skywalking] support shardingjdbc database storage 
feature (#1220)
   
   
   @wu-sheng commented on this pull request.
   
   @chidaodezhongsheng The 
implementation codes are under incubating. So you will take charge. I just 
reviewed the licenses and documents related things.
   
   Some things need to change.
   
   
   
   In 
apm-collector/apm-collector-boot/src/main/resources/application.yml:
   
   > +contextPath: /
   
   +storage:
   
   +  elasticsearch:
   
   +clusterName: CollectorDBCluster
   
   +clusterTransportSniffer: true
   
   +clusterNodes: localhost:9300
   
   +indexShardsNumber: 2
   
   +indexReplicasNumber: 0
   
   +highPerformanceMode: true
   
   +ttl: 7
   
   +#storage:
   
   +#  h2:
   
   +#url: jdbc:h2:~/memorydb
   
   +#userName: sa
   
   +#storage:
   
   +#  shardingjdbc:
   
   ShardingJDBC is an incubating feature, no use cases yet. And none of the 
contributors are committer yet. So, by that, please don't put Sharding JDBC in 
default application.yml. Even it is under comments.
   
   
   
   In 
apm-dist/release-docs/LICENSE:
   
   > @@ -255,6 +256,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
   
Apache: commons-configuration 1.8: 
https://github.com/apache/commons-configuration, Apache 2.0
   
Apache: commons-io 2.4: https://github.com/apache/commons-io, Apache 2.0
   
Apache: tomcat 8.5.27: https://github.com/apache/tomcat/tree/trunk, 
Apache 2.0
   
   +Apache: groovy 2.4.5-indy: https://github.com/apache/groovy, Apache 2.0
   
   Groovy has a NOTICE file. Please change NOTICE in same folder. And follow 
the file structure. Ref here: 
https://github.com/apache/groovy/blob/master/NOTICE
   
   
   
   In 
docs/README.md:
   
   > -* [Agent or collector version upgrade](en/FAQ/Upgrade.md)
   
   -
   
   +## Documents
   
   +[![cn 
doc](https://img.shields.io/badge/document-中文-blue.svg)](README_ZH.md)
   
   +
   
   +  * Getting Started
   
   +* [Quick start](en/Quick-start.md)
   
   +* [Supported middlewares, frameworks and libraries](Supported-list.md)
   
   +  * [How to disable plugins?](en/How-to-disable-plugin.md)
   
   +  * Advanced Features
   
   +* [Override settings through System.properties or 
System.env](en/Setting-override.md)
   
   +* [Direct uplink and disable naming discovery](en/Direct-uplink.md)
   
   +* [Open TLS](en/TLS.md)
   
   +* [Namespace Isolation](en/Namespace.md)
   
   +* [Token Authentication](en/Token-auth.md)
   
   +* [Open Database Sharding Storage](en/Shardingjdbc.md)
   
   This should a section in Incubating Features. named: Use Sharding JDBC as 
storage implementor.
   
   
   
   In 
docs/en/Shardingjdbc.md:
   
   > @@ -0,0 +1,13 @@
   
   +# Supported Database Sharding Storage
   
   +Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
   
   +Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need to import MYSQL Driver manually.
   
   +
   
   +## Supported version
   
   +5.0.0-beta +
   
   +
   
   +## Requirement
   
   +- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to 
collector-libs directory.
   
   collector-libs is not the directory name.
   
   
   
   In 
docs/en/Shardingjdbc.md:
   
   > @@ -0,0 +1,13 @@
   
   +# Supported Database Sharding Storage
   
   +Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
   
   +Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need 

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

[GitBox]

chidaodezhongsheng commented on issue #1220: support shardingjdbc database 
storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388736637
 
 
   @wu-sheng thanks a lot, I will resolve the conflicts and mentions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

SevenPointOld commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901397
 
 

 ##
 File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md
 ##
 @@ -0,0 +1,2 @@
+###How to use trace ignore plugin
+Please copy the apm-trace-ignore-plugin-x.jar to `agent/plugins`, this plugin 
support reading config from environment variables(The env key must start with 
`skywalking.`, the reuslt should be as same as in 
`apm-trace-ignore-plugin.config`), or you can copy the 
`apm-trace-ignore-plugin.config` to `agent/config` then you'll set you need 
ignore paths in `apm-trace-ignore-plugin.config`
 
 Review comment:
   ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

SevenPointOld commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901335
 
 

 ##
 File path: apm-sniffer/optional-plugins/pom.xml
 ##
 @@ -31,11 +31,15 @@
 net.bytebuddy
 
${shade.package}.${shade.net.bytebuddy.source}
 
-
${project.build.directory}/../../../../skywalking-agent/optional-plugins
+
 
 Review comment:
   I add  `` follow `apm-sdk-plugin/pom`  
   
![image](https://user-images.githubusercontent.com/12181207/39991540-7ab090c4-57a2-11e8-9f71-74d6f527b550.png)
   It's just a statement, the sub pom if need this properties should override 
it,  then act on `${agent.package.dest.dir}`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Rainbowboys opened a new issue #1223: Some doubts about the ui

[GitBox]

Rainbowboys opened a new issue #1223:  Some doubts about the ui
URL: https://github.com/apache/incubator-skywalking/issues/1223
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - Can the trace results of the search be sorted by the time of initiation?
   - When I use TraceId search, the result is a irrelevant result?
   - Span info -log fileds can't adapt to size
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1221: Does SkyWalking support Python API?

[GitBox]

wu-sheng commented on issue #1221: Does SkyWalking support Python API?
URL: 
https://github.com/apache/incubator-skywalking/issues/1221#issuecomment-388710765
 
 
   You could see from the readme. SkyWalking is supporting multiple languages, 
Java, .NET, Nodejs. Go is still ongoing. But you should understand , we didn't 
provide API for each language, the cummunity did.
   
   Such as: Java from several developers, I just lead. @liuhaoyang leads the 
.NET. @ascrutae leads the nodejs. So if you want a python version, you could 
create one, and we can work together.
   
   For multiple languages, SkyWalking provided protocol support: 
   
![image](https://user-images.githubusercontent.com/5441976/39981426-22a32a5a-5783-11e8-9b1e-705279f6669a.png)
   These two protocols should be supported by every language.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858734
 
 

 ##
 File path: docs/en/Shardingjdbc.md
 ##
 @@ -0,0 +1,13 @@
+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need to import MYSQL Driver manually.
+
+## Supported version
+5.0.0-beta +
+
+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to 
collector-libs directory.
 
 Review comment:
   `collector-libs` is not the directory name.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858505
 
 

 ##
 File path: docs/README.md
 ##
 @@ -1,45 +1,46 @@
-## Documents
-[![cn doc](https://img.shields.io/badge/document-中文-blue.svg)](README_ZH.md)
-
-  * Getting Started
-* [Quick start](en/Quick-start.md)
-* [Supported middlewares, frameworks and libraries](Supported-list.md)
-  * [How to disable plugins?](en/How-to-disable-plugin.md)
-  * Advanced Features
-* [Override settings through System.properties or 
System.env](en/Setting-override.md)
-* [Direct uplink and disable naming discovery](en/Direct-uplink.md)
-* [Open TLS](en/TLS.md)
-* [Namespace Isolation](en/Namespace.md)
-* [Token Authentication](en/Token-auth.md)
-  * Incubating Features
-* Abstract
-  * Application Toolkit
-* [Overview](en/Applicaton-toolkit.md)
-* [OpenTracing Tracer](en/Opentracing.md)
-* Logging
-  * [log4j](en/Application-toolkit-log4j-1.x.md)
-  * [log4j2](en/Application-toolkit-log4j-2.x.md)
-  * [logback](en/Application-toolkit-logback-1.x.md)
-* [Trace](en/Application-toolkit-trace.md)
-* [Propagate Context across 
Thread](en/Application-toolkit-trace-cross-thread.md)
-  * Testing
-* [Plugin 
Test](https://github.com/SkywalkingTest/agent-integration-test-report)
-* [Java Agent Performance 
Test](https://skywalkingtest.github.io/Agent-Benchmarks/)
-  * Development Guides
-* [How to build project](en/How-to-build.md)
-* [Plugin development guide](en/Plugin-Development-Guide.md)
-* Protocol
-  * [Cross Process Propagation Headers Protocol, 
v1.0](en/Skywalking-Cross-Process-Propagation-Headers-Protocol-v1.md)
-  * [SkyWalking Trace Data Protocol](en/Trace-Data-Protocol.md)
-* [Release Guide](en/How-to-release.md)
-  * [Roadmap](ROADMAP.md)
-  * Resources provided by community
-* [Public 
speakings](https://github.com/OpenSkywalking/Community#public-speakings)
-* [Videos](https://github.com/OpenSkywalking/Community#videos)
-* [Articles](https://github.com/OpenSkywalking/Community#articles)
-  * FAQ
-* [Why only traces in UI?](en/FAQ/Why-have-traces-no-others.md)
-* [Too many GRPC logs in the console](en/FAQ/Too-many-gRPC-logs.md)
-* [The trace doesn't continue in kafka consumer 
side](en/FAQ/kafka-plugin.md)
-* [Agent or collector version upgrade](en/FAQ/Upgrade.md)
-
+## Documents
+[![cn doc](https://img.shields.io/badge/document-中文-blue.svg)](README_ZH.md)
+
+  * Getting Started
+* [Quick start](en/Quick-start.md)
+* [Supported middlewares, frameworks and libraries](Supported-list.md)
+  * [How to disable plugins?](en/How-to-disable-plugin.md)
+  * Advanced Features
+* [Override settings through System.properties or 
System.env](en/Setting-override.md)
+* [Direct uplink and disable naming discovery](en/Direct-uplink.md)
+* [Open TLS](en/TLS.md)
+* [Namespace Isolation](en/Namespace.md)
+* [Token Authentication](en/Token-auth.md)
+* [Open Database Sharding Storage](en/Shardingjdbc.md)
 
 Review comment:
   This should a section in `Incubating Features`. named: `Use Sharding JDBC as 
storage implementor`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187851353
 
 

 ##
 File path: apm-collector/apm-collector-boot/src/main/resources/application.yml
 ##
 @@ -1,84 +1,90 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-#cluster:
-#  zookeeper:
-#hostPort: localhost:2181
-#sessionTimeout: 10
-naming:
-  jetty:
-host: localhost
-port: 10800
-contextPath: /
-cache:
-#  guava:
-  caffeine:
-remote:
-  gRPC:
-host: localhost
-port: 11800
-agent_gRPC:
-  gRPC:
-host: localhost
-port: 11800
-#Set these two setting to open ssl
-#sslCertChainFile: $path
-#sslPrivateKeyFile: $path
-
-#Set your own token to active auth
-#authentication: xx
-agent_jetty:
-  jetty:
-host: localhost
-port: 12800
-contextPath: /
-analysis_register:
-  default:
-analysis_jvm:
-  default:
-analysis_segment_parser:
-  default:
-bufferFilePath: ../buffer/
-bufferOffsetMaxFileSize: 10M
-bufferSegmentMaxFileSize: 500M
-ui:
-  jetty:
-host: localhost
-port: 12800
-contextPath: /
-storage:
-  elasticsearch:
-clusterName: CollectorDBCluster
-clusterTransportSniffer: true
-clusterNodes: localhost:9300
-indexShardsNumber: 2
-indexReplicasNumber: 0
-highPerformanceMode: true
-ttl: 7
-#storage:
-#  h2:
-#url: jdbc:h2:~/memorydb
-#userName: sa
-configuration:
-  default:
-# namespace: x
-applicationApdexThreshold: 2000
-serviceErrorRateThreshold: 10.00
-serviceAverageResponseTimeThreshold: 2000
-instanceErrorRateThreshold: 10.00
-instanceAverageResponseTimeThreshold: 2000
-applicationErrorRateThreshold: 10.00
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#cluster:
+#  zookeeper:
+#hostPort: localhost:2181
+#sessionTimeout: 10
+naming:
+  jetty:
+host: localhost
+port: 10800
+contextPath: /
+cache:
+#  guava:
+  caffeine:
+remote:
+  gRPC:
+host: localhost
+port: 11800
+agent_gRPC:
+  gRPC:
+host: localhost
+port: 11800
+#Set these two setting to open ssl
+#sslCertChainFile: $path
+#sslPrivateKeyFile: $path
+
+#Set your own token to active auth
+#authentication: xx
+agent_jetty:
+  jetty:
+host: localhost
+port: 12800
+contextPath: /
+analysis_register:
+  default:
+analysis_jvm:
+  default:
+analysis_segment_parser:
+  default:
+bufferFilePath: ../buffer/
+bufferOffsetMaxFileSize: 10M
+bufferSegmentMaxFileSize: 500M
+ui:
+  jetty:
+host: localhost
+port: 12800
+contextPath: /
+storage:
+  elasticsearch:
+clusterName: CollectorDBCluster
+clusterTransportSniffer: true
+clusterNodes: localhost:9300
+indexShardsNumber: 2
+indexReplicasNumber: 0
+highPerformanceMode: true
+ttl: 7
+#storage:
+#  h2:
+#url: jdbc:h2:~/memorydb
+#userName: sa
+#storage:
+#  shardingjdbc:
 
 Review comment:
   ShardingJDBC is an incubating feature, no use cases yet. And none of the 
contributors are committer yet. So, by that, please don't put Sharding JDBC in 
default application.yml. Even it is under comments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this 

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858208
 
 

 ##
 File path: apm-dist/release-docs/LICENSE
 ##
 @@ -255,6 +256,7 @@ The text of each license is also included at 
licenses/LICENSE-[project].txt.
 Apache: commons-configuration 1.8: 
https://github.com/apache/commons-configuration, Apache 2.0
 Apache: commons-io 2.4: https://github.com/apache/commons-io, Apache 2.0
 Apache: tomcat 8.5.27: https://github.com/apache/tomcat/tree/trunk, Apache 
2.0
+Apache: groovy 2.4.5-indy: https://github.com/apache/groovy, Apache 2.0
 
 Review comment:
   Groovy has a NOTICE file. Please change NOTICE in same folder. And follow 
the file structure. Ref here: 
https://github.com/apache/groovy/blob/master/NOTICE


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858863
 
 

 ##
 File path: docs/en/Shardingjdbc.md
 ##
 @@ -0,0 +1,13 @@
+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need to import MYSQL Driver manually.
+
+## Supported version
+5.0.0-beta +
+
+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to 
collector-libs directory.
+- In config/application.yml, close the elasticsearch configuration and open 
the shardingjdbc configuration, multiple data source configurations should be 
separated by Half Comma.
 
 Review comment:
   Considering the sharding settings have been remove from application.yml. 
please add the settings in here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898156
 
 

 ##
 File path: docs/README_ZH.md
 ##
 @@ -1,42 +1,46 @@
-## 中文文档
-[![EN doc](https://img.shields.io/badge/document-English-blue.svg)](README.md)
-
-  * 快速入门
-* [快速入门](cn/Quick-start-CN.md)
-* [中间件，框架与类库支持列表](Supported-list.md)
-* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md)
-  * 高级特性
-* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md)
-* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md)
-* [开启TLS](cn/TLS-CN.md)
-* [命名空间隔离](cn/Namespace-CN.md)
-* [基于Token认证](cn/Token-auth-CN.md)
-  * APM相关介绍资料
-* 
[OpenTracing中文版](https://github.com/opentracing-contrib/opentracing-specification-zh)
-  * Application Toolkit，应用程序工具包
-* [概述](cn/Application-toolkit-CN.md)
-* [OpenTracing Tracer](cn/Opentracing-CN.md)
-* 日志组件
-  * [log4j组件](cn/Application-toolkit-log4j-1.x-CN.md)
-  * [log4j2组件](cn/Application-toolkit-log4j-2.x-CN.md)
-  * [logback组件](cn/Application-toolkit-logback-1.x-CN.md)
-* [Trace](cn/Application-toolkit-trace-CN.md)
-* [调用链跨线程传递](cn/Application-toolkit-trace-cross-thread-CN.md) 
-  * 测试用例
-* [插件测试](https://github.com/SkywalkingTest/agent-integration-test-report)
-* [Java 
探针性能测试](https://skywalkingtest.github.io/Agent-Benchmarks/README_zh.html)
-  * 开发指南
-* [工程编译指南](cn/How-to-build-CN.md)
-* [插件开发指南](cn/Plugin-Development-Guide-CN.md)
-* 交互协议
-* [Cross Process Propagation Headers Protocol, v1.0  
跨进程追踪上下文传递协议](cn/Skywalking-Cross-Process-Propagation-Headers-Protocol-CN-v1.md)
-* [SkyWalking Trace Data Protocol 
探针与Collector间网络协议](cn/Trace-Data-Protocol-CN.md)
-  * [Roadmap](ROADMAP.md)
-  * 社区提供的共享资源
-* [公开演讲](https://github.com/OpenSkywalking/Community#public-speakings)
-* [视频](https://github.com/OpenSkywalking/Community#videos)
-* [文章](https://github.com/OpenSkywalking/Community#articles)
-  * FAQ
-* [Trace查询有数据，但是没有拓扑图和JVM数据?](cn/FAQ/Why-have-traces-no-others-CN.md)
-* [加载探针，Console被GRPC日志刷屏](cn/FAQ/Too-many-gRPC-logs-CN.md)
-* [Kafka消息消费端链路断裂](cn/FAQ/Kafka-plugin-CN.md)
+## 中文文档
+[![EN doc](https://img.shields.io/badge/document-English-blue.svg)](README.md)
+
+  * 快速入门
+* [快速入门](cn/Quick-start-CN.md)
+* [中间件，框架与类库支持列表](Supported-list.md)
+* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md)
+* [可选插件](cn/Optional-plugins-CN.md)
+  * 高级特性
+* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md)
+* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md)
+* [开启TLS](cn/TLS-CN.md)
+* [命名空间隔离](cn/Namespace-CN.md)
+* [基于Token认证](cn/Token-auth-CN.md)
+* [使用Shardingjdbc作为存储实现](cn/Shardingjdbc-CN.md)
 
 Review comment:
   In CN doc, also need an `孵化功能` section.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898936
 
 

 ##
 File path: docs/en/Shardingjdbc.md
 ##
 @@ -0,0 +1,21 @@
+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need to import MYSQL Driver manually.
+
+## Supported version
+5.0.0-beta +
 
 Review comment:
   beta2? beta is under release process now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899581
 
 

 ##
 File path: docs/README_ZH.md
 ##
 @@ -1,42 +1,46 @@
-## 中文文档
-[![EN doc](https://img.shields.io/badge/document-English-blue.svg)](README.md)
-
-  * 快速入门
-* [快速入门](cn/Quick-start-CN.md)
-* [中间件，框架与类库支持列表](Supported-list.md)
-* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md)
-  * 高级特性
-* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md)
-* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md)
-* [开启TLS](cn/TLS-CN.md)
-* [命名空间隔离](cn/Namespace-CN.md)
-* [基于Token认证](cn/Token-auth-CN.md)
-  * APM相关介绍资料
-* 
[OpenTracing中文版](https://github.com/opentracing-contrib/opentracing-specification-zh)
-  * Application Toolkit，应用程序工具包
-* [概述](cn/Application-toolkit-CN.md)
-* [OpenTracing Tracer](cn/Opentracing-CN.md)
-* 日志组件
-  * [log4j组件](cn/Application-toolkit-log4j-1.x-CN.md)
-  * [log4j2组件](cn/Application-toolkit-log4j-2.x-CN.md)
-  * [logback组件](cn/Application-toolkit-logback-1.x-CN.md)
-* [Trace](cn/Application-toolkit-trace-CN.md)
-* [调用链跨线程传递](cn/Application-toolkit-trace-cross-thread-CN.md) 
-  * 测试用例
-* [插件测试](https://github.com/SkywalkingTest/agent-integration-test-report)
-* [Java 
探针性能测试](https://skywalkingtest.github.io/Agent-Benchmarks/README_zh.html)
-  * 开发指南
-* [工程编译指南](cn/How-to-build-CN.md)
-* [插件开发指南](cn/Plugin-Development-Guide-CN.md)
-* 交互协议
-* [Cross Process Propagation Headers Protocol, v1.0  
跨进程追踪上下文传递协议](cn/Skywalking-Cross-Process-Propagation-Headers-Protocol-CN-v1.md)
-* [SkyWalking Trace Data Protocol 
探针与Collector间网络协议](cn/Trace-Data-Protocol-CN.md)
-  * [Roadmap](ROADMAP.md)
-  * 社区提供的共享资源
-* [公开演讲](https://github.com/OpenSkywalking/Community#public-speakings)
-* [视频](https://github.com/OpenSkywalking/Community#videos)
-* [文章](https://github.com/OpenSkywalking/Community#articles)
-  * FAQ
-* [Trace查询有数据，但是没有拓扑图和JVM数据?](cn/FAQ/Why-have-traces-no-others-CN.md)
-* [加载探针，Console被GRPC日志刷屏](cn/FAQ/Too-many-gRPC-logs-CN.md)
-* [Kafka消息消费端链路断裂](cn/FAQ/Kafka-plugin-CN.md)
+## 中文文档
+[![EN doc](https://img.shields.io/badge/document-English-blue.svg)](README.md)
+
+  * 快速入门
+* [快速入门](cn/Quick-start-CN.md)
+* [中间件，框架与类库支持列表](Supported-list.md)
+* [如何关闭特定插件](cn/How-to-disable-plugin-CN.md)
+* [可选插件](cn/Optional-plugins-CN.md)
+  * 高级特性
+* [通过系统启动参数进行覆盖配置](cn/Setting-override-CN.md)
+* [服务直连(Direct uplink)及禁用名称服务(naming service)](cn/Direct-uplink-CN.md)
+* [开启TLS](cn/TLS-CN.md)
+* [命名空间隔离](cn/Namespace-CN.md)
+* [基于Token认证](cn/Token-auth-CN.md)
+* [使用Shardingjdbc作为存储实现](cn/Shardingjdbc-CN.md)
 
 Review comment:
   File name should not be shardingJDBC.  Should be: 
Use-ShardingJDBC-as-storage-implementor.md


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

coveralls commented on issue #1213: provides a optional-plugin for tracking 
ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16964148/badge)](https://coveralls.io/builds/16964148)
   
   Coverage increased (+0.4%) to 23.788% when pulling 
**18790363b3ba50738ea3e577b63506fce16a4e77 on SevenPointOld:master** into 
**1bbd5e1c28afed0784834978cdba33d074a536a1 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169
 
 
   @wu-sheng  It based my local machine. I installed sofarpc 5.4.0 to my local 
m2 repo
   
   I tested it like this.
   
   env settings
   ```
   export project_name=sofarpc-scenario
   export agent_repository_branch=sofarpc-integration
   export 
agent_repository_url=https://github.com/leizhiyuan/incubator-skywalking.git
   export testcase_branch=sofarpc-testcase-scenario
   ```
   test command
   ```
sh deploy-test.sh \
   -p ${project_name} \
   -b ${agent_repository_branch} \
   -r ${agent_repository_url} \
   -tcb ${testcase_branch}
   ```
   
   after run this ,It asks me private password of github to publish reports . I 
can not access master branch 
('https://github.com/SkywalkingTest/agent-integration-test-report.git/'),so I 
copied it there


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169
 
 
   @wu-sheng  It based my local machine. I installed sofarpc 5.4.0 to my local 
m2 repo
   
   I tested it like this.
   
   env settings
   ```
   export project_name=sofarpc-scenario
   export agent_repository_branch=sofarpc-integration
   export 
agent_repository_url=https://github.com/leizhiyuan/incubator-skywalking.git
   export testcase_branch=sofarpc-testcase-scenario
   ```
   test command
   ```
sh deploy-test.sh \
   -p ${project_name} \
   -b ${agent_repository_branch} \
   -r ${agent_repository_url} \
   -tcb ${testcase_branch}
   ```
   
   after run this ,It asks me private password of github to publish reports . I 
can not access master branch ,so I copied it there


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169
 
 
   @wu-sheng  It based my local machine. I installed sofarpc 5.4.0 to my local 
m2 repo
   
   I tested it like this.
   
   env settings
   ```
   export project_name=sofarpc-scenario
   export agent_repository_branch=sofarpc-integration
   export 
agent_repository_url=https://github.com/leizhiyuan/incubator-skywalking.git
   export testcase_branch=sofarpc-testcase-scenario
   ```
   test command
   ```
sh deploy-test.sh \
   -p ${project_name} \
   -b ${agent_repository_branch} \
   -r ${agent_repository_url} \
   -tcb ${testcase_branch}
   ```
   
   after run this ,It asks me private password of github to publish reports . I 
can not access master branch 
('https://github.com/SkywalkingTest/agent-integration-test-report.git/'),so I 
copied it there to inform you


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388747564
 
 
   When we release sofarpc 5.4.0 I will provide a new test report


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

wu-sheng commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879656
 
 

 ##
 File path: 
apm-sniffer/optional-plugins/optional-spring-plugins/spring-annotation-plugin/pom.xml
 ##
 @@ -28,6 +28,10 @@
 
 apm-spring-annotation-plugin
 
+
+UTF-8
+/..
 
 Review comment:
   This could be the default in `optional-plugins/pom.xml`, which will make 
people easier to understand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

wu-sheng commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187881241
 
 

 ##
 File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md
 ##
 @@ -0,0 +1,2 @@
+###How to use trace ignore plugin
+Please copy the apm-trace-ignore-plugin-x.jar to `agent/plugins`, this plugin 
support reading config from environment variables(The env key must start with 
`skywalking.`, the reuslt should be as same as in 
`apm-trace-ignore-plugin.config`), or you can copy the 
`apm-trace-ignore-plugin.config` to `agent/config` then you'll set you need 
ignore paths in `apm-trace-ignore-plugin.config`
 
 Review comment:
   See here: 
https://github.com/SevenPointOld/incubator-skywalking/blob/18790363b3ba50738ea3e577b63506fce16a4e77/apm-sniffer/optional-plugins/trace-ignore-plugin/README.md
   
   Your markdown don't look good. Please provide sections about two usages.
   ```
   # title
   Abstrct
   
   ## Usage
   1. .. use config file.
   2. .. through env, and examples
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

wu-sheng commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879700
 
 

 ##
 File path: apm-sniffer/optional-plugins/pom.xml
 ##
 @@ -31,11 +31,15 @@
 net.bytebuddy
 
${shade.package}.${shade.net.bytebuddy.source}
 
-
${project.build.directory}/../../../../skywalking-agent/optional-plugins
+
 
 Review comment:
   Set default value


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

wu-sheng commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187883147
 
 

 ##
 File path: apm-sniffer/optional-plugins/trace-ignore-plugin/pom.xml
 ##
 @@ -0,0 +1,78 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+optional-plugins
+org.apache.skywalking
+5.0.0-beta-SNAPSHOT
+
+4.0.0
+
+apm-trace-ignore-plugin
+jar
+
+apm-trace-ignore-plugin
+http://maven.apache.org
+
+
+
+
+
+org.apache.maven.plugins
+maven-antrun-plugin
+
+
+package
+
+run
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ant-contrib
+ant-contrib
+1.0b3
+
+
+ant
+ant
+
+
+
+
+org.apache.ant
+ant-nodeps
+1.8.1
+
 
 Review comment:
   Would these two will in your optional jar? Could you provide a screenshot to 
show me what are in it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899006
 
 

 ##
 File path: docs/en/Shardingjdbc.md
 ##
 @@ -0,0 +1,21 @@
+# Supported Database Sharding Storage
+Beside the default Elasticsearch storage, it also support the database 
sharding storage, it allow the users to store data in multiple databases.
+Note: it only supported MYSQL database sharding, and due to the license 
restrictions, the users need to import MYSQL Driver manually.
+
+## Supported version
+5.0.0-beta +
+
+## Requirement
+- Manually import MySQL Driver package mysql-connector-java-5.1.36.jar to 
collector libs directory.
+- In config/application.yml, close the elasticsearch configuration and open 
the shardingjdbc configuration, multiple data source configurations should be 
separated by Half Comma.
+``` javascript
 
 Review comment:
   It is a yml, not a javascript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898905
 
 

 ##
 File path: docs/cn/Shardingjdbc-CN.md
 ##
 @@ -0,0 +1,21 @@
+# 支持数据库分片存储
+除了默认的Elasticsearch存储外，还支持数据库分片存储，允许用户将数据存储在多个数据库中。
+注意：目前仅支持MYSQL数据库的分片存储，且由于license限制，需要用户手动引入mysql驱动包。
+
+## 版本支持
+5.0.0-beta +
 
 Review comment:
   beta2? beta is under release process now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on a change in pull request #1220: support shardingjdbc 
database storage feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899019
 
 

 ##
 File path: docs/cn/Shardingjdbc-CN.md
 ##
 @@ -0,0 +1,21 @@
+# 支持数据库分片存储
+除了默认的Elasticsearch存储外，还支持数据库分片存储，允许用户将数据存储在多个数据库中。
+注意：目前仅支持MYSQL数据库的分片存储，且由于license限制，需要用户手动引入mysql驱动包。
+
+## 版本支持
+5.0.0-beta +
+
+## 配置要求
+- 手工导入MYSQL的驱动包mysql-connector-java-5.1.36.jar到collector libs目录下。
+- config/application.yml中，关闭elasticsearch配置，打开shardingjdbc配置，多个数据源配置用半角逗号隔开。
+``` javascript
 
 Review comment:
   It is a yml, not a javascript.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liuwei881 opened a new issue #1221: sky walking是否提供python 的api，就是直接通过python调取skywalking的相关信息？

[GitBox]

liuwei881 opened a new issue #1221: sky walking是否提供python 
的api，就是直接通过python调取skywalking的相关信息？
URL: https://github.com/apache/incubator-skywalking/issues/1221
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, 
component version.
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

wu-sheng commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388745138
 
 
   @leizhiyuan Ping us when you are ready (after release). 
   
   And I have to ask, where does 
https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/17#issuecomment-388741798
 base? I guess 5.4.0 is not released, yet.  FYI @ascrutae 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388742185
 
 
   @wu-sheng  I have tested it, It seems everything is ok,
   
https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/17#issuecomment-388741798
   
   we will publish sofarpc 5.4.0 soon ,then I will update this issue, and this 
pr can be merged.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dinggel opened a new issue #1222: How do I package the master branch code?

[GitBox]

dinggel opened a new issue #1222: How do I package the master branch code?
URL: https://github.com/apache/incubator-skywalking/issues/1222
 
 
   I want to use the latest version of incubator-skywalking-ui,i have some 
problems when i run the master branch code of incubator-skywalking-ui with the 
5.0.0-alpha of incubator-skywalking


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

[GitBox]

wu-sheng commented on issue #1220: support shardingjdbc database storage 
feature 
URL: 
https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388715549
 
 
   @chidaodezhongsheng Conflicts must be resolved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187961412
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   No, the id must unique


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

SevenPointOld commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187903231
 
 

 ##
 File path: 
apm-sniffer/optional-plugins/optional-spring-plugins/spring-annotation-plugin/pom.xml
 ##
 @@ -28,6 +28,10 @@
 
 apm-spring-annotation-plugin
 
+
+UTF-8
+/..
 
 Review comment:
   I think the `sdk.plugin.related.dir`  should in `optional-plugins/pom.xml`, 
because it needs to cover the path of the copy


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liliang8858 opened a new issue #1226: Exception while executing runnable

[GitBox]

liliang8858 opened a new issue #1226: Exception while executing runnable 
URL: https://github.com/apache/incubator-skywalking/issues/1226
 
 
   - Why do you submit this issue?
   - [0] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   Exception while executing runnable 
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   5.0.0
   - Which company or project?
   collector
   
   - What happen?
   spring boot - > 11800 
   SEVERE: Exception while executing runnable 
io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed@1667dc5
   java.lang.NullPointerException
   at 
org.apache.skywalking.apm.collector.storage.es.dao.cache.ApplicationEsCacheDAO.getApplicationIdByCode(ApplicationEsCacheDAO.java:66)
   at 
org.apache.skywalking.apm.collector.cache.caffeine.service.ApplicationCacheCaffeineService.getApplicationIdByCode(ApplicationCacheCaffeineService.java:69)
   at 
org.apache.skywalking.apm.collector.analysis.register.provider.service.ApplicationIDService.getOrCreateForApplicationCode(ApplicationIDService.java:71)
   at 
org.apache.skywalking.apm.collector.agent.grpc.provider.handler.ApplicationRegisterServiceHandler.applicationCodeRegister(ApplicationRegisterServiceHandler.java:52)
   at 
org.apache.skywalking.apm.network.proto.ApplicationRegisterServiceGrpc$MethodHandlers.invoke(ApplicationRegisterServiceGrpc.java:225)
   at 
io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:171)
   at 
io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:272)
   at 
io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:653)
   at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
   at 
io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
   at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   at java.lang.Thread.run(Thread.java:748)
   
   
   spring boot + dubbo + zookeeper   
   skywalking
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1219: bug: the agent file path with blank space in windows server would report an error

[GitBox]

wu-sheng commented on issue #1219: bug: the agent file path with blank space in 
windows server would report an error
URL: 
https://github.com/apache/incubator-skywalking/issues/1219#issuecomment-388804792
 
 
   Maybe you can debug on your env? Try to find what happens, and send a pull 
request?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187959970
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   the id isn't equals `ComponentsDefine` define's.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187959970
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   the id isn't equals `ComponentsDefine` define's


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187961811
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   @ascrutae It is test file ,seems no one use It, I will remove this line


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tangmingming closed issue #1224: agent启动报错

[GitBox]

tangmingming closed issue #1224: agent启动报错
URL: https://github.com/apache/incubator-skywalking/issues/1224
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tangmingming commented on issue #1224: agent启动报错

[GitBox]

tangmingming commented on issue #1224: agent启动报错
URL: 
https://github.com/apache/incubator-skywalking/issues/1224#issuecomment-388776203
 
 
   是我服务端application.yml 配置有问题  改成本机IP（10.111.80.226）就好了
   
   naming:
 jetty:
   host: 0.0.0.0
   port: 10800
   context_path: /
   remote:
 gRPC:
   host: 10.111.80.226
   port: 11800
   agent_gRPC:
 gRPC:
   host: 10.111.80.226
   port: 11800
   agent_jetty:
 jetty:
   host: 10.111.80.226
   port: 12800
   context_path: /
   analysis_register:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

SevenPointOld commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187911271
 
 

 ##
 File path: apm-sniffer/optional-plugins/pom.xml
 ##
 @@ -98,11 +102,22 @@
 
 
 
+
 
 
 
-
-
+
+
 
 Review comment:
   Well, I think the meaning of this plugin may be somewhat confusing,
   One is to integrate other components to achieve link tracking.
   The other is to extend SPI's own behavior.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liliang8858 commented on issue #1226: Exception while executing runnable

[GitBox]

liliang8858 commented on issue #1226: Exception while executing runnable 
URL: 
https://github.com/apache/incubator-skywalking/issues/1226#issuecomment-388794743
 
 
   There is no GRPC   
   Must the GRPC be started?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new pull request #1227: Update README.md

[GitBox]

wu-sheng opened a new pull request #1227: Update README.md
URL: https://github.com/apache/incubator-skywalking/pull/1227
 
 
   Miss a word in readme.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187960804
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   @ascrutae I found  that test  component-libraries.yml 
   
   Jedis has used 30 ,cloud I use 30 too?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187963546
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   @ascrutae They are all 30, only In test's component-libraries.yml ,I can not 
set it to 30, because jedis used It


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187965357
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   all production code ,I need to set it as 30. last plugin is 29. I removed 
test settings, I did not use it in test project


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1225: 5.0 configuration issues.

[GitBox]

wu-sheng commented on issue #1225: 5.0 configuration issues.
URL: 
https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388774678
 
 
   Cluster and remote deploy need your real IPs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

coveralls commented on issue #1213: provides a optional-plugin for tracking 
ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16967701/badge)](https://coveralls.io/builds/16967701)
   
   Coverage increased (+0.4%) to 23.788% when pulling 
**8ce9a84ffca8c04e526015b85e620bb7cd779cf0 on SevenPointOld:master** into 
**1bbd5e1c28afed0784834978cdba33d074a536a1 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

SevenPointOld commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187902459
 
 

 ##
 File path: apm-sniffer/optional-plugins/pom.xml
 ##
 @@ -31,11 +31,15 @@
 net.bytebuddy
 
${shade.package}.${shade.net.bytebuddy.source}
 
-
${project.build.directory}/../../../../skywalking-agent/optional-plugins
+
+
${project.build.directory}${sdk.plugin.related.dir}/../../../../skywalking-agent
+
${agent.package.dest.dir}/optional-plugins
+apm-trace-ignore-plugin
 
 Review comment:
   What's the better way to do that,  I need to determine which plugins are 
folders


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1223: Some doubts about the ui

[GitBox]

wu-sheng commented on issue #1223:  Some doubts about the ui
URL: 
https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-388775681
 
 
   - Sort will optimize in beta.
   - Please provide more details.
   - log can be changed. @hanahmily


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1227: Update README.md

[GitBox]

coveralls commented on issue #1227: Update README.md
URL: 
https://github.com/apache/incubator-skywalking/pull/1227#issuecomment-388814704
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16969049/badge)](https://coveralls.io/builds/16969049)
   
   Coverage increased (+0.004%) to 23.361% when pulling 
**d2f4eb4b12937f892ad7b195ee594ca5036cf8e9 on wu-sheng-patch-1** into 
**1bbd5e1c28afed0784834978cdba33d074a536a1 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187964503
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   You can set the value to `32`, because the value define in 
`component-libraries.yml` is `32`. and more you also should change length of 
`components` filed to `33`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962668
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   Sorry，I mean the value that it define in `component-libraries.yml`file isn't 
equals the value define in `ComponentsDefine.java` file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962693
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   I mean the value that it define in `component-libraries.yml`file isn't 
equals the value define in `ComponentsDefine.java` file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962693
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   the value that it define in `component-libraries.yml`file isn't equals the 
value define in `ComponentsDefine.java` file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liliang8858 closed issue #1226: Exception while executing runnable

[GitBox]

liliang8858 closed issue #1226: Exception while executing runnable 
URL: https://github.com/apache/incubator-skywalking/issues/1226
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #1225: 5.0 configuration issues.

[GitBox]

wu-sheng closed issue #1225: 5.0 configuration issues.
URL: https://github.com/apache/incubator-skywalking/issues/1225
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wfs0902 commented on issue #1225: 5.0 configuration issues.

[GitBox]

wfs0902 commented on issue #1225: 5.0 configuration issues.
URL: 
https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388770134
 
 
   The 5.0 operation document is not updated accordingly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187962668
 
 

 ##
 File path: 
apm-collector/apm-collector-configuration/collector-configuration-provider/src/test/resources/component-libraries.yml
 ##
 @@ -124,6 +124,9 @@ Hystrix:
 Jedis:
   id: 30
   languages: Java
+SOFARPC:
+  id: 31
 
 Review comment:
   Sorry, it's my fault. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1225: 5.0 configuration issues.

[GitBox]

wu-sheng commented on issue #1225: 5.0 configuration issues.
URL: 
https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388770896
 
 
   Yes, need a 0.0.0.0 by default. Please send a pr to fix. But beta is under 
release, can't change at this momeny, considering this is a critical issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on issue #1210: Add sofa rpc plugin integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388835222
 
 
   @ascrutae  I have changed sofarpc componentId to be 32


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ascrutae commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

ascrutae commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187968284
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   The component id must equals the `ComponentsDefine.java` defined's, or the 
component in topology will incorrect


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin integration

[GitBox]

leizhiyuan commented on a change in pull request #1210: Add sofa rpc plugin 
integration
URL: 
https://github.com/apache/incubator-skywalking/pull/1210#discussion_r187970209
 
 

 ##
 File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
 ##
 @@ -84,6 +84,8 @@
 
 public static final OfficialComponent HYSTRIX =  new OfficialComponent(29, 
"Hystrix");
 
+public static final OfficialComponent SOFARPC =  new OfficialComponent(30, 
"SOFARPC");
 
 Review comment:
   @ascrutae Ok,I will set it 32, SQLite(31) is wrong before? It has no 
defination in 
   ComponentsDefine


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed pull request #1227: Update README.md

[GitBox]

wu-sheng closed pull request #1227: Update README.md
URL: https://github.com/apache/incubator-skywalking/pull/1227
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wfs0902 commented on issue #1225: 5.0 configuration issues.

[GitBox]

wfs0902 commented on issue #1225: 5.0 configuration issues.
URL: 
https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-388773568
 
 
   Thanks very much for your quick reply,In cluster mode, the IP that all nodes 
publish is 0.0.0.0, which affects the service load?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wfs0902 commented on issue #1225: 5.0 configuration issues.

[GitBox]

wfs0902 commented on issue #1225: 5.0 configuration issues.
URL: 
https://github.com/apache/incubator-skywalking/issues/1225#issuecomment-389006126
 
 
   Remote use real IP,There is an error,the following
   "DEBUG 2018-05-15 08:36:36 DiscoveryRestServiceClient :  GRPC server list 
remain unchanged: [0.0.0.0:11800] 
   ERROR 2018-05-15 08:36:37 AppAndServiceRegisterClient :  
AppAndServiceRegisterClient execute fail. 
   org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: 
UNAVAILABLE"
   
"org.apache.skywalking.apm.dependencies.io.netty.channel.AbstractChannel$AnnotatedConnectException:
 Connection refused: no further information: 0.0.0.0/0.0.0.0:11800"


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Rainbowboys commented on issue #1223: Some doubts about the ui

[GitBox]

Rainbowboys commented on issue #1223:  Some doubts about the ui
URL: 
https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-389014918
 
 
   ok thanks ! There are some questions ,I know use apm-toolkit-opentracing set 
up Log and tags,But i when i use apm-toolkit-trace,find it only for tag ,it 
mean want to set up log ,i must use opentracing?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1228: bug:remote agent.config use real collector IP that happens connection exception

[GitBox]

wu-sheng commented on issue #1228: bug:remote agent.config use real collector 
IP  that happens connection exception
URL: 
https://github.com/apache/incubator-skywalking/issues/1228#issuecomment-389024283
 
 
   All IPs exception UI/Jetty, need to be changed into real IPs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng closed issue #1228: bug:remote agent.config use real collector IP that happens connection exception

[GitBox]

wu-sheng closed issue #1228: bug:remote agent.config use real collector IP  
that happens connection exception
URL: https://github.com/apache/incubator-skywalking/issues/1228
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

wu-sheng commented on a change in pull request #1213: provides a 
optional-plugin for tracking ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#discussion_r188153469
 
 

 ##
 File path: apm-sniffer/optional-plugins/pom.xml
 ##
 @@ -98,11 +102,22 @@
 
 
 
+
 
 
 
-
-
+
+
 
 Review comment:
   I am not following. I just have concerns about this pom. Too many your 
plugin details expose to root pom.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wfs0902 opened a new issue #1228: bug:remote agent.config use real collector IP that happens connection exception

[GitBox]

wfs0902 opened a new issue #1228: bug:remote agent.config use real collector IP 
 that happens connection exception
URL: https://github.com/apache/incubator-skywalking/issues/1228
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   collector's application.yml is the following,
   **naming:
 jetty:
   host: 0.0.0.0
   port: 10800
   context_path: /
   remote:
 gRPC:
   host: 0.0.0.0
   port: 11800
   agent_gRPC:
 gRPC:
   host: 0.0.0.0
   port: 11800
   agent_jetty:
 jetty:
   host: 0.0.0.0
   port: 12800
   context_path: /
   analysis_register:
 default:
   analysis_jvm:
 default:
   analysis_segment_parser:
 default:
   buffer_file_path: ../buffer/
   buffer_offset_max_file_size: 10M
   buffer_segment_max_file_size: 500M
   ui:
 jetty:
   host: 0.0.0.0
   port: 12800
   context_path: /
   storage:
 elasticsearch:
   cluster_name: CollectorDBCluster
   cluster_transport_sniffer: true
   cluster_nodes: 192.168.6.71:9300**
   Remote tomcat'agent use real IP,
  **collector.servers=192.168.6.71:10800**
   There is an error,the following
   "DEBUG 2018-05-15 08:36:36 DiscoveryRestServiceClient : GRPC server list 
remain unchanged: [0.0.0.0:11800]
   ERROR 2018-05-15 08:36:37 AppAndServiceRegisterClient : 
AppAndServiceRegisterClient execute fail.
   org.apache.skywalking.apm.dependencies.io.grpc.StatusRuntimeException: 
UNAVAILABLE"
   
"org.apache.skywalking.apm.dependencies.io.netty.channel.AbstractChannel$AnnotatedConnectException:
 Connection refused: no further information: 0.0.0.0/0.0.0.0:11800"
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, 
component version.
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wfs0902 commented on issue #1228: bug:remote agent.config use real collector IP that happens connection exception

[GitBox]

wfs0902 commented on issue #1228: bug:remote agent.config use real collector IP 
 that happens connection exception
URL: 
https://github.com/apache/incubator-skywalking/issues/1228#issuecomment-389022369
 
 
   Configure as you say.In collector application.yml,
   ips use 0.0.0.0 ,remote agent connect exception access to collector,
   The execption is "no further information: 0.0.0.0/0.0.0.0:11800";


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

[GitBox]

coveralls commented on issue #1213: provides a optional-plugin for tracking 
ignores enhancement(#1203)
URL: 
https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16982331/badge)](https://coveralls.io/builds/16982331)
   
   Coverage increased (+0.4%) to 23.788% when pulling 
**cf0182e2422ccb509c5056ba7a49e4de0dcadeac on SevenPointOld:master** into 
**4a20c288482552cc0b78d759fe6fba66f335da82 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #1223: Some doubts about the ui

[GitBox]

wu-sheng commented on issue #1223:  Some doubts about the ui
URL: 
https://github.com/apache/incubator-skywalking/issues/1223#issuecomment-389024734
 
 
   The internal toolkit is only for tag, now. You can send pull request to 
support log, if you want.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services