[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321411719 ## File path: superset/common/query_object.py ## @@ -72,15 +89,15 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321414429 ## File path: superset/connectors/druid/models.py ## @@ -952,12 +970,14

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321412898 ## File path: superset/connectors/base/models.py ## @@ -239,47 +239,47

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321411207 ## File path: superset/common/query_context.py ## @@ -109,36 +114,36 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321413253 ## File path: superset/connectors/druid/models.py ## @@ -24,13 +24,15

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321414007 ## File path: superset/connectors/druid/models.py ## @@ -146,53 +151,53

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319226410 ## File path: superset/common/query_context.py ## @@ -150,8 +155,8 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319220516 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r31377 ## File path: superset/common/query_context.py ## @@ -40,8 +42,13 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r318889219 ## File path: superset/connectors/base/models.py ## @@ -60,8 +60,8 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r318889509 ## File path: superset/connectors/base/models.py ## @@ -79,68 +79,68 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r318889318 ## File path: superset/connectors/base/models.py ## @@ -79,68 +79,68 @@

[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r31597 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@