ams-tschoening commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583837151
So let's close #12 and really focus on this one, replacing things in favour
of CMAKE instead of adding it? I don't use the ANT-build myself
turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##
turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##
ams-tschoening commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583884452
@stephen-webb Does `socketservertestcase` succeed for your? I get the
following error messages for two tests which use the `%C` format flag in
Ralph Goers created LOG4J2-2777:
---
Summary: Add retryCount attribute to KafkaAppender
Key: LOG4J2-2777
URL: https://issues.apache.org/jira/browse/LOG4J2-2777
Project: Log4j 2
Issue Type:
rgoers merged pull request #319: log4j-kafka added with "retryCount" function
URL: https://github.com/apache/logging-log4j2/pull/319
This is an automated message from the Apache Git Service.
To respond to the message, please
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376811760
##
File path: src/site/apt/building/vcpkg.apt
##
@@ -0,0 +1,41 @@
+~~ Licensed to the Apache Software
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376811526
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,104 @@
+~~ Licensed to the Apache Software
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376809913
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,104 @@
+~~ Licensed to the Apache Software
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376805122
##
File path: src/test/java/CMakeLists.txt
##
@@ -0,0 +1,18 @@
+include(FetchContent)
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376805933
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376803532
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376806130
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376808023
##
File path: src/test/cpp/net/socketservertestcase.cpp
##
@@ -478,4 +477,4 @@
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376807031
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/LOG4J2-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033285#comment-17033285
]
ASF subversion and git services commented on LOG4J2-2777:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033240#comment-17033240
]
Volkan Yazici commented on LOG4J2-2703:
---
[~rgoers] , yes, I can give it a try. It is actually
[
https://issues.apache.org/jira/browse/LOG4J2-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christoph Kaser closed LOG4J2-2758.
---
Thank you very much!
> RollingFileAppender: NPE when using a custom DirectFileRolloverStrategy
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376884765
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376894906
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,104 @@
+~~ Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033415#comment-17033415
]
Christoph Kaser commented on LOG4J2-2760:
-
That's strange, I did run all unit tests before
ams-tschoening commented on a change in pull request #14: Replace ant build
with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376907831
##
File path: src/test/cpp/net/socketservertestcase.cpp
##
@@ -478,4 +477,4 @@
turbanoff commented on a change in pull request #338: use 'final' modifier for
fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376814654
##
File path:
log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##
rgoers merged pull request #315: added retry count if failed to send
URL: https://github.com/apache/logging-log4j2/pull/315
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rgoers commented on issue #315: added retry count if failed to send
URL: https://github.com/apache/logging-log4j2/pull/315#issuecomment-583893907
PR manually merged with minor changes.
This is an automated message from the
[
https://issues.apache.org/jira/browse/LOG4J2-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ralph Goers closed LOG4J2-2777.
---
Resolution: Fixed
PR was applied
> Add retryCount attribute to KafkaAppender
>
rgoers commented on issue #319: log4j-kafka added with "retryCount" function
URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-583893976
PR merged with minor changes.
This is an automated message from the
[
https://issues.apache.org/jira/browse/LOG4J2-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033296#comment-17033296
]
ASF subversion and git services commented on LOG4J2-2777:
-
Commit
rgoers merged pull request #332: LOG4J2-2760: Fixes RollingFileAppender with
DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332
This is an automated message from the Apache Git
rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes
RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout
URL: https://github.com/apache/logging-log4j2/pull/332#discussion_r376753729
##
File path:
[
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033323#comment-17033323
]
Ralph Goers commented on LOG4J2-2760:
-
After applying this fix a different unit test started
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376840482
##
File path: src/test/cpp/net/socketservertestcase.cpp
##
@@ -478,4 +477,4 @@
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376843651
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376848071
##
File path: src/test/java/CMakeLists.txt
##
@@ -0,0 +1,18 @@
+include(FetchContent)
ams-tschoening commented on issue #14: Replace ant build with cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583888615
https://github.com/apache/logging-log4cxx/tree/ghpr_14_replace-ant-build-with-cmake
[
https://issues.apache.org/jira/browse/LOG4J2-2760?focusedWorklogId=384141=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384141
]
ASF GitHub Bot logged work on LOG4J2-2760:
--
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033300#comment-17033300
]
ASF subversion and git services commented on LOG4J2-2760:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033301#comment-17033301
]
ASF subversion and git services commented on LOG4J2-2760:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-2760?focusedWorklogId=384142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384142
]
ASF GitHub Bot logged work on LOG4J2-2760:
--
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033302#comment-17033302
]
ASF subversion and git services commented on LOG4J2-2760:
-
Commit
[
https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033303#comment-17033303
]
ASF subversion and git services commented on LOG4J2-2760:
-
Commit
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376844778
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,104 @@
+~~ Licensed to the Apache Software
42 matches
Mail list logo