[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583837151 So let's close #12 and really focus on this one, replacing things in favour of CMAKE instead of adding it? I don't use the ANT-build myself

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-09 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ##

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-09 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376771316 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ##

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583884452 @stephen-webb Does `socketservertestcase` succeed for your? I get the following error messages for two tests which use the `%C` format flag in

[jira] [Created] (LOG4J2-2777) Add retryCount attribute to KafkaAppender

2020-02-09 Thread Ralph Goers (Jira)
Ralph Goers created LOG4J2-2777: --- Summary: Add retryCount attribute to KafkaAppender Key: LOG4J2-2777 URL: https://issues.apache.org/jira/browse/LOG4J2-2777 Project: Log4j 2 Issue Type:

[GitHub] [logging-log4j2] rgoers merged pull request #319: log4j-kafka added with "retryCount" function

2020-02-09 Thread GitBox
rgoers merged pull request #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376811760 ## File path: src/site/apt/building/vcpkg.apt ## @@ -0,0 +1,41 @@ +~~ Licensed to the Apache Software

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376811526 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376809913 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376805122 ## File path: src/test/java/CMakeLists.txt ## @@ -0,0 +1,18 @@ +include(FetchContent)

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376805933 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376803532 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376806130 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376808023 ## File path: src/test/cpp/net/socketservertestcase.cpp ## @@ -478,4 +477,4 @@

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376807031 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[jira] [Commented] (LOG4J2-2777) Add retryCount attribute to KafkaAppender

2020-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033285#comment-17033285 ] ASF subversion and git services commented on LOG4J2-2777: - Commit

[jira] [Commented] (LOG4J2-2703) MapMessage#getFormattedMessage() incorrectly formats Object's

2020-02-09 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033240#comment-17033240 ] Volkan Yazici commented on LOG4J2-2703: --- [~rgoers] , yes, I can give it a try. It is actually

[jira] [Closed] (LOG4J2-2758) RollingFileAppender: NPE when using a custom DirectFileRolloverStrategy without fileName

2020-02-09 Thread Christoph Kaser (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoph Kaser closed LOG4J2-2758. --- Thank you very much! > RollingFileAppender: NPE when using a custom DirectFileRolloverStrategy

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376884765 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376894906 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software

[jira] [Commented] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread Christoph Kaser (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033415#comment-17033415 ] Christoph Kaser commented on LOG4J2-2760: - That's strange, I did run all unit tests before

[GitHub] [logging-log4cxx] ams-tschoening commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376907831 ## File path: src/test/cpp/net/socketservertestcase.cpp ## @@ -478,4 +477,4 @@

[GitHub] [logging-log4j2] turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible

2020-02-09 Thread GitBox
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376814654 ## File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java ##

[GitHub] [logging-log4j2] rgoers merged pull request #315: added retry count if failed to send

2020-02-09 Thread GitBox
rgoers merged pull request #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [logging-log4j2] rgoers commented on issue #315: added retry count if failed to send

2020-02-09 Thread GitBox
rgoers commented on issue #315: added retry count if failed to send URL: https://github.com/apache/logging-log4j2/pull/315#issuecomment-583893907 PR manually merged with minor changes. This is an automated message from the

[jira] [Closed] (LOG4J2-2777) Add retryCount attribute to KafkaAppender

2020-02-09 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers closed LOG4J2-2777. --- Resolution: Fixed PR was applied > Add retryCount attribute to KafkaAppender >

[GitHub] [logging-log4j2] rgoers commented on issue #319: log4j-kafka added with "retryCount" function

2020-02-09 Thread GitBox
rgoers commented on issue #319: log4j-kafka added with "retryCount" function URL: https://github.com/apache/logging-log4j2/pull/319#issuecomment-583893976 PR merged with minor changes. This is an automated message from the

[jira] [Commented] (LOG4J2-2777) Add retryCount attribute to KafkaAppender

2020-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033296#comment-17033296 ] ASF subversion and git services commented on LOG4J2-2777: - Commit

[GitHub] [logging-log4j2] rgoers merged pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout

2020-02-09 Thread GitBox
rgoers merged pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout URL: https://github.com/apache/logging-log4j2/pull/332 This is an automated message from the Apache Git

[GitHub] [logging-log4j2] rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout

2020-02-09 Thread GitBox
rgoers commented on a change in pull request #332: LOG4J2-2760: Fixes RollingFileAppender with DirectWriteRolloverStrategy and HtmlLayout URL: https://github.com/apache/logging-log4j2/pull/332#discussion_r376753729 ## File path:

[jira] [Commented] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033323#comment-17033323 ] Ralph Goers commented on LOG4J2-2760: - After applying this fix a different unit test started

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376840482 ## File path: src/test/cpp/net/socketservertestcase.cpp ## @@ -478,4 +477,4 @@

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376843651 ## File path: src/test/cpp/net/socketserverstarter.cpp ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376848071 ## File path: src/test/java/CMakeLists.txt ## @@ -0,0 +1,18 @@ +include(FetchContent)

[GitHub] [logging-log4cxx] ams-tschoening commented on issue #14: Replace ant build with cmake

2020-02-09 Thread GitBox
ams-tschoening commented on issue #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#issuecomment-583888615 https://github.com/apache/logging-log4cxx/tree/ghpr_14_replace-ant-build-with-cmake

[jira] [Work logged] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?focusedWorklogId=384141=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384141 ] ASF GitHub Bot logged work on LOG4J2-2760: -- Author: ASF GitHub Bot

[jira] [Commented] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033300#comment-17033300 ] ASF subversion and git services commented on LOG4J2-2760: - Commit

[jira] [Commented] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033301#comment-17033301 ] ASF subversion and git services commented on LOG4J2-2760: - Commit

[jira] [Work logged] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?focusedWorklogId=384142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384142 ] ASF GitHub Bot logged work on LOG4J2-2760: -- Author: ASF GitHub Bot

[jira] [Commented] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033302#comment-17033302 ] ASF subversion and git services commented on LOG4J2-2760: - Commit

[jira] [Commented] (LOG4J2-2760) RollingFileAppender with DirectWriteRolloverStrategy does not work with HtmlLayout

2020-02-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033303#comment-17033303 ] ASF subversion and git services commented on LOG4J2-2760: - Commit

[GitHub] [logging-log4cxx] stephen-webb commented on a change in pull request #14: Replace ant build with cmake

2020-02-09 Thread GitBox
stephen-webb commented on a change in pull request #14: Replace ant build with cmake URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376844778 ## File path: src/site/apt/building/cmake.apt ## @@ -0,0 +1,104 @@ +~~ Licensed to the Apache Software