[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16836711/badge)](https://coveralls.io/builds/16836711) Coverage

[GitHub] wu-sheng closed pull request #1173: Do not get alarm metric for overview and application topology.

2018-05-04 Thread GitBox
wu-sheng closed pull request #1173: Do not get alarm metric for overview and application topology. URL: https://github.com/apache/incubator-skywalking/pull/1173 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #1173: Do not get alarm metric for overview and application topology.

2018-05-04 Thread GitBox
coveralls commented on issue #1173: Do not get alarm metric for overview and application topology. URL: https://github.com/apache/incubator-skywalking/pull/1173#issuecomment-386621150 [![Coverage

[GitHub] wu-sheng closed pull request #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
wu-sheng closed pull request #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ascrutae closed issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae closed issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386772017 @candyleer @liuhaoyang The 5.0.0-beta tested and we are going to send the vote mail about 5.0-beta release next week. I will close

[GitHub] ascrutae opened a new issue #167: The format about exception stack is irregular

2018-05-04 Thread GitBox
ascrutae opened a new issue #167: The format about exception stack is irregular URL: https://github.com/apache/incubator-skywalking-ui/issues/167 Here is the screen snapshot: ![286141525450248_

[GitHub] wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386772477 Thanks everyone. Before and during release vote, feel free to open question. Especially for @liuhaoyang about .NET CORE related

[GitHub] zone1511 commented on issue #325: Support config downstream from collector

2018-05-04 Thread GitBox
zone1511 commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386763046 Because some plugin needs dynamic configuration. For agent configuration pushing. It needs to provide several functions -

[GitHub] wu-sheng commented on issue #325: Support config downstream from collector

2018-05-04 Thread GitBox
wu-sheng commented on issue #325: Support config downstream from collector URL: https://github.com/apache/incubator-skywalking/issues/325#issuecomment-386765599 push is just a concept, in network, except deal with TCP. directly, there is no real push. Also client ask server side for new

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16845946/badge)](https://coveralls.io/builds/16845946) Coverage

[GitHub] wu-sheng closed pull request #1109: New Change logs for next release

2018-05-07 Thread GitBox
wu-sheng closed pull request #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] wu-sheng opened a new pull request #1182: Update CHANGES.md

2018-05-07 Thread GitBox
wu-sheng opened a new pull request #1182: Update CHANGES.md URL: https://github.com/apache/incubator-skywalking/pull/1182 Fix a format issue of changelog document. This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on a change in pull request #1109: New Change logs for next release

2018-05-06 Thread GitBox
wu-sheng commented on a change in pull request #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#discussion_r186316040 ## File path: CHANGES.md ## @@ -1,19 +1,79 @@ Changes by Version == Release

[GitHub] wu-sheng opened a new issue #1181: Provide dynamic refresh file in agent

2018-05-06 Thread GitBox
wu-sheng opened a new issue #1181: Provide dynamic refresh file in agent URL: https://github.com/apache/incubator-skywalking/issues/1181 This requirement came from the upgrade, SkyWalking's agent and protocol are stable enough, and didn't need to update for a long time. But considering

[GitHub] ascrutae commented on issue #1181: Provide dynamic refresh file in agent

2018-05-06 Thread GitBox
ascrutae commented on issue #1181: Provide dynamic refresh file in agent URL: https://github.com/apache/incubator-skywalking/issues/1181#issuecomment-386951992 Get it. This is an automated message from the Apache Git

[GitHub] hanahmily commented on a change in pull request #1109: New Change logs for next release

2018-05-06 Thread GitBox
hanahmily commented on a change in pull request #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#discussion_r186314768 ## File path: CHANGES.md ## @@ -1,19 +1,79 @@ Changes by Version == Release

[GitHub] coveralls commented on issue #1109: New Change logs for next release

2018-05-06 Thread GitBox
coveralls commented on issue #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#issuecomment-383520328 [![Coverage Status](https://coveralls.io/builds/16858467/badge)](https://coveralls.io/builds/16858467) Coverage remained the

[GitHub] coveralls commented on issue #1109: New Change logs for next release

2018-05-06 Thread GitBox
coveralls commented on issue #1109: New Change logs for next release URL: https://github.com/apache/incubator-skywalking/pull/1109#issuecomment-383520328 [![Coverage Status](https://coveralls.io/builds/16858674/badge)](https://coveralls.io/builds/16858674) Coverage increased

[GitHub] wu-sheng closed pull request #1182: Update CHANGES.md

2018-05-07 Thread GitBox
wu-sheng closed pull request #1182: Update CHANGES.md URL: https://github.com/apache/incubator-skywalking/pull/1182 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] coveralls commented on issue #1182: Update CHANGES.md

2018-05-07 Thread GitBox
coveralls commented on issue #1182: Update CHANGES.md URL: https://github.com/apache/incubator-skywalking/pull/1182#issuecomment-386985191 [![Coverage Status](https://coveralls.io/builds/16860803/badge)](https://coveralls.io/builds/16860803) Coverage increased (+0.004%) to

[GitHub] wu-sheng opened a new issue #1183: Why doesn't the alarm rate in overview page match alarm in other two pages

2018-05-07 Thread GitBox
wu-sheng opened a new issue #1183: Why doesn't the alarm rate in overview page match alarm in other two pages URL: https://github.com/apache/incubator-skywalking/issues/1183 ![image](https://user-images.githubusercontent.com/5441976/39693913-2f8d009e-5218-11e8-9dc1-275a9747bb79.png)

[GitHub] candyleer opened a new pull request #1175: ix #1174

2018-05-05 Thread GitBox
candyleer opened a new pull request #1175: ix #1174 URL: https://github.com/apache/incubator-skywalking/pull/1175 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] candyleer opened a new pull request #1184: Update FAQ doc

2018-05-07 Thread GitBox
candyleer opened a new pull request #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517155 1. We need to support ZipKin and Jaeger agent. Suggest those to be maven third party module's submodule, but

[GitHub] wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
wu-sheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517882 > apm-collector-thirdparty-agent I didn't like the `agent` part, even we are using this in existed collector

[GitHub] coveralls commented on issue #1165: Get conjectural node component name from component server name.

2018-05-04 Thread GitBox
coveralls commented on issue #1165: Get conjectural node component name from component server name. URL: https://github.com/apache/incubator-skywalking/pull/1165#issuecomment-386533059 [![Coverage

[GitHub] coveralls commented on issue #995: Collector table description for develop guide.

2018-05-04 Thread GitBox
coveralls commented on issue #995: Collector table description for develop guide. URL: https://github.com/apache/incubator-skywalking/pull/995#issuecomment-376571122 [![Coverage Status](https://coveralls.io/builds/16831128/badge)](https://coveralls.io/builds/16831128) Coverage

[GitHub] liuhaoyang opened a new pull request #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang opened a new pull request #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New

[GitHub] wu-sheng commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
wu-sheng commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552511 `sqlite` is a difference component compared with `EntityFrameworkCore's in-memory database`. Right? So, you don't

[GitHub] peng-yongsheng closed pull request #1168: JDK 9 compile.

2018-05-04 Thread GitBox
peng-yongsheng closed pull request #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] liuhaoyang closed pull request #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang closed pull request #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] coveralls commented on issue #1168: JDK 9 compile.

2018-05-04 Thread GitBox
coveralls commented on issue #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386553512 [![Coverage Status](https://coveralls.io/builds/16831980/badge)](https://coveralls.io/builds/16831980) Coverage remained the same at 23.363%

[GitHub] liuhaoyang commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386553431 You're right. It is not appropriate to remove existing IDS.

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910 # Report @ 2018/05/04 ## Issue ### Topology * **[COLLECTOR]** the server alarm value is incorrect. Except is 1, but

[GitHub] coveralls commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
coveralls commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386558445 [![Coverage Status](https://coveralls.io/builds/16832337/badge)](https://coveralls.io/builds/16832337)

[GitHub] wu-sheng closed pull request #1165: Get conjectural node component name from component server name.

2018-05-04 Thread GitBox
wu-sheng closed pull request #1165: Get conjectural node component name from component server name. URL: https://github.com/apache/incubator-skywalking/pull/1165 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386199704 # Report @ 2018/05/03 the prefix description of Issue: |prefix|description| |:---|:---| |**[AGENT]** | This prefix

[GitHub] wu-sheng opened a new issue #1167: Refactor the plugin component name to real library name

2018-05-04 Thread GitBox
wu-sheng opened a new issue #1167: Refactor the plugin component name to real library name URL: https://github.com/apache/incubator-skywalking/issues/1167 Since the component mapping has provided in collector side, please refactor all existed component plugins to their real component

[GitHub] peng-yongsheng opened a new pull request #1168: JDK 9 compile.

2018-05-04 Thread GitBox
peng-yongsheng opened a new pull request #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168 Please answer these questions before submitting pull request - Why submit this pull request? - [X] New feature provided ___ ### New feature or

[GitHub] wu-sheng commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
wu-sheng commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386552128 Cannot support for now or forever? From my perspective, removing some existed IDs is a very dangerous and

[GitHub] ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
ascrutae commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386556910 # Report @ 2018/05/04 ## Issue ### Topology * **[COLLECTOR]** the server alarm value is incorrect. Except is 1, but

[GitHub] wu-sheng opened a new issue #1166: Optimize topology query

2018-05-04 Thread GitBox
wu-sheng opened a new issue #1166: Optimize topology query URL: https://github.com/apache/incubator-skywalking/issues/1166 Add a new column for group query, in order to reduce the query cost. This is an automated message

[GitHub] wu-sheng commented on issue #1168: JDK 9 compile.

2018-05-04 Thread GitBox
wu-sheng commented on issue #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386546604 @liuhaoyang FYI, we didn't add jdk9 and jdk10 compile in CI. These cost too much. I still recommend to compile in JDK8.

[GitHub] liuhaoyang commented on issue #1168: JDK 9 compile.

2018-05-04 Thread GitBox
liuhaoyang commented on issue #1168: JDK 9 compile. URL: https://github.com/apache/incubator-skywalking/pull/1168#issuecomment-386547217 yes. I just use JDK9 to test. This is an automated message from the Apache Git Service.

[GitHub] wu-sheng commented on issue #1169: Remove components define that cannot be supported

2018-05-04 Thread GitBox
wu-sheng commented on issue #1169: Remove components define that cannot be supported URL: https://github.com/apache/incubator-skywalking/pull/1169#issuecomment-386550279 what do you mean cannot support? This is an automated

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-03 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386503576 ## Report @ 2018/05/04 ### Issue * [Collector] Block Error ``` java.lang.ClassCastException:

[GitHub] candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-03 Thread GitBox
candyleer commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386503576 ## Report @2018/05/04 ### Issue * [Collector] Block Error ``` java.lang.ClassCastException:

[GitHub] coveralls commented on issue #1161: Rename thermodynamic attributes.

2018-05-03 Thread GitBox
coveralls commented on issue #1161: Rename thermodynamic attributes. URL: https://github.com/apache/incubator-skywalking/pull/1161#issuecomment-386503477 [![Coverage Status](https://coveralls.io/builds/16829425/badge)](https://coveralls.io/builds/16829425) Coverage remained the

[GitHub] peng-yongsheng opened a new issue #1162: Clean buffer files by default when restart collector.

2018-05-03 Thread GitBox
peng-yongsheng opened a new issue #1162: Clean buffer files by default when restart collector. URL: https://github.com/apache/incubator-skywalking/issues/1162 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Bug ___ ### Bug

[GitHub] peng-yongsheng closed pull request #1161: Rename thermodynamic attributes.

2018-05-03 Thread GitBox
peng-yongsheng closed pull request #1161: Rename thermodynamic attributes. URL: https://github.com/apache/incubator-skywalking/pull/1161 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] wu-sheng closed issue #1158: Support settings of collector module provide in complex structure

2018-05-04 Thread GitBox
wu-sheng closed issue #1158: Support settings of collector module provide in complex structure URL: https://github.com/apache/incubator-skywalking/issues/1158 This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng closed issue #1162: Clean buffer files by default when restart collector.

2018-05-04 Thread GitBox
wu-sheng closed issue #1162: Clean buffer files by default when restart collector. URL: https://github.com/apache/incubator-skywalking/issues/1162 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test

2018-05-04 Thread GitBox
wu-sheng commented on issue #1146: SkyWalking 5.0.0-beta e2e test URL: https://github.com/apache/incubator-skywalking/issues/1146#issuecomment-386517079 @candyleer your blocking should be removed by now. This is an

[GitHub] peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin

2018-05-04 Thread GitBox
peng-yongsheng commented on issue #665: [Tracer Interop] Google OpenCensus / OpenZipkin URL: https://github.com/apache/incubator-skywalking/issues/665#issuecomment-386517155 1. We need to support ZipKin and Jaeger agent. Suggest those to be maven third party module's submodule, but

[GitHub] coveralls commented on issue #1184: Update FAQ doc

2018-05-07 Thread GitBox
coveralls commented on issue #1184: Update FAQ doc URL: https://github.com/apache/incubator-skywalking/pull/1184#issuecomment-387086981 [![Coverage Status](https://coveralls.io/builds/16866433/badge)](https://coveralls.io/builds/16866433) Coverage increased (+0.004%) to 23.362%

[GitHub] wu-sheng commented on issue #1124: Duplicated service search result

2018-05-14 Thread GitBox
wu-sheng commented on issue #1124: Duplicated service search result URL: https://github.com/apache/incubator-skywalking/issues/1124#issuecomment-386185825 I am moving this issue to beta2, because this is caused by this service is out of date. I guess, some one sets the application code

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682 @wu-sheng thanks a lot, I will resolve the conflicts and mentions. 技术部·架构部·林嘉琦 手机:18710075837

[GitHub] liuwei881 commented on issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息?

2018-05-14 Thread GitBox
liuwei881 commented on issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息? URL: https://github.com/apache/incubator-skywalking/issues/1221#issuecomment-388707922 sky walking是否提供python 的api? This is an

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388727682 @wu-sheng thanks a lot, I will resolve the conflicts and mentions. 技术部·架构部·林嘉琦 手机:18710075837

[GitHub] chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
chidaodezhongsheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-388736637 @wu-sheng thanks a lot, I will resolve the conflicts and mentions.

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901397 ## File path:

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187901335 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] Rainbowboys opened a new issue #1223: Some doubts about the ui

2018-05-14 Thread GitBox
Rainbowboys opened a new issue #1223: Some doubts about the ui URL: https://github.com/apache/incubator-skywalking/issues/1223 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ]

[GitHub] wu-sheng commented on issue #1221: Does SkyWalking support Python API?

2018-05-14 Thread GitBox
wu-sheng commented on issue #1221: Does SkyWalking support Python API? URL: https://github.com/apache/incubator-skywalking/issues/1221#issuecomment-388710765 You could see from the readme. SkyWalking is supporting multiple languages, Java, .NET, Nodejs. Go is still ongoing. But you should

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858734 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,13 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858505 ## File path: docs/README.md ## @@ -1,45 +1,46 @@ -## Documents -[![cn

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187851353 ## File path: apm-collector/apm-collector-boot/src/main/resources/application.yml ##

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858208 ## File path: apm-dist/release-docs/LICENSE ## @@ -255,6 +256,7 @@ The text of each

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187858863 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,13 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898156 ## File path: docs/README_ZH.md ## @@ -1,42 +1,46 @@ -## 中文文档 -[![EN

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898936 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,21 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899581 ## File path: docs/README_ZH.md ## @@ -1,42 +1,46 @@ -## 中文文档 -[![EN

[GitHub] chidaodezhongsheng opened a new pull request #1220: support shardingjdbc database storage feature

2018-05-13 Thread GitBox
chidaodezhongsheng opened a new pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] New feature provided

[GitHub] coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
coveralls commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388714290 [![Coverage

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388746169 @wu-sheng It based my local machine. I installed sofarpc 5.4.0 to my local m2 repo I tested it like this. env settings

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388747564 When we release sofarpc 5.4.0 I will provide a new test report This is

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879656 ## File path:

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187881241 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/README.md

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187879700 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -31,11

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187882858 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@ -98,11

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187883561 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/pom.xml

[GitHub] wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187883147 ## File path: apm-sniffer/optional-plugins/trace-ignore-plugin/pom.xml

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899006 ## File path: docs/en/Shardingjdbc.md ## @@ -0,0 +1,21 @@ +# Supported Database

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187898905 ## File path: docs/cn/Shardingjdbc-CN.md ## @@ -0,0 +1,21 @@ +# 支持数据库分片存储

[GitHub] wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature

2018-05-14 Thread GitBox
wu-sheng commented on a change in pull request #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#discussion_r187899019 ## File path: docs/cn/Shardingjdbc-CN.md ## @@ -0,0 +1,21 @@ +# 支持数据库分片存储

[GitHub] liuwei881 opened a new issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息?

2018-05-14 Thread GitBox
liuwei881 opened a new issue #1221: sky walking是否提供python 的api,就是直接通过python调取skywalking的相关信息? URL: https://github.com/apache/incubator-skywalking/issues/1221 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388745138 @leizhiyuan Ping us when you are ready (after release). And I have to ask, where does

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-14 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388742185 @wu-sheng I have tested it, It seems everything is ok,

[GitHub] coveralls commented on issue #1217: Rewrite Async http client plugin

2018-05-13 Thread GitBox
coveralls commented on issue #1217: Rewrite Async http client plugin URL: https://github.com/apache/incubator-skywalking/pull/1217#issuecomment-388535000 [![Coverage Status](https://coveralls.io/builds/16963044/badge)](https://coveralls.io/builds/16963044) Coverage increased

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 -javaagent:~/skywalking-agent/skywalking-agent.jar ``` private static AbstractTracerContext getOrCreate(String operationName,

[GitHub] SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-13 Thread GitBox
SevenPointOld commented on a change in pull request #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#discussion_r187836198 ## File path: apm-sniffer/optional-plugins/pom.xml ## @@

[GitHub] SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203)

2018-05-14 Thread GitBox
SevenPointOld commented on issue #1213: provides a optional-plugin for tracking ignores enhancement(#1203) URL: https://github.com/apache/incubator-skywalking/pull/1213#issuecomment-388733787 I have revised code and pushed to repository, please review the new request

[GitHub] dinggel opened a new issue #1222: How do I package the master branch code?

2018-05-14 Thread GitBox
dinggel opened a new issue #1222: How do I package the master branch code? URL: https://github.com/apache/incubator-skywalking/issues/1222 I want to use the latest version of incubator-skywalking-ui,i have some problems when i run the master branch code of incubator-skywalking-ui with the

[GitHub] leizhiyuan commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
leizhiyuan commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388693585 ignore me This is an automated message from the Apache Git Service. To

[GitHub] wu-sheng commented on issue #1210: Add sofa rpc plugin integration

2018-05-13 Thread GitBox
wu-sheng commented on issue #1210: Add sofa rpc plugin integration URL: https://github.com/apache/incubator-skywalking/pull/1210#issuecomment-388687519 @leizhiyuan You could debug the `TracingContext#finish`. The `TraceSegment` in the method should contain all the data you need.

  1   2   3   4   5   6   7   8   9   10   >