Re: [notmuch] keeping a copy of sent mail locally

On Sun, Dec 20, 2009 at 07:22:55PM +0100, Marten Veldthuis wrote: > There's a message-send-hook, which we should probably use. Something > like: > > (add-hook 'message-send-hook 'notmuch-always-bcc-sender) > (defun notmuch-always-bcc-sender () > (message-add-header (concat "Bcc: " >

Re: [notmuch] keeping a copy of sent mail locally

On Mon, Dec 21, 2009 at 08:57:40PM +1100, Alex Ghitza wrote: > On Sun, 20 Dec 2009 13:31:13 -0500, Jameson Graef Rollins > wrote: > > Hi, folks. I've been following this thread a bit and I wanted to put > > in my argument that using Bcc is *NOT* the way to save local copi

[notmuch] update on delete/rename support

Hey, folks. I was wondering if there was an update on getting support for mail deleting and moving/renaming into notmuch. I wanted to try to push on it a little bit since I believe that support for deleting/moving messages is the most important outstanding issue at the moment. I finally got arou

Re: [notmuch] update on delete/rename support

On Sat, Dec 26, 2009 at 10:06:24AM -0800, Carl Worth wrote: > Yes. I've got a series of about 20 commits reworking the internals a > bit, and then one patch past that that I still need to break down into > several clean commits. Carl, that's really great to hear. Thanks so much for the response.

[notmuch] modifying emacs keymap

Hey, folks. This is the first in what is surely to be a long line of requests for help customizing the notmuch emacs UI. In this episode, I'm trying to add a function to the default keymap in notmuch-search-mode. Here's what I tried to do: (add-hook 'notmuch-search-mode (define-key notmuch-se

Re: [notmuch] modifying emacs keymap

On Mon, Dec 28, 2009 at 11:27:30PM +0100, Tassilo Horn wrote: > > (add-hook 'notmuch-search-mode > > (define-key notmuch-search-mode-map "A" > > 'notmuch-show-mark-read-then-archive-thread) > > ) > > `notmuch-search-mode' is no hook, and even if it was, you couldn't add > what you like, because

[notmuch] [PATCHv2] notmuch.el: colorize lines in notmuch-search based on thread tags.

Arbitrary font faces can be specified for given thread tags. By default, no coloring is applied. To specify coloring, place something like this in your .emacs: (setq notmuch-search-line-faces '(("delete" . (:foreground "red")) ("unread" . (:foreground "green")))

Re: [notmuch] [PATCHv2] notmuch.el: colorize lines in notmuch-search based on thread tags.

I realize I should have mentioned that this patch is meant to supercede the previous patch. There are just a couple of minor improvements, including turning on highlighting for deleted threads by default. jamie. pgpXjXWTROZ0t.pgp Description: PGP signature __

Re: [notmuch] loss of duplicate messages

On Fri, 05 Feb 2010 18:25:59 +0100, Marten Veldthuis wrote: > This is indeed the correct behaviour of notmuch. There has been some > discussion on it in the past, I believe with proposals to track both > messages and show only one; but I don't think I've seen proponents of > showing both duplicat

[PATCH] use custom-face-edit value-type in notmuch-search-line-faces

This enables the proper face customization UI for notmuch-search-line-faces. --- emacs/notmuch.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 92a86cf..a23d0c2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -612,7 +612

Sorting and attachments

On Sat, 26 Mar 2011 21:53:49 -0700, mueen at nawaz.org wrote: > 1. Can notmuch return results sorted by size? As far as I know, there is currently no way to do that (but see below). > 2. Can I tell notmuch to limit the items it returns (e.g. show me > first ten messages matching ... ) Are you lo

crypto branch rebased

I've rebased my crypto branch [0] against cworth's master at 74bc93f0. jamie. [0] git://finestructure.net/notmuch -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL:

[PATCH] use custom-face-edit value-type in notmuch-search-line-faces

On Sun, 27 Mar 2011 22:57:46 -0400, Austin Clements wrote: > My concern is that it's unclear if the custom-face-edit widget is considered > a public interface, or if it's internal to customize and thus could change > at any time. These things are always a bit murky in Emacs. custom-face-edit > has

crypto branch rebased

On Thu, 31 Mar 2011 23:26:34 +0200, Xavier Maillard wrote: > Just an OT message to inform you that my notmuch/emacs couple no longer > crashes here. I did not find out why it crashed before though. Great! jamie. -- next part -- A non-text attachment was scrubbed... Name:

Not build threads option?

On Fri, 01 Apr 2011 20:42:23 -0700, mueen at nawaz.org wrote: > Is there a way in the notmuch emacs client not to build the threads for > each query? It can be a bit time consuming. Sometimes (often, actually), > I just want to read all mails from someone, and am not interested in the > whole threa

(auto-)tagging sent messages

On Sat, 16 Apr 2011 14:57:07 +0200, Pieter Praet wrote: > > Further, for certain mails I sent (like this one ) I would like a > > WAITING tag (or similar) in order to indicate that I am waiting for an > > answer. Currently I set this manually. Could this be achieved through > > some indicators via

Strange match to my query

On Thu, 14 Apr 2011 09:32:30 +0200, Florian Friesdorf wrote: > On Tue, 01 Mar 2011 15:15:22 -0800, Jameson Rollins finestructure.net> wrote: > > > A simple rebuild when you go to bed can look like: > > > > I think you're missing an important step: > > > > notmuch dump >dump.txt > > mv $(notmuc

tracking non-mail files [was: Re: (auto-)tagging sent messages]

On Mon, 25 Apr 2011 14:41:28 -0700, Carl Worth wrote: > Though, even if that were the only problem, we could just teach notmuch > to remember that particular files were detected as not-email to fix the > performance problem without requiring any user configuration. This is actually related to an

new "crypto" branch providing full PGP/MIME support

Quick! While cworth is working I want to push this back to the top of the queue! crypto branch is still ready for merge! git://finestructure.net/notmuch Thanks! jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signat

doc: notmuch help search-terms, boolean operators

On Tue, 26 Apr 2011 16:01:17 -0700, Carl Worth wrote: > > Complete list of boolean operators in order of precedence: > > - NOT > > - AND > > - XOR > > - OR > > > > Is this correct? If yes, I would extend the manpage accordingly. > > Currently, notmuch doesn't implement this behavior but relies o

[PATCH] create and set temporary home directory

On Fri, 06 May 2011 11:09:19 +0200, Florian Friesdorf wrote: > any chance of getting this patch into 0.6? Hi, Florian. Yes, I have included this patch in the release-candidate/0.6 branch. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available T

release-candidate/0.6

Hi, folks. As some of you already know, I am trying to put together a release candidate for a 0.6 release that we can present to cworth for approval. This branch can be found in my public notmuch repository in the "release-candidate/0.6" branch: git remote add jrollins git://finestructure.net/no

vim support improvements for 0.6

Hi, Filipe. I notice that you have been submitting a lot of patches for vim support. As you may have seen, I'm trying to put together a release candidate for notmuch 0.6. Since I know nothing about vim, would you be willing to prepare a patch set that includes all of the patches to vim support t

[PATCH] implement search --format=sanitized_text + emacs UI to use it

On Fri, 6 May 2011 19:55:26 -0400, Austin Clements wrote: > Perhaps text summary output should *always* do this. The text summary > format is meant half for user consumption and half for emacs > consumption and allowing newlines that don't indicate the end of a > summary line seems bad for *both*

release-candidate/0.6

On Fri, 6 May 2011 22:31:09 -0400, Tim Gray wrote: > Ditto with the very very simple patch I sent about OS X compiling. I > take it there are few users of OS X on this list, so every little bit > could help. Hi, Tim. Have you tried compiling the release-candidate/0.6 on OS X without this patc

[PATCH] Add part filename in notmuch show output if available.

On Sun, 8 May 2011 03:00:37 +0400, Dmitry Kurochkin wrote: > Before the change, notmuch show output had filename only for > parts with "Content-Disposition: attachment". But parts with > inline disposition may have filename as well. > > The patch makes notmuch show always output filename if ava

[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

Hey, Florian. I applied this patch to release-candidate/0.6, manually adding in the formatting fixes in the same patch. I also applied the test patch, modified to use the add_message test suite function, which makes the patch a bit simpler. Thanks for the fixes. jamie. -- next part

release-candidate/0.6

On Fri, 06 May 2011 19:56:30 -0400, James Vasile wrote: > I sent two patches to the list on March 16. They were a bug fix to > allow notmuch to correctly handle some poorly formatted email. Nobody > ever replied, but I'd like to see the bug fixed nonetheless, as it > results in unreadable mail.

release-candidate/0.6

Hi, folks. I've pushed some more patches to the release-candidate/0.6 branch [0] (which should now be at commit id 89ca01b6104dd732903104e50777a7b4a211e1f4): * support for decryption of parts with notmuch show --format=part * emacs support for retrieving parts (like attachments) from encrypted

release-candidate/0.6

On Sun, 08 May 2011 21:24:52 -0400, Daniel Kahn Gillmor wrote: > One new feature that you didn't mention is that --decrypt is passed > through to notmuch reply based on the state of the current buffer. > > That is: it used to be that you had to remember whether you'd viewed a > thread with M-RET

storing From and Subject in xapian

On Wed, 4 May 2011 21:48:39 -0400, Austin Clements wrote: > This is awesome. What was your machine configuration? Does anyone else have an opinions about this patch? It seems reasonable to me (other than a couple errant comments that were left in and should be removed). It seems worth the slig

[PATCH 1/1] emacs: Use "message-cited-text" instead of "message-cited-text-face"

Hi, Pieter. I applied this patch to the release-candidate/0.6 branch. Thanks for sending it in, and fixing it up. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL:

[PATCH] Fix old style notmuch-fcc-dirs configuration check.

On Mon, 9 May 2011 20:04:54 +0400, Dmitry Kurochkin wrote: > In notmuch 0.5 notmuch-fcc-dirs style changed. The previous code > did not correctly identify an old configuration and, as a > consequence, broke new configurations. > > The fix was extracted from a bigger patch series by David > Edmo

[PATCH] Use message-field-value instead of message-fetch-field in FCC header setup.

On Mon, 9 May 2011 16:06:20 +0400, Dmitry Kurochkin wrote: > For message-fetch-field the buffer is expected to be narrowed to > just the header of the message. That is not the case when > notmuch-fcc-header-setup is run, hence a wrong header value may be > returned. E.g. when forwarding an > em

[PATCH] lib/message-file: plug three memleaks.

Hey, Anton. Thanks for identifying and fixing these. I've pushed this to the r-c/0.6 branch. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL:

release-candidate/0.6

Hi, folks. I have pushed a couple of more patches to release-candidate/0.6 [0]: * Dmitry's fix for emacs fcc * Anton Khirnov's memleak fixes I think that everything else can wait for later releases. ***I hereby declare that release-candidate/0.6 is ready for release.*** I think the only remain

release-candidate/0.6

On Mon, 09 May 2011 10:20:18 -0700, Jameson Graef Rollins wrote: > ***I hereby declare that release-candidate/0.6 is ready for release.*** After all of that pomp, I take it all back! Fully fearful of further delaying release of 0.6, I decided I wanted to slip in a couple last-minute patc

[PATCH] test: use `princ' instead of `message' calls in emacs tests

On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin wrote: > The patch replaces all (message (buffer-string)) calls in emacs > tests with (princ (buffer-string)). This avoids accidentally > interpreting '%' as format specifiers and makes code simpler > because we do not need to capture stderr. >

vim support improvements for 0.6

On Tue, 10 May 2011 01:30:11 +0300, Felipe Contreras wrote: > All right. Hopefully nobody will request further changes to these patches: > git://github.com/felipec/notmuch.git [fc-vim-next] > > It's not rebased on top of your branch, but there are no merge conflicts. Thanks, Felipe. Merged with

[PATCH] avoid segfault when calling sanitize_string() on NULL

Yikes! Thanks for finding this, dkg. I just pushed this to r-c/0.6. It looks like we need to expand the tests to test this corner case. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: n

release-candidate/0.6

Arg. One last bit of churn. dkg found a bug in the new sanitize_string function that was causing segfaults on messages with empty headers. This is obviously an imprtant thing to fix. After chatting with some folks on #notmuch, we decided that the debian build dependency on libgmime 2.4.24 is a

address completion when composing

On Wed, 11 May 2011 14:31:36 +0200, Florian Friesdorf wrote: > In addition, about a year ago, Sebastian indicated, that notmuch itself > could offer returning email addresses [3]. Are there arguments against > or just nobody found the time to do it? As with pretty much everything in notmuch, man

[PATCH] Fix search output sanitization test.

On Wed, 11 May 2011 13:48:29 -0400, Austin Clements wrote: > Previously, the test assumed the generated message would be assigned a > specific thread ID; now it doesn't. Also, spelling fix. Thanks, Austin. I applied this to the r-c/0.6 branch. jamie. -- next part -- A n

address completion when composing

On Thu, 12 May 2011 02:04:41 +0200, Florian Friesdorf wrote: > 1. store to/cc/bcc in xapian Hey, Florian. I think all of these fields are actually already stored in the database. > 2. provide a mechanism to query those fields from the cmdline I think this is the idea. You would also want to

[PATCH] test: "search-by-folder" single-word search terms should be updated correctly when directories are renamed.

On Thu, 12 May 2011 15:22:25 +0200, Pieter Praet wrote: > I've pushed a cleaner version of this patch to my github repo, for > inclusion in release-candidate/0.6. Hey, Pieter. I realize we've been passing around git urls a lot recently, particularly in regards to the release-candidate/0.6 branch

release-candidate/0.6

On Thu, 12 May 2011 15:36:43 -0700, Carl Worth wrote: > Does anyone want to attempt to fix up this first patch? (It doesn't > necessarily have to be David). Hi, Carl. I went through dme's multipart patch series and cleaned things up. I split up that first commit into a couple of separate ones,

Header and other questions

On Mon, 16 May 2011 11:27:52 -0400, Jesse Rosenthal wrote: > The decision, if I remember correctly, was that regions are so intuitive > for emacs users, and many people reported trying to tag by region > without thinking about it, that this approach would make sense for the > emacs interface. In

Multiple sender identities (composing)

On Mon, 16 May 2011 11:52:43 +0200, Thomas Jost wrote: > On Mon, 16 May 2011 19:29:07 +1000, Stewart Smith flamingspork.com> wrote: > > Thought I'd share this bit of my .emacs snippet that may be useful to go > > on the emacs tips page. > > > > This does the following: > > - sets up a list of p

Multiple sender identities (composing)

On Mon, 16 May 2011 20:03:34 +0200, Thomas Jost wrote: > Nice idea, I like that. However this way you can only get the address > part, not the username part. And when using some addresses I want to put > a nickname instead of my full name, so just using a default user name is > not very convenien

MIME restructuring [was: Re: release-candidate/0.6]

On Mon, 16 May 2011 14:20:07 -0700, Carl Worth wrote: > I'll have to learn better how to control the emacs mail composer in > order to understand how to get signatures to cover attachments if I want > to do that kind of thing. See mml-secure-message-sign-pgpmime to sign an entire message, as oppo

New crypto patch series

Hi, folks. This is a series of patches that constitute a complete rework of notmuch crypto support (signature verification and decryption of PGP/MIME messages, with emacs ui support), including some relevant preparatory patches, on top of the notmuch/master branch at b6862c7eb9bfb00183e568b40d77ea

[PATCH 03/11] Use empty strings instead of NULL in format_reply structure.

This keeps things consistent with notmuch-show, and prevents having to check for the existence of the field pointer for simple string output formats. --- notmuch-reply.c | 12 ++-- show-message.c |2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/notmuch-reply.c b

[PATCH 05/11] test: new test-lib function to test for equality between files

We need to be able to test for the presence of a newline at the end of output. There's no good way to capture trailing newlines in bash, so redirecting output to a file is the next best thing. This new function should be used when testing for output that is expected to have trailing newlines. Th

[PATCH 01/11] Simplify reply_part function to eliminate redundant code paths.

This is the same logic but with less code. --- notmuch-reply.c | 41 ++--- 1 files changed, 14 insertions(+), 27 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index ab15650..5d72b1f 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -88,31 +8

[PATCH 09/11] Add decryption of PGP/MIME-encrypted parts with --decrypt.

This adds support for decrypting PGP/MIME-encrypted parts to notmuch-show and notmuch-reply. The --decrypt option implies --verify. Once decryption (and possibly signature verification) is done, a new part_encstatus formatter is emitted, the part_sigstatus formatter is emitted, and the entire mul

[PATCH 02/11] Integrate reply_part_content function into reply_part function.

After the last patch to eliminate some redundant code paths in reply_part, the reply_part_content function was only being called once. Disolving the function and integrating its contents into the reply_part function makes things a little simpler, and frees up some name space that will be needed in

[PATCH 07/11] test: add crypto tests for signature verification and decryption

This adds a new "crypto" test script to the test suite to test PGP/MIME signature verification and message decryption. Included here is a test GNUPGHOME with a test secret key (passwordless), and test for: * signing/verification * signing/verification with full owner trust * verification wi

[PATCH 06/11] test: add notmuch_show_sanitize_all function that is a little more aggressive.

The old notmuch_show_sanitize function only scrubed part of the filename. This one scrubs the full filename, as well as the message id. --- test/test-lib.sh |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 9e2e0b5..ae25635 100

[PATCH 04/11] Break up format->part function into part_start and part_content functions.

Future improvements (eg. crypto support) will require adding new part header. By breaking up the output of part headers from the output of part content, we can easily out new part headers with new formatting functions. --- notmuch-client.h |5 +- notmuch-reply.c | 13 -- notmuch-show.c

[PATCH 10/11] emacs: Add support for PGP/MIME verification/decryption

A new emacs configuration variable "notmuch-crypto-process-mime" controls the processing of PGP/MIME signatures and encrypted parts. When this is set true, notmuch-query will use the notmuch show --decrypt flag to decrypt encrypted messages and/or calculate the sigstatus of signed messages. If sig

[PATCH 08/11] Add signature verification of PGP/MIME-signed parts with --verify.

This is primarily for notmuch-show, although the functionality is added to show-message. Once signatures are processed a new part_sigstatus formatter is emitted, and the entire multipart/signed part is replaced with the contents of the signed part. At the moment only a json part_sigstatus formatt

[PATCH 11/11] tag signed/encrypted during notmuch new

This patch adds the tag "signed" to messages with any multipart/signed parts, and the tag "encrypted" to messages with any multipart/encrypted parts. This only occurs when messages are indexed during notmuch new, so a database rebuild is required to have old messages tagged. --- lib/index.cc

[PATCH] emacs: Allow user to choose "From" address when composing a new message.

On Thu, 26 May 2011 10:39:58 +0200, Thomas Jost wrote: > > When I first started implementing the custom-from feature I planned to > > use a prefix argument to get the behavior (such as "C-u m" rather than > > "M" for compose-new-mail-with-custom-from). You might even see I've got > > some code wr

[PATCH] emacs: Add a customization allowing to always prompt for the "From" address when composing a new message

On Thu, 26 May 2011 19:22:41 +0200, Thomas Jost wrote: > Here it is :) I'm sure it will be useful for many other people too, including > myself. To be applied on top of my other patches, then you can set > notmuch-always-prompt-for-sender to t. Awesome! Thanks, Thomas. jamie. -- ne

[PATCH] emacs: Add a customization allowing to always prompt for the "From" address when composing a new message

On Thu, 26 May 2011 14:11:11 -0700, Carl Worth wrote: > It's a nice patch series, and I've pushed it all out now. After using this feature for a day, I think it's great. But it would be nice if the name was just automatically filled in, since that doesn't change, and the ido selection cycled thr

[PATCH] emacs: Add a customization allowing to always prompt for the "From" address when composing a new message

Another thing I'm realizing is that I don't think I want the from select to be happening when I'm replying to messages. The reply is already smartly picking From: address based on the To: address of the message being replied to. What if we just make from selector work for just composing new messa

normalizing part numbering across PGP/MIME processing

Ok. So I very much hope this patch series satisfies those who were bothered by the part renumbering that was happening when PGP/MIME parts were processed. For signed messages we no longer modify the parts at all, so numbering always remains constant, and for encrypted messages the numbering will

[PATCH 3/4] emacs: Do not attempt to render arbitrary application parts.

We probably shouldn't have been doing this anyway, but we do it here specifically because we don't want the content of the application/pgp-encrypted parts to be displayed and cluttering the message show. --- emacs/notmuch-show.el |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

[PATCH 4/4] emacs: Give mutlipart/{signed, encrypted} their own part handler.

This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- emacs/notmu

[PATCH 2/4] Render all parts of multipart/encrypted when decrypting.

The primary goal here is to keep the decrypted output as similarly structured as undecrypted output as possible. Now, when decrypting parts, only the original encrypted part is replaced by the it's decrypted content. If this part isn't itself a multipart, then all part numbering should remain con

[PATCH 1/4] Do not replace multipart/signed part with content part when doing verification.

Some folks have complained about the part renumbering that occurs when the entire multipart/signed part is replaced with the part contents after verification. This is primarily because it incurs an additional computational cost to retrieve individual parts, since verification has to be performed a

[PATCH 1/2] emacs: Don't always prompt for the "From" address when replying

On Fri, 27 May 2011 11:14:59 +0200, Thomas Jost wrote: > You're right, this is mostly annoying when replying to messages. Here's a fix. Awesome. Thanks, Thomas. Tested and works great. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Typ

[PATCH 2/2] emacs: Cleaner interface when prompting for sender address

On Fri, 27 May 2011 11:15:00 +0200, Thomas Jost wrote: > Once again, a very good suggestion. I had doubts at first (because I sometimes > send mails using a nickname or on behalf of a group using that group's name), > but then I noticed I already had only one name in notmuch-identities :) So > he

[PATCH] emacs: Give mutlipart/{signed, encrypted} their own part handler.

This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- This patch

normalizing part numbering across PGP/MIME processing

On Fri, 27 May 2011 17:53:44 -0700, Carl Worth wrote: > So, well done, Jameson! You've been extremely patient as I sat on this > patch series for *so* long, and then made you rebuild it so many > times. I hope you think the rebuilds were at least worth it for the much > cleaner final state, (I kno

[PATCH 02/25] add note about updating the debian symbols file to the RELEASE file

--- RELEASING | 22 ++ 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/RELEASING b/RELEASING index a392d81..475100a 100644 --- a/RELEASING +++ b/RELEASING @@ -35,7 +35,21 @@ repository. From here, there are just a few steps to release: Commit this cha

release-candidate/0.6 redux

So what follows is a patch series for a bunch of miscellaneous patches that should be included in 0.6. Most of them were originally part of the release-candiate/0.6 branch, and they are here rebased on top of notmuch/master at cb8418784c21155ffea79cce8409a7ea3c546937, which includes all the multip

[PATCH 04/25] test: move "Search for non-existent message prints nothing" to search-output, and add similar test for format=json

These tests also use the new test_expect_equal_file test. --- test/search|5 - test/search-output | 12 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/test/search b/test/search index 0981f66..4835872 100755 --- a/test/search +++ b/test/search @@ -118

[PATCH 06/25] test: move utf-8 subject search test from json to search test script

This test doesn't have anything to do with json, and has everything to do with testing search capability, so I'm not sure why it was in the wrong place. --- test/json |5 - test/search |6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/test/json b/test/json ind

[PATCH 12/25] test: cleanup search-output test names (no functional change)

Signed-off-by: Jameson Graef Rollins --- test/search-output | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/test/search-output b/test/search-output index 8edc26a..02cf602 100755 --- a/test/search-output +++ b/test/search-output @@ -4,7 +4,7

[PATCH 08/25] create and set temporary home directory

ctory. The patch creates a directory in the temporary test directory and sets home accordingly. In case of a non-existent home directory, the tests are failing without this patch. Signed-off-by: Jameson Graef Rollins --- test/test-lib.sh |7 +++ 1 files changed, 7 insertions(+), 0 dele

[PATCH 09/25] emacs: Define several faces for the crypto-status button

From: Thomas Jost Signed-off-by: Jameson Graef Rollins jrollins modified this patch to conform to recent changes in the crypto processing since this patch was originally sent in. --- emacs/notmuch-crypto.el | 42 -- 1 files changed, 32 insertions

[PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.

l-dme at dme.org". Signed-off-by: Jameson Graef Rollins --- emacs/notmuch-maildir-fcc.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 3f1c124..b79f6a3 100644 --- a/emacs/notmuch-maildir-fcc.el +

[PATCH 01/25] fix check for libdir in ldconfig paths

The configure script tries to check that the libdir is included in the ldconfig paths, and then sets the RPATH compiler flag if it's not. This check was broken, and was always setting RPATH. This fixes the path check. --- configure |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 11/25] test: add test for sanitized notmuch-search output

From: Florian Friesdorf Signed-off-by: Jameson Graef Rollins --- test/search-output |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/search-output b/test/search-output index 13f9613..8edc26a 100755 --- a/test/search-output +++ b/test/search-output @@ -304,6

[PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output

The test in json was inferior to the one in search-output, since it wasn't properly testing for the presence of a trailing newline. --- test/json |4 test/search-output |4 +--- 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/test/json b/test/json index 0badb1d

[PATCH 05/25] fix trailing newlines in notmuch search

A previous commit to fix json formatting for null results (0b1ddc5f6652bde99d63d9d553777b3d926694cf) accidentally introduced a regression that removed trailing newlines for non-json output. (There wasn't a good test for this previously, but there is now). The problem is due to the fundamental dif

[PATCH 03/25] test: modify search-output test to use the new test_expect_equal_file function

These test now properly test for the presence of a newline at the end of all output. Right now some of these test will fail because the search output is currently broken to *not* produce proper newlines in some cases. --- test/search-output | 72 ++---

[PATCH 13/25] emacs: Use "message-cited-text" instead of "message-cited-text-face"

From: Pieter Praet (describe-face 'message-cited-text-face) > message-cited-text-face is an alias for the face `message-cited-text'. > This face is obsolete since 22.1; use `message-cited-text' instead. Signed-off-by: Pieter Praet Signed-off-by: Jameson Graef Rollin

[PATCH 10/25] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

ASCII code less than 32 with a question mark. Signed-off-by: Jameson Graef Rollins --- notmuch-search.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 69af617..530cecc 100644 --- a/notmuch-search.c +++ b/notmuc

[PATCH 19/25] emacs: fix notmuch-show-part-button to not include newline

This makes the button cleaner, so that it doesn't include the entire rest of the line that the button is on. --- emacs/notmuch-show.el | 29 + 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 6c498ab.

[PATCH 20/25] emacs: Don't always prompt for the "From" address when replying

From: Thomas Jost When replying, the From: address is already filled in by notmuch reply, so most of the time there is no need to prompt the user for it. --- emacs/notmuch-mua.el |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-m

[PATCH 22/25] test: fix test_expect_equal_file test to copy instead of mv test files

This is a pretty important fix to this test, so that it can be used to test against existing files, without deleting them in the case of test failure. --- test/test-lib.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 6a8cb98.

[PATCH 21/25] emacs: Cleaner interface when prompting for sender address

From: Thomas Jost Most of the time, every entry in the list of identities has the same user name part. It can then be filled in automatically, and the user can only be prompted for the email address, which makes the interface much cleaner. --- emacs/notmuch-mua.el | 33 +++-

[PATCH 17/25] avoid segfault when calling sanitize_string() on NULL

From: Daniel Kahn Gillmor Signed-off-by: Jameson Graef Rollins --- notmuch-search.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 530cecc..616fe68 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -116,6 +116,9

[PATCH 16/25] lib/message-file: plug three memleaks.

From: Anton Khirnov Signed-off-by: Jameson Graef Rollins --- lib/message-file.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/message-file.c b/lib/message-file.c index 7722832..99505c1 100644 --- a/lib/message-file.c +++ b/lib/message-file.c @@ -341,12

[PATCH 18/25] Fix search output sanitization test.

From: Austin Clements Previously, the test assumed the generated message would be assigned a specific thread ID; now it doesn't. Also, spelling fix. Signed-off-by: Jameson Graef Rollins --- test/search-output |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 15/25] Use message-field-value instead of message-fetch-field in FCC header setup.

eturns the From header value of the forwarded email. Message-field-value is the same as message-fetch-field, only narrows the buffer to the headers first. Signed-off-by: Jameson Graef Rollins --- emacs/notmuch-maildir-fcc.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) di

[PATCH 25/25] Fix stdout stream grabbing in format_part_content_text

The declaration of the GMimeStream pointer to stdout in format_part_content_text was somehow preventing subsequent printf calls from outputting to stdout if the output was redirected to a file. Scoping the declaration to the actual use of the stream pointer works around this problem. --- notmuch-

[PATCH 23/25] test: update emacs test to use test_expect_equal_file

This is a much cleaner way to do the emacs tests, since we're actually comparing output against existing files with expected output. We also won't miss any trailing newlines this way. And speaking of which, one of the expected output files was actually missing a trailing blank line that was actua

<    5   6   7   8   9   10   11   12   13   14   >