Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

On Thu, Sep 22, 2016 at 2:15 PM, Larry Gritz wrote: > OK, my stab at this is here: https://github.com/OpenImageIO/oiio/pull/1493 > > Please follow up comments on the approach on that PR, if you don't mind. > > It would be great for somebody to pull that patch on their end and give it > a try (wor

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

Yes, keep it as is. Jason and I are both still slapping our heads for missing the -a :) On Fri, Sep 23, 2016 at 3:10 PM, Larry Gritz wrote: > I *think* that --compression applies to all subimages, because it sets > some other variable, which is consulted when it's time to output anything. > It

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

I *think* that --compression applies to all subimages, because it sets some other variable, which is consulted when it's time to output anything. It doesn't work by traversing the subimages and setting attributes on each one. So, you're basically just using -a in this circumstance and don't need a

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

Ok, I missed seeing the "-a" in there even though it is way at the top :/ So I have to walk this back. We thought about this more after reading your post and there are a bunch of places I wouldn't necessarily want to set an attr on every single subimage: bit depth screen window display window ju

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

https://github.com/OpenImageIO/oiio/pull/1495 This makes sure that those attribute-setting operations apply to all subimages. On Thu, Sep 22, 2016 at 10:04 PM, Larry Gritz wrote: > Yes, I see your point. > > It looks like --compression will work on every part, but by default > --attrib does no

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

If its not explictly set, 45 will be used in IImImf. But Id have to check the code to see if dwaCompressionLevel gets explictly added if its omitted. My guess is that it isnt added automagically. On Thursday, September 22, 2016, Deke Kincaid wrote: > One more. When you don't set the compressio

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

Yes, I see your point. It looks like --compression will work on every part, but by default --attrib does not. oiiotool has a "-a" flag, which means "try to do all operations on all subimages", and many operations will only operate on the first subimage, if the -a flag is not used. (There are so m

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

um... is it required to set dwaCompressionLevel? No default in the library? OK, I will take no chances. Amending the PR to set to 45 if it's not set already (and one of the dwa compression modes is requested). On Thu, Sep 22, 2016 at 7:43 PM, Deke Kincaid wrote: > One more. When you don't set

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

One more. When you don't set the compression at all, the compression attr does not get set, so I'm not even sure if this is a "legal" dwa compressed file? Shouldn't we default to 45 if nothing is set? On Thu, Sep 22, 2016 at 7:03 PM, Deke Kincaid wrote: > One other follow up and also related t

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

One other follow up and also related to the PR. With a multipart EXR image, how do you set the compression on all parts? It is only setting it on part 0, none of the others are getting compressed. Can we have the --compression dwaa:45 in the above PR also work on every single part, not just the f

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

OK, my stab at this is here: https://github.com/OpenImageIO/oiio/pull/1493 Please follow up comments on the approach on that PR, if you don't mind. It would be great for somebody to pull that patch on their end and give it a try (works for me, but would be good to have somebody else confirm it me

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

#2 +1 On Thu, Sep 22, 2016 at 12:36 AM, Larry Gritz wrote: > 1. As Kevin points out, we can use something akin to Karl's mapping (I'll > find a cubic curve that maps these smoothly?) of quality's 0-100 scale into > settings for DWA compression quality. I don't know if that will give you a > "sm

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

Also agree on #2. On 09/21/2016 11:50 PM, Jep Hill wrote: I second the vote for #2 On Sep 21, 2016, at 9:59 AM, Deke Kincaid > wrote: I like #2. On Wed, Sep 21, 2016 at 9:36 AM, Larry Gritz > wrote: So in following the spirit o

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

test message -- ignore On Wed, Sep 21, 2016 at 2:50 PM, Jep Hill wrote: > I second the vote for #2 > > On Sep 21, 2016, at 9:59 AM, Deke Kincaid wrote: > > I like #2. > > On Wed, Sep 21, 2016 at 9:36 AM, Larry Gritz wrote: > >> So in following the spirit of OIIO's core mission to allow a singl

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

I second the vote for #2 On Sep 21, 2016, at 9:59 AM, Deke Kincaid wrote: > I like #2. > >> On Wed, Sep 21, 2016 at 9:36 AM, Larry Gritz wrote: >> So in following the spirit of OIIO's core mission to allow a single generic >> API to shield users from the gory details of each individual forma

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

I like #2. On Wed, Sep 21, 2016 at 9:36 AM, Larry Gritz wrote: > So in following the spirit of OIIO's core mission to allow a single > generic API to shield users from the gory details of each individual format > (as much as possible), I feel strongly that --quality should not magically > change

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

So in following the spirit of OIIO's core mission to allow a single generic API to shield users from the gory details of each individual format (as much as possible), I feel strongly that --quality should not magically change directions and scales for one format. If --quality 100 is "looks perfect"

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

I think I pulled that out of my rear end one day, so don't out too much stock in that mapping if it sounds sketchy. On Wednesday, September 21, 2016, Kevin Wheatley wrote: > Closest I've seen to a quality scale was this email from Karl > > https://lists.nongnu.org/archive/html/openexr-devel/2014

[Oiio-dev] oiiotool --quality for dwaa exr ignored

Yeah, I was going to say make it contextual -- so its basically an alias for dwaCompressionLevel for the DWAA/B case. On Wednesday, September 21, 2016, Deke Kincaid > wrote: > If the constraint of —quality is that it is always 0-100, then that is > going to be hard to map and would lead to con

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

Closest I've seen to a quality scale was this email from Karl https://lists.nongnu.org/archive/html/openexr-devel/2014-08/msg00049.html Kevin ___ Oiio-dev mailing list Oiio-dev@lists.openimageio.org http://lists.openimageio.org/listinfo.cgi/oiio-dev-ope

[Oiio-dev] oiiotool --quality for dwaa exr ignored

If the constraint of —quality is that it is always 0-100, then that is going to be hard to map and would lead to confusion(i.e. All other applications would use a different slider then oiio). Is it possible to make the quality slider more contextual to the compression rather then normalizing it to

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

maketx doesn't have a --quality command at all, primarily because we'd traditionally been using either lossless TIFF or OpenEXR for textures, and for neither of those did quality come into play. But recently we added support for TIFF-with-jpeg, and OpenEXR with DWAA compression has since come a

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

Yup, already mentioned that in my example :) On Tue, Sep 20, 2016 at 4:58 PM, Eric Tabellion < eric.tabell...@dreamworks.com> wrote: > You can try this instead, this worked for me in maketx: > > # For high quality use this > --attrib openexr:dwaCompressionLevel 45.0 > > # For meduim quality use t

Re: [Oiio-dev] oiiotool --quality for dwaa exr ignored

You can try this instead, this worked for me in maketx: # For high quality use this --attrib openexr:dwaCompressionLevel 45.0 # For meduim quality use that: --attrib openexr:dwaCompressionLevel 85.0 On Tue, Sep 20, 2016 at 3:11 PM, Deke Kincaid wrote: > Hi Larry > > We are trying to compress

[Oiio-dev] oiiotool --quality for dwaa exr ignored

Hi Larry We are trying to compress EXR files in OIIO with dwaa/dwab compression but currently this does not seem to directly hooked up to the --quality flag in oiiotool. No matter if you use --quality 10 or 100, the attr dwaCompressionLevel key never gets set and the file is exactly the same size