On Thu, 19 Aug 2021 18:39:08 GMT, Johan Vos wrote:
> We should probably add this to the release notes.
Good idea.
-
PR: https://git.openjdk.java.net/jfx11u/pull/30
9M2RV99hQ!dpO9UK8458NQKXiiWkGAxJV2D2wUpaj0Lj6CGeQEei1FoV7bgKcV_3q4Szn7X8UYHGUa$>
Am Fr., 30. Juli 2021 um 14:57 Uhr schrieb Kevin Rushforth
mailto:kevin.rushfo...@oracle.com>>:
>
> Now that JavaFX 17 is in RDP2, we can turn more attention to bug
fixes
> and enhancement r
;cost",
and have a willing contributor and sponsor (for contributors who are not
Committers), are more likely to make JavaFX 18.
-- Kevin
On 7/30/2021 5:56 AM, Kevin Rushforth wrote:
Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes
and enhancement requests for JavaF
On Tue, 17 Aug 2021 17:13:36 GMT, Kevin Rushforth wrote:
> Clean backport of HTTP/2. This is enabled by default only with running with
> JDK 12 or later.
>
> I have tested this with both JDK 11, where I verified that it HTTP/2 is not
> enabled, and JDK 15, where I verified
On Wed, 18 Aug 2021 14:49:00 GMT, Kevin Rushforth wrote:
> Clean backport to remove obsolete 3DViewer tests.
This pull request has now been integrated.
Changeset: 215aa17e
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/com
Clean backport to remove obsolete 3DViewer tests.
-
Commit messages:
- 8271230: Remove obsolete test classes and data files from 3DViewer sample
Changes: https://git.openjdk.java.net/jfx11u/pull/37/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=37=00
Issue:
On Mon, 16 Aug 2021 21:55:52 GMT, Kevin Rushforth wrote:
> As mentioned in the JBS bug report, this is needed to minimize gratuitous
> diffs in the native WebKit sources between mainline and jfx11u. These diffs
> can make it hard to see whether there is any substantive diff betwee
On Tue, 17 Aug 2021 17:59:50 GMT, Kevin Rushforth wrote:
> Clean backport of the fix to cherry pick GTK WebKit 2.32.3 changes, as a
> follow-on to the WebKit 612.1 update. Once PR #34 is integrated, I will
> rebase this branch on top of `master` (to pick up that fix), and take th
Clean backport of the fix to cherry pick GTK WebKit 2.32.3 changes, as a
follow-on to the WebKit 612.1 update. Once PR #34 is integrated, I will rebase
this branch on top of `master` (to pick up that fix), and take this out of
Draft state.
As an FYI, I tested this patch in my
Clean backport of the fix to allow WebKit to continue to build with VS 2017, as
a follow-on to the WebKit 612.1 update, so it is based off that branch. Once PR
#34 is integrated, I will rebase this branch on top of `master` (to pick up
that fix), and take this out of Draft state.
As an FYI, I
On Tue, 17 Aug 2021 17:39:55 GMT, Kevin Rushforth wrote:
> Clean backport of the fix to allow WebKit to continue to build with VS 2017,
> as a follow-on to the WebKit 612.1 update, so it is based off that branch.
> Once PR #34 is integrated, I will rebase this branch on top o
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote:
> Nearly clean backport of third-party update to WebKit 612.1. There was one
> minor conflict in one unit test file due to difference in context.
>
> As an FYI, I tested this patch in my
> [test-kcr-11.0.13](htt
Merge `jfx17` into `master`.
-
Commit messages:
- Merge jfx17
- 8272329: Cherry pick GTK WebKit 2.32.3 changes
- 8271484: Tree-/TableCell: NPE when accessing edit event from startEdit
- Merge
- 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent
libjfxmedia_qtkit
-
On Wed, 18 Aug 2021 11:58:36 GMT, Kevin Rushforth wrote:
> Merge `jfx17` into `master`.
This pull request has now been integrated.
Changeset: fdc88341
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx/commit/fdc88341f1df8fb9c99356ada54b25124b77ea6e
Stats: 693 li
On Tue, 17 Aug 2021 17:27:49 GMT, Kevin Rushforth wrote:
> Clean backport of third-party update to libxml2 2.9.12.
>
> As an FYI, I tested this patch in my
> [test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13)
> branch, which has the aggregate
On Tue, 17 Aug 2021 17:17:59 GMT, Kevin Rushforth wrote:
> Clean backport of fix to rename `VERSION` to `VERSION.txt` to fix build
> breakage on Xcode 12.5.
This pull request has now been integrated.
Changeset: ebc5926c
Author: Kevin Rushforth
URL:
https://git.openjdk.ja
On Tue, 17 Aug 2021 17:22:44 GMT, Kevin Rushforth wrote:
> Clean backport of third-party update to GStreamer 1.18.4.
>
> As an FYI, I tested this patch in my
> [test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13)
> branch, which has the aggregate
On Tue, 17 Aug 2021 12:43:52 GMT, Ambarish Rapte wrote:
> Change to update copyright year of files modified in 2021.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/605
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote:
> Nearly clean backport of third-party update to WebKit 612.1. There was one
> minor conflict in one unit test file due to difference in context.
>
> As an FYI, I tested this patch in my
> [test-kcr-11.0.13](htt
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote:
> Nearly clean backport of third-party update to WebKit 612.1. There was one
> minor conflict in one unit test file due to difference in context.
>
> As an FYI, I tested this patch in my
> [test-kcr-11.0.13](htt
Nearly clean backport of third-party update to WebKit 612.1. There was one
minor conflict in one unit test file due to difference in context.
As an FYI, I tested this patch in my
[test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13)
branch, which has the aggregate
Clean backport of third-party update to libxml2 2.9.12.
As an FYI, I tested this patch in my
[test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13)
branch, which has the aggregate set of patches for the following bugs:
Clean backport of third-party update to GStreamer 1.18.4.
As an FYI, I tested this patch in my
[test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13)
branch, which has the aggregate set of patches for the following bugs:
Clean backport of fix to rename `VERSION` to `VERSION.txt` to fix build
breakage on Xcode 12.5.
-
Commit messages:
- 8268915: WebKit build fails with Xcode 12.5
Changes: https://git.openjdk.java.net/jfx11u/pull/31/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=31=00
Clean backport of HTTP/2. This is enabled by default only with running with JDK
12 or later.
I have tested this with both JDK 11, where I verified that it HTTP/2 is not
enabled, and JDK 15, where I verified that it HTTP/2 is enabled.
As an FYI, I tested this patch in my
On Tue, 17 Aug 2021 17:13:36 GMT, Kevin Rushforth wrote:
> Clean backport of HTTP/2. This is enabled by default only with running with
> JDK 12 or later.
>
> I have tested this with both JDK 11, where I verified that it HTTP/2 is not
> enabled, and JDK 15, where I verified
On Mon, 16 Aug 2021 21:55:52 GMT, Kevin Rushforth wrote:
> As mentioned in the JBS bug report, this is needed to minimize gratuitous
> diffs in the native WebKit sources between mainline and jfx11u. These diffs
> can make it hard to see whether there is any substantive diff betwee
As mentioned in the JBS bug report, this is needed to minimize gratuitous diffs
in the native WebKit sources between mainline and jfx11u. These diffs can make
it hard to see whether there is any substantive diff between the two and also
can sometimes lead to merge conflicts.
In addition to the
On Mon, 16 Aug 2021 20:13:03 GMT, Ambarish Rapte wrote:
>> Cherry pick the GTK webkit 2.32.3 changes
>> https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html
>
> Ambarish Rapte has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 16 Aug 2021 21:23:56 GMT, Kevin Rushforth wrote:
> Clean backport of fix to add missing copyright headers. No changes other than
> comments.
This pull request has now been integrated.
Changeset: 1a021ed4
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/
Clean backport of fix to add missing copyright headers. No changes other than
comments.
-
Commit messages:
- 8209086: Some javafx.web files are missing GPLv2+Classpath copyright header
Changes: https://git.openjdk.java.net/jfx11u/pull/28/files
Webrev:
On Mon, 16 Aug 2021 17:37:09 GMT, Kevin Rushforth wrote:
> Clean backport of Mesa-3D third-party update.
This pull request has now been integrated.
Changeset: 330b4fad
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/commit/330b4fadb0f3b76f77f0338f26b9097960551
Clean backport of Mesa-3D third-party update.
-
Commit messages:
- 8262396: Update Mesa 3-D Headers to version 21.0.3
Changes: https://git.openjdk.java.net/jfx11u/pull/27/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=27=00
Issue:
On Fri, 13 Aug 2021 19:03:41 GMT, Ambarish Rapte wrote:
> Cherry pick the GTK webkit 2.32.3 changes
> https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html
Looks good. Tested on all platforms.
I left one question for you, but it's more out of curiosity.
On Mon, 28 Jun 2021 12:13:44 GMT, Nir Lisker wrote:
> Adds a directional light as a subclass of `LightBase`. I think that this is
> the correct hierarchy for it.
>
> I tried to simulate a directional light by putting a point light far away,
> but I got artifacts when the distance was large.
On Mon, 2 Aug 2021 16:53:08 GMT, Michael Strauß wrote:
>> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
>> well as the corresponding `:focus-visible` and `:focus-within` CSS
>> pseudo-classes.
>
> Michael Strauß has updated the pull request incrementally with one
On Sat, 3 Jul 2021 23:09:09 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
9M2RV99hQ!fkRdlKBh300gss2krEHXu3UBrH7WOoht8YhvBygI4oIQd5dXyA2dXSrcTpkY5GOP5IQU$>
for details.
P.S. Adding a `duplicatesStrategy` to the copy task also helps with
the issue.
--Abhinay
*From:* openjfx-dev on behalf of
Kevin Rushforth
*Sent:* Friday, August 13,
This seems like a reasonable enhancement to me.
CSS experts: can you think of any issues that we should be mindful of
when doing this?
-- Kevin
On 8/12/2021 12:49 PM, Abhinay Agarwal wrote:
Every now and then, I miss having the capability to (un)manage nodes in its
Parent via CSS. There
I still need to catch up on my email, since I still have the original
question in my queue.
The answer to the original query is that there is a known bug with ant
1.10.7 [1] that will cause this error. You can either use ant 1.10.5
(which is the one we specify in build.properties) or use ant
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal
wrote:
> JDK-8172095: Let Node.managed become CSS-styleable
Please start a new thread and reference that one. That thread asks for a new
property, but I think what you propose, which is to make the existing `managed`
property CSS styleable,
On Thu, 12 Aug 2021 17:09:46 GMT, Abhinay Agarwal
wrote:
> JDK-8172095: Let Node.managed become CSS-styleable
This will need at least a brief discussion on the openjfx-dev mailing list.
-
PR: https://git.openjdk.java.net/jfx/pull/602
On Wed, 11 Aug 2021 21:28:26 GMT, Nir Lisker wrote:
> Fixes documentation mistakes as noted in the JBS issue.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/601
On Wed, 11 Aug 2021 13:04:02 GMT, Kevin Rushforth wrote:
> Update the fix version to 11.0.13 for the start of a new release.
This pull request has now been integrated.
Changeset: 72df39f3
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/com
Update the fix version to 11.0.13 for the start of a new release.
-
Commit messages:
- 8270992: Change JavaFX release version in jfx11u to 11.0.13
Changes: https://git.openjdk.java.net/jfx11u/pull/26/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=26=00
Issue:
On 8/7/2021 11:56 AM, Pankaj Bansal wrote:
On Fri, 6 Aug 2021 20:44:23 GMT, Thiago Milczarek Sayao
wrote:
I will look at this. Meanwhile, could you please write an automated system test
for this?
Sure, I would provide it, but in the past drag and drop tests were not
possible. Any
support for Metal and Wayland in
JavaFX 18.
- Johan
On Fri, Jul 30, 2021 at 2:58 PM Kevin Rushforth
mailto:kevin.rushfo...@oracle.com>> wrote:
Now that JavaFX 17 is in RDP2, we can turn more attention to bug
fixes
and enhancement requests for JavaFX 18. It's the summ
, I am 100% ok with the list of issues Kevin mentioned that need to be
moved forward now.
Apart from that, I want to have support for Metal and Wayland in JavaFX 18.
- Johan
On Fri, Jul 30, 2021 at 2:58 PM Kevin Rushforth <
kevin.rushfo...@oracle.com>
wrote:
Now that JavaFX 17 is in RDP2,
On Tue, 10 Aug 2021 12:43:50 GMT, Kevin Rushforth wrote:
> Merge `jfx17` branch into `master`.
This pull request has now been integrated.
Changeset: 20079b13
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx/commit/20079b1340c966779f383a60e56c962f3d5ff5e2
Stats:
> Merge `jfx17` branch into `master`.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 20 additional commits
since the last revis
Merge `jfx17` branch into `master`.
-
Commit messages:
- Merge jfx17
- 8271485: Javadoc "Method Summary" table is misaligned if overridden JDK
method has {@inheritDoc} tag
- 8250590: Classes and methods in the javafx.css package are missing
documentation
The merge commit only
On Thu, 29 Jul 2021 16:18:24 GMT, Kevin Rushforth wrote:
> As noted in the JBS bug report, the javadoc-generated HTML table for a class
> is messed up if any method is overridden from a core JDK class and has the
> `{@inheritDoc}` tag. For example, the following taken from the
>
This looks interesting and useful. I'd like to hear from other
developers as well.
A few comments:
1. We might want to consider whether there is a better name (nothing
comes to mind at the moment)
2. This will almost certainly need to be a ConditionalFeature (since it
might not be
On Fri, 30 Jul 2021 00:42:30 GMT, Alexander Matveev
wrote:
> Removed code which loads nonexistent libjfxmedia_qtkit.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/597
Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes
and enhancement requests for JavaFX 18. It's the summer, so there may be
delays as some people are out at various times (including me), but I
would like to get some of the outstanding enhancement requests moving
over the
On Fri, 30 Jul 2021 06:23:59 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - fix review comments
> Merge `jfx17` branch into `master`.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 18 additional commits
since the last revis
On Fri, 30 Jul 2021 00:26:47 GMT, Kevin Rushforth wrote:
> Merge `jfx17` branch into `master`.
This pull request has now been integrated.
Changeset: a283ba3c
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx/commit/a283ba3c24befe9a359078855fe7d08e3bfafe6c
Stats: 9
Merge `jfx17` branch into `master`.
-
Commit messages:
- Merge jfx17
- 8212088: Missing copyright notices for property files
- 8271086: Block comments of form '/***' are treated as javadoc comments
- 8240640: [macos] Wrong focus behaviour with multiple Alerts
- 8271230: Remove
To: OpenJFX Developers
As a reminder, JavaFX 17 is now in Rampdown Phase Two (RDP2). [1]
P1-P2 bugs, and test or doc bugs of any priority, can be fixed during
RDP2. Explicit approval is needed for bug fixes (except for doc and test
fixes), and all enhancements to go in to the jfx17 branch.
On Thu, 29 Jul 2021 14:38:02 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - fix review comments
Two
On Thu, 29 Jul 2021 14:47:10 GMT, Ajit Ghaisas wrote:
> I have filed [JDK-8271485](https://bugs.openjdk.java.net/browse/JDK-8271485)
> to address this.
I just submitted PR #593 with a fix. It will also address the problem noted
above of overridden methods without additional documentation
On Thu, 29 Jul 2021 16:18:24 GMT, Kevin Rushforth wrote:
> As noted in the JBS bug report, the javadoc-generated HTML table for a class
> is messed up if any method is overridden from a core JDK class and has the
> `{@inheritDoc}` tag. For example, the following taken from the
>
As noted in the JBS bug report, the javadoc-generated HTML table for a class is
messed up if any method is overridden from a core JDK class and has the
`{@inheritDoc}` tag. For example, the following taken from the
On Thu, 29 Jul 2021 08:43:59 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - fix review comments
I
On Thu, 29 Jul 2021 08:43:59 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - fix review comments
> >
On Thu, 29 Jul 2021 07:17:45 GMT, Ajit Ghaisas wrote:
> I found few more such methods in javafx.css package using "find in files" in
> my editor and fixed them.
>
...
> * PseudoClassImpl.getPseudoClassName()
> * PseudoClassImpl.toString()
> * SimpleSelector.getPseudoclasses()
These three are
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo sh
On Thu, 29 Jul 2021 09:38:35 GMT, Ajit Ghaisas wrote:
> Wherever only @inheritDoc is used, we are having this corruption in final
> html documentation
I saw this problem with `@inheritDoc` yesterday as well, and was getting ready
to report it here, but then couldn't reproduce it with a clean
On Wed, 28 Jul 2021 22:05:00 GMT, Nir Lisker wrote:
> > I think `getProperty()` and `getConverter()` should be fixed in this PR.
>
> There could be more methods like that. Maybe the script should check
> specifically for a missing summary?
We just used the `javadoc` tool to find them, so
On Tue, 27 Jul 2021 12:44:58 GMT, Ajit Ghaisas wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8250590 - add missing @since tag
On Wed, 28 Jul 2021 09:37:17 GMT, Pankaj Bansal wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8250590 - add missing @since tag
>
> modules/javafx.graphics/src/main/java/javafx/css/Rule.java line 141:
>
>> 139:
On Wed, 28 Jul 2021 09:34:33 GMT, Nir Lisker wrote:
> I have spotted some missing docs:
>
> * `CompoundSelector` missing docs for methods overriden from `Object`.
I'm not too worried about the missing docs for overridden methods. Unless we
are overriding it in a way that needs to be
On Wed, 28 Jul 2021 13:08:28 GMT, Pankaj Bansal wrote:
> I am surprised that this does not need a CSR. It looks like too much bigger
> documentation change for not needing a CSR.
JavaFX doesn't impose the same requirement of needing a CSR for everything that
touches API documentation as does
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo sh
On Wed, 28 Jul 2021 17:34:32 GMT, Kevin Rushforth wrote:
> This PR adds missing copyright header blocks for several properties files,
> script files, and textual data files (e.g., fxml, css) that do not have them.
> Where feasible, all non-trivial textual files in the repo sh
This PR adds missing copyright header blocks for several properties files,
script files, and textual data files (e.g., fxml, css) that do not have them.
Where feasible, all non-trivial textual files in the repo should have a proper
copyright header.
## Notes to Reviewers
* This PR is targeted
On Thu, 22 Jul 2021 22:07:34 GMT, Kevin Rushforth wrote:
> This fix for [JDK-8271086](https://bugs.openjdk.java.net/browse/JDK-8271086)
> is part of a larger cleanup effort to find and fix places where we have
> missing or redundant API comments. See
> [JDK-82
On Mon, 26 Jul 2021 22:23:20 GMT, Alexander Matveev
wrote:
>> Fixed by not failing initialization if DSERR_NODRIVER is returned, which
>> will be return if device is not present at all. Fixed format initialization
>> even if DirectSound device was not created in case if audio device will
>>
(beyond the code
review). I'll send details tomorrow once RDP2 starts.
-- Kevin
On 3/30/2021 7:30 AM, Kevin Rushforth wrote:
I just noticed a copy/paste error:
> We plan to fork a jfx16 stabilization branch at RDP1.
That should be a "jfx17" branch.
-- Kevin
On 3/30/2021 7
, Michael Strauß wrote:
I should point out that the rest of the JavaFX framework did not
require a single code change as a result of the API changes. So while
some changes are binary incompatible, they are syntactically
transparent.
Am Mi., 28. Juli 2021 um 01:39 Uhr schrieb Kevin Rushforth
This will take a while to work through, and we will need to get general
consensus on the API changes.
I doubt I can support incompatible breaking changes in this area, given
how fundamental property and bindings are to JavaFX. I'll take a look,
but it is likely that the incompatible API
Looking at content bindings at the same time as regular bindings makes a
lot of sense, as long as the proposed changes don't result in the loss
of any well-defined, workable functionality (e.g., tightening the
restriction that a property P1 that is unidirectionally bound to another
property P2
On Tue, 27 Jul 2021 10:00:10 GMT, Ajit Ghaisas wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/converter/EffectConverter.java
>> line 83:
>>
>>> 81: /**
>>> 82: * Converter to convert DropShadow {@code Effect}
>>> 83: * @since 9
>>
>> Good catch on the `@since 9` tag.
I do something like this:
git fetch upstream pull/569/head:pr_569
Then you can checkout the "pr_569" branch. I typically will then merge
in the current upstream/master to test. If you don't have an "upstream"
remote you can instead:
git fetch https://github.com/openjdk/jfx
On Mon, 26 Jul 2021 18:04:22 GMT, Kevin Rushforth wrote:
>> This PR corrects/adds missing documentation for classes in javafx.css
>> package.
>
> modules/javafx.graphics/src/main/java/javafx/css/CssParser.java line 4724:
>
>> 4722:
>> 4723: /**
>> 47
On Mon, 26 Jul 2021 13:55:45 GMT, Ajit Ghaisas wrote:
> This PR corrects/adds missing documentation for classes in javafx.css package.
I applied the patch and confirm that there are no more "missing comments"
warnings for the `javafx.css` package.
The docs look reasonable in general. I did
On Sat, 24 Jul 2021 12:45:04 GMT, Kevin Rushforth wrote:
> Remove the obsolete `apps/samples/3DViewer/src/test` directory from the
> 3DViewer sample, including two test classes that don't run and a set of data
> files that won't load. This is a follow-on cleanup bug to
> [JDK-82
On Sat, 24 Jul 2021 02:59:52 GMT, Alexander Matveev
wrote:
> Fixed by not failing initialization if DSERR_NODRIVER is returned, which will
> be return if device is not present at all. Fixed format initialization even
> if DirectSound device was not created in case if audio device will arrive
On Sat, 24 Jul 2021 13:10:30 GMT, Kevin Rushforth wrote:
> Merge `jfx17` branch into `master`.
This pull request has now been integrated.
Changeset: 071828a2
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx/commit/071828a200faa9fc1bf22ff6098e5892e6426aa7
Stats:
Merge `jfx17` branch into `master`.
-
Commit messages:
- Merge jfx17
- 8270839: Remove deprecated implementation methods from Scene
- 8269374: Menu inoperable after setting stage to second monitor
- Merge
- 8270838: Remove deprecated protected access members from
On Sat, 24 Jul 2021 12:56:32 GMT, Michael Strauß wrote:
> I think it might be better to expand the scope of the issue to not only
> include the documentation changes, but also the implementation changes as
> discussed in this PR. In this case, I will mark this as a Draft PR and target
> it to
Remove the obsolete `apps/samples/3DViewer/src/test` directory from the
3DViewer sample, including two test classes that don't run and a set of data
files that won't load. This is a follow-on cleanup bug to
[JDK-8269259](https://bugs.openjdk.java.net/browse/JDK-8269259).
NOTE: this is targeted
On Fri, 23 Jul 2021 17:40:32 GMT, Pankaj Bansal wrote:
>> The bug is a regression as a result of fix done for JDK-8227366 and is
>> reproducible on Linux and Mac. This fix is being reverted in this change and
>> a new bug (JDK-8271054) has been created to redo the JDK-8227366
>>
>> An
On Fri, 23 Jul 2021 15:24:35 GMT, Pankaj Bansal wrote:
>> The bug is a regression as a result of fix done for JDK-8227366 and is
>> reproducible on Linux and Mac. This fix is being reverted in this change and
>> a new bug (JDK-8271054) has been created to redo the JDK-8227366
>>
>> An
On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal wrote:
> The bug is a regression as a result of fix done for JDK-8227366 and is
> reproducible on Linux and Mac. This fix is being reverted in this change and
> a new bug (JDK-8271054) has been created to redo the JDK-8227366
>
> An automated
On Tue, 20 Jul 2021 18:58:08 GMT, Kevin Rushforth wrote:
> Update boot JDK used to build JavaFX to JDK 16.0.2, which supersedes 16.0.1.
>
> NOTE: this is targeted to `jfx17`.
This pull request has now been integrated.
Changeset: d5401095
Author: Kevin Rushforth
URL:
On Mon, 19 Jul 2021 19:52:05 GMT, Pankaj Bansal wrote:
> The bug is a regression as a result of fix done for JDK-8227366 and is
> reproducible on Linux and Mac. This fix is being reverted in this change and
> a new bug (JDK-8271054) has been created to redo the JDK-8227366
>
> An automated
This fix for [JDK-8271086](https://bugs.openjdk.java.net/browse/JDK-8271086) is
part of a larger cleanup effort to find and fix places where we have missing or
redundant API comments. See
[JDK-8271083](https://bugs.openjdk.java.net/browse/JDK-8271083).
This fixes a long-standing problem dating
On Fri, 16 Jul 2021 17:53:21 GMT, Kevin Rushforth wrote:
> This removes following implementation methods in Scene by making them
> package-scope. They were previously deprecated for removal by
> [JDK-8270246](https://bugs.openjdk.java.net/browse/JDK-8270246):
>
>
&g
801 - 900 of 4743 matches
Mail list logo
