Hearing no objections, we will enable this for pull requests on the jfx
repo starting Tuesday, Feb 4.
-- Kevin
On 1/8/2020 11:34 AM, Kevin Rushforth wrote:
Does anyone strongly feel otherwise? If not, then I'll request the
Skara team to enable this feature.
-- Kevin
On 1/8/2020 11:26 AM,
Looks like an all-or-nothing situation - either any commit requires
re-approval or no commit requires re-approval. In this case, I would say
that all commits should require re-approval since it's the safer approach.
Having the issue stay in approved state after a significant change is much
worse
On Tue, 31 Dec 2019 18:19:29 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
Looks good now.
Since this isn't directly related to the PR in question, I'm starting a
new thread.
On 12/20/2019 7:22 PM, Philip Race wrote:
On 12/20/19, 7:04 PM, Scott Palmer wrote:
I'm not sure if I'me supposed to try to integrate now that I've made
that 10 -> 0 change, or if the new change resets the
On Sat, 21 Dec 2019 20:35:10 GMT, Phil Race wrote:
>> Link problem appears to just be a missing slash:
>> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
>
>> Link problem appears to just be a missing slash:
>> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
>
> Seems
On Sat, 21 Dec 2019 18:35:26 GMT, Scott Palmer wrote:
>> I'm not sure if I'me supposed to try to integrate now that I've made that 10
>> -> 0 change, or if the new change resets the need for review... Also, note
>> that the link in the bot msg for "project specific requirements" is giving
>>
On Sat, 21 Dec 2019 03:03:57 GMT, Scott Palmer wrote:
>> Interesting. I was only running the tests in graphics (gradle
>> :graphics:test) as when I run all the tests I always get this failure
>> (unrelated to anything I've changed):
>>
>>> Task :base:test
>>
>>
On 12/20/19, 7:04 PM, Scott Palmer wrote:
I'm not sure if I'me supposed to try to integrate now that I've made that 10 ->
0 change, or if the new change resets the need for review...
It shows ready, which surprises me.
Still learning skara .. I'd expect any change to reset as how can it
On Sat, 21 Dec 2019 02:50:54 GMT, Scott Palmer wrote:
>> The fix looks good now. There is one problem in the test (in
>> `StubTextLayout`) that needs to be fixed.
>
> Interesting. I was only running the tests in graphics (gradle
> :graphics:test) as when I run all the tests I always get this
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 78ddf12e: 8130738: Fixed test issue with
On Fri, 20 Dec 2019 23:43:53 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good now. There is one problem in the test (in
> `StubTextLayout`) that needs to be fixed.
Interesting. I was only running the tests in graphics (gradle
On Fri, 20 Dec 2019 23:44:07 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
The fix looks good now.
On Fri, 20 Dec 2019 22:18:29 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
-
Marked
On Fri, 20 Dec 2019 00:19:43 GMT, Kevin Rushforth wrote:
>> I was thinking of deferring the `apps/toys` demo to avoid any delays in
>> getting the new API into JavaFX 14. I have something for it, I just don't
>> want any feedback on it to hold up the review of this issue. Is there
>>
On Thu, 19 Dec 2019 13:48:11 GMT, Scott Palmer wrote:
>>
>
> I was thinking of deferring the `apps/toys` demo to avoid any delays in
> getting the new API into JavaFX 14. I have something for it, I just don't
> want any feedback on it to hold up the review of this issue. Is there
> anything
On Thu, 12 Dec 2019 21:51:56 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
>
I was thinking of deferring the `apps/toys` demo to avoid any delays in getting
the new API into JavaFX 14. I have something for it, I just don't want any
feedback on it
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
The pull request has been updated with 1 additional commit.
-
Added commits:
- f846ad6d: 8130738: Add tabSize property to Text and
On Sat, 14 Dec 2019 16:38:25 GMT, Kevin Rushforth wrote:
>> TextFlow isn't mentioned in the JavaDoc for any of the other Text properties
>> where the same rule applies. Perhaps that should be remedied with a
>> follow-up task?
>
> A follow-up issue would be fine.
I've created
On Fri, 13 Dec 2019 01:20:47 GMT, Scott Palmer wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
>> 494:
>>
>>> 493: * Values less than 1 are treated as 1. This value overrides the
>>> 494: * {@code tabSize} of contained {@link
On Fri, 13 Dec 2019 01:10:48 GMT, Scott Palmer wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1450:
>>
>>> 1449: private static final CssMetaData TAB_SIZE =
>>> 1450: new CssMetaData("-fx-tab-size",
>>> 1451:
On Fri, 13 Dec 2019 01:29:47 GMT, Phil Race wrote:
>> The terms "tab character" or "horizontal tab" refer to the ASCII tab
>> character itself. Since a tab character isn't a fixed number of spaces,
>> changing it to "size of a tab character" could be misleading. I'd be fine
>> with another
On Thu, 12 Dec 2019 22:02:53 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1273:
>>
>>> 1272: /**
>>> 1273: * The size of a tab stop in spaces.
>>> 1274: * Values less than 1 are treated as 1.
>>
>> "tab stop" seems to be an
On Thu, 12 Dec 2019 22:02:14 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
> 494:
>
>> 493: * Values less than 1 are treated as 1. This value overrides the
>> 494:
On Thu, 12 Dec 2019 21:41:12 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1883:
>
>> 1882: }
>> 1883: @Override protected void
On Thu, 12 Dec 2019 21:29:06 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1450:
>
>> 1449: private static final CssMetaData TAB_SIZE =
>> 1450: new
On Thu, 12 Dec 2019 21:40:34 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1882:
>
>> 1881: return StyleableProperties.TAB_SIZE;
>> 1882:
On Thu, 12 Dec 2019 21:16:32 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1273:
>
>> 1272: /**
>> 1273: * The size of a tab stop in spaces.
>> 1274: * Values less
On Thu, 12 Dec 2019 22:02:27 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
On Thu, 12 Dec 2019 21:52:05 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
On Thu, 12 Dec 2019 19:48:37 GMT, Scott Palmer wrote:
>> In that case, I recommend just doing the API get/set tests for `TextFlow`
>> without creating a `Scene` or `Stage`. This won't need anything from the
>> `StubToolkit`.
>
> In my attempts to address the issue with StubTextLayout I
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
The pull request has been updated with 1 additional commit.
-
Added commits:
- f99a3aa9: 8130738: Add tabSize property to Text and
On Thu, 12 Dec 2019 15:52:23 GMT, Kevin Rushforth wrote:
>> Good catch. Yes, please update it as you suggested.
>
> The following comment from @swpalmer sent to the openjfx-dev mailing list
> wasn't mirrored in the PR (I have alerted the Skara team about this).
>
>
> From: Scott Palmer
>
On Thu, 12 Dec 2019 15:19:39 GMT, Kevin Rushforth wrote:
>> I just noticed while updating the CSR that, while I mentioned it on the
>> mailing list, the fact that TextFlow's tabSize override that of any
>> contained Text nodes is not documented.
>> Shall I add to the javadoc for tabSize in
On Thu, 12 Dec 2019 15:15:38 GMT, Scott Palmer wrote:
>> I think a new `TextFlowTest.java` would be a good place for those tests.
>>
>> Our build is set up to use `ant` so if you want to wire it up to the build,
>> you'll need that (it should be as simple as having `ANT_HOME` set to
>>
On Wed, 11 Dec 2019 01:22:54 GMT, Kevin Rushforth wrote:
>> The unit tests that were already added to `TextTest.java` cover the new
>> methods on Text, but not in every combination. I'll add a couple more to
>> ensure all combinations are covered. `TextFlow` has no existing unit tests
>>
> On Dec 10, 2019, at 8:23 PM, Kevin Rushforth wrote:
...
>
> I think a new `TextFlowTest.java` would be a good place for those tests.
My first attempt at unit tests for TextFlow are failing. I believe the
StubTextLayout is not equipped to handle TextFlow. This may be a bigger job…
This
On Wed, 11 Dec 2019 01:04:15 GMT, Scott Palmer wrote:
>> As a follow-on point to the missing public method in TextFlow, can you add
>> unit tests for the API methods on both `Text` and `TextFlow`? A good way to
>> do that is to have a test for all combinations of setting the value via the
>>
On Tue, 10 Dec 2019 23:51:48 GMT, Kevin Rushforth wrote:
>>> Should this PR also add a tabSize property to controls such as TextArea? Or
>>> should that be a different PR after this one is merged?
>>
>> This would need to be a new enhancement and would first need to be discussed
>> on the
On Wed, 27 Nov 2019 10:51:10 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1895:
>>
>>> 1894: }
>>> 1895: @Override public void set(int v) { super.set((v <
>>> 1) ? 1 : v); }
>>> 1896:
On Tue, 10 Dec 2019 18:54:08 GMT, Kevin Rushforth wrote:
>> Overall this looks good to me with one "must fix" API issue and one
>> additional minor comment.
>>
>> In addition to the automated unit test, it might be nice to have a simple
>> app (in `apps/toys`) with a slider to control the tab
On Tue, 10 Dec 2019 18:37:50 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> Overall this looks good to me with one "must fix" API issue and one
> additional minor comment.
>
> In addition to the automated unit test, it might be nice to have a
On Tue, 10 Dec 2019 18:38:04 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
Overall this looks good
The pull request has been updated with additional changes.
Added commits:
- af959665: 8130738: Add tabSize property to Text and TextFlow
Changes:
- all: https://git.openjdk.java.net/jfx/pull/32/files
- new: https://git.openjdk.java.net/jfx/pull/32/files/254c40de..af959665
On Wed, 27 Nov 2019 01:30:22 GMT, Kevin Rushforth wrote:
> On Wed, 27 Nov 2019 01:17:42 GMT, Scott Palmer wrote:
>
>> On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote:
>>
>>> On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote:
>>>
On Thu, 7 Nov 2019 14:56:58 GMT, Kevin
On Wed, 27 Nov 2019 01:17:42 GMT, Scott Palmer wrote:
> On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote:
>
>> On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote:
>>
>>> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote:
>>>
On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer
On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote:
> On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote:
>
>> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote:
>>
>>> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote:
>>>
Added tabSize property to Text and TextFlow and
46 matches
Mail list logo
