Request to bump JDK-8220272 priority

2019-04-05 Thread Thiago Milczarek Sayao
Hi, Is it possible to bump up the JDK-8220272 priority? https://bugs.openjdk.java.net/browse/JDK-8220272 We are building a Point of Sale application in OpenJfx for Brazilian Pharmacy Retail. This bug often change the order or windows, so top modal windows shows behind it's parent and users

RE: Request to bump JDK-8220272 priority

2019-04-07 Thread Thiago Milczarek Sayao
de Thiago Milczarek Sayao Enviado: sexta-feira, 5 de abril de 2019 09:54 Para: openjfx-dev@openjdk.java.net Assunto: Request to bump JDK-8220272 priority Hi, Is it possible to bump up the JDK-8220272 priority? https://bugs.openjdk.java.net/browse/JDK-8220272 We are building a Point of Sale

Re: Call for IntelliJ IDEA user help

2019-04-07 Thread Thiago Milczarek Sayao
Hi Diego, I have downloaded the sources and imported the project with the "Import project from external model" -> Gradle. I am able to build it in intellij from the gradle tab (openjdk-jfx -> Tasks -> build -> build). I have used Sdkman to install gradle 5.3.1 and ant. I have used Ubuntu

RE: Request to bump JDK-8220272 priority

2019-04-07 Thread Thiago Milczarek Sayao
s somehow depending on event order. On my work machine the result varies, but mostly it shows the bug. On my home machine (which is newer and much more powerful) it *always* shows the bug. De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: domingo, 7 de abril de 2019 17:49 Para: openjf

JDK-8220272: Found the problem + possible fix

2019-04-14 Thread Thiago Milczarek Sayao
* THE PROBLEM * In GlassApplication.cpp, the GDK_FOCUS_CHANGE event gets called from the last window to the first on my setup (I suspect "out-of-order" on some setups and even occasionally in the expected order). So the code to keep the latest enabled window fails (refering to WindowStage.java

RE: FxApplicationThread usage with

2019-04-16 Thread Thiago Milczarek Sayao
If you do a database (or any I/O intensive task that blocks) the call should be on a Task or Service (which contains a Task). You can bind to the task return value directly, threads will be handled correctly. For non I/O intensive tasks you can set values directly. If you do I/O intensive

JDK-8212060: Found the problem - will try to fix

2019-04-16 Thread Thiago Milczarek Sayao
This bug affects Linux - the Window appears somewhere on the screen and then moves to de center. The moving is a visible glitch. * The cause * on glass_window.cpp: void WindowContextTop::request_focus() { gtk_window_present(GTK_WINDOW(gtk_widget)); } This code executes before the

RE: Can Javafx cursor be disabled?

2019-05-31 Thread Thiago Milczarek Sayao
If you are using X.org, the cursor is controlled by X, so I would look for a X configuration to disable cursor. https://unix.stackexchange.com/questions/346903/can-i-remove-the-mouse-pointer-entirely-from-x De: openjfx-dev em nome de Dell Green Enviado:

RE: Can Javafx cursor be disabled?

2019-06-01 Thread Thiago Milczarek Sayao
Just realized you might be using Monocle. So it might be handling the cursor. Don't know how to hide it.. De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: sábado, 1 de junho de 2019 19:18 Para: openjfx-dev@openjdk.java.net Assunto: RE: Can Javafx

RE: Can Javafx cursor be disabled?

2019-06-01 Thread Thiago Milczarek Sayao
Para: openjfx-dev@openjdk.java.net Assunto: RE: Can Javafx cursor be disabled? Thanks for that, good to know. I should of mentioned that we are not using X, but using framebuffer instead Message: 2 Date: Fri, 31 May 2019 14:45:11 + From: Thiago Milczarek Sayao To: "openjf

How to run Ensemble8?

2019-06-03 Thread Thiago Milczarek Sayao
How do I run Ensemble8 from source, using the libs from the source build? Is there a gradle task for that (could not find one - also not a gradle expert)? Thanks!

RE: Call for testing: Drag and Drop on Linux

2019-06-10 Thread Thiago Milczarek Sayao
will look into it (on the patch that got integrated). How much time we have until 13 release? Thanks. De: Kevin Rushforth Enviado: segunda-feira, 10 de junho de 2019 17:39 Para: Thiago Milczarek Sayao; openjfx-dev@openjdk.java.net Assunto: Re: Call for testing: Drag and Drop on

RE: Call for testing: Drag and Drop on Linux

2019-06-10 Thread Thiago Milczarek Sayao
to fix it without success (for now). Posted question here: https://discourse.gnome.org/t/dnd-window-getting-in-the-way-of-dnd-events/1141 De: Kevin Rushforth Enviado: segunda-feira, 10 de junho de 2019 19:00 Para: Thiago Milczarek Sayao; openjfx-dev

RE: Call for testing: Drag and Drop on Linux

2019-06-11 Thread Thiago Milczarek Sayao
: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: segunda-feira, 10 de junho de 2019 14:15 Para: openjfx-dev@openjdk.java.net Assunto: Call for testing: Drag and Drop on Linux Dear Linux Users, I did some modifications on DND to work better with Linux: https://github.com/javafxports/openjdk

Possible bug on linux + gnome (ubuntu 18.04)

2019-06-19 Thread Thiago Milczarek Sayao
Could anyone confirm this? Run the sample below, click the "Run" button and then close the "Owner Stage". On my machine, gnome shell crashes, sometimes X crashes. import javafx.application.Application; import javafx.scene.Scene; import javafx.scene.control.Button; import

RFR JDK-8226537: gnome-shell crashes when closing a multi-level stage initOwner()

2019-06-21 Thread Thiago Milczarek Sayao
Please, review the following: https://github.com/javafxports/openjdk-jfx/pull/506 https://bugs.openjdk.java.net/browse/JDK-8226537

Call for testing: Drag and Drop on Linux

2019-06-10 Thread Thiago Milczarek Sayao
Dear Linux Users, I did some modifications on DND to work better with Linux: https://github.com/javafxports/openjdk-jfx/pull/490 Benefits: * Works on wayland * Works across gtk2 and gtk3 with little code differences * Works on scenebuilder (with gtk3 - currently it falls back to

Findings on JDK-8211302

2019-05-13 Thread Thiago Milczarek Sayao
Hello, I have been looking into JDK-8211302. https://bugs.openjdk.java.net/browse/JDK-8211302 Did not find a solution, but the problem is because gdk_drag_context_get_selected_action(event->context) is returning ZERO. That's also why the cursor does not update on the drop location. Subsequent

RE: Findings on JDK-8211302

2019-05-13 Thread Thiago Milczarek Sayao
nda-feira, 13 de maio de 2019 10:38 Para: Thiago Milczarek Sayao; openjfx-dev@openjdk.java.net Assunto: RE: Findings on JDK-8211302 Hello Thiago, This solution was proposed by one of the engineers in Oracle sometime back and we have tested it. This does not seem to solve the issue. If you wish to

RE: Findings on JDK-8211302

2019-05-13 Thread Thiago Milczarek Sayao
Run it with -Djdk.gtk.version=2 If the problem stops, it's related. De: Magosányi Árpád Enviado: segunda-feira, 13 de maio de 2019 10:53 Para: Thiago Milczarek Sayao; openjfx-dev@openjdk.java.net Assunto: Re: Findings on JDK-8211302 Could this be related? https

RE: Findings on JDK-8211302

2019-05-13 Thread Thiago Milczarek Sayao
ers. De: Pankaj Bansal Enviado: segunda-feira, 13 de maio de 2019 10:59 Para: Thiago Milczarek Sayao; openjfx-dev@openjdk.java.net Assunto: RE: Findings on JDK-8211302 I think problem starts even before this as process_dnd_source_mouse_release is called when we release the mouse after d

RE: Findings on JDK-8211302

2019-05-14 Thread Thiago Milczarek Sayao
Fix in progress: https://github.com/tsayao/openjdk-jfx/pull/5 De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: terça-feira, 14 de maio de 2019 13:25 Para: openjfx-dev@openjdk.java.net Assunto: RE: Findings on JDK-8211302 Found the problem! Managed

RE: Ideas for future development

2019-05-23 Thread Thiago Milczarek Sayao
For 2 I use spring boot (together with javafx). On the "business logic" module I use other technologies such as JPA, Spring Boot JPA, ... De: openjfx-dev em nome de Krzysztof Gorczowski Enviado: quinta-feira, 23 de maio de 2019 16:13 Para:

RE: Findings on JDK-8211302

2019-05-14 Thread Thiago Milczarek Sayao
} De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: segunda-feira, 13 de maio de 2019 22:28 Para: Pankaj Bansal; openjfx-dev@openjdk.java.net Assunto: RE: Findings on JDK-8211302 Did further investigation... I think the problem lies on Gdk mouse motion

How do I find out why SceneBuilder is not recognizing my control?

2019-04-30 Thread Thiago Milczarek Sayao
When I load a .jar in SceneBuilder, some controls are recognized, some are not. How do I find out why some are ignored? Thanks.

RFR: JDK-8197536: TableView, ListView: unexpected scrolling behaviour on up/down keys

2019-05-02 Thread Thiago Milczarek Sayao
https://bugs.openjdk.java.net/browse/JDK-8197536 https://github.com/javafxports/openjdk-jfx/pull/460

RFR: JDK-8193502: Fix DialogPane wrong height calculation (and possible some other size related issues)

2019-04-26 Thread Thiago Milczarek Sayao
Please, review the following: https://github.com/javafxports/openjdk-jfx/pull/456 https://bugs.openjdk.java.net/browse/JDK-8193502 Thanks.

RFR: JDK-8220272: Fix gtk window event order

2019-04-23 Thread Thiago Milczarek Sayao
https://bugs.openjdk.java.net/browse/JDK-8220272 https://github.com/javafxports/openjdk-jfx/pull/445 (Received confirmation on my OCA from Oracle)

RFR: JDK-8212060: Fix Window show and then move glitch

2019-04-23 Thread Thiago Milczarek Sayao
https://github.com/javafxports/openjdk-jfx/pull/446 https://bugs.openjdk.java.net/browse/JDK-8212060

RFR: JDK-8210973: Set the focus to the owner window when current window is closed

2019-04-23 Thread Thiago Milczarek Sayao
https://github.com/javafxports/openjdk-jfx/pull/451 https://bugs.openjdk.java.net/browse/JDK-8210973

RFR: JDK-8222214: Fix TableView content disappearing on user pressing UP

2019-04-23 Thread Thiago Milczarek Sayao
https://github.com/javafxports/openjdk-jfx/pull/450 https://bugs.openjdk.java.net/browse/JDK-814

JDK-8222214, JDK-8210973

2019-04-22 Thread Thiago Milczarek Sayao
Did those two fixes: JDK-814: Fix TableView content disappearing on user pressing UP  https://github.com/javafxports/openjdk-jfx/pull/450 JDK-8210973: Set the focus to the owner window when current window is closed https://github.com/javafxports/openjdk-jfx/pull/451 Will probably work on

RFR: JDK-8227366: Wrong stage gets focused after modal stage creation

2019-07-31 Thread Thiago Milczarek Sayao
Please, review (and remove WIP): https://github.com/javafxports/openjdk-jfx/pull/520 https://bugs.openjdk.java.net/browse/JDK-8227366 Thanks.

Building on windows

2019-08-03 Thread Thiago Milczarek Sayao
Hi, I have followed the instructions on: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows When running ./gradlew.bat on cygwin I get: > FAIL: WINSDK_DIR not defined My version is 14.16.27012. Thanks.

Help for fixing JDK-8227366

2019-07-28 Thread Thiago Milczarek Sayao
Hi, I have been investigating: https://bugs.openjdk.java.net/browse/JDK-8227366 The problem is the focus event gets fired for all windows when a window is closed, so it messes up with "last window" tracking. It also causes unnecessary events. On com.sun.javafx.tk.quantum.GlassStage:

RE: Building on windows

2019-08-05 Thread Thiago Milczarek Sayao
directory where RC.exe lives. So it > is hard coded. Might be a problem. I never hit this problem. - Nir On Mon, Aug 5, 2019 at 4:26 AM Thiago Milczarek Sayao mailto:thiago.sa...@clamed.com.br>> wrote: Managed to get past the error by updating the source tree. Now I'm getting this: > FAIL: c

RE: Building on windows

2019-08-04 Thread Thiago Milczarek Sayao
ers. De: openjfx-dev em nome de Thiago Milczarek Sayao Enviado: sábado, 3 de agosto de 2019 19:41 Para: openjfx-dev@openjdk.java.net Assunto: Building on windows Hi, I have followed the instructions on: https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Wind

Re: RFR: 8225571: Port DND source to use GTK instead of GDK

2019-10-02 Thread Thiago Milczarek Sayao
On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: > On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao > wrote: > >> https://bugs.openjdk.java.net/browse/JDK-8225571 >> >> To run tests (on the root of the source tree): >> ./gradlew apps >

RFR: 8225571: Port DND source to use GTK instead of GDK

2019-10-02 Thread Thiago Milczarek Sayao
https://bugs.openjdk.java.net/browse/JDK-8225571 To run tests (on the root of the source tree): /gradlew apps java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor java

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Thiago Milczarek Sayao
On Thu, 14 Nov 2019 14:35:28 GMT, Alexander Scherbatiy wrote: > On Thu, 14 Nov 2019 14:35:27 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy >> wrote: >> >>> Allow IDEA to correctly detect Git version control system when opening JFX >>> project. >>>

RE: JavaFX-Bugs on GraalVM 19.3 (Java 11)

2019-11-21 Thread Thiago Milczarek Sayao
Well, GraalVM page says it's production ready. By production ready I understand something way beyond "Hello, FX". Although, I would not expert perfection, since it's new technology. The blue text also happens on my machine, running Linux. Probably a bug on graalvm, as it does not happen with

RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-09 Thread Thiago Milczarek Sayao
https://bugs.openjdk.java.net/browse/JDK-8232811 This one was hard to tackle. ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest - Commits: - 338bedbe: Fix mistake - a02894d6: Fix JDK-8232811 -

Minor code changes that aren't necessarily bugs

2019-12-09 Thread Thiago Milczarek Sayao
While going across the source code I have noticed some code that might be incorrect , such as: - WindowStage.setScene() has a call to requestFocus() I might be missing something, but I think it does not belong there because the scene is usually set before show(), and while it may be set after

Questions about glass linux implementation

2019-12-09 Thread Thiago Milczarek Sayao
Well, git blames Antem Ananiev - not sure you're around this list. Question 1 - Why can't we use gtk_window_set_resizable () ? Question 2 - Why do we keep separated geometry and not use gtk directly? Thanks.

Re: [Rev 01] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-09 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest The pull request has been updated with 1 additional commit. -

Re: [Rev 03] RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-10 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >

Re: [Rev 01] RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-10 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >

Re: [Rev 02] RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-10 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >

How can a stage decoration change?

2019-12-17 Thread Thiago Milczarek Sayao
Hi. Window.setBounds() doc specifies: * Gravity values specify how to correct window location if only its size * changes (for example when stage decorations are added). User initiated * resizing should be ignored and must not influence window location through * this mechanism. How can I test

RE: How can a stage decoration change?

2019-12-17 Thread Thiago Milczarek Sayao
a decorated Stage is created, the window might be initially created and then the decorations added in a second step. -- Kevin On 12/17/2019 8:34 AM, Thiago Milczarek Sayao wrote: > Hi. > > Window.setBounds() doc specifies: > > > * Gravity values specify how to correct window lo

Re: [Rev 04] RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-12 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8225571 > > To run tests (on the root of the source tree): > ./gradlew apps > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar > dragdrop.DragDropWithControls > java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >

Re: RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-11 Thread Thiago Milczarek Sayao
On Wed, 11 Dec 2019 18:43:23 GMT, Kevin Rushforth wrote: >> I don't get an assertion error on Oracle Linux 7.7 -- so far only on Ubuntu >> 16.04. I will resume reviewing once you restore the `DRAG_DONE` behavior. > > With your latest patch, which reverts the changes to `GtkDnDClipboard.java`,

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-09 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest The pull request has been updated with 1 additional commit. -

Re: RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-10 Thread Thiago Milczarek Sayao
On Tue, 10 Dec 2019 16:13:06 GMT, Kevin Rushforth wrote: >> Just a reminder to take a look when time allows. > > I'm starting to look at this. I see at least one behavioral difference that > will need to be addressed. With the existing implementation, if I drag / drop > onto a target that set

Re: RFR: 8225571: Port DND source to use GTK instead of GDK

2019-12-02 Thread Thiago Milczarek Sayao
On Fri, 4 Oct 2019 23:03:00 GMT, Kevin Rushforth wrote: > On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth wrote: > >> On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao >> wrote: >> >>> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote: >>

RE: How can a stage decoration change?

2019-12-18 Thread Thiago Milczarek Sayao
file a bug and provide a PR when it's ready and pass the tests. Cheers. De: Kevin Rushforth Enviado: terça-feira, 17 de dezembro de 2019 18:49 Para: Thiago Milczarek Sayao ; openjfx-dev@openjdk.java.net Assunto: Re: How can a stage decoration change? In that case, I'

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-19 Thread Thiago Milczarek Sayao
On Tue, 17 Dec 2019 21:37:34 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java > line 63: > >> 62: @Test(timeout = 15000) >> 63: public void

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-19 Thread Thiago Milczarek Sayao
On Thu, 19 Dec 2019 14:29:39 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1062: > >> 1061: geometry.final_height.type = BOUNDSTYPE_CONTENT; >> 1062: } >> 1063:

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-19 Thread Thiago Milczarek Sayao
On Thu, 19 Dec 2019 14:13:47 GMT, Ambarish Rapte wrote: >> The pull request has been updated with 1 additional commit. > > tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java > line 64: > >> 63: public void dialogWithOwnerSizingTest() throws Exception

Re: [Rev 03] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-19 Thread Thiago Milczarek Sayao
> https://bugs.openjdk.java.net/browse/JDK-8232811 > > This one was hard to tackle. > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest The pull request has been updated with 2 additional commits. -

Re: [Rev 02] RFR: 8232811: Dialog's preferred size no longer accommodates multi-line strings

2019-12-19 Thread Thiago Milczarek Sayao
On Tue, 17 Dec 2019 23:01:51 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java > line 124: > >> 123: >> 124:

Re: [Rev 19] RFR: 8236651: Simplify and update glass gtk backend

2020-02-10 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 20] RFR: 8236651: Simplify and update glass gtk backend

2020-02-10 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 21] RFR: 8236651: Simplify and update glass gtk backend

2020-02-10 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

RE: No screen coordinates for DRAG_DONE events

2020-02-12 Thread Thiago Milczarek Sayao
Dirk, Which platform are you using? (Windows, Linux, Mac) (Will take a look if Linux) Thanks. De: openjfx-dev em nome de Dirk Lemmermann Enviado: segunda-feira, 10 de fevereiro de 2020 13:21 Para: OpenJFX Assunto: No screen coordinates for DRAG_DONE events

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-03-03 Thread Thiago Milczarek Sayao
On Thu, 13 Feb 2020 23:56:42 GMT, Kevin Rushforth wrote: >> **Code Changes** >> >> * glass_window.cpp / glass_window.h >> * Removed WindowContextPlug and WindowContextChild (that were used for >> applets / web start) and moved everything to >> one class named WindowContext (since

Re: [Rev 14] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-23 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-23 Thread Thiago Milczarek Sayao
On Tue, 14 Jan 2020 11:30:49 GMT, Thiago Milczarek Sayao wrote: >> I understand. Will do that when the code works 100%. I have submitted the PR >> to avoid duplicated efforts and let people test it (if anyone is willing). > > Sizing and positioning completed and fairly test

Re: [Rev 15] RFR: 8236651: Simplify and update glass gtk backend

2020-01-29 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-01-29 Thread Thiago Milczarek Sayao
On Tue, 28 Jan 2020 16:59:27 GMT, Thiago Milczarek Sayao wrote: >> Sizing and positioning completed and fairly tested. >> >> Will look into mouse grabbing. > > To anyone willing to test this, here is a binary test-release for linux: > > https://github.com/tsay

Re: [Rev 16] RFR: 8236651: Simplify and update glass gtk backend

2020-01-29 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 17] RFR: 8236651: Simplify and update glass gtk backend

2020-01-29 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-02-03 Thread Thiago Milczarek Sayao
On Wed, 29 Jan 2020 12:16:49 GMT, Thiago Milczarek Sayao wrote: >> To anyone willing to test this, here is a binary test-release for linux: >> >> https://github.com/tsayao/jfx/releases/tag/test-glass-gtk > > It's ready for an initial look. > > If anyone has

Re: [Rev 18] RFR: 8236651: Simplify and update glass gtk backend

2020-02-03 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-28 Thread Thiago Milczarek Sayao
On Tue, 14 Jan 2020 11:30:49 GMT, Thiago Milczarek Sayao wrote: >> I understand. Will do that when the code works 100%. I have submitted the PR >> to avoid duplicated efforts and let people test it (if anyone is willing). > > Sizing and positioning completed and fairly test

Re: [Rev 22] RFR: 8236651: Simplify and update glass gtk backend

2020-02-11 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 23] RFR: 8236651: Simplify and update glass gtk backend

2020-02-11 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 24] RFR: 8236651: Simplify and update glass gtk backend

2020-02-11 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 25] RFR: 8236651: Simplify and update glass gtk backend

2020-02-14 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 27] RFR: 8236651: Simplify and update glass gtk backend

2020-02-15 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 06] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-08 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 09] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-11 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 08] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-11 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 10] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-12 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

RE: [Rev 08] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-13 Thread Thiago Milczarek Sayao
ne is willing to test, or take a look. I need to do more testing on: * Mouse grabs to mimic windows behavior; * Native _setBackground call Any pointers on uses cases for this is appreciated. Cheers. De: openjfx-dev em nome de Thiago Milczarek Sayao En

Re: [Rev 11] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-13 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 13] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-22 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

RE: Correct branch for PR?

2020-01-17 Thread Thiago Milczarek Sayao
AFAIK, use master. They will decide to backport to a point release or not. De: openjfx-dev em nome de Robert Lichtenberger Enviado: sexta-feira, 17 de janeiro de 2020 04:29 Para: openjfx-dev@openjdk.java.net Mailing Assunto: Correct branch for PR? I have a

Re: [Rev 07] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-09 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

RE: Maximized undecorated stage

2020-01-13 Thread Thiago Milczarek Sayao
I have fixed it on Linux: https://github.com/openjdk/jfx/pull/77 Can be ported to the current code: void WindowContext::set_maximized(bool maximize) { is_maximized = maximize; if (maximize) { // enable the functionality GdkWMFunction wmf =

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-14 Thread Thiago Milczarek Sayao
On Mon, 6 Jan 2020 22:57:31 GMT, Thiago Milczarek Sayao wrote: >> This sort of enhancement needs to be discussed on the openjfx-dev mailing >> list first. While the WIP PR might be used to illustrate what you have in >> mind to propose, it is premature to actually review

Linux Glass - WindowContextChild and WindowContextPlug

2019-12-31 Thread Thiago Milczarek Sayao
Does anyone knows the context of use of WindowContextChild and WindowContextPlug on the linux glass implementation? File: glass_window.cpp They seem to be never called. Thanks.

RE: Linux Glass - WindowContextChild and WindowContextPlug

2020-01-02 Thread Thiago Milczarek Sayao
em nome de Thiago Milczarek Sayao Enviado: terça-feira, 31 de dezembro de 2019 16:50 Para: openjfx-dev@openjdk.java.net Assunto: Linux Glass - WindowContextChild and WindowContextPlug Does anyone knows the context of use of WindowContextChild and WindowContextPlug on the linux glass

Re: [Rev 02] RFR: 8236651: Simplify and update glass gtk backend

2020-01-05 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

RFR: 8236651: Simplify and update glass gtk backend

2020-01-05 Thread Thiago Milczarek Sayao
This proposed change does the following: - Ports DND target to use GTK reducing code size and adding extra text / image formats (such as .gif); - Use gtk signals instead of gdk events (also to reduce code size); - Simplifies geometry (sizing/positioning) with a more straightforward code (less

Re: [Rev 03] RFR: 8236651: Simplify and update glass gtk backend

2020-01-06 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: 8236651: Simplify and update glass gtk backend

2020-01-06 Thread Thiago Milczarek Sayao
On Mon, 6 Jan 2020 00:28:14 GMT, Thiago Milczarek Sayao wrote: > This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to r

Re: [Rev 04] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-06 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-06 Thread Thiago Milczarek Sayao
On Mon, 6 Jan 2020 22:41:07 GMT, Kevin Rushforth wrote: >>> Please, mark it as WIP. >> >> You can do this by editing the title and adding `WIP: ` as a prefix. > > This sort of enhancement needs to be discussed on the openjfx-dev mailing > list first. While the WIP PR might be used to

Re: [Rev 05] RFR: WIP: 8236651: Simplify and update glass gtk backend

2020-01-06 Thread Thiago Milczarek Sayao
> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

  1   2   3   >