Re: [Openocd-development] [PATCH] Update ep93xx and at91rm9200 drivers

2010-09-30 Thread Zach Welch
during the command handling upgrade, because I could not compile them and began to question whether anyone else could either. Thanks for submitting a patch to keep them alive. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743

[Openocd-development] Rough OpenOCD Plan

2010-09-27 Thread Zach Welch
-development list in the hope of generating useful feedback, but it requires subscribing to post (last I checked). Sorry for the bad netiquette. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743 ___ Openocd-development mailing list Openocd

Re: [Openocd-development] Rough OpenOCD Plan

2010-09-27 Thread Zach Welch
as it should be. I simply can't stand 400 line functions. That's Just Wrong. However, they did derive from my effort to grok MEM-AP ROM Tables, so I suppose there is a fair connection to my intended work. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743

Re: [Openocd-development] Generic support for named and anonymous pipes

2010-09-27 Thread Zach Welch
on the existing patches. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743 ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] Rough OpenOCD Plan

2010-09-27 Thread Zach Welch
On 09/27/2010 07:12 AM, John Rigby wrote: On Mon, Sep 27, 2010 at 1:05 AM, Zach Welch zwe...@codesourcery.com wrote: ... Last week, I started testing my BeagleBoard with OpenOCD, so I have begun trying to validate and improve the Cortex-A8 support. Indeed, I have already committed a minor

Re: [Openocd-development] Generic support for named and anonymous pipes

2010-09-27 Thread Zach Welch
deprecation warning and plan to remove it after a couple of releases. This will allow any tools that use it to continue working as expected. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743 ___ Openocd-development mailing list

Re: [Openocd-development] [PATCH] Skip halt check in cortex_a8_mmu

2010-09-24 Thread Zach Welch
syntax for 'mww' and friends. I will commit this new patch sometime soon, barring objections. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743 From 3f0a1129db69a9cc11dc2c37c9f0cd3b6fda22c2 Mon Sep 17 00:00:00 2001 From: Zachary T Welch zwe...@codesourcery.com Date: Fri, 24

[Openocd-development] RFC: Cortex-A[89] and SMP

2010-09-21 Thread Zach Welch
, but I would again appreciate any feedback from those who have gone before me. Has anyone else been planning to attack this new problem? -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743 ___ Openocd-development mailing list Openocd

[Openocd-development] Status of Cortex-A8 Support?

2010-09-17 Thread Zach Welch
. Thanks in advance for your time and consideration on these matters. -- Zach Welch CodeSourcery zwe...@codesourcery.com (650) 331-3385 x743 ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo

Re: [Openocd-development] Flash code reuse

2009-12-31 Thread Zach Welch
On Thu, 2009-12-31 at 10:33 -0600, Dean Glazeski wrote: Hi all, To give some background on what I'm playing with, I'm trying to do an implementation for dataflash devices. This work is not looking into doing SPI over FT2232 or anything, I'm looking at running some native code on my ARM9

Re: [Openocd-development] malloc: Vote what to do

2009-12-17 Thread Zach Welch
On Thu, 2009-12-17 at 21:44 +0100, Carsten Breuer wrote: Hi all, after finding out, that malloc come back with NULL even on linux (where people says here, it don't), im starting to loose interest in the hole thing. So what should we do? I think now, that all this arguments not to

Re: [Openocd-development] [PATCH 1/2] ecos: crisper implementation of timeval_ms()

2009-12-15 Thread Zach Welch
I would almost prefer that you use a Makefile trick here. We should avoid adding new #if's in the code when it's possible to avoid them. At the very least, provide two _complete_ versions of the function. Your new comment is misleading, as it only applies to one branch. On Tue, 2009-12-15 at

Re: [Openocd-development] OpenOCD Coding (was broken)

2009-12-13 Thread Zach Welch
On Sun, 2009-12-13 at 15:49 -0800, David Brownell wrote: [snip] Note that MISRA is not universally lauded. As I understand, some of its practices are contrary to other widely adopted coding policies. Sure. Some points are a laugh like a null pointer should not be dereferenced.

Re: [Openocd-development] [PATCH 0/3] deferred 'init' and leaner 'help'

2009-12-10 Thread Zach Welch
On Thu, 2009-12-10 at 13:18 +, Spencer Oliver wrote: Spencer Oliver wrote: Zachary T Welch wrote: Hi all, These patches clean up the server and system startup. The first patch factors the GDB server setup to be more conducive to deferred initialization of targets (in a later

Re: [Openocd-development] [PATCH 1/3] build: add build/src to include path

2009-12-08 Thread Zach Welch
I would say that the builddir should precede the srcdir. Happily, this should also generate a more minimal patch. Patches should touch as few lines as possible. Make all of them match the form: FOO = \ foo \ bar not FOO = foo \ bar The first form makes it

Re: [Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread Zach Welch
As far as I'm concerned, you never need our sign-off for this file. :) --Z On Tue, 2009-12-08 at 09:39 +0100, Øyvind Harboe wrote: Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com --- src/ecosboard.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git

Re: [Openocd-development] [PATCH 2/3] zy1000: remove unecessary include

2009-12-08 Thread Zach Welch
On Tue, 2009-12-08 at 01:07 -0800, David Brownell wrote: On Tuesday 08 December 2009, Zach Welch wrote: As far as I'm concerned, you never need our sign-off for this file. :) --Z On Tue, 2009-12-08 at 09:39 +0100, Øyvind Harboe wrote: Signed-off-by: Øyvind Harboe oyvind.har

Re: [Openocd-development] [PATCH 3/3] minidriver: fix inline capability of minidriver

2009-12-08 Thread Zach Welch
Do you really need to have the commands.[ch] changes here? If you can leave that alone, it would be preferred, as it doesn't appear to have anything to do with this patch. Also, you should not convert header file #includes in .c files to if the header is in the same directory. Indeed, that is

Re: [Openocd-development] multiple JTAG interfaces

2009-12-08 Thread Zach Welch
, fixing one part of the problem at a time. Sincerely, Zach Welch Corvallis, OR ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-07 Thread Zach Welch
On Mon, 2009-12-07 at 12:26 +0100, Øyvind Harboe wrote: On Sun, Dec 6, 2009 at 2:51 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: 1. Move the $(srcdir) from defining _DIR vars to their use. i.e. set just the directory component. I'm not quite sure what you mean by this. I

[Openocd-development] multiple JTAG interfaces

2009-12-07 Thread Zach Welch
be relatively safe to push. It might be best to do this integration in stages so each phase gets good testing, but what do others think about these changes and overall strategy? Cheers, Zach Welch Corvallis, OR ___ Openocd-development mailing list

Re: [Openocd-development] (nor) flash broken

2009-12-06 Thread Zach Welch
On Sun, 2009-12-06 at 18:05 -0800, David Brownell wrote: I thought I'd try mem info in GDB. Nothing. Why? Well, flash banks doesn't show anything any more. Why? Nothing calls flash_bank_add() ... handle_flash_bank_command() just leaks the structure it filled out. Whoops that must

Re: [Openocd-development] (nor) flash broken

2009-12-06 Thread Zach Welch
On Sun, 2009-12-06 at 19:55 -0800, Zach Welch wrote: On Sun, 2009-12-06 at 18:05 -0800, David Brownell wrote: I thought I'd try mem info in GDB. Nothing. Why? Well, flash banks doesn't show anything any more. Why? Nothing calls flash_bank_add() ... handle_flash_bank_command

Re: [Openocd-development] (nor) flash broken

2009-12-06 Thread Zach Welch
On Sun, 2009-12-06 at 20:34 -0800, David Brownell wrote: On Sunday 06 December 2009, Zach Welch wrote: On Sun, 2009-12-06 at 18:05 -0800, David Brownell wrote: I thought I'd try mem info in GDB. Nothing. Why? The first thing I tried, by the way, was gdb_memory_map enable

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-05 Thread Zach Welch
On Sat, 2009-12-05 at 08:25 +0100, Øyvind Harboe wrote: This worked pretty well, but there are lots of (to me) inexplicable -I's on the command line still and none of them point to the right place in the build tree. I'm testing minidummy build != src dir. oharboe/fixminidriver2

Re: [Openocd-development] libopenocd... again

2009-12-05 Thread Zach Welch
On Sat, 2009-12-05 at 00:51 -0800, David Brownell wrote: On Friday 04 December 2009, Zach Welch wrote: That's a useful statement of the extreme, but note that it's in two parts: decouple ... and switch. Decoupling is one of those things that's not fully understandable except

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-05 Thread Zach Welch
On Sat, 2009-12-05 at 11:14 +0100, Øyvind Harboe wrote: On Sat, Dec 5, 2009 at 8:45 AM, Zach Welch z...@superlucidity.net wrote: On Sat, 2009-12-05 at 08:35 +0100, Øyvind Harboe wrote: The approach seems to work fine, but requires that some other issues are sorted out first with include

[Openocd-development] [RFC] common flash work (generic objects)

2009-12-05 Thread Zach Welch
Hi all, The master branch on my repo.or.cz mirror has a couple of patches that begin to unify the flash tree, which will eventually lead to the elimination of a bit more duplicated code. It's using the container_of macro first used by the target module. The first patch introduces the basic

Re: [Openocd-development] [PATCH 1/4] improve command_done() API and docs

2009-12-05 Thread Zach Welch
On Sat, 2009-12-05 at 13:26 -0800, David Brownell wrote: On Sunday 29 November 2009, Zachary T Welch wrote: Note: this audit revealed some potential bugs with the command context implementation. There was a reason that commands were added at the end of the list. Shallow copying of

Re: [Openocd-development] [PATCH 1/4] switch 'rm' command away from using Jim

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 07:48 +0100, Øyvind Harboe wrote: On Fri, Dec 4, 2009 at 3:04 AM, Zachary T Welch z...@superlucidity.net wrote: Commands that do not need to use Jim should be registered as high-level command handlers. Why is that? Nb! ls *does* need to use jim to return a list

Re: [Openocd-development] Error: The 'init' command must be used before 'init'.

2009-12-04 Thread Zach Welch
This is actually expected; there was no warning previously, and the dummy driver always fails because it returns garbage. It still starts up, right? The fact that it is telling you where something failed is a good thing, if were talking about real hardware... right? --Z On Fri, 2009-12-04 at

Re: [Openocd-development] [PUSHED 4/4] split nor flash core/tcl

2009-12-04 Thread Zach Welch
On Thu, 2009-12-03 at 18:04 -0800, Zachary T Welch wrote: Hi all, The first two patches work to eliminate some Jim handling in the helper and JTAG modules, with the later being nearly purged. If the command layer provides some wrappers for Jim's return handling mechanisms, then all handlers

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 16:03 +0100, Øyvind Harboe wrote: It's getting there, see oharboe/fixminidriver. I had to mess with lots of Makefile.am to pollute the include path. If I can get that out of the way, then I should be able to clean up the rest too Yeah, those changes should not go into

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 22:51 +0100, Øyvind Harboe wrote: On Fri, Dec 4, 2009 at 10:36 PM, Zach Welch z...@superlucidity.net wrote: On Fri, 2009-12-04 at 16:03 +0100, Øyvind Harboe wrote: It's getting there, see oharboe/fixminidriver. I had to mess with lots of Makefile.am to pollute

Re: [Openocd-development] ft2232.c to include LPC-Stick

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 21:46 -0300, Esteban Lucchesi wrote: Hi all, I'm new to the list. I've read it often these last days because I bought a Hitex LPC-Stick for the LPC2468 and I wanted to make it work with Eclipse+Yagarto+OpenOCD. I added the layout lpcstick to ft2232.c and the

Re: [Openocd-development] [PUSHED 12/4] remove flash.[ch]

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 03:43 -0800, Zach Welch wrote: [snip] The last two patches begin to split the NOR flash layer into public and private APIS (flash/nor/{core,imp}.h, respectively) and into core and TCL modules (flash/nor/{core,tcl}.c, likewise). More patches will be required

Re: [Openocd-development] [PUSHED 12/4] remove flash.[ch]

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 19:45 -0600, Dean Glazeski wrote: Don't mind me when it comes to the NAND. I won't be active probably until Christmas break when I no longer have persistent projects :). At that time I welcome the challenge of forcing my stuff into the proper mold. I'll have to make a

Re: [Openocd-development] [patch 1/N] ARM: renaming

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 20:54 -0800, David Brownell wrote: On Friday 04 December 2009, Zach Welch wrote: Sounds good to me. I have given the target directory a wide berth since you have been working on it. ;) Glad to hear it. :) I pushed; N == 10. This should be the bulk

Re: [Openocd-development] libopenocd... again

2009-12-04 Thread Zach Welch
On Fri, 2009-12-04 at 23:31 -0800, David Brownell wrote: On Tuesday 01 December 2009, Zach Welch wrote: We should approach this problem as though we intend to eventually decouple Jim from the core functionality and switch to a different front-end language. That's a useful statement

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-04 Thread Zach Welch
On Sat, 2009-12-05 at 08:35 +0100, Øyvind Harboe wrote: The approach seems to work fine, but requires that some other issues are sorted out first with include dirs. From error message above, there are two strange -I additions: NB! build != src dir -I. = current build directory -I../.. =

Re: [Openocd-development] [PATCH] basic ARM semihosting support

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 08:23 +0100, Øyvind Harboe wrote: I would like to see this merged. Any objections? Go for it! --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 09:20 +0100, Øyvind Harboe wrote: The public API _must_ be a non-inline version of the API that calls the inline version. Period. You don't explain why this is necessary and I don't agree. I believe you assume that it is impossible to allow the minidriver to inline

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 09:53 +0100, Øyvind Harboe wrote: So the minidriver (including classic API) must have control over whether or not the following fn's gets inlined or not. These fn's really are in the inner loops and boil away to *nothing* on a low performance low latency system. And they

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 10:22 +0100, Øyvind Harboe wrote: (Ref. discussion I think we've settled that the minidriver can either implement an ABI or use inlining for performance.) On Thu, Dec 3, 2009 at 10:11 AM, Zach Welch z...@superlucidity.net wrote: On Thu, 2009-12-03 at 09:53 +0100

Re: [Openocd-development] [PATCH] basic ARM semihosting support

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 08:23 +0100, Øyvind Harboe wrote: I would like to see this merged. Any objections? Actually, I did just find two things: 1) The header is missing from the Makefile.am 2) The header is missing a copyright header and #ifdef wrapper --Z

Re: [Openocd-development] [PATCH] basic ARM semihosting support

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 10:39 +0100, Øyvind Harboe wrote: I added a missing #include sys/stat.h, but it is not quite ready to commit yet I think. Does it build under Windows? Perhaps it does, I didn't try. I don't think we should try to make this work under anything but POSIX API for now,

Re: [Openocd-development] libopenocd... again

2009-12-03 Thread Zach Welch
On Tue, 2009-12-01 at 21:08 -0800, Zach Welch wrote: Hi all, Assuming a split between policy and mechanism can be addressed, OpenOCD will become much more usable as a proper library. One of the questions that needs resolution is how to install our header files. The answer that we chose

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 10:51 +0100, Øyvind Harboe wrote: On Thu, Dec 3, 2009 at 10:36 AM, Zach Welch z...@superlucidity.net wrote: On Thu, 2009-12-03 at 10:22 +0100, Øyvind Harboe wrote: (Ref. discussion I think we've settled that the minidriver can either implement an ABI or use inlining

Re: [Openocd-development] libopenocd... again

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 01:50 -0800, Zach Welch wrote: On Tue, 2009-12-01 at 21:08 -0800, Zach Welch wrote: Hi all, Assuming a split between policy and mechanism can be addressed, OpenOCD will become much more usable as a proper library. One of the questions that needs resolution is how

Re: [Openocd-development] [PATCH] basic ARM semihosting support

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 12:27 -0500, Nicolas Pitre wrote: On Thu, 3 Dec 2009, Zach Welch wrote: On Thu, 2009-12-03 at 10:39 +0100, Øyvind Harboe wrote: I added a missing #include sys/stat.h, but it is not quite ready to commit yet I think. Does it build under Windows? Perhaps

Re: [Openocd-development] everything must be used before init ??

2009-12-03 Thread Zach Welch
On Thu, 2009-12-03 at 15:00 -0800, David Brownell wrote: On Sunday 29 November 2009, Zach Welch wrote: Broken how? It's worked as advertised, as far as I know. It was allowing all commands to run during CONFIG stage, regardless of whether they were marked EXEC-only. Broken

Re: [Openocd-development] [PUSHED 7/7] split the 'init' command

2009-12-02 Thread Zach Welch
On Tue, 2009-12-01 at 13:01 -0800, Zachary T Welch wrote: Hi all, This series makes most of the individual steps in 'init' accessible to direct invocation. The changes should allow recovery in cases when OpenOCD is run interactively and (for example) you fail to specify an interface before

Re: [Openocd-development] [PUSHED 3/3] remove all #if logic from openocd.c

2009-12-02 Thread Zach Welch
On Tue, 2009-12-01 at 20:06 -0800, Zachary T Welch wrote: Hi all, This series removes all #if logic from the src/openocd.c file, making it look much nicer and helping to stablize our ABI in the process. Share and Enjoy, --Z ___ Openocd-development

Re: [Openocd-development] gdb_port no longer returns configured port

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 12:46 +0100, Øyvind Harboe wrote: Also, gdb_port is incremented even if starting the target fails. I'll take a look at these regressions today. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-02 Thread Zach Welch
Do not apply this until you fix the problem noted below. Thanks, Zach On Wed, 2009-12-02 at 14:38 +0100, Øyvind Harboe wrote: Fix 'regression' where jtag_add_dr_out() is no longer inlined after refactoring. The minidrivers strip away all the overhead and allow inner loops to communicate

Re: [Openocd-development] Common TFTP support

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 16:13 +0100, Øyvind Harboe wrote: On Wed, Dec 2, 2009 at 4:07 PM, Yegor Yefremov yegorsli...@googlemail.com wrote: On Wed, Dec 2, 2009 at 3:47 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: On Wed, Dec 2, 2009 at 3:42 PM, Yegor Yefremov yegorsli...@googlemail.com

Re: [Openocd-development] Common TFTP support

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 15:42 +0100, Yegor Yefremov wrote: I found some short description about TFTP support in OpenOCD but it seems to be restricted to eCOS or ZY1000 debugger. Are there any plans to implement such a feature? The usage were for example following: I have my Linux development

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-02 Thread Zach Welch
I just noticed that there may be other problems with this; I question the need for both -I and #include dirname/ Seems like one or the other is enough, so there appears to be a new redundancy here. On Wed, 2009-12-02 at 13:39 -0800, Zach Welch wrote: Do not apply this until you fix

Re: [Openocd-development] Common TFTP support

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 13:47 -0800, Zach Welch wrote: On Wed, 2009-12-02 at 15:42 +0100, Yegor Yefremov wrote: I found some short description about TFTP support in OpenOCD but it seems to be restricted to eCOS or ZY1000 debugger. Are there any plans to implement such a feature? The usage

Re: [Openocd-development] Common TFTP support

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 22:59 +0100, Øyvind Harboe wrote: I've seen that the tftp is really just a vestigal habit that is quickly replaced once the benefits of the *great* gdb load capabilities that OpenOCD offers have been discovered. It's fast + it offers automatic flash programming support.

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 23:00 +0100, Øyvind Harboe wrote: On Wed, Dec 2, 2009 at 10:55 PM, Zach Welch z...@superlucidity.net wrote: I just noticed that there may be other problems with this; I question the need for both -I and #include dirname/ Seems like one or the other is enough, so

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 22:54 +0100, Øyvind Harboe wrote: + +/* The minidriver contains inline versions of JTAG fn's */ +#include minidriver.h + This is bad, as you are creating a new layering violation that will need to be removed. You should move this #include to somewhere other

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 14:32 -0800, Zach Welch wrote: On Wed, 2009-12-02 at 22:54 +0100, Øyvind Harboe wrote: + +/* The minidriver contains inline versions of JTAG fn's */ +#include minidriver.h + This is bad, as you are creating a new layering violation that will need

Re: [Openocd-development] [PATCH] minidriver: allow jtag_add_dr_out() to be inlined into inner loops

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 14:44 -0800, Zach Welch wrote: On Wed, 2009-12-02 at 14:32 -0800, Zach Welch wrote: On Wed, 2009-12-02 at 22:54 +0100, Øyvind Harboe wrote: + +/* The minidriver contains inline versions of JTAG fn's */ +#include minidriver.h + This is bad, as you

Re: [Openocd-development] [PUSHED 7/7] split the 'init' command

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 15:00 -0800, David Brownell wrote: Hmm, I'll have to try pulling this ... but one of my test configs is now triggering the perplexing message Error: The 'init' command must be used before 'init'. That seems somehow ... not possible. ;) Here's the logic: all

Re: [Openocd-development] [PUSHED 7/7] split the 'init' command

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 15:57 -0800, David Brownell wrote: On Wednesday 02 December 2009, Zach Welch wrote: On Wed, 2009-12-02 at 15:00 -0800, David Brownell wrote: Hmm, I'll have to try pulling this ... but one of my test configs is now triggering the perplexing message Error

Re: [Openocd-development] [PUSHED 7/7] split the 'init' command

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 15:36 -0800, David Brownell wrote: On Wednesday 02 December 2009, David Brownell wrote: Hmm, I'll have to try pulling this ... but one of my test configs is now triggering the perplexing message Error: The 'init' command must be used before 'init'. That

Re: [Openocd-development] [PATCH] fix 'target init' command registration

2009-12-02 Thread Zach Welch
Pushed Now, does it become apparent why I want a test suite that runs via 'make check'? It might save me from myself. :) On Wed, 2009-12-02 at 16:19 -0800, Zachary T Welch wrote: The command handler registration was put at the top level, rather than as a subcommand. Move it to where it

Re: [Openocd-development] add jtag/drivers/ too... [WAS: split flash/* into flash/nor/* and flash/nand/*]

2009-12-02 Thread Zach Welch
On Tue, 2009-12-01 at 15:30 -0800, Zach Welch wrote: Hi all, I want to clean up our flash directory, moving the files into subdirectories and simplifying the nand filenames. This paves the way for future types of flash technologies, drivers for which seem like they could be imminent

Re: [Openocd-development] [PUSHED 7/7] split the 'init' command

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 17:13 -0800, David Brownell wrote: On Wednesday 02 December 2009, Zach Welch wrote: Add '-c noinit' at the end to suppress the second 'init', if the first one succeeds okay. I'd rather just preserve the original semantics, where init just ensures that things were

Re: [Openocd-development] add jtag/drivers/ too... [WAS: split flash/* into flash/nor/* and flash/nand/*]

2009-12-02 Thread Zach Welch
On Wed, 2009-12-02 at 16:54 -0800, Zach Welch wrote: [snip] I will be pushing these shortly, though I am going to add another patch to move the JTAG drivers into src/jtag/drivers/. This helps clean up the src/jtag directory and puts the drivers/ directory on even level with the minidriver

Re: [Openocd-development] [PATCH] arm: dcc_downloads and fast_memory_access are now enabled by default

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 08:52 +0100, Øyvind Harboe wrote: How about a warning when it's _not_ explicitly enabled or disabled by the user? Specifically, tell the users to try enabling those features or to add explicit commands to stop the warnings. Scripts for boards where that feature will

Re: [Openocd-development] [PATCH 1/3] command: the Jim interpreter can now be provided rather than created

2009-12-01 Thread Zach Welch
Only one minor suggested improvement, below. Otherwise, these both look okay to me. On Tue, 2009-12-01 at 08:48 +0100, Øyvind Harboe wrote: In embedded hosts, the Jim interpreter can come from the existing context rather than be created by OpenOCD. Signed-off-by: Øyvind Harboe

Re: [Openocd-development] [PATCH 1/3] command: the Jim interpreter can now be provided rather than created

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 09:17 +0100, Øyvind Harboe wrote: #if !BUILD_ECOSBOARD It is now safe to kill this #if logic too. It's like a bonus prize. ;) Almost, but not quite. I tried before I remembered that Jim is embedded into the athttpd server... You know the slightly messy and

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 09:37 +0100, Michael Schwingen wrote: Zach Welch wrote: On Mon, 2009-11-30 at 14:42 -0800, David Brownell wrote: On Monday 30 November 2009, Zachary T Welch wrote: Registers a signal handler to catch SIGSEGV in order to display the stack where the program

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 09:45 +0100, Øyvind Harboe wrote: Hm - I'm with David here: I am not very fond of re-inventing parts of gdb to include it in OpenOCD. Fully implementing this would make OpenOCD depend on libbfd just for crash reports - this is ridiculous. If something like this

Re: [Openocd-development] [PATCH 1/3] command: the Jim interpreter can now be provided rather than created

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 10:16 +0100, Øyvind Harboe wrote: The patch to ecosboard.c always gives a non-NULL value, and we always pass in NULL from openocd.c. The #if is entirely redundant when you take a moment to look at the big picture. Except it doesn't build, it's that messy bit with

Re: [Openocd-development] [PATCH] arm: dcc_downloads and fast_memory_access are now enabled by default

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 09:18 +0100, Øyvind Harboe wrote: On Tue, Dec 1, 2009 at 9:03 AM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 08:52 +0100, Øyvind Harboe wrote: How about a warning when it's _not_ explicitly enabled or disabled by the user? Specifically, tell

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 01:23 -0800, David Brownell wrote: Registers a signal handler to catch SIGSEGV in order to display the stack where the program crashed. Is this for inside OpenOCD? If so, I'd rather just expect folk to run inside GDB. Either they're running natively and

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 10:25 +0100, Øyvind Harboe wrote: On Tue, Dec 1, 2009 at 10:17 AM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 09:45 +0100, Øyvind Harboe wrote: Hm - I'm with David here: I am not very fond of re-inventing parts of gdb to include it in OpenOCD

Re: [Openocd-development] [PATCH 1/3] command: the Jim interpreter can now be provided rather than created

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 10:24 +0100, Øyvind Harboe wrote: On Tue, Dec 1, 2009 at 10:19 AM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 10:16 +0100, Øyvind Harboe wrote: The patch to ecosboard.c always gives a non-NULL value, and we always pass in NULL from openocd.c

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 01:52 -0800, David Brownell wrote: On Tuesday 01 December 2009, Zach Welch wrote: On Tue, 2009-12-01 at 01:23 -0800, David Brownell wrote: Registers a signal handler to catch SIGSEGV in order to display the stack where the program crashed

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 10:36 +0100, Øyvind Harboe wrote: No one was talking about linking with GDB. That's just insane. ;) libbfd is part of binutils. But again it should be_optional. OK. Explain the benefit of complicating OpenOCD vs. adding a script to launch OpenOCD via GDB then...

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 11:06 +0100, Øyvind Harboe wrote: On Tue, Dec 1, 2009 at 11:02 AM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 10:36 +0100, Øyvind Harboe wrote: No one was talking about linking with GDB. That's just insane. ;) libbfd is part of binutils

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 11:14 +0100, Øyvind Harboe wrote: Again, you have missed the point. This is about users and our releases. I cannot make that point more clearly. It is not about developers who are willing to use GDB. It's about users who aren't. I haven't done the statistics, but

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 11:27 +0100, Michael Schwingen wrote: Zach Welch wrote: Hm - I'm with David here: I am not very fond of re-inventing parts of gdb to include it in OpenOCD. Fully implementing this would make OpenOCD depend on libbfd just for crash reports - this is ridiculous

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 21:57 +0100, Andreas Fritiofson wrote: On Tue, Dec 1, 2009 at 10:32 AM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 10:25 +0100, Øyvind Harboe wrote: On Tue, Dec 1, 2009 at 10:17 AM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 09

Re: [Openocd-development] FT4232H support

2009-12-01 Thread Zach Welch
On Mon, 2009-11-30 at 16:38 -0600, Austin, Alex wrote: Hello, I’ve built a JTAG adapter (Very similar to oocdlink-h) using the FT4232H instead of the FT2232H. Due to the lack of ACBUS on the 4232, I’ve routed the reset lines to the same pins on BDBUS. CDBUS and DDBUS both go to serial

Re: [Openocd-development] [rfc] improving 'help'... volunteers?

2009-12-01 Thread Zach Welch
On Sat, 2009-11-28 at 15:26 -0800, David Brownell wrote: On Saturday 28 November 2009, Zach Welch wrote: On Sat, 2009-11-28 at 14:07 -0800, David Brownell wrote: On Saturday 28 November 2009, Zach Welch wrote: Next, we should consider updating all help messages to full sentences, so

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 23:09 +0100, Andreas Fritiofson wrote: On Tue, Dec 1, 2009 at 11:08 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: On Tue, Dec 1, 2009 at 10:23 PM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 21:57 +0100, Andreas Fritiofson wrote: On Tue

Re: [Openocd-development] [rfc] improving 'help'... volunteers?

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 14:28 -0800, David Brownell wrote: On Tuesday 01 December 2009, Zach Welch wrote: The use of angle brackets intends to distinguish parameter names from literal arguments. Thus [foo] means an optional thing which semantically will be used as a foo, whereas

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 10:08 -0800, David Brownell wrote: On Tuesday 01 December 2009, Øyvind Harboe wrote: Zach made a good point that there are bug reports we are not receiving today. Those are the ones he's after here I think. I'm sure this project loses more potential bug reports by

[Openocd-development] policy vs. mechanism

2009-12-01 Thread Zach Welch
Hi all, Part of my impetus to restructure the command set is to see more separation of policy and mechanism in the code. The JTAG layer shows how this can be done: a tcl.c file contains all of the command handlers, while core.c contains the low-level functions that do the work. It might be

Re: [Openocd-development] split flash/* into flash/nor/* and flash/nand/*

2009-12-01 Thread Zach Welch
at 17:52 -0600, Dean Glazeski wrote: Aargh, darn school! I can't keep up with these patches, but do it! This leaves some room for work I want to do when I have time again :). // Dean Glazeski On Tue, Dec 1, 2009 at 5:30 PM, Zach Welch z...@superlucidity.net wrote: Hi all

Re: [Openocd-development] [PATCH 2/4] produce stack traces on segfaults

2009-12-01 Thread Zach Welch
On Wed, 2009-12-02 at 00:56 +0100, Andreas Fritiofson wrote: On Tue, Dec 1, 2009 at 11:50 PM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-12-01 at 23:09 +0100, Andreas Fritiofson wrote: [snip] I like it, except I think it needs to be disabled in the default case. We will get

Re: [Openocd-development] [PATCH 0/7] split the 'init' command

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 13:01 -0800, Zachary T Welch wrote: Hi all, This series makes most of the individual steps in 'init' accessible to direct invocation. The changes should allow recovery in cases when OpenOCD is run interactively and (for example) you fail to specify an interface before

Re: [Openocd-development] [PATCH 0/3] remove all #if logic from openocd.c

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 20:49 -0800, David Brownell wrote: On Tuesday 01 December 2009, Zachary T Welch wrote: This series removes all #if logic from the src/openocd.c file, making it look much nicer and helping to stablize our ABI in the process. Yes! These patches were easy. I am not yet

[Openocd-development] libopenocd... again

2009-12-01 Thread Zach Welch
Hi all, Assuming a split between policy and mechanism can be addressed, OpenOCD will become much more usable as a proper library. One of the questions that needs resolution is how to install our header files. The answer that we chose for this will determine how much restructuring will be

Re: [Openocd-development] policy vs. mechanism

2009-12-01 Thread Zach Welch
On Tue, 2009-12-01 at 20:57 -0800, David Brownell wrote: On Tuesday 01 December 2009, Zach Welch wrote: After the command cleanup that I have started, I believe this type of factoring deserves to be pursued in the other modules. I propose making these changes in the following order

Re: [Openocd-development] [PATCH] Revert improve alloc_vprintf

2009-11-30 Thread Zach Welch
Do not apply. The old implementation was total crap, and your vsnprintf implementation must be too. That's not our problem, and it can be worked around without destroying the improvements for others. Use a single 'char' on the stack. One character should be enough. --Z On Mon, 2009-11-30 at

  1   2   3   4   5   6   7   8   9   >