her from a file or using a DNS query.
revision 3816c7c46d466f9dfff85c41553084ee957e27d0
Author: Anders Widell
Date: Fri, 6 Oct 2017 14:47:57 +0200
dtm: Extract Multicast class for node discovery message handling [#991]
Extract a class with the name Multicast, that handles send and receive o
Ack with minor comments inline, marked AndersW>
regards,
Anders Widell
On 10/06/2017 11:10 AM, Hans Nordeback wrote:
---
scripts/opensaf_scale_out | 14 +-
src/clm/README | 17
src/clm/clmd/clms_cb.h | 2 ++
src/clm/clmd/clms_evt.c|
---
src/base/Makefile.am | 2 +-
src/base/logtrace.c | 268 ---
src/base/logtrace.cc | 253
src/base/logtrace.h | 88 -
4 files changed, 298 insertions(+), 313 deletions(-)
delete
servicesy
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision fea5875204b44b6e9adf1816a247e3ea2a2bd353
Author: Anders Wi
Extend the OpenSAF internal log service so that it supports multiple log streams
in addition to the MDS log. All log streams are received on the same socket and
the stream name is extracted from the MSGID field. Each stream is written to a
separate file based on the name of the stream.
---
src/dtm
Instead of writing trace messages directly to a file, use the OpenSAF internal
log service which is implemented in osaftransportd. As a consequence, the trace
files will now be rotated automatically when they have exceeded the maximum
allowed log file size.
---
src/base/logtrace.cc | 280 +
Hi!
I intend to push this tomorrow unless there are any comments?
regards,
Anders Widell
On 10/06/2017 03:01 PM, Anders Widell wrote:
Summary: dtm: Extract Multicast class for node discovery message handling [#991]
Review request for Ticket(s): 991
Peer Reviewer(s): Alex, Ravi
Pull request
Ack with minor comments, marked AndersW> below.
regards,
Anders Widell
On 10/06/2017 04:11 PM, Hans Nordeback wrote:
---
00-README.conf| 3 +
src/base/Makefile.am | 1 +
src/base/daemon.c | 87 +
ns are not fully implemented in GCC 4.8.
/ Anders Widell
On 10/17/2017 01:03 PM, Hans Nordebäck wrote:
Hi Anders,
the regex should be std::regex is_valid{R"([_[:alpha:]]+\.?\w+)"}; I
think.
The original function does not handle e.g. "." correctly I guess,
but th
Ok will change these, except using std::unique_ptr since Google C++
Style Guide discourages usage of class type with static storage duration.
regards,
Anders Widell
On 10/17/2017 10:43 AM, Hans Nordebäck wrote:
ack, code review only. Minor comments below. /Thanks HansN
On 10/10/2017 06
Once the code freeze has happened, we will send out a
new announcement and after that you can start pushing bug-fixes for the
October release to the release branch.
regards,
Anders Widell
--
Check out the vibrant
It no longer throws an exception, but it still doesn't properly with GCC
4.8 (when I tested the regex below only accepts single-character strings).
regards,
Anders Widell
On 10/18/2017 09:40 AM, Hans Nordebäck wrote:
Hi Anders,
you can try this regex, it works in gcc 4.8.4, gcc 5.4.
---
src/base/Makefile.am| 3 +++
src/base/osaf_unistd.cc | 62 +
src/base/osaf_unistd.h | 51
3 files changed, 116 insertions(+)
create mode 100644 src/base/osaf_unistd.cc
create mode 100644 src/base/o
Introduce a cluster genration ID which is saved on persistent local storage on
all nodes during a cluster reset. Nodes with different cluster generation IDs
are not allowed to form a cluster with each other. This addresses several
problems:
* If a node reboots very fast or very slowly, it is preve
tion to or from nodes that are not
members of the CLM cluster. The cluster reset will not be completely safe until
such a mechanism is in place.
revision 2f3999f02c7ab0edc3e51799a74ec51c06eeb84e
Author: Anders Widell
Date: Mon, 23 Oct 2017 15:24:53 +0200
base: Add utility function osaf_fdatasync
revision efa3e715c91405754aac58b3eba58fa6719cb64f
Author: Anders Widell
Date: Wed, 25 Oct 2017 14:04:30 +0200
dtm: Always call the configure_tipc script [#2653]
Call the configure_tipc script regardless of whether OpenSAF is configured to
manage TIPC or not. This is needed since the script may need
If OpenSAF is not configured to manage TIPC, we don't need to require the
presence of /etc/opensaf/slot_id or /var/lib/opensaf/node_id. Instead, we create
the file /var/lib/opensaf/node_id ourselves based on the TIPC address of the
node we are running on. The same translation formula is used (in th
Call the configure_tipc script regardless of whether OpenSAF is configured to
manage TIPC or not. This is needed since the script may need to set up the Node
ID when OpenSAF is not managing TIPC.
---
src/dtm/transport/osaf-transport.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
system controllers have died, so
the main thread should not be blocked for too long.
regards,
Anders Widell
On 10/23/2017 04:41 PM, Zoran Milinkovic wrote:
Add two new admin operations to CLM.
1. Node reboot will use the same openation id as cluster reboot, but the DN
will contain CLM node
,
Anders Widell
On 10/26/2017 02:02 PM, Zoran Milinkovic wrote:
Hi,
base/process.h cannot be used in C code.
The patch copies the pattern for execution of all other scripts.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: den 26 oktober 2017 13:35
To: Zoran Milinkovic ; Hans
To increase the amount of trace data that is kept on disk, OpenSAF trace files
now have nine backup files, named .1 to .9, instead of just one single backup
file. The MDS log still has one single backup file, as before.
---
src/dtm/transport/log_server.cc| 9 +
src/dtm/transpo
OpenSAF servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 2a7a20bafa7f189fca79bd73e6d678c58fda64dd
Auth
supervision of the script, but currently the user
is responsible for making sure that it doesn't hang.
regards,
Anders Widell
On 10/26/2017 02:17 PM, Anders Widell wrote:
The preferred way is to convert the file to C++, but if this is not
possible then you can add a wrapper layer. There
patch I re-ordered the fields compared to the
previous commit.
regards,
Anders Widell
On 10/26/2017 03:37 PM, Zoran Milinkovic wrote:
Hi,
This solution is not safe and is NBC.
If a new node with earlier release join the cluster, the whole cluster will be
rebooted.
For example, this is
fimmnd[493]: ER No IMMD service =>
cluster restart, exiting
2) a) On e.g. PL-4, adding e.g. 48 to a file
/var/log/opensaf/.clm_cluster_generation_id to simulate "dangling"
generation files and then reboot PL-4 results in a cluster reboot.
/Regards HansN
On 10/23/2017 03:3
). It should be removed.
regards,
Anders Widell
On 10/23/2017 04:41 PM, Zoran Milinkovic wrote:
Add two new admin operations to CLM.
1. Node reboot will use the same openation id as cluster reboot, but the DN
will contain CLM node
Example for rebooting SC2:
immadm -o 4 safNode
Divide the safe reboot in the opensaf_reboot script into two phases: in the
first phase we stop important OpenSAF services (currently only IMM), and in the
second phase we reboot the nodes.
---
scripts/opensaf_reboot | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/opensaf_reboot
If the shutdown -r command fails, either by returning an error code immediately,
or by not completing the reboot within one minute, we will call the failfast
reboot mechanism to make sure the node reboots.
---
src/base/Makefile.am | 3 +--
src/base/osaf_utility.c
n
Core libraries y
Samples n
Tests n
Other y
Comments (indicate scope for each "y" above):
-
revision eedbc2ed68294bd9b4f1fe42baa382c800df7e1d
Author: Anders Widell
Date: F
The fallback reboot mechanism requires write permission to the SysRq proc
interface, so we must call opensaf_reboot_prepare() before daemonize() to make
sure it works properly.
---
src/clm/clmd/clms_main.c | 2 ++
src/clm/clmnd/main.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/
well. Avoid pushing
unimportant bug-fixes to the release branch.
develop: for new enhancements as well as all bug-fixes. This will become
the next major OpenSAF release, probably OpenSAF 5.18.01
regards,
Anders Widell
Ack with comment: add /python/pylint.html to .gitignore
regards,
Anders Widell
On 10/23/2017 02:40 PM, Hans Nordeback wrote:
Summary: pyosaf: Create a pylint makefile target for pyosaf V2 [#2636]
Review request for Ticket(s): 2636
Peer Reviewer(s): AndersW, Srinivas, Nguyen
Pull request to
Ack.
regards,
Anders Widell
On 11/07/2017 03:28 PM, Hans Nordeback wrote:
---
src/dtm/dtmnd/dtm_main.cc | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/dtm/dtmnd/dtm_main.cc b/src/dtm/dtmnd/dtm_main.cc
index f8d7e531a..cf0b81f8a 100644
--- a/src
document so well in what version options were introduced, so it
requires some investigation.
regards,
Anders Widell
On 11/13/2017 09:02 AM, Hans Nordebäck wrote:
Hi Alex,
it was tested on Ubuntu 16.04 and MontaVista Carrier Grade Express
Linux 2.2.0.
/Regards HansN
On 11/10/2017 08:10 PM
have migrated to 228 by then?
regards,
Anders Widell
On 11/13/2017 12:47 PM, Anders Widell wrote:
What version of systemd are you using Alex? I think we should first
establish the minimum version that anyone is using, and use that as a
minimum required version for OpenSAF. Then we have to check
Add a the possibility to select between blocking and non-blocking send and
receive operations on the UnixSocket, and use blocking mode when sending
logtrace trace messages. Trace messages will thus not be lost, but excessive
tracing can slow down the service being traced. This patch also contains a
n
OpenSAF servicesn
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision d6d4e83ea42a14c497f3d50eaa3b13f2f164be52
Auth
ort both systemd 219 and systemd 229, we could pass a
large timeout value, e.g. 5184000 which is 24 hours (or "24h" if it
works - needs to be tested).
regards,
Anders Widell
On 11/13/2017 06:02 PM, Alex Jones wrote:
No, we don't need support for 208 for the next release of OpenS
When I compare this with the fix that I did as part of ticket [#2451] (pasted
in below), I think it looks like you forgot free(ms), and thus you get a memory
leak eachh time you receive an CLMSV_CLMS_TO_CLMNA_REBOOT_MSG,
CLMSV_CLMS_TO_CLMNA_NODE_REBOOT_MSG or CLMSV_CLMS_TO_CLMNA_ACTION_MSG mess
about it - we could do the math and come up with a shorter
time-out. One or a few hours ought to be enough.
regards,
Anders Widell
On 11/14/2017 03:32 PM, Alex Jones wrote:
Does 229 still accept 0, even though the documentation says infinity?
Alex
On 11/14/2017 09:24 AM, Anders Widell wrote
Ack with minor comment: you can change the README to say that
OPENSAF_CLUSTER_REBOOT_WAIT_TIME_SEC can be set in nid.conf (which is
sourced by opensafd).
regards,
Anders Widell
On 11/10/2017 09:28 AM, Hans Nordeback wrote:
With current #2542 solution there is a window in the nid phase when
Ack with the comment that you should specify a finite time-out (a few
hours?) instead of "infinity", to ensure compatibility with systemd
versions older than 229.
regards,
Anders Widell
On 11/10/2017 12:11 PM, Hans Nordeback wrote:
---
src/nid/opensafd.service.in | 1 +
1 fi
Yes, something like that. I think each service can also be re-started
(several times?), so you may need to multiply the sum with some number.
regards,
Anders Widell
On 11/15/2017 01:03 PM, Hans Nordebäck wrote:
Hi Anders,
yes, my first approach was, (mentioned in the ticket) was to:
&quo
servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision f064141abac6212f944c4e379d5b9dc9b5f13a4c
Author: Anders Wi
Fix a regression for the case when OPENSAF_MANAGE_TIPC=no and the file
/var/lib/opensaf/node_id is present. In this case, the configure_tipc script
should do nothing.
---
src/nid/configure_tipc.in | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/nid/configure_tipc.i
Just to emphasize that these variables are not used in this part of the
shell script.
/ Anders
On 11/15/2017 03:28 PM, Hans Nordebäck wrote:
ack, review only. A question, why was ETH_NAME, TIPC_NET id moved?
/Regards Hans
On 11/15/2017 01:55 PM, Anders Widell wrote:
Fix a regression for
Ack with minor comment: isn't there a missing dollar sign in save_ifd=IFS ?
regards,
Anders Widell
On 11/16/2017 03:46 PM, Hans Nordeback wrote:
---
scripts/opensaf_scale_out | 20 +++-
src/clm/README| 2 +-
src/clm/clmnd/main.c | 9 +
3
Ack with comment: add a newline at the end of python/README
regards,
Anders Widell
On 11/17/2017 09:54 AM, Hans Nordeback wrote:
The output format can now be given, e.g.:
make pylint (defaults to text)
make pylint FORMAT=html
make pylint FORMAT=parseable
make pylint FORMAT=json
function fm_rda_init) almost immediately before rda_register_callback. I
think you can move the rda_register_callback call into the fm_rda_init
function and remove the call to rda_get_role here as well.
regards,
Anders Widell
On 11/20/2017 03:40 AM, Minh Chau wrote:
There is a race condition
e
retry control as template parameter(s)?
regards,
Anders Widell
On 11/24/2017 11:30 AM, Vu Minh Nguyen wrote:
Make generic C++ python-like decorator handling SA_AIS_ERR_TRY_AGAIN
return code of AIS APIs.
---
src/base/Makefile.am | 5 +-
src/ba
Add a new protocol message that can be recevied on the UNIX socket, that causes
osaftransportd to write all buffered log messages from memory to disk.
---
src/base/logtrace.cc | 4 +-
src/dtm/Makefile.am | 16 -
src/dtm/common/osaflog_protocol.h | 50
Flush log entries in the OpenSAF internal log server from memory to disk before
rebooting the local node, to prevent loss of log messages.
---
scripts/opensaf_reboot | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/opensaf_reboot b/scripts/opensaf_reboot
index b8a5737d0..df65c268
Add new UnixSocket methods for sending and receiving with a sockaddr_un address
parameter. Also add support for abstract UNIX socket addresses and for providing
a raw sockaddr_un address to UnixSocket.
---
src/base/tests/unix_socket_test.cc | 35 +
src/base/unix_client_socket.cc |
revision 5f19209a3a9ca2e3ac55ddbacc74cbefcc2f1fa4
Author: Anders Widell
Date: Tue, 28 Nov 2017 15:34:37 +0100
dtm: Add flush command for writing buffered log messages to disk [#2646]
Add a new protocol message that can be recevied on the UNIX socket, that causes
osaftransportd to write all buffered log messages from memo
Ack with minor comment: maybe add -n option to the echo command, to
avoid appending a newline at the end of the last field?
regards,
Anders Widell
On 11/27/2017 04:30 PM, Hans Nordeback wrote:
---
scripts/opensaf_scale_out | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
I have two comments:
1) I think this should be put under src/ais (but not src/ais/include)
instead of putting it in src/base.
2) Could you think about if it is possible to make the retry time and
interval constexpr?
regards,
Anders Widell
On 11/30/2017 01:01 PM, Hans Nordebäck wrote
Add support to the osaflog command for parsing and pretty-printing the OpenSAF
log messages. Initially, we only support simple pretty-printing by removing
information which is not frequently needed when reading the logs. In future
ticket(s), we can also add support for filtering log messages.
The
n
OpenSAF servicesy
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 640a7f6ce590d2bef128019d6cec887616595e3d
Auth
Ack, tested without PLM.
regards,
Anders Widell
On 12/06/2017 06:14 PM, Alex Jones wrote:
If EEs and corresponding CLM nodes are dynamically created, after a middleware
si-swap when the former standby has become active, then one of those EEs is
rebooted, clmd has not enabled PLM readiness
Ack with comments, marked AndersW> below.
regards,
Anders Widell
On 12/04/2017 04:34 PM, Vu Minh Nguyen wrote:
Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code
of AIS APIs.
---
src/ais/Makefile.am| 5 +-
src/ais/try_again_decorato
n
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 2079e19ce75f7bccd5f9b108632b9a6ef9bcbfc5
Author: Anders Widell
Date:
---
src/base/ncs_main_papi.h | 6 -
src/base/ncs_main_pub.c | 331 ++-
src/base/ncs_main_pub.h | 26
src/base/ncsgl_defs.h| 1 -
src/base/os_defs.h | 2 -
5 files changed, 14 insertions(+), 352 deletions(-)
diff --git a/src/base/
---
src/mds/mds_main.c | 32 +---
1 file changed, 1 insertion(+), 31 deletions(-)
diff --git a/src/mds/mds_main.c b/src/mds/mds_main.c
index 5b0f06220..7f471782c 100644
--- a/src/mds/mds_main.c
+++ b/src/mds/mds_main.c
@@ -363,7 +363,6 @@ uint32_t mds_lib_req(NCS_LIB_R
---
src/clm/clmnd/main.c | 22 +-
1 file changed, 5 insertions(+), 17 deletions(-)
diff --git a/src/clm/clmnd/main.c b/src/clm/clmnd/main.c
index 45f4d2f27..bd847f722 100644
--- a/src/clm/clmnd/main.c
+++ b/src/clm/clmnd/main.c
@@ -634,19 +634,7 @@ static int get_node_info(NOD
---
src/mds/mds_c_db.c | 21 +
src/mds/mds_dt2c.h | 2 +-
src/mds/mds_dt_tcp.h | 2 +-
src/mds/mds_papi.h | 4 ++--
4 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/src/mds/mds_c_db.c b/src/mds/mds_c_db.c
index 46b8eb462..e6b95cdf7 100644
--- a/src/mds/
---
src/ckpt/ckptd/cpd_cb.h | 14 ++
src/ckpt/ckptd/cpd_db.c | 22 +++
src/ckpt/ckptd/cpd_evt.c| 66 +
src/ckpt/ckptd/cpd_mds.c| 6 ++---
src/ckpt/ckptd/cpd_proc.c | 44 +++---
src/ckpt/ckptd
---
src/plm/common/plms.h | 4 ++--
src/plm/plmd/plms_mds.c | 15 +--
2 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/src/plm/common/plms.h b/src/plm/common/plms.h
index d550ea06d..6523a92d6 100644
--- a/src/plm/common/plms.h
+++ b/src/plm/common/plms.h
@@ -257,8 +25
---
src/fm/fmd/fm_mds.c | 2 +-
src/fm/fmd/fmd.conf | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/fm/fmd/fm_mds.c b/src/fm/fmd/fm_mds.c
index 44d272f13..c1b0d9200 100644
--- a/src/fm/fmd/fm_mds.c
+++ b/src/fm/fmd/fm_mds.c
@@ -681,7 +681,7 @@ static uint32_t fm_mds_r
---
src/base/ncs_main_papi.h | 8
src/base/ncsgl_defs.h| 7 ---
2 files changed, 15 deletions(-)
diff --git a/src/base/ncs_main_papi.h b/src/base/ncs_main_papi.h
index 8f8f909a5..c3255d14f 100644
--- a/src/base/ncs_main_papi.h
+++ b/src/base/ncs_main_papi.h
@@ -87,14 +87,6 @@ voi
---
src/msg/agent/mqa_api.cc | 10 +-
src/msg/agent/mqa_db.h | 4 ++--
src/msg/agent/mqa_init.cc| 14 +++---
src/msg/agent/mqa_mds.cc | 14 +++---
src/msg/common/mqsv_common.c | 8
src/msg/common/mqsv_common.h | 2 +-
src/msg/msgd/mqd_mds.c
---
src/msg/Makefile.am | 10 +-
src/msg/agent/{mqa_api.c => mqa_api.cc} | 231 ++--
src/msg/agent/{mqa_clbk.c => mqa_clbk.cc} | 38 +++--
src/msg/agent/mqa_def.h | 13 +-
src/msg/agent/{mqa_init.c => mqa_init.cc} | 20
-
We move towards a flat addressing scheme by using Node ID instead of the legacy
slot-id and subslot-id to identify nodes in the cluster.
revision 80a9c99e61bb5fd0ba9be11b8dbbd883e679ebf2
Author: Anders Widell
Date: Thu, 21 Dec 2017 11:15:30 +0100
fm: Remove code dealing with slot and subs
---
src/imm/immd/immd_cb.h| 4 ++--
src/imm/immd/immd_db.c| 21 -
src/imm/immd/immd_evt.c | 32
src/imm/immd/immd_mds.c | 3 +--
src/imm/immd/immd_proc.c | 9 +++--
src/imm/immd/immd_proc.h | 3 +--
src/imm/immnd/immnd_mds.
In a parallel build, the $(top_builddir)/lib may not yet exist when building
the all-local target. Make sure the directory exists using mkdir -p
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index 45fc5c207..bcfd844cd 100644
--- a/Makefile.am
+++ b/M
n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 7191b00d311d2112af3743a5e8ace1a2de1f8096
Author: Anders Widell
Date:
unchanged).
* Please comment out (insert hash characters before) the two options in
transportd.conf, since they have the default values.
regards,
Anders Widell
On 12/27/2017 12:25 PM, syam-talluri wrote:
---
opensaf.spec.in| 2 +
src/dtm/M
Ack.
regards,
Anders Widell
On 12/28/2017 09:42 AM, Gary Lee wrote:
Source files renamed to .cc
Apply changes required to compile succesfully with g++
---
src/fm/Makefile.am | 8
src/fm/fmd/fm.h | 2 +-
src/fm/fmd/{fm_amf.c => fm_amf
Ok, I will remove them before pushing!
Does anyone have more comments? I will push this on Wednesday if no more
comments are posted.
regards,
Anders Widell
On 01/02/2018 04:10 PM, Alex Jones wrote:
As far as I can see, plms_self_id and plms_remote_id aren't used at all.
Let'
issed. :-)
regards,
Anders Widell
On 01/09/2018 09:15 AM, Mathi N P wrote:
This is a good change, long pending.
The patches look okay. Iam thinking about in-service upgradeability of
especially IMM(FEVS) and CKPT!
Cheers,
Mathi.
On Thu, Dec 21, 2017 at 11:25 AM, Anders Widell
mailto:ander
If the /var/lib/opensaf/node_id file doesn't exist when DTM starts, DTM will
create the file and use the IPv4 address as node ID. When using IPv6, the file
must still be configured manually. IPv6 support may be added in a future ticket.
---
src/dtm/dtmnd/dtm.h | 1 +
src/dtm/dtmnd/dt
Core libraries y
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
-
revision c9161898793a57ce1db18be5343b9ea2a372271e
Author: Anders Widell
Date: Fri, 1
Also fix the CLM API tests so that they longer assume that there is a node with
node ID 0x2010f in the cluster.
---
src/clm/apitest/clmtest.cc | 6 ++
src/clm/apitest/tet_saClmClusterNodeGet.cc | 23 ---
src/clm/apitest/tet_saClmClusterNodeGetAsyn
---
src/ckpt/apitest/test_cpsv.h | 2 +-
src/ckpt/ckptnd/cpnd_res.c | 18 +-
src/ckpt/common/cpsv_evt.c | 2 +-
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/ckpt/apitest/test_cpsv.h b/src/ckpt/apitest/test_cpsv.h
index 27d7c8076..97c78f256 100644
--- a
---
src/lck/apitest/tet_gla.c | 4 ++--
src/lck/apitest/tet_gld.c | 4 ++--
src/lck/apitest/tet_glnd.c | 2 +-
src/lck/apitest/tet_glsv.h | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/lck/apitest/tet_gla.c b/src/lck/apitest/tet_gla.c
index b6c3c4725..deff6e91f 100644
The files chassis_id, slot_id and subslot_id in /etc/opensaf no longer have to
be present. When they are missing, OpenSAF will derive the Node ID from the TIPC
address or the IPv4 address of the node.
---
src/nid/opensafd.in | 49 +++--
1 file changed, 2
---
src/msg/apitest/tet_mqa.c | 4 ++--
src/msg/apitest/tet_mqsv.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/msg/apitest/tet_mqa.c b/src/msg/apitest/tet_mqa.c
index b73e7567e..bd38d94ee 100644
--- a/src/msg/apitest/tet_mqa.c
+++ b/src/msg/apitest/tet_mqa.c
@@ -4,7
Ack.
regards,
Anders Widell
On 01/15/2018 01:03 PM, Hans Nordeback wrote:
---
CPPLINT.cfg | 1 +
1 file changed, 1 insertion(+)
create mode 100644 CPPLINT.cfg
diff --git a/CPPLINT.cfg b/CPPLINT.cfg
new file mode 100644
index 0..532509cd0
--- /dev/null
+++ b/CPPLINT.cfg
@@ -0,0
Found C++ system header after other
header. Should be: service.h, c system, c++ system, other.
[build/include_order] [4]
src/osaf/consensus/service.cc:79: { should almost always be at the end
of the previous line [whitespace/braces] [4]
src/osaf/consensus/service.cc:203: { should almost always be
Ack.
regards,
Anders Widell
On 01/16/2018 12:53 PM, Hans Nordeback wrote:
---
src/fm/fmd/fmd.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fm/fmd/fmd.conf b/src/fm/fmd/fmd.conf
index 63950ef8e..4924abfd9 100644
--- a/src/fm/fmd/fmd.conf
+++ b/src/fm/fmd
used.
regards,
Anders Widell
On 01/19/2018 09:57 AM, Ravi Sekhar Reddy Konda wrote:
Hi Anders,
Ack, reviewed & tested (combinations also)
Update the README(if you are pushing #2759 immediately, you can do after #2759)
one minor comment, in generate_nodeid you hardcoded chassis_id & su
keys in some
directory in the etcd database, so that the same database can be used
for other purposes as well. I think the plugin (shell script) should add
a directory prefix to the key.
Also see one comment inline below, marked AndersW>
regards,
Anders Widell
On 01/19/2018 01:47 PM, Hans Nor
See one comment below, marked AndersW2>
regards,
Anders Widell
On 01/22/2018 07:56 AM, Gary Lee wrote:
HI Anders/Hans
On 20/01/18 00:56, Anders Widell wrote:
Ack from me also, with comments:
* I think my major comment is that I had originally envisioned that
you would use the "
Treat the value zero in /etc/opensaf/slot_id in the same way as if the file is
missing, i.e. use the TIPC address or IPv4 address as node ID.
---
00-README.conf | 15 ---
Makefile.am | 2 +-
src/nid/opensafd.in | 3 +++
3 files changed, 12 insertions(+), 8 deletions(-)
n
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 0131fd2425dfcac9a9428f453d6d3d76cea65655
Auth
.am updates should be moved to this patch.
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
---
src/osaf/consensus/Makefile | 18 +++
src/osaf/consensus/keyvalue.cc | 221 ++
src/osaf/consensus/keyvalue.h|
Ack for this patch with comments, marked AndersW>
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
* consult with consensus service before promoting node to active
* add watch thread and self-fence if it detects active controller
has been changed (if remote fencing
be renamed to key_value.h so that we have consistent
naming of files. Of course, service.cc and keyvalue.cc should be renamed
as well, and the header guards.
regards,
Anders Widell
On 01/24/2018 06:31 AM, Gary Lee wrote:
Hi Anders
Will change according to your comments, one comment below:
Ack for the patch.
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
When a node goes down and split-brain prevention is enabled,
check that we still have write access to the consensus service.
If not and fencing is disabled, reboot the node to prevent
split brain.
---
src/amf
Ack with comments, marked AndersW> below.
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
---
src/fm/Makefile.am| 1 +
src/fm/fmd/fm_main.cc | 37 +++--
src/fm/fmd/fm_rda.cc | 13 +
src/fm/fmd/fmd.conf | 6 ++
Ack for the patch, with the comment that Makefile.am should be updated
in the patch where the new files are introduced (as mentioned in the
comments for that patch).
regards,
Anders Widell
On 01/23/2018 09:06 AM, Gary Lee wrote:
---
00-README.conf | 56
701 - 800 of 993 matches
Mail list logo
