osaf/services/saf/amf/amfd/ndfsm.cc| 4 +++-
osaf/services/saf/amf/amfd/ndproc.cc | 5 -
osaf/services/saf/amf/amfd/node.cc | 12
osaf/services/saf/amf/amfd/nodegroup.cc| 18 +++---
osaf/services/saf/amf/amfd/nodeswbundle.cc | 2 +-
osaf/services/saf/amf/amfd/si.cc | 24
osaf/services/saf/amf/amfd/si_dep.cc | 11 ---
osaf/services/saf/amf/amfd/siass.cc | 4 ++--
osaf/services/saf/amf/amfd/sirankedsu.cc | 15 ---
4 files changed, 30 insertions(+), 24
osaf/services/saf/amf/amfd/cluster.cc| 3 +--
osaf/services/saf/amf/amfd/comp.cc | 17 ++---
osaf/services/saf/amf/amfd/compcstype.cc | 5 +
osaf/services/saf/amf/amfd/comptype.cc | 7 +--
osaf/services/saf/amf/amfd/csi.cc| 20 ++--
osaf/services/saf/amf/amfd/hlt.cc | 1 +
osaf/services/saf/amf/amfd/imm.cc | 1 +
osaf/services/saf/amf/amfd/include/ntf.h | 4 ++--
osaf/services/saf/amf/amfd/include/sg.h | 1 -
osaf/services/saf/amf/amfd/include/susi.h | 4 ++--
5 files changed, 6 insertions(+), 5
osaf/services/saf/amf/amfd/su.cc | 14 --
osaf/services/saf/amf/amfd/sutcomptype.cc| 4 +++-
osaf/services/saf/amf/amfd/sutype.cc | 12 +---
osaf/services/saf/amf/amfd/svctype.cc| 6 +++---
osaf/services/saf/amf/amfd/svctypecstypes.cc |
and valgrind have been run.
changeset 0b48fcffb4ff4a739e56d33e5780e535cd232d3a
Author: Gary Lee gary@dektech.com.au
Date: Fri, 03 Jan 2014 16:26:02 +1100
amfd: Correct a number of issues identified by Coverity [#680]
* Unnecessary header file (HFA)
* Logically dead code
osaf/services/saf/amf/amfnd/comp.cc | 16 ++--
osaf/services/saf/amf/amfnd/compdb.cc | 20 +---
2 files changed, 15 insertions(+), 21 deletions(-)
* Dereference after null check (FORWARD_NULL)
* Logically dead code (DEADCODE)
* Uninitialized scalar variable
osaf/services/saf/amf/amfd/util.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
* use delete[] for variables allocated with new[]
diff --git a/osaf/services/saf/amf/amfd/util.cc
b/osaf/services/saf/amf/amfd/util.cc
--- a/osaf/services/saf/amf/amfd/util.cc
+++
osaf/services/saf/amf/amfd/compcstype.cc | 5 +++--
osaf/services/saf/amf/amfd/hlt.cc| 2 +-
osaf/services/saf/amf/amfd/imm.cc| 9 ++---
3 files changed, 10 insertions(+), 6 deletions(-)
* Calling risky function (SECURE_CODING)
replace calls to sprintf with snprintf
osaf/services/saf/amf/amfnd/di.cc | 5 -
osaf/services/saf/amf/amfnd/hcdb.cc | 3 +--
osaf/services/saf/amf/amfnd/main.cc | 2 +-
osaf/services/saf/amf/amfnd/pg.cc | 5 ++---
osaf/services/saf/amf/amfnd/sidb.cc | 12 +++-
osaf/services/saf/amf/amfnd/sudb.cc | 4 ++--
osaf/services/saf/amf/amfnd/main.cc | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
* Calling risky function (SECURE_CODING)
fix buffer overflow if a string longer than 31 chars is specified for
node_type
diff --git a/osaf/services/saf/amf/amfnd/main.cc
osaf/services/saf/amf/amfd/app.cc | 27 ---
osaf/services/saf/amf/amfd/apptype.cc | 13 -
2 files changed, 16 insertions(+), 24 deletions(-)
* Unnecessary header file (HFA)
* Logically dead code (DEADCODE)
* Dereference null return value (NULL_RETURNS)
osaf/services/saf/amf/amfnd/ckpt_updt.cc | 4 ++--
osaf/services/saf/amf/amfnd/compdb.cc| 6 +++---
osaf/services/saf/amf/amfnd/sidb.cc | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
* use delete[] for variables allocated with new[]
diff --git
osaf/services/saf/amf/amfnd/clc.cc | 11 ---
osaf/services/saf/amf/amfnd/clm.cc | 11 ++-
2 files changed, 10 insertions(+), 12 deletions(-)
* Unnecessary header file (HFA)
* Unchecked return value (CHECKED_RETURN)
* Uninitialized scalar variable (UNINIT)
* Out-of-bounds read
we have tagg'ed 4.4.FC.
/AndersBj
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: den 9 januari 2014 13:06
To: Gary Lee; Hans Nordebäck; praveen.malv...@oracle.com;
nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel
, saAmfSIStandbyWeight, saAmfSvcDefActiveWeight and
saAmfSvcDefStandbyWeight are deleted in si.cc
* fix a few typos where delete is called when delete [] is required
changeset 75ebad333d4fe32a2712cec5739c216bf9873385
Author: Gary Lee gary@dektech.com.au
Date: Mon, 13 Jan 2014 18:19:19 +1100
osaf/services/saf/amf/amfd/csi.cc | 25 -
osaf/services/saf/amf/amfd/include/sg.h | 1 -
osaf/services/saf/amf/amfd/sgtype.cc| 3 ++-
osaf/services/saf/amf/amfd/si.cc| 27 +--
osaf/services/saf/amf/amfd/svctype.cc | 20
6024244cfcc20ae49b9c5d65b3e14f5b0770bd2b
Author: Gary Lee gary@dektech.com.au
Date: Mon, 13 Jan 2014 21:50:14 +1100
* remove saAmfStgValidSuTypes from 'struct avd_amf_sg_type_tag' as it
appears to be a typo of saAmfSGtValidSuTypes
* ensure saAmfCSIDependencies is deleted in csi.cc
osaf/services/saf/amf/amfd/csi.cc | 25 -
osaf/services/saf/amf/amfd/include/sg.h | 1 -
osaf/services/saf/amf/amfd/sgtype.cc| 3 ++-
osaf/services/saf/amf/amfd/si.cc| 27 +--
osaf/services/saf/amf/amfd/svctype.cc | 20
saAmfSIActiveWeight, saAmfSIStandbyWeight,
saAmfSvcDefActiveWeight
and saAmfSvcDefStandbyWeight are deleted in si.cc
* fix a few typos where delete is called when delete [] is requiredOn
13/01/14 21:53, Gary Lee wrote:
osaf/services/saf/amf/amfd/csi.cc | 25
n
Comments (indicate scope for each y above):
-
Ran a set of basic tests with valgrind turned on, and the errors
reported in the ticket are no longer present.
changeset 3299ba6200f9d66580509a2c3a91d2e771550c64
Author: Gary Lee gary
osaf/services/saf/amf/amfnd/amfnd.cc|4 +-
osaf/services/saf/amf/amfnd/cbq.cc |4 +-
osaf/services/saf/amf/amfnd/ckpt_updt.cc|4 +-
osaf/services/saf/amf/amfnd/comp.cc | 14 +-
osaf/services/saf/amf/amfnd/compdb.cc |6 +-
osaf/services/saf/amf/amfd/nodegroup.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
don't read beyond the end of saAmfNGNodeList, if the node to be removed from
node group
is at the end of the array.
diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc
n
Other n
Comments (indicate scope for each y above):
-
changeset 7ace16491a5d95040dd1701c4fd8c081bd6d1d0d
Author: Gary Lee gary@dektech.com.au
Date: Thu, 16 Jan 2014 16:29:35 +1100
amfd: Invalid read when deleting
situations, and replaced
with osafassert(p != NULL)
* added more comments to indicate when free() is used
on AVSV_ATTR_NAME_VAL pointers
changeset d5b481b75da0ee4518dc65567ee41a4db1974eb1
Author: Gary Lee gary@dektech.com.au
Date: Tue, 28 Jan 2014 14:03:21 +1100
amfnd: fix errors reported
osaf/services/saf/amf/amfnd/amfnd.cc|4 +-
osaf/services/saf/amf/amfnd/cbq.cc |4 +-
osaf/services/saf/amf/amfnd/ckpt_updt.cc| 18 +-
osaf/services/saf/amf/amfnd/comp.cc | 11 +-
osaf/services/saf/amf/amfnd/compdb.cc |6 +-
Comments (indicate scope for each y above):
-
This patch series corrects Unnecessary header file (HFA) errors
reported by Coverity.
changeset 95725e699d9b738dcad359cac228266e7890220b
Author: Gary Lee gary@dektech.com.au
Date: Mon, 10 Feb 2014 13
: Gary Lee gary@dektech.com.au
Date: Tue, 11 Feb 2014 13:43:29 +1100
amfd: fix big parameter passed by value errors
this patch fixes Big parameter passed by value (PASS_BY_VALUE) errors
reported by Coverity, by coverting pass by value parameters to pass by
const
osaf/services/saf/amf/amfd/siass.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/siass.cc
b/osaf/services/saf/amf/amfd/siass.cc
--- a/osaf/services/saf/amf/amfd/siass.cc
+++ b/osaf/services/saf/amf/amfd/siass.cc
@@ -259,6 +259,7 @@
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset c5e9c0567f4236a809d38eee8d6a822dc9c53008
Author: Gary Lee gary@dektech.com.au
Date: Fri, 28 Feb 2014 15:12:13 +1100
amfd
with them?
Praveen?
Thanks,
Hans
On 28 February 2014 05:19, Gary Lee gary@dektech.com.au wrote:
osaf/services/saf/amf/amfd/siass.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/siass.cc
b/osaf/services/saf/amf/amfd/siass.cc
osaf/services/saf/amf/amfd/imm.cc| 40 ++-
osaf/services/saf/amf/amfd/include/imm.h | 16
2 files changed, 49 insertions(+), 7 deletions(-)
Currently, admin operation responses from amfd are not synchronised with
IMM changes that may be
osaf/services/saf/amf/amfd/imm.cc| 30 ++
osaf/services/saf/amf/amfd/include/imm.h | 2 +-
2 files changed, 3 insertions(+), 29 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
---
n
Comments (indicate scope for each y above):
-
changeset cd039d9f162b401419b1b0665190ceec20169846
Author: Gary Lee gary@dektech.com.au
Date: Mon, 31 Mar 2014 14:57:48 +1100
amfd: use job queue for IMM admin response [#817
agree?
Thanks,
Hans
On 31 March 2014 06:32, Gary Lee gary@dektech.com.au wrote:
osaf/services/saf/amf/amfd/imm.cc| 30
++
osaf/services/saf/amf/amfd/include/imm.h | 2 +-
2 files changed, 3 insertions(+), 29 deletions(-)
diff --git a/osaf
n
Other n
Comments (indicate scope for each y above):
-
changeset 692778b63490b8a45435dbecbccc56e56b831d1d
Author: Gary Lee gary@dektech.com.au
Date: Wed, 16 Apr 2014 16:11:25 +1000
amfd: use job queue for IMM admin
osaf/services/saf/amf/amfd/imm.cc| 45 +++
osaf/services/saf/amf/amfd/include/imm.h | 16 +++
2 files changed, 54 insertions(+), 7 deletions(-)
Currently, admin operation responses from amfd are not synchronised with
IMM changes that may be
osaf/services/saf/amf/amfd/imm.cc | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
It has been found that an admin operation (other than controller switch-over)
can be started after a controller switch-over has been initiated.
The result of this can be that the admin
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset bb22e56cb9a68cd2230f9eb2dd930d2817750c83
Author: Gary Lee gary@dektech.com.au
Date: Tue, 22 Apr 2014 13:25:02 +1000
amfd
n
Tests n
Other n
Comments (indicate scope for each y above):
-
EXPLAIN/COMMENT THE PATCH SERIES HERE
changeset ed011a4d972f515395c9be7b3ed06b3ffdda5934
Author: Gary Lee gary@dektech.com.au
Date: Wed
) {
LOG_NO(SI Swap not possible, Controller role switch
under progress);
rc = SA_AIS_ERR_TRY_AGAIN;
goto done;
}
}
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary
osaf/services/saf/amf/amfnd/cbq.cc | 7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
If a SI is in SHUTTING-down mode and a lock request arrives,
the component is required to call saAmfCSIQuiescingComplete() which
shouldn't be needed.
Therefore we should stop the qscing complete
Other n
Comments (indicate scope for each y above):
-
changeset b1b63571db541aea1c11ea47fdaef92ce5ac9b08
Author: Gary Lee gary@dektech.com.au
Date: Thu, 08 May 2014 15:52:36 +1000
amfd: Remove asserts from validation
osaf/services/saf/amf/amfd/app.cc| 18 +++---
osaf/services/saf/amf/amfd/comp.cc | 5 +++--
osaf/services/saf/amf/amfd/compcstype.cc | 5 +++--
osaf/services/saf/amf/amfd/hlt.cc| 10 ++
osaf/services/saf/amf/amfd/sg.cc | 9 +
Ack.
Thanks
Gary
On 12/05/14 19:55, Hans Feldt wrote:
osaf/services/saf/amf/amfd/imm.cc | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/imm.cc
b/osaf/services/saf/amf/amfd/imm.cc
--- a/osaf/services/saf/amf/amfd/imm.cc
+++
of OpenSAF. But perhaps that is not a valid use case.
Thanks
Gary
On 15/05/14 22:10, Nagendra Kumar wrote:
Some comments inlined with Nagu
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 08 May 2014 12:14
To: hans.fe...@ericsson.com; hans.nordeb
n
Comments (indicate scope for each y above):
-
changeset a34d5c6ada7bd10ac0518bb70830bcc9253627f7
Author: Gary Lee gary@dektech.com.au
Date: Thu, 22 May 2014 17:17:24 +1000
amfd: use correct SU when calling set_su_failover [#713
osaf/services/saf/amf/amfd/su.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
A typo was introduced when some SU logic was
moved from comp.cc to su.cc. This may have caused
a segfault when set_su_failover() is called
on a null pointer.
set_su_failover() should be called on this SU
osaf/services/saf/amf/amfnd/err.cc| 61 +++---
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23 ++
4 files changed, 82 insertions(+), 7
osaf/services/saf/amf/amfnd/err.cc | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
* fix spelling mistakes
diff --git a/osaf/services/saf/amf/amfnd/err.cc
b/osaf/services/saf/amf/amfnd/err.cc
--- a/osaf/services/saf/amf/amfnd/err.cc
+++ b/osaf/services/saf/amf/amfnd/err.cc
@@
n
Other n
Comments (indicate scope for each y above):
-
changeset 48092e505f992410f12cd05b94933917f95dba4b
Author: Gary Lee gary@dektech.com.au
Date: Mon, 26 May 2014 13:28:06 +1000
amfnd: Improve logging
On 26/05/14 13:46, Gary Lee wrote:
diff --git a/osaf/services/saf/amf/amfnd/su.cc
b/osaf/services/saf/amf/amfnd/su.cc
--- a/osaf/services/saf/amf/amfnd/su.cc
+++ b/osaf/services/saf/amf/amfnd/su.cc
@@ -462,6 +462,8 @@ uint32_t avnd_evt_tmr_su_err_esc_evh(AVN
}
TRACE('%s
n
Other n
Comments (indicate scope for each y above):
-
This is V2.
changeset 24c1b4c093478d6b4b0933e52f9809f60fefa228
Author: Gary Lee gary@dektech.com.au
Date: Wed, 28 May 2014 17:25:36 +1000
amfnd
osaf/services/saf/amf/amfnd/err.cc | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/amf/amfnd/err.cc
b/osaf/services/saf/amf/amfnd/err.cc
--- a/osaf/services/saf/amf/amfnd/err.cc
+++ b/osaf/services/saf/amf/amfnd/err.cc
@@ -1152,7 +1152,7 @@ uint32_t
osaf/services/saf/amf/amfnd/err.cc| 77 --
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23
4 files changed, 98 insertions(+), 7
Hi again :)
On 30/05/14 11:05, Gary Lee wrote:
2. too many times doesn't look good.
LOG_NO(components of '%s' restarted too many times (comp restart count: %d)
should be changed to
LOG_NO(components of '%s' restarted exceeds configured '%u' (comp
restart count: %u),
su
osaf/services/saf/amf/amfnd/err.cc| 48 +++---
osaf/services/saf/amf/amfnd/include/avnd_cb.h | 2 +
osaf/services/saf/amf/amfnd/include/avnd_su.h | 3 +
osaf/services/saf/amf/amfnd/su.cc | 23
4 files changed, 69 insertions(+), 7
osaf/services/saf/amf/amfnd/err.cc | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/amf/amfnd/err.cc
b/osaf/services/saf/amf/amfnd/err.cc
--- a/osaf/services/saf/amf/amfnd/err.cc
+++ b/osaf/services/saf/amf/amfnd/err.cc
@@ -1150,7 +1150,7 @@ uint32_t
Hi Nagu
Sorry, I forgot to change the 3 instances of '%d' below, to '%u'.
Can you please change before pushing, or should I send another patch?
Thanks
Gary
On Mon, 2014-06-02 at 13:08 +1000, Gary Lee wrote:
+
+void su_increment_su_restart_count(AVND_SU su)
+{
+ su.su_restart_cnt
osaf/services/saf/amf/amfd/include/si.h | 5 +++-
osaf/services/saf/amf/amfd/si.cc| 43 ++--
2 files changed, 38 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
osaf/services/saf/amf/amfd/include/app.h| 6 ++--
osaf/services/saf/amf/amfd/include/sg.h | 31 ++--
osaf/services/saf/amf/amfd/include/si.h | 14 ++--
osaf/services/saf/amf/amfd/include/si_dep.h | 22 ++--
osaf/services/saf/amf/amfd/include/si.h | 5 ++-
osaf/services/saf/amf/amfd/si.cc| 45
2 files changed, 9 insertions(+), 41 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
n
Comments (indicate scope for each y above):
-
changeset da7b0f5e0a729dfcfc5e9674b584a1ceeca3c650
Author: Gary Lee gary@dektech.com.au
Date: Tue, 10 Jun 2014 11:26:03 +1000
amfd: Convert AVD_SI from struct to a class [#713
Hi
You can also get a snapshot of the latest code (not tested / not yet
released) from:
http://sourceforge.net/p/opensaf/staging/ci/default/tarball
On 10/06/14 12:44, Yao Cheng LIANG wrote:
Dear AVM,
Thanks. But could you tell me the command to download it? I am not familiar
with
osaf/services/saf/amf/amfd/include/si.h | 7 -
osaf/services/saf/amf/amfd/si.cc| 43 ++--
2 files changed, 40 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
Comments (indicate scope for each y above):
-
This is V2. The copy constructor and assignment
operator are now private.
changeset 6495aee4e47c098413c95979378d4de26cbf4537
Author: Gary Lee gary@dektech.com.au
Date: Wed, 11 Jun 2014 10:11:05 +1000
e9fa0d9f2cda7a41768e5409625951f8b92d4065
Author: Gary Lee gary@dektech.com.au
Date: Wed, 11 Jun 2014 15:19:27 +1000
amfd: Change avd_si_adjust_si_assignments to a member function [#713]
Make avd_si_adjust_si_assignments a class member function of AVD_SI
changeset aaa8b697076cf3c9c37f515c5ca1ae2ef6941cf3
Author
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/si.cc| 88
2 files changed, 44 insertions(+), 45 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
osaf/services/saf/amf/amfd/include/si.h | 1 -
osaf/services/saf/amf/amfd/si.cc| 20
2 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
osaf/services/saf/amf/amfd/include/si.h | 2 +
osaf/services/saf/amf/amfd/si.cc| 46 +++-
2 files changed, 24 insertions(+), 24 deletions(-)
Make avd_si_adjust_si_assignments a class member function of AVD_SI
diff --git
osaf/services/saf/amf/amfd/include/si.h | 7 +
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 2 +-
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 38 +++---
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 28 +++---
osaf/services/saf/amf/amfd/si.cc
osaf/services/saf/amf/amfd/include/si.h | 3 +-
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 17 +++---
osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 14 ++--
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 10
osaf/services/saf/amf/amfd/sg_nway_fsm.cc|
osaf/services/saf/amf/amfd/include/si.h | 5 +++--
osaf/services/saf/amf/amfd/si.cc | 14 +++---
osaf/services/saf/amf/amfd/sirankedsu.cc | 4 ++--
3 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
Comments (indicate scope for each y above):
-
This patch set is part 4 of SI refactoring.
changeset 2c574664d8c2c58b36c962d3f212309ad204b01d
Author: Gary Lee gary@dektech.com.au
Date: Fri, 13 Jun 2014 15:39:39 +1000
amfd: move svctype
osaf/services/saf/amf/amfd/include/si.h| 34 +--
osaf/services/saf/amf/amfd/include/svctype.h | 38 ++
osaf/services/saf/amf/amfd/include/svctypecstype.h | 35
3 files changed, 75 insertions(+), 32 deletions(-)
Move
osaf/services/saf/amf/amfd/include/si.h | 10 +-
osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10 +-
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +-
osaf/services/saf/amf/amfd/si.cc | 20
4 files changed, 35 insertions(+),
wrote:
You can print si name also. Is there any reason to delete it from :
- TRACE_ENTER2(%s AdmState %s = %s, si-name.value,
- avd_adm_state_name[si-saAmfSIAdminState],
avd_adm_state_name[state]);
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary
Hi Hans
On 13/06/14 20:49, Hans Feldt wrote:
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
--- a/osaf/services/saf/amf/amfd/include/si.h
+++ b/osaf/services/saf/amf/amfd/include/si.h
@@ -122,6 +122,11 @@ public:
void
Thanks Hans. I'll add svctype.h and svctypecstype.h to include/Makefile.am
Thanks
Gary
On 16/06/14 18:36, Hans Nordebäck wrote:
ack, minor comment, the Makefile.am should be updated with the new
header files. /Regards HansN
On 06/13/14 07:48, Gary Lee wrote:
osaf/services/saf/amf/amfd
osaf/services/saf/amf/amfd/csi.cc | 4 ++--
osaf/services/saf/amf/amfd/include/si.h | 11 +++
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 4 ++--
osaf/services/saf/amf/amfd/si.cc | 25 -
osaf/services/saf/amf/amfd/si_dep.cc | 2 +-
5
osaf/services/saf/amf/amfd/ckpt_edu.cc | 64 --
osaf/services/saf/amf/amfd/ckpt_enc.cc | 204
2 files changed, 78 insertions(+), 190 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/ckpt_edu.cc
b/osaf/services/saf/amf/amfd/ckpt_edu.cc
---
Comments (indicate scope for each y above):
-
changeset 77a5839859012d839aeb7798b6fa0d8c141d4156
Author: Gary Lee gary@dektech.com.au
Date: Thu, 26 Jun 2014 12:08:42 +1000
amfd: Convert remove_csi and add_csi to static member functions [#713
osaf/services/saf/amf/amfd/csi.cc | 4 ++--
osaf/services/saf/amf/amfd/include/si.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
These functions don't operate directly on this SI instance.
Let's make them static member functions for now.
diff --git
-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 26 juni 2014 04:11
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: Convert remove_csi and add_csi to static
member functions [#713]
osaf/services/saf/amf/amfd
(indicate scope for each y above):
-
This should be applied on top of the SI refactoring part 5 patches (25/6/14).
changeset d0e41ace78497c11eda3c5e017e51a987b7978d4
Author: Gary Lee gary@dektech.com.au
Date: Fri, 27 Jun 2014 15:33:58 +1000
(indicate scope for each y above):
-
This patchset should be applied on top of part 5 and 6.
changeset 79f9022cbad2eb9b51e23455321a76022e1325b4
Author: Gary Lee gary@dektech.com.au
Date: Wed, 02 Jul 2014 14:57:03 +1000
amfd: change
osaf/services/saf/amf/amfd/include/si.h | 2 ++
osaf/services/saf/amf/amfd/si.cc| 10 ++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
b/osaf/services/saf/amf/amfd/include/si.h
---
n
Comments (indicate scope for each y above):
-
changeset cb692c0417a755aeb376cdf4e08116c254c13159
Author: Gary Lee gary@dektech.com.au
Date: Thu, 03 Jul 2014 11:42:27 +1000
amfd: Change various AVD_APP functions to member
Minor comment below.
On 02/07/14 15:30, Gary Lee wrote:
diff --git a/osaf/services/saf/amf/amfd/include/app.h
b/osaf/services/saf/amf/amfd/include/app.h
--- a/osaf/services/saf/amf/amfd/include/app.h
+++ b/osaf/services/saf/amf/amfd/include/app.h
@@ -32,17 +32,26 @@
#include si.h
Comments (indicate scope for each y above):
-
changeset c4124046e4ffaa1d829eef4761a56f251d9cd4fe
Author: Gary Lee gary@dektech.com.au
Date: Mon, 04 Aug 2014 15:18:39 +1000
amfd: Ensure SaNameT is null terminated [#713]
Ensure
osaf/services/saf/amf/amfd/app.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Ensure app.name.value is null terminated. It seems some code
assumes SaNameT.value is null terminated, eg. ccbutil_getCcbOpDataByDN()
in immutil.c.
diff --git a/osaf/services/saf/amf/amfd/app.cc
n
Comments (indicate scope for each y above):
-
changeset e6d631809d7fbf21d33f90aec72b7504614c63e7
Author: Gary Lee gary@dektech.com.au
Date: Wed, 06 Aug 2014 18:01:01 +1000
amfnd: Log events relating to error escalation timers
osaf/services/saf/amf/amfnd/err.cc | 18 +++---
osaf/services/saf/amf/amfnd/include/avnd_tmr.h | 37
osaf/services/saf/amf/amfnd/mbcsv.cc | 4 +-
osaf/services/saf/amf/amfnd/su.cc | 2 +-
osaf/services/saf/amf/amfnd/susm.cc| 4 +-
Other n
Comments (indicate scope for each y above):
-
changeset bfa60301737086250148e0937c3f44cf6d08c94b
Author: Gary Lee gary@dektech.com.au
Date: Wed, 13 Aug 2014 12:02:13 +1000
amfnd: Fix compilation issue on opensaf
osaf/services/saf/avsv/avnd/avnd_tmr.c | 10 +-
osaf/services/saf/avsv/avnd/include/avnd_tmr.h | 12 ++--
2 files changed, 11 insertions(+), 11 deletions(-)
structs need to be explicitly declared 'struct' in C.
diff --git a/osaf/services/saf/avsv/avnd/avnd_tmr.c
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/include/si_dep.h | 1 -
osaf/services/saf/amf/amfd/si_dep.cc| 14 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/include/si_dep.h | 1 -
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 6 +++---
osaf/services/saf/amf/amfd/si_dep.cc| 10 +-
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/include/si_dep.h | 1 -
osaf/services/saf/amf/amfd/si_dep.cc| 12 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
osaf/services/saf/amf/amfd/include/si.h | 3 +-
osaf/services/saf/amf/amfd/include/si_dep.h | 3 +-
osaf/services/saf/amf/amfd/si_dep.cc| 79 ++--
3 files changed, 43 insertions(+), 42 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
osaf/services/saf/amf/amfd/include/si.h | 1 +
osaf/services/saf/amf/amfd/include/si_dep.h | 1 -
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 6 +++---
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 4 ++--
osaf/services/saf/amf/amfd/si_dep.cc| 14 +++---
5 files
1 - 100 of 904 matches
Mail list logo
