Hi Minh,
Please find below my comments inline.
Thank you
Srinivas
-Original Message-
From: minh chau [mailto:minh.c...@dektech.com.au]
Sent: Thursday, September 28, 2017 6:49 AM
To: Srinivas
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: correct return code is re
Hi Minh,
I have corrected the permissions of the file.
Thank you
Srinivas
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: Tuesday, October 3, 2017 7:21 AM
To: Srinivas ; lennart.l...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PAT
Hi Minh,
Thank you for your comments, I will incorporate the comments and will push the
file.
Thank you
Srinivas
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: Tuesday, October 3, 2017 1:10 PM
To: Srinivas Mangipudy ;
lennart.l...@ericsson.com
Cc
Hi Alex,
Please find my comments below, preceded with [Srinivas].
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Friday, October 6, 2017 7:05 PM
To: Venkata Mahesh Alla
Cc: Alex Jones ; opensaf-devel@lists.sourceforge.net
Subject: [devel]
Hi Alex,
Ack from my side ( review only ) , I tried to reproduce the issue, but could
not.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Tuesday, October 10, 2017 4:55 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net
Hi Hieu,
Reviewed and tested.
I am fine with the patch.
Thank you
Srinivas.
-Original Message-
From: Hieu Nguyen [mailto:hieu.t.ngu...@dektech.com.au]
Sent: Tuesday, October 3, 2017 9:20 AM
To: hans.nordeb...@ericsson.com; anders.wid...@ericsson.com
Cc: opensaf-devel@lists.sourceforg
Ack from my side ( code review only ).
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Wednesday, October 18, 2017 9:44 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msg: allow real
Hi Alex,
I need one more day to complete my review.
Thank you
Srinivas
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Wednesday, November 1, 2017 8:07 PM
To: srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/1] Review Request for msg: fix
Hi Alex,
Ack, code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Friday, October 27, 2017 7:30 PM
To: srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msg: fix ERR_UNAVAILABLE code
Lock on active node not
allowed
Nov 8 14:43:20 osaf-VirtualBox osafclmd[3943]: NO clms_imm_node_lock failed
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Tuesday, November 7, 2017 11:45 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.s
Hi Alex,
I agree, but should we not skip running this test, in case if we are executing
it on active controller?
Thank you
Srinivas
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Wednesday, November 8, 2017 6:44 PM
To: Srinivas Mangipudy
Cc: opensaf-devel
Hi Alex,
ACK from my side.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Tuesday, November 7, 2017 11:45 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msg: add support for critical
Hi Alex,
Ack, Code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:alex.jo...@genband.com]
Sent: Thursday, November 30, 2017 1:14 AM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msgd: fix double delete of
Hi Canh,
Ack from my end, not tested.
Thank you
Srinivas
-Original Message-
From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
Sent: Thursday, November 23, 2017 4:17 PM
To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au;
srinivas.mangip...@oracle.com
Cc: opensaf-devel@
Hi Lennart,
I agree. Since there is already a ticket 1531 to handle this scenario in a
separate thread, I will close this issue as duplicate.
Thank you
Srinivas
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: Wednesday, December 13, 2017 4:30 PM
To: Srin
Hi Canh,
Ack from my end, did not test.
Thank you
Srinivas
-Original Message-
From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
Sent: Monday, December 18, 2017 10:22 AM
To: minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] ntf: fix [
Hi Canh,
Ack from my end, not tested.
Regards
Srinivas
-Original Message-
From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au]
Sent: Friday, December 22, 2017 12:00 PM
To: minh.c...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] ntf: fix NtfAd
Hi Minh,
Ack from my end.
Thank you
Srinivas
-Original Message-
From: Minh Chau [mailto:minh.c...@dektech.com.au]
Sent: Thursday, January 4, 2018 12:06 PM
To: lennart.l...@ericsson.com; srinivas.mangip...@oracle.com;
canh.v.tru...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net;
Hi Canh,
Ack from my end, but I suspect a potential memory leak.
Say we are creating many log streams in a single CCB operation and there is a
switch over, then we will not delete the elements in the vector, since we will
call "goto done" and the memory is cleared before the "done" label.
if (
Srinivas
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: Monday, January 29, 2018 9:31 AM
To: Lennart Lund ; Srinivas Mangipudy
; Canh Van Truong
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync
...@dektech.com.au]
Sent: Tuesday, January 30, 2018 4:17 AM
To: Srinivas Mangipudy ; Lennart Lund
; Canh Van Truong
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync
reader information [#2757]
Hi Srinivas,
Those symbols should be
Hi Minh,
The LD_LIBRARY_PATH env was pointing to the old .so and hence I got the
problem. Now it is resolved and the code built successfully.
Thank you
Srinivas
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: Thursday, February 1, 2018 2:27 AM
To: Srinivas Mangipudy
Hi Alex,
Ack from me, code review only.
Thank you
Srinivas
From: Alex Jones [mailto:ajo...@rbbn.com]
Sent: Wednesday, January 31, 2018 8:02 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/1] Review Request for msg: implement metadata size and
Hi Anders,
The “src/imm/README” has the following statement:
"This would be processes for loading, sync and dump/pbe.
To enable such trace uncomment:
#export IMMSV_TRACE_PATHNAME=$pkglogdir/osafimmnd"
The "src/imm/immnd/immnd.conf" has the following section:
"# Unc
Hi Minh,
Ack from my end.
Thank you
Srinivas
-Original Message-
From: Minh Chau [mailto:minh.c...@dektech.com.au]
Sent: Monday, February 12, 2018 8:38 AM
To: canh.v.tru...@dektech.com.au
Cc: Minh Chau ; opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 0/1] Review Request for
Hi Anders,
I have incorporated your review comments and pushed the patch.
Thank you
Srinivas
-Original Message-
From: Anders Widell [mailto:anders.wid...@ericsson.com]
Sent: Monday, February 12, 2018 6:26 PM
To: srinivas
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1]
Thank you Vu, Zoran for your comments.
I will make code changes to return NCSCC_RC_NO_OBJECT from
immsv_evt_enc_name_list.
Thank you
Srinivas
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: Tuesday, February 27, 2018 2:45 PM
To: Vu Minh Nguyen ;
Hi Vu,
I updated OpenSAF_IMMsv_PR.odt and the document is at:
https://sourceforge.net/p/opensaf/documentation/ci/default/tree/OpenSAF_IMMSv_PR.odt
Can you please review.
Thank you
Srinivas
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: Thursday, Ma
Hi Alex,
Ack from my side, code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:ajo...@rbbn.com]
Sent: Wednesday, March 7, 2018 5:46 AM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 0/1] Review Request for msgd
Hi Alex,
Ack from my side, code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:ajo...@rbbn.com]
Sent: Tuesday, March 20, 2018 9:25 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msgnd: prevent race
Hi Alex,
Ack from my end, code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:ajo...@rbbn.com]
Sent: Wednesday, April 25, 2018 8:08 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msgd: handle abrupt
Hi Alex,
Ack from my side, code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:ajo...@rbbn.com]
Sent: Friday, May 11, 2018 9:03 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msg: update msg to use CLM B
Hi Alex,
Ack from my side, code review only.
Thank you
Srinivas
-Original Message-
From: Alex Jones [mailto:ajo...@rbbn.com]
Sent: Friday, May 11, 2018 8:42 PM
To: Srinivas Mangipudy
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] msgd: put node down handling
33 matches
Mail list logo
