[opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

2011-06-29 Thread Kadah Coba
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/377/ --- Review request for Viewer. Summary --- This is a direct adaptation of

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Nicky Perian
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review829 --- \n is a new line character(line-feed) \r is a carriage return. may

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Kadah Coba
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/ --- (Updated June 29, 2011, 4:54 p.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- (Updated June 29, 2011, 12:14 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Basic Shaders and FPS

2011-06-29 Thread Hitomi Tiponi
That is why there are the Low-Medium-High-Ultra settings - so that people don't need to know about shaders, just that sliding the slider right makes things look better but slower. The individual settings for each standard setting (e.g. Low) could be debated, but the approach seems to work pr

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Kadah Coba
> On June 29, 2011, 6:37 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanelpermissions.cpp, line 245 > > > > > > Coding standard: rewrite as btn_mark_for_sale. Will do. As far as the XUI names, is there a stan

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Kadah Coba
> On June 29, 2011, 6:41 a.m., Oz Linden wrote: > > indra/newview/llpanelpermissions.cpp, lines 477-480 > > > > > > There's nothing else inside this 'else if' - why not add the check of > > update_sale_info to this st

Re: [opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/#review826 --- Looks good apart from missing NULL check. indra/newview/llpanelw

[opensource-dev] Review Request: STORM-1459 "Wearing Tab" - Add ability to copy displayed inventory names to clipboard

2011-06-29 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/370/ --- Review request for Viewer. Summary --- Add a feature on the "Wearing T

[opensource-dev] Basic Shaders and FPS

2011-06-29 Thread Lee ponzu
This is something I just discovered that I suppose most of you have always known. I was messing with my oldish iMac (ATI 2600 Pro) and I discovered that the main thing that makes all the difference to FPS is the shaders. Basic Shaders off: FPS == 30 to 50. Basic Shaders on: FPS == 13 to 15 Sim

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review824 --- Just a couple of minor items to address and this looks good. rem

[opensource-dev] Avatar Scale and Camera Placement

2011-06-29 Thread Lee ponzu
There is a thought provoking discussion of avatar scale here... http://www.sluniverse.com/php/vb/content-creation/61046-matter-scale-how-scale-affects.html You've probably seen it, but if not, it is a worthwhile read. One of the issues is default camera placement. In brief, the default is too far

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review825 --- Looking good overall. Please fix the minor issues. indra/newview

Re: [opensource-dev] Review Request: VWR-25923 Unnecessary capability request spam

2011-06-29 Thread Vadim ProductEngine
> On June 25, 2011, 8:30 a.m., Tankmaster Finesmith wrote: > > When I applied this latest patch to firestorm, which is based off of LL > > 2.5.2, I kept getting timed out when TPing from a mainland area and a DD of > > 256 to other regions. I tried multiple times TPing from the area around >