Re: [Openvpn-devel] any reason to not adding tap-windows.h to https://github.com/OpenVPN/openvpn/tree/master/include ?

2016-11-06 Thread Илья Шипицин
2016-11-05 15:53 GMT+05:00 Steffan Karger <stef...@karger.me>: > Hi, > > On 05-11-16 11:34, Илья Шипицин wrote: > > > > 2016-11-05 13:08 GMT+05:00 Steffan Karger <stef...@karger.me > > <mailto:stef...@karger.me>>: > > > > On 05-11-16 06

Re: [Openvpn-devel] any reason to not adding tap-windows.h to https://github.com/OpenVPN/openvpn/tree/master/include ?

2016-11-05 Thread Илья Шипицин
2016-11-05 13:08 GMT+05:00 Steffan Karger <stef...@karger.me>: > Hi, > > On 05-11-16 06:52, Илья Шипицин wrote: > > I'm geting "build only" travis-ci mingw cross compile config > > and I came to idea that I do not understand why "tap-windows.h" mus

[Openvpn-devel] any reason to not adding tap-windows.h to https://github.com/OpenVPN/openvpn/tree/master/include ?

2016-11-04 Thread Илья Шипицин
Hello, I'm geting "build only" travis-ci mingw cross compile config and I came to idea that I do not understand why "tap-windows.h" must be downloaded separately 1) if we use some functions, we should include prototypes. it is not very common to download prototypes from different location 2)

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Илья Шипицин
t; Community Manager > OpenVPN Technologies, Inc > > irc freenode net: mattock > > > Il 12/10/2016 13:43, Илья Шипицин ha scritto: > >> it should have been fixed with >> https://github.com/OpenVPN/openvpn-gui/commit/727eaee0c54b0a >> ee01ad28f622c1da7011e7b7c1

Re: [Openvpn-devel] Help testing OpenVPN 2.4-alpha1 preview installers?

2016-10-12 Thread Илья Шипицин
it should have been fixed with https://github.com/OpenVPN/openvpn-gui/commit/727eaee0c54b0aee01ad28f622c1da7011e7b7c1 @mattock ? 2016-10-12 15:30 GMT+05:00 Ton van Vliet : > On 11-10-16 12:36, Samuli Seppänen wrote: > > However, we'd need to help with testing these preview

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-26 Thread Илья Шипицин
2016-09-26 12:37 GMT+05:00 Samuli Seppänen <sam...@openvpn.net>: > Il 24/09/2016 09:32, Илья Шипицин ha scritto: > >> can we merge it ? >> >> 2016-09-17 16:17 GMT+05:00 Steffan Karger <stef...@karger.me >> <mailto:stef...@karger.me>>: >> &g

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-24 Thread Илья Шипицин
can we merge it ? 2016-09-17 16:17 GMT+05:00 Steffan Karger : > Hi, > > On 17 September 2016 at 12:54, Ilya Shipitsin > wrote: > > --- > > .travis.yml | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index

[Openvpn-devel] extended error messages ?

2016-09-23 Thread Илья Шипицин
Hello, is there a way to tell user that login/password are correct, but ... 1) password is expired 2) acount is disabled 3) access is not permitted is 2FA mechanism suitable for that ? is somebody already working on above mentioned error handling ? Cheers, Ilya Shipitsin

Re: [Openvpn-devel] [PATCH] cppcheck finding: add "ASSERT( maxoutput > 0 || separator != NULL )" to prevent possible null pointer derefence

2016-09-18 Thread Илья Шипицин
Hello, this defect was found by cppcheck, however cppcheck still complains. so, we did not make it happy yet. I think, the best would be split this function into 2 separate functions (with either null argument) or leave it like that. 2016-09-18 20:14 GMT+05:00 David Sommerseth <

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-18 Thread Илья Шипицин
we already run openvpn/openvpn-build in travis. build only is not complicated. there are minor issues with 14.04 mingw gcc, which is too old for openvpn master. I'll make patch after I will resolve it. 2016-09-17 18:58 GMT+05:00 Gert Doering : > Hi, > On Sat, Sep 17, 2016

Re: [Openvpn-devel] [PATCH] Fix win32 building with C99 mode

2016-09-17 Thread Илья Шипицин
Should we add mingw compiler to travis-ci matrix? 17 сент. 2016 г. 6:34 PM пользователь "Gert Doering" написал: In -std=c99 mode, WIN32 is not defined to be "1" anymore, but just "#define WIN32" - so the "#if WIN32" breaks, needs to be "#ifdef WIN32" Signed-off-by: Gert

[Openvpn-devel] how is debug/doval and debug/dovalns are supposed to be used ?

2016-09-17 Thread Илья Шипицин
Hello, I see couple of valgrind-like tests debug/dovalns debug/doval however, I do not see any usage of them [ilia@localhost openvpn]$ find . -type f -exec grep doval {} ';' -print Binary file ./.git/index matches ./.git/index [ilia@localhost openvpn]$ I would like to valgrind tests to

Re: [Openvpn-devel] [PATCH] enable "--disable-crypto" build configuration

2016-09-17 Thread Илья Шипицин
2016-09-17 16:17 GMT+05:00 Steffan Karger : > Hi, > > On 17 September 2016 at 12:54, Ilya Shipitsin > wrote: > > --- > > .travis.yml | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 452c48e..369db97

Re: [Openvpn-devel] [PATCH] Change timestamps to POSIX format.

2016-08-11 Thread Илья Шипицин
iso 8601 is good format. it is accepted by default by sql servers, Log Parser 2016-08-12 0:23 GMT+05:00 Gert Doering : > All our timestams used to be "what ctime()" produces, which is > > "Thu Aug 11 21:15:27 2016" > > Changed to use POSIX standard format, which is > >

Re: [Openvpn-devel] Win10 Tun Server +Standard W10 User +OVPN Interactive Service +OVPN GUI

2016-08-07 Thread Илья Шипицин
I also noticed, that "openvpn administrators" membership is required. Should we modify installer to make it adf current user to that group? 7 авг. 2016 г. 17:48 пользователь "debbie10t" написал: > > > On 05/08/16 03:04, Selva Nair wrote: > > On Thu, Aug 4, 2016 at 6:53 PM,

Re: [Openvpn-devel] git master: no more WinXP ?

2016-06-29 Thread Илья Шипицин
it is almost the same choice like whether to include "run as admin" manifest or leave it to user. from security point of view, it makes sense that running anything with admin privileges might be security issue and user should agree on that. but I vote for starting interactive service from

Re: [Openvpn-devel] git master: no more WinXP ?

2016-06-29 Thread Илья Шипицин
my colleguae suggested that 1) installer should detect "running on windows xp" 2) installer should suggest to install previous version of openvpn and provide a link to it. 3) after that installer should refuse to install looks good 2016-06-29 14:00 GMT+05:00 Gert Doering :

Re: [Openvpn-devel] git master: no more WinXP ?

2016-06-29 Thread Илья Шипицин
ok, I've figured out what fwpuclnt.dll is used for: block_dns feature. 2016-06-29 13:05 GMT+05:00 Илья Шипицин <chipits...@gmail.com>: > Hello, > > I'm trying to install openvpn git master on WinXP, no luck, it complains > on missing fwpuclnt.dll > > ther

Re: [Openvpn-devel] git master: no more WinXP ?

2016-06-29 Thread Илья Шипицин
ok, if so, we need to modify installer to detect that. 2016-06-29 13:11 GMT+05:00 Gert Doering : > Hi, > > On Wed, Jun 29, 2016 at 01:05:17PM +0500, ?? wrote: > > I'm trying to install openvpn git master on WinXP, no luck, it complains > on > > missing

[Openvpn-devel] git master: no more WinXP ?

2016-06-29 Thread Илья Шипицин
Hello, I'm trying to install openvpn git master on WinXP, no luck, it complains on missing fwpuclnt.dll there's no such dll in WinXP (and it is not possible to supply dll within installer) https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/Makefile.am#L130 however, I do not see,

Re: [Openvpn-devel] openvpn/openvpn-build

2016-06-28 Thread Илья Шипицин
issues are still closed 2016-06-20 16:01 GMT+05:00 Samuli Seppänen : > Hi, > > Hello, >> >> I see issues are closed at https://github.com/openvpn/openvpn-build >> what is preffered way of reporting bugs ? >> > > I'm open to opening the issues again. If nobody objects, that's

Re: [Openvpn-devel] windows installer: choosing x86/x64 and NDIS5/NDIS6

2016-06-27 Thread Илья Шипицин
we have just packed our own installer using ... !include WinVer.nsh ... !define TAP_WINDOWS_INSTALLER_5 "C:\tap\tap-windows-9.9.2_3.exe" !define TAP_WINDOWS_INSTALLER_6 "C:\tap\tap-windows-9.21.2.exe" ... ${If} ${AtLeastWin7} File /oname=tap-windows.exe "${TAP_WINDOWS_INSTALLER_6}" ${Else}

Re: [Openvpn-devel] brainstorming: t_client system test equivalent for windows?

2016-06-24 Thread Илья Шипицин
I would suggest powershell instead of perl. I can write powershell stuff 24 июня 2016 г. 19:07 пользователь "Gert Doering" написал: > Hi, > > a new patch set from Heiko is coming up, which is going to change the > "IFCONFIG_BEFORE_TUN_OPEN" to "what everyone else does"

Re: [Openvpn-devel] what is the best way of skipping tests when openvpn configured --disable-crypto ?

2016-06-23 Thread Илья Шипицин
I'm afraid people do not pay attention to output. if build doesn't fail, why should they ? I can add that message, even make it any colour. 2016-06-23 16:32 GMT+05:00 Gert Doering : > Hi, > > On Wed, Jun 22, 2016 at 10:41:48PM +0200, Steffan Karger wrote: > > >

[Openvpn-devel] windows installer: choosing x86/x64 and NDIS5/NDIS6

2016-06-23 Thread Илья Шипицин
Hello, we used to enroll our own installer, and we bundled both x86 and x64 into single installer it was easy, several blocks ${If} ${RunningX64} ${Else} ... ${EndIf} we are going to pack NDIS5/NDIS6 the same way. in order to choose proper installer automatically, not to put that

Re: [Openvpn-devel] [PATCH 3/3] Clarify which Windows versions require which TUN/TAP driver

2016-06-23 Thread Илья Шипицин
800 users and does not work for 3 of them), but it is definetly a sign to start upgrading. 2016-06-23 13:23 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 22/06/16 19:19, Илья Шипицин wrote: > > we use ndis5 on windows 10. > > If the rumours I've

Re: [Openvpn-devel] what is the best way of skipping tests when openvpn configured --disable-crypto ?

2016-06-23 Thread Илья Шипицин
I did tests. It does not run in case of --disable-crypto 23 июня 2016 г. 1:42 пользователь "Steffan Karger" <stef...@karger.me> написал: > On Wed, Jun 22, 2016 at 9:23 PM, Илья Шипицин <chipits...@gmail.com> > wrote: > > like that ? > > > > diff

Re: [Openvpn-devel] [PATCH 3/3] Clarify which Windows versions require which TUN/TAP driver

2016-06-22 Thread Илья Шипицин
we use ndis5 on windows 10. 2016-06-22 22:14 GMT+05:00 Samuli Seppänen : > I have not actually tested tap-windows (NDIS 5) on Windows 10, but I > believe NDIS 5 support was removed from Windows 10 a while back. If NDIS 5 > drivers still work for Windows 10 then I can

Re: [Openvpn-devel] [PATCH 3/3] Clarify which Windows versions require which TUN/TAP driver

2016-06-22 Thread Илья Шипицин
why "must" for windows 10 ? 2016-06-22 22:06 GMT+05:00 : > From: Samuli Seppänen > > Signed-off-by: Samuli Seppänen > --- > INSTALL | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/INSTALL b/INSTALL >

[Openvpn-devel] what is https://github.com/OpenVPN/openvpn-build/blob/master/generic/mingw64/build ?

2016-06-20 Thread Илья Шипицин
Hello, there is separate build in mingw64 folder. what is it for ? Cheers, Ilya Shipitsin

[Openvpn-devel] openvpn/openvpn-build

2016-06-20 Thread Илья Шипицин
Hello, I see issues are closed at https://github.com/openvpn/openvpn-build what is preffered way of reporting bugs ? somehow, I managed to run it on cygwin without wget installed (I installed curl), so I see 'curl' branch is broken, curl does not follow redirects do we really need both wget and

[Openvpn-devel] what is the best way of skipping tests when openvpn configured --disable-crypto ?

2016-06-19 Thread Илья Шипицин
Hello, when playing with travis-ci, I encountered that t_lpback.sh and t_cltsrv.sh fails on "make check" if openvpn is configured with --disable-crypto (because --genkey is not available) what would be the best ? 1) run 'openvpn --help' and grep for --genkey ? 2) check exit code of 'openvpn

Re: [Openvpn-devel] how snapshot installers are built ?

2016-06-09 Thread Илья Шипицин
2016-06-09 11:16 GMT+05:00 Samuli Seppänen : > Hi, > > Hi, >> >> >> I see daily builds like >> >> >> >> http://build.openvpn.net/downloads/snapshots/openvpn-install-master-20160607214911-63b3e000c9-x86_64.exe >> >> >> I used to think they are built with

[Openvpn-devel] how snapshot installers are built ?

2016-06-08 Thread Илья Шипицин
Hello, I see daily builds like http://build.openvpn.net/downloads/snapshots/openvpn-install-master-20160607214911-63b3e000c9-x86_64.exe I used to think they are built with "build-snapshot": https://github.com/OpenVPN/openvpn-build/blob/master/windows-nsis/build-snapshot however, when I run

Re: [Openvpn-devel] potential segfault on strlen(NULL)

2016-06-07 Thread Илья Шипицин
2016-06-07 19:11 GMT+05:00 Gert Doering : > Hi, > > On Tue, Jun 07, 2016 at 06:04:54PM +0500, ?? wrote: > > as I see, there's call to format_hex_ex with separator=NULL here: > > Interesting find. > > This code is funny - format_hex_ex() is called from

Re: [Openvpn-devel] Valgring findings

2016-06-07 Thread Илья Шипицин
I thought to run valgrind separately, but it might be interesting to run it under "make check" as well 2016-06-07 19:33 GMT+05:00 Samuli Seppänen : > > Hello, >> >> I played with valgrind a bit >> >> https://travis-ci.org/chipitsine/openvpn/jobs/135869065 >> >> Looks like

[Openvpn-devel] Valgring findings

2016-06-07 Thread Илья Шипицин
Hello, I played with valgrind a bit https://travis-ci.org/chipitsine/openvpn/jobs/135869065 Looks like there are leaks in openssl code, should we suppress it? Cheers, Ilya Shipitsin

[Openvpn-devel] potential segfault on strlen(NULL)

2016-06-07 Thread Илья Шипицин
Hello, I'm investigating some cppcheck findings, for example: [src/openvpn/buffer.c:442] -> [src/openvpn/buffer.c:447]: (warning) Either the condition 'if(separator&&&!(i%(space_break_flags&255)))' is redundant or there is possible null pointer dereference: separator. [src/openvpn/buffer.c:443]

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
oops, I was wrong. 2016-06-07 13:28 GMT+05:00 Arne Schwabe <a...@rfc2549.org>: > Am 07.06.16 um 10:23 schrieb Илья Шипицин: > > mingw is an official way of building windows packages. I guess something > > like that appliable for ARM as well (I haven't heard about compilers

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
as for Travis-CI builds, there's such possibility already 1) register at github.com 2) add your own repo to travis-ci.org 3) voila, you can attack Pentagon from travis-ci cloud the way of "add some attacking code to openvpn codebase" seems to be much more complicated 2016-06-07 13:20 GMT+05:00

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
mingw is an official way of building windows packages. I guess something like that appliable for ARM as well (I haven't heard about compilers running on those machines) so, if we can catch an issue during such compile, it is good. 2016-06-07 12:58 GMT+05:00 Samuli Seppänen :

Re: [Openvpn-devel] [PATCH] Another fix related to unit test framework

2016-06-07 Thread Илья Шипицин
it is not true that Travis-CI is limited to Linux/Ubuntu, at least there's Mac OS X. and we can set up (later) cross builds for MIPS/ARM/Windows/whatever (not sure about "make check") cross build would be good starting point, if there was such thing already, we could notice that mingw build got

Re: [Openvpn-devel] travis-ci (smoke testing)

2016-06-05 Thread Илья Шипицин
воскресенье, 5 июня 2016 г. пользователь Steffan Karger написал: > Hi, > > On Sun, Jun 5, 2016 at 12:21 AM, Илья Шипицин <chipits...@gmail.com > <javascript:;>> wrote: > > I was impressed by unit testing efforts, so I suggest to implement > something > >

Re: [Openvpn-devel] travis-ci (smoke testing)

2016-06-05 Thread Илья Шипицин
it is because of SNI 2016-06-05 12:25 GMT+05:00 Steffan Karger : > On Sun, Jun 5, 2016 at 2:16 AM, Jens Neuhalfen > wrote: > >> (unfortunately, ssl cert at mbed tls website was expired and Xcode7.3 > does > >> not compile openvpn with openssl) >

[Openvpn-devel] clang static analysis

2016-06-05 Thread Илья Шипицин
Hello, I performed the following steps 1) cloned master branch of https://github.com/openvpn/openvpn 2) autoreconf -iv 3) ./configure 4) scan-build make (scan-build is clang tool for static analysis) report is here: http://chipitsine.github.io/openvpn-clang-scan/ I think we should take care

Re: [Openvpn-devel] travis-ci (smoke testing)

2016-06-05 Thread Илья Шипицин
I marked xcode6.4 as failures for a while (I've no idea what's wrong there, time is correct, certificate is correct, I'll dive into that later) as for Mac OS X, we can choose build matrix as wide as we want to, I do not insist on using xcode6.4 image, it is just as example. we can pick any

[Openvpn-devel] travis-ci (smoke testing)

2016-06-04 Thread Илья Шипицин
Hello, I was impressed by unit testing efforts, so I suggest to implement something like that https://travis-ci.org/chipitsine/openvpn/builds/135318558 ( https://github.com/OpenVPN/openvpn/pull/52 ) we can use Linux, Mac OSX, gcc, clang, various configure options. (unfortunately, ssl cert at

Re: [Openvpn-devel] [PATCH 1/2] Refactor t_client.sh

2016-05-24 Thread Илья Шипицин
Travis CI supports Linux and MacOS X, no *BSD, no Windows, ... 2016-05-24 12:31 GMT+05:00 Steffan Karger : > Hi, > > On Mon, May 23, 2016 at 10:44 AM, Samuli Seppänen > wrote: > > Yes. I think a separate testing branch with more liberal commit rights > >

Re: [Openvpn-devel] Need help for adding feature: Selecting remote servers by best latency

2016-05-11 Thread Илья Шипицин
how are you going to resolve a) host.example.com resolves in multiple "A" records b) host.example.com resolves in both "" and "A" records ? 2016-05-11 20:41 GMT+05:00 Paul Garnier : > Hello, > > > I’m actually trying to add an option in openvpn which will allow the

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
the point is "if there were PR ... and some friendly developers behaviour", so that issue wouldn't get lost "in mailing list archives" currently, it was definitely lost. nobody knows where it is 2016-05-02 16:17 GMT+05:00 Gert Doering : > Hi, > > On Mon, May 02, 2016 at

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
ok, we are running 1000+ users installation, just couple of them experienced that behaviour. and, after I investigated it in details, I came to uninitilized variable (which by chance was "almost always" initialized with NULL) from that point of view, 2 out of 1000 is almost nothing and I could

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
ok, I sent to list bug report, it was somewhere on windows 8.1 beta. somehow, uninitialized variables were initialized with garbage (it was fixed to NULL in windows 8.1 release) bug is there https://github.com/OpenVPN/openvpn/blob/master/src/openvpn/error.c#L458 if std_redir is defined, so

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
well, I'm not prepared to pass commit procedures, I'm awaiting for Samuli response whether or not he can handle those if I will send patches directly to him 2016-05-02 15:56 GMT+05:00 Gert Doering : > Hi, > > On Mon, May 02, 2016 at 03:54:46PM +0500, ??

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
there's nothing to be afraid of. http://doc.gitlab.com/ee/workflow/importing/import_projects_from_github.html we can export all issues, pr, whatever from github to gitlab if github will decide to follow code.google.com 2016-05-02 15:09 GMT+05:00 Gert Doering : > Hi, > > On

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
if we would have been using PR, anyone would be able to have a look at single place and find opened PRs. can you find unmerged patches ? 2016-05-02 15:46 GMT+05:00 Gert Doering : > Hi > > On Mon, May 02, 2016 at 03:19:54PM +0500, ?? wrote: > > when

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
when using mailing list there's no way to clearly determine what was done and needs to pay attention to. and people get disappointed "I sent a patch and nothing happened" how that is supposed to work in mailing list paradigma? 2016-05-02 15:09 GMT+05:00 Gert Doering : >

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
sf.net mailing list can go away as well. I do not see why relying on sf.net is any better than relying on github.com 2016-05-02 14:47 GMT+05:00 Gert Doering : > Hi, > > On Mon, May 02, 2016 at 12:02:37PM +0300, Samuli Seppänen wrote: > > At minimum we should clearly state

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
it is already running at "coverity_scan" branch: https://travis-ci.org/OpenVPN/openvpn/builds/120718429 so, it definitely good however, I would add (to make build running on ubuntu trusty) sudo: required dist: trusty 2016-05-02 13:59 GMT+05:00 Samuli Seppänen : > > On Mon,

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
It seems, patches are often lost "somewhere in mailing list archives" I still have no idea why this way of distributing patches is prefferable over native github PRs 2 мая 2016 г. 12:55 пользователь "Steffan Karger" написал: On Mon, May 2, 2016 at 9:44 AM, Samuli Seppänen

Re: [Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
I can prepare .travis.yml for openvpn, however, I'm not prepared for "pack your commit so and so... We are short on time to merge it" Is it ok if I send .travis.yml to you? Can you proceed with commit/review procedure? 2 мая 2016 г. 12:44 пользователь "Samuli Seppänen"

[Openvpn-devel] CI for openvpn

2016-05-02 Thread Илья Шипицин
Hello, I just run cppcheck and ... [src/openvpnserv/interactive.c:601]: (error) Memory pointed to by 'addr_row' is freed twice. [src/openvpnserv/interactive.c:700]: (error) Memory pointed to by 'fwd_row' is freed twice. [src/openvpnserv/interactive.c:1329]: (error) Common realloc mistake:

[Openvpn-devel] automatically close PR

2016-05-02 Thread Илья Шипицин
Hello, it is not very ethical to allow people to open PR in order to say later "hey, you know, we do not accept PR" I suggest to enable https://nopullrequests.appspot.com/ on https://github.com/openvpn/openvpn repo, it looks like a polite way of saying things. ideas? Ilya Shipitsin

[Openvpn-devel] compiling openvpn-gui artifacts on PR

2016-05-02 Thread Илья Шипицин
Hello, what do you think if we involve circle ci for compiling PR ? it is know to keep artifacts https://circleci.com/gh/chipitsine/openvpn-gui-circleci/12#artifacts https://circleci.com/gh/chipitsine/openvpn-gui-circleci/10#artifacts I haven't figured out how to report automatically to github

Re: [Openvpn-devel] Unit testing in openvpn?

2016-04-21 Thread Илья Шипицин
the most comfortable for github is travis-ci (it runs tests even for pull requests). we already use it for openvpn-gui and openvpn-build projects (just build, those projects do not have any tests yet): https://travis-ci.org/OpenVPN/openvpn-gui https://travis-ci.org/OpenVPN/openvpn-build as for

Re: [Openvpn-devel] Micro-sha-ft

2016-02-15 Thread Илья Шипицин
we sign our software here. actually it works like SHA-2 sign + SHA-1 timestamp. we use "signtool" for that. I'll have a look how to do that with openvpn release system 2016-02-15 14:05 GMT+05:00 Samuli Seppänen : > > > > > I presume you are aware but just in case > >

Re: [Openvpn-devel] GUI repo

2016-02-08 Thread Илья Шипицин
I saw few cases when openvpn.exe remains running even after openvpn-gui told it to stop (and it was awful). is iservice magic of start/stop openvpn.exe the same as for openvpn-gui ? if yes, I would say that it is ok to switch to iservice by default. 2016-02-08 12:42 GMT+05:00 Gert Doering

Re: [Openvpn-devel] GUI repo

2016-02-08 Thread Илья Шипицин
I saw that PR. I have one question regarding that. when we deployed openvpn, we used to supply our users a config file without "nobind" keyword. it worked for most of our users, however, those who needed 2 or more vpn connections complained that "port already bind". so, we added "nobind" to

Re: [Openvpn-devel] GUI repo

2016-02-08 Thread Илья Шипицин
2016-02-08 2:55 GMT+05:00 Gert Doering : > Hi, > > On Mon, Feb 08, 2016 at 01:12:37AM +0500, ?? wrote: > > there's still "Start OpenVPN directly" > > > > https://github.com/OpenVPN/openvpn-gui/blob/master/openvpn.c#L724 > > > > in such case admin rights

Re: [Openvpn-devel] GUI repo

2016-02-07 Thread Илья Шипицин
as far as I understand it is up to user whether to install openvpn as a service or not. if openvpn is not installed as a service, highest priv is required, right? 2016-02-08 1:29 GMT+05:00 Selva Nair <selva.n...@gmail.com>: > Hi, > > On Sun, Feb 7, 2016 at 3:12 PM, Илья Ш

Re: [Openvpn-devel] GUI repo

2016-02-07 Thread Илья Шипицин
there's still "Start OpenVPN directly" https://github.com/OpenVPN/openvpn-gui/blob/master/openvpn.c#L724 in such case admin rights are still required for routes manipulation. maybe we should release two installers (or make a checkbox in installer?) 1) regular mode (with highest priv manifest)

Re: [Openvpn-devel] GUI repo

2016-02-07 Thread Илья Шипицин
if you mean interactive service, keep in mind that people sometimes start openvpn as a child of openvpn-gui, not as a service воскресенье, 7 февраля 2016 г. пользователь Selva Nair написал: > Hi, > > We can now remove the HighestAvailable privilege request in GUI, but have > to keep it in the

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-25 Thread Илья Шипицин
t; > Samuli, any news from you ? >> >> 2016-01-23 1:22 GMT+05:00 Илья Шипицин <chipits...@gmail.com >> <mailto:chipits...@gmail.com>>: >> >> any progress here ? >> >> 2016-01-22 14:05 GMT+05:00 Steffan Karger <stef...@karger.me >&

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-25 Thread Илья Шипицин
Samuli, any news from you ? 2016-01-23 1:22 GMT+05:00 Илья Шипицин <chipits...@gmail.com>: > any progress here ? > > 2016-01-22 14:05 GMT+05:00 Steffan Karger <stef...@karger.me>: > >> On Fri, Jan 22, 2016 at 9:40 AM, Илья Шипицин <chipits...@gmail.com> &g

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-22 Thread Илья Шипицин
any progress here ? 2016-01-22 14:05 GMT+05:00 Steffan Karger <stef...@karger.me>: > On Fri, Jan 22, 2016 at 9:40 AM, Илья Шипицин <chipits...@gmail.com> > wrote: > > who can add it to https://travis-ci.org/openvpn/ ? > > Samuli can do this - I do not have sufficie

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-22 Thread Илья Шипицин
Hello, who can add it to https://travis-ci.org/openvpn/ ? 2016-01-18 17:36 GMT+05:00 Samuli Seppänen : > Hi, > > Hello, >> >> https://github.com/OpenVPN/openvpn-gui/pull/12 >> > > I merged this one, it looked good afaict. > > should we add build configuration under

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-18 Thread Илья Шипицин
and, I'm going to add coverity to openvpn-gui later. 2016-01-18 11:44 GMT+05:00 Jacky Alcine <jackyalc...@gmail.com>: > This would be great. Helps with visibility of tests for the public. > > > On Mon, 2016-01-18 at 11:39 +0500, Илья Шипицин wrote: > > Hello, > &

Re: [Openvpn-devel] travis-ci for openvpn-gui

2016-01-18 Thread Илья Шипицин
for now, there are no tests. it will be visible whether project builds or not (for pull requests as well). 2016-01-18 11:44 GMT+05:00 Jacky Alcine <jackyalc...@gmail.com>: > This would be great. Helps with visibility of tests for the public. > > > On Mon, 2016-01-18 at 11:39 +

[Openvpn-devel] travis-ci for openvpn-gui

2016-01-18 Thread Илья Шипицин
Hello, https://github.com/OpenVPN/openvpn-gui/pull/12 should we add build configuration under https://travis-ci.org/openvpn/ ?

[Openvpn-devel] unused functions (as a result of cppcheck testing)

2016-01-11 Thread Илья Шипицин
Hello, cppcheck found several unused functions: [src/openvpn/misc.c:842]: (style) The function 'setenv_int_i' is never used. [src/openvpn/misc.c:669]: (style) The function 'env_set_add_to_environment' is never used. [src/openvpn/misc.c:627]: (style) The function 'env_set_print' is never used.

Re: [Openvpn-devel] link to openvpn.se ?

2016-01-10 Thread Илья Шипицин
Hello, any progress here ? 2015-12-31 14:48 GMT+05:00 Samuli Seppänen : > > > Hello, > >> >> I mentioned that you want to shut down openvpn.se , >> because of beeing too old. >> however, there're links to it, for instance, >>

[Openvpn-devel] some cleanup on openvpn-build

2016-01-10 Thread Илья Шипицин
Hello, please someone have a look at https://github.com/OpenVPN/openvpn-build/pull/16 it seems there few more files with --enable-password-save or --disable-snappy Cheers, Ilya Shipitsin

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
as for my observation, people share password with coworkers, they will share cert in the same way :) well, password-only is legitimate setup, so I would add test case for it. maybe bit later. where can I have a look at existing test cases you are talking about? суббота, 2 января 2016 г.

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
also, does it make sence to perform unit testing on build like setup server with user/password auth on localhost, connect to is using client, see whether it is ok ? 2015-12-26 12:40 GMT+03:00 Steffan Karger : > On 26-12-15 10:19, Gert Doering wrote: > > On Wed, Dec 23,

Re: [Openvpn-devel] [PATCH] Warn user if their certificate has expired

2016-01-02 Thread Илья Шипицин
I'm getting "segmentation fault" after that commit. well, I suspect you beleive that user _always_ has client cert, which is not true. obviously, for preshared keys there''s no user cert, and for user/password auth there's also no user cert (which is our case) is Valgrind I see the following:

[Openvpn-devel] link to openvpn.se ?

2015-12-30 Thread Илья Шипицин
Hello, I mentioned that you want to shut down openvpn.se, because of beeing too old. however, there're links to it, for instance, https://github.com/OpenVPN/openvpn-gui/blob/master/README more links, higher google page rank, so people will see it in search results. should we remove that link ?

[Openvpn-devel] windows team ?

2015-12-28 Thread Илья Шипицин
Hello, I've heard about "things need some loving" and "let us create windows team". can you please pay some attention to pull requests https://github.com/OpenVPN/openvpn-gui/pulls ? it is no good when PR stay without any attention. looks like there's no loving for windows things. Cheers, Ilya

Re: [Openvpn-devel] Packet loss due to radius issues

2015-08-05 Thread Илья Шипицин
I can maitain such a repo. also, did you consider to employ students from GSoC ? for example, ToX (which I like very much) employed 9 students. it might give some drive into development. 2015-08-02 16:36 GMT+05:00 Samuli Seppänen : > > Hi, >> >> On Fri, Jul 31, 2015 at

Re: [Openvpn-devel] Packet loss due to radius issues

2015-08-01 Thread Илья Шипицин
I do not mind about "the official repo". can you provide more details on that? 2015-08-01 18:07 GMT+05:00 Gert Doering : > Hi, > > On Fri, Jul 31, 2015 at 11:57:26AM +0200, Samuel Thibault wrote: >> But without a central repository where people would get to know about >> your

Re: [Openvpn-devel] Packet loss due to radius issues

2015-07-31 Thread Илья Шипицин
just 'user' it is too early to talk about central repository, currently I'm the only user of that plugin 2015-07-31 14:12 GMT+05:00 Samuel Thibault <samuel.thiba...@ens-lyon.org>: > Илья Шипицин, le Fri 31 Jul 2015 14:09:51 +0500, a écrit : >> I've rewritten radius thing with .net, m

Re: [Openvpn-devel] Packet loss due to radius issues

2015-07-31 Thread Илья Шипицин
Hello, I've rewritten radius thing with .net, my plugin performs queries to multiple radius servers in parallel, I'm using it with Mono in production for few months: https://github.com/skbkontur/openvpn-auth-radius I can help with that plugin if you are interested 2015-07-31 4:37 GMT+05:00

Re: [Openvpn-devel] Windows TAP driver profiling

2015-01-17 Thread Илья Шипицин
have a look at wire speed of tap adapter, https://yadi.sk/i/zz4WbnOHe3hJf I see 10mb 2015-01-17 0:02 GMT+05:00 Dan Moulding : > Hello all, > > I have been extensively testing OpenVPN recently, for potential deployment > with some other systems I have been

Re: [Openvpn-devel] New OpenVPN Windows installers (I004 and I604) released

2014-10-21 Thread Илья Шипицин
this is because Heiko rejected merge request: http://sourceforge.net/p/openvpn-gui/code/merge-requests/1/ it is easily fixed by openvpn-gui manifest I keep hearing from Heiko about some magic openvpn service for years. it is just couple of minutes to merge that request though... 2014-10-21

Re: [Openvpn-devel] Ongoing Windoes 8 issues

2014-08-20 Thread Илья Шипицин
when "some hacks work, some not" , it looks like assumtion that variables should be initialized with zero. have a look around, maybe youl'll find another uninitialized variable :-) 2014-08-20 13:32 GMT+06:00 Richard Weinberger : > Hi! > > This bug exists for almost

Re: [Openvpn-devel] Ongoing Windoes 8 issues

2014-08-20 Thread Илья Шипицин
we have a lot of users on Windows 8, no issue at all. well, I recall some issue (it was different than https://community.openvpn.net/openvpn/ticket/316) couple of early adopters installed Windows 8 preview, openvpn doesn't work on that windows edition (due to improper variable initialization

Re: [Openvpn-devel] Heartbleed

2014-04-09 Thread Илья Шипицин
ability, but not any attacker. 2014-04-09 14:30 GMT+06:00 Arne Schwabe <a...@rfc2549.org>: > Am 09.04.14 10:25, schrieb Илья Шипицин: >> am I right that "nobind" option gives some protection to windows >> openvpn client ? >> > No. Nobind gives no protection. > > Arne

Re: [Openvpn-devel] Heartbleed

2014-04-09 Thread Илья Шипицин
am I right that "nobind" option gives some protection to windows openvpn client ? 2014-04-08 23:02 GMT+06:00 Samuli Seppänen : > Hi, Am 08.04.2014 15:42, schrieb Steffan Karger: >> Perhaps a dumb question, but if the server instance is linked >> against

Re: [Openvpn-devel] uninitialized handle fix (serious bug on Win 8.1), another attempt

2013-12-08 Thread Илья Шипицин
ok, you suggest to initialize orig_stderr. initialize with what ? what value of orig_stderr should mean a) "no stderr redirection requested, return GetStdHandle (STD_ERROR_HANDLE)" b) "stderr redirection was requested, return orig_stderr" as Matthias Andree said, neither NULL, nor

Re: [Openvpn-devel] uninitialized handle fix (serious bug on Win 8.1), another attempt

2013-12-08 Thread Илья Шипицин
Ok, your suggestion? воскресенье, 8 декабря 2013 г. пользователь Gert Doering писал: > Hi, > > On Sat, Dec 07, 2013 at 09:01:35PM +0600, ??? wrote: > > if handle is not initialized, orig_stderr variable could take random > > value, which we observe on Windows 8.1 (bug reported here as

[Openvpn-devel] Fwd: uninitialized handle fix (serious issue on Win 8.1)

2013-12-05 Thread Илья Шипицин
guys, please pay attention to this message. it really resolves issue with openvpn on windows 8.1 -- Forwarded message -- From: Илья Шипицин <chipits...@gmail.com> List-Post: openvpn-devel@lists.sourceforge.net Date: 2013/12/4 Subject: uninitialized handle fix (serious issue

[Openvpn-devel] uninitialized handle fix (serious issue on Win 8.1)

2013-12-04 Thread Илья Шипицин
Hello! I confirm issue described here: https://forums.openvpn.net/topic13246.html also, I confirm that it is due to random handle value (which somehow was null before Win 8.1 was released) also, I do not understand why we should check "err" handle on INVALID_HANDLE_VALUE, it will fail anyway on

<    1   2   3   4   5   >