Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-10 Thread Gert Doering
Hi, On Fri, Jul 10, 2020 at 06:48:26PM +0200, Jan Just Keijser wrote: > > It's just a comment, but if that is wrong, it's not helpful in trying to > > understand the code. > > > just submitted patch v4 but forgot to fix that:   richard is right 29 > decimal is  0x1D -  or just 29, I guess  - not

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-10 Thread Jan Just Keijser
Hi all, On 08-Jul-20 10:24, Gert Doering wrote: On Tue, Jul 07, 2020 at 06:14:25PM +0200, Jan Just Keijser wrote: This one works(!), so generally, Win10 accepts this DHCP option - but it seems to want "all domains in one". Can you send a v3? not sure if all went well , but here's V3.

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-08 Thread Gert Doering
Hi, On Tue, Jul 07, 2020 at 06:14:25PM +0200, Jan Just Keijser wrote: > > This one works(!), so generally, Win10 accepts this DHCP option - but > > it seems to want "all domains in one". > > > > Can you send a v3? > > > not sure if all went well , but here's V3. Unfortunately not, that one seems

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-07 Thread Jan Just Keijser
Hi, On 06/07/20 18:15, Gert Doering wrote: Hi, On Tue, Jun 30, 2020 at 04:15:58PM +0200, Jan Just Keijser wrote: On 30/06/20 16:11, Gert Doering wrote: On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf,

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-06 Thread Gert Doering
Hi, On Thu, Jul 02, 2020 at 11:04:41PM +0200, David Sommerseth wrote: > Can we please see this discussion also in context of this mail thread, which > tries to look a broader at this challenge? There's two things here - a small and useful featurette which can go into 2.5, and the broader

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-06 Thread Gert Doering
Hi, On Tue, Jun 30, 2020 at 04:15:58PM +0200, Jan Just Keijser wrote: > On 30/06/20 16:11, Gert Doering wrote: > > On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: > >> @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const > >> struct tuntap_options *o) > >>

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Jan Just Keijser
Hi, On 03/07/20 11:18, Arne Schwabe wrote: The main purpose of that RFC is to ensure we handle DNS and --dhcp-options consistently across all OpenVPN implementations we care about, and that we document this properly. I see one as an implementation issue (can we specify a particular DHCP

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Jonathan K. Bullard
Hi, On Fri, Jul 3, 2020 at 3:39 AM Jan Just Keijser wrote: > > Hi, > > On 02/07/20 23:04, David Sommerseth wrote: > > On 30/06/2020 16:15, Jan Just Keijser wrote: > >> hi, > >> > >> On 30/06/20 16:11, Gert Doering wrote: > >>> Hi, > >>> > >>> On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Arne Schwabe
>> The main purpose of that RFC is to ensure we handle DNS and >> --dhcp-options >> consistently across all OpenVPN implementations we care about, and >> that we >> document this properly. >> > > I see one as an implementation issue (can we specify a particular DHCP > option more than once) and

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-03 Thread Jan Just Keijser
Hi, On 02/07/20 23:04, David Sommerseth wrote: On 30/06/2020 16:15, Jan Just Keijser wrote: hi, On 30/06/20 16:11, Gert Doering wrote: Hi, On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const struct

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-02 Thread David Sommerseth
On 30/06/2020 16:15, Jan Just Keijser wrote: > hi, > > On 30/06/20 16:11, Gert Doering wrote: >> Hi, >> >> On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: >>> @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const >>> struct tuntap_options *o) >>>

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-30 Thread Jan Just Keijser
hi, On 30/06/20 16:11, Gert Doering wrote: Hi, On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const struct tuntap_options *o) write_dhcp_u32_array(buf, 42, (uint32_t *)o->ntp, o->ntp_len, );

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-30 Thread Gert Doering
Hi, On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: > @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const > struct tuntap_options *o) > write_dhcp_u32_array(buf, 42, (uint32_t *)o->ntp, o->ntp_len, ); > write_dhcp_u32_array(buf, 45, (uint32_t

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-30 Thread Jan Just Keijser
Hi, On 24/06/20 12:28, Gert Doering wrote: Hi, On Tue, Jun 23, 2020 at 03:53:52PM -0400, Selva Nair wrote: So what option do we want? --dhcp-option SEARCH --dhcp-option DOMAIN-SEARCH --dhcp-option SEARCH-DOMAIN RFC 3397 calls it "Domain Search" so it has to be DOMAIN-SEARCH, in my view.

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-24 Thread Gert Doering
Hi, On Tue, Jun 23, 2020 at 03:53:52PM -0400, Selva Nair wrote: > > So what option do we want? > > > > --dhcp-option SEARCH > > --dhcp-option DOMAIN-SEARCH > > --dhcp-option SEARCH-DOMAIN > > RFC 3397 calls it "Domain Search" so it has to be DOMAIN-SEARCH, in my > view. Platform scripts

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-23 Thread Selva Nair
Hi, On Tue, Jun 23, 2020 at 3:22 AM Jan Just Keijser wrote: > > Hi, > > On 21/06/20 17:14, Selva Nair wrote: > > On Sun, Jun 21, 2020 at 7:14 AM Gert Doering wrote: > >> > >> going through OpenVPN threads that went stale - I think this is > >> actually a nice addition (read: other people have

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-23 Thread Jan Just Keijser
Hi, On 21/06/20 17:14, Selva Nair wrote: On Sun, Jun 21, 2020 at 7:14 AM Gert Doering wrote: going through OpenVPN threads that went stale - I think this is actually a nice addition (read: other people have already asked me if this can be done). On Thu, Mar 05, 2020 at 01:53:12PM +0100, Jan

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-21 Thread David Sommerseth
On 21/06/2020 13:14, Gert Doering wrote: > Hi, > > going through OpenVPN threads that went stale - I think this is > actually a nice addition (read: other people have already asked > me if this can be done). > > On Thu, Mar 05, 2020 at 01:53:12PM +0100, Jan Just Keijser wrote: >> So, for what

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-21 Thread Jonathan K. Bullard
Hi, On Sun, Jun 21, 2020 at 11:15 AM Selva Nair wrote: > > Hi, > > On Sun, Jun 21, 2020 at 7:14 AM Gert Doering wrote: > > > > Hi, > > > > going through OpenVPN threads that went stale - I think this is > > actually a nice addition (read: other people have already asked > > me if this can be

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-21 Thread Selva Nair
Hi, On Sun, Jun 21, 2020 at 7:14 AM Gert Doering wrote: > > Hi, > > going through OpenVPN threads that went stale - I think this is > actually a nice addition (read: other people have already asked > me if this can be done). > > On Thu, Mar 05, 2020 at 01:53:12PM +0100, Jan Just Keijser wrote: >

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-21 Thread Jonathan K. Bullard
Hi! On Sun, Jun 21, 2020 at 7:15 AM Gert Doering wrote: > > Hi, > > going through OpenVPN threads that went stale - I think this is > actually a nice addition (read: other people have already asked > me if this can be done). > > On Thu, Mar 05, 2020 at 01:53:12PM +0100, Jan Just Keijser wrote: >

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-21 Thread Gert Doering
Hi, going through OpenVPN threads that went stale - I think this is actually a nice addition (read: other people have already asked me if this can be done). On Thu, Mar 05, 2020 at 01:53:12PM +0100, Jan Just Keijser wrote: > So, for what it's worth, I've dusted off the patch again and rebased

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-03-05 Thread Jan Just Keijser
Hi all, On 05/03/20 13:53, Jan Just Keijser wrote: Hi, On 01/03/20 16:29, Selva Nair wrote: On Sun, Mar 1, 2020 at 2:17 AM Gert Doering wrote: On Sun, Mar 01, 2020 at 05:37:15AM +, Leroy Tennison via Openvpn-users wrote: Admittedly, and older server version (2.3) but is there a way to

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-03-05 Thread Jan Just Keijser
Hi, On 01/03/20 16:29, Selva Nair wrote: On Sun, Mar 1, 2020 at 2:17 AM Gert Doering wrote: On Sun, Mar 01, 2020 at 05:37:15AM +, Leroy Tennison via Openvpn-users wrote: Admittedly, and older server version (2.3) but is there a way to specify multiple DNS search suffixes for a Windows