Re: [PATCH] remove erjang due the following reasons: - the download url is from dropbox and is unavailable [1] - the last version of erjang implementation is dated from 2016 and it seems abandoned [2]

2018-01-21 Thread Nadav Har'El
I can't apply this patch because it uses "wget -c" from your previous patch which I did not apply yet... Can you please send a new patch that applies to master? Thanks. -- Nadav Har'El n...@scylladb.com On Sat, Jan 20, 2018 at 6:51 PM, geraldo netto <geraldone...@gmail.com> wro

Re: how to fix arithmetic on pointer to void?

2018-01-21 Thread Nadav Har'El
On Sun, Jan 21, 2018 at 8:42 PM, Geraldo Netto wrote: > Guys, > > I have run clang static analiser/cppcheck on OSv code and it came with > issues > One of them, is this arithmetic on pointer to void > You're right, the standard says you cannot do pointer arithmetic on

Re: [PATCH] Enhanced procfs to support /proc/sys/kernel/hostname

2018-01-23 Thread Nadav Har'El
Thanks. I'll commit, but I have unimportant nitpicks below; If you'll want to change anything (you don't have to), you can do it in a followup patch after this one is already comitted. -- Nadav Har'El n...@scylladb.com On Tue, Jan 23, 2018 at 2:11 PM, Waldemar Kozaczuk <jwkozac...@gmail.

Re: Page fault outside of application

2018-01-23 Thread Nadav Har'El
On Tue, Jan 23, 2018 at 12:40 PM, Rick Payne wrote: > > A few moving parts, so not sure what is causing this - but trying to start > an erlang application I'm seeing this: > I don't have any bright ideas, but just a few small comments below, hopefully (?) they will help

Re: [PATCH 01/56] apache-derby/Makefile: use wget -c

2018-01-17 Thread Nadav Har'El
"java8" feature, so applications can start specifying they need Java 8 (and Java 7 is not good enough). -- Nadav Har'El n...@scylladb.com On Tue, Jan 16, 2018 at 9:42 PM, geraldo netto <geraldone...@gmail.com> wrote: > Signed-off-by: geraldo netto <geraldone...@gmail.com> &g

Re: [PATCH] Added number of syscalls to support golang

2018-01-17 Thread Nadav Har'El
On Wed, Jan 17, 2018 at 6:59 AM, Waldek Kozaczuk wrote: > The sys_ioctl was probably added to conform with Linux implementation - > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/ > linux.git/tree/fs/ioctl.c. And ioctl function is variadic. > I still don't

Re: [PATCH 01/56] apache-derby/Makefile: use wget -c

2018-01-17 Thread Nadav Har'El
On Wed, Jan 17, 2018 at 11:17 PM, Waldek Kozaczuk <jwkozac...@gmail.com> wrote: > > On Wed, Jan 17, 2018 at 3:36 AM, Nadav Har'El <n...@scylladb.com> wrote: > > If I try >> scripts/build image=openjdk8-fedora,apache-derby >> >> I get other strang

Re: [PATCH] Added number of syscalls to support golang

2018-01-15 Thread Nadav Har'El
On Mon, Jan 15, 2018 at 11:02 AM, Nadav Har'El <n...@scylladb.com> wrote: > > > + >> +static int pselect6(int nfds, fd_set *readfds, fd_set *writefds, >> + fd_set *exceptfds, const struct timespec *timeout_ts, >> + void *

Re: golang-example fails with general protection or page fault

2018-01-15 Thread Nadav Har'El
On Mon, Jan 15, 2018 at 6:35 AM, Waldek Kozaczuk wrote: > I think I have gotten to the point where Go work reasonably well on OSv so > I will be sending the patches. Here is the order of the patches and how I > am planning to break them down: > >- Add missing SYSCALLs

Re: [PATCH] Added number of syscalls to support golang

2018-01-15 Thread Nadav Har'El
On Mon, Jan 15, 2018 at 7:55 AM, Waldemar Kozaczuk wrote: > This patch adds number of syscalls to that are needed to make Golang > apps run on OSv. > Is this based on Benoit's earlier patches or your new additions? If it's based on Benoit's patch please mention him in the

Re: [PATCH] Implemented Read-Only File System (ROFS)

2018-01-25 Thread Nadav Har'El
On Wed, Jan 24, 2018 at 4:26 PM, Waldek Kozaczuk wrote: > I guess I could add another blacklist to scripts/test.py to filter out > tests failing due to rams bugs these when running ROFS image. > > Is this reasonable? > Perhaps. I wasn't happy to see a huge patch to test.py

Re: [PATCH 1/2 v2] * avoid downloading tomcat if it already exists

2018-01-11 Thread Nadav Har'El
On Thu, Jan 11, 2018 at 11:09 PM, geraldo netto wrote: > Signed-off-by: geraldo netto > --- > tomcat/GET | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tomcat/GET b/tomcat/GET > index b96d963..07247d9 100755 >

Re: [PATCH] Fixed code style in ramfs

2018-01-31 Thread Nadav Har'El
On Wed, Jan 31, 2018 at 1:40 PM, Waldemar Kozaczuk wrote: > Fixed code style issues in ramfs source code mainly by replacing > tabs with spaces. > I'm curious why you want to change that. Aren't these files consistent in their code style, i.e. use only tabs - and not a

Re: Using stock PIE executables from standard distributions?

2018-01-28 Thread Nadav Har'El
On Mon, Jan 29, 2018 at 12:37 AM, Rick Payne <ri...@rossfell.co.uk> wrote: > > > > On 28 Jan 2018, at 22:23, Nadav Har'El <n...@scylladb.com> wrote: > > > > However, sadly, we still do have bugs with PIE support that need to be > fixed before running PIEs

Re: Page fault outside of application

2018-01-29 Thread Nadav Har'El
On Wed, Jan 24, 2018 at 11:07 AM, Rick Payne <ri...@rossfell.co.uk> wrote: > Hi, > > On 23/01/18 20:16, Nadav Har'El wrote: > >> I don't have any bright ideas, but just a few small comments below, >> hopefully (?) they will help something... >> > > Appre

Re: Page fault outside of application

2018-01-29 Thread Nadav Har'El
On Mon, Jan 29, 2018 at 11:20 AM, Rick Payne <ri...@rossfell.co.uk> wrote: > On Mon, 2018-01-29 at 10:54 +0200, Nadav Har'El wrote: > > This all seems reasonable. > Maybe we somehow got the PLT becoming read-only, so we are getting a > pagefault trying to write to it? > C

Re: Build failed in Jenkins: osv-build #1321

2018-01-28 Thread Nadav Har'El
On Sun, Jan 28, 2018 at 11:48 AM, wrote: > See display/redirect?page=changes> > > strip: build/ws/apps/openjdk8-fedora/install/usr/lib/libnspr4.so[. >

Re: Using stock PIE executables from standard distributions?

2018-01-28 Thread Nadav Har'El
On Sat, Jan 27, 2018 at 5:09 PM, Dan Kaminsky wrote: > Given that OSv implements its own ELF loader, I'm wondering how much it > could potentially take advantage of platforms' recent change to PIE > compilation. (GCC7 is PIE by default, a thing that's been some headache for >

Re: Build failed in Jenkins: osv-build #1321

2018-01-28 Thread Nadav Har'El
On Sun, Jan 28, 2018 at 12:42 PM, Nadav Har'El <n...@scylladb.com> wrote: > > On Sun, Jan 28, 2018 at 11:48 AM, <jenk...@scylladb.com> wrote: > >> See <https://jenkins.scylladb.com:8443/job/osv-build/1321/displa >> y/redirect?page=changes> >> >&g

Re: [PATCH] Fixed code style in ramfs

2018-01-31 Thread Nadav Har'El
On Wed, Jan 31, 2018 at 6:29 PM, Waldek Kozaczuk wrote: > As I was going to make number of changes to this files I wanted to make > them compatible with OSv code style. I kind of did not even think they were > copied from different source. > > Actually at least one of the

Re: Page fault outside of application

2018-01-30 Thread Nadav Har'El
On Mon, Jan 29, 2018 at 3:51 PM, Nadav Har'El <n...@scylladb.com> wrote: > > On Mon, Jan 29, 2018 at 12:16 PM, Rick Payne <ri...@rossfell.co.uk> wrote: > >> >> Maybe I'm not following. The GNU_RELO sections look the same between >> the 2 versions of erlexec.

Re: mysql: failed looking up symbol numa_all_nodes_ptr

2018-02-11 Thread Nadav Har'El
On Sat, Feb 10, 2018 at 7:31 AM, Geraldo Netto wrote: > Dear Friends, > > I was trying to upgrade mysql but in order to upgrade to version 5.6.39 > It seems mysql requires the libraries > - libnuma.so.1 > libnuma is a separate shared library, it is not part of glibc, and

Re: upgrading musl version on osv - progress/issues

2018-02-13 Thread Nadav Har'El
On Tue, Feb 13, 2018 at 9:06 PM, Geraldo Netto wrote: > Dear Friends, > > I was playing with current version of musl on osv > I have progressed in compilation, but still failing as below > > Most problems are related to locales (wide chars?), math, some stdio, etc > Do

Re: [PATCH 0/3] imgedit.py: small cleanups based on pylint

2018-02-13 Thread Nadav Har'El
On Tue, Feb 13, 2018 at 3:24 PM, geraldo netto wrote: > small cleanups based on pylint > May I ask, why are cosmetic overhauls like this a good idea, and not just churn and work for both you and the committers? > as for fsize, it was removed because it was never used

Re: [PATCH 2/3] setup.py: sort packages

2018-02-14 Thread Nadav Har'El
There is no good way for me to review this patch (to confirm you didn't forget any of the packages while sorting them)... Why is this important or even useful to have the package names sorted? -- Nadav Har'El n...@scylladb.com On Tue, Feb 13, 2018 at 7:07 PM, geraldo netto <gerald

Re: [PATCH 3/3] setup.py: reuse ubuntu class for linux mint

2018-02-14 Thread Nadav Har'El
Can you please send this patch directly, instead of adding all this code in the first patch, which you then remove it in the third patch? Thanks, Nadav. -- Nadav Har'El n...@scylladb.com On Tue, Feb 13, 2018 at 7:07 PM, geraldo netto <geraldone...@gmail.com> wrote: > Signed-off-by

Re: [PATCH v2] mkbootfs.py: reuse manifest_common - should fix #905

2018-02-15 Thread Nadav Har'El
Hi, please see comments inline below (also explains the bug which Justin found). -- Nadav Har'El n...@scylladb.com On Fri, Feb 9, 2018 at 6:56 PM, geraldo netto <geraldone...@gmail.com> wrote: > Signed-off-by: geraldo netto <geraldone...@gmail.com> > --- > scr

Re: [PATCH v2] mkbootfs.py: reuse manifest_common - should fix #905

2018-02-15 Thread Nadav Har'El
On Thu, Feb 15, 2018 at 3:09 PM, Geraldo Netto wrote: > Hello Nadav/Justin/All, > > I have made the tuning Nadav suggested at it is working like a charm for > me :) > In any case, I'll test some options/combinations > > 2 interesting things I just found: > - make is not

Re: Why only RH based distros do support ARM 64 builds? was [PATCH 2/3] setup.py: sort packages

2018-02-21 Thread Nadav Har'El
On Tue, Feb 20, 2018 at 9:12 PM, Geraldo Netto wrote: > Hello Guys, > > Let me redo the patches > I'll redo per distribution because there are some more packages to add > So, please, disregard the changes the patches about unzip/wget > > I have tested the changes on

Re: [PATCH] explicitly tell at README.md that compilation requires at least 2GB of RAM

2018-02-22 Thread Nadav Har'El
On Thu, Feb 22, 2018 at 6:02 AM, geraldo netto wrote: > this will avoid people having such situation below: > ... > CXX core/commands.cc > virtual memory exhausted: Cannot allocate memory > I'm not comfortable with saying just that "2 GB of memory is needed for the

Re: [PATCH v2 1/2] manifest_common: avoid error when splitting paths

2018-02-22 Thread Nadav Har'El
On Fri, Feb 16, 2018 at 5:19 AM, geraldo netto wrote: > Signed-off-by: geraldo netto > --- > scripts/manifest_common.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/manifest_common.py

Re: [PATCH v2 1/3] setup.py: add curl to fedora package list

2018-02-22 Thread Nadav Har'El
I'll commit this, as it can't hurt, but note that it won't help either - curl is installed by default on every Fedora installation: $ dnf groups info Core Group: Core Description: Smallest possible installation Mandatory Packages: ... curl -- Nadav Har'El n...@scylladb.com On Thu, Feb 22

Re: busybox __vprintf_chk missing (old musl)

2018-02-19 Thread Nadav Har'El
On Mon, Feb 19, 2018 at 5:08 AM, Geraldo Netto wrote: > Hello Guys, > > Just to report, it seems our current version of musl does not have some > glibc extensions > Checking their mailing lists (http://www.openwall.com/ > lists/musl/2015/06/17/1) > They have implemented

Re: [PATCH 24/56] mysql/GET: remove if (wget -c handles it)

2018-02-21 Thread Nadav Har'El
On Tue, Feb 20, 2018 at 3:51 PM, Geraldo Netto wrote: > Hello Waldek/Nadav/All, > > Totally agreed Waldek! > And maybe we could also define a policy to phase out apps that are not > maintained for a long time > eg: let's suppose we have an apps that is not updated for

Re: [PATCH 24/56] mysql/GET: remove if (wget -c handles it)

2018-02-21 Thread Nadav Har'El
On Sun, Feb 18, 2018 at 5:47 PM, Waldek Kozaczuk wrote: > If I may also add my 2 cents. I think it might be also worth to think > about priorities meaning which apps we care and which not so much. And the > make sure that at least the most important ones have fixed build

Re: [COMMIT osv-apps master] Ruby: Pass RUBYLIB environment variable

2018-02-18 Thread Nadav Har'El
On Sun, Feb 18, 2018 at 4:57 PM, Waldek Kozaczuk wrote: > > >>> api.require('ruby') >>> -default = api.run(cmdline="/ruby.so /ruby-example/hello.rb") >>> +default = api.run(cmdline="--env=RUBYLIB=/usr/share/ruby:/usr/lib64/ruby >>> /ruby.so /ruby-example/hello.rb") >>> >>

Re: Fast vdso syscall compatibility library

2018-02-18 Thread Nadav Har'El
On Thu, Feb 15, 2018 at 12:01 AM, Waldek Kozaczuk wrote: > I have bee trying to prepare new patch to add libvdso support needed by > golang based on the work of @benoit. I came across this discussion here >

Re: [COMMIT osv-apps master] Ruby: Pass RUBYLIB environment variable

2018-02-18 Thread Nadav Har'El
On Sun, Feb 18, 2018 at 4:59 AM, Commit Bot wrote: > From: Waldemar Kozaczuk > Committer: Waldemar Kozaczuk > Branch: master > > Ruby: Pass RUBYLIB environment variable > > Signed-off-by: Waldemar Kozaczuk

Re: [PATCH 2/3] setup.py: sort packages

2018-02-18 Thread Nadav Har'El
t we support > So, we could create a single list of shared dependencies and just use it > I'm not sure this is worth the trouble, but perhaps. > > > Kind Regards, > > Geraldo Netto > Sapere Aude => Non dvcor, dvco > http://exdev.sf.net/ > > On 14 February 2018 a

Re: [PATCH 24/56] mysql/GET: remove if (wget -c handles it)

2018-02-18 Thread Nadav Har'El
On Sun, Feb 18, 2018 at 5:27 AM, Geraldo Netto wrote: > Hello Waldek/All, > > Indeed, I must say, not only this, but many other apps have broken urls or > broken builds > This was the main thing that bothered me about your "change wget to wget -c" series of 50 patches -

Re: [PATCH 54/56] twemproxy/GET: use wget -c

2018-02-18 Thread Nadav Har'El
On Sat, Feb 17, 2018 at 10:38 PM, Waldek Kozaczuk wrote: > Geraldo, > > I applied your patch and built it like this: > ./scripts/build image=twemproxy > > Now when I tried to run it I got an error about empty command line. > This happens because some applications were only

Re: [COMMIT osv-apps master] mysql: fix path separator

2018-02-25 Thread Nadav Har'El
dom, 25 de fev de 2018 07:02, Commit Bot <b...@cloudius-systems.com> > escreveu: > >> From: geraldo netto <geraldone...@gmail.com> >> Committer: Nadav Har'El <n...@scylladb.com> >> Branch: master >> >> mysql: fix path separator >> >> fix path

Re: Releasing OSv

2018-02-25 Thread Nadav Har'El
On Sun, Feb 25, 2018 at 8:45 PM, Waldek Kozaczuk wrote: > I would like to publish new release of OSv. The last official one was 0.24 > and published on Oct 30, 2015 (a little over 2 years). I have never > released OSv so any input and suggestions are very welcome especially

Re: upgrading musl version on osv - progress/issues

2018-02-25 Thread Nadav Har'El
On Sun, Feb 25, 2018 at 8:11 AM, Geraldo Netto wrote: > Hello Nadav/Waldek/All, > > It turns out most math functions just need a minor tuning > I'm still facing a lot of issues with wide chars and some stdio things > But I hope to start submitting the patches to upgrade

Re: OSv IPv6

2018-08-05 Thread Nadav Har'El
On Sat, Aug 4, 2018 at 6:00 AM, Charles Myers wrote: > It took me a while to split out the patches according to your guidelines, > since they were not organized that way. > I will be submitting them probably starting tomorrow or maybe early next > week. The largest patch will be around 1 MB for

Re: [PATCH] bsd: Added mtx_trylock()

2018-08-05 Thread Nadav Har'El
On Sat, Aug 4, 2018 at 6:03 AM, Charles Myers wrote: > Used in FreeBSD IPv6 code sys/netinet6/frag6.c IP6Q_TRYLOCK(). > Thanks, I'll commit these two trivial patches as-is, but the next patches, can you please add a "Signed-off-by:" line to your patch? This is explained in the CONTRIBUTING

Re: Implementing more memory-efficient mmap() for ROFS and RAMFS

2018-08-05 Thread Nadav Har'El
On Fri, Aug 3, 2018 at 9:35 PM, Waldek Kozaczuk wrote: > There is an outstanding issue https://github.com/ > cloudius-systems/osv/issues/979 that describes how OSv creates extra > copies of file data when mmap() is called for RAMFS or ROFS node. Possible > improvement to eliminate this extra

Re: [PATCH] Added getrandom() implementation

2018-08-15 Thread Nadav Har'El
On Wed, Aug 15, 2018 at 5:49 AM, Waldemar Kozaczuk wrote: > Fixes #989 > > Signed-off-by: Waldemar Kozaczuk > --- > Makefile | 1 + > include/api/sys/random.h | 1 + > include/api/x64/bits/syscall.h | 1 + > libc/include/sys/random.h | 13 ++ >

Re: Build failed in Jenkins: osv-build #1403

2018-08-15 Thread Nadav Har'El
On Wed, Aug 15, 2018 at 3:19 PM, Nadav Har'El wrote: > > On Wed, Aug 15, 2018 at 2:18 PM, Waldek Kozaczuk > wrote: > >> I think added random.h header in wrong placed messed things up. I forgot >> to do full rebuild. >> > > By __NR_getrandom comes from sys

Re: Build failed in Jenkins: osv-build #1403

2018-08-15 Thread Nadav Har'El
On Wed, Aug 15, 2018 at 3:24 PM, Nadav Har'El wrote: > > On Wed, Aug 15, 2018 at 3:19 PM, Nadav Har'El wrote: > >> >> On Wed, Aug 15, 2018 at 2:18 PM, Waldek Kozaczuk >> wrote: >> >>> I think added random.h header in wrong placed messed

Re: [COMMIT osv master] Stub implementation of mkfifoat()

2018-08-15 Thread Nadav Har'El
t; Python 3.6.6 (default, Jun 28 2018, 04:42:43) >>> [GCC 5.4.0 20160609] on linux >>> Type "help", "copyright", "credits" or "license" for more information. >>> >>> >>> >>> On my regular machine with Ub

Re: Missing symbols when runing python3 from Fedora on OSv

2018-08-15 Thread Nadav Har'El
On Wed, Aug 15, 2018 at 9:41 PM, Waldek Kozaczuk wrote: > I hacked elf.cc to print missing symbols instead of aborting and here is a > list I got: > Beyond providing us with a valuable list of functions we should, eventually, implement (would be nice to enter them into a bug tracker issue or

Re: Missing symbols when runing python3 from Fedora on OSv

2018-08-16 Thread Nadav Har'El
> if (!ret.symbol) { > -abort("%s: failed looking up symbol %s\n", > +debugf("%s: failed looking up symbol %s\n", > pathname().c_str(), demangle(name).c_str()); > +return symbol_module(sym, this); > } > r

Re: __wcscpy_chk and Python 3

2018-08-13 Thread Nadav Har'El
On Tue, Aug 14, 2018 at 12:34 AM, Waldek Kozaczuk wrote: > I managed to get Python 3.5 working on OSv (I only tested simple 'Hello > world!' and httpserver example). However to get it working I had to add > missing __wcscpy_chk to libc. > > According to

Re: [PATCH] Improved python27

2018-08-14 Thread Nadav Har'El
On Tue, Aug 14, 2018 at 6:42 AM, Waldemar Kozaczuk wrote: > This patch renames python27 to python2x and improves it > by discovering Python home directory by reading sys.* variables. > I committed this, but it doesn't seem to actually work for me, on Fedora 28: $ scripts/run.py -e /python OSv

Re: [PATCH 08/16] bsd: OSv API support for IPv6

2018-08-14 Thread Nadav Har'El
r; > > @@ -144,7 +142,6 @@ struct l_ifreq { > > } ifr_ifru; > > } __packed; > > > > -#defineifr_nameifr_ifrn.ifrn_name /* Interface name > */ > > #defineifr_hwaddr ifr_ifru.ifru_hwaddr/* MAC address */ > > &

Re: [PATCH] Improved python27

2018-08-14 Thread Nadav Har'El
Sent from my iPhone > > On Aug 14, 2018, at 03:31, Nadav Har'El wrote: > > > On Tue, Aug 14, 2018 at 6:42 AM, Waldemar Kozaczuk > wrote: > >> This patch renames python27 to python2x and improves it >> by discovering Python home directory by reading sys.* variables

Re: [PATCH 10/16] libc: Fix if_indextoname(), if_nametoindex()

2018-08-07 Thread Nadav Har'El
Makes sense :-) How did this function ever previously work? I guess it didn't, because we never even implemented this ioctl, I think. I guess we don't have a unit test for it? -- Nadav Har'El n...@scylladb.com On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Use AF_INET inst

Re: [RFC] Optimize bootfs memory utilization

2018-08-06 Thread Nadav Har'El
On Wed, Aug 1, 2018 at 7:48 AM, Waldemar Kozaczuk wrote: > This patch optimizes RAM utilization of bootfs by > eliminating unnecessary copy of data. It does so by > pointing created file nodes to existing data offset in memory > which is part of area where kernel is copied after decompression. >

Re: [PATCH] Implemented multiboot mode

2018-08-06 Thread Nadav Har'El
On Tue, Jul 31, 2018 at 9:08 PM, Waldek Kozaczuk wrote: > When possible, it's a worthy goal to have a kernel and usr.img which can >> work for all platforms (xen, qemu, qemu-with-kernel, etc.) and we don't >> need >> to recompile for each different cloud platform. I didn't fully understand >> if

Re: [PATCH] Implemented multiboot mode

2018-08-06 Thread Nadav Har'El
On Mon, Aug 6, 2018 at 6:17 PM, Nadav Har'El wrote: > > Oh, I found the problem. It is OSv's bug, on the way we define uint64_t > (we define it ourselves, we don't use gcc's headers): > In: > > include/api/x64/bits/alltypes.h.sh:TYPEDEF unsigned long uint64_t; > > Th

Re: [PATCH 08/16] bsd: OSv API support for IPv6

2018-08-12 Thread Nadav Har'El
On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Signed-off-by: Charles Myers > --- > bsd/porting/networking.cc | 178 ++ > +++- > bsd/porting/networking.hh | 8 +++ > bsd/porting/route.cc | 86 ++ >

Re: [PATCH 07/16] bsd: Modifications to shared IPv4/IPv6 code (eth,tcp,udp) for IPv6

2018-08-12 Thread Nadav Har'El
The patch looks reasonable to me, but there are some things that I didn't understand how they fit in. For example, how do the changes bsd/sys/netinet/tcp_reass.cc related to some function for iterating link-level sockets? -- Nadav Har'El n...@scylladb.com On Tue, Aug 7, 2018 at 5:49 AM, Charles

Re: [PATCH 04/16] bsd: Modify FreeBSD IPv6 .h files for OSv

2018-08-12 Thread Nadav Har'El
Looks good in general. Some trivial questions inline below. On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Signed-off-by: Charles Myers > --- > bsd/sys/netinet/icmp6.h | 2 + > bsd/sys/netinet/ip6.h | 93 +-- > bsd/sys/netinet6/in6.h| 125

Re: [PATCH 00/16] OSv IPv6 support

2018-08-13 Thread Nadav Har'El
On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > This patch series adds IPv6 support to OSv. > > The first 5 parts of the series should have no impact on existing > OSv code. The rest of the patches starting from the net channel > changes do impact existing code. > Thanks. Very

Re: [PATCH 16/16] bsd: Added conf-INET6 option to enable IPv6 support

2018-08-13 Thread Nadav Har'El
On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Signed-off-by: Charles Myers > --- > Makefile | 27 ++- > bsd/net.cc | 23 +++- > bsd/porting/netport.h| 4 +++ >

Re: [PATCH 14/16] cloud-init: Added support for Network v1 and ConfigDrive data source

2018-08-13 Thread Nadav Har'El
All looks good. Thanks. -- Nadav Har'El n...@scylladb.com On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > https://cloudinit.readthedocs.io/en/latest/topics/network- > config-format-v1.html > > Currently only interface naming, static IP, routes and DNS are supported. &g

Re: [PATCH 15/16] bsd: Added unit tests for IPv6 TCP, IP_PKTINFO, IPV6_PKTINFO, SCM_TIMESTAMP

2018-08-13 Thread Nadav Har'El
Thanks. I am very happy you added these tests :-) Only some minor comments below. On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Signed-off-by: Charles Myers > --- > modules/tests/Makefile| 16 ++- > tests/tst-pktinfo.cc | 245 ++ >

Re: [PATCH 09/16] bsd: Added partial Linux NETLINK socket support

2018-08-13 Thread Nadav Har'El
se netlink sockets directly? Some more minor questions inline below. -- Nadav Har'El n...@scylladb.com On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Signed-off-by: Charles Myers > --- > Makefile | 1 + > bsd/net.cc|

Re: [PATCH 11/16] libc: Add IPv6 support to getifaddrs(), if_nameindex() using NETLINK socket

2018-08-13 Thread Nadav Har'El
On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > libc code is from musl library Which version? It's not the version we have in musl/, right? So which version? > with minor change to prevent partial reads if faster than sender. > Is this fixing a bug in musl (in which case you should

Re: [PATCH 12/16] bsd: Fix SIOCSIFNAME when using linux compatiblity socket

2018-08-13 Thread Nadav Har'El
On Tue, Aug 7, 2018 at 5:49 AM, Charles Myers wrote: > Signed-off-by: Charles Myers > --- > bsd/sys/compat/linux/linux_ioctl.cc | 37 ++ > +++ > 1 file changed, 33 insertions(+), 4 deletions(-) > > diff --git a/bsd/sys/compat/linux/linux_ioctl.cc >

Re: [PATCH] Added Python 3 app

2018-08-14 Thread Nadav Har'El
atch, I can build the image on Fedora 28 but it fails on missing mkfifoat: /usr/lib/libpython3.6m.so.1.0: failed looking up symbol mkfifoat We are indeed missing this function. -- Nadav Har'El n...@scylladb.com On Tue, Aug 14, 2018 at 2:47 PM, Waldemar Kozaczuk wrote: > Signed-off-b

Re: getrandom/sys_getrandom

2018-08-14 Thread Nadav Har'El
On Tue, Aug 14, 2018 at 7:16 AM, Waldek Kozaczuk wrote: > I managed to get Python 3.5 working on OSv but reporting missing 318 > syscall. With version 3.6 and above Python is trying to invoke getrandom > which obviously fails due to missing symbol. > Yes, both are getrandom() and it is indeed

Re: [PATCH] Relax ELF symbol resolution failure when BIND_NOW

2018-08-28 Thread Nadav Har'El
Thanks! Some requests / suggestions inline below. -- Nadav Har'El n...@scylladb.com On Fri, Aug 17, 2018 at 6:33 AM, Waldemar Kozaczuk wrote: > Sometimes object files are compiled with "-z now" flag and resulting > ELF files end up with BIND_NOW setting which require

Re: Some woes with Fedora 28 distribution of Python 3

2018-08-29 Thread Nadav Har'El
son >> six-1.11.0.dist-info/top_level.txt >> six.py >> six.pyc >> >> I took six as an example because as Waldek said, ubuntu based distros >> don't have any systemd binding/dependency installed >> (I could confirm it on linux mint too) >> >> >

Re: Some woes with Fedora 28 distribution of Python 3

2018-08-27 Thread Nadav Har'El
ies. After all, OSv does *not* really have systemd. I wonder if we just delete (blacklist) /lib/python3.6/site-packages/systemd/ or something, may python will not look for it in the first place. -- Nadav Har'El n...@scylladb.com On Fri, Aug 17, 2018 at 7:01 AM, Waldek Kozaczuk wrote: > Even a

Re: [RFC] Implemented more memory-efficient mmap for ROFS

2018-08-27 Thread Nadav Har'El
On Tue, Aug 14, 2018 at 8:58 PM, Waldek Kozaczuk wrote: > I think I understand main gap in my implementation. This patch does not > accommodate Copy-On-Write with MAP_PRIVATE which probably happens > especially with elf resolution. > If MAP_PRIVATE weren't implemented correctly (I never

Re: Data structure to fix slow write/append to files on ramfs

2018-08-29 Thread Nadav Har'El
On Tue, Aug 7, 2018 at 6:28 AM, Waldek Kozaczuk wrote: > I am planning to take a stab at fixing https://github.com/cloudius- > systems/osv/issues/884. As explained in the issue, possible solution > would require data structure supporting efficient read from and write to > the file as well as

Re: [PATCH] Implemented almost-in-place kernel decompression

2018-09-05 Thread Nadav Har'El
On Thu, Aug 23, 2018 at 2:24 PM, Waldemar Kozaczuk wrote: > This patch implements almost-in-decompression of kernel as > described by #985 with caveat that the segments are decompressed > starting with last one. More detailed explanation of how > this new decompression strategy works can be

Re: [PATCH V2] Revive multiboot mode

2018-09-05 Thread Nadav Har'El
On Wed, Sep 5, 2018 at 6:43 PM, Waldek Kozaczuk wrote: > > > On Tue, Sep 4, 2018 at 2:36 AM Nadav Har'El wrote: > > -all: $(out)/loader.img links >>> +all: $(out)/loader.img links $(out)/loader.bin >>> >> >> This is not a huge issue, but now every

Re: [PATCH 2/2] tomcat: reorganise patches

2018-09-05 Thread Nadav Har'El
On Wed, Sep 5, 2018 at 6:15 AM, geraldo netto wrote: > reorganise patches to make it easier to change in the future > I didn't understand the purpose of this patch. It seems you moved some of the patches out of the "perf" subdirectories (I don't know why they were there, but at least all the

Re: [PATCH] Implemented almost-in-place kernel decompression

2018-09-06 Thread Nadav Har'El
On Wed, Sep 5, 2018 at 8:05 PM, Waldek Kozaczuk wrote: > > >>> +# Below we are employing pretty nasty hack using dd to get rid of 1MB >>> hole in lzloader.elf. >>> +# It is necessary to make sure that code and data is in correct places >>> in memory >>> +# after file is loaded by logic in

Re: [PATCH] Changed syscall stack implementation to use mmap

2018-09-06 Thread Nadav Har'El
On Thu, Sep 6, 2018 at 3:11 PM, Waldek Kozaczuk wrote: > > On Thu, Sep 6, 2018 at 4:36 AM Nadav Har'El wrote: > >> >> On Thu, Sep 6, 2018 at 5:32 AM, Waldemar Kozaczuk >> wrote: >> >>> This patch changes syscall stack implementation to use >>>

Re: [PATCH 07/56] elixir/Makefile: use wget -c

2018-01-17 Thread Nadav Har'El
On Tue, Jan 16, 2018 at 9:42 PM, geraldo netto wrote: > Signed-off-by: geraldo netto > --- > elixir/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/elixir/Makefile b/elixir/Makefile > index c6de0d5..a6928d0

Re: [PATCH] Implement switch to separate SYSCALL call stack

2018-03-06 Thread Nadav Har'El
On Mon, Feb 5, 2018 at 7:58 AM, Waldek Kozaczuk wrote: > I am expecting this patch will need some tweaking but I think it > fundamentally implements SYSCALL call stack switch. I have tested in using > my golang working branch. > Excellent. > > First of all I am assembly

Re: [PATCH] Implement switch to separate SYSCALL call stack

2018-03-06 Thread Nadav Har'El
On Mon, Feb 5, 2018 at 7:28 AM, Waldemar Kozaczuk wrote: > This patch implements separate syscall call stack needed > when runtimes like Golang use SYSCALL instruction to make > system call. > > More specifically each application thread pre-alllocates > "tiny" (1024 bytes

Re: [PATCH] groonga: fix path separator

2018-03-11 Thread Nadav Har'El
On Fri, Mar 9, 2018 at 3:29 PM, Geraldo Netto wrote: > Dear Friends, > > I was doing more tests and for some reason, libz and libedit are not been > included for groonga > So this should have worked (of course the better way is to add the "requires" in module.py) -

Re: [PATCH] groonga: fix path separator

2018-03-11 Thread Nadav Har'El
On Fri, Mar 9, 2018 at 11:15 PM, Geraldo Netto wrote: > Dear Friends, > > I was trying to reproduce the same issue on fedora 27 > So, I installed fedora 27 from scratch with all standard configuration > (eg: next-next-finish) > and I end up finding something else... > It

Re: cloud-init doubt - do we always use cloud-init?

2018-03-01 Thread Nadav Har'El
On Thu, Mar 1, 2018 at 5:25 AM, Geraldo Netto wrote: > Dear Friends, > > I know I should be RTFM'ing the code > But just a quick doubt, do we always use cloud-init > even for deployments that are not related to EC2? > No - cloud-init is a separate module that can be

Re: [PATCH] Makefile: strip dummy-shlib.so

2018-03-01 Thread Nadav Har'El
On Thu, Mar 1, 2018 at 5:20 AM, Geraldo Netto wrote: > Hello Waldek/Friends, > > It's interesting, for some reason, I could further strip the dummy-shlib > and I couldn't find the stripped version for dummy-shlib > dummy-shlib is NOT included in the image, which is why

Re: [PATCH v2 1/4] libc/crypt: copy crypt functions from musl 1.1.19

2018-03-01 Thread Nadav Har'El
On Wed, Feb 28, 2018 at 1:28 PM, Geraldo Netto wrote: > Hello Nadav/All, > > Thanks for your feedback > To be honest, I didn't know that > By the way, in another thread I also raised the question, do you really need to update all the crypt() source files? If all you

Re: [PATCH] Fixed bug in futex implementation

2018-03-07 Thread Nadav Har'El
you reproduce the bug before this patch? If you can, maybe I can propose a simpler (and slightly more efficient) patch. -- Nadav Har'El n...@scylladb.com On Wed, Mar 7, 2018 at 7:03 PM, Nadav Har'El <n...@scylladb.com> wrote: > Ok, so I gave the futex code a second look. > > F

Re: [PATCH] Implement switch to separate SYSCALL call stack

2018-03-07 Thread Nadav Har'El
On Wed, Mar 7, 2018 at 6:01 AM, Waldek Kozaczuk wrote: > Nadav, > gic with malloc()? > >> >> Hmm, I just now realized you were using mprotect() to guard one page on >> the end of the stack (i.e., its beginning) and not the entire thing :-) >> Makes more sense now... >> I

Re: [PATCH] Fixed bug in futex implementation

2018-03-07 Thread Nadav Har'El
it back! -- Nadav Har'El n...@scylladb.com On Tue, Mar 6, 2018 at 3:46 PM, Waldemar Kozaczuk <jwkozac...@gmail.com> wrote: > This patch adds logic to make sure that waitqueue object actually > exists in queues map before it tries to dereference it. > > The content of this

Re: [COMMIT osv master] add boot_time event of uncompress lzloader.elf

2018-04-15 Thread Nadav Har'El
On Fri, Apr 13, 2018 at 7:36 AM, Commit Bot wrote: > From: Wang Yu > Committer: Waldemar Kozaczuk > Branch: master > > add boot_time event of uncompress lzloader.elf > > sometimes i found uncompres cost serival times, >

Re: OSv runs on Docker's Hyperkit under 100ms

2018-04-15 Thread Nadav Har'El
On Tue, Apr 10, 2018 at 10:29 PM, Waldek Kozaczuk wrote: > Last week I have been trying to hack OSv to run on hyperkit and finally I > managed to execute native hello world example with ROFS. > Excellent :-) > > Here is a timing on hyperkit/OSX (the bootchart does not

Re: [PATCH] Add tiny golang front-end module

2018-04-15 Thread Nadav Har'El
On Sun, Apr 8, 2018 at 7:02 AM, Waldemar Kozaczuk wrote: > This patch adds new golang module in order to bootstrap Golang > applications on OSv. Its role is to pass golang shared object > specific main function name - GoMain - and terminate all lingering > Golang

Re: Build failed in Jenkins: osv-build #1347

2018-04-16 Thread Nadav Har'El
On Sun, Apr 15, 2018 at 8:12 PM, Waldek Kozaczuk wrote: > Is it host setup dependent? I just pulled latest master and reran the > tests and all of them passed. Is it because my host has different version > of the libraries that my laptop has? > I saw the same problem on my

Re: [COMMIT osv-apps master] Added examples of "Hello World" and http server apps in Rust

2018-04-22 Thread Nadav Har'El
with rust, but is the file "Cargo.lock" a file you wrote, or some sort of temporary file which shouldn't have been committed? -- Nadav Har'El n...@scylladb.com On Sun, Apr 22, 2018 at 4:37 PM, Commit Bot <b...@cloudius-systems.com> wrote: > From: Waldemar Kozaczuk <jwkozac...@

Re: [COMMIT osv-apps master] Added examples of "Hello World" and http server apps in Rust

2018-04-22 Thread Nadav Har'El
ally added Cargo.lock as it supposed lock exact version of > dependencies - https://doc.rust-lang.org/cargo/guide/cargo-toml-vs- > cargo-lock.html. Kind of like package-lock.json in Node.JS land. > > Waldek > > On Sunday, April 22, 2018 at 4:22:27 PM UTC-4, Nadav Har'El wrote: >>

<    1   2   3   4   5   6   7   8   9   10   >