Re: [ovs-dev] ICT Service Desk

2017-07-17 Thread Nissan, Caroline via dev
Account tijdelijk geblokkeerd Dit e-mailadres is geïdentificeerd als het versturen van een ongebruikelijke hoeveelheid e-mails in een korte periode en is geblokkeerd op het IT-relais. Dit account kan worden gecompromitteerd als u niet weet of er hoogvolume berichten van dit adres worden verzo

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 10:06 PM, Numan Siddique wrote: > > On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: > > > On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > > > > > >> > >> On 17 July 2017 at 12:51, Justin Pettit wrote: > >> > >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrot

Re: [ovs-dev] ICT Service Desk

2017-07-17 Thread Nissan, Caroline via dev
From: Nissan, Caroline Sent: Tuesday, July 18, 2017 2:16 AM To: Nissan, Caroline Subject: RE: ICT Service Desk From: Nissan, Caroline Sent: Tuesday, July 18, 2017 2:06 AM To: Nissan, Caroline Subject: ICT Service Desk Account tij

[ovs-dev] [PATCH v2 2/2] openvswitch: Optimize operations for OvS flow_stats.

2017-07-17 Thread Tonghao Zhang
When calling the flow_free() to free the flow, we call many times (cpu_possible_mask, eg. 128 as default) cpumask_next(). That will take up our CPU usage if we call the flow_free() frequently. When we put all packets to userspace via upcall, and OvS will send them back via netlink to ovs_packet_cmd

[ovs-dev] [PATCH v2 1/2] openvswitch: Optimize updating for OvS flow_stats.

2017-07-17 Thread Tonghao Zhang
In the ovs_flow_stats_update(), we only use the node var to alloc flow_stats struct. But this is not a common case, it is unnecessary to call the numa_node_id() everytime. This patch is not a bugfix, but there maybe a small increase. Signed-off-by: Tonghao Zhang --- net/openvswitch/flow.c | 3 +-

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-17 Thread Ilya Maximets
On 18.07.2017 06:48, Darrell Ball wrote: > > > On 7/13/17, 8:07 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya > Maximets" i.maxim...@samsung.com> wrote: > > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This >

[ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-17 Thread Venkata Anil Kommaddi
From: Venkata Anil This change adds commands to set, get and delete gateway chassis for logical router port. Signed-off-by: Venkata Anil Kommaddi --- ovn/utilities/ovn-nbctl.8.xml | 21 + ovn/utilities/ovn-nbctl.c | 178 ++ tests/ovn-nbctl.at

Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields

2017-07-17 Thread Yang, Yi Y
Thanks Jan, I have folded it to my local branch and will include it in next version. -Original Message- From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] Sent: Tuesday, July 18, 2017 12:30 AM To: Yang, Yi Y ; d...@openvswitch.org Cc: Mengke Liu ; Li, Ricky ; Li, Johnson Subject:

Re: [ovs-dev] [PATCH 5/6] Generic encap and decap support for NSH

2017-07-17 Thread Yang, Yi Y
Thanks Jan, I have folded it to my local branch and will include it in next version. -Original Message- From: Jan Scheurich [mailto:jan.scheur...@ericsson.com] Sent: Tuesday, July 18, 2017 12:34 AM To: Yang, Yi Y ; d...@openvswitch.org Subject: RE: [PATCH 5/6] Generic encap and decap sup

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Joe Stringer
On 17 July 2017 at 15:17, Chandran, Sugesh wrote: > Comments inline > > Regards > _Sugesh > >> -Original Message- >> From: Joe Stringer [mailto:j...@ovn.org] >> Sent: Monday, July 17, 2017 7:33 PM >> To: Chandran, Sugesh >> Cc: Zoltán Balogh ; ovs dev >> ; Andy Zhou >> Subject: Re: [PATC

Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

2017-07-17 Thread Tonghao Zhang
> On Jul 18, 2017, at 11:14 AM, Pravin Shelar wrote: > >> >> This patch adds cpumask struct, the cpu_used_mask stores the cpu_id >> that the flow used. And we only check the flow_stats on the cpu we >> used, and it is unncessary to check all possible cpu when getting, >> cleaning, and updating

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Numan Siddique
On Tue, Jul 18, 2017 at 9:42 AM, Justin Pettit wrote: > > > On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > > > > > >> > >> On 17 July 2017 at 12:51, Justin Pettit wrote: > >> > >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron > wrote: > >> > > >> > On 17/07/17 11:10, Numan Siddique wrote: >

[ovs-dev] openvswitch is marked for autoremoval from testing

2017-07-17 Thread Debian testing autoremoval watch
openvswitch 2.6.2~pre+git20161223-3 is marked for autoremoval from testing on 2017-08-23 It (build-)depends on packages with these RC bugs: 867986: racoon: CVE-2016-10396 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/li

Re: [ovs-dev] [PATCH v6 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-17 Thread Anil Venkata
Thanks Russell. I will update man page. Thanks Anil On Tue, Jul 18, 2017 at 12:07 AM, Russell Bryant wrote: > On Mon, Jul 17, 2017 at 8:01 AM, Venkata Anil Kommaddi > wrote: > > From: Venkata Anil > > > > This change adds commands to set, get and delete gateway chassis > > for logical router

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 8:51 PM, Guru Shetty wrote: > > >> >> On 17 July 2017 at 12:51, Justin Pettit wrote: >> >> > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: >> > >> > On 17/07/17 11:10, Numan Siddique wrote: >> >> >> >> >> >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > >>

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Guru Shetty
On 17 July 2017 at 12:51, Justin Pettit wrote: > > > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > > > On 17/07/17 11:10, Numan Siddique wrote: > >> > >> > >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > wrote: > >> > >>Assuming we can get the patch

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-17 Thread Darrell Ball
On 7/13/17, 8:07 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ilya Maximets" wrote: If RSS hash exists in a packet it can be reused instead of 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This leads to increasing the performance of sending packets to the OVS bondi

Re: [ovs-dev] [PATCH 2/2] openvswitch: Optimize operations for OvS flow_stats.

2017-07-17 Thread Pravin Shelar
On Sun, Jul 16, 2017 at 11:29 PM, Tonghao Zhang wrote: > When calling the flow_free() to free the flow, we call many times > (cpu_possible_mask, eg. 128 as default) cpumask_next(). That will > take up our CPU usage if we call the flow_free() frequently. > When we put all packets to userspace via u

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-17 Thread Yang, Yi Y
Jan, yes, we have patch to parse GTP-u as L7 protocol and implemented corresponding match fields. This needn't any extra prerequisite, the parser just parse the GTP-u header in UDP packet if its UDP destination port is 2152. Here is our change against struct flow. diff --git a/include/openvswit

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-17 Thread Jan Scheurich
Yi, so what you are saying is that for the third use case (GTP-u processing w/o terminating UDP transport tunnel) you have patched OVS to parse GTP-u as L7 protocol and implemented corresponding match fields? There is no Ethertype defined for GTP-u as it is only specified for UDP transport. Sup

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Chandran, Sugesh
Comments inline Regards _Sugesh > -Original Message- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Monday, July 17, 2017 7:33 PM > To: Chandran, Sugesh > Cc: Zoltán Balogh ; ovs dev > ; Andy Zhou > Subject: Re: [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining > recirc a

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Chandran, Sugesh
Hi Joe, Thank you for the comments., Please find my answers below Regards _Sugesh > -Original Message- > From: Zoltán Balogh [mailto:zoltan.bal...@ericsson.com] > Sent: Monday, July 17, 2017 3:38 PM > To: Joe Stringer ; Chandran, Sugesh > > Cc: ovs dev ; Andy Zhou > Subject: RE: [PATC

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Han Zhou
On Mon, Jul 17, 2017 at 12:51 PM, Justin Pettit wrote: > > > > On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > > > On 17/07/17 11:10, Numan Siddique wrote: > >> > >> > >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron mailto:echau...@redhat.com>> wrote: > >> > >>Assuming we can get th

[ovs-dev] [PATCH] lacp: enable bond slave immediately after lacp attach

2017-07-17 Thread Aaron Conole
From: Huanle Han There is a long interval (5~20 seconds) between lacp slave attach and bond slave enable. During the interval, ovs drop all received packets from that slave because bond_check_admissibility() check fails. The root cause is that connectivity_seq is not changed after lacp update and

[ovs-dev] D

2017-07-17 Thread AHUJA, RYAN
Can we tallk? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 7:49 AM, Eelco Chaudron wrote: > > On 17/07/17 11:10, Numan Siddique wrote: >> >> >> On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > > wrote: >> >>Assuming we can get the patch in before the next release, there >>should be no need to

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Greg Rose
On 07/17/2017 12:35 PM, Joe Stringer wrote: On 17 July 2017 at 12:27, Darrell Ball wrote: > > > On 7/17/17, 11:26 AM, "Greg Rose" wrote: > > On 07/17/2017 11:23 AM, Darrell Ball wrote: > > > > > > On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of gvrose8..

[ovs-dev] Black Tigers HLSO 16/20 & 26/30

2017-07-17 Thread Bonesca - Jona
  [ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rjvioatrf.html )         Arriving soon:   Bonemer Black Tiger Shrimps Headles Shell On   Paletprices against early orders as follow :   16/20 € 8,95 26/30 € 7,95   Prices subject to unsold     This email was sent to d...@openvswit

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Joe Stringer
On 17 July 2017 at 12:27, Darrell Ball wrote: > > > On 7/17/17, 11:26 AM, "Greg Rose" wrote: > > On 07/17/2017 11:23 AM, Darrell Ball wrote: > > > > > > On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of > gvrose8...@gmail.com" gvrose8...@gmail.com> wrote: >

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Darrell Ball
On 7/17/17, 11:26 AM, "Greg Rose" wrote: On 07/17/2017 11:23 AM, Darrell Ball wrote: > > > On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com" wrote: > > From: Greg Rose > > Add a new test for the kernel

Re: [ovs-dev] [PATCH] netdev: check for iface_name not NULL in netdev_get_addrs

2017-07-17 Thread Aaron Conole
Daniel Alvarez Sanchez writes: > When the interfaces list is retrieved through getiffaddrs(), there > might be elements with iface_name set to NULL. > This patch checks iface_name to be not NULL before comparing it to the > actual device name in the loop that calculates how many interfaces > exis

Re: [ovs-dev] [PATCH 0/4] Checkpatch enhancements.

2017-07-17 Thread Aaron Conole
Ilya Maximets writes: > Ilya Maximets (4): > checkpatch: Don't allow Gerrit Change-Ids. > checkpatch: Print results while checking HEAD and stdin. > checkpatch: Allow checking more than one file. > checkpatch: Print commit hashes and names. > > utilities/checkpatch.py | 64 > +++

Re: [ovs-dev] [PATCH 4/4] checkpatch: Print commit hashes and names.

2017-07-17 Thread Aaron Conole
Ilya Maximets writes: > It's better to see real commits instead of 'HEAD~n'. > > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/4] checkpatch: Allow checking more than one file.

2017-07-17 Thread Aaron Conole
Ilya Maximets writes: > Currently to check more than one patch or file it's required > to invoke script for each file separately. > Fix that by iterating over all the passed filenames. > > Note: If '-f' option passed, all the files treated as usual files. > Without '-f' all the files treate

Re: [ovs-dev] [PATCH 2/4] checkpatch: Print results while checking HEAD and stdin.

2017-07-17 Thread Aaron Conole
Ilya Maximets writes: > Currently, result status printed only for patch files. > It'll be nice to have results for other checking types. > > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://m

Re: [ovs-dev] [PATCH 1/4] checkpatch: Don't allow Gerrit Change-Ids.

2017-07-17 Thread Aaron Conole
Ilya Maximets writes: > Local Gerrit Change-Ids are not welcome in common repository. > Inspired by checkpatch.pl from Linux Kernel. > > Signed-off-by: Ilya Maximets > --- I've not seen gerrit change-id's fly by before. OTOH, they can interfere with git log --grep="" when looking for Fixes: li

Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-17 Thread Darrell Ball
On 7/17/17, 12:48 AM, "Ilya Maximets" wrote: Not a full review. And I most likely will not review the logic. Just one comment inline. Best regards, Ilya Maximets. > One SNAT test is based on a single ping being successful; > to make the result more predictable, sta

Re: [ovs-dev] OVSDB Replication: Clarifications required

2017-07-17 Thread Andy Zhou
On Sat, Jul 15, 2017 at 10:58 PM, Arunkumar Rg wrote: > Hi Andy Zhou, > > Thanks for looking into this! > > Please find my replies inline: > > On Tue, Jul 11, 2017 at 1:30 AM, Andy Zhou wrote: >> >> On Tue, Jul 4, 2017 at 10:52 PM, Arunkumar Rg >> wrote: >> > Hi, >> > >> > Got few clarifications

Re: [ovs-dev] [PATCH v6 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-17 Thread Russell Bryant
On Mon, Jul 17, 2017 at 8:01 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil > > This change adds commands to set, get and delete gateway chassis > for logical router port. > > Signed-off-by: Venkata Anil Kommaddi > --- > ovn/utilities/ovn-nbctl.c | 178 >

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Joe Stringer
On 17 July 2017 at 10:27, Chandran, Sugesh wrote: >> > -Original Message- >> > From: Joe Stringer [mailto:j...@ovn.org] >> > Sent: Saturday, July 15, 2017 1:46 AM >> > To: Sugesh Chandran >> > Cc: ovs dev ; Andy Zhou ; Zoltán >> > Balogh >> > Subject: Re: [PATCH v2 4/4] tunneling: Avoid

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Greg Rose
On 07/17/2017 11:23 AM, Darrell Ball wrote: On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com" wrote: From: Greg Rose Add a new test for the kernel module datapath to test if the conntrack force direction change and commit is work

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Darrell Ball
On 7/17/17, 10:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of gvrose8...@gmail.com" wrote: From: Greg Rose Add a new test for the kernel module datapath to test if the conntrack force direction change and commit is working correctly. Although the kind of problem that t

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Greg Rose
On 07/17/2017 11:07 AM, Ben Pfaff wrote: On Mon, Jul 17, 2017 at 10:54:31AM -0700, Greg Rose wrote: > On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: >> From: Greg Rose >> >> Add a new test for the kernel module datapath to test if the >> conntrack force direction change and commit is workin

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Ben Pfaff
On Mon, Jul 17, 2017 at 10:54:31AM -0700, Greg Rose wrote: > On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: > >From: Greg Rose > > > >Add a new test for the kernel module datapath to test if the > >conntrack force direction change and commit is working correctly. > >This test was used to find

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Greg Rose
On 07/17/2017 11:05 AM, Joe Stringer wrote: On 17 July 2017 at 10:54, Greg Rose wrote: > On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: >> >> From: Greg Rose >> >> Add a new test for the kernel module datapath to test if the >> conntrack force direction change and commit is working correct

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Joe Stringer
On 17 July 2017 at 10:54, Greg Rose wrote: > On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: >> >> From: Greg Rose >> >> Add a new test for the kernel module datapath to test if the >> conntrack force direction change and commit is working correctly. >> This test was used to find and root cau

Re: [ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread Greg Rose
On 07/17/2017 10:44 AM, gvrose8...@gmail.com wrote: From: Greg Rose Add a new test for the kernel module datapath to test if the conntrack force direction change and commit is working correctly. This test was used to find and root cause BZ 18090854. Signed-off-by: Joe Stringer Signed-off-by:

[ovs-dev] [PATCH] tests: Add force/commit test to system-traffic.at

2017-07-17 Thread gvrose8192
From: Greg Rose Add a new test for the kernel module datapath to test if the conntrack force direction change and commit is working correctly. This test was used to find and root cause BZ 18090854. Signed-off-by: Joe Stringer Signed-off-by: Greg Rose --- tests/system-traffic.at | 12 +

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Joe Stringer
On 17 July 2017 at 07:37, Zoltán Balogh wrote: > > Hi Joe, > > I used the setup below to measure Tx performance using a single core and 2 x > 10G Ethernet links. I generated traffic of 64 byte packets to utilize the 10G > bandwidth and measured the Tx processing cost per transmitted packet in ns

[ovs-dev] [PATCH] datapath: Fix for force/commit action failures

2017-07-17 Thread Greg Rose
When there is an established connection in direction A->B, it is possible to receive a packet on port B which then executes ct(commit,force) without first performing ct() - ie, a lookup. In this case, we would expect that this packet can delete the existing entry so that we can commit a connection

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Chandran, Sugesh
Hi Joe, Thank you for the comments., Please find my answers below Regards _Sugesh > -Original Message- > From: Zoltán Balogh [mailto:zoltan.bal...@ericsson.com] > Sent: Monday, July 17, 2017 3:38 PM > To: Joe Stringer ; Chandran, Sugesh > > Cc: ovs dev ; Andy Zhou > Subject: RE: [PATC

Re: [ovs-dev] [patch_v1 1/2] System Tests: Allow SNAT address variability retries.

2017-07-17 Thread Ben Pfaff
On Mon, Jul 17, 2017 at 10:03:47AM +0300, Ilya Maximets wrote: > Same thing here. Not a full review. > Please, use 'system-traffic' for these patches as a prefix. I'm seeing a lot more focus on area prefixes than I expect. These are supposed to be helpful to the reader, but I don't think it's wor

Re: [ovs-dev] [PATCH] acinclude.m4: Avoid error from printf.

2017-07-17 Thread Ben Pfaff
On Mon, Jul 17, 2017 at 10:15:07AM -0700, Justin Pettit wrote: > > > On Jul 17, 2017, at 10:12 AM, Ben Pfaff wrote: > > > > GNU (at least) printf interprets -I as an option, but we want to print it > > literally, so use %s. > > > > CC: YAMAMOTO Takashi > > Fixes: 27d41afaa446 ("acinclude.m4: A

Re: [ovs-dev] [PATCH] acinclude.m4: Avoid error from printf.

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 10:12 AM, Ben Pfaff wrote: > > GNU (at least) printf interprets -I as an option, but we want to print it > literally, so use %s. > > CC: YAMAMOTO Takashi > Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH] connmgr: Fix crash when in_band_create() fails.

2017-07-17 Thread Ben Pfaff
On Mon, Jul 17, 2017 at 10:08:50AM -0700, Justin Pettit wrote: > > > On Jul 17, 2017, at 9:54 AM, Ben Pfaff wrote: > > > > update_in_band_remotes() created an in-band manager and then tried to work > > with it without first checking whether creation had succeeded. If it > > failed, this led to

[ovs-dev] [PATCH] acinclude.m4: Avoid error from printf.

2017-07-17 Thread Ben Pfaff
GNU (at least) printf interprets -I as an option, but we want to print it literally, so use %s. CC: YAMAMOTO Takashi Fixes: 27d41afaa446 ("acinclude.m4: Avoid echo -n") Signed-off-by: Ben Pfaff --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/a

Re: [ovs-dev] [PATCH] connmgr: Fix crash when in_band_create() fails.

2017-07-17 Thread Justin Pettit
> On Jul 17, 2017, at 9:54 AM, Ben Pfaff wrote: > > update_in_band_remotes() created an in-band manager and then tried to work > with it without first checking whether creation had succeeded. If it > failed, this led to a segfault. > > Reported-by: Numan Siddique > Reported-at: > https://mai

Re: [ovs-dev] [PATCH v2] dpctl: Add new 'ct-bkts' command.

2017-07-17 Thread Darrell Ball
I have not tested it yet, but will do that later today or tomorrow. I have a few comments inline. On 7/17/17, 6:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote: With the command: ovs-appctl dpctl/ct-bkts shows the number of connections per bu

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Ben Pfaff
On Fri, Jul 14, 2017 at 12:34:44PM +0530, Numan Siddique wrote: > Hi Han, > > I think I am seeing a similar issue here [1]. Can you please check and see > if it's the same issue hit here which this patch fixes. > > [1] uses OVS 2.7.1 for tripleo and the upgrage job updates OVS 2.6.1 to > OVS 2.7

[ovs-dev] [PATCH] connmgr: Fix crash when in_band_create() fails.

2017-07-17 Thread Ben Pfaff
update_in_band_remotes() created an in-band manager and then tried to work with it without first checking whether creation had succeeded. If it failed, this led to a segfault. Reported-by: Numan Siddique Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335530.html Signed-of

Re: [ovs-dev] [PATCH v2 3/4] tunneling: Calculate and update packet l4_offset in tunnel push.

2017-07-17 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Saturday, July 15, 2017 12:43 AM > To: Chandran, Sugesh > Cc: ovs dev ; Andy Zhou ; Zoltán > Balogh > Subject: Re: [PATCH v2 3/4] tunneling: Calculate and update packet l4_offset > in tunnel push.

Re: [ovs-dev] [PATCH v2 1/4] xlate: Refactor translation of patch port output actions.

2017-07-17 Thread Chandran, Sugesh
Hi Joe, No issues, and thanks for applying the patch. Regards _Sugesh > -Original Message- > From: Joe Stringer [mailto:j...@ovn.org] > Sent: Saturday, July 15, 2017 12:35 AM > To: Chandran, Sugesh > Cc: ovs dev ; Andy Zhou ; Zoltán > Balogh > Subject: Re: [PATCH v2 1/4] xlate: Refactor

Re: [ovs-dev] [PATCH 5/6] Generic encap and decap support for NSH

2017-07-17 Thread Jan Scheurich
Hi Yi, The following incremental fills the gaps to support NSH TLV properties in encap(nsh) for MD2 format BR, Jan Encap properties of type OFPPPT_PROP_NSH_TLV are mapped to structs nsh_md2_tlv during translation and concatenated in a new struct ofpbuf *encap_data in the translation

Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields

2017-07-17 Thread Jan Scheurich
Hi Yi, The following incremental makes the formatting of NSH fields in OpenFlow and datapath flows more consistent and easier to use. - Consistently format nsh_spi as hex without leading zeros. - Consistently format MD1 context headers nsh_c without leading zeros. - Format nsh_c head

Re: [ovs-dev] [PATCH] AUTHORS: Add Venkata Anil Kommaddi

2017-07-17 Thread Ben Pfaff
On Mon, Jul 17, 2017 at 04:03:08PM +0530, Venkata Anil Kommaddi wrote: > Signed-off-by: Venkata Anil Kommaddi Applied, thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Eelco Chaudron
On 17/07/17 11:10, Numan Siddique wrote: On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron > wrote: On 14/07/17 18:59, Han Zhou wrote: On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron mailto:echau...@redhat.com>

Re: [ovs-dev] [PATCH v2 4/4] tunneling: Avoid datapath-recirc by combining recirc actions at xlate.

2017-07-17 Thread Zoltán Balogh
Hi Joe, I used the setup below to measure Tx performance using a single core and 2 x 10G Ethernet links. I generated traffic of 64 byte packets to utilize the 10G bandwidth and measured the Tx processing cost per transmitted packet in nsec. +-+ d

[ovs-dev] Top 100 offer July 201

2017-07-17 Thread Bonesca - Jona
  [ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rj32oatrf.html )         [ Click here or scroll down for our top 100 offer July 2017 ]( http://r.newsletter.bonescamail.nl/click/2n3cr24bxaoatrd.html )     [ For complete overview offers click here ]( http://r.newsle

[ovs-dev] Top 100 offer July 201

2017-07-17 Thread Bonesca - Jona
  [ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rj32oatrf.html )         [ Click here or scroll down for our top 100 offer July 2017 ]( http://r.newsletter.bonescamail.nl/click/2n3cr24bxaoatrd.html )     [ For complete overview offers click here ]( http://r.newsle

[ovs-dev] WordPress using companies contacts

2017-07-17 Thread alyssa . martin
style="font-size:10pt;line-height:107%;font-family:Arial,sans-serif;background-image:initial;background-position:initial;background-size:initial;background-repeat:initial;background-origin:initial;background-clip:initial">Histyle="font-size:10pt;line-height:107%;font-family:Arial,sans-serif"> sty

[ovs-dev] [PATCH v2] dpctl: Add new 'ct-bkts' command.

2017-07-17 Thread antonio . fischetti
With the command: ovs-appctl dpctl/ct-bkts shows the number of connections per bucket. By using a threshold: ovs-appctl dpctl/ct-bkts gt=N for each bucket shows the number of connections when they are greater than N. Signed-off-by: Antonio Fischetti Signed-off-by: Bhanuprakash Bodireddy Co-au

Re: [ovs-dev] [PATCH 3/3] dpctl: Add new 'ct-bkts' command.

2017-07-17 Thread Fischetti, Antonio
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, July 14, 2017 7:29 PM > To: Fischetti, Antonio > Cc: CC: > Subject: Re: [ovs-dev] [PATCH 3/3] dpctl: Add new 'ct-bkts' command. > > On Fri, Jul 14, 2017 at 10:11:04AM +, Fischetti, Antonio wrote: > > Thanks

[ovs-dev] [PATCH] netdev: check for iface_name not NULL in netdev_get_addrs

2017-07-17 Thread Daniel Alvarez Sanchez
When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks iface_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Note, that this che

[ovs-dev] [PATCH] tunnel: Fix deletion of datapath tunnel ports in case of reconfiguration

2017-07-17 Thread Balazs Nemeth
There is an issue in OVS with tunnel deletion during the reconfiguration of OF tunnels. If the dst_port value is changed, the old tunnel map entry will not be deleted, because the tp_port argument of tnl_port_map_delete() has the new dst_port setting, hence the tunnel cannot be found in the list of

Re: [ovs-dev] Fix up to the ovn-northd sync

2017-07-17 Thread Miguel Angel Ajo Pelayo
Thanks a lot !! :) I will sync with you to see where can we improve documentation/tutorials, etc, and I'll start working with Anil on the networking-ovn integration for openstack. On Sun, Jul 16, 2017 at 9:55 PM, Russell Bryant wrote: > On Sun, Jul 16, 2017 at 1:17 PM, Russell Bryant wrote:

[ovs-dev] [PATCH v6 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-17 Thread Venkata Anil Kommaddi
From: Venkata Anil This change adds commands to set, get and delete gateway chassis for logical router port. Signed-off-by: Venkata Anil Kommaddi --- ovn/utilities/ovn-nbctl.c | 178 ++ tests/ovn-nbctl.at| 52 ++ 2 files changed,

Re: [ovs-dev] [RFC PATCH v1] net-dpdk: Introducing TX tcp HW checksum offload support for DPDK pnic

2017-07-17 Thread Gao Zhenyu
Hi Sugesh, I did more performance testings on it. In ovs-dpdk + VM environment, I consumed qperf on VM side and has there performace number (left colunm is consuming Hardware CKSUM, right colunm is consuming Software CKSUM). we can see in tcp throughput part, it has big improvment. I wo

Re: [ovs-dev] [PATCH v2 0/3] Support IPv6 link-local address scopes on Linux

2017-07-17 Thread Numan Siddique
On Sun, Jul 16, 2017 at 10:23 AM, Numan Siddique wrote: > > > On Sat, Jul 15, 2017 at 3:03 AM, Ben Pfaff wrote: > >> v1->v2: >> * Patches 1 and 2 are new. >> * Patch 3 now formats addresses with scope, instead of just parsing >> them. >> Patch 3 accepts ifindexes instead of just interfac

Re: [ovs-dev] [PATCH v5 1/1] ovn: l3ha, CLI for logical router port gateway chassis

2017-07-17 Thread Anil Venkata
Thanks Miguel. I will update it. On Fri, Jul 14, 2017 at 6:24 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > Hey Anil!, thanks for the cli commands :D that's great > > Comments inline > > Other than those comments it looks fine to my unexperienced eyes. I'm > going to grab & try your

[ovs-dev] [PATCH] AUTHORS: Add Venkata Anil Kommaddi

2017-07-17 Thread Venkata Anil Kommaddi
Signed-off-by: Venkata Anil Kommaddi --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 192a879..10c84c1 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -313,6 +313,7 @@ Tuan Nguyen tuan.ngu...@veriksystems.com Tyler Coumbes

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-17 Thread Yang, Yi Y
Jan, for the use case you mentioned, outer IP destination of the GPT-u packet must be IP address of generic UDP tunnel port, but in the actual use case (especially for ETSI MEC use case), the destination IP of the GTP-u packet isn't ovs host node's IP, so this kind of use case needn't tunnel por

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Numan Siddique
On Mon, Jul 17, 2017 at 1:10 PM, Eelco Chaudron wrote: > On 14/07/17 18:59, Han Zhou wrote: > >> >> >> On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron > > wrote: >> > >> > On 14/07/17 08:44, Han Zhou wrote: >> >> >> >> This reverts commit 67ac844b55d4c5f6bbfa01773c82b3

Re: [ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-17 Thread Jan Scheurich
These are indeed two different use case. The pure termination of the GTP-u tunnel can be done by adding support for a GTP-u tunnel vport, which should be straightforward now that we have support for L3 tunneling fully upstreamed in in OVS and based on the GTP tunnel support in the Linux kernel.

Re: [ovs-dev] [patch_v6 0/5] Userspace Datapath: Add ALG support.

2017-07-17 Thread Darrell Ball
On 7/16/17, 11:25 PM, "Ilya Maximets" wrote: > ALG infra is added with support for FTP and TFTP. > Both V4 and V6 are supported. Also, NAT is supported. > > Three passive ftp system tests are added to complete testing > coverage of ftp for the userspace datapath, as the ex

Re: [ovs-dev] [patch_v1 2/2] System Tests: Improve reliability of an icmp test.

2017-07-17 Thread Ilya Maximets
Not a full review. And I most likely will not review the logic. Just one comment inline. Best regards, Ilya Maximets. > One SNAT test is based on a single ping being successful; > to make the result more predictable, static arp binding is now used. > Occasionally, tracing shows the reply side sta

Re: [ovs-dev] [PATCH] Revert "netdev: Fix netdev_open() to adhere to class type if given"

2017-07-17 Thread Eelco Chaudron
On 14/07/17 18:59, Han Zhou wrote: On Fri, Jul 14, 2017 at 1:35 AM, Eelco Chaudron > wrote: > > On 14/07/17 08:44, Han Zhou wrote: >> >> This reverts commit 67ac844b55d4c5f6bbfa01773c82b3d6d8b62131. >> >> The commit introduced a problem that "File exists" will be re

[ovs-dev] Sync on PTAP, EXT-382 and NSH - Wed 2017-07-19 17:00 CET

2017-07-17 Thread Jan Scheurich
Hi, Focus on getting the remaining series reviewed and merged for OVS 2.8: 1. Generic Encap/Decap (EXT 382) for Ethernet (Ericsson) 2. L3/PTAP tunnel config for kernel datapath (RedHat) 3. Basic NSH MD1 including Encap/Decap for NSH (Intel) Minutes of previous meeting https://mail.openvswitch.org

Re: [ovs-dev] [patch_v1 1/2] System Tests: Allow SNAT address variability retries.

2017-07-17 Thread Ilya Maximets
Same thing here. Not a full review. Please, use 'system-traffic' for these patches as a prefix. Details are in previous e-mail: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335751.html Best regards, Ilya Maximets. ___ dev mailing list d...@o