Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files

On Wed, May 8, 2019, 20:35 Ben Pfaff wrote: > On Wed, May 08, 2019 at 04:15:59PM -0400, Aaron Conole wrote: > > Hi Numan, > > > > (also, CC'ing Mark) > > > > 0-day Robot writes: > > > > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried > out your patch. > > > Thanks for

[ovs-dev] [PATCH] ovs-save: Handle cases of upgrades from very old OVS versions.

We have added code to ovs-save over the last few releases which makes the following bad assumptions. 1. The default OpenFlow version of running daemon is OpenFlow14. Impact: This causes upgrades from older OVS versions to end up with no flows in their bridges (even the default 'NORMAL' ones)

Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files

On Wed, May 08, 2019 at 04:15:59PM -0400, Aaron Conole wrote: > Hi Numan, > > (also, CC'ing Mark) > > 0-day Robot writes: > > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > > your patch. > > Thanks for your contribution. > > > > I encountered some error that I

[ovs-dev] [PATCH 3/7 v2] datapath: Use new header file net/ipv6_frag.h

From: Florian Westphal Upstream commit: commit 70b095c84326640eeacfd69a411db8fc36e8ab1a Author: Florian Westphal Date: Sat Jul 14 01:14:01 2018 +0200 ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module IPV6=m DEFRAG_IPV6=m CONNTRACK=y yields:

[ovs-dev] [PATCH 2/7 v2] datapath: Pass nf_hook_state to nf_conntrack_in()

From: Florian Westphal Upstream Commit: commit 93e66024b0249cec81e91328c55a754efd3192e0 Author: Florian Westphal Date: Wed Sep 12 15:19:07 2018 +0200 netfilter: conntrack: pass nf_hook_state to packet and error handlers nf_hook_state contains all the hook

Re: [ovs-dev] [PATCH 7/7] datapath: Support kernel version 4.19.x and 4.20.x

Sure, I will submit new versions after testing is done. Thanks, Yifeng On Wed, May 8, 2019 at 4:05 PM Ben Pfaff wrote: > > On Wed, May 08, 2019 at 02:27:57PM -0700, Yi-Hung Wei wrote: > > On Mon, May 6, 2019 at 3:01 PM Yifeng Sun wrote: > > > > > > This patch updated acinclude.m4 so that OVS

Re: [ovs-dev] [PATCH 5/7] openvswitch: use nf_ct_get_tuplepr, invert_tuplepr

Thanks for reviewing, please see my acks in below. Yifeng On Wed, May 8, 2019 at 2:19 PM Yi-Hung Wei wrote: > > On Mon, May 6, 2019 at 2:59 PM Yifeng Sun wrote: > > > > From: Florian Westphal > > > > Upstream commit: > > commit 60e3be94e6a1c5162a0763c9aafb5190b2b1fdce > > Author:

Re: [ovs-dev] [PATCH v3 1/3] netdev: Dynamic per-port Flow API.

> -Original Message- > From: Ilya Maximets > Sent: Tuesday, May 7, 2019 12:24 PM > To: ovs-dev@openvswitch.org > Cc: Ian Stokes ; Flavio Leitner ; > Ophir Munk ; Kevin Traynor > ; Roni Bar Yanai ; Finn > Christensen ; Ben Pfaff ; Roi Dayan > ; Simon Horman ; > Ilya Maximets > Subject:

Re: [ovs-dev] [PATCH 0/7] datapath: Support 4.19.x and 4.20.x kernel

On 5/6/2019 2:56 PM, Yifeng Sun wrote: This series of patches enabled OVS to support kernel 4.19.x and 4.20.x. Tests shows that this series of patches passed check-kmod tests or didn't introduce new failed check-kmod tests for the following kernel versions: 3.10.0-957.12.1.el7.x86_64 (rhel)

Re: [ovs-dev] [PATCH 3/7] datapath: Use new header file net/ipv6_frag.h

Thank for the review, I will fix in next version. Yifeng On Wed, May 8, 2019 at 1:54 PM Yi-Hung Wei wrote: > > On Mon, May 6, 2019 at 2:58 PM Yifeng Sun wrote: > > > > From: Florian Westphal > > > > Upstream commit: > > commit 70b095c84326640eeacfd69a411db8fc36e8ab1a > > Author:

Re: [ovs-dev] [PATCH 2/7] datapath: Pass nf_hook_state to nf_conntrack_in

Thanks for the review, please see my acks in below. On Wed, May 8, 2019 at 1:53 PM Yi-Hung Wei wrote: > > On Mon, May 6, 2019 at 2:58 PM Yifeng Sun wrote: > > > > From: Florian Westphal > > > > Upstream Commit: > > commit 93e66024b0249cec81e91328c55a754efd3192e0 > > Author: Florian

Re: [ovs-dev] [PATCH] netdev: Dynamic per-port Flow API.

Hi Ilya, > -Original Message- > From: Ilya Maximets > Sent: Wednesday, April 24, 2019 6:12 PM > To: Ophir Munk ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Flavio Leitner ; > Kevin Traynor ; Roni Bar Yanai > ; Finn Christensen ; Ben Pfaff > ; Roi Dayan ; Simon Horman > ; Olga Shern ; >

Re: [ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

Hi Numan, Thanks for the feedback. Submitted v7 with updated ovn-architecture.xml. Thanks Regards, Ankur From: Numan Siddique Sent: Wednesday, May 8, 2019 4:30 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR On

[ovs-dev] [PATCH v7 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 2, Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical

[ovs-dev] [PATCH v7 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

Background: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2] https://docs.google.com/document/d/1uoQH478wM1OZ16HrxzbOUvk5LvFnfNEWbkPT6Zmm9OU/edit?usp=sharing This Series: Layer 3 E-W and Layer 3 N-S (NO NAT) changes for vlan backed distributed logical router. This

[ovs-dev] [PATCH v7 0/2] OVN: Distributed Virtual Router for Vlan Backed Networks

This series is about enhancing the logical router functionality in OVN to work with vlan backed logical switches. Intial proposal was discused here: [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-October/353066.html [2]

Re: [ovs-dev] [PATCH 7/7] datapath: Support kernel version 4.19.x and 4.20.x

On Mon, May 6, 2019 at 3:01 PM Yifeng Sun wrote: > > This patch updated acinclude.m4 so that OVS can be compiled on 4.19.x > and 4.20.x kernels. > This patch also updated travis files so that latest kernel versions > are used during travis test builds. > > Signed-off-by: Yifeng Sun > --- Thanks

Re: [ovs-dev] [PATCH 4/7] datapath: Fix conntrack_count related compilation errors

On Wed, May 8, 2019 at 1:44 PM Gregory Rose wrote: > On 5/6/2019 2:56 PM, Yifeng Sun wrote: > > This patch fixes the compilation errors of OVS on 4.19+ kernels. > > > > Signed-off-by: Yifeng Sun > > --- > > datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++-- > >

Re: [ovs-dev] [PATCH 6/7] netfilter: Remove useless param helper of nf_ct_helper_ext_add

On Tue, May 7, 2019 at 6:39 PM Gao Feng wrote: > > > At 2019-05-07 05:56:47, "Yifeng Sun" wrote: > >From: Gao Feng > > > >Upstream commit: > >commit 440534d3c56be04abfb26850ee882d19d223557a > >Author: Gao Feng > >Date: Mon Jul 9 18:06:33 2018 +0800 > > > >netfilter: Remove

Re: [ovs-dev] [PATCH 5/7] openvswitch: use nf_ct_get_tuplepr, invert_tuplepr

On Mon, May 6, 2019 at 2:59 PM Yifeng Sun wrote: > > From: Florian Westphal > > Upstream commit: > commit 60e3be94e6a1c5162a0763c9aafb5190b2b1fdce > Author: Florian Westphal > Date: Mon Jun 25 17:55:32 2018 +0200 > > openvswitch: use nf_ct_get_tuplepr, invert_tuplepr > >

Re: [ovs-dev] [PATCH 3/7] datapath: Use new header file net/ipv6_frag.h

On Mon, May 6, 2019 at 2:58 PM Yifeng Sun wrote: > > From: Florian Westphal > > Upstream commit: > commit 70b095c84326640eeacfd69a411db8fc36e8ab1a > Author: Florian Westphal > Date: Sat Jul 14 01:14:01 2018 +0200 > > ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module > >

Re: [ovs-dev] [PATCH 2/7] datapath: Pass nf_hook_state to nf_conntrack_in

On Mon, May 6, 2019 at 2:58 PM Yifeng Sun wrote: > > From: Florian Westphal > > Upstream Commit: > commit 93e66024b0249cec81e91328c55a754efd3192e0 > Author: Florian Westphal > Date: Wed Sep 12 15:19:07 2018 +0200 > > netfilter: conntrack: pass nf_hook_state to packet and error

Re: [ovs-dev] [PATCH 1/7] datapath: Handle removal of nf_conntrack_l3proto.h

On Mon, May 6, 2019 at 2:57 PM Yifeng Sun wrote: > > Upstream kernel commit a0ae2562 ("netfilter: conntrack: remove l3proto > abstraction") removed header file net/netfilter/nf_conntrack_l3proto.h. > This patch detects it and fixes compilation errors of OVS on 4.19+ kernels. > > Signed-off-by:

Re: [ovs-dev] [PATCH 4/7] datapath: Fix conntrack_count related compilation errors

On 5/6/2019 2:56 PM, Yifeng Sun wrote: This patch fixes the compilation errors of OVS on 4.19+ kernels. Signed-off-by: Yifeng Sun --- datapath/linux/compat/include/net/netfilter/nf_conntrack_count.h | 4 ++-- datapath/linux/compat/nf_conncount.c | 6 +- 2

[ovs-dev] [patch v8] conntrack: Add rcu support.

For performance and code simplification reasons, add rcu support for conntrack. The array of hmaps is replaced by a cmap as part of this conversion. Using a single map also simplifies the handling of NAT and allows the removal of the nat_conn map and friends. Per connection entry locks are

Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files

Hi Numan, (also, CC'ing Mark) 0-day Robot writes: > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. I think it makes sense to use the

Re: [ovs-dev] [patch v7] conntrack: Add rcu support.

On Wed, May 8, 2019 at 10:56 AM Ben Pfaff wrote: > On Wed, May 08, 2019 at 12:14:56AM -0700, Darrell Ball wrote: > > On Tue, May 7, 2019 at 2:56 PM Ben Pfaff wrote: > > > I am not confident about destruction ordering here. It appears that > > > conntrack_destroy() frees 'ct'. I don't see

Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (TODO_SPLIT.rst). Repository lacks necessary blobs

Re: [ovs-dev] [patch v7] conntrack: Add rcu support.

On Wed, May 08, 2019 at 12:14:56AM -0700, Darrell Ball wrote: > On Tue, May 7, 2019 at 2:56 PM Ben Pfaff wrote: > > I am not confident about destruction ordering here. It appears that > > conntrack_destroy() frees 'ct'. I don't see anything that assures that > > a grace period has expired

Re: [ovs-dev] [PATCH] odp-util: extend usage of limit for parse functions

On Wed, May 08, 2019 at 09:22:54AM -0700, Toms Atteka wrote: > This fixes stack overflow issues for odp_actions_from_string. > As well moved depth check inside parse_odp_key_mask_attr to beginning. > Added some missing depth reductions. > > Basic manual testing was performed. > > Reported-by: >

Re: [ovs-dev] [PATCH] stopwatch: Free stopwatch packets after processing

On Wed, May 08, 2019 at 04:26:01PM +0200, Eelco Chaudron wrote: > > On 8 May 2019, at 14:56, Dumitru Ceara wrote: > > > The free(pkt) call was missing inside the stopwatch_thread processing > > loop. > > > > Signed-off-by: Dumitru Ceara > > --- > > lib/stopwatch.c | 1 + > > 1 file changed, 1

Re: [ovs-dev] [PATCH] OVN: convert buffered_mac_bindings to ovs_list

On Wed, May 08, 2019 at 03:41:48PM +0200, Lorenzo Bianconi wrote: > Convert buffered_mac_bindings from hashmap to a linked list since it is > used just for iteration (no lookups are performed on it) > > Signed-off-by: Lorenzo Bianconi I think this makes the code very slightly easier to

Re: [ovs-dev] [PATCHv7] netdev-afxdp: add new netdev type for AF_XDP.

Hi Ilya, Thanks for your review. I will fix them in my next version. On Mon, May 6, 2019 at 5:37 AM Ilya Maximets wrote: > > Hi. Thanks for a new version. > > Quick review inline. > > Best regards, Ilya Maximets. > > On 03.05.2019 22:02, William Tu wrote: > > The patch introduces experimental

Re: [ovs-dev] [PATCH] OVN: fix pinctrl ip buffering for gw router port

On Wed, May 08, 2019 at 02:59:32PM +0200, Lorenzo Bianconi wrote: > > On Tue, May 07, 2019 at 03:08:52PM +0200, Lorenzo Bianconi wrote: > > > Use sb mac binding table to trigger ip buffer dequeueing instead of > > > the APR/ND packet reception since the ARP reply can be managed on a > > >

Re: [ovs-dev] [PATCH] openvswitch: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)

From: Geert Uytterhoeven Date: Wed, 8 May 2019 08:52:32 +0200 > Commit 4806e975729f99c7 ("netfilter: replace NF_NAT_NEEDED with > IS_ENABLED(CONFIG_NF_NAT)") removed CONFIG_NF_NAT_NEEDED, but a new user > popped up afterwards. > > Fixes: fec9c271b8f1bde1 ("openvswitch: load and reference the

Re: [ovs-dev] OVS/OVN Split initial commits are complete

On Wed, May 8, 2019 at 1:03 AM Mark Michelson wrote: > On 5/7/19 1:42 PM, Numan Siddique wrote: > > > > > > On Sat, Apr 27, 2019 at 5:51 AM Justin Pettit > > wrote: > > > > > > > On Apr 26, 2019, at 2:50 PM, Mark Michelson > > wrote:

[ovs-dev] [PATCH] odp-util: extend usage of limit for parse functions

This fixes stack overflow issues for odp_actions_from_string. As well moved depth check inside parse_odp_key_mask_attr to beginning. Added some missing depth reductions. Basic manual testing was performed. Reported-by: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=13808 Signed-off-by:

Re: [ovs-dev] [PATCH v9 3/5] dpif-netdev: split out generic lookup function

Bleep bloop. Greetings Harry van Haaren, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #274 FILE: lib/dpif-netdev.h:102: #define

[ovs-dev] [PATCH v9 5/5] dpif-netdev: add specialized generic scalar functions

This commit adds a number of specialized functions, that handle common miniflow fingerprints. This enables compiler optimization, resulting in higher performance. Below a quick description of how this optimization actually works; "Specialized functions" are "instances" of the generic

[ovs-dev] [PATCH v9 4/5] dpif-netdev: refactor generic implementation

This commit refactors the generic implementation. The goal of this refactor is to simply the code to enable "specialization" of the functions at compile time. Given compile-time optimizations, the compiler is able to unroll loops, and create optimized code sequences due to compile time knowledge

[ovs-dev] [PATCH v9 3/5] dpif-netdev: split out generic lookup function

This commit splits the generic hash-lookup-verify function to its own file. In doing so, we must move some MACRO definitions to dpif-netdev.h Signed-off-by: Harry van Haaren --- v6: - Fixup some checkpatch warnings on whitespace with MACROs (Ilya) - Other MACROs function incorrectly when

[ovs-dev] [PATCH v9 2/5] dpif-netdev: move dpcls lookup structures to .h

This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c Signed-off-by: Harry van Haaren --- v6: - Fix double

[ovs-dev] [PATCH v9 0/5] dpcls func ptrs & optimizations

TL;DR: 1) As per v7, the function pointer rework for dpcls 2) Last 2 patches include specialized scalar optimizations v9: use count_1bits(), ALWAYS_INLINE, and rebased. v8: fixed variable-lenght array issues. Running with Eth/IPv4/UDP traffic should show performance improvements, with EMC/SMC

[ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren --- v9: - Use count_1bits in favour of __builtin_popcount (Ilya) v6: -

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

On Wed, May 08, 2019 at 11:41:16AM +0300, Ilya Maximets wrote: > > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > >> There are a few cases where structure copy can be replaced by > >> memcpy(), for possible portability benefit. This is because > >> the structures involved have

Re: [ovs-dev] [PATCH v8 4/5] dpif-netdev: refactor generic implementation

On 08.05.2019 17:44, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Wednesday, May 8, 2019 3:20 PM >> To: Van Haaren, Harry ; ovs-dev@openvswitch.org >> Cc: Stokes, Ian ; acon...@redhat.com; >> echau...@redhat.com >> Subject:

Re: [ovs-dev] [PATCH v8 4/5] dpif-netdev: refactor generic implementation

> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Wednesday, May 8, 2019 3:20 PM > To: Van Haaren, Harry ; ovs-dev@openvswitch.org > Cc: Stokes, Ian ; acon...@redhat.com; > echau...@redhat.com > Subject: Re: [PATCH v8 4/5] dpif-netdev: refactor generic

Re: [ovs-dev] [PATCH v8 2/5] dpif-netdev: move dpcls lookup structures to .h

> -Original Message- > From: Stokes, Ian > Sent: Wednesday, May 8, 2019 3:12 PM > To: Van Haaren, Harry ; ovs-dev@openvswitch.org > Cc: acon...@redhat.com; echau...@redhat.com; i.maxim...@samsung.com > Subject: Re: [PATCH v8 2/5] dpif-netdev: move dpcls lookup structures to .h > > On

Re: [ovs-dev] [PATCH] stopwatch: Free stopwatch packets after processing

On 8 May 2019, at 14:56, Dumitru Ceara wrote: > The free(pkt) call was missing inside the stopwatch_thread processing > loop. > > Signed-off-by: Dumitru Ceara > --- > lib/stopwatch.c | 1 + > 1 file changed, 1 insertion(+) > Change looks good to me… Acked-by: Eelco Chaudron

Re: [ovs-dev] [PATCH v8 4/5] dpif-netdev: refactor generic implementation

On 08.05.2019 13:22, Harry van Haaren wrote: > This commit refactors the generic implementation. The > goal of this refactor is to simply the code to enable > "specialization" of the functions at compile time. > > Given compile-time optimizations, the compiler is able > to unroll loops, and

Re: [ovs-dev] [PATCH v8 2/5] dpif-netdev: move dpcls lookup structures to .h

On 5/8/2019 11:22 AM, Harry van Haaren wrote: This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c Thanks

Re: [ovs-dev] [PATCH v8 4/5] dpif-netdev: refactor generic implementation

On 08.05.2019 13:22, Harry van Haaren wrote: > This commit refactors the generic implementation. The > goal of this refactor is to simply the code to enable > "specialization" of the functions at compile time. > > Given compile-time optimizations, the compiler is able > to unroll loops, and

[ovs-dev] [PATCH] netdev-dpdk: Post-copy Live Migration support for vhost-user-client.

From: Liliia Butorina Post-copy Live Migration for vHost supported since DPDK 18.11 and QEMU 2.12. New global config option 'vhost-postcopy-support' added to control this feature. Ex.: ovs-vsctl set Open_vSwitch . other_config:vhost-postcopy-support=true Changing this value requires

[ovs-dev] [PATCH] OVN: convert buffered_mac_bindings to ovs_list

Convert buffered_mac_bindings from hashmap to a linked list since it is used just for iteration (no lookups are performed on it) Signed-off-by: Lorenzo Bianconi --- ovn/controller/pinctrl.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git

Re: [ovs-dev] [PATCH 4/4] rhel: run ovn with the same user as ovs

Bleep bloop. Greetings Jaime Caamaño Ruiz, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 129 characters long (recommended limit is 79) #93 FILE:

Re: [ovs-dev] [PATCH 3/4] rhel: secure openvswitch useropts

Bleep bloop. Greetings Jaime Caamaño Ruiz, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 185 characters long (recommended limit is 79) #42 FILE:

Re: [ovs-dev] [PATCH] OVN: fix pinctrl ip buffering for gw router port

> On Tue, May 07, 2019 at 03:08:52PM +0200, Lorenzo Bianconi wrote: > > Use sb mac binding table to trigger ip buffer dequeueing instead of > > the APR/ND packet reception since the ARP reply can be managed on a > > different chassis if a gw router port is scheduled on a different > > node > > >

[ovs-dev] [PATCH] stopwatch: Free stopwatch packets after processing

The free(pkt) call was missing inside the stopwatch_thread processing loop. Signed-off-by: Dumitru Ceara --- lib/stopwatch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/stopwatch.c b/lib/stopwatch.c index 54a85ed..f560216 100644 --- a/lib/stopwatch.c +++ b/lib/stopwatch.c @@ -450,6

[ovs-dev] [PATCH 4/4] rhel: run ovn with the same user as ovs

Both ovn and ovs share the same log and run directories which are owned by the user running ovs so it makes sense that ovn runs under that user too to diminish security concerns and possible problems with log rotation. Signed-off-by: Jaime Caamaño Ruiz ---

[ovs-dev] [PATCH 3/4] rhel: secure openvswitch useropts

The openvswitch useropts file is being stored in a directory where the openvswitch user has write permissions. The openvswitch user can then manipulate the file to change the user under which switchd daemon runs. This patch changes the file to /var/openvswitch.useropts preventing any

[ovs-dev] [PATCH 2/4] rhel: start ovn-controller-vtep with ovn-ctl

Use ovn-ctl to start ovn-controller-vtep from the corresponding systemd unit file. Signed-off-by: Jaime Caamaño Ruiz --- ovn/utilities/ovn-ctl | 10 +- rhel/usr_lib_systemd_system_ovn-controller-vtep.service | 12 ++-- 2 files changed, 15

[ovs-dev] [PATCH 1/4] ovn-controller-vtep: Fix wrong value for ovnsb-db argument

Fix help output of ovn-controller-vtep that was suggesting the openvswitch database instead of the ovn southbound database for the ovnsb-db argument. Also fix the corresponding systemd unit that was passing the openvswitch database instead of the ovn southbound database for the ovnsb-db argument.

Re: [ovs-dev] [PATCH] openvswitch: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)

On Wed, May 08, 2019 at 08:52:32AM +0200, Geert Uytterhoeven wrote: > Commit 4806e975729f99c7 ("netfilter: replace NF_NAT_NEEDED with > IS_ENABLED(CONFIG_NF_NAT)") removed CONFIG_NF_NAT_NEEDED, but a new user > popped up afterwards. > > Fixes: fec9c271b8f1bde1 ("openvswitch: load and reference

Re: [ovs-dev] [PATCH v5 1/2] OVN: Enable E-W Traffic, Vlan backed DVR

On Wed, May 8, 2019 at 2:13 AM Ankur Sharma wrote: > Hi Numan, > > Thank you so much for trying out the patch. > Please find my replies inline regarding your test. > > For other comments in the code, i will be happy to make the change and v6 > will have it. > > Thanks > > Regards, > Ankur > > >

Re: [ovs-dev] [branch-2.9] conntrack: Fix clang warning.

Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (lib/conntrack.c). Repository lacks necessary blobs

Re: [ovs-dev] [branch-2.9] conntrack: Fix clang warning.

On 08.05.2019 12:51, Darrell Ball wrote: > Reported-by: Ilya Maximets > Fixes: 374fcb5249f1 ("conntrack: Fix race for NAT cleanup.") > Signed-off-by: Darrell Ball > --- > lib/conntrack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/conntrack.c b/lib/conntrack.c

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

On 08.05.2019 12:20, Darrell Ball wrote: > > > On Wed, May 8, 2019 at 1:41 AM Ilya Maximets > wrote: > > > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > >> There are a few cases where structure copy can be replaced by > >> memcpy(),

[ovs-dev] [PATCH v8 5/5] dpif-netdev: add specialized generic scalar functions

This commit adds a number of specialized functions, that handle common miniflow fingerprints. This enables compiler optimization, resulting in higher performance. Below a quick description of how this optimization actually works; "Specialized functions" are "instances" of the generic

[ovs-dev] [PATCH v8 4/5] dpif-netdev: refactor generic implementation

This commit refactors the generic implementation. The goal of this refactor is to simply the code to enable "specialization" of the functions at compile time. Given compile-time optimizations, the compiler is able to unroll loops, and create optimized code sequences due to compile time knowledge

[ovs-dev] [PATCH v8 3/5] dpif-netdev: split out generic lookup function

This commit splits the generic hash-lookup-verify function to its own file. In doing so, we must move some MACRO definitions to dpif-netdev.h Signed-off-by: Harry van Haaren --- v6: - Fixup some checkpatch warnings on whitespace with MACROs (Ilya) - Other MACROs function incorrectly when

[ovs-dev] [PATCH v8 2/5] dpif-netdev: move dpcls lookup structures to .h

This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c Signed-off-by: Harry van Haaren --- v6: - Fix double

[ovs-dev] [PATCH v8 1/5] dpif-netdev: implement function pointers/subtable

This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren --- v6: - Implement subtable effort per packet "lookups_match" counter

[ovs-dev] [PATCH v8 0/5] dpcls func ptrs & optimizations

TL;DR: 1) As per v7, the function pointer rework for dpcls 2) Last 2 patches include specialized scalar optimizations, v8 fixed variable-lenght array issues. Running with Eth/IPv4/UDP traffic should show performance improvements, with EMC/SMC disabled (so just DPCLS traffic), on a simple test

Re: [ovs-dev] [PATCH] openvswitch: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)

Geert Uytterhoeven wrote: > Commit 4806e975729f99c7 ("netfilter: replace NF_NAT_NEEDED with > IS_ENABLED(CONFIG_NF_NAT)") removed CONFIG_NF_NAT_NEEDED, but a new user > popped up afterwards. Thnaks for spotting this. Acked-by: Florian Westphal ___

Re: [ovs-dev] [branch-2.9] conntrack: Fix clang warning.

Ignore this patch; I resent the correct version Darrell On Wed, May 8, 2019 at 2:36 AM Darrell Ball wrote: > Fixes: 374fcb5249f1 ("conntrack: Fix race for NAT cleanup.") > Signed-off-by: Darrell Ball > --- > lib/conntrack.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

[ovs-dev] [branch-2.9] conntrack: Fix clang warning.

Reported-by: Ilya Maximets Fixes: 374fcb5249f1 ("conntrack: Fix race for NAT cleanup.") Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 0d71195..077bdca 100644 --- a/lib/conntrack.c +++

[ovs-dev] [branch-2.9] conntrack: Fix clang warning.

Fixes: 374fcb5249f1 ("conntrack: Fix race for NAT cleanup.") Signed-off-by: Darrell Ball --- lib/conntrack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 0d71195..fe393ba 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@

[ovs-dev] Installieren Sie ein Ortungssystem

track ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

On Wed, May 8, 2019 at 1:41 AM Ilya Maximets wrote: > > On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: > >> There are a few cases where structure copy can be replaced by > >> memcpy(), for possible portability benefit. This is because > >> the structures involved have padding and

Re: [ovs-dev] [branch-2.9 3/3] conntrack: Replace structure copy by memcpy().

> On Thu, May 02, 2019 at 05:29:16PM -0700, Darrell Ball wrote: >> There are a few cases where structure copy can be replaced by >> memcpy(), for possible portability benefit. This is because >> the structures involved have padding and elements of the >> structure are used to generate hashes. >>

Re: [ovs-dev] [RFC 4/5] dpif-netdev: Only reload static tx qid when needed.

Patch looks good to me, however need to fix the relaxed atomic operations. On 30 Apr 2019, at 14:18, David Marchand wrote: pmd->static_tx_qid is allocated under a mutex by the different pmd threads. Unconditionally reallocating it will make those pmd threads sleep when contention occurs.

Re: [ovs-dev] [RFC 5/5] dpif-netdev: Catch reloads faster.

On 30 Apr 2019, at 14:18, David Marchand wrote: Looking at the reload flag only every 1024 loops can be a long time under load, since we might be handling 32 packets per iteration, which means 32k packets. Look at the flag every loop, no major performance impact seen. Signed-off-by: David

[ovs-dev] [PATCH 2/2] ofproto-dpif-xlate: Add include mode to priority tags

Configure "include-non-zero" priority tags to keep the 802.1Q header when the VLAN ID is zero, except both the VLAN ID and priority are zero. Add a "include" configuration option to keep it for such frames as well. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan ---

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Change priority tags from boolean to enum

Priority tags is a port configuration to determine how the port treats priority tags, e.g. zero VLAN ID. Change the type from boolean to enum as a pre-step towards introducing additional modes. The new options are "omit", equivalent to previously "false", and "include-non-zero", equivalent to

[ovs-dev] [PATCH 0/2] Add include mode to priority tags port option

Setting priority-tags to "true" Open vSwitch still omits the 802.1Q header on output if both the VLAN ID and priority would be zero. Add an option to keep the 8021Q header for such frames as well. Patch #1: change boolean to enum as a pre-step to adding addition option Patch #2: add "include"

Re: [ovs-dev] [patch v7] conntrack: Add rcu support.

correction below for 'struct conn' inline comments On Wed, May 8, 2019 at 12:14 AM Darrell Ball wrote: > Thanks for the review > > On Tue, May 7, 2019 at 2:56 PM Ben Pfaff wrote: > >> On Mon, May 06, 2019 at 09:20:53AM -0700, Darrell Ball wrote: >> > For performance and code simplification

Re: [ovs-dev] [RFC 2/5] dpif-netdev: Trigger parallel pmd reloads.

On 7 May 2019, at 16:00, Ilya Maximets wrote: On 07.05.2019 16:46, Eelco Chaudron wrote: On 30 Apr 2019, at 14:17, David Marchand wrote: pmd reloads are currently serialised in each steps calling reload_affected_pmds. Any pmd processing packets, waiting on a mutex etc... will make other

Re: [ovs-dev] [patch v7] conntrack: Add rcu support.

Thanks for the review On Tue, May 7, 2019 at 2:56 PM Ben Pfaff wrote: > On Mon, May 06, 2019 at 09:20:53AM -0700, Darrell Ball wrote: > > For performance and code simplification reasons, add rcu support for > > conntrack. The array of hmaps is replaced by a cmap as part of this > > conversion.

[ovs-dev] [PATCH] openvswitch: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)

Commit 4806e975729f99c7 ("netfilter: replace NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)") removed CONFIG_NF_NAT_NEEDED, but a new user popped up afterwards. Fixes: fec9c271b8f1bde1 ("openvswitch: load and reference the NAT helper.") Signed-off-by: Geert Uytterhoeven ---