On 13 Mar 2023, at 9:38, Roi Dayan wrote:
> On 22/02/2023 12:30, Roi Dayan wrote:
>> Sometimes there is a need to clean empty chains as done in
>> delete_chains_from_netdev(). The cited commit doesn't remove
>> the chain completely which cause adding ingress_block later to fail.
>> This can be
On 10 Mar 2023, at 13:11, Eelco Chaudron wrote:
> On 1 Mar 2023, at 8:22, Chris Mi wrote:
>
>> This patch set adds offload support for sFlow.
>>
>> Psample is a genetlink channel for packet sampling. TC action act_sample
>> uses psample to send sampled pa
On 1 Mar 2023, at 8:22, Chris Mi wrote:
> This patch set adds offload support for sFlow.
>
> Psample is a genetlink channel for packet sampling. TC action act_sample
> uses psample to send sampled packets to userspace.
>
> When offloading sample action to TC, userspace creates a unique ID to
>
On 9 Mar 2023, at 15:42, Simon Horman wrote:
> On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wrote:
>> Run "make check-offloads" as part of the GitHub actions tests.
>>
>> This test was run 25 times using GitHub actions, and the
>> fa
Remove one of two consecutive time_msec() calls in the revalidate() function.
We take the time stamp after udpif_get_n_flows(), to avoid any potential
delays in getting the number of offloaded flows.
Signed-off-by: Eelco Chaudron
---
v2: Moved time_msec() after udpif_get_n_flows().
ofproto
ted runner.
Did not yet include sanitizers in the run, as it's causing
the test to run too long >30min and there seems to be (timing)
issues with some of the tests.
Signed-off-by: Eelco Chaudron
---
v2: Added a new test keyword to exclude the failing tests.
Added some documentation aroun
Combine the ASAN and UBSAN tests into a single sanitizer run.
Signed-off-by: Eelco Chaudron
---
v2: Introduction of this patch in the patch set.
v3: Moved Ubuntu test image upgrade to second patch.
.ci/linux-build.sh | 14 +-
.github/workflows/build
On 7 Mar 2023, at 18:01, Ilya Maximets wrote:
> On 2/28/23 16:52, Eelco Chaudron wrote:
>> Run "make check-offloads" as part of the GitHub actions tests.
>>
>> This test was run 25 times using GitHub actions, and the
>> failing rerun test cases where exclud
On 8 Mar 2023, at 13:53, Ilya Maximets wrote:
> On 3/8/23 13:23, Eelco Chaudron wrote:
>> Depending on the driver implementation, it can take from 0.2 seconds
>> up to 2 seconds before offloaded flow statistics are updated. This is
>> true for both TC and rte_
.
This fix will wait for at least 2 seconds, by default, before assuming no
packets where received during this period.
Reviewed-by: Simon Horman
Signed-off-by: Eelco Chaudron
---
Changes:
- v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is
also covered.
- v3: Ad
.
This fix will wait for at least 2 seconds, by default, before assuming no
packets where received during this period.
Reviewed-by: Simon Horman
Signed-off-by: Eelco Chaudron
---
Changes:
- v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is
also covered.
- v3: Ad
On 3 Mar 2023, at 22:20, Ilya Maximets wrote:
> On 2/27/23 15:58, Eelco Chaudron wrote:
>> Depending on the driver implementation, it can take from 0.2 seconds
>> up to 2 seconds before offloaded flow statistics are updated. This is
>> true for both TC and rte_
th success, id=0:
>> "recirc_id(0),in_port(4),eth(src=f6:2d:a8:f7:d2:f7,dst=aa:1a:54:e9:c5:56),eth_type(0x0800),ipv4(frag=no),
>> packe
> ts:1, bytes:84, used:0.040s, actions:2
>> "
>
> Tested,
> The first sleep can be removed with msg filters.
> The sleep bef
On 7 Mar 2023, at 16:32, Eelco Chaudron wrote:
> On 3 Mar 2023, at 16:15, Simon Horman wrote:
>
>> On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
>>> Run "make check-offloads" as part of the GitHub actions tests.
>>>
>>>
On 3 Mar 2023, at 16:15, Simon Horman wrote:
> On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote:
>> Run "make check-offloads" as part of the GitHub actions tests.
>>
>> This test was run 25 times using GitHub actions, and the
>> fa
+++-
> ofproto/ofproto-tnl-unixctl.man | 9 +-
> tests/ovs-router.at | 105 ++-
> tests/system-route.at | 39 +
> 8 files changed, 317 insertions(+), 73 deletions(-)
Thanks for this revision, it fixes
when caching routes from
> Kernel FIB with Netlink, but are not dealt with in this patch.
>
> Acked-by: Eelco Chaudron
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
> ---
> NEWS| 3 ++
> lib/ovs-router.c| 86 +++
ff-by: Nobuhiro MIKI
> ---
> lib/ovs-router.c| 6 +++---
> ofproto/ofproto-tnl-unixctl.man | 8
> tests/ovs-router.at | 2 +-
> 3 files changed, 8 insertions(+), 8 deletions(-)
Changes look good to me! Th
On 6 Mar 2023, at 9:19, Chris Mi wrote:
> On 3/1/2023 9:23 PM, Ilya Maximets wrote:
>> On 3/1/23 14:21, Ilya Maximets wrote:
>>> On 3/1/23 14:08, Chris Mi wrote:
On 3/1/2023 8:44 PM, Ilya Maximets wrote:
> On 2/28/23 14:05, Chris Mi wrote:
>> On 2/24/2023 4:16 AM, Ilya Maximets
On 2 Mar 2023, at 8:57, Faicker Mo wrote:
> The device may be deleted and added with ifindex changed.
> The tc rules on the device will be deleted if the device is deleted.
> The func tc_del_filter will fail when flow del. The mapping of
> ufid to tc will not be deleted.
> The traffic will
On 3 Mar 2023, at 11:45, Adrian Moreno wrote:
> On 3/3/23 11:33, Eelco Chaudron wrote:
>>
>>
>> On 27 Feb 2023, at 15:29, Ilya Maximets wrote:
>>
>>> On 2/24/23 11:41, Adrián Moreno wrote:
>>>> From: Adrian Moreno
>>>>
>>>&
On 27 Feb 2023, at 15:29, Ilya Maximets wrote:
> On 2/24/23 11:41, Adrián Moreno wrote:
>> From: Adrian Moreno
>>
>> This is basically a rewrite of the upcall_cost.py script moving some of
>> it's functionality to the ebpf programs. These are the main changes:
>>
>> * Correlation of kernel
ted with its own logic. This patch resolves the difference
> between kernel FIB and OVS route table cache by retrieving the
> RTA_PREFSRC attribute of Netlink messages.
>
> Acked-by: Eelco Chaudron
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
No changes, so jus
from
> Kernel FIB with Netlink, but are not dealt with in this patch.
>
> Acked-by: Eelco Chaudron
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
Small nit below, rest looks good.
> ---
> NEWS| 3 ++
> lib/ovs-router.c
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote:
> Fixed the manual page to indicate that both IPv4/IPv6
> are supported. Also added missing pkt_mark on one side
> and fixed the "gw" and "bridge" notation quirks.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
> ---
>
n is used. Also, pkt_mark and gw have separate prefix
> strings so they can be parsed in any order.
>
> Acked-by: Eelco Chaudron
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
Changes look good.
Acked-by: Eelco Chaudron
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote:
> This is useful in test cases where multiple IPv4/IPv6 addresses
> are assigned together.
>
> Acked-by: Eelco Chaudron
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
> ---
This patch still looks good with t
On 1 Mar 2023, at 11:40, Ilya Maximets wrote:
> On 3/1/23 08:19, Eelco Chaudron wrote:
>>
>>
>> On 28 Feb 2023, at 18:37, Ilya Maximets wrote:
>>
>>> On 2/22/23 11:29, Nobuhiro MIKI wrote:
>>>> With this series, the preferred source address in ovs
On 28 Feb 2023, at 17:23, Simon Horman wrote:
> On Tue, Feb 28, 2023 at 04:24:57PM +0100, Eelco Chaudron wrote:
>>
>>
>> On 16 Feb 2023, at 13:21, Eelco Chaudron wrote:
>>
>>> On 15 Feb 2023, at 21:15, Ilya Maximets wrote:
>>>
>>>> On 2
ted with its own logic. This patch resolves the difference
> between kernel FIB and OVS route table cache by retrieving the
> RTA_PREFSRC attribute of Netlink messages.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
The changes look
when caching routes from
> Kernel FIB with Netlink, but are not dealt with in this patch.
>
> Signed-off-by: Nobuhiro MIKI
Changes look good, two small nits below.
Acked-by: Eelco Chaudron
> ---
> NEWS| 3 ++
> lib/ovs-router.c| 83 +
On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote:
> These commands already support both IPv4 and IPv6.
>
> Signed-off-by: Nobuhiro MIKI
> ---
> ofproto/ofproto-tnl-unixctl.man | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ofproto/ofproto-tnl-unixctl.man
n is used. Also, pkt_mark and gw have separate prefix
> strings so they can be parsed in any order.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
Two small nits below, maybe Ilya can fold them in when applying?
The rest looks good to me.
Acked-by: Eelco Chaudron
> -
On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote:
> This is useful in test cases where multiple IPv4/IPv6 addresses
> are assigned together.
>
> Reviewed-by: Simon Horman
> Signed-off-by: Nobuhiro MIKI
With the suggested changes applied by Ilya this patch looks good to me.
ooks good to me! Did some testing and found no issues.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 28 Feb 2023, at 18:37, Ilya Maximets wrote:
> On 2/22/23 11:29, Nobuhiro MIKI wrote:
>> With this series, the preferred source address in ovs-router is obtained
>> from both ovs/route/add command and kernel FIB.
>>
>> v5:
>> - Add patch to fix man page
>> v4:
>> - Add cleanup patch for
ted runner.
Did not yet include sanitizers in the run, as it's causing
the test to run too long >30min and there seems to be (timing)
issues with some of the tests.
Signed-off-by: Eelco Chaudron
---
v2: Added a new test keyword to exclude the failing tests.
Added some documentation around the
Combine the ASAN and UBSAN tests into a single sanitizer run.
Signed-off-by: Eelco Chaudron
---
v2: Newly added
.ci/linux-build.sh | 14 +-
.github/workflows/build-and-test.yml | 10 +++---
2 files changed, 8 insertions(+), 16 deletions(-)
diff --git
On 16 Feb 2023, at 13:21, Eelco Chaudron wrote:
> On 15 Feb 2023, at 21:15, Ilya Maximets wrote:
>
>> On 2/14/23 14:54, Eelco Chaudron wrote:
>>> Run "make check-offloads" as part of the GitHub actions tests.
>>>
>>> This test was run 25 time
On 17 Feb 2023, at 16:02, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> On 2/14/23 14:54, Eelco Chaudron wrote:
>>> Run "make check-offloads" as part of the GitHub actions tests.
>>>
>>> This test was run 25 times using GitHub actions, an
. With rte_flow offload this is not a
problem as dpif netdev keeps both in sync.
This patch will include the hardware offloaded flows if the
underlying dpif implementation is not syncing them.
Signed-off-by: Eelco Chaudron
---
v3: Added this patch to patch set.
v4: No changes to this patch.
ofproto
.
Signed-off-by: Eelco Chaudron
---
v2: Updated commit message to explain behavior.
v3: Added a test case.
Added dpif API to query the dpif for datapath layers synchronization.
Added coverage counter to identify potential problem.
v4: Fixed some spelling, moved common code to a macro, and moved
On 21 Feb 2023, at 12:15, Simon Horman wrote:
Thanks for the review Simon, see responses inline. Will send out a v4 soon.
//Eelco
> On Fri, Feb 03, 2023 at 12:12:12PM +0100, Eelco Chaudron wrote:
>> When the ukey's action set changes, it could caus the flow to use a
>
> ni
.
This fix will wait for at least 2 seconds, by default, before assuming no
packets where received during this period.
Reviewed-by: Simon Horman
Signed-off-by: Eelco Chaudron
---
Changes:
- v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is
also covered.
- v3: Ad
On 21 Feb 2023, at 11:47, Simon Horman wrote:
> On Tue, Feb 14, 2023 at 02:39:25PM +0100, Eelco Chaudron wrote:
>> Depending on the driver implementation, it can take from 0.2 seconds
>> up to 2 seconds before offloaded flow statistics are updated. This is
>> true for both
On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote:
> With this series, the preferred source address in ovs-router is obtained
> from both ovs/route/add command and kernel FIB.
Hi Nobuhiro,
I was on PTO last week, will try to review it later this week, or early next
week.
//Eelco
> v5:
> -
get operation to
>> avoid rtnl_lock().")
>> Signed-off-by: Roi Dayan
>
> I think this needs an ack from Eelco (CCed).
>
> But it looks good to me.
>
> Reviewed-by: Simon Horman
The changes look good to me. Will it be worth adding a test case?
Acked-by: Eelco
On 23 Feb 2023, at 12:26, Chris Mi wrote:
> v2-v1:
> - Fix robot errors.
> v3-v2:
> - Remove Gerrit Change-Id.
> - Add patch #9 to fix older kernels build issue.
> - Add travis test result.
> v4-v3:
> - Fix offload issue when sampling rate is 1.
> v5-v4:
> - Move polling thread from ofproto to
On 16 Feb 2023, at 14:21, Ilya Maximets wrote:
> On 2/14/23 14:12, Eelco Chaudron wrote:
>> Remove one of two consecutive time_msec() calls in the revalidate() function.
>>
>> Signed-off-by: Eelco Chaudron
>> ---
>> ofproto/ofproto-dpif-upcall.c |2 +
On 16 Feb 2023, at 13:59, Ilya Maximets wrote:
> Signed-off-by: Ilya Maximets
The changes look good to me.
Acked-by: Eelco Chaudron
> ---
> NEWS | 2 +-
> debian/changelog | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
On 16 Feb 2023, at 13:59, Ilya Maximets wrote:
The changes look good to me.
Acked-by: Eelco Chaudron
> Signed-off-by: Ilya Maximets
> ---
> NEWS | 3 +++
> configure.ac | 2 +-
> debian/changelog | 6 ++
> 3 files changed, 10 insertions(+), 1 deletion
On 15 Feb 2023, at 21:15, Ilya Maximets wrote:
> On 2/14/23 14:54, Eelco Chaudron wrote:
>> Run "make check-offloads" as part of the GitHub actions tests.
>>
>> This test was run 25 times using GitHub actions, and the
>> failing rerun test cases where exclud
On 15 Feb 2023, at 21:04, Ilya Maximets wrote:
> On 1/11/23 19:36, Michael Santana wrote:
>>
>>
>> On 1/5/23 08:56, Eelco Chaudron wrote:
>>> Instead of using all zero stats when executing a revalidate for missed
>>> dp flows, use the last known s
ted runner.
Signed-off-by: Eelco Chaudron
---
.ci/linux-build.sh |6 +-
.github/workflows/build-and-test.yml |8 +++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 10021fddb..cafff4d83 100755
--- a
Remove the "offloads - simulated flow action update" test case, as
it's covered by the "datapath - simulated flow action update" test.
Fixes: b1f58f5072d6 ("netdev-offload-tc: Preserve tc statistics when flow gets
modified.")
Signed-off-by: Eelco Chaudron
---
te
.
This fix will wait for at least 2 seconds, by default, before assuming no
packets where received during this period.
Signed-off-by: Eelco Chaudron
Changes:
- v2: Use existing ukey->offloaded so the revalidate_missed_dp_flow case is
also covered.
- v3: Added OVS_REQUIRES(ukey->
Remove one of two consecutive time_msec() calls in the revalidate() function.
Signed-off-by: Eelco Chaudron
---
ofproto/ofproto-dpif-upcall.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index db7570ee2
eft as default.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-January/401501.html
> Signed-off-by: Vladislav Odintsov
Thanks for fixing this! The changes look good to me.
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ext week.
//Eelco
>> On 10 Feb 2023, at 11:21, Eelco Chaudron wrote:
>>
>>
>>
>> On 8 Feb 2023, at 16:22, Vladislav Odintsov wrote:
>>
>>> This patch adds new ovs-ctl options to pass umask configuration to allow
>>> OVS daemons set requested soc
On 7 Feb 2023, at 7:48, Nobuhiro MIKI wrote:
> We can use the "ip route add ... src ..." command to set the preferred
> source address for each entry in the kernel FIB. OVS has a mechanism to
> cache the FIB, but the preferred source address is ignored and
> calculated with its own logic. This
On 7 Feb 2023, at 7:48, Nobuhiro MIKI wrote:
> When adding a route with ovs/route/add command, the source address
> in "ovs_router_entry" structure is always the FIRST address that the
> interface has. See "ovs_router_get_netdev_source_address"
> function for more information.
>
> If an
On 8 Feb 2023, at 16:22, Vladislav Odintsov wrote:
> This patch adds new ovs-ctl options to pass umask configuration to allow
> OVS daemons set requested socket permissions on group. Previous
> behaviour (if using with systemd service unit) created sockets with 0750
> permissions mask (group
a
Thanks for doing a v3. The change looks good to me!
Acked-by: Eelco Chaudron
> ---
>
> v2: use goto label and free old_meter outside of ovs lock.
>
> v3: add the label and keep the lock in place.
>
> net/openvswitch/meter.c | 4 +++-
> 1 file changed, 3 insertions(+
On 9 Feb 2023, at 10:41, Gaetan Rivet wrote:
>> -Original Message-
>> From: dev > <mailto:ovs-dev-boun...@openvswitch.org>> on behalf of Eelco Chaudron
>> mailto:echau...@redhat.com>>
>> Date: Monday 23 January 2023 at 10:44
>> To: Gae
On 9 Feb 2023, at 11:58, Simon Horman wrote:
> On Thu, Feb 09, 2023 at 05:32:40PM +0800, Hangyu Hua wrote:
>> old_meter needs to be free after it is detached regardless of whether
>> the new meter is successfully attached.
>>
>> Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters
On 9 Feb 2023, at 13:45, Ilya Maximets wrote:
> On 2/7/23 15:03, Eelco Chaudron wrote:
>> This series makes it possible to include system-traffic.at tests into
>> "make check-offloads" tests.
>>
>> The last patch of the series explains which tests are sti
On 8 Feb 2023, at 17:50, Simon Horman wrote:
> On Tue, Feb 07, 2023 at 03:07:24PM +0100, Eelco Chaudron wrote:
>> With some datapaths, read TC, it takes a bit longer to update the
>> OpenFlow statistics. Rather than adding an additional delay, try
>> to read the counters mu
On 8 Feb 2023, at 8:16, Hangyu Hua wrote:
> old_meter needs to be free after it is detached regardless of whether
> the new meter is successfully attached.
>
> Fixes: c7c4c44c9a95 ("net: openvswitch: expand the meters supported number")
> Signed-off-by: Hangyu Hua
> ---
>
On 8 Feb 2023, at 17:32, Simon Horman wrote:
> On Tue, Feb 07, 2023 at 03:03:57PM +0100, Eelco Chaudron wrote:
>> Include and run the system-traffic.at tests as part of the system offload
>> testsuite. Exclude all the tests that will not run without any special
>> modific
On 7 Feb 2023, at 16:04, Vladislav Odintsov wrote:
> Thanks for the review, Eelco!
> Answers are inline.
>
>> On 7 Feb 2023, at 17:02, Eelco Chaudron wrote:
>>
>> See some comments inline below.
>>
>> Cheers,
>>
>> Eelco
>&
With some datapaths, read TC, it takes a bit longer to update the
OpenFlow statistics. Rather than adding an additional delay, try
to read the counters multiple times until we get the desired value.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-traffic.at | 18
tunnel by simulated packets
These tests where executed on a Fedora37 machine with the kernel
6.1.5-200.fc37.x86_64 installed.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads-testsuite-macros.at | 21 +
tests/system-traffic.at |2
ctions")
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/tc.c| 14 +-
tests/system-traffic.at |1 -
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/tc.c b/lib/tc.c
index 1fb2b4a92..4c07e2216 100644
--- a/lib/tc.c
+++ b/lib/tc.c
Make the order of the Netlink attributes for odp_flow_key_from_flow__()
the same as the kernel will return them.
This will make sure the attributes displayed in the dpctl/dump-flows
output appear in the same order for all datapath.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/odp
The tc conntrack implementation does not support the timeout option.
The current implementation is silently ignoring the timeout option
by adding a general conntrack entry.
This patch will skip the related test by overriding the support macro.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
tc does not include ethernet header length in packet byte count.
This fix will allow the packets that go trough tc to be 14 bytes less.
This difference in the TC implementation is already described in
tc-offload.rst.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system
, and it will not invoke the ALG helper.
Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support")
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
Documentation/howto/tc-offload.rst| 11 +++
lib/netdev-offload-tc.c |4
tests/system-offloads
Flush datapath flows as TC flows take some more time to be flushed out.
The flush speeds this up.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-traffic.at |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/system-traffic.at b/tests/system
tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced
commit was requested. This patch will fix this.
Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack support")
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/netdev-offload-tc.c | 13 +++
TC flower does not allow the push of the implicit null labels (RFC3032).
Avoid the use of such labels in the MPLS test cases.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-traffic.at | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests
rror level message, but
should be debug, like all other, EOPNOTSUPP, related log messages.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/netdev-offload-tc.c |2 +-
tests/automake.mk |3 ++
tests/system-kmod-macros.at
based to the latest ovs master branch
- Added Roi's ACKs
Eelco Chaudron (11):
tests: Include working system-traffic tests into the
system-offloads-testsuite.
test: Do not use MPLS implicit null label in test cases.
netdev-offload-tc: Fix tc conntrack force commit support.
See some comments inline below.
Cheers,
Eelco
On 27 Jan 2023, at 14:29, Vladislav Odintsov wrote:
> This patch adds a new ovs-ctl option to pass umask configuration to allow
> OVS daemons to set requested socket permissions on group. Previous
> behaviour (if using with systemd service unit)
On 4 Feb 2023, at 9:11, Simon Horman wrote:
> On Fri, Feb 03, 2023 at 08:36:12PM +0100, Ilya Maximets wrote:
>> On 2/3/23 17:48, Simon Horman wrote:
>>> On Thu, Feb 02, 2023 at 12:09:47PM +0100, Eelco Chaudron wrote:
>>>> Include and run the system-traffic.
On 6 Feb 2023, at 8:48, Tianyu Yuan wrote:
> On Fri 2/3/2023 8:35 PM, Eelco Chaudron wrote:
>>
>> On 30 Jan 2023, at 17:42, Simon Horman wrote:
>>
>>> From: Tianyu Yuan
>>>
>>> Allow revalidator to continuously delete police in kernel tc data
riter.
>
> APIs like cpumask_next and cpumask_set_cpu never access bits
> beyond cpu count, cpumask_size() bytes of memory is enough.
>
> Signed-off-by: Eddy Tao
The changes look good to me. Hopefully this is the last revision ;)
Acked-by: Eelco Chaudron
___
On 30 Jan 2023, at 17:42, Simon Horman wrote:
> From: Tianyu Yuan
>
> Allow revalidator to continuously delete police in kernel
> tc datapath until it is deleted.
>
> In current implementation, polices in tc datapath will not
> deleted when they are being used and these remaining polices
>
yond cpu count, cpumask_size() bytes of memory is enough
>
> Signed-off-by: Eddy Tao
Hi Eddy,
Thanks for this patch, I have one small nit, but the rest looks good.
Acked-by: Eelco Chaudron
> ---
> net/openvswitch/flow.c | 9 ++---
> net/openvswitch/flow.h | 2 +
. With rte_flow offload this is not a
problem as dpif netdev keeps both in sync.
This patch will include the hardware offloaded flows if the
underlying dpif implementation is not syncing them.
Signed-off-by: Eelco Chaudron
---
v3: Added this patch to patch set.
ofproto/ofproto-dpif-upcall.c | 11
.
Signed-off-by: Eelco Chaudron
---
v2: Updated commit message to explain behavior.
v3: Added a test case.
Added dpif API to query the dpif for datapath layers synchronization.
Added coverage counter to identify potential problem.
lib/dpif-netdev.c|7
lib/dpif
already
>
> Is there any known issue regarding to the netdev/checkpatch?
Not sure which netdev/checkpatch you are referring to. I always you the general
kernel one in /script/checkpatch.pl.
Your patch looks good to me with /script/checkpatch.pl --strict.
> Best regards
>
> eddy
>
er of bytes decided by
> nr_cpu_ids(running CPUs)
>
> I will remove this statement after solving a final style issue in the next
> submission.
Thanks!
> Thanks
> eddy
>
> 发件人: Eelco Chaudron
> 发送时间: 2023年2月2日 11:05
> 收件
On 2 Feb 2023, at 12:39, Simon Horman wrote:
> On Thu, Feb 02, 2023 at 12:09:37PM +0100, Eelco Chaudron wrote:
>> This series makes it possible to include system-traffic.at tests into
>> "make check-offloads" tests.
>>
>> The last patch of the series expla
Make the order of the Netlink attributes for odp_flow_key_from_flow__()
the same as the kernel will return them.
This will make sure the attributes displayed in the dpctl/dump-flows
output appear in the same order for all datapath.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/odp
tunnel by simulated packets
These tests where executed on a Fedora37 machine with the kernel
6.1.5-200.fc37.x86_64 installed.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-offloads-testsuite-macros.at | 21 +
tests/system-traffic.at |2
With some datapaths, read TC, it takes a bit longer to update the
OpenFlow statistics. Rather than adding an additional delay, try
to read the counters multiple times until we get the desired value.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-traffic.at | 18
ctions")
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
lib/tc.c| 14 +-
tests/system-traffic.at |1 -
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/tc.c b/lib/tc.c
index 1fb2b4a92..4c07e2216 100644
--- a/lib/tc.c
+++ b/lib/tc.c
tc does not include ethernet header length in packet byte count.
This fix will allow the packets that go trough tc to be 14 bytes less.
This difference in the TC implementation is already described in
tc-offload.rst.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system
The tc conntrack implementation does not support the timeout option.
The current implementation is silently ignoring the timeout option
by adding a general conntrack entry.
This patch will skip the related test by overriding the support macro.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
Flush datapath flows as TC flows take some more time to be flushed out.
The flush speeds this up.
Signed-off-by: Eelco Chaudron
Acked-by: Roi Dayan
---
tests/system-traffic.at |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/system-traffic.at b/tests/system
801 - 900 of 2699 matches
Mail list logo
