[ovs-dev] [PATCH 04/15] datapath: Optimize operations for OvS flow_stats.

y: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 7 --- datapath/flow.h | 2 ++ datapath/flow_table.c | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c

[ovs-dev] [PATCH 05/15] datapath: Remove unnecessary newlines from OVS_NLERR uses

lines to the logging. Signed-off-by: Joe Perches <j...@perches.com> Acked-by: Joe Stringer <j...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c| 14 +- datapath/f

[ovs-dev] [PATCH 09/15] acinclude: Check for extended netlink ack presence

RTNL ops validate and newlink now include the extended netlink ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS if found. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4

[ovs-dev] [PATCH 08/15] compat: Add check for DST_NOCACHE

DST_NOCACHE was removed from the Linux 4.13 kernel. Check if HAVE_DST_NOCACHE is defined for older kernels. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/net/ip6_fib.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath

[ovs-dev] [PATCH 13/15] acinclude: Add support for Linux 4.13

Add configuration support for the just released 4.13 Linux kernel. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 46efa69..cb5f3ae 100644 --- a/acinclude.m4

Re: [ovs-dev] [PATCH 09/15] acinclude: Check for extended netlink ack presence

On 09/11/2017 10:56 AM, Greg Rose wrote: RTNL ops validate and newlink now include the extended netlink ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS if found. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 6 ++ 1 file changed, 6 insertions(+)

[ovs-dev] [PATCH 03/15] datapath: Optimize updating for OvS flow_stats.

.@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 599b4e5..30e4d21 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -71,7 +71,6 @@ void ovs_

[ovs-dev] [PATCH 02/15] datapath: Remove all references to SKB_GSO_UDP.

er <da...@davemloft.net> SKB_GSO_UDP is removed in the upstream kernel. Use HAVE_SKB_GSO_UDP define from acinclude to detect if SKB_GSO_UDP exists and if so apply openvswitch section of this upstream patch. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 6 ++

[ovs-dev] [PATCH 10/15] datapath: Fixup RTNL ops for kernel 4.13

nce they are no longer supported since 2.5.x. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/lisp.c | 21 ++--- datapath/linux/compat/stt.c | 11 +++ 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/datapath/linux/compat/lisp.c b/datap

[ovs-dev] [PATCH 15/15] travis: Update build kernel list

Linux kernel 4.13 has been released. Update the kernel build list to the current list of kernels from kernel.org. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml

[ovs-dev] [PATCH 14/15] Documentation: Update NEWS and FAQ.

Document Open vSwitch Linux kernel support for the 4.13 kernel release. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- Documentation/faq/releases.rst | 2 +- NEWS | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/releases

Re: [ovs-dev] [PATCH V2 1/6] acinclude: Check for SKB_GSO_UDP

On 08/24/2017 08:10 AM, Greg Rose wrote: Removed in kernel 4.13 Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 74cc046..9bd1c49 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@

Re: [ovs-dev] [PATCH] FAQ: Indicate OVS 2.8 supports up to Linux 4.12.

On 09/07/2017 01:09 PM, Justin Pettit wrote: On Sep 7, 2017, at 10:14 AM, Ben Pfaff wrote: On Tue, Sep 05, 2017 at 10:22:47AM -0700, Justin Pettit wrote: Signed-off-by: Justin Pettit Acked-by: Ben Pfaff Thanks. I pushed this to master and

Re: [ovs-dev] [PATCH] FAQ: Indicate OVS 2.8 supports up to Linux 4.12.

On 09/07/2017 03:47 PM, Justin Pettit wrote: On Sep 7, 2017, at 3:45 PM, Greg Rose <gvrose8...@gmail.com> wrote: On 09/07/2017 03:44 PM, Justin Pettit wrote: On Sep 7, 2017, at 3:42 PM, Greg Rose <gvrose8...@gmail.com> wrote: On 09/07/2017 01:09 PM, Justin Pettit wrote: On

Re: [ovs-dev] [PATCH] FAQ: Indicate OVS 2.8 supports up to Linux 4.12.

On 09/07/2017 03:49 PM, Justin Pettit wrote: On Sep 7, 2017, at 3:48 PM, Greg Rose <gvrose8...@gmail.com> wrote: On 09/07/2017 03:47 PM, Justin Pettit wrote: On Sep 7, 2017, at 3:45 PM, Greg Rose <gvrose8...@gmail.com> wrote: On 09/07/2017 03:44 PM, Justin Pettit wrote: On

Re: [ovs-dev] [PATCH] FAQ: Indicate OVS 2.8 supports up to Linux 4.12.

On 09/07/2017 03:44 PM, Justin Pettit wrote: On Sep 7, 2017, at 3:42 PM, Greg Rose <gvrose8...@gmail.com> wrote: On 09/07/2017 01:09 PM, Justin Pettit wrote: On Sep 7, 2017, at 10:14 AM, Ben Pfaff <b...@ovn.org> wrote: On Tue, Sep 05, 2017 at 10:22:47AM -0700, Justin Pettit wr

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

o some other work and will get back to this afterwards. I'll just need to debug the connection issue to the collector. Thanks, - Greg -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Greg Rose Sent: Saturday, August 19, 2

Re: [ovs-dev] [PATCH 0/2] fix odp parsing of set masked action

On 09/03/2017 10:19 PM, Roi Dayan wrote: On 29/08/2017 07:30, Roi Dayan wrote: Hi, The first commit is a fix for parsing set masked action and the second commit is adding a test. Before the fix the addtion of the tests fails with the following: # make check TESTSUITEFLAGS=436 #

Re: [ovs-dev] [PATCH] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()'

On 09/11/2017 12:20 PM, Christophe JAILLET wrote: All other error handling paths in this function go through the 'error' label. This one should do the same. Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Christophe JAILLET

Re: [ovs-dev] [PATCH] put bundle_lookup ahead to simplify the code

; ovs_assert((s->lacp != NULL) == (s->lacp_slaves != NULL)); -bundle = bundle_lookup(ofproto, aux); if (!bundle) { bundle = xmalloc(sizeof *bundle); Makes sense... Reviewed-by: Greg Rose <gvrose8...@gmail.com>

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

- From: Greg Rose [mailto:gvrose8...@gmail.com] Sent: Tuesday, August 29, 2017 5:15 PM To: Weglicki, MichalX <michalx.wegli...@intel.com> Cc: d...@openvswitch.org; Szczerbik, PrzemyslawX <przemyslawx.szczer...@intel.com> Subject: Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: a

[ovs-dev] [PATCH V2 01/16] acinclude: Check for SKB_GSO_UDP

Removed in kernel 4.13 Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index aeb594a..0e98ade 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -767,6 +767,9 @@ AC_DEFUN([OVS_CHECK_LINUX_

[ovs-dev] [PATCH V2 02/16] datapath: Remove all references to SKB_GSO_UDP.

er <da...@davemloft.net> SKB_GSO_UDP is removed in the upstream kernel. Use HAVE_SKB_GSO_UDP define from acinclude to detect if SKB_GSO_UDP exists and if so apply openvswitch section of this upstream patch. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 6 ++

[ovs-dev] [PATCH V2 03/16] datapath: Optimize updating for OvS flow_stats.

.@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 599b4e5..30e4d21 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -71,7 +71,6 @@ void ovs_

[ovs-dev] [PATCH V2 04/16] datapath: Optimize operations for OvS flow_stats.

y: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 7 --- datapath/flow.h | 2 ++ datapath/flow_table.c | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c

[ovs-dev] [PATCH V2 06/16] datapath: fix skb_panic due to the incorrect actions attrlen

davemloft.net> Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet upcall to userspace.") Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/actions.c | 1 + datapath/datapath.c | 7 --- datapath/datapath.h | 2 ++ 3 files changed,

[ovs-dev] [PATCH V2 05/16] datapath: Remove unnecessary newlines from OVS_NLERR uses

lines to the logging. Signed-off-by: Joe Perches <j...@perches.com> Acked-by: Joe Stringer <j...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c| 14 +- datapath/f

[ovs-dev] [PATCH V2 08/16] compat: Add check for DST_NOCACHE

DST_NOCACHE was removed from the Linux 4.13 kernel. Check if HAVE_DST_NOCACHE is defined for older kernels. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/include/net/ip6_fib.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/datapath

[ovs-dev] [PATCH V2 07/16] acinclude: Add compat define for DST_NOCACHE

DST_NOCACHE is removed in the 4.13 Linux kernel - add check for it and if found set HAVE_DST_NOCACHE. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 0e98ade..772ff03

[ovs-dev] [PATCH V2 10/16] datapath: Fixup RTNL ops for kernel 4.13

nce they are no longer supported since 2.5.x. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/lisp.c | 21 ++--- datapath/linux/compat/stt.c | 11 +++ 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/datapath/linux/compat/lisp.c b/datap

[ovs-dev] [PATCH V2 09/16] acinclude: Check for extended netlink ack presence

RTNL ops validate and newlink now include the extended netlink ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS if found. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4

[ovs-dev] [PATCH V2 11/16] acinclude: Check for existence of nf_hook_ops member "list".

The "list" member of the nf_hook_ops structure is removed in Linux kernel release 4.13. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 577437f..46efa69 100644 --- a/ac

[ovs-dev] [PATCH V2 12/16] datapath: Check for existence of nf_hook_ops member list

The list member of nf_hook_ops has been removed in Linux kernel release 4.13. Check for the definition of it in pre-4.13 kernels. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/stt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/linux/compat/s

[ovs-dev] [PATCH V2 13/16] datapath: Fix up vxlan device flags

Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/vport-vxlan.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c index 2910694..c7139ab 100644 --- a/datapath/vport-vxlan.c +++ b/datapath/vport-vxla

[ovs-dev] [PATCH V2 15/16] Documentation: Update NEWS and FAQ.

Document Open vSwitch Linux kernel support for the 4.13 kernel release. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- Documentation/faq/releases.rst | 2 +- NEWS | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/releases

[ovs-dev] [PATCH V2 14/16] acinclude: Add support for Linux 4.13

Add configuration support for the just released 4.13 Linux kernel. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 46efa69..cb5f3ae 100644 --- a/acinclude.m4

[ovs-dev] [PATCH V2 16/16] travis: Update build kernel list

Linux kernel 4.13 has been released. Update the kernel build list to the current list of kernels from kernel.org. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml

Re: [ovs-dev] [PATCH v4 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

On 09/26/2017 04:53 AM, Michal Weglicki wrote: Extend flow key part of data record to include following Information Elements: - ingressInterface - ingressInterfaceType - egressInterface - egressInterfaceType - interfaceName - interfaceDescription Michal, I'm testing this patch and so far it

[ovs-dev] [PATCH 3/5] datapath: Optimize operations for OvS flow_stats.

y: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 7 --- datapath/flow.h | 2 ++ datapath/flow_table.c | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c

[ovs-dev] [PATCH V2 3/6] datapath: Optimize updating for OvS flow_stats.

.@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 599b4e5..30e4d21 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -71,7 +71,6 @@ void ovs_

[ovs-dev] [PATCH V2 4/6] datapath: Optimize operations for OvS flow_stats.

y: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 7 --- datapath/flow.h | 2 ++ datapath/flow_table.c | 4 +++- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c

[ovs-dev] [PATCH V2 2/6] datapath: Remove all references to SKB_GSO_UDP.

er <da...@davemloft.net> SKB_GSO_UDP is removed in the upstream kernel. Use HAVE_SKB_GSO_UDP define from acinclude to detect if SKB_GSO_UDP exists and if so apply openvswitch section of this upstream patch. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 6 ++

[ovs-dev] [PATCH V2 1/6] acinclude: Check for SKB_GSO_UDP

Removed in kernel 4.13 Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 74cc046..9bd1c49 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -763,6 +763,9 @@ AC_DEFUN([OVS_CHECK_LINUX_

[ovs-dev] [PATCH V2 5/6] datapath: Remove unnecessary newlines from OVS_NLERR uses

lines to the logging. Signed-off-by: Joe Perches <j...@perches.com> Acked-by: Joe Stringer <j...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c| 14 +- datapath/f

[ovs-dev] [PATCH V2 6/6] datapath: fix skb_panic due to the incorrect actions attrlen

davemloft.net> Fixes: 0e469d3b380c ("datapath: Include datapath actions with sampled-packet upcall to userspace.") Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/actions.c | 1 + datapath/datapath.c | 7 --- datapath/datapath.h | 2 ++ 3 files changed,

Re: [ovs-dev] [PATCH 2/5] datapath: Optimize updating for OvS flow_stats.

On 08/23/2017 04:24 PM, Joe Stringer wrote: On 23 August 2017 at 11:21, Greg Rose <gvrose8...@gmail.com> wrote: > Upstream commit: > commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952 > Author: Tonghao Zhang <xiangxia.m@gmail.com> > Date: Mon Ju

Re: [ovs-dev] [PATCH 1/5] datapath: Remove all references to SKB_GSO_UDP.

On 08/23/2017 04:21 PM, Joe Stringer wrote: On 23 August 2017 at 11:21, Greg Rose <gvrose8...@gmail.com> wrote: > Upstream commit: > commit 880388aa3c07fdea4f9b85e35641753017b1852f > Author: David S. Miller <da...@davemloft.net> > Date: Mon Jul 3 07:29:12

Re: [ovs-dev] [PATCH 3/9] ct-dpif: Add ct_dpif_get_info()

int (*ct_get_info)(struct dpif *, struct ct_dpif_tuple *tuple, + const uint16_t zone, struct ct_dpif_info *info); + /* Meters */ /* Queries 'dpif' for supported meter features. Seems fine to me. Reviewed-by: Greg Rose <gvrose8...@gmail.com> __

Re: [ovs-dev] [PATCH 5/9] dpif-netlink: Implement ct_get_info

On 08/25/2017 03:51 PM, Yi-Hung Wei wrote: This patch implements ct_get_info() in dpif-netlink. It uses NFNL_SUBSYS_CTNETLINK netlink subsystem to query conntrack info from kernel datapath. Then, ofproto/trace can use the ct_get_info() to derive the ct_state of the traced flow. System traffic

Re: [ovs-dev] [PATCH 6/9] netlink-conntrack: Add support for querying conntrack exp

On 08/25/2017 03:51 PM, Yi-Hung Wei wrote: The ct_state of an uncommmited new flow is marked as related if the flow is in the conntrack expectation table. In order for ofproto/trace to identify the ct_state of a new related flow, this patch utilizes NFNL_SUBSYS_CTNETLINK_EXP netlink subsystem to

Re: [ovs-dev] [PATCH 7/9] flow: Refactor parse_ct_state()

+if (!parse_ct_state(state_s_, CS_TRACKED, ", ", , )) { ovs_fatal(0, "%s", ds_cstr()); } if (!validate_ct_state(state, )) { Other than my comment above this patch looks fine. Reviewed-by: Greg Rose <gvrose8...@gmail.com> ___

Re: [ovs-dev] [PATCH 8/9] ofproto/trace: Change delimiter of ct_state in --ct-next

'trk,est' ], [0], [stdout]) +AT_CHECK([ovs-appctl ofproto/trace br0 'in_port=1,tcp' --ct-next 'trk|est' --ct-next 'trk|est' ], [0], [stdout]) AT_CHECK([tail -1 stdout], [0], [Datapath actions: 3 ]) LGTM. Reviewed-by: Greg Rose <gvrose8...@gmail.com> __

Re: [ovs-dev] [PATCH 9/9] ofproto/trace: Support ct_mark and ct_label in --ct-next

On 08/25/2017 03:51 PM, Yi-Hung Wei wrote: Previously, --ct-next option in ofproto/trace only supports specifying ct_state. This patch adds support of ct_mark and ct_label. Signed-off-by: Yi-Hung Wei --- lib/ct-dpif.c| 7 lib/ct-dpif.h

Re: [ovs-dev] [PATCH] dpif: Remove duplicated word in comment for dpif_recv()

a' point into data in the caller-provided * 'buf', so their memory cannot be freed separately from 'buf'. LGTM Reviewed-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 0/9] ofproto/trace: Support querying ct info from kernel DP

e8b91cf36769 " Merge branch 'dpdk_merge' of https://github.com/darball/ovs.; passes a travis build check. Tested-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/9] ofproto/trace: Fix memory leak in oftrace_push_ct_state()

struct ds s = DS_EMPTY_INITIALIZER; format_flags(, ct_state_to_string, ct_state, '|'); ds_put_format(output, " - resume conntrack with ct_state=%s", Besides the minor nit above it LGTM. Reviewed-by: Greg Rose <gvrose8...@gmail.com> _

Re: [ovs-dev] [PATCH 2/9] ofproto/trace: Propagate ct_zone in recirculation

ggestion perhaps you might create a helper struct to contain all the parameters and just pass a pointer. Personally I start looking for ways to cut down on parameter passing when a function gets to 4 or more parameters. Again - just a personal predilection. Otherwise the patch LGTM. Review

Re: [ovs-dev] [PATCH 4/9] ofproto/trace: Query ct_state for conntrack recirc from DP

On 08/25/2017 03:51 PM, Yi-Hung Wei wrote: Instead of using fixed default conntrack state 'trk|new' in ofproto/trace for conntrack recirculation, this patch queries the conntrack state from datapath using ct_dpif_get_info(). Signed-off-by: Yi-Hung Wei --- lib/ct-dpif.c

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

and will get back to this afterwards. I'll just need to debug the connection issue to the collector. Thanks, - Greg > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Greg Rose > Sent: Saturday, August 19, 2017

Re: [ovs-dev] [PATCH] timeval: Fix misleading function descriptions.

On 08/28/2017 12:08 AM, Ilya Maximets wrote: TIME_UPDATE_INTERVAL was removed long time ago. Now each call leads to time update via syscall and it's granularity is system dependent. Fixes: 31ef9f5178de ("timeval: Remove CACHE_TIME scheme.") Signed-off-by: Ilya Maximets

[ovs-dev] [PATCH] include/openvswitch/utils.h:

Fix macro for case where build is done with NDEBUG Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- include/openvswitch/util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h index abebf96..72299e7

Re: [ovs-dev] [PATCH] include/openvswitch/utils.h:

On 10/09/2017 04:34 PM, Ben Pfaff wrote: On Mon, Oct 09, 2017 at 03:59:37PM -0700, Greg Rose wrote: > Fix macro for case where build is done with NDEBUG > > Signed-off-by: Greg Rose <gvrose8...@gmail.com> > --- > include/openvswitch/util.h | 2 +- > 1 file changed, 1

Re: [ovs-dev] [PATCH 1/2] acinclude: Add support for grep option.

amp;1 +grep $5 '$2' $1 >/dev/null 2>&1 status=$? case $status in 0) LGTM Tested-by: Greg Rose <gvrose8...@gmail.com> Reviewed-by: Greg Rose <gvrose8...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] acinclude: Fix SKB_GSO_UDP check.

for SKB_GSO_UDP") Signed-off-by: William Tu <u9012...@gmail.com> Cc: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index 543e1e3f0630..3158c20fbe55 100644 --- a/acinclude.m4 +++

Re: [ovs-dev] [PATCH 2/2] lib/netlink: Use correct netlink max message size

On 11/01/2017 01:33 PM, Ben Pfaff wrote: On Wed, Nov 01, 2017 at 01:17:04PM -0700, Greg Rose wrote: On 11/01/2017 01:01 PM, Ben Pfaff wrote: On Wed, Nov 01, 2017 at 10:33:25AM -0700, Greg Rose wrote: On 11/01/2017 09:38 AM, Ben Pfaff wrote: On Wed, Nov 01, 2017 at 08:28:48AM -0700, Greg Rose

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: > On certain Ubuntu systems running the 4.4 based kernel depmod > may not correctly search for module dependencies when newer > openvswitch kernel modules have been installed in

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

On 11/02/2017 11:12 AM, Greg Rose wrote: On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: > On certain Ubuntu systems running the 4.4 based kernel depmod > may not correctly search for module dependencies when newer > openvswitch kerne

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

On 11/02/2017 01:09 PM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 12:55:13PM -0700, Greg Rose wrote: On 11/02/2017 11:12 AM, Greg Rose wrote: On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:46:48AM -0700, Greg Rose wrote: On certain Ubuntu systems running the 4.4 based

[ovs-dev] [Patch V2] Documentation: Document additional module dependency

configuration file fixes the problem. So to be safe just add it. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- Documentation/intro/install/general.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index e

Re: [ovs-dev] [PATCH] Documentation: Document module install issues

On 11/02/2017 02:39 PM, Guru Shetty wrote: On 2 November 2017 at 12:55, Greg Rose <gvrose8...@gmail.com <mailto:gvrose8...@gmail.com>> wrote: On 11/02/2017 11:12 AM, Greg Rose wrote: On 11/02/2017 11:07 AM, Ben Pfaff wrote: On Thu, Nov 02, 2017 at 10:4

Re: [ovs-dev] [PATCH 2/2] ipfix: Update Timestamp when flow updated

On 10/31/2017 10:37 AM, Ben Pfaff wrote: On Tue, Oct 31, 2017 at 10:08:08AM -0700, Greg Rose wrote: On 10/24/2017 03:19 PM, Ben Pfaff wrote: On Tue, Jun 06, 2017 at 01:42:08PM -0700, Greg Rose wrote: On 06/06/2017 08:22 AM, Ben Pfaff wrote: On Mon, Jun 05, 2017 at 08:34:32PM -0700, Greg Rose

Re: [ovs-dev] [PATCH 2/2] lib/netlink: Use correct netlink max message size

On 10/31/2017 12:53 PM, Ben Pfaff wrote: On Fri, Sep 22, 2017 at 07:44:53AM -0700, Greg Rose wrote: The maximum message size for recent Linux kernels is 32Kb and in older kernels it is 16KB. See http://www.spinics.net/lists/netdev/msg431592.html Adjust the size checked and update a comment

Re: [ovs-dev] [Patch V2] Documentation: Document additional module dependency

On 11/02/2017 02:02 PM, Greg Rose wrote: On certain Ubuntu systems running the 4.4 based kernel depmod may not correctly search for module dependencies when newer openvswitch kernel modules have been installed in the extra directory at /lib/modules/$(uname -r)/extra. A symptom

Re: [ovs-dev] [PATCH 2/2] lib/netlink: Use correct netlink max message size

On 11/01/2017 09:38 AM, Ben Pfaff wrote: On Wed, Nov 01, 2017 at 08:28:48AM -0700, Greg Rose wrote: > On 10/31/2017 12:53 PM, Ben Pfaff wrote: >> On Fri, Sep 22, 2017 at 07:44:53AM -0700, Greg Rose wrote: >>> The maximum message size for recent Linux kernels is 32Kb and in

[ovs-dev] [PATCH 1/6] datapath: Fix netdev_master_upper_dev_link for 4.14

An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4| 3 +++ datapath/linux/compat/include/linux/netde

[ovs-dev] [PATCH 0/6] Enable OVS on Linux 4.14 kernel

with the recent change to make sure the SKB_GSO_UDP was searched as a whole word and thus exposed more fractures. I updated .travis.yml to use all the most recent supported LTS and stable kernels from kernel.org. Greg Rose (6): datapath: Fix netdev_master_upper_dev_link for 4.14 compat: Do not include

[ovs-dev] [PATCH 6/6] travis: Update kernel test list from kernel.org

Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index f217840..8ca6d75 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,17 +25,16 @@ sudo: false env:

[ovs-dev] [PATCH 4/6] datapath: Fix SKB_GSO_UDP usage

Using SKB_GSO_UDP breaks the compilation on Linux 4.14. Check for the HAVE_SKB_GSO_UDP compiler #define. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/datapath.c | 9 ++--- datapath/linux/compat/stt.c | 11 ++- 2 files changed, 16 insertions(+), 4 del

[ovs-dev] [PATCH 3/6] datapath: Constify struct nf_conntrack_l4proto

Linux 4.14 requires this parameter to be constified. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index d517a87..4b181ad 100644 --- a/datapath/connt

[ovs-dev] [PATCH 2/6] compat: Do not include headers when not compiling

If the entire file is not going to be compiled due to compilation time directives then don't bother pulling in the headers. This fixes a compilation error on Linux 4.14. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c| 2 +- datapath/linux/

[ovs-dev] [PATCH V2 5/6] acinclude.m4: Enable Linux 4.14

From: Greg Rose <gvrose8...@gmail.como> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 6511a24..b815c58 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -14

[ovs-dev] [PATCH V2 6/6] travis: Update kernel test list from kernel.org

From: Greg Rose <gvrose@VM-1-Centos.domain> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- .travis.yml | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index f217840..8ca6d75 100644 --- a/.travis.yml +++ b/.travis.y

[ovs-dev] [PATCH V2 4/6] datapath: Fix SKB_GSO_UDP usage

From: Greg Rose <gvrose8...@gmail.como> Using SKB_GSO_UDP breaks the compilation on Linux 4.14. Check for the HAVE_SKB_GSO_UDP compiler #define. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/datapath.c | 9 ++--- datapath/linux/compat/stt.c | 11

[ovs-dev] [PATCH V2 3/6] datapath: conntrack: make protocol tracker pointers const

tually make the actual trackers themselvers const. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/conntrack.c | 4 ++-- 1 file changed, 2 insertions(

[ovs-dev] [PATCH V2 1/6] datapath: Fix netdev_master_upper_dev_link for 4.14

From: Greg Rose <gvrose8...@gmail.como> An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4| 3 +

[ovs-dev] [PATCH V2 2/6] compat: Do not include headers when not compiling

From: Greg Rose <gvrose8...@gmail.como> If the entire file is not going to be compiled because OVS is using upstream tunnel support then also don't bother pulling in the headers. Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linux/compat/ip_gre.c| 2 +- datapath/

[ovs-dev] [PATCH 0/6] Enable OVS on Linux 4.14 kernel

with the recent change to make sure the SKB_GSO_UDP was searched as a whole word and thus exposed more fractures. I updated .travis.yml to use all the most recent supported LTS and stable kernels from kernel.org. Greg Rose (6): datapath: Fix netdev_master_upper_dev_link for 4.14 compat: Do not include

[ovs-dev] [PATCH 00/12] Backport upstream Linux OVS patches

The following patches are available in the current Linux upstream git repository: 183dea5 openvswitch: do not propagate headroom updates to internal port 311af51 openvswitch: use ktime_get_ts64() instead of ktime_get_ts() 67c8d22 openvswitch: fix the incorrect flow action alloc size

[ovs-dev] [PATCH 01/12] datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()

Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Christophe JAILLET <christophe.jail...@wanadoo.fr> Fixes: 850c2a4d1a ("datapath: Avoid using stack larger than 1024.") Signed-off-by: Greg Rose <gvrose8...@gma

[ovs-dev] [PATCH 02/12] datapath: reliable interface indentification in port dumps

er if needed. Signed-off-by: Jiri Benc <jb...@redhat.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Jiri Benc <jb...@redhat.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- acinclude.m4

[ovs-dev] [PATCH 03/12] datapath: export get_dp() API

th.c. Export it. Signed-off-by: Andy Zhou <az...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Andy Zhou <az...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/datapath.c | 29 - datapath/datapath.h | 3

[ovs-dev] [PATCH 04/12] datapath: Add meter netlink definitions

ink messages and attributes for communicating with the user space programs. Signed-off-by: Andy Zhou <az...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Andy Zhou <az...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/linu

[ovs-dev] [PATCH 05/12] datapath: Add meter infrastructure

Andy Zhou <az...@ovn.org> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/Modules.mk | 6 +- datapath/datapath.c | 14 +- datapath/datapath.h | 3 + datapath/linux/compat/include/net

[ovs-dev] [PATCH 08/12] datapath: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start

nvswitch: Add meter infrastructure") Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapa

[ovs-dev] [PATCH 07/12] datapath: Using kfree_rcu() to simplify the code

gt; Cc: Wei Yongjun <weiyongj...@huawei.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/meter.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/datapath/meter.c b/datapath/meter.c index 2e58b6c..52ddd6c 100644 --- a/datapath/meter.c +++ b/datapat

[ovs-dev] [PATCH 06/12] datapath: Fix return value check in ovs_meter_cmd_features()

m> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Wei Yongjun <weiyongj...@huawei.com> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/meter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[ovs-dev] [PATCH 10/12] datapath: fix the incorrect flow action alloc size

udgement can be done by the reserve_sfa_size. Signed-off-by: zhangliping <zhanglipin...@baidu.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: zhangliping <zhanglipin...@baidu.com> Signed-off-by: Greg Rose

[ovs-dev] [PATCH 09/12] datapath: fix data type in queue_gso_packets

untap and packet") Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Acked-by: Willem de Bruijn <will...@google.com> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off-by: Greg Rose

[ovs-dev] [PATCH 12/12] datapath: do not propagate headroom updates to internal port

e. Signed-off-by: Paolo Abeni <pab...@redhat.com> Acked-by: Pravin B Shelar <pshe...@ovn.org> Signed-off-by: David S. Miller <da...@davemloft.net> Also removed related compat layer changes. Cc: Paolo Abeni <pab...@redhat.com> Signed-off-by

[ovs-dev] [PATCH 11/12] datapath: use ktime_get_ts64() instead of ktime_get_ts()

off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: David S. Miller <da...@davemloft.net> Cc: Arnd Bergmann <a...@arndb.de> Signed-off-by: Greg Rose <gvrose8...@gmail.com> --- datapath/flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dat

<    1   2   3   4   5   6   7   8   9   10   >