[ovs-dev] [PATCH v1] Docs: Remove HWOL DPDK limitation.

Partial offload support was added to OVS DPDK in OVS 2.10. As such remove the limitation that OVS DPDK does not support HWOL from the DPDK install documentation. Signed-off-by: Ian Stokes --- Documentation/intro/install/dpdk.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation

Re: [ovs-dev] netdev-dpdk: Support the link speed of XL710

This seems like a very easy commit :-) > > > > On Thu, 23 Aug 2018 at 13:34, Ian Stokes mailto:ian.sto...@intel.com>> wrote: > > > On 8/22/2018 6:14 PM, Federico Iezzi wrote: > > > DPDK exposes API all the way from 10

[ovs-dev] [PATCH v1 2/2] netdev-dpdk: Add link speed to get_status().

is available in Mbps in rte_eth_link. This commit converts the link speed for a given dpdk device to an easy to read string and reports it in get_status(). Suggested-by: Flavio Leitner Signed-off-by: Ian Stokes --- lib/netdev-dpdk.c | 62 +++ 1

[ovs-dev] [PATCH v1 1/2] netdev-dpdk: Fix netdev_dpdk_get_features().

to NETDEV_F_OTHER for undefined link speeds. Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.") Signed-off-by: Ian Stokes --- Flavio, this patch is based on suggestions from you https://mail.openvswitch.org/pipermail/ovs-dev/2018-September/351809.html I'd like to add Co-authored-by: Flav

[ovs-dev] [PATCH v1] Docs: Remove zero-copy QEMU limitation.

branches. Remove the reference to this issue in the zero-copy documentation. Cc: Ciara Loftus Signed-off-by: Ian Stokes --- Documentation/topics/dpdk/vhost-user.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhos

[ovs-dev] [PATCH branch-2.9] dpdk: Use DPDK 17.11.4 release.

Modify travis linux build script to use the latest DPDK stable release 17.11.4. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 4 ++-- Documentation/intro/install/dpdk.rst

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

Hi Ben, The following changes since commit 949758946767ff79b4c3eb5eca755c6cf21643e3: ovs-save: Don't always include the default flow during restore (2018-09-13 05:19:54 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up

[ovs-dev] [PATCH branch-2.7] dpdk: Use DPDK 16.11.8 release.

Modify travis linux build script to use the latest DPDK stable release 16.11.8. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 2 +- Documentation/intro/install/dpdk.rst

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

On 9/13/2018 1:57 PM, Kevin Traynor wrote: On 09/13/2018 01:45 PM, Ian Stokes wrote: On 9/13/2018 1:34 PM, Ophir Munk wrote: Hi Sugesh, I can update documentation. Is it enough to update dpdk.rst.txt only? If not - can you please send a link to additional files with references to 17.11

Re: [ovs-dev] [dpdk-howl PATCH v2] netdev-dpdk: Upgrade to dpdk v18.08.0

On 9/13/2018 1:34 PM, Ophir Munk wrote: Hi Sugesh, I can update documentation. Is it enough to update dpdk.rst.txt only? If not - can you please send a link to additional files with references to 17.11 to be updated? I will wait 1-2 days to get more reviews then will send v3. Hi Ophir, I've

[ovs-dev] [PATCH 1/1] dpdk: Use DPDK 17.11.4 release.

Modify travis linux build script to use the latest DPDK stable release 17.11.4. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh | 2 +- Documentation/faq/releases.rst | 6 +++--- Documentation/intro/install/dpdk.rst

Re: [ovs-dev] [ovs-dev, dpdk-howl, v2] netdev-dpdk: Upgrade to dpdk v18.08.0

On 9/11/2018 10:35 AM, Ilya Maximets wrote: Comments inline. Best regards, Ilya Maximets. On 11.09.2018 02:04, Ophir Munk wrote: 1. Enable compilation and linkage with dpdk 18.08.0 The following dpdk commits which were introduced after dpdk 17.11.x require OVS updates to accommodate to the

Re: [ovs-dev] [RFC] Federating the 0-day robot, and improving the testing

On 9/11/2018 4:51 PM, Aaron Conole wrote: "Eelco Chaudron" writes: On 6 Sep 2018, at 10:56, Aaron Conole wrote: As of June, the 0-day robot has tested over 450 patch series. Occasionally it spams the list (apologies for that), but for the majority of the time it has caught issues before

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

On 8/30/2018 2:51 PM, Ophir Munk wrote: Hi Ian, Please find comments inline. -Original Message- From: Ian Stokes [mailto:ian.sto...@intel.com] Sent: Thursday, August 30, 2018 1:15 PM To: ovs-dev@openvswitch.org Cc: Ophir Munk ; Ben Pfaff ; Aaron Conole ; Kevin Traynor Subject: Re

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

On 8/30/2018 9:31 AM, Stokes, Ian wrote: On Tue, Aug 28, 2018 at 11:32:31AM +0100, Ian Stokes wrote: On 8/27/2018 5:16 PM, Ben Pfaff wrote: On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote: 4. How can I inspect the new branches? Currently I am not seeing them. I do not think

Re: [ovs-dev] [PATCH v3 6/6] system-dpdk: Connect network namespaces via dpdkvhostuser ports

On 8/30/2018 1:08 AM, Bala Sankaran wrote: - Original Message - From: "Aaron Conole" To: "Bala Sankaran" Cc: "Tiago Lam" , d...@openvswitch.org Sent: Wednesday, 29 August, 2018 5:14:41 PM Subject: Re: [ovs-dev] [PATCH v3 6/6] system-dpdk: Connect network namespaces via dpdkvhostuser

Re: [ovs-dev] [PATCH v3 0/6] system-dpdk: Add support to connect two namespaces

On 8/28/2018 6:47 PM, Bala Sankaran wrote: This allows system-dpdk test suite to ping two namespaces via a veth and dpdkvhostuser port, using testpmd as a forwarding agent. For the initial test, testpmd included with 18.11-rc0 is used, while ovs is linked against DPDK 17.11 LTS. Some

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

On 8/27/2018 5:16 PM, Ben Pfaff wrote: I can help with some of these. On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote: Ian, can you please specify the practical steps regarding the new branches? Specifically, what is the procedure for adding a new patch for either of the branches

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.7

Hi Ben, The following changes since commit 576a2011a2872bf0f05ae19cf20425f88c837999: netdev-linux: Avoid division by 0 if kernel reports bad scheduler data. (2018-08-20 09:31:06 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_7 for you to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.8

Hi Ben, The following changes since commit f860e9ec5b009d836de6211510b17ebe2b894ef1: netdev-linux: Avoid division by 0 if kernel reports bad scheduler data. (2018-08-20 09:31:00 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_8 for you to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

Hi Ben, The following changes since commit 9b2b68660e9a939a82e9142f25ba0f7942188925: ovn-northd: Support learning neighbor from ARP request. (2018-08-27 09:51:21 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_9 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

Hi Ben, The following changes since commit 052602d269480c69007bea771ebb8beffc2e377c: ovn-northd: Support learning neighbor from ARP request. (2018-08-27 09:50:28 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_10 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

Hi Ben, The following changes since commit 418a7a84245f5fbe589dd1267463fc9ba27a1dd6: ofproto-dpif-trace: Make -generate send packets to controller again. (2018-08-27 09:35:21 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch

Re: [ovs-dev] [PATCH v2 6/6] system-dpdk: Execute testpmd on the background

On 8/22/2018 2:37 PM, Aaron Conole wrote: From: Bala Sankaran This adds a new test to the 'check-dpdk' subsystem that will exercise allocations, PMDs, and the vhost-user code path. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole ---

Re: [ovs-dev] [PATCH v2 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

On 8/22/2018 2:37 PM, Aaron Conole wrote: From: Bala Sankaran When multiple users run the DPDK testsuite ther dependence on /tmp Minor typo above 'ther' -> 'their' Ian will cause conflicts. Use the RUNDIR as a dynamic path to overcome this. NOTE: This still doesn't solve the dependency on

Re: [ovs-dev] [PATCH v2 3/6] system-dpdk: Allow running the dpdk tests from a VM

On 8/22/2018 2:37 PM, Aaron Conole wrote: Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. LGTM, tested and no

Re: [ovs-dev] [PATCH v2 4/6] system-dpdk: Use a different character marker for sed commands

On 8/22/2018 2:37 PM, Aaron Conole wrote: The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. LGTM, Ian Signed-off-by: Aaron Conole ---

Re: [ovs-dev] [PATCH v2 2/6] system-dpdk: skip all tests if there are no hugepages

On 8/22/2018 2:37 PM, Aaron Conole wrote: From: Bala Sankaran A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. This is ok, again however I'd like to see the expected behavior called

Re: [ovs-dev] [PATCH v2 1/6] system-dpdk: update test suite for non-phy testing

On 8/22/2018 2:37 PM, Aaron Conole wrote: This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Overall I think this approach is

Re: [ovs-dev] netdev-dpdk: Support the link speed of XL710

On 8/22/2018 6:14 PM, Federico Iezzi wrote: DPDK exposes API all the way from 10Mbps to 100Gbps. http://doc.dpdk.org/api/rte__ethdev_8h_source.html Can other cards be added? 25G is now getting really popular. Thanks It’s a good point, technically there’s nothing stopping users from using

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

On 8/15/2018 4:52 PM, Aaron Conole wrote: Ian Stokes writes: On 8/15/2018 10:51 AM, Ophir Munk wrote: Hi, Please find comments inline. -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- boun...@openvswitch.org] On Behalf Of Stokes, Ian Sent: Tuesday, August

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

On 8/15/2018 10:51 AM, Ophir Munk wrote: Hi, Please find comments inline. -Original Message- From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- boun...@openvswitch.org] On Behalf Of Stokes, Ian Sent: Tuesday, August 14, 2018 7:42 PM To: Ben Pfaff (b...@ovn.org) Cc:

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

On 8/14/2018 10:19 PM, Ben Pfaff wrote: On Tue, Aug 14, 2018 at 04:42:06PM +, Stokes, Ian wrote: Recently at the OVS DPDK community meeting the case for 2 new branches was raised. https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350898.html These branches would be: (i) OVS

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.8

Hi Ben, The following changes since commit 05ae838b2057fd2c55cdca87228f34741b046b79: netdev-dpdk: Use hex for PCI vendor ID. (2018-08-08 22:12:19 +0100) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_8 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.7

Hi Ben, The following changes since commit a90ff16cad22afd4cea6dfd9f0b93f93988842cb: netdev-dpdk: Use hex for PCI vendor ID. (2018-08-08 22:12:58 +0100) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_7 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

changes up to 7184517ca77fc9c084f1a8b53ccdbc82dab34c19: vswitch.xml: Update dpdk-init documentation. (2018-08-10 10:40:20 +0100) Ian Stokes (1): releases: Add 2.10 entry for supported DPDK versions. Kevin Traynor (1

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

to 6d947d508a5167f31430a3c8c8026a7d22aa7349: vswitch.xml: Update dpdk-init documentation. (2018-08-10 10:39:54 +0100) Ian Stokes (1): releases: Add 2.10 entry for supported DPDK versions. Kevin Traynor (1): vswitch.xml: Update dpdk-init

Re: [ovs-dev] [PATCH v7 00/13] Support multi-segment mbufs

On 8/9/2018 12:44 PM, Ilya Maximets wrote: On 09.08.2018 11:38, Lam, Tiago wrote: Hi Ilya, On 09/08/2018 09:27, Ilya Maximets wrote: Hmm. I found that this series modifies only dpdk related components and doesn't pay any attention to others. dp_packet API was modified to respect the segmented

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.7

Hi Ben, The following changes since commit e1619a1e7a8dded3c7da9ab40bd62a3628478711: ofctl: Fixup compare_flows function (2018-08-08 21:11:14 +0300) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_7 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.6

Hi Ben, The following changes since commit a9e21a1b9134090a3a12b1760daffba7f2777472: pcap-file: Fix formatting of log message. (2018-08-03 16:55:51 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_6 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.8

Hi Ben, The following changes since commit 59c0ba2990b7149ba42bb34b76cbe27b9cbed0e9: ofctl: Fixup compare_flows function (2018-08-08 21:09:55 +0300) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_8 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

Hi Ben, The following changes since commit c3a91ed557b7765c907ee5597ae8e68b1181869a: ofctl: Fixup compare_flows function (2018-08-08 21:03:17 +0300) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_9 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

Hi Ben, The following changes since commit faf64fb8861f312aca86a1d2b8fcb30d0504b09b: table: fix html buffer output (2018-08-08 11:19:15 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_10 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

Hi Ben, The following changes since commit c3cc694b93dd523176d2131a4b1b3b3170644638: table: fix html buffer output (2018-08-08 11:18:07 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up to

Re: [ovs-dev] [PATCH 1/2] ofp-port: Fix buffer overread parsing Intel custom statistics.

On 8/8/2018 7:11 PM, Ben Pfaff wrote: On Wed, Aug 08, 2018 at 09:24:30AM +0100, Ian Stokes wrote: On 8/7/2018 1:00 AM, Ben Pfaff wrote: On Fri, Jul 27, 2018 at 11:14:43AM -0700, Ben Pfaff wrote: CC: Michal Weglicki Fixes: 971f4b394c6e ("netdev: Custom statistics.") Reported

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

On 8/8/2018 5:06 PM, Darrell Ball wrote: On Wed, Aug 8, 2018 at 3:17 AM, Ian Stokes <mailto:ian.sto...@intel.com>> wrote: On 8/7/2018 6:13 PM, Darrell Ball wrote: On Tue, Aug 7, 2018 at 5:08 AM, Stokes, Ian mailto:ian.sto...@intel.com> <

[ovs-dev] [PATCH] releases: Add 2.10 entry for supported DPDK versions.

This commit adds an entry for OVS 2.10 and the supported DPDK version in releases.rst. Signed-off-by: Ian Stokes --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 0f3bf0c..50ca5f6 100644

Re: [ovs-dev] [PATCH] netdev-dpdk: Use hex for PCI vendor ID.

On 8/3/2018 8:03 PM, Kevin Traynor wrote: Match the prefix and formatting. Fixes: 8a9562d21a40 ("dpif-netdev: Add DPDK netdev.") Cc: pshe...@ovn.org Signed-off-by: Kevin Traynor Thanks Kevin, I'll add this to the pull request, I think it can be backported from 2.10 -> 2.6 also. Ian ---

Re: [ovs-dev] [PATCH v7 07/13] dp-packet: Handle multi-seg mubfs in shift() func.

On 8/7/2018 6:13 PM, Darrell Ball wrote: On Tue, Aug 7, 2018 at 5:08 AM, Stokes, Ian > wrote: > In its current implementation dp_packet_shift() is also unaware of multi- > seg mbufs (that holds data in memory non-contiguously) and assumes that > data

Re: [ovs-dev] [PATCH v6] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

On 7/27/2018 7:26 PM, Vishal Deep Ajmera wrote: OVS reads packets in batches from a given port and packets in the batch are subjected to potentially 3 levels of lookups to identify the datapath megaflow entry (or flow) associated with the packet. Each megaflow entry has a dedicated buffer in

Re: [ovs-dev] [PATCH 2/2] ofp-port: Drop of useless indirection in ofputil_pull_ofp14_port_stats().

On 7/27/2018 7:14 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff Seems straight forward enough. LGTM. I can add this to this weeks pull request. Thanks Ian --- lib/ofp-port.c | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git

Re: [ovs-dev] [PATCH 1/2] ofp-port: Fix buffer overread parsing Intel custom statistics.

On 8/7/2018 1:00 AM, Ben Pfaff wrote: On Fri, Jul 27, 2018 at 11:14:43AM -0700, Ben Pfaff wrote: CC: Michal Weglicki Fixes: 971f4b394c6e ("netdev: Custom statistics.") Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9445 Signed-off-by: Ben Pfaff Still needs a review.

Re: [ovs-dev] [PATCH 5/5] netdev: Clean up class initialization.

On 7/12/2018 10:55 PM, Ben Pfaff wrote: The macros are hard to read. This makes it a little more readable. Thanks for this Ben, one minor comment below. Signed-off-by: Ben Pfaff --- configure.ac | 1 + lib/netdev-dpdk.c | 235 --

Re: [ovs-dev] Revert "dp-packet: Handle multi-seg mbufs in resize__()."

On 7/25/2018 2:56 PM, Aaron Conole wrote: 0-day Robot writes: Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Hi Ian (and all), Given there are

[ovs-dev] [PATCH 1/1] ovn-nbctl: Initialize arguments to avoid compilation warnings.

uot; Fixes: bc8223df3b01 ("ovn-nbctl: Don't die in parse_priority().") Signed-off-by: Ian Stokes --- ovn/utilities/ovn-nbctl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 3c3e582..c3703a3 100644 ---

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

] netdev-dpdk: Fix failure to configure flow control at netdev-init. On 7/13/2018 6:13 PM, Ian Stokes wrote: On 7/10/2018 2:23 PM, Sugesh Chandran wrote: Configuring flow control at ixgbe netdev-init is throwing error in port start. For eg: without this fix, user cannot configure flow control

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

On 7/13/2018 6:13 PM, Ian Stokes wrote: On 7/10/2018 2:23 PM, Sugesh Chandran wrote: Configuring flow control at ixgbe netdev-init is throwing error in port start. For eg: without this fix, user cannot configure flow control on ixgbe dpdk port as below, " ovs-vsctl add-port br0

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

: Use ETH_ADDR_BYTES_ARGS instead of open-coding it. sparse: Add support for DPDK. Ian Stokes (1): Docs: Improve OVS DPDK version mapping notice. Mark Kavanagh (4): netdev-dpdk: fix mbuf sizing dp-packet: Init specific mbuf fields. netdev-dpdk: copy large packet to multi

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

On 7/19/2018 7:06 PM, Ian Stokes wrote: On 7/13/2018 5:56 PM, Ian Stokes wrote: Hi Ben, The following changes since commit 89dd5819cf181a741271d297bc99fea4760f7ba5:    rhel: support kmod-openvswitch build against multiple kernels, rhel6 (2018-07-12 17:42:07 -0700) are available

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

On 7/13/2018 5:56 PM, Ian Stokes wrote: Hi Ben, The following changes since commit 89dd5819cf181a741271d297bc99fea4760f7ba5:   rhel: support kmod-openvswitch build against multiple kernels, rhel6 (2018-07-12 17:42:07 -0700) are available in the git repository at:   https://github.com

Re: [ovs-dev] [PATCH 4/5] sparse: Add support for DPDK.

On 7/12/2018 10:55 PM, Ben Pfaff wrote: This allows netdev-dpdk.c to compile cleanly with sparse. Thanks for this Ben, much appreciated, I hadn't seen that sparse was broken for OVS with DPDK. I was under the impression that travis builds with sparse enabled so typically I look there for

Re: [ovs-dev] [PATCH 3/5] netdev-dpdk: Use ETH_ADDR_BYTES_ARGS instead of open-coding it.

On 7/12/2018 10:55 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff I wasn't aware of ETH_ADDR_BYTES_ARGS(), thanks, will add to the next pull request. Ian --- lib/netdev-dpdk.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dpdk.c

Re: [ovs-dev] [PATCH 2/5] netdev-dpdk: Fix sparse complaints.

On 7/16/2018 7:06 PM, Yifeng Sun wrote: Thanks for the fix. I am wondering why there was no running issue when dl_type is compared with wrong byte order. Reviewed-by: Yifeng Sun On Thu, Jul 12, 2018 at 2:55 PM, Ben Pfaff wrote: Neither of these is a real problem. Seems ok to me, adding

Re: [ovs-dev] [PATCH 1/5] netdev-dpdk: Fix incorrect byte order conversion in log message.

On 7/12/2018 10:55 PM, Ben Pfaff wrote: uint8_t values shouldn't be passed to ntohs(). Found by soarse. Signed-off-by: Ben Pfaff --- lib/netdev-dpdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix failure to configure flow control at netdev-init.

On 7/10/2018 2:23 PM, Sugesh Chandran wrote: Configuring flow control at ixgbe netdev-init is throwing error in port start. For eg: without this fix, user cannot configure flow control on ixgbe dpdk port as below, " ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \

Re: [ovs-dev] [PATCH v5] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

On 7/13/2018 2:54 PM, Vishal Deep Ajmera wrote: Hi Ian, Ilya, If there are no more comments, can I request to please include the fix in this week's pull request? Hi Vishal, I'll leave Ilya to respond to the changes he requested. This weeks pull request includes the new feature 'SMC cache

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

changes up to 70f4d53a17d953b0fadf18361b54ce95550ebfb7: netdev-dpdk: Fix failure to configure flow control at netdev-init. (2018-07-13 17:08:56 +0100) Ian Stokes (1): Docs: Improve OVS DPDK version mapping notice. Mark

Re: [ovs-dev] [PATCH v5 00/14] Support multi-segment mbufs

On 7/11/2018 7:23 PM, Tiago Lam wrote: Overview This patchset introduces support for multi-segment mbufs to OvS-DPDK. Multi-segment mbufs are typically used when the size of an mbuf is insufficient to contain the entirety of a packet's data. Instead, the data is split across numerous

[ovs-dev] [PATCH] Docs: Improve OVS DPDK version mapping notice.

. Suggested-by: Ben Pfaff Signed-off-by: Ian Stokes --- Documentation/howto/dpdk.rst | 6 -- Documentation/intro/install/dpdk.rst | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index 82596f5..ab3d576

Re: [ovs-dev] [PATCH v5 01/14] netdev-dpdk: fix mbuf sizing

On 7/12/2018 4:40 PM, Lam, Tiago wrote: On 12/07/2018 14:37, Ian Stokes wrote: On 7/11/2018 7:23 PM, Tiago Lam wrote: From: Mark Kavanagh There are numerous factors that must be considered when calculating the size of an mbuf: - the data portion of the mbuf must be sized in accordance

Re: [ovs-dev] [PATCH v5 01/14] netdev-dpdk: fix mbuf sizing

On 7/11/2018 7:23 PM, Tiago Lam wrote: From: Mark Kavanagh There are numerous factors that must be considered when calculating the size of an mbuf: - the data portion of the mbuf must be sized in accordance With Rx buffer alignment (typically 1024B). So, for example, in order to

Re: [ovs-dev] Multiqueue in vhost using OVS-DPDK

On 7/11/2018 7:23 PM, Ian Stokes wrote: On 7/11/2018 7:02 PM, Ravi Kerur wrote: Hello OVS-DPDK team, I am using OVS 2.9.90 for my vhost-virtio testing and had some questions on vhost multiqueue support, it doesn't seem to be working correctly. Kindly let me know if multiqueue is supported? I

Re: [ovs-dev] Multiqueue in vhost using OVS-DPDK

On 7/11/2018 7:02 PM, Ravi Kerur wrote: Hello OVS-DPDK team, I am using OVS 2.9.90 for my vhost-virtio testing and had some questions on vhost multiqueue support, it doesn't seem to be working correctly. Kindly let me know if multiqueue is supported? I am using following link as a reference.

Re: [ovs-dev] [PATCH v4 05/15] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

On 7/10/2018 12:06 PM, Tiago Lam wrote: A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free operations by non-pmd threads on a given mempool. free_dpdk_buf() has been modified to make use of the introduced mutex. 1 comment Below Tiago. Signed-off-by: Tiago

Re: [ovs-dev] [PATCH v4 11/15] netdev-dpdk: copy large packet to multi-seg. mbufs

On 7/10/2018 12:06 PM, Tiago Lam wrote: From: Mark Kavanagh Currently, packets are only copied to a single segment in the function dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames, particularly when multi-segment mbufs are involved. This patch calculates the number of

Re: [ovs-dev] [PATCH v4 01/15] netdev-dpdk: Differentiate between mtu/mbuf size.

On 7/10/2018 12:06 PM, Tiago Lam wrote: When configuring a mempool, in netdev_dpdk_mempool_configure(), the result of a call to dpdk_buf_size() is being used as the MTU. This, however, is not the MTU but a ROUND_UP aligned number based on the MTU, which could lead to the reuse of mempools even

Re: [ovs-dev] [PATCH 0/3] IPsec support for tunneling

On 7/9/2018 5:54 PM, Ben Pfaff wrote: On Thu, Jul 05, 2018 at 09:29:37PM +, Stokes, Ian wrote: On Thu, Jul 05, 2018 at 09:29:12PM +0100, Ian Stokes wrote: On 6/27/2018 6:58 PM, Qiuyu Xiao wrote: This patch series reintroduce IPsec support for OVS tunneling and adds new features to prepare

[ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

required. Cc: Justin Pettit Cc: Venkata Anil Fixes: 31114af758c7 ("ovn-nbctl: Update logical router port commands.") Fixes: 80f408f4cffb ("ovn: Use Logical_Switch_Port in NB.") Fixes: 36f232bca2db ("ovn: l3ha, CLI for logical router port gateway cha

Re: [ovs-dev] [PATCH] NEWS: Re-add vhost zero copy support.

On 7/10/2018 2:33 PM, Loftus, Ciara wrote: An entry for experimental vhost zero copy support was removed incorrectly. Re-add this entry to NEWS. Reported-by: Eelco Chaudron Cc: Ciara Loftus Fixes: c3c722d2c7ee ("Documentation: document ovs-dpdk flow offload") Signed-off-by:

[ovs-dev] [PATCH] NEWS: Re-add vhost zero copy support.

An entry for experimental vhost zero copy support was removed incorrectly. Re-add this entry to NEWS. Reported-by: Eelco Chaudron Cc: Ciara Loftus Fixes: c3c722d2c7ee ("Documentation: document ovs-dpdk flow offload") Signed-off-by: Ian Stokes --- NEWS | 1 + 1 file changed, 1

Re: [ovs-dev] [PATCH v4 12/15] netdev-dpdk: support multi-segment jumbo frames

On 7/10/2018 1:40 PM, Ilya Maximets wrote: On 10.07.2018 15:30, Eelco Chaudron wrote: On 10 Jul 2018, at 13:06, Tiago Lam wrote: From: Mark Kavanagh Currently, jumbo frame support for OvS-DPDK is implemented by increasing the size of mbufs within a mempool, such that each mbuf within the

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

changes up to ac2fb7d4fae5ad6d37dde4d1d3f0907e6f950329: dpdk: Use DPDK 17.11.3 release. (2018-07-06 10:52:54 +0100) Ian Stokes (1): dpdk: Use DPDK 17.11.3 release. .travis/linux-build.sh | 2 +- Documentation

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

to 43307ad0e2543c9c8443f3ab1150ab03f4eb551c: dpdk: Support both shared and per port mempools. (2018-07-06 12:46:26 +0100) Finn Christensen (1): netdev-dpdk: implement flow offload with rte flow Ian Stokes (2): dpdk: Use

Re: [ovs-dev] [PATCH] release-process.rst: Add "soft freeze" stage.

On 7/5/2018 9:46 PM, Ben Pfaff wrote: On Thu, Jul 05, 2018 at 09:37:16PM +0100, Ian Stokes wrote: On 7/5/2018 9:21 PM, Ben Pfaff wrote: On Thu, Jul 05, 2018 at 07:33:06PM +0100, Ian Stokes wrote: On 7/2/2018 9:57 PM, Ben Pfaff wrote: +1. "Soft freeze" of the master branch. +

Re: [ovs-dev] [patch_v1] db-ctl-base: Use boolean variable values.

in 165c1f0649af commit. Cc: Ian Stokes Fixes: 165c1f0649af ("db-ctl-base: Fix compilation warnings.") Signed-off-by: Darrell Ball --- lib/db-ctl-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index 1768b45..4af8489 100644 --- a/

Re: [ovs-dev] [PATCH] release-process.rst: Add "soft freeze" stage.

On 7/5/2018 9:21 PM, Ben Pfaff wrote: On Thu, Jul 05, 2018 at 07:33:06PM +0100, Ian Stokes wrote: On 7/2/2018 9:57 PM, Ben Pfaff wrote: +1. "Soft freeze" of the master branch. + + During the freeze, we ask committers to refrain from applying patches that + add new features un

Re: [ovs-dev] [PATCH 0/3] IPsec support for tunneling

On 6/27/2018 6:58 PM, Qiuyu Xiao wrote: This patch series reintroduce IPsec support for OVS tunneling and adds new features to prepare for the OVN IPsec support. The new features are: 1) Add CA-cert based authentication support to ovs-monitor-ipsec. 2) Enable ovs-pki to generate x.509 version 3

Re: [ovs-dev] [PATCH] release-process.rst: Add "soft freeze" stage.

On 7/2/2018 9:57 PM, Ben Pfaff wrote: The last few OVS releases have included a "soft freeze" stage in the release process, but this stage has never been formalized in the documentation. This adds a description. Signed-off-by: Ben Pfaff --- Documentation/internals/release-process.rst | 87

Re: [ovs-dev] [PATCH v2] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

On 7/5/2018 12:06 AM, Vishal Deep Ajmera wrote: OVS reads packets in batches from a given port and packets in the batch are subjected to potentially 3 levels of lookups to identify the datapath megaflow entry (or flow) associated with the packet. Each megaflow entry has a dedicated buffer in

[ovs-dev] [PATCH] db-ctl-base: Fix compilation warnings.

code into library.") Signed-off-by: Ian Stokes --- lib/db-ctl-base.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index a59ac30..1768b45 100644 --- a/lib/db-ctl-base.c +++ b/lib/db-ctl-base.c @@ -919,8 +919,8 @@ cmd_

Re: [ovs-dev] [PATCH] dpif-netdev: Avoid reordering of packets in a batch with same megaflow

On 6/17/2018 3:21 AM, Vishal Deep Ajmera wrote: OVS reads packets in batches from a given port and packets in the batch are subjected to potentially 3 levels of lookups to identify the datapath megaflow entry (or flow) associated with the packet. Each megaflow entry has a dedicated buffer in

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 17.11.3 release.

On 7/2/2018 8:29 PM, Flavio Leitner wrote: On Wed, Jun 20, 2018 at 10:39:46AM +0100, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 17.11.3. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- .travis/linux-build.sh

Re: [ovs-dev] [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow

On 6/28/2018 6:39 PM, Flavio Leitner wrote: On Thu, Jun 28, 2018 at 11:22:49AM +, Shahaf Shuler wrote: Hi Ian, Flavio, Hi! Thursday, June 28, 2018 12:14 PM, Ian Stokes: Subject: Re: [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow On 6/25/2018 2:21 PM, Shahaf Shuler wrote: Hi

Re: [ovs-dev] [PATCH v11 0/7] OVS-DPDK flow offload with rte_flow

On 6/25/2018 2:21 PM, Shahaf Shuler wrote: Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow with a mark id (a unit32_t number). Later, we then get the flow directly from

[ovs-dev] [PATCH v2] dpdk: Support both shared and per port mempools.

the memory models and example memory requirement calculations is also added. Signed-off-by: Ian Stokes --- v1 -> v2 * Fix typo 'transparency' in vswitch.xml. * In memory.rst change mtu size description from 'can be' to 'is always' larger than the requested mtu size and fix 'alignment' typ

Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] dpdk: Support both shared and per port mempools.

On 6/25/2018 7:56 PM, 0-day Robot wrote: Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: == Checking d0b5c881a538 ("dpdk: Support both s

Re: [ovs-dev] [PATCH v1] dpdk: Support both shared and per port mempools.

On 6/26/2018 9:30 PM, Aaron Conole wrote: Hi Ian, Ian Stokes writes: This commit re-introduces the concept of shared mempools as the default memory model for DPDK devices. Per port mempools are still available but must be enabled explicitly by a user. OVS previously used a shared mempool

Re: [ovs-dev] [PATCH v1] dpdk: Support both shared and per port mempools.

On 6/26/2018 3:33 PM, Kevin Traynor wrote: On 06/25/2018 12:56 PM, Ian Stokes wrote: This commit re-introduces the concept of shared mempools as the default memory model for DPDK devices. Per port mempools are still available but must be enabled explicitly by a user. OVS previously used

[ovs-dev] [PATCH v1] dpdk: Support both shared and per port mempools.

the memory models and example memory requirement calculations is also added. Signed-off-by: Ian Stokes --- Documentation/automake.mk| 1 + Documentation/intro/install/dpdk.rst | 6 + Documentation/topics/dpdk/index.rst | 1 + Documentation/topics/dpdk/memory

Re: [ovs-dev] [RFC PATCH v2 1/1] dpdk: Support both shared and per port mempools.

On 6/19/2018 12:46 PM, Kevin Traynor wrote: On 06/19/2018 12:16 PM, Kevin Traynor wrote: On 06/19/2018 12:11 PM, Kevin Traynor wrote: +if (per_port_mp && rte_errno == EEXIST) { +LIST_FOR_EACH (next, list_node, _mp_list) { +if (dmp->mp ==

<    1   2   3   4   >