Re: [ovs-dev] [PATCH ovn] inc-proc-eng: Improve the documentation with more detailed guidelines.

2022-12-21 Thread Numan Siddique
On Mon, Dec 12, 2022 at 3:45 PM Han Zhou wrote: > > Signed-off-by: Han Zhou Thanks for improving the documentation. There are a couple of small typos. PSB Acked-by: Numan Siddique Numan > --- > lib/inc-proc-eng.h | 127 + > 1 fi

Re: [ovs-dev] [PATCH ovn v2] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-12-16 Thread Numan Siddique
On Thu, Dec 15, 2022 at 4:38 PM Han Zhou wrote: > > On Mon, Dec 12, 2022 at 1:28 AM venu iyer wrote: > > > > Currently, even stateless flows are subject to connection tracking when > there are > > LB rules (for DNAT). However, if a flow needs to be subjected to LB, then > it shouldn't > > be conf

Re: [ovs-dev] [PATCH ovn v3 0/5] OVN IC multiple same routes fixes

2022-12-15 Thread Numan Siddique
ic: prevent advertising/learning multiple same routes > ic: minor code improvements > ic-sb schema: add index for routes table & document upgrade path For the entire series: Acked-by: Numan Siddique Numan > > Documentation/intro/install/ovn-upg

Re: [ovs-dev] [PATCH ovn] Add IPv6 support for lb health-check

2022-12-15 Thread Numan Siddique
On Tue, Nov 22, 2022 at 12:54 PM Lorenzo Bianconi wrote: > > Add Similar to IPv4 counterpart, introduce IPv6 load-balancer health > check support. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2136094 > Signed-off-by: Lorenzo Bianconi Hi Lorenzo, Thanks for adding this missing fe

Re: [ovs-dev] [PATCH ovn 00/12] Fixes to multiple Unit and System Tests

2022-12-15 Thread Numan Siddique
On Tue, Dec 13, 2022 at 10:07 AM Xavier Simonart wrote: > > Hi Mark, Ales > > Thanks for your review and feedback. > I'll send v2 for patch 4 and 7, and comments on patch 10. > > Thanks > Xavier > > On Mon, Dec 12, 2022 at 10:33 PM Mark Michelson wrote: > > > Hi Xavier. I did a review of this ser

Re: [ovs-dev] [PATCH v3 ovn] actions: introduce ct_commit_continue action

2022-12-14 Thread Numan Siddique
On Tue, Dec 13, 2022 at 1:20 PM Lorenzo Bianconi wrote: > > > On Tue, Dec 13, 2022 at 5:03 AM Dumitru Ceara wrote: > > > > > > On 12/13/22 07:17, Han Zhou wrote: > > > > On Mon, Dec 12, 2022 at 8:52 AM Numan Siddique wrote: > > > >> >

Re: [ovs-dev] [OVN v19 3/3] OVN Remote Port Mirroring: controller changes to create ovs mirrors

2022-12-14 Thread Numan Siddique
On Wed, Dec 14, 2022 at 7:48 PM Ihar Hrachyshka wrote: > > There's one code branch left for the now-killed "both" filter. (See > below.) With this branch cleaned up, > > Acked-By: Ihar Hrachyshka I applied this patch to the main and branch-22,12 with a few changes. Please see below > > On Tue

Re: [ovs-dev] [OVN v19 1/3] OVN Remote Port Mirroring: Add new Schemas in NB

2022-12-14 Thread Numan Siddique
On Wed, Dec 14, 2022 at 7:40 PM Ihar Hrachyshka wrote: > > Acked-By: Ihar Hrachyshka Thanks Ihar for the reviews. I applied this patch with the below small changes - diff --git a/ovn-nb.xml b/ovn-nb.xml index c2d0

Re: [ovs-dev] [OVN v19 0/3] OVN Remote Port Mirroring

2022-12-14 Thread Numan Siddique
On Tue, Dec 13, 2022 at 2:33 PM Abhiram R N wrote: > > This patch set adds a new feature in OVN. > i.e Remote Port Mirroring > Already in OVS this support is present. We are leveraging that > and trying to add support in OVN. > So that from OVN APIs we can create/delete mirrors and > attach and de

Re: [ovs-dev] [OVN v19 1/3] OVN Remote Port Mirroring: Add new Schemas in NB

2022-12-13 Thread Numan Siddique
On Tue, Dec 13, 2022 at 3:33 PM Ihar Hrachyshka wrote: > > Abhiram, these style violations should be fixed. Hi Ihar, These warnings are ok and can be ignored. Perhaps we need to fix it in the checkpatch to address these warnings. Numan > > (I will review the actual code changes tomorrow.) > >

Re: [ovs-dev] [OVN v18 1/3] OVN Remote Port Mirroring: Add new Schemas in NB and SB

2022-12-12 Thread Numan Siddique
On Mon, Dec 12, 2022 at 2:17 PM Ihar Hrachyshka wrote: > > I appreciate the split of the code into pieces, since it became hard > to track the changes and focus discussion on parts that are indeed > controversial / require additional discussion, compared to rather > static pieces. > > I'm not COMP

Re: [ovs-dev] [OVN v17 1/3] OVN Remote Port Mirroring: Add new Schemas in NB and SB

2022-12-12 Thread Numan Siddique
On Tue, Nov 29, 2022 at 7:50 AM Abhiram R N wrote: > > Hi Mark, > > Thanks for your review. > Please see replies inline below > > On Tue, Nov 29, 2022 at 3:24 AM Mark Michelson wrote: > > > Hi, since this patch series doesn't have a cover letter, I figure I > > would make some top-level comments

Re: [ovs-dev] [PATCH v3 ovn] actions: introduce ct_commit_continue action

2022-12-12 Thread Numan Siddique
On Thu, Dec 8, 2022 at 12:15 PM Lorenzo Bianconi wrote: > > In the current codebase ct_commit {} action clears ct_state metadata of > the incoming packet. This behaviour introduces an issue if we need to > check the connection tracking state in the subsequent pipeline stages, > e.g. for hairpin tr

Re: [ovs-dev] [PATCH v4 ovn] binding: add the capability to apply QoS for lsp

2022-12-12 Thread Numan Siddique
On Sun, Dec 11, 2022 at 8:54 AM Lorenzo Bianconi wrote: > > > On Fri, Dec 9, 2022 at 9:43 AM Lorenzo Bianconi > > wrote: > > > > > > > On Sun, Dec 4, 2022 at 5:06 PM Lorenzo Bianconi > > > > wrote: > > > > > > > > > > Introduce the capability to apply QoS rules for logical switch ports > > > > >

Re: [ovs-dev] [PATCH ovn v2 3/4] ic: prevent advertising/learning multiple same routes

2022-12-12 Thread Numan Siddique
On Mon, Dec 12, 2022 at 5:41 AM Dumitru Ceara wrote: > > On 12/9/22 19:42, Vladislav Odintsov wrote: > > Hi Dumitru, > > Hi Vladislav, > > > > > please see answers inline. > > > > Regards, > > Vladislav Odintsov > > > >> On 9 Dec 2022, at 17:37, Dumitru Ceara wrote: > >> > >> On 12/6/22 11:20, Vl

Re: [ovs-dev] [PATCH v4 ovn] binding: add the capability to apply QoS for lsp

2022-12-09 Thread Numan Siddique
On Fri, Dec 9, 2022 at 9:43 AM Lorenzo Bianconi wrote: > > > On Sun, Dec 4, 2022 at 5:06 PM Lorenzo Bianconi > > wrote: > > > > > > Introduce the capability to apply QoS rules for logical switch ports > > > claimed by ovn-controller. Rely on shash instead of sset for > > > egress_ifaces. > > > >

Re: [ovs-dev] [PATCH v4 ovn] binding: add the capability to apply QoS for lsp

2022-12-08 Thread Numan Siddique
On Sun, Dec 4, 2022 at 5:06 PM Lorenzo Bianconi wrote: > > Introduce the capability to apply QoS rules for logical switch ports > claimed by ovn-controller. Rely on shash instead of sset for > egress_ifaces. > > Acked-by: Mark Michelson > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2

Re: [ovs-dev] [PATCH ovn 1/2] CI: Refactor the linux-build.sh

2022-12-07 Thread Numan Siddique
On Mon, Nov 28, 2022 at 9:26 AM Ales Musil wrote: > > Update the build script, so it is easier to > define opts/flags per compiler, but also per architecture. > > Signed-off-by: Ales Musil Thanks Ales. I applied both the patches to the main. Numan > --- > .ci/linux-build.sh | 48

Re: [ovs-dev] [PATCH ovn v3] controller: Check if MAC binding table has timestamp column

2022-12-07 Thread Numan Siddique
On Tue, Dec 6, 2022 at 10:21 AM Ales Musil wrote: > > In order to keep backward compatibility with northd we need > to check if MAC binding table actually has the timestamp column. > > Reported-at: https://bugzilla.redhat.com/2151066 > Signed-off-by: Ales Musil Acked-by: Numa

Re: [ovs-dev] [PATCH ovn v2] northd: Add missing RBAC rules for BFD table.

2022-12-07 Thread Numan Siddique
On Tue, Dec 6, 2022 at 9:56 AM Dumitru Ceara wrote: > > On 12/6/22 15:52, Frode Nordahl wrote: > > If a OVN deployment has OVN RBAC enabled for the southbound > > database, enabling BFD would lead to permission errors. > > > > The data in the entries in the BFD table do not belong to any > > given

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Fix removal of BFD entry on route deletion

2022-12-07 Thread Numan Siddique
On Tue, Dec 6, 2022 at 7:47 AM Dumitru Ceara wrote: > > On 12/2/22 21:36, Frode Nordahl wrote: > > When creating a route with BFD, ovn-nbctl creates an entry both > > in the Logical_Router_Static_Route and BFD tables. > > > > However, before this patch, removing a route does not remove the > > cor

Re: [ovs-dev] [PATCH ovn 1/7] ic: move routes_ad hmap insert to separate function

2022-12-05 Thread Numan Siddique
On Mon, Dec 5, 2022 at 11:37 AM Dumitru Ceara wrote: > > On 12/2/22 18:31, Vladislav Odintsov wrote: > > This change will be useful in next commit. > > > > Signed-off-by: Vladislav Odintsov > > --- > > Hi Vladislav, > > This looks OK to me but I think I'd squash it in the patch that actually > us

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2022-12-02 Thread Numan Siddique
he patches as RFC. Numan > > Regards, > Vladislav Odintsov > > > On 2 Dec 2022, at 00:20, Numan Siddique wrote: > > > > On Thu, Dec 1, 2022 at 3:58 PM Vladislav Odintsov > <mailto:odiv...@gmail.com>> wrote: > >> > >> Hi, > >> > &g

Re: [ovs-dev] [OVN] Request: v22.03.2 tag

2022-12-01 Thread Numan Siddique
On Thu, Dec 1, 2022 at 10:11 AM Frode Nordahl wrote: > > Hello all, > > We would like to request a new tag in OVN branch-22.03 for a couple of > important issues [0][1], and of course all the other goodness that has > arrived on that branch since the .1 point release in June. > > I guess these day

Re: [ovs-dev] [OVN RFC 0/7] OVN IC bugfixes & proposals/questions

2022-12-01 Thread Numan Siddique
On Thu, Dec 1, 2022 at 3:58 PM Vladislav Odintsov wrote: > > Hi, > > is it possible to consider any of the problems written below and here [0] for > the possible fixes to be included in upcoming OVN/OVS releases? Hi, I didn't get a chance to look at the patches. But if some of them are fixing

Re: [ovs-dev] [PATCH v2 ovn] binding: add the capability to apply QoS for lsp

2022-11-28 Thread Numan Siddique
On Thu, Nov 24, 2022 at 4:33 PM Lorenzo Bianconi wrote: > > Introduce the capability to apply QoS rules for logical switch ports > claimed by ovn-controller. Rely on shash instead of sset for > egress_ifaces. > > Acked-by: Mark Michelson > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=

Re: [ovs-dev] [PATCH v7] ovsdb idl: Add the support to specify the uuid for row insert.

2022-11-27 Thread Numan Siddique
On Tue, Oct 25, 2022 at 5:17 PM Ilya Maximets wrote: > > On 9/26/22 19:52, num...@ovn.org wrote: > > From: Numan Siddique > > > > ovsdb-server allows the OVSDB clients to specify the uuid for > > the row inserts [1]. The C IDL client library is missing this >

Re: [ovs-dev] [PATCH ovn v5 0/2] Allow related traffic for LB

2022-11-25 Thread Numan Siddique
On Fri, Nov 25, 2022 at 4:53 AM Dumitru Ceara wrote: > > On 11/22/22 16:03, Ales Musil wrote: > > The related traffic wasn't correctly forwarded > > through the LB, the main issue was that the > > traffic was not NATted. This series allows > > the NAT to be applied and the traffic should > > arriv

Re: [ovs-dev] [PATCH ovn] ovn-util: Bump OVN internal minor version for new stages.

2022-11-25 Thread Numan Siddique
On Fri, Nov 25, 2022 at 6:18 AM Dumitru Ceara wrote: > > A few logical pipeline stages have been added. The internal minor > version must be bumped every time that happens. > > Fixes: d3926b433e44 ("northd: rely on new actions for lb affinity") > Signed-off-by: Dum

Re: [ovs-dev] [OVN v15] OVN - Add Support for Remote Port Mirroring

2022-11-24 Thread Numan Siddique
On Thu, Nov 24, 2022 at 9:14 AM Abhiram R N wrote: > > Mirror creation just creates the mirror. The lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port Mirroring. > > Note: This is targeted to mirror to destinations anywhere outside the

Re: [ovs-dev] [PATCH ovn] actions: introduce next_table option for CT_COMMIT_V2

2022-11-23 Thread Numan Siddique
On Tue, Oct 25, 2022 at 4:39 PM Lorenzo Bianconi wrote: > > In the current codebase ct_commit {} action clears ct_state metadata of > the incoming packet. This behaviour introduces an issue if we need to > check the connection tracking state in the subsequent pipeline stages, > e.g. for hairpin tr

Re: [ovs-dev] [PATCH ovn] binding: add the capability to apply QoS for lsp

2022-11-23 Thread Numan Siddique
On Tue, Nov 22, 2022 at 5:31 PM Lorenzo Bianconi wrote: > > > Thanks Lorenzo! > > > > Acked-by: Mark Michelson > > > > The only question I have is why you converted to a shash instead of a smap? > > Hi Mark, > > Thx for the review. Do you mean shash instead of sset? > > Regards, > Lorenzo > Than

Re: [ovs-dev] [PATCH ovn branch-22.09] ovs: Bump submodule to include latest fixes.

2022-11-23 Thread Numan Siddique
On Thu, Nov 17, 2022 at 7:38 AM Dumitru Ceara wrote: > > Move the submodule to the tip of OVS branch3.0. This picks up: > 6690ed80c netdev-linux: Fix inability to apply QoS on ports with custom > qdiscs. > > Signed-off-by: Dumitru Ceara Acked-by: Numan Siddique Numan

Re: [ovs-dev] [PATCH ovn] ci: github: Enable address and UB sanitizers for system tests.

2022-11-23 Thread Numan Siddique
On Fri, Nov 18, 2022 at 10:11 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara Acked-by: Numan Siddique Numan > --- > .github/workflows/test.yml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.github/workflows/test.yml b/.github/workflows/test.y

Re: [ovs-dev] [PATCH ovn v6 3/3] northd: add drop sampling

2022-11-23 Thread Numan Siddique
Global options. > - 24 least significant bits: 0. > - obs_point_id: The openflow table number. > > Adding this configuration is not enough to make OVS sample drops. The > apropriate configuration IPFIX needs to be added to those chassis that > you wish to sample from. See man(5)

Re: [ovs-dev] [PATCH ovn v6 2/3] northd: make default drops explicit

2022-11-23 Thread Numan Siddique
al flows and as default > openflow flows (e.g: for physical tables). The only exceptions are > physical tables 68 and 70 that are used to implement chk_lb_hairpin and > ct_snat_to_vip actions and don't drop traffic. > > Signed-off-by: Adrian Moreno Acked-by: Numan Siddique

Re: [ovs-dev] [PATCH ovn v6 1/3] actions: add sample action

2022-11-23 Thread Numan Siddique
ple_Collector_Set table in order to configure IPFIX sampling. > > Signed-off-by: Adrian Moreno Acked-by: Numan Siddique This patch series needs a rebase. Can you please spin up v7 ? Thanks Numan > --- > controller/lflow.c| 1 + > include/ovn/actions.h | 16

Re: [ovs-dev] [PATCH ovn v6 2/2] ovn-controller: Fixed missing flows after interface deletion

2022-11-22 Thread Numan Siddique
On Tue, Nov 22, 2022 at 2:36 AM Han Zhou wrote: > > On Mon, Nov 21, 2022 at 4:40 AM Xavier Simonart wrote: > > > > In the following scenario: > > - interface "old" is created and external_ids:iface-id is set (to lp) > > - interface "new" is created and external_ids:iface-id is set (to same lp) >

Re: [ovs-dev] [PATCH ovn v4 3/3] northd: Add I-P for syncing SB address sets.

2022-11-22 Thread Numan Siddique
On Tue, Nov 22, 2022 at 1:20 AM Han Zhou wrote: > > On Mon, Nov 21, 2022 at 7:50 PM wrote: > > > > From: Numan Siddique > > > > Updates to NB address sets and NB port groups are handled > > incrementally for syncing the SB address sets. This patch > &

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-21 Thread Numan Siddique
On Sat, Nov 19, 2022 at 8:02 PM Han Zhou wrote: > > On Sat, Nov 19, 2022 at 3:35 PM Numan Siddique wrote: > > > > On Sat, Nov 19, 2022 at 6:24 PM Numan Siddique > wrote: > > > > > > On Fri, Nov 18, 2022 at 7:38 PM Han Zhou wrote: > > > > >

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Allow related traffic through LB

2022-11-21 Thread Numan Siddique
On Wed, Nov 16, 2022 at 5:30 AM Ales Musil wrote: > > In order to allow related traffic use the > new action ct_commit_nat, which ensures that > the traffic is commited and NATted. In combination > with match on ct.rel it allows the related traffic > to go through with correct NAT being applied. >

Re: [ovs-dev] [PATCH ovn] northd: Refactor build_lrouter_nat_flows_for_lb function

2022-11-21 Thread Numan Siddique
On Fri, Nov 4, 2022 at 10:14 AM Ales Musil wrote: > > On Fri, Nov 4, 2022 at 2:57 PM Mark Michelson wrote: > > > Hi Ales, > > > > Hi Mark, > thank you for the review. > > > > > > On 10/20/22 10:14, Ales Musil wrote: > > > To avoid make it easier to add flow to this stage refactor > > > the functi

Re: [ovs-dev] [PATCH ovn branch-22.03 1/8] northd, controller: Add timestamp column to MAC_Binding table

2022-11-21 Thread Numan Siddique
On Fri, Nov 4, 2022 at 4:52 AM Ales Musil wrote: > > The new timestamp column in MAC_Binding is > populated with current time whenever the row is > created or the MAC address is updated. > This can be utilized by MAC binding aging mechanism, > when we can check if enough time has passed since the

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-19 Thread Numan Siddique
On Sat, Nov 19, 2022 at 6:24 PM Numan Siddique wrote: > > On Fri, Nov 18, 2022 at 7:38 PM Han Zhou wrote: > > > > On Fri, Nov 18, 2022 at 3:53 PM Han Zhou wrote: > > > > > > > > > > > > On Fri, Nov 18, 2022 at 2:58 PM Numan Siddique wrote:

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-19 Thread Numan Siddique
On Fri, Nov 18, 2022 at 7:38 PM Han Zhou wrote: > > On Fri, Nov 18, 2022 at 3:53 PM Han Zhou wrote: > > > > > > > > On Fri, Nov 18, 2022 at 2:58 PM Numan Siddique wrote: > > > > > > ' > > > > > > On Fri, Nov 18, 2022 at 5:

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-18 Thread Numan Siddique
' On Fri, Nov 18, 2022 at 5:44 PM Numan Siddique wrote: > > > > > On Fri, Nov 18, 2022, 4:55 PM Han Zhou wrote: >> >> On Fri, Nov 18, 2022 at 1:47 PM Numan Siddique wrote: >> > >> > On Fri, Nov 18, 2022 at 3:46 PM Han Zhou wrote: >> &g

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-18 Thread Numan Siddique
On Fri, Nov 18, 2022, 4:55 PM Han Zhou wrote: > On Fri, Nov 18, 2022 at 1:47 PM Numan Siddique wrote: > > > > On Fri, Nov 18, 2022 at 3:46 PM Han Zhou wrote: > > > > > > On Fri, Nov 18, 2022 at 11:23 AM Numan Siddique > wrote: > > > > > &g

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-18 Thread Numan Siddique
On Fri, Nov 18, 2022 at 3:46 PM Han Zhou wrote: > > On Fri, Nov 18, 2022 at 11:23 AM Numan Siddique wrote: > > > > On Fri, Nov 18, 2022 at 11:27 AM Numan Siddique wrote: > > > > > > ' > > > > > > On Fri, Nov 18, 2022 at 2:14 AM Han Z

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-18 Thread Numan Siddique
On Fri, Nov 18, 2022 at 11:27 AM Numan Siddique wrote: > > ' > > On Fri, Nov 18, 2022 at 2:14 AM Han Zhou wrote: > > > > On Tue, Nov 15, 2022 at 7:19 AM wrote: > > > > > > From: Numan Siddique > > > > > > Updates to NB address se

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Add I-P for syncing SB address sets.

2022-11-18 Thread Numan Siddique
' On Fri, Nov 18, 2022 at 2:14 AM Han Zhou wrote: > > On Tue, Nov 15, 2022 at 7:19 AM wrote: > > > > From: Numan Siddique > > > > Updates to NB address sets and NB port groups are handled > > incrementally for syncing the SB address sets. This patch &

Re: [ovs-dev] [PATCH ovn v3 1/2] northd IP: Add a new engine node 'en_sb_sync' to sync SB tables.

2022-11-18 Thread Numan Siddique
On Fri, Nov 18, 2022 at 1:37 AM Han Zhou wrote: > > On Tue, Nov 15, 2022 at 7:19 AM wrote: > > > > From: Numan Siddique > > > > A sub-engine node 'en_address_set_sync' is added with-in the > > 'en_sb_sync' node to sync the Address_Set tab

Re: [ovs-dev] [PATCH ovn v5 0/3] Add ovn drop debugging

2022-11-18 Thread Numan Siddique
On Fri, Nov 18, 2022 at 9:56 AM Dumitru Ceara wrote: > > On 11/15/22 10:49, Ales Musil wrote: > > On Fri, Nov 4, 2022 at 4:50 PM Adrian Moreno wrote: > > > >> Very often when troubleshooting networking issues in an OVN cluster one > >> would like to know if any packet (or a specific one) is being

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-16 Thread Numan Siddique
se checks that there is no conntrack entry for the stateless traffic. Existing system tests should give you a good reference. Let me know if you have any questions. Numan > regards, > > -venu > > ____ > From: Numan Siddique > Sent: Monday,

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add I-P for syncing SB address sets.

2022-11-15 Thread Numan Siddique
On Tue, Nov 15, 2022 at 11:10 AM Mark Michelson wrote: > > On 11/14/22 16:34, Numan Siddique wrote: > > On Mon, Nov 14, 2022 at 3:23 PM Mark Michelson wrote: > >> > >> Hi Numan, I have just one minor suggestion below. > >> > >> On 11/14/22 11:48,

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Add I-P for syncing SB address sets.

2022-11-14 Thread Numan Siddique
On Mon, Nov 14, 2022 at 3:23 PM Mark Michelson wrote: > > Hi Numan, I have just one minor suggestion below. > > On 11/14/22 11:48, num...@ovn.org wrote: > > From: Numan Siddique > > > > Updates to NB address sets and NB port groups are handled > > increment

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-14 Thread Numan Siddique
On Wed, Nov 9, 2022 at 4:15 PM Numan Siddique wrote: > > On Wed, Nov 9, 2022 at 4:11 PM Han Zhou wrote: > > > > On Tue, Nov 8, 2022 at 7:51 AM venu.iyer wrote: > > > > > > Currently, even stateless flows are subject to connection tracking when > > th

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-09 Thread Numan Siddique
On Wed, Nov 9, 2022 at 4:11 PM Han Zhou wrote: > > On Tue, Nov 8, 2022 at 7:51 AM venu.iyer wrote: > > > > Currently, even stateless flows are subject to connection tracking when > there are > > LB rules (for DNAT). However, if a flow needs to be subjected to LB, then > it shouldn't > > be config

Re: [ovs-dev] [PATCH ovn v3 0/4] Send Rarps for ipv6 router lsp

2022-11-08 Thread Numan Siddique
On Fri, Nov 4, 2022 at 5:00 AM Felix Hüttner via dev wrote: > > previously garps/rarps where only sent for "external" lsp's if these > had an ipv4 address attached. For lsp's on gateway routers that do > not have an ipv4 address assigned (e.g. if they are ipv6 only) no > rarps were send out. > > T

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-03 Thread Numan Siddique
On Thu, Nov 3, 2022 at 7:10 AM Xavier Simonart wrote: > > On Wed, Nov 2, 2022 at 3:31 PM Dumitru Ceara wrote: > > > On 11/2/22 15:21, Numan Siddique wrote: > > > On Wed, Nov 2, 2022 at 7:39 AM Xavier Simonart > > wrote: > > >> > > >> Hi N

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-02 Thread Numan Siddique
On Wed, Nov 2, 2022 at 7:39 AM Xavier Simonart wrote: > > Hi Numan, Dumitru > > Thanks for looking at this patch and for your feedback. > > > On Tue, Nov 1, 2022 at 10:41 PM Numan Siddique wrote: > > > On Fri, Oct 28, 2022 at 11:36 AM Dumitru Ceara wrote: > &g

Re: [ovs-dev] [PATCH ovn v3] ovn-controller: Fix some issues with CT zone assignment.

2022-11-01 Thread Numan Siddique
get_zone_num "$ct_zones" ls0-hv1) > +port2_zone=$(get_zone_num "$ct_zones" ls0-hv2) > +snat_zone=$(get_zone_num "$ct_zones" ${lr_uuid}_snat) > + > +check test "$snat_zone" -eq "$snat_req_zone" > +check test "$port1_zone" -ne

Re: [ovs-dev] [PATCH ovn 0/4] Send Rarps for ipv6 router lsp

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev wrote: > > previously garps/rarps where only sent for "external" lsp's if these > had an ipv4 address attached. For lsp's on gateway routers that do > not have an ipv4 address assigned (e.g. if they are ipv6 only) no > rarps were send out. > >

Re: [ovs-dev] [PATCH ovn 4/4] pinctrl: Send RARPs for external ipv6 interfaces

2022-11-01 Thread Numan Siddique
t; > This change has been tested in an environment with 600 logical routers > on a single ipv6 external network. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > controller/pinctrl.c | 23 + > tests/ovn.at | 80 +

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:48 AM Felix Hüttner via dev wrote: > > in order to easily add future ipv6 test cases the common `ovn_attach` > function should also support ipv6 addresses. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > tes

Re: [ovs-dev] [PATCH ovn 2/4] northd: handle own rarps like garps

2022-11-01 Thread Numan Siddique
hanges done, you can add my Acked-by tag in the next version Acked-by: Numan Siddique Numan > --- > northd/northd.c | 9 + > northd/ovn_northd.dl | 2 +- > tests/ovn-northd.at | 18 +- > tests/ovn.at | 8 +++- > 4 files changed, 22

Re: [ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev wrote: > > We need to be able to handle rarp fields in order to ensure we can > handle rarp messages we send ourselves. > This will be used by the next patch in the series. > > Signed-off-by: Felix Huettner Acked-by: Numa

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-01 Thread Numan Siddique
On Fri, Oct 28, 2022 at 11:36 AM Dumitru Ceara wrote: > > Hi Xavier, > > On 10/24/22 17:21, Xavier Simonart wrote: > > In the following scenario: > > - interface "old" is created and external_ids:iface-id is set (to lp) > > - interface "new" is created and external_ids:iface-id is set (to same lp)

Re: [ovs-dev] [PATCH ovn v4 2/3] northd: make default drops explicit

2022-11-01 Thread Numan Siddique
On Mon, Oct 17, 2022 at 9:15 AM Adrian Moreno wrote: > > By default, traffic that doesn't match any configured flow will be dropped. > But having that behavior implicit makes those drops more difficult to > visualize. > > Make default drops explicit both as default logical flows and as default > o

Re: [ovs-dev] [PATCH ovn v4 1/3] actions: add sample action

2022-11-01 Thread Numan Siddique
On Mon, Oct 17, 2022 at 9:14 AM Adrian Moreno wrote: > > sample ovn action encodes into the OFPACT_SAMPLE ovs action. > > OVN action allows the following parameters: > > - obs_domain_id: 8-bit integer that identifies the sampling application. > This value will be combined with the datapath's tun

Re: [ovs-dev] [PATCH ovn] util: Avoid double parsing of LB vip and backend ip

2022-10-18 Thread Numan Siddique
rectly from "sockaddr_storage". > > Signed-off-by: Ales Musil Thanks for the patch. LGTM. Can you please also update the function comments in lib/ovn-util.c now that the function also sets 'struct in6_addr *ip'. Acked-by: Numan Siddique Numan > --- > lib/lb.

Re: [ovs-dev] [PATCH ovn] controller: Remove unused shash from update_ct_zone

2022-10-18 Thread Numan Siddique
On Wed, Oct 12, 2022 at 3:32 PM Mark Michelson wrote: > > Wow, this shash has been unused since branch-21.06 . Good find! > > Acked-by: Mark Michelson Thanks. Applied to the main branch. Numan > > On 10/12/22 04:07, Ales Musil wrote: > > Signed-off-by: Ales Musil > > --- > > controller/ovn

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-10-10 Thread Numan Siddique
fa:16:3e:4c:e6:1f,dst=fa:16:3e:c9:a7:6b),eth_type(0x0800),ipv4(src=192.168.210.103,dst=1.1.1.254,proto=6,tos=0/0,ttl=64,frag=no),tcp(src=0/0,dst=0/0), > packets:2, bytes:148, used:3.230s, offloaded:yes, dp:tc, > actions:set(eth(src=fa:16:3e:ae:b5:e5,dst=8c:1f:64:30:61:43)),set(ipv4(t

Re: [ovs-dev] [PATCH ovn] spec: require python3-openvswitch for ovn-detrace

2022-10-05 Thread Numan Siddique
On Tue, Oct 4, 2022 at 5:41 AM Dumitru Ceara wrote: > > On 9/21/22 15:36, Vladislav Odintsov wrote: > > Signed-off-by: Vladislav Odintsov > > --- > > Hi Vladislav, > > > rhel/ovn-fedora.spec.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rhel/ovn-fedora.spec.in b/rhel/ovn-fedo

Re: [ovs-dev] [PATCH ovn v3] northd: Use separate SNAT for already-DNATted traffic.

2022-09-28 Thread Numan Siddique
tage is reached, a > separate CT zone is used for SNAT. > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > v2 -> v3: > * Rebased on top of current main branch > * Fixed checkpatch issues from v2. > * Accounted for the ct_label -> ct_ma

Re: [ovs-dev] [OVN v6] OVN - Add Support for Remote Port Mirroring

2022-09-27 Thread Numan Siddique
On Sun, Sep 11, 2022 at 10:26 AM Abhiram R N wrote: > > Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. > While Mirror creation just creates the mirror, the lsp-attach-mirror > triggers the sequence to create Mirror in OVS DB on compute node. > OVS already supports Port Mirror

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: Add Dumitru Ceara.

2022-09-21 Thread Numan Siddique
On Wed, Sep 21, 2022 at 11:33 AM Dumitru Ceara wrote: > > On 9/21/22 16:03, Mark Michelson wrote: > > Acked-by: Mark Michelson > > > > Congrats, Dumitru! Thanks. Applied to main. Congrats, Dumitru ! Numan > > > > On 9/21/22 07:20, num...@ovn.

Re: [ovs-dev] [PATCH ovn] lb: Remove unused ovn_northd_lb_vip vip_port_str member.

2022-09-20 Thread Numan Siddique
On Mon, Sep 19, 2022 at 2:06 AM Ales Musil wrote: > > On Fri, Aug 26, 2022 at 2:35 PM Dumitru Ceara wrote: > > > Signed-off-by: Dumitru Ceara > > --- > > lib/lb.c | 5 + > > lib/lb.h | 1 - > > 2 files changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/lib/lb.c b/lib/lb.c > > inde

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

2022-09-16 Thread Numan Siddique
On Fri, Sep 16, 2022 at 11:59 AM Numan Siddique wrote: > > On Tue, Sep 13, 2022 at 7:34 AM Ilya Maximets wrote: > > > > Every time a new logical flow is created, ovn-northd creates an > > exclusive hash map to collect all the datapaths this logical flow is > > appl

Re: [ovs-dev] [PATCH ovn branch-22.09 2/2] Prepare for 22.09.1.

2022-09-16 Thread Numan Siddique
On Fri, Sep 16, 2022 at 11:38 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.0.

2022-09-16 Thread Numan Siddique
On Fri, Sep 16, 2022 at 11:38 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique I'm sure you're already aware of it (but just as a reminder) that this patch should also be merged to the main branch. Thanks Numan > --- > NEWS

Re: [ovs-dev] [PATCH ovn branch-22.03] Allow for setting the Next server IP in the DHCP header

2022-09-16 Thread Numan Siddique
l DHCP option but a > special use case in OVN. > > [0] > https://github.com/openvswitch/ovs/blob/9dd3031d2e0e9597449e95428320ccaaff7d8b3d/lib/dhcp.h#L42 > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2083629 > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

2022-09-16 Thread Numan Siddique
ces. However, 'n_datapaths' is used practically > everywhere, including ovn_lflow_add(), so we'll have to pass it around > in most of the functions in northd as an argument. Taking that into > account, I decided to make them both global to avoid touching half of > th

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
h/20220908140644.2647859-1-odiv...@gmail.com/ > > Regards, > Vladislav Odintsov > > > On 16 Sep 2022, at 02:25, Vladislav Odintsov wrote: > > > > Ok, > > I’ll correct patch and resend v2. > > > > Regards, > > Vladislav Odintsov > &

Re: [ovs-dev] [PATCH ovn v3 0/4] northd: Optimize preparation of load balancers.

2022-09-15 Thread Numan Siddique
On Tue, Sep 13, 2022 at 1:19 PM Han Zhou wrote: > > On Mon, Sep 12, 2022 at 3:25 AM Dumitru Ceara wrote: > > > > On 9/9/22 23:32, Ilya Maximets wrote: > > > Re-compute of 'northd' node in ovn-northd may take almost half of the > > > total processing time in case there is a big number of load bala

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
,nw_frag=no > Datapath actions: drop > > [root@dev1 ~]# ovn-nbctl show public > switch 633ad6c1-f3e5-4f31-b2fe-215203cf5272 (public) > port p-port1 > addresses: ["50:54:00:00:00:03 172.16.0.100"] > port ln-public > type: localnet >

Re: [ovs-dev] stateless acl on ovn-k8s interface

2022-09-15 Thread Numan Siddique
On Tue, Sep 13, 2022 at 6:41 PM venugopal iyer via dev wrote: > > Hi, Han, Numan: > While testing a use case in our ovn-k8s cluster we ran into an issue where > wecouldn't effectively use stateless ACL on the OVN interface. Turns out we > will track > all the packets here, since there will be a

Re: [ovs-dev] [PATCH ovn] northd: don't include disabled LSP's IP to Load Balancing

2022-09-15 Thread Numan Siddique
On Mon, Sep 12, 2022 at 6:11 PM Vladislav Odintsov wrote: > > If one has a UDP load balancer with backend IP which is located under > disabled LSP, such backend would be threated as alive and marked as > 'online' on Service_Monitor table and added to load balancing as well. > Though such LSP can't

Re: [ovs-dev] [PATCH ovn] northd: Don't get stuck in the STATE_INIT_HASH_SIZES state.

2022-09-15 Thread Numan Siddique
On Fri, Sep 9, 2022 at 4:00 AM Ilya Maximets wrote: > > On 8/25/22 11:03, Dumitru Ceara wrote: > > On 8/24/22 18:32, Ilya Maximets wrote: > >> On 8/24/22 17:57, Dumitru Ceara wrote: > >>> On 8/24/22 17:49, Ilya Maximets wrote: > On 8/24/22 17:43, Ilya Maximets wrote: > > On 8/23/22 16:42,

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
livered to p-public. Thanks Numan > > Regards, > Vladislav Odintsov > > > On 15 Sep 2022, at 15:42, Numan Siddique wrote: > > > > On Thu, Sep 8, 2022 at 7:41 AM Vladislav Odintsov > <mailto:odiv...@gmail.com>> wrote: > >> > >> Prior to thi

Re: [ovs-dev] [PATCH ovn] northd: drop traffic to disabled LSPs in ingress pipeline

2022-09-15 Thread Numan Siddique
On Thu, Sep 8, 2022 at 7:41 AM Vladislav Odintsov wrote: > > Prior to this patch traffic to LSPs, which are disabled with > `ovn-nbctl lsp-set-enabled disabled` was dropped in the end of > lswitch egress pipeline. This means that traffic is processed in vain: > - traffic, which should be dropped

Re: [ovs-dev] [PATCH ovn] northd: Accumulate more database updates before processing.

2022-09-12 Thread Numan Siddique
ovnnb_cond_seqno = new_ovnnb_cond_seqno; > > } > > > > - struct ovsdb_idl_txn *ovnsb_txn = > > -ovsdb_idl_loop_run(&ovnsb_idl_loop); > > +struct ovsdb_idl_txn *ovnsb_txn = > run_i

Re: [ovs-dev] [PATCH ovn] northd: Always propagate LB proto to lflows

2022-09-09 Thread Numan Siddique
On Fri, Sep 9, 2022 at 2:11 AM Ales Musil wrote: > > On Fri, Sep 9, 2022 at 7:43 AM Han Zhou wrote: > > > > > > > On Tue, Sep 6, 2022 at 6:02 AM Ales Musil wrote: > > > > > > The current behavior is that load balancers > > > default to tcp protocol if it is not specified. > > > However, this is

Re: [ovs-dev] [PATCH ovn] northd: don't add drop lflow if LB VIP matches LRP IP

2022-09-06 Thread Numan Siddique
On Wed, Aug 31, 2022 at 9:17 AM Vladislav Odintsov wrote: > > Please, add this tag before applying the patch: > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2022-August/052021.html I'm sorry. I missed adding this tag before applying the patch. I also backported to branch

Re: [ovs-dev] [ovn] Conntrack zone is not flushed on PB release

2022-09-06 Thread Numan Siddique
On Tue, Sep 6, 2022 at 2:40 PM Vladislav Odintsov wrote: > > Hi, > > we’ve noticed that after port binding is released, the conntrack entries in > the associated to deleted port-binding zone are left in conntrack. > I’ve ran through the code, it seems that conntrack zone flushing after port > bi

Re: [ovs-dev] [PATCH ovn v2 2/2] Prepare for post-22.09.0

2022-08-30 Thread Numan Siddique
, 10 insertions(+), 1 deletion(-) > > LGTM, > Acked-by: Ilya Maximets Looks like the branch-22.09 is not yet created. For the entire series : Acked-by: Numan Siddique Numan > ___ > dev mailing list > d...@openvswitch

Re: [ovs-dev] [PATCH ovn v3 2/5] binding.c: Missing local_datapath update in runtime_data port_binding handler.

2022-08-19 Thread Numan Siddique
On Fri, Aug 19, 2022 at 10:42 AM Han Zhou wrote: > > On Thu, Aug 18, 2022 at 5:21 PM Han Zhou wrote: > > > > When handling port_binding changes, it is possible that new > > local_datapaths are added, and the fields of the local_datapath, such as > > localnet_port, external_ports, etc. need to be

Re: [ovs-dev] [PATCH ovn v3 1/5] binding.c: Avoid checking OVSDB tracking status in handle_updated_port.

2022-08-19 Thread Numan Siddique
it is risky if the OVSDB IDL implementation changes. > > Fixes: 3103487e087b ("Split out code to handle port binding db updates") > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > controller/binding.c | 10 +- > 1 file changed, 5 insertions(+),

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Numan Siddique
ps://github.com/numansiddique/ovn/runs/7891302586?check_suite_focus=true Please also add documentation in ovn-northd.8.xml about the new logical flows you'd be adding, fix any existing test case failures and also add a system test if possible. Thanks Numan > Wentao Jia > >

Re: [ovs-dev] [OVN PATCH] northd: add unsnat/undnat lflow for established connections

2022-08-17 Thread Numan Siddique
0.102" > type: "dnat_and_snat" > nat 88b9371b-a058-46b5-91f9-6741edf3391a > external ip: "1.1.1.124" > logical ip: "192.168.210.0/24" > type: "snat" > nat f9843d73-341a-4557-b996-ced76b4fa

Re: [ovs-dev] [PATCH ovn] system-ovn.at: add connectivity test between container port and parent one

2022-08-17 Thread Numan Siddique
On Thu, Aug 18, 2022 at 3:47 AM Lorenzo Bianconi wrote: > > Introduce system test for the following fix: > 'd9f69b2d7 ("controller: physical: fix regression for container ports")' Thanks for the follow up patch to add the test case. I applied this to the main branch. Numan > > Signed-off-by: L

<    1   2   3   4   5   6   7   8   9   10   >