Re: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation

Hi Alin, I don't see a big value from this patch if I understand it correctly. Firstly, your commit is not clear about what it means when it says "typing it later on". Are you referring to typing it later on in the documentation? Secondly, since Hyper-V has different switch types such as

Re: [ovs-dev] [PATCH] windows: netdev report error if query failed

Acked-By: Shashank Ram <r...@vmware.com> From: ovs-dev-boun...@openvswitch.org <ovs-dev-boun...@openvswitch.org> on behalf of Alin Serdean <aserd...@cloudbasesolutions.com> Sent: Tuesday, February 7, 2017 10:41:24 PM To: d...@openvswitch.org

Re: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation

From: Alin Serdean <aserd...@cloudbasesolutions.com> Sent: Sunday, February 5, 2017 3:12:57 PM To: Shashank Ram; d...@openvswitch.org Subject: RE: [PATCH 4/4] doc-windows: Consolidate switch names in documentation Hi Shashank, Thanks for reviewing the patch! The main problem is we have two swit

[ovs-dev] [PATCH v2] datapath-windows: Add a wrapper to retreive external vport

This wrapper is to simplify readability. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Actions.c | 8 datapath-windows/ovsext/PacketIO.c | 6 +++--- datapath-windows/ovsext/Vport.c| 6 ++ datapath-windows/ovsext/Vport.h| 2 ++ 4 files chang

[ovs-dev] [PATCH v3] datapath-windows: Add a wrapper to retreive external vport

This wrapper is to simplify readability. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Actions.c | 8 datapath-windows/ovsext/PacketIO.c | 6 +++--- datapath-windows/ovsext/Vport.c| 6 ++ datapath-windows/ovsext/Vport.h| 2 ++ 4 files chang

[ovs-dev] [PATCH] vswitchd: Move config_ofproto_types call before bridge_add_port

list. Once the dpif_backer is added, the call to config_ofproto_types() will ensure that the set_config handler in dpif-netdev/netlink.c is called. Signed-off-by: Shashank Ram <r...@vmware.com> --- vswitchd/bridge.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vs

Re: [ovs-dev] [PATCH v2 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

Hi Anand, following are my comments: 1. Since you are just using a RW lock without specifically differentiating between and read and write protection, you could use a spin lock instead. Spin locks in general are recommended if all you want is a lock. 2. Instead of running the fragment cleaner

[ovs-dev] [PATCH v2] datapath-windows: Avoid busy wait in OvsStartIpHelper

is determined by this counter value, we need to reset the counter back correctly once the request has been consumed by the IP Helper thread. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/IpHelper.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH] datapath-windows: Avoid busy wait in OvsStartIpHelper

is determined by this counter value, we need to reset the counter back correctly once the request has been consumed by the IP Helper thread. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/IpHelper.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[ovs-dev] [PATCH] datapath-windows: Fix issues related to packet completion

. Instead, we should keep the forwarding detail of the original packet as is, and only update the forwarding detail for the newNbl. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Actions.c | 25 - 1 file changed, 20 insertions(+), 5 del

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength()

Acked-by: Shashank Ram <r...@vmware.com> From: Sairam Venugopal <vsai...@vmware.com> Sent: Friday, December 9, 2016 10:48:23 AM To: Shashank Ram Cc: Sairam Venugopal Subject: [PATCH 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLe

Re: [ovs-dev] [PATCH] datapath-windows: Add a wrapper to check for external vport

hursday, January 12, 2017 8:27:22 AM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Add a wrapper to check for external vport Hi, Thanks for the patch. Is this part of a series or is it a standalone patch? I don't see the added value to add the wrapper j

[ovs-dev] [PATCH] datapath-windows: Add a wrapper to check for external vport

Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Vport.c | 6 ++ datapath-windows/ovsext/Vport.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index e9e22aa..9142937 100644 --- a/da

Re: [ovs-dev] [PATCH v2] Windows: Implement Hyper-V VIF discovery agent.

Hi Yin, thanks for your changes. Would it be possible for you to split this feature into smaller, easier to review commits? Also, please also mention in the commit message how you tested out different scenarios, and what will be the impact on existing Vif addition workflow etc. Thanks!

Re: [ovs-dev] [PATCH v2] datapath-windows: Avoid busy wait in OvsStartIpHelper

3, 2016 1:14:39 PM To: Yin Lin; Shashank Ram; Nithin Raju; Sairam Venugopal Cc: d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: Avoid busy wait in OvsStartIpHelper Hi Shashank, Thanks a lot for the patch! My only concern is that this issue has already been addres

Re: [ovs-dev] [PATCH] Fix the memleak in Netflow. The memleak was trigged each time creating a netflow and deleting it then.

Hi, could you format the commit message to have the title and description in separate lines as shown below. """ ofproto-dpif-xlate.c: Fix a memory leak in Netflow The memory leak was triggered each time on creating a netflow and subsequently deleting it. Signed-off-by: Sha Zhang

Re: [ovs-dev] [PATCH] windows: Crash when the handle communication device cannot be found

From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, March 9, 2017 1:58 AM To: Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] windows: Crash when

Re: [ovs-dev] [PATCH] datapath-windows: Trigger conntrack event after setting mark and label

Thanks Sai for the change. I was wondering if you could add a helper function to lookup the OVS_CT_ENTRY that got added to the OvsConntrackKeyLookupCtx list, instead of passing a boolean around to functions. i.e replace "entryCreated" with "IsEntryCreated()". Thanks, Shashank

Re: [ovs-dev] [PATCH] datapath-windows: Trigger conntrack event after setting mark and label

Discussed with Sai offline. Since the Event needs to be fired just the first time the CtEntry is created, he is using a bool for it. Acked-by: Shashank Ram <r...@vmware.com> From: Sairam Venugopal Sent: Tuesday, March 7, 2017 10:16:54 AM To: Shashank

Re: [ovs-dev] [PATCH] datapath-windows: Fix conntrack lookups for reversed keys

s not equal to - * rev_key due to NAT effect. - */ -OvsCtKeyReverse(); -if (OvsCtKeyAreSame(key, entry->key)) { +if (OvsCtKeyAreSame(revCtxKey, entry->key)) { found = entry; reply = TRUE; break; -- 2.9.3.windows.1 ______

Re: [ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

Guru, could you please apply this patch. Thanks, Shashank From: Anand Kumar Sent: Thursday, July 27, 2017 4:48:02 PM To: Shashank Ram; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

Re: [ovs-dev] [PATCH] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

mar <kumaran...@vmware.com> ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] socket-util: Avoid using sendmsg on Windows

s, unsigned int n, unsigned int flags) return emulate_sendmmsg(fd, msgs, n, flags); } #endif +#endif -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d.

Re: [ovs-dev] [PATCH 16/40] datapath-windows: Add function annotations for OvsAcquireDatapathWrite

LOCK_STATE_EX *lockState, -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 18/40] datapath-windows: Add function annotations for OvsCancelIrp

eventQueueLockArr[OVS_MCAST_EVENT_TYPES_MAX]; UINT32 ovsNumEventQueueArr[OVS_MCAST_EVENT_TYPES_MAX]; +DRIVER_CANCEL OvsCancelIrp; NTSTATUS OvsInitEventQueue() -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> __

Re: [ovs-dev] [PATCH 33/40] datapath-windows: Check return status when using APIs

T_SUCCESS(status)) { goto error; } NdisAcquireRWLockRead(gOvsSwitchContext->dispatchLock, , 0); -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...

Re: [ovs-dev] [PATCH 11/40] datapath-windows: Add an assert in recirculation

{ -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 22/40] datapath-windows: Add annotations for OvsReleaseEventQueueLock

atic __inline VOID OvsReleaseEventQueueLock(int eventId) { -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 23/40] datapath-windows: Add annotations for OvsReleasePidHashLock

pidHashLock) static __inline VOID OvsReleasePidHashLock() { -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 30/40] datapath-windows: Add dummy parameter for NotifyRouteChange2

.", -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 36/40] datapath-windows: Add annotation for OvsCtRelatedEntryCleaner

elatedEntryCleaner, ); if (status != STATUS_SUCCESS) { -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 08/40] datapath-windows: Suppress PAGED_CODE warnings

8) PAGED_CODE(); #ifdef DBG POVS_DEVICE_EXTENSION ovsExt = -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 09/40] datapath-windows: Fix possible NULL dereference in BufferMgmt

ASSERT(mdl->Next == NULL); -OvsFreeMDLAndData(mdl); nbTemp = NET_BUFFER_NEXT_NB(nbTemp); } } -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com>

Re: [ovs-dev] [PATCH 20/40] datapath-windows: Add function annotations for OvsCancelIrpDatapath

lowTunnelKeyPolicy[]; extern UINT32 nlFlowTunnelKeyPolicyLen; +DRIVER_CANCEL OvsCancelIrpDatapath; static __inline VOID OvsAcquirePidHashLock() -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> __

Re: [ovs-dev] [PATCH 12/40] datapath-windows: Add annotations for OvsAcquireCtrlLock

eCtrlLock(); VOID OvsReleaseCtrlLock(); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 17/40] datapath-windows: Add function annotations for OvsReleaseDatapath

VOID OvsReleaseDatapath(OVS_DATAPATH *datapath, LOCK_STATE_EX *lockState) -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https:

Re: [ovs-dev] [PATCH 29/40] datapath-windows: Suppress warning in jhash

ing(suppress: 6385) +/* Suppress buffer overflow, it is either zero or some random value */ c += tmp[2]; JhashFinal(, , ); } -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___

Re: [ovs-dev] [PATCH 40/40] datapath-windows: Fix static analysis warnings around ovsInstanceListLock

Comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH 35/40] datapath-windows: Treat TCP_HDR_LEN static analysis warnings

)(ntohs(iph->tot_len) -\ IP4_HDR_LEN(iph) - TCP_HDR_LEN(tcph)) -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailin

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

Alin, thanks a lot for this important series! Could you please test out all these changes with Driver verifier and ensure that it does not introduce new regressions such as memory leaks, deadlocks etc. Thanks, Shashank From:

Re: [ovs-dev] [PATCH 06/40] datapath-windows: Fix aligment in Stt

IPPROTO_TCP, 0); } else { IPv6Hdr *ipHdr; TCPHdr *tcpHdr; -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 05/40] datapath-windows: Fix possible NULL dereference in IpFragment

This will result in a memory leak, comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To:

Re: [ovs-dev] [PATCH 07/40] datapath-windows: Add asserts to Stt

gEntry->sttHdr = *sttHdr; } if (ipHdr->ecn == IP_ECN_CE) { -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com>= ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 19/40] datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp

est); -static VOID OvsTunnelFilterCancelIrp(PDEVICE_OBJECT DeviceObject, - PIRP Irp); +DRIVER_CANCEL OvsTunnelFilterCancelIrp; /* * Callout driver global variables -- 2.10.2.windows.1 ___ Acked-by: Shashank Ra

Re: [ovs-dev] [PATCH 04/40] datapath-windows: interfaceName overflow in IpHelper

________ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 10/40] datapath-windows: Fix possible NULL deference

From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH 10/40] datapath-windows: Fix

Re: [ovs-dev] [PATCH 24/40] datapath-windows: Add annotations for OvsAcquirePidHashLock

) { -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 27/40] datapath-windows: Add assert in OvsPartialCopyNBL

- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 01/40] datapath-windows: Use only non executable memory

Comments inline. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Thursday, July 13, 2017 9:40 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH 26/40] datapath-windows: Use annotations instead for macros

g(VOID *ptr, ULONG tag); -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 31/40] datapath-windows: prettify logging in iphelper

t;, status); +OVS_LOG_ERROR("Fail to register UNICAST IP change, status: %x.", >> s/Fail/Failed + status); } register_cleanup: if (status != STATUS_SUCCESS) { -- 2.10.2.windows.1 __

Re: [ovs-dev] [PATCH 02/40] datapath-windows: Use non-executable memory when allocating memory

nPagedPoolNx, size, OVS_MEMORY_TAG, NormalPoolPriority); } -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> __

Re: [ovs-dev] [PATCH 13/40] datapath-windows: Add annotations for OvsReleaseCtrlLock

Irql, gOvsCtrlLock) +_Requires_lock_held_(gOvsCtrlLock) +_Releases_lock_(gOvsCtrlLock) VOID OvsReleaseCtrlLock(); /* -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d.

Re: [ovs-dev] [PATCH 14/40] datapath-windows: Remove function declarations from Tunnel.c

const GUID *filterKey, -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 28/40] datapath-windows: Fix possible NULL deference in OvsFullCopyNBL

t, } nb = NET_BUFFER_LIST_FIRST_NB(nbl); +if (nb == NULL) { +return NULL; +} if (NET_BUFFER_NEXT_NB(nb) == NULL) { return OvsCopySinglePacketNBL(context, nbl, nb, headRoom, copyNblInfo); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ra

Re: [ovs-dev] [PATCH 21/40] datapath-windows: Add function annotations for OvsAcquireEventQueueLock

} +_IRQL_raises_(DISPATCH_LEVEL) +_IRQL_saves_global_(OldIrql, eventQueueLockArr[eventId]) +_Acquires_lock_(eventQueueLockArr[eventId]) static __inline VOID OvsAcquireEventQueueLock(int eventId) { -- 2.10.2.windows.1 ___ Acked-by: Shashank Ra

Re: [ovs-dev] [PATCH 34/40] datapath-windows: Vport check RtlStringCbLengthW return value

l to convert interface LUID to alias, status: %x", -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 38/40] datapath-windows: Fix shared variables which use Interlocked functions

___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 37/40] datapath-windows: Add annotation for OvsIpFragmentEntryCleaner

ns */ -static VOID OvsIpFragmentEntryCleaner(PVOID data); +static KSTART_ROUTINE OvsIpFragmentEntryCleaner; static VOID OvsIpFragmentEntryDelete(POVS_IPFRAG_ENTRY entry, BOOLEAN checkExpiry); /* Global and static variables */ -- 2.10.2.windows.1 ___ Acked-b

Re: [ovs-dev] [PATCH 03/40] datapath-windows: Remove annotations in Switch.c

erRestart function. * -- */ -_Use_decl_annotations_ NDIS_STATUS OvsExtRestart(NDIS_HANDLE filterModuleContext, PNDIS_FILTER_RESTART_PARAMETERS filterRestartParameters) -- 2.10.2.windows.1 ___ Acked-by: Shashank Ra

Re: [ovs-dev] [PATCH 15/40] datapath-windows: Add function annotations for OvsAcquireDatapathRead

, -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 25/40] datapath-windows: Fix spelling for OvsTunnelFilterSetIrpContext

+ * case the IRP is canceled. * -- */ VOID -- 2.10.2.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mai

Re: [ovs-dev] [PATCH 32/40] datapath-windows: fix excessive stack usage in iphelper

esolveIPNeigh(internalRow, +status = OvsGetOrResolveIPNeigh(>internalRow, ipAddr, ); OvsUpdateIPNeighEntry(ipAddr, , status); -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.

[ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

, and it returns a linked list of NBLs and sets the HEAD and TAIL of the new list obtained from the curNbl. If the caller wants to chain a new linked list at the HEAD or TAIL, it can make use of the curNbl and lastNbl to do so. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/

Re: [ovs-dev] [PATCH] datapath-windows: Fix a bug in OvsCreateNewNBLsFromMultipleNBs()

I will hold onto this patch a bit longer. Noticed that there are other bugs that get exposed as a result of this bug fix. Will send out a v2. Thanks, Shashank From: Shashank Ram <r...@vmware.com> Sent: Friday, July 21, 2017 11:57:44 AM

Re: [ovs-dev] DNS support options

From: ovs-dev-boun...@openvswitch.org on behalf of Lance Richardson Sent: Tuesday, August 8, 2017 11:59 AM To: Ben Pfaff Cc: d...@openvswitch.org Subject: Re: [ovs-dev] DNS support options >

Re: [ovs-dev] [PATCH v3] datapath-windows: Update Orig Tuple to use ICMP Type and Code

kumaran...@vmware.com> --- _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

mar <kumaran...@vmware.com> --- ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

To: Alin Serdean; Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt I think the same effect can be achieved using this incremental: --- datapath-windows/ovsext/ovsext.rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

solutions.com> Sent: Monday, May 15, 2017 1:50:09 PM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt Thanks a lot for the patch. I had to double look the changes. It may be worth adding to the commit message that this

Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

Thanks for the patch, please find comments inline. From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Tuesday, June 20, 2017 1:36 PM To: d...@openvswitch.org Subject: [ovs-dev]

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

n NULL; -} -OvsCtUpdateFlowKey(key, state, ctx->key.zone, 0, NULL); -return entry; -invalid: -state |= OVS_CS_F_INVALID; OvsCtUpdateFlowKey(key, state, ctx->key.zone, 0, NULL); return entry; } -- 2.9.0.windows.1 ___ Acked-by: Sha

Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

Hi Guru, can you apply this as well? Thanks! Shashank From: Nithin Raju Sent: Wednesday, June 21, 2017 12:25:33 PM To: Shashank Ram Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN > On Jun

Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Friday, May 19, 2017 4:28 PM To: Ben Pfaff Cc: ovs dev; Guru Shetty Subject: Re: [ovs-dev] [PATCH v2] Windows lib: Use

[ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

xmalloc checks if the size is valid before allocating memory. Signed-off-by: Shashank Ram <r...@vmware.com> --- lib/netdev-windows.c | 4 ++-- lib/wmi.c| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c index 3

[ovs-dev] [PATCH v2] datapath-windows: Set Version correctly for OVSExt

converted to a literal text 'Version' instead of the the version number passed using the 'Version' property to MSBuild. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/ovsext.rc | 5 +++-- datapath-windows/ovsext/ovsext.vcxproj | 14 +++--- 2 files chang

Re: [ovs-dev] [PATCH] datapath-windows: use NlAttrGet() in Conntrack.c

ine NETLINK_NETFILTER 12 #define NETLINK_GENERIC 16 -- 2.7.1.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: Define NAT_ACTION enum correctly

The existing code throws a warning when compiled with the Windows 10 SDK: 'typedef ': ignored on left of 'NAT_ACTION' when no variable is declared Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Conntrack.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

Adds validations in OvsGetIp() to make sure the IHL is within valid bounds. If IHL is invalid, then the packet is dropped by the callers of this function. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Flow.c | 5 + datapath-windows/ovsext/Off

Re: [ovs-dev] [PATCH] datapath-windows: Zero initialize Conntrack-ICMP entry

TCPOPT_EOL, -- 2.9.0.windows.1 _______ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: Set Version correctly for OVSExt

converted to a literal text. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/ovsext.rc | 5 +++-- datapath-windows/ovsext/ovsext.vcxproj | 14 +++--- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/datapath-windows/ovsext/ovsext.rc b/da

Re: [ovs-dev] [PATCH] windows: fix broken build

endif /* windefs.h */ -- 2.10.2.windows.1 ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v6 2/4] datapath-windows: Add NAT module in conntrack

Yin, thanks for the patches. Please briefly describe in the commit message the scope of this patch. Same applies to other patches in this series. Thanks, Shashank From: ovs-dev-boun...@openvswitch.org on behalf of Yin Lin

Re: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

Sure, will send out a v2. Thanks, Shashank From: Alin Serdean <aserd...@cloudbasesolutions.com> Sent: Friday, May 19, 2017 2:51:27 PM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

[ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

xmalloc checks if the size is valid before allocating memory, and also if the allocation was successful. Signed-off-by: Shashank Ram <r...@vmware.com> --- lib/netdev-windows.c | 14 ++ lib/wmi.c| 14 ++ 2 files changed, 4 insertions(+), 24 deletions(-)

Re: [ovs-dev] [PATCH] tests: Fix sparse error on test-ovn.c

f-by: Alin Gabriel Serdean <aserd...@ovn.org> --- Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: Fix bugs in cleaner threads

during driver unload. Testint done: Verified that cleaner threads run as expected without crashing during driver unload. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/Conntrack-related.c | 6 +- datapath-windows/ovsext/Conntrack.c | 6 +- da

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

___ >From: ovs-dev-boun...@openvswitch.org on >behalf of Sairam Venugopal >Sent: Monday, August 28, 2017 4:56 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit

Re: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

tapath-windows/ovsext/Conntrack.c | 10 ++ datapath-windows/ovsext/Conntrack.h | 1 + 2 files changed, 11 insertions(+) ___ Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswit

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

Comments inline. Subject: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state. For a given packet, packet counters in conntrack should be accounted only once, even if the packet is processed multiple times by

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

, it does not make sense to style the CT code differently than the rest of the Windows data path code. --- Acked-by: Shashank Ram From: ovs-dev-boun...@openvswitch.org <ovs-dev-boun...@openvswitch.org> on behalf of Shashank Ram <r...@vmware.

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

From: ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff Sent: Wednesday, August 2, 2017 11:35 AM To: Alin Serdean Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/40] Fix static code analysis

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

> From: ovs-dev-boun...@openvswitch.org on > behalf of Ben Pfaff > Sent: Wednesday, August 2, 2017 11:35 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 00/40] Fix static

[ovs-dev] [PATCH] datapath-windows: Move OvsCreateNewNBLsFromMultipleNBs to BuggerMgmt

Moves function OvsCreateNewNBLsFromMultipleNBs() to BufferMgmt.c to facilitate consumption from outside PacketIO.c. Signed-off-by: Shashank Ram <r...@vmware.com> --- datapath-windows/ovsext/BufferMgmt.c | 47 datapath-windows/ovsext/BufferMgmt.

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Monday, August 28, 2017 4:56 PM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to

Re: [ovs-dev] [PATCH v2] datapath-windows: Add an upper limit to conntrack entries

Acked-by: Shashank Ram <r...@vmware.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Update OvsIPv4TunnelKey flags in geneve decap.

On 10/17/17, 5:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: Set the geneve flags OVS_TNL_F_GENEVE_OPT and OVS_TNL_F_CRT_OPT in OvsDecapGeneve, so that windows behavior is similiar to linux

Re: [ovs-dev] [PATCH v2 7/7] datapath-windows: Fix possible NULL dereference in IpFragment

Gabriel Serdean <aserd...@cloudbasesolutions.com> --- Acked-by: Shashank Ram <shashan...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 6/7] datapath-windows: Fix static analysis warnings around ovsInstanceListLock

: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> --- v2: Removed an extra return. Suggested by: Shashank Ram r...@vmware.com --- Acked-by: Shashank Ram <shashan...@gmail.com> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

want to fulfill? Thanks, Alin. > -Original Message- > From: Shashank Ram [mailto:r...@vmware.com] > Sent: Tuesday, November 28, 2017 3:33 PM > To: d...@openvswitch.org; Alin Serdean > <aserd...@cloudbasesolutions.com> >

  1   2   >