[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #3 from Robert-André Mauchin (afk until next Thu) 
 ---
There are some issues with the licences, some files are GPLv2+ and some other
GPLv3+:

*No copyright* CC0
--
fritzing-parts-0.9.2b/svg/obsolete/pcb/SparkFun-LCC20_SparkFun.svg
fritzing-parts-0.9.2b/svg/obsolete/pcb/SparkFun-LPCC20_SparkFun.svg

CC by
-
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/fullbreadboardgenerator/documentation/resources/guide_style.css

GPL (v2 or later) (with incorrect FSF address)
--
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/footgen/footgen.py

GPL (v3 or later)
-
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/dilPackageGenerator/generator.py
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/fullbreadboardgenerator/generator.py
fritzing-parts-0.9.2b/part-gen-scripts/obsolete/resistorSetGenerator/valuesAndColors_forResistors.py


It should be reflected in the License: tag

 - I think you should add a specific verion of fritzing in the Requires tag
otherwiseit will conflicts with lower version of fritzing.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later) (with incorrect FSF address)", "CC by", "GPL
 (v3 or later)", "Unknown or generated", "*No copyright* CC0". 8576
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/fritzing-parts/review-fritzing-
 parts/licensecheck.txt
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/fritzing/parts/svg/contrib/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/core/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/obsolete(fritzing),
 /usr/share/fritzing/parts/svg/contrib(fritzing),
 /usr/share/fritzing/parts/svg/user/schematic(fritzing),
 /usr/share/fritzing/parts/obsolete(fritzing),
 /usr/share/fritzing/parts(fritzing),
 /usr/share/fritzing/parts/svg/core/icon(fritzing),
 /usr/share/fritzing/parts/svg/contrib/pcb(fritzing),
 /usr/share/fritzing/parts/svg/core(fritzing),
 /usr/share/fritzing/parts/subparts2d/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/icon(fritzing),
 /usr/share/fritzing/parts/svg/contrib/schematic(fritzing),
 /usr/share/fritzing/parts/svg/user(fritzing),
 /usr/share/fritzing/parts/subparts(fritzing),
 /usr/share/fritzing/parts/core(fritzing),
 /usr/share/fritzing/parts/svg/core/pcb(fritzing),
 /usr/share/fritzing(fritzing),
 /usr/share/fritzing/parts/svg/contrib/icon(fritzing),
 /usr/share/fritzing/parts/user(fritzing),
 /usr/share/fritzing/parts/svg/user/icon(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/pcb(fritzing),
 /usr/share/fritzing/parts/svg/core/schematic(fritzing),
 /usr/share/fritzing/parts/subparts2d(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/breadboard(fritzing),
 /usr/share/fritzing/parts/svg/user/breadboard(fritzing),
 /usr/share/fritzing/parts/subparts/breadboard(fritzing),
 /usr/share/fritzing/parts/svg(fritzing),
 /usr/share/fritzing/parts/svg/user/pcb(fritzing),
 /usr/share/fritzing/parts/contrib(fritzing),
 /usr/share/fritzing/parts/svg/obsolete/schematic(fritzing)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043

Honggang LI  changed:

   What|Removed |Added

  Flags||needinfo?(ke...@scrye.com)



--- Comment #37 from Honggang LI  ---
(In reply to Kevin Fenzi from comment #33)
> So, the problem is actually that the old libibverbs package had no
> dependency on perl, but this new one (subpackage of rdma-core) does. This
> results in the rawhide composes failing because lorax prunes out perl and
> then the /usr/bin/rxe_cfg script has no perl and errors out. 
> 
> So, very short term I have just untagged rdma-core again, so we can
> hopefully get a rawhide compose today or this weekend. 

Hi, Kevin
 Fedora-rawhide lorax addressed the perl package issue, and we had rebuilt
rdma-core with all known issues got fixed. I checked my fedora-rawhide virtual
machine, only old rdma package available.

 What we need to do to replace the old rdma package with the new rdma-core
package?


> Slightly longer term, we have put in a PR to make lorax not prune perl: 
> https://github.com/rhinstaller/lorax/pull/228 once thats merged and in a
> rawhide lorax build we can retag or rebuild rdma-core
> 
> Longer term still, it would sure be nice if we didn't have to have perl on
> minimal images. I don't know how important rxe_cfg is or if it could be
> re-written to work with system-python or as a binary, but that would sure be
> nice 
> to drop the dep on perl here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 187314] Review Request: perl-Data-HexDump

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=187314

Fedora Update System  changed:

   What|Removed |Added

 Resolution|NEXTRELEASE |ERRATA



--- Comment #6 from Fedora Update System  ---
perl-Authen-Radius-0.26-4.el7, perl-Data-HexDump-0.02-26.el7 has been pushed to
the Fedora EPEL 7 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 187313] Review Request: perl-Authen-Radius

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=187313

Fedora Update System  changed:

   What|Removed |Added

 Resolution|NEXTRELEASE |ERRATA



--- Comment #6 from Fedora Update System  ---
perl-Authen-Radius-0.26-4.el7, perl-Data-HexDump-0.02-26.el7 has been pushed to
the Fedora EPEL 7 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967



--- Comment #2 from Ed Marshall  ---
Spec URL: https://fedorapeople.org/~logic/fritzing-parts/fritzing-parts.spec
SRPM URL:
https://fedorapeople.org/~logic/fritzing-parts/fritzing-parts-0.9.2b-1.fc27.src.rpm
Description: Fritzing is a free software tool to support designers, artists and
hobbyists to work creatively with interactive electronics. The fritzing-parts
package contains a library of part definitions, including both meta-data and
related graphics.
Fedora Account System Username: logic

Thanks for catching those!

- I've yanked the Group: tag, and I'll pull it from Fritzing itself the next
time I issue an update.
- I've punted entirely on the patches, since as of the next update (which will
follow on the heels of this pretty quickly) those scripts won't even exist
anymore (which was the reason for both patches: fixing hashbang lines, and an
outdated FSF address, to make fedora-review happy). So, I've pulled the
obsolete parts scripts entirely, and both patches.
- I had no idea that URL would work with Github! This is so much better than
the reference trick I was using (which I'm sure I borrowed from an old mailing
list thread at some point), thank you!
- Yanked defattr, will get rid of it in Fritzing itself with the next release
too.

Koji scratch build is at:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21155649

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476481] Review Request: perl-AWS-Signature4 - Perl module for creating a version4 signature for Amazon Web Services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476481



--- Comment #8 from Fedora Update System  ---
perl-AWS-Signature4-1.02-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #42 from Fedora Update System  ---
fedrepo-req-1.0.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8dc36fc7bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478052] Review Request: nuvola-app-google-play-music - Google Play integration for Nuvola Player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478052

mgans...@alice.de  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |nuvola-app-google-play-musi |nuvola-app-google-play-musi
   |c - Google Calendar web app |c - Google Play integration
   |for Nuvola Player 3 |for Nuvola Player



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434746] Review Request: uom-se - Unit Standard (JSR 363) implementation for Java SE 8 and above

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434746



--- Comment #4 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/uom-se

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434746] Review Request: uom-se - Unit Standard (JSR 363) implementation for Java SE 8 and above

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434746



--- Comment #3 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/uom-se

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728



--- Comment #19 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cld2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728



--- Comment #20 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cld2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450212] Review Request: pyowm - Python wrapper library for the OpenWeatherMap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450212



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pyowm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450212] Review Request: pyowm - Python wrapper library for the OpenWeatherMap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450212



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pyowm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #32 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/syncthing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #31 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/syncthing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479844] Review Request: deepin-notifications - System notifications for linuxdeepin desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479844



--- Comment #5 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-notifications

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479844] Review Request: deepin-notifications - System notifications for linuxdeepin desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479844



--- Comment #4 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-notifications

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130



--- Comment #3 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Math-Utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434746] Review Request: uom-se - Unit Standard (JSR 363) implementation for Java SE 8 and above

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434746

Lukas Berk  changed:

   What|Removed |Added

   Assignee|brol...@redhat.com  |lb...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130



--- Comment #2 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Math-Utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478059] Review Request: nuvola-app-jango - Jango for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478059



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-jango

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478059] Review Request: nuvola-app-jango - Jango for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478059



--- Comment #5 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-jango

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478053] Review Request: nuvola-app-groove - Microsoft Groove for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478053



--- Comment #4 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-groove

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478053] Review Request: nuvola-app-groove - Microsoft Groove for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478053



--- Comment #3 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-groove

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421065



--- Comment #10 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-qt-dbus-factory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421065



--- Comment #9 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-qt-dbus-factory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421044] Review Request: deepin-qml-widgets - Deepin QML widgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421044



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-qml-widgets

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421044] Review Request: deepin-qml-widgets - Deepin QML widgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421044



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-qml-widgets

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478705] Review Request: deepin-calendar - Calendar for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478705



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-calendar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478705] Review Request: deepin-calendar - Calendar for Deepin Desktop Environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478705



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-calendar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479022] Review Request: preeny - Some helpful preload libraries for pwning stuff

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479022



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/preeny

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479707] Review Request: perl-Test-Exit - Test that some code calls exit without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479707



--- Comment #3 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Test-Exit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479022] Review Request: preeny - Some helpful preload libraries for pwning stuff

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479022



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/preeny

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479707] Review Request: perl-Test-Exit - Test that some code calls exit without terminating testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479707



--- Comment #2 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Test-Exit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432993] Review Request: hd-idle - Spin down idle [USB] hard disks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432993



--- Comment #15 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/hd-idle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432993] Review Request: hd-idle - Spin down idle [USB] hard disks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432993



--- Comment #14 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/hd-idle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #14 from Brandon Nielsen  ---
(In reply to Elliott Sales de Andrade from comment #13)
> For g++ subpackage, I'd check original gcc, maybe.  Same for gnulib,
> assuming it has also been bundling it. The illegal package name has to do
> with including static files in a package name without -static suffix, which
> is likely not relevant here.
> 
> I'd say pinging someone from the Embedded SIG might be useful:
> https://fedoraproject.org/wiki/Embedded

New spec URL:
https://bitbucket.org/nielsenb/mspgcc-fedora/raw/e291164cb85b8d82603e5e4f2dc04929f8d5a146/msp430-elf-toolchain.spec

New SRPM URL:
https://bitbucket.org/nielsenb/mspgcc-fedora/downloads/msp430-elf-toolchain-5.0.0.0-1.src.rpm

I split out the C++ stuff. Original gcc doesn't bundle gnulib, but the bundled
libiberty is not versioned.

I'll check out the Embedded SIG when I get a chance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478052] Review Request: nuvola-app-google-play-music - Google Calendar web app for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478052



--- Comment #5 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-google-play-music

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478052] Review Request: nuvola-app-google-play-music - Google Calendar web app for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478052



--- Comment #4 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-google-play-music

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467054] Review Request: nuvola-app-google-calendar - Google Calendar web app for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467054



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-google-calendar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467054] Review Request: nuvola-app-google-calendar - Google Calendar web app for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467054



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-google-calendar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467049] Review Request: nuvola-app-deezer - Deezer for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467049



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-deezer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467049] Review Request: nuvola-app-deezer - Deezer for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467049



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-deezer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476085] Review Request: libsemigroups - C++ library for semigroups and monoids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476085

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-10 12:54:00



--- Comment #18 from Fedora Update System  ---
libsemigroups-0.3.1-3.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1120788] Review Request: Rex - Tool for Automation, Remote Execution and Configuration Deployment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1120788
Bug 1120788 depends on bug 1476481, which changed state.

Bug 1476481 Summary: Review Request: perl-AWS-Signature4 - Perl module for 
creating a version4 signature for Amazon Web Services
https://bugzilla.redhat.com/show_bug.cgi?id=1476481

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476481] Review Request: perl-AWS-Signature4 - Perl module for creating a version4 signature for Amazon Web Services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476481

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-10 12:53:33



--- Comment #7 from Fedora Update System  ---
perl-AWS-Signature4-1.02-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465130] Review Request: nuvola-app-8tracks - 8tracks for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465130



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-8tracks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465130] Review Request: nuvola-app-8tracks - 8tracks for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465130



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/nuvola-app-8tracks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478703] Review Request: perl-Exporter-Easy - Takes the drudgery out of Exporting symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478703



--- Comment #3 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Exporter-Easy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478703] Review Request: perl-Exporter-Easy - Takes the drudgery out of Exporting symbols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478703



--- Comment #2 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Exporter-Easy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462465] Review Request: cmatrix - A scrolling 'Matrix'-like screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462465



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cmatrix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462465] Review Request: cmatrix - A scrolling 'Matrix'-like screen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462465



--- Comment #5 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cmatrix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458840] Review Request: urw-base35-fonts - Level 2 Core Font Set for Ghostscript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458840



--- Comment #30 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/urw-base35-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1458840] Review Request: urw-base35-fonts - Level 2 Core Font Set for Ghostscript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1458840



--- Comment #29 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/urw-base35-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634



--- Comment #30 from Fabio Valentini  ---
Thank you very much for the review! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473705] Review Request: perl-Alien-Base-ModuleBuild - Perl framework for building Alien:: modules and their libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473705



--- Comment #5 from Ralph Bean  ---
(fedrepo-req-admin):  Apologies for the delay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1473705] Review Request: perl-Alien-Base-ModuleBuild - Perl framework for building Alien:: modules and their libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1473705



--- Comment #4 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Alien-Base-ModuleBuild

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480279] New: Review Request: python-avocado-lts - Framework with tools and libraries for Automated Testing (LTS branch)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480279

Bug ID: 1480279
   Summary: Review Request: python-avocado-lts - Framework with
tools and libraries for Automated Testing (LTS branch)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mmath...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://merlinm.fedorapeople.org/package-review/python-avocado-lts/python-avocado-lts.spec
SRPM URL:
https://merlinm.fedorapeople.org/package-review/python-avocado-lts/python-avocado-lts-52.0-1.fc27.src.rpm
Koji scratch build URL:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21148800
Description:
Avocado is a set of tools and libraries (what people call
these days a framework) to perform automated testing.

This is the LTS (Long Term Stability) branch.

Fedora Account System Username: merlinm

Notes:
This package is for the upstream LTS (Long Term Stability) branch of avocado.

As of avocado version 52.0, the LTS branch is identical to the regular feature 
branch which is currently packaged in Fedora as "python-avocado". However, 
future LTS versions will be 52.1, 52.2, ... whereas future feature versions 
will be 53.0, 54.0,   As a result of this versioning scheme, the base 
package name of the LTS version in Fedora needs to be different than the 
regular feature versions--otherwise the package manager, builders, etc. will 
always consider new LTS versions to immediately be obsolete. Thus, the request 
for this new package as "python-avocado-lts".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479844] Review Request: deepin-notifications - System notifications for linuxdeepin desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479844

Robert-André Mauchin (afk until next Thu)  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin (afk until next Thu) 
 ---
Everything is ok, package accepted.

Thanks for your work.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 38 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/deepin-notifications/review-deepin-
 notifications/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin-
 notifications-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in 

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #29 from Athos Ribeiro  ---
- License is OK
- Requires and Provides are OK
- The package provides the bundled packages used for the gui, as required
- RPMlint still raises an error about hardcoded path, which shall be fixed in
future releases of the package, since the package already contacted systemd
upstream about the missing macro.

The package looks good to me.


Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468454



--- Comment #8 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/php-pecl-timecop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468454] Review Request: php-pecl-timecop - Time travel and freezing extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468454



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/php-pecl-timecop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478358] Review Request: php-sebastian-diff2 - Diff implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478358



--- Comment #7 from Ralph Bean  ---
(fedrepo-req-admin):  Apologies for the delay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478358] Review Request: php-sebastian-diff2 - Diff implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478358



--- Comment #6 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/php-sebastian-diff2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476489



--- Comment #9 from Ralph Bean  ---
(fedrepo-req-admin):  Apologies for the delay!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476489] Review Request: xfce4-statusnotifier-plugin - Panel area status notifier plugin for Xfce4

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476489



--- Comment #8 from Ralph Bean  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/xfce4-statusnotifier-plugin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474033] Review Request: ucx - Communication library implementing high-performance messaging

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474033



--- Comment #9 from Andrey Maslennikov  ---
Spec URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/5be459ccf60ee116cc56296f72ecd38560961dee/ucx.spec
SRPM URL:
https://gist.github.com/amaslenn/3c847e0bdc063bcbb4b6507b5efbf6b9/raw/5be459ccf60ee116cc56296f72ecd38560961dee/ucx-1.2.0-1.fc25.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21147884

Details:
> > %files
> > %{_libdir}/lib*.so*
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
Unversioned .so moved to -devel.


> > %{_datadir}/ucx/perftest/*
> > 
> > https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
> > Extra files are now removed in %install, fixed issue with file pattern.
> > Is there anything else to fix here? Please also see below.
> 
> The issue here is that the directories /usr/share/ucx and 
> /usr/share/ucs/perftest are not included in your packages. That's why I've 
> linked the directory ownership guidelines.
Fixed.


> > -devel package now has 'Provides: %{name}-static = %{version}-%{release}'.
> 
> It is as if you deliberately misread
> 
>   
> https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
> 
> because even if a "compelling reason" where given as why to include the 
> static libs, they don't belong into the -devel package, if there are also 
> shared libs.
Static libs moved to separate -static package. -devel depends on it.


> > It reports "[!]: Package should not use obsolete m4 macros" complaining
> > on AC_PROG_LIBTOOL. Is it critical and has to fixed?
> 
> That's not part of the review guidelines or packaging guidelines. The tool is 
> trying to be helpful. In case it became necessary to regenerate the configure 
> script during the build process, such as for a fix, obsolete macros would be 
> problematic. It's something to fix upstream. Make sure you can autoreconf the 
> source tarball on a recent installation of Fedora.
OK, thanks. autoreconf works on f25.


> > Another error it reports is from rpmlint: binary-or-shlib-defines-rpath.
> > Is there any other way to correctly specify the path for .so/executable 
> > files?
> 
> If check-rpaths during an official build complained about it, proceed as 
> described at: 
> https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath
Couldn't reproduce it with fedora-review ran locally on spec/srpm. Added
--disable-rpath to %configure anyway.


> > It also reports mismatch in sizes/checksums of the tarball, which is
> > expected: current link is for prev release, we will create a new one
> > (v1.2.1) once pass this review.
> 
> That is completely *unexpected*. The SourceURL *must* link exactly the source 
> archive that is included in the src.rpm.
> 
> https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
> 
> MUST: The sources used to build the package must match the upstream source, 
> as provided in the spec URL. Reviewers should use sha256sum for this task as 
> it is used by the sources file once imported into git. If no upstream URL can 
> be specified for this package, please see the Source URL Guidelines for how 
> to deal with this.
Just want to have issues in spec fixed before creating actual release. Can we
ignore this one for a while? Once others are resolved I'll fix it ASAP (will
required creating a release).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479844] Review Request: deepin-notifications - System notifications for linuxdeepin desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479844



--- Comment #2 from Zamir SUN  ---
Thanks.
Updated in place.

Spec URL:
https://zsun.fedorapeople.org/pub/pkgs/deepin-notifications/deepin-notifications.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/deepin-notifications/deepin-notifications-3.0.6-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #9 from Tomas Tomecek  ---
I'll do another review round once the release is done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380826] Review Request: pgadmin4 - Management tool for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380826



--- Comment #2 from Devrim GÜNDÜZ  ---
All the packages are available from https://yum.postgresql.org . The pgadmin4
packaging is not 100% stable enough yet, so I'll hold this ticket for a few
weeks more.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #8 from Petr Hracek  ---
New updates based on PR.

Spec URL: https://phracek.fedorapeople.org/meta-test-family.spec
SRPM URL:
https://phracek.fedorapeople.org/meta-test-family-0.5.20-1.fc25.src.rpm

Installation errors
---
INFO: mock.py version 1.4.2 starting (python version = 3.5.3)...
Start: init plugins
INFO: selinux disabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled HW Info plugin
Mock Version: 1.4.2
INFO: Mock Version: 1.4.2
Finish: chroot init
INFO: installing package(s):
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/meta-test-family-0.5.20-1.fc25.noarch.rpm
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/python2-meta-test-family-0.5.20-1.fc25.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-25-x86_64/root/ --releasever
25 --disableplugin=local --setopt=deltarpm=False install
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/meta-test-family-0.5.20-1.fc25.noarch.rpm
/home/phracek/work/programming/meta-test-family/review-meta-test-family/results/python2-meta-test-family-0.5.20-1.fc25.noarch.rpm



Rpmlint
---
Checking: meta-test-family-0.5.20-1.fc25.noarch.rpm
  python2-meta-test-family-0.5.20-1.fc25.noarch.rpm
  meta-test-family-0.5.20-1.fc25.src.rpm
meta-test-family.noarch: W: no-documentation
meta-test-family.noarch: W: devel-file-in-non-devel-package
/usr/share/moduleframework/examples/base-runtime/resources/hello-world/hello.c
meta-test-family.noarch: E: script-without-shebang
/usr/share/moduleframework/examples/multios_testing/moduleframework/module_framework.py
meta-test-family.noarch: E: non-executable-script
/usr/share/moduleframework/examples/memcached/sanity2.sh 644 /bin/bash 
meta-test-family.noarch: W: no-manual-page-for-binary mtf-generator
meta-test-family.noarch: W: no-manual-page-for-binary moduleframework-cmd
meta-test-family.noarch: W: no-manual-page-for-binary modulelint
python2-meta-test-family.noarch: W: no-documentation
python2-meta-test-family.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moduleframework/timeoutlib.py 644
/usr/bin/python 
python2-meta-test-family.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moduleframework/bashhelper.py 644
/usr/bin/python 
python2-meta-test-family.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moduleframework/mtf_generator.py 644
/usr/bin/python 
meta-test-family.src: W: invalid-url Source0:
https://codeload.github.com/fedora-modularity/meta-test-family/tar.gz/meta-test-family-0.5.20.tar.gz
HTTP Error 404: Not Found

3 packages and 0 specfiles checked; 5 errors, 7 warnings.


As soon as PR will be merged, I will create release.

mtf_generator.py is false possitive. It contains /usr/bin/python.
bashhelper.py will be probably deleted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441728] Review Request: cld2 - Compact Language Detector 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441728

Kalev Lember  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||klem...@redhat.com
   Assignee|nob...@fedoraproject.org|klem...@redhat.com
  Flags||fedora-review+



--- Comment #18 from Kalev Lember  ---
Packaging looks nice and clean to me. Approving based on Jan Kalina's
unofficial review above.

I'd maybe change two minor things, one is that

%if 0%{?usesnapshot}
%autosetup -n %name-%{commit0}
%else
%setup -q
%endif

... seems a bit unsymmetrical; would be easier to read if both were %autosetup
(or both were %setup -q) but not a mix like this.

The other minor thing is that -devel package doesn't need to contain '%license
LICENSE' since it's already included in the base package.

Feel free to change these if you want after importing. APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476589] Review Request: deepin-api - Go-lang bingding for dde-daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476589



--- Comment #7 from sensor@gmail.com ---
SPEC: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00588927-deepin-api/deepin-api.spec
SRPM: 
https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00588927-deepin-api/deepin-api-3.1.11-2.fc25.src.rpm

Fixed, but some packages does not submit for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1477154] Re-Review Request: meta-test-family - a tool to test components of a modular Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1477154



--- Comment #7 from Petr Hracek  ---
rpmlint Errors should be fixed by PR
https://github.com/fedora-modularity/meta-test-family/pull/42

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1480032




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480032
[Bug 1480032] perl-Math-Derivative-1.00 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130

Petr Pisar  changed:

   What|Removed |Added

 Blocks|1480032 |
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
0905aab8b65ed08f951756dd86803267877f88e45027af458bb3b83d218cb7c4) is original.
Ok.
Summary verified in lib/Math/Utils.pm. Ok.
Description is Ok.
License verified in lib/Math/Utils.pm and README. The LICENSE file seems bogus
(CPAN RT#122758). Ok.
No XS code, noarch BuildArch is Ok.
Test::CheckManifest not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Math-Utils.spec ../SRPMS/perl-Math-Utils-1.10-1.fc27.src.rpm
../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm 
drwxr-xr-x2 rootroot0 Aug 10 11:34
/usr/share/doc/perl-Math-Utils
-rw-r--r--1 rootroot 3290 May 11 02:07
/usr/share/doc/perl-Math-Utils/Changes
-rw-r--r--1 rootroot 2754 May 11 02:08
/usr/share/doc/perl-Math-Utils/README
-rw-r--r--1 rootroot 6423 Aug 10 11:34
/usr/share/man/man3/Math::Utils.3pm.gz
drwxr-xr-x2 rootroot0 Aug 10 11:34
/usr/share/perl5/vendor_perl/Math
-rw-r--r--1 rootroot18759 Aug 10 11:34
/usr/share/perl5/vendor_perl/Math/Utils.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(:VERSION) >= 5.10.1
  1 perl(Carp)
  1 perl(Exporter)
  1 perl(integer)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(Math::Utils) = 1.09
  1 perl-Math-Utils = 1.10-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Math-Utils-1.10-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27
(https://koji.fedoraproject.org/koji/taskinfo?taskID=21145375). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480032
[Bug 1480032] perl-Math-Derivative-1.00 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478067] Review Request: nuvola-app-mixcloud - Mixcloud for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478067



--- Comment #8 from mgans...@alice.de  ---
new rpm packages:
Spec URL:
https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-mixcloud.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-mixcloud-3.2-3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1480032




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1480032
[Bug 1480032] perl-Math-Derivative-1.00 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1480130] New: Review Request: perl-Math-Utils - Useful mathematical functions not in Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1480130

Bug ID: 1480130
   Summary: Review Request: perl-Math-Utils - Useful mathematical
functions not in Perl
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jplesnik.fedorapeople.org/perl-Math-Utils/perl-Math-Utils.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Math-Utils/perl-Math-Utils-1.10-1.fc27.src.rpm

Description:
Math::Utils contains implementations of commonly used mathematical
functions and operations that are not part of standard Perl.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478059] Review Request: nuvola-app-jango - Jango for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478059



--- Comment #4 from Vít Ondruch  ---
(In reply to mgans...@alice.de from comment #3)
> (In reply to Vít Ondruch from comment #2)
> > * Description
> >   - Please drop the "Mixcloud for Nuvola Player 3 : " from the description.
> > This
> > is already contained in summary. No need to repeat it.
> 
> There is no text "Mixcloud for Nuvola Player 3 :" i can drop from
> description. :)

Ahh, silly me. Sorry for the confusion 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478059] Review Request: nuvola-app-jango - Jango for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478059



--- Comment #3 from mgans...@alice.de  ---
(In reply to Vít Ondruch from comment #2)
> * Description
>   - Please drop the "Mixcloud for Nuvola Player 3 : " from the description.
> This
> is already contained in summary. No need to repeat it.

There is no text "Mixcloud for Nuvola Player 3 :" i can drop from description.
:)

> 
> * .metainfo.xml typo in summary
>   - s/Jano/Jango/
> 
> These are minor nits, so I APPROVE the package, but please fix them prior
> importing into Fedora.

new rpm packages:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-jango.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-jango-
2.3-2.fc26.src.rpm

%changelog
* Thu Aug 10 2017 Martin Gansser  - 2.3-2
- correct %%{name}.metainfo.xml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478067] Review Request: nuvola-app-mixcloud - Mixcloud for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478067



--- Comment #7 from mgans...@alice.de  ---
(In reply to Vít Ondruch from comment #6)
> I have noticed typo in the .metainfo.xml:
> 
> Mixcload
> 
> It should be "Mixcloud".

corrected

%changelog
* Thu Aug 10 2017 Martin Gansser  - 3.2-3
- correct %%{name}.metainfo.xml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478059] Review Request: nuvola-app-jango - Jango for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478059

Vít Ondruch  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Vít Ondruch  ---
* Description
  - Please drop the "Mixcloud for Nuvola Player 3 : " from the description.
This
is already contained in summary. No need to repeat it.

* .metainfo.xml typo in summary
  - s/Jano/Jango/

These are minor nits, so I APPROVE the package, but please fix them prior
importing into Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478059] Review Request: nuvola-app-jango - Jango for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478059

Vít Ondruch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|vondr...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Vít Ondruch  ---
Taking this for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478053] Review Request: nuvola-app-groove - Microsoft Groove for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478053

Vít Ondruch  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Vít Ondruch  ---
The package looks good => APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1479967] Review Request: fritzing-parts - Parts library for the Fritzing electronic design application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,


No time to do a full review right now, but here's a preliminary couple of
issues:

 - The tag "Group:" is to be removed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Your patches… what do they do? Have they been reported upstream? Do you have
a bug number for them? See
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

 - Change: 

Source0:  
https://github.com/fritzing/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
 

to

Source0:  
https://github.com/fritzing/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

 - %defattr(-,root,root,-) is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478067] Review Request: nuvola-app-mixcloud - Mixcloud for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478067



--- Comment #6 from Vít Ondruch  ---
I have noticed typo in the .metainfo.xml:

Mixcload

It should be "Mixcloud".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1478053] Review Request: nuvola-app-groove - Microsoft Groove for Nuvola Player 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1478053

Vít Ondruch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|vondr...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Vít Ondruch  ---
I'll take this for a review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org