Re: TAP and Bail out!

2008-01-19 Thread Adam Kennedy
Eric Wilhelm wrote: # from Adam Kennedy # on Friday 18 January 2008 00:23: Eric Wilhelm wrote: This is not a command-line conditional bail, but rather "the module won't even load for some reason and thus testing anything else is pointless". ... Well, possibly. The bail outs

Re: TAP and Bail out!

2008-01-18 Thread Adam Kennedy
Eric Wilhelm wrote: # from Geoffrey Young # on Tuesday 15 January 2008 11:49: what I think many are asking for is for Test::Builder to be able to issue the appropriate TAP on $condition. Where $condition is a run-time option set at the command-line, not hardcoded into the test. Writing "or

Re: The Star Trek: Generations problem.

2008-01-14 Thread Adam Kennedy
On 15/01/2008, chromatic <[EMAIL PROTECTED]> wrote: > > On Monday 14 January 2008 15:42:49 Adam Kennedy wrote: > > > Test::Builder should just do what it's told. > > > > If the code that IS responsible for testing suites tells it to bail on > > fail,

Re: The Star Trek: Generations problem.

2008-01-14 Thread Adam Kennedy
For the record, I don't like the approach of requiring the failure condition to have the ability to do math (even if it's just counting). It complicates things quite a bit, and means that it will require more than three characters to indicate you want fainting-mode. Adam K On 15/01/2008, Matisse

Re: The spewing problem.

2008-01-14 Thread Adam Kennedy
Michael Peters wrote: Michael G Schwern wrote: Michael Peters wrote: make test || echo -e "\a" I keep digging away at this because I'm looking for a problem other than "I want to see the first failure". And that's what I'm hearing from you and from Matisse and everyone else. Yours is a li

Re: The spewing problem.

2008-01-14 Thread Adam Kennedy
Test::Builder should just do what it's told. If the code that IS responsible for testing suites tells it to bail on fail, that's exactly what it should do. Adam K chromatic wrote: On Monday 14 January 2008 02:27:56 Ovid wrote: --- chromatic <[EMAIL PROTECTED]> wrote: How is this simpler

Re: The spewing problem.

2008-01-14 Thread Adam Kennedy
Because if my test script is startled, I want it to stop and fall over. Google for "feinting goat". Adam K On 14/01/2008, Michael G Schwern <[EMAIL PROTECTED]> wrote: > > Adam Kennedy wrote: > > This shouldn't be any more complicated than " -g" (whe

Re: The spewing problem.

2008-01-13 Thread Adam Kennedy
Michael G Schwern wrote: Paul Johnson wrote: This is something that I too have asked for in the past. I've even hacked up my own stuff to do it, though obviously not as elegantly as you or Geoff. Here's my use case. I have a bunch of tests that generally pass. I hack something fundamental an

Re: Summarizing the pod tests thread

2007-07-31 Thread Adam Kennedy
Salve J. Nilsen wrote: Let's say Joe Sysadmin wants to install the author's (a.k.a. "your") module Useful::Example, and during the test-phase one of the POD tests fail. Joe Sysadmin doesn't use modules, lets try the following. "Joe Sysadmin wants to install the JSAN client, because his HTML/J

Re: Summarizing the pod tests thread

2007-07-31 Thread Adam Kennedy
David Golden wrote: * Alternatives -- Eric Wilhelm suggests putting these tests in at/ and running them with prove. Likewise, Module::Build and ExtUtils::MakeMaker could have targets added that run tests in an "at/" directory as another way to encourage the practice. (Module authors who want su

Re: Fixing the damage caused by has_test_pod

2007-07-31 Thread Adam Kennedy
Eric Wilhelm wrote: I'm thinking the installer should have the option to scan the tests and skip any that use qr/Test::Pod(?:::Coverage)?/. This wouldn't work. It would just mean that the installer would skip ALL the tests for Test::Pod :) There's many cases when testing the Test:: modules

Re: Fixing the damage caused by has_test_pod

2007-07-31 Thread Adam Kennedy
Christopher H. Laco wrote: I say that's fine. If it fails and you can't install it, then don't. Arguments about whether the tests should or shouldn't be run [or included at all] is irrelevant. Tests failed. Don't install. File RT. Filing RT requires understand what failed and why. This requires

Re: Fixing the damage caused by has_test_pod

2007-07-31 Thread Adam Kennedy
Salve J Nilsen wrote: Anyhow, I think being able to recreate the entire distribiution may be a good thing, but perhaps not necessarily from a CPAN-distributed tarball. I'd certainly expect that from a source repository checkout, though. CPAN-distributed tarballs are the primary source of the s

Re: Fixing the damage caused by has_test_pod

2007-07-31 Thread Adam Kennedy
chromatic wrote: On Monday 30 July 2007 10:01:25 Eric Wilhelm wrote: I think the important bit is that `make test` only runs tests which verify the module's functionality. ... and if my POD coverage somehow mysteriously changed between the time I bundled a new dist and some user downloaded t

Re: Fixing the damage caused by has_test_pod

2007-07-31 Thread Adam Kennedy
David Golden wrote: CPAN is a core strength of Perl because it makes developer's lives easier by not reinventing the wheel. This is not necesarily the case. Every language has ways of providing additional libraries that make developers lives easier by not reinventing the wheel. CPAN is a co

Re: Fixing the damage caused by has_test_pod

2007-07-28 Thread Adam Kennedy
The POD testing I can mostly agree with. Unfortunately, the pod coverage tests requires the module to be compiled, so CPANTS can never safely run it, and thus can never run it at all. :) Adam K Eric Wilhelm wrote: # from Adam Kennedy # on Saturday 28 July 2007 09:38 am: Thus, I would

Re: Fixing the damage caused by has_test_pod

2007-07-28 Thread Adam Kennedy
chromatic wrote: I use Module::Build (don't jerk your knee yet, Adam) so that I can easily override 'make disttest' to run my author tests. I keep them in t/author/. Build.PL for Test::MockObject should make it a little clearer: http://search.cpan.org/src/CHROMATIC/Test-MockObject-1.

Fixing the damage caused by has_test_pod

2007-07-28 Thread Adam Kennedy
For background on this email, see the following entry in my journal. http://use.perl.org/~Alias/journal/33893 Lately, I've noticed a series of modules that are cargo-culting the use of test_pod and test_pod_coverage in their tests. Not only are we seeing spurious failures for users, but worse

Re: Reporting setup problems separately?

2007-07-24 Thread Adam Kennedy
David Golden wrote: On 7/24/07, Gabor Szabo <[EMAIL PROTECTED]> wrote: In the way it is written now both setup-phases-failure and real-failure are displayed in the same way. When it fails I know something went wrong but I don't know if it is in the test environment (e.g. not enough disk space) o

Alternate CPAN::Reporter delivery methods?

2007-04-09 Thread Adam Kennedy
My ISP now block all non-authenticated SMTP traffic (as far as I can tell anyway). Personally I use an authenticated SMTP server on one of my websebers, but even the ISP's own servers need it. As email continues to get locked down more-heavily, is it worth looking into an alternative deliver

Re: What was I thinking?

2007-03-31 Thread Adam Kennedy
Kirrily Robert wrote: In September 2001, apparently all aglow in the excitement of all the talk that was going on about testing and whatnot, I wrote a module called CPAN::Test::Reporter. (http://search.cpan.org/~skud/CPAN-Test-Reporter-0.02/) Looking at it, I have no idea what I was thinking or

Re: YAML?

2007-03-31 Thread Adam Kennedy
We're defining a subset of YAML (YAMLish) that should be simple to implement in many languages. YAMLish was based initially on the YAML subset that YAML::Tiny supports. Since then I've made it able to handle arbitrary strings as hash keys (YAML::Tiny needs hash keys like \w\S+). Except fo

Re: TAP::Parser internationalization

2007-03-18 Thread Adam Kennedy
Without referencing anything specific in your code (since I haven't read it since about first week you started) I'll just note that internationalisation of any kind should be as close to the user interface as you can possibly make it, without the assumption that the user interfaces you have now

Re: You cannot predict what TAP will be used for (was Re: Should TAP capture exit codes)

2007-03-08 Thread Adam Kennedy
I propose that we prefix lines from STDERR with '! ' in the same way that '# ' is used for diagnostics. wstat and exit can just be wstat 256 exit 1 The problem with STDERR and exit is that we can't actually use them for anything significant. Otherwise when dealing with TAP streams that don

Re: Should TAP capture exit codes

2007-03-08 Thread Adam Kennedy
Reading through this I can't help but thing I've seen it all before. The PITA test result code conversation, if you'll recall. But when that cloned something akin to HTTP codes it was because there looked to be only 15-20 total possible results. And it's not meant to be extensible the way TAP

Re: Custom extensions to META.yml

2007-03-07 Thread Adam Kennedy
Graham Barr wrote: On Mar 5, 2007, at 1:56 PM, Eric Wilhelm wrote: * brian d foy <[EMAIL PROTECTED]> [2007-03-04T12:09:26] I'm not talking about the particular field name, but the idea that I'd want to say in META.yml "Don't send me mail", or whatever setting I want. Instead of having to dis

Re: Custom extensions to META.yml

2007-03-07 Thread Adam Kennedy
Ricardo SIGNES wrote: * brian d foy <[EMAIL PROTECTED]> [2007-03-04T12:09:26] I'm not talking about the particular field name, but the idea that I'd want to say in META.yml "Don't send me mail", or whatever setting I want. Instead of having to disable (or enable) CC for every new tool, I'd want

Re: Fuzz testing

2007-03-06 Thread Adam Kennedy
Barbie wrote: Hi Dave, Has anyone done any perl fuzz-testing - that is, written something that generates valid but silly code in an attempt to find errors in the interpreter or in a module? Is Acme::BadExample what you're looking for? The module that spawned a brilliant and enlightening talk

Re: a safer way to use no_plan?

2007-03-06 Thread Adam Kennedy
Its O(1) vs O(n). We do the work once to make "no plan" safer, everybody benefits for happily ever after. Your argument sounds like the things I had to deal with when I introduced Test::More. "Why should we load a module with all these functions when I can just write 'print ...my test... ? "

Re: a safer way to use no_plan?

2007-03-05 Thread Adam Kennedy
Dominique Quatravaux wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andy Lester wrote: Good Lord do I get frustrated at the handwringing over test counting. Look, it's simple. You write your tests. You run it through prove. You see how many tests it reports. You add it at the top of

Re: UNIVERSAL::ref might make ref( $mocked_obj ) sane

2007-03-01 Thread Adam Kennedy
chromatic wrote: On Monday 26 February 2007 06:35, Christopher H. Laco wrote: Or me. I have a personal hate relationship with MockObject in this way. I love MockObject. I hate getting warnings about 3 party modules use of can in my test suite. Ideally those third parties would fix their buggy

Re: UNIVERSAL::ref might make ref( $mocked_obj ) sane

2007-03-01 Thread Adam Kennedy
Yuval Kogman wrote: On Sun, Feb 25, 2007 at 22:34:15 -0800, chromatic wrote: Why not, I already have half of the other stuff in UNIVERSAL Just don't tell Adam. As much as I dislike UNIVERSAL::, I'd FAR prefer to have it all maintained by one person. That way I can submit my typically

Re: UNIVERSAL::ref might make ref( $mocked_obj ) sane

2007-03-01 Thread Adam Kennedy
Yuval Kogman wrote: BTW, pure perl blessed() will work: sub UNIVERSAL::a_sub_not_likely_to_be_here { ref($_[0]) } sub blessed ($) { local($@, $SIG{__DIE__}, $SIG{__WARN__}); length(ref($_[0])) ? eval { $_[0]->a_sub_not_likely_to_be_here }

Re: Object Identification Cold War and the return of autobox.pm (was Re: UNIVERSAL::ref might make ref( $mocked_obj ) sane)

2007-03-01 Thread Adam Kennedy
chromatic wrote: On Monday 26 February 2007 13:50, Michael G Schwern wrote: But what if isa() is broken or has side effects, hmm? That's not the caller's problem. Fix the broken code. Don't break more code trying to work around bugs. I think the problem he's refering to is that if the ca

Re: Object Identification Cold War and the return of autobox.pm (wasRe: UNIVERSAL::ref might make ref( $mocked_obj ) sane)

2007-03-01 Thread Adam Kennedy
Michael G Schwern wrote: Yuval Kogman wrote: Likewise with ref in boolean context, I almost never want the object to be able to lie to me. But if it has to work hard to lie, then does it matter? Yeah, I'm with Yuval here. There seem to be a cold war going on here wrt identifying an object.

Re: Test::Simple API incompatibility - cpan-testers FAIL results

2007-02-15 Thread Adam Kennedy
This comes from the OMGYOUBROKECPAN! diagnostics formatting change in 0.60_01. Can we use that as the official name for this sort of error? Because the other alternative would be "Doing a Schwern" and I I'm sure you'd prefer to preserve that term for something positive :) Adam K

Re: ExtUtils::MakeMaker, and t/ sub-directories

2007-02-08 Thread Adam Kennedy
Christopher H. Laco wrote: Nik Clayton wrote: Paul Johnson wrote: On Thu, Feb 08, 2007 at 09:26:01AM +, Nik Clayton wrote: [ I vaguely recall a discussion about this, but my search-fu is weak, and I can't find it ] Is there a standard way/idiom to get ExtUtils::MakeMaker to support tests

Re: Parallelizing TAPx::Harness?

2007-02-05 Thread Adam Kennedy
Eric Wilhelm wrote: Hi all, I was just thinking that since my tests are nicely orthogonal and yet there's very little cpu utilization during testing, that I could probably get them done about 20x faster if they were parallelized. Has anyone looked at doing this with TAPx::Harness or otherwis

Re: Module Announcement: Perl-Critic-1.01

2007-02-02 Thread Adam Kennedy
And from all of us, I think a big Thank You and congratulations are in order. Adam K Jeffrey Thalhammer wrote: After more than 18 months of development, Perl-Critic has reached its first major release! Version 1.01 is now available on a CPAN mirror nea

Re: TAPx::Harness support for EUMM

2007-01-30 Thread Adam Kennedy
I for one would rather it wasn't. Remembering that NOBODY ever passes Makefile.PL params manually, you need every build system capable of supporting those params, and ever CPAN client to be capable of passing them. An environment variable is a direct line from the user/system to EUMM for ONL

Re: Using pip to get testing done better and faster...

2007-01-23 Thread Adam Kennedy
Eric Wilhelm wrote: # from Adam Kennedy # on Tuesday 09 January 2007 03:05 am: Since I moved to SVN, one of the things I've been doing is commiting my release tarballs into a /releases/ directory. One side-effect of this is that even before I've uploaded it to CPAN, ever release alr

Re: Test::Harness 3.0

2007-01-22 Thread Adam Kennedy
Smylers wrote: Eric Wilhelm writes: PERL_TEST_HARNESS_DUMP_TAP="$(test_dir_for_this_dist)" If that isn't enough, I suppose you could do "if the env var is an executable, run it and capture the output"? Nice -- so that if you manage to trick somebody into setting that environment variable y

Re: Using pip to get testing done better and faster...

2007-01-22 Thread Adam Kennedy
That assumes that what is in svn is what is in the tarball. In practice, the packaging system needs to do various things. For example, copying in the LICENSE file, checking newlines are all unix, adding ppport.h if needed, and so on. Adam K Nik Clayton wrote: Adam Kennedy wrote: Since I

Re: Test::Harness 3.0

2007-01-21 Thread Adam Kennedy
Eric Wilhelm wrote: # from Andy Armstrong # on Sunday 21 January 2007 11:37 am: On 21 Jan 2007, at 19:16, Eric Wilhelm wrote: PERL_TEST_HARNESS_DUMP_TAP="$(test_dir_for_this_dist)" If that isn't enough (which may be the case in Adam's cpan injection), I suppose you could do "if the env var

Re: Test::Harness 3.0

2007-01-21 Thread Adam Kennedy
Can you imagine the logfile of 177305 tests? Assuming 50 chars across, that's 5-10meg. I'm completely fine with 5-10 meg of TAP output. Please note I'm already dealing with clustered and distributed virtual machines and giant XML stores. I'm slinging 1 gig system images across the internet..

Re: Test::Harness 3.0

2007-01-21 Thread Adam Kennedy
Adam Kennedy wrote: So, seeing as you are going to take over Test::Harness as well, is NOW where I ask you for the PITA-related capturing of a copy of the TAP streams? :) Let me just clarify what I'm wanting here, for those talking about alternative parsing. I don't want ANY dif

Re: Test::Harness 3.0

2007-01-21 Thread Adam Kennedy
Andy Armstrong wrote: On 21 Jan 2007, at 14:28, Andy Armstrong wrote: Yup - point taken. YAML it is then. Everyone happy with that? By which I mean YAML and/or TAP. There's no real reason not to be able to output TAP if someone might find that useful. export TEST_HARNESS_DUMP_TAP=/home/me/t

Re: Test::Harness 3.0

2007-01-21 Thread Adam Kennedy
I dont get this logic. Why cant something that wants to monitor the test process do something other than make test? They can do a make, and or make test-prep or whatever, and then call into an alternative test harness framework to monitor the tests. Can you explain why this is a no-go in more d

Re: Test::Harness 3.0

2007-01-21 Thread Adam Kennedy
So, seeing as you are going to take over Test::Harness as well, is NOW where I ask you for the PITA-related capturing of a copy of the TAP streams? :) Adam K Ovid wrote: Hi all, Andy Lester sent me an email (which I'm relaying with permission) saying that he feels the TAPx::Parser distributi

Using pip to get testing done better and faster...

2007-01-09 Thread Adam Kennedy
If anyone has been paying attention to my journal, you may have vaguely heard about "pip" (which I named mostly because it's cute, easy to type and not taken by anything other program in debian, but which we can also call the "Perl Installer Program" if people like). One feature I just added i

Re: TAPx::Parser 0.05_03

2007-01-09 Thread Adam Kennedy
Ovid wrote: --- Adam Kennedy <[EMAIL PROTECTED]> wrote: One of the principles of PITA is that we do as little as possible inside the operating system image. That includes NOT calculating a judgement call for "PASS" or "FAIL" or at least ignoring it if it gets don

Re: TAPx::Parser 0.05_03

2007-01-09 Thread Adam Kennedy
As an aside, installs OK for me on Win32k... So far you're the only Windows person to tell me that. What version of Windows/Perl/TAPx::Parser are we talking about? Ook, sorry, looks like I only installed 0.41. BTW, why have you dropped the version number from so high to so low. Adam K

Re: TAPx::Parser 0.05_03

2007-01-08 Thread Adam Kennedy
Ovid wrote: It's on its way to the CPAN now. Thanks for lots of feedback. I'd really love to hear from Windows users as to whether or not it seems to work OK there. More feature requests welcome. Oh goody. OK, so let present a scenario PITA needs solved, and then you tell me if you solve it

Re: First try at sample test output.

2007-01-06 Thread Adam Kennedy
Ovid wrote: tbad/longtestfilenameFailed 2/10 tests (less 1 skipped test: 7 okay) (1 test unexpectedly succeeded) Is that last lines for a TODO? Because it just gave me a brief WTF moment. Might be better for clarity to use (1 TODO test unexpectedly succeeded) Adam K

Re: Comment about BAIL_OUT

2007-01-06 Thread Adam Kennedy
Michael G Schwern wrote: Ovid wrote: However, if you use the '-s' switch to shuffle your tests and bailout is not first, then some tests will run until the BAIL_OUT is hit. This seems to violate the principle that tests should be able to run in any order without dependencies. It doesn't viola

Re: Comment about BAIL_OUT

2007-01-06 Thread Adam Kennedy
What I did instead is moved all the setup and teardown stuff into simple functions, plopped them into modules in t/lib/ and had each test do: use lib 't/lib'; use MakeMaker::Test; setup_foo(); END { teardown_foo(); } You can even get clever and pack the setup/te

Re: Modules dealing with data files

2006-11-13 Thread Adam Kennedy
complicated? (I could just bundle the data file with the distribution, but the size of the data file, and the probability that the format is unlikely to change invites the above approach). Adam Kennedy wrote Data::Package after discovering fake modules that actually are just data. Not sure if it

Uses for TAP beyond just testing...

2006-11-09 Thread Adam Kennedy
I'm currently writing a deploy script for an website. As I'm writing it, it has occurred to me that I always want to check as I'm going that everything has happened correctly, that I want to print output for each step, and that ideally I'd like to be able to automatically run the deploy script

Re: P::C or PPI bug?

2006-11-07 Thread Adam Kennedy
I'm not sure you can reliably test that though, not to 100% anyway, given the problem of implicit params. is( foo $bar, $baz, $expected ); which means is( foo($bar, $baz), $expected ); Yes, his specific case is ok, but I think you need to be a bit cunning about how you check... Adam K Chr

Re: CPAN.pm to install only flagged versions of modules

2006-10-31 Thread Adam Kennedy
David Golden wrote: On 10/31/06, Gabor Szabo <[EMAIL PROTECTED]> wrote: In a way this is what Linux distros do or ActiveState does, but I would like to do it on CPAN level and still in source code. As a start I could possibly creat a minicpan for particular modules and their cross-tested version

Re: CPAN.pm to install only flagged versions of modules

2006-10-31 Thread Adam Kennedy
For those that missed it's release let me also mention that "pip" is out now. http://search.cpan.org/~adamk/Module-Plan-Base-0.04/lib/pip.pm This extends the Bundle idea to third party or arbitrary (such as backpan or whatever) modules. I wrote it because I wanted to install a specific set o

Re: Failing test on Windows

2006-10-27 Thread Adam Kennedy
chromatic wrote: On Wednesday 25 October 2006 07:41, Adam Kennedy wrote: I guess the tricky bit is measuring it, do we just look for -T in the test scripts? If we add this, it's definitely going to hurt me in the game, but I think it might be worth it. This may be a new Kwalitee m

Re: Failing test on Windows

2006-10-25 Thread Adam Kennedy
Adriano Rodrigues wrote: I think planning and testing your modules under -T is just being a good CPANizen; just like warnings/strict and writing pod. Hey, that could be the next optional metrics for CPANTS: run_under_taint. A bonus point for the ones that cared about it. It makes me afraid beca

Re: Failing test on Windows

2006-10-23 Thread Adam Kennedy
WORKSFORME on Strawberry alpha 2. I'm betting it's something to do with the -T, because the only difference I can think of is that the build is running inside some sort of alternative harness that does something differently... Out of curiosity, why are your tests set to use tainting? Adam K

Re: Pod Spelling

2006-10-04 Thread Adam Kennedy
In addition to my own modules, I've used it on Perl::Critic and PPI and (aside from Adam Kennedy's weird Aussie spelling!) and it worked great. That's about 29,000 lines of well-documented code -- I'm not sure if you consider that large or not. Perl::Critic currently has 29 stopwords not incl

Re: Proposal for author test envvar standard (was Re: Suggestionsfor cpantesters)

2006-10-04 Thread Adam Kennedy
Chris Dolan wrote: On Oct 3, 2006, at 11:04 PM, Adam Kennedy wrote: I'd ideally like to keep this constrained to a single environment variable. These tests are all the same sort of thing, tests that you run before you release, but not otherwise. If so, there's th

Re: Proposal for author test envvar standard (was Re: Suggestionsfor cpantesters)

2006-10-03 Thread Adam Kennedy
where is any string likely not to collide with other developers or projects. It would be used like this in a .t file: use strict; use Test::More; if (!$ENV{PERL_DEV_TEST} && !$ENV{PERL_DEV_TEST_PERLCRITIC}) { plan skip_all => 'Developer test'; } plan ... Is that good enough?

Re: Proposal for author test envvar standard (was Re: Suggestionsfor cpantesters)

2006-10-03 Thread Adam Kennedy
Christopher H. Laco wrote: Chris Dolan wrote: On Oct 3, 2006, at 11:13 AM, David Golden wrote: Given what you use, perhaps qr/AUTHOR_TEST/ is a good idea. That's cool. Then I could do C in my .t files and just set that to 1 in my .cshrc for all time. I've seen discussion of the right env va

Re: ANNOUNCE: Perl::Metrics::Simple - alpha version

2006-10-03 Thread Adam Kennedy
Michael Peters wrote: Matisse Enzer wrote: I uploaded an alpha version to the CPAN yesterday: http://search.cpan.org/dist/Perl-Metrics-Simple/ There is an included script, in the examples/ directory which produces output like this: Looks useful. My only suggestion is to rename the examp

Testing... ignore

2006-10-03 Thread Adam Kennedy

Re: Breaking compatability with Test::Harness and friends?

2006-09-16 Thread Adam Kennedy
What I find surprising is the concept that a TODO test is assumed to fail. If I mark a test (block) as TODO, I would have thought by flagging some tests as not done yet then for the purposes of PASS/FAIL I don't care what the result it. Broken or incomplete code may still have a failure mode

Re: New TAP Grammar

2006-09-14 Thread Adam Kennedy
It might be worth running Perl::MinimumVersion over the codebase real quick. It has all the obvious stuff coded into it (like warnings and qr//) already. Adam K Michael G Schwern wrote: Ovid wrote: Also, for purposes of backwards compatability, I'm concerned about qr// and $code->(). When we

Re: Too many tests

2006-09-14 Thread Adam Kennedy
How else are you going to deal with "you've run more tests than you said you were"? If you accept the results and assume the count is wrong how do you know what the program didn't silently die part way through and in fact you are dealing with a catastrophic failure in the middle of more tests th

Re: TidyView - preview your perltidy options

2006-09-14 Thread Adam Kennedy
Ovid wrote: - Original Message ---- From: Adam Kennedy <[EMAIL PROTECTED]> Please excuse the stupid question, but is there any chance this could use Wx instead of Tk, since Wx installs from CPAN cleanly everywhere now (I think) and Tk doesn't seem to install properly. I fina

Re: TidyView - preview your perltidy options

2006-09-14 Thread Adam Kennedy
And the second obvious question, while I'm thinking about it... When will we be able to install this from CPAN? :) Adam K [EMAIL PROTECTED] wrote: Hi all, I have release a pet project on Sourceforge called TidyView, at https://sourceforge.net/projects/tidyview/

Re: TidyView - preview your perltidy options

2006-09-14 Thread Adam Kennedy
Please excuse the stupid question, but is there any chance this could use Wx instead of Tk, since Wx installs from CPAN cleanly everywhere now (I think) and Tk doesn't seem to install properly. But then I imagine moving to Wx would mean a HUGE amount of code to change... Adam K [EMAIL PROTE

Re: CPANTS quality brainstorming

2006-09-14 Thread Adam Kennedy
David Cantrell wrote: Adam Kennedy wrote: Agreed, while the META.yml key is the simplest way, it should be possible to locate the most common patterns for licensing, such at the typical COPYRIGHT POD block that often contains "... is licensed ..." etc. Or licenced. Please rememb

Re: CPANTS quality brainstorming

2006-09-13 Thread Adam Kennedy
brian d foy wrote: In article <[EMAIL PROTECTED]>, Thomas Klausner <[EMAIL PROTECTED]> wrote: I added a few things, most notably the new has_license metric (thanks again to Gabor Szabo for implementing it). (BTW, there was quite a drop in the CPANTS game highscore lists, as lots of dists don't

Re: post-YAPC::Europe CPANTS news

2006-09-13 Thread Adam Kennedy
David Golden wrote: Adam Kennedy wrote: But with that in mind, I still don't see much point in running them at install-time, so lately I've modified my pod.t test so that it's skip message is now "skipped: Author tests not required for installation" or the like, a

Re: Installing Tests

2006-09-12 Thread Adam Kennedy
Frankly, I think anything you might write to try and pick and choose what to install is going to have problems. Since we're wasting... ermm... using all this extra disk space for tests anyway, why not just do the lot. Take the entire distribution post-make and just tarball that up and save i

Re: RFC:: Test::Example

2006-09-12 Thread Adam Kennedy
I think you've made an invalid assumption that examples will just happen to have a console or input/output interface. How do I show an example of using Wx.pm by implementing Windows Notepad in the example. Or a POE asyncronous application, or a curses interface, and so on. Adam K Gabor Szab

Re: post-YAPC::Europe CPANTS news

2006-09-12 Thread Adam Kennedy
Gabor Szabo wrote: On 9/13/06, Thomas Klausner <[EMAIL PROTECTED]> wrote: In theory, we can now remove some of the very simple metrics (that might not make that much sense), i.e. has_test_pod (no_pod_errors is much better) and has_test_pod_coverage The main reason why they're still here is beca

Re: post-YAPC::Europe CPANTS news

2006-09-11 Thread Adam Kennedy
Of course some authors don't care about having a community around their software, and some don't consider their CPAN package as "important" or "big" enough to warrant a community (despite it probably being licensed with an open source-friendly license). These people are entirely free to continu

Re: post-YAPC::Europe CPANTS news

2006-09-08 Thread Adam Kennedy
Salve J Nilsen wrote: Thomas Klausner wrote: Oh, and if you want to join the fun and help a bit, here's a (probably incomplete) list of tasks: - Metrics: [snip] Would the metrics for community support channels that were suggested a while ago be welcome? (The discussion about them sort of di

Re: post-YAPC::Europe CPANTS news

2006-09-08 Thread Adam Kennedy
Thomas Klausner wrote: Hi! On Thu, Sep 07, 2006 at 10:23:39AM +1000, Adam Kennedy wrote: - has_example I thought we were generally negative on this one, because it would encourage people to spuriously add trivial example directories to their distributions... Yes, but I've rec

Re: post-YAPC::Europe CPANTS news

2006-09-08 Thread Adam Kennedy
Michael Peters wrote: Adam Kennedy wrote: It might be an interesting idea to also add a "dependencies_exist" metric, that makes sure that all the dependencies that are declared actually exist in the CPAN. Dunno, could be of dubiously little value, but I just managed to some

Re: post-YAPC::Europe CPANTS news

2006-09-06 Thread Adam Kennedy
Anything that would make the quality of the reviews worse (or malicious) isn't a negative thing. Or rather, it IS a negative thing. :) Adam K

Re: post-YAPC::Europe CPANTS news

2006-09-06 Thread Adam Kennedy
Thomas Klausner wrote: Hi! During YAPC::Europe in Birmingham I did a (rather short and un-hackish) hackathon. Slides are available here: http://domm.plix.at/talks/2006_birmingham_cpants/ During YAPC, I added a few new metrics: - manifest_matches_dist Check if the stuff listed in MANIFEST ma

Re: post-YAPC::Europe CPANTS news

2006-09-06 Thread Adam Kennedy
Jonathan Rockway wrote: I could be wrong here, but I think the check is to make sure that tar doesn't set +x on Makefile.PL or Build.PL, thus forcing the user to run the proper version of perl instead of automagically running the perl that shebang points to. (Example: Makefile.PL says #!/usr/bin

Re: Terrible diagnostic failure

2006-09-04 Thread Adam Kennedy
Ovid wrote: - Original Message From: Andy Lester <[EMAIL PROTECTED]> I think I might just JFDI a "T::H goes to STDOUT" release. You can call it the "Ovid wants to have Petdance's children" release. Anyone care to place bets as to whether or not anything depends on this behavior?

Re: Terrible diagnostic failure

2006-09-04 Thread Adam Kennedy
Rafael Garcia-Suarez wrote: Ovid wrote in perl.qa : I've had similar issues with test output out of sequence, especially when I pipe the output into more or tee (sometimes 2>&1 helps, but not always). What about an optional environment variable which forcess *all* output to STDOUT or STDERR bu

Re: Counting files, lines, packages, subs in Perl

2006-09-04 Thread Adam Kennedy
I should also note that ADAMK's Perl::Metrics provides a heavy-weight alternative, using Class::DBI to persist metrics data. At present I'm interested in something with fewer dependencies. Well, it doesn't do the actual metrics. It's a platform for doing the processing and storage of metrics,

Re: [Module::Build] Yikes! Module::Build 0.2804 produces META.ymlwithversion objects

2006-08-06 Thread Adam Kennedy
David Golden wrote: Steffen Mueller wrote: John Peacock schrieb: David Golden wrote: (Though technically, it really ought to check that the ref equals "Module::Build::Version"). No, that would be wrong too. Never test a ref() against a specific object class, since it paints you into a corn

Re: Running a CPAN Testers installation for Strawberry Perl

2006-08-02 Thread Adam Kennedy
Thanks Scott It appears, much to my surprise, that there is no published How To Set Up CPAN Testers that is current. Perhaps the QA List (cc'ed) could fill us both in on how to set one up? Adam K Scott wrote: Adam, I have downloaded and installed Strawberry Perl alpha 1 and have CPU cycles

Re: Module Signatures

2006-07-25 Thread Adam Kennedy
Andreas J. Koenig wrote: On Thu, 20 Jul 2006 02:35:02 +1000, Adam Kennedy <[EMAIL PROTECTED]> said: > On the other hand, give me an easy to use, works _everywhere_, never > fails falsely positive or negative, never crashes, low-dependency > security enhancement to CPAN

Re: [Module::Build] Yikes! Module::Build 0.2804 produces META.yml with version objects

2006-07-20 Thread Adam Kennedy
Gee, I love YAML. (Sigh.) You and me both. It's at this point I make very quiet noises about YAML::Tiny, and how it only supports ordinary data, so things like objects and circulars and other crazy things can't happen. It's not "done" yet, but the basics all should work. You might want

Re: Real Kwalitee, or please stop spending time thinking about CPANTS

2006-07-20 Thread Adam Kennedy
I've heard people commenting variants of "people will ignore perfectly good modules unless they have score Foo" or "people will use crap modules just because they have score Foo" - but I've never actually seen it happen in Real Life. Has anybody? Just a long as we don't show the CPANTS score

Re: Real Kwalitee, or please stop spending time thinking about CPANTS

2006-07-19 Thread Adam Kennedy
Andy Lester wrote: Don't worry about the game. But that's all I hear about is the game. It's all game game game game. The subset that like the game, also like to talk. The ones that don't care about the game, don't care to tell you about it. But one day they are going to discover CPANTS

Re: Kwalitee metric: Community support channels

2006-07-19 Thread Adam Kennedy
Salve J Nilsen wrote: Just a wild thought... Would it be useful to check for references to community support channels like mailing lists, IRC channels, public bug trackers and official web pages? One way to do this could be to look for relevant keywords in the META.yml file or to do simple

Re: Real Kwalitee, or please stop spending time thinking about CPANTS

2006-07-19 Thread Adam Kennedy
Andy Lester wrote: (... many things ...) And if you still have time or inclination to make CPANTS rules, have at it. Don't worry about the game. CPANTS is not about the game. The game is just a cute way to make a subset of authors pay more attention to cleaning their own cages. What CPANTS

  1   2   3   4   >