Re: [COMMITTERS] pgsql: Fix another join removal bug: the check on PlaceHolderVars was w

2010-09-26 Thread Andres Freund
On Sunday 26 September 2010 02:29:16 David Fetter wrote: On Sat, Sep 25, 2010 at 11:04:28PM +, Tom Lane wrote: Fix another join removal bug: the check on PlaceHolderVars was wrong. The previous coding would decide that join removal was unsafe upon finding a PlaceHolderVar that

Re: [COMMITTERS] pgsql: Add new SQL function, format(text).

2010-11-21 Thread Andres Freund
On Sunday 21 November 2010 04:34:37 Robert Haas wrote: Add new SQL function, format(text). Currently, three conversion format specifiers are supported: %s for a string, %L for an SQL literal, and %I for an SQL identifier. The latter two are deliberately designed not to overlap with what

Re: [COMMITTERS] pgsql: Revert the behavior of inet/cidr functions to not unpack the arg

2011-12-12 Thread Andres Freund
Hi, On Monday, December 12, 2011 09:29:23 AM Heikki Linnakangas wrote: Revert the behavior of inet/cidr functions to not unpack the arguments. Whats the plan to handle this wrt a stable release? We had one more report of this on irc and I got two calls from clients already. And I don't have

Re: [COMMITTERS] pgsql: Revert the behavior of inet/cidr functions to not unpack the arg

2011-12-12 Thread Andres Freund
On Monday, December 12, 2011 07:48:01 PM Tom Lane wrote: Andres Freund and...@anarazel.de writes: On Monday, December 12, 2011 09:29:23 AM Heikki Linnakangas wrote: Revert the behavior of inet/cidr functions to not unpack the arguments. Whats the plan to handle this wrt a stable release

Re: [COMMITTERS] pgsql: Dramatically reduce System V shared memory consumption.

2012-06-29 Thread Andres Freund
that you use size in the mmap... Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

Re: [COMMITTERS] pgsql: Provide some static-assertion functionality on all compilers.

2012-10-16 Thread Andres Freund
for StaticAssertStmt? Greetings, Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [COMMITTERS] pgsql: Provide some static-assertion functionality on all compilers.

2012-10-19 Thread Andres Freund
On Tuesday, October 16, 2012 11:50:48 PM Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On Monday, October 01, 2012 04:46:41 AM Tom Lane wrote: Provide some static-assertion functionality on all compilers. The current method used here doesn't allow the macro to be used

Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-21 Thread Andres Freund
the cache. Tests show a big speedup on Linux at least on some filesystems. Idea and patch from Andres Freund. I just found a relatively big problem with one of your modifications on the patch - you removed the FreeDir(xldir); xldir = AllocateDir(fromdir); pair - unfortunately its crucial because

Re: [COMMITTERS] pgsql: Must not reach consistency before XLOG_BACKUP_RECORD

2012-12-05 Thread Andres Freund
-- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Adjust many backend functions to return OID rather than void.

2012-12-24 Thread Andres Freund
not, I'll do that. There were some more of the same thing youve fixed, see the attached patch that fixes the rest, at least as far as I can see when compiling HEAD here. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [COMMITTERS] pgsql: Make pg_dump exclude unlogged table data on hot standby slaves

2013-01-25 Thread Andres Freund
On 2013-01-25 08:49:10 +, Magnus Hagander wrote: Make pg_dump exclude unlogged table data on hot standby slaves This missed the fact that there is no ExecuteSqlQueryForSingleRow and surroundign infrastructure. Fix attached. Greetings, Andres Freund -- Andres Freund

Re: [COMMITTERS] pgsql: Make pg_dump exclude unlogged table data on hot standby slaves

2013-01-25 Thread Andres Freund
On 2013-01-25 13:56:11 +0100, Magnus Hagander wrote: On Fri, Jan 25, 2013 at 1:31 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-01-25 08:49:10 +, Magnus Hagander wrote: Make pg_dump exclude unlogged table data on hot standby slaves This missed the fact

Re: [COMMITTERS] pgsql: Fill tuple before HeapSatisfiesHOTAndKeyUpdate

2013-02-01 Thread Andres Freund
(not having been set for the new tuple), which is an indexed column. While at it, make sure to set the tableoid early in both old and new tuples as well. This isn't of much consequence, since that column is seldom (never?) indexed. Report and patch from Andres Freund

Re: [COMMITTERS] pgsql: Move Assert() definitions to c.h

2013-02-01 Thread Andres Freund
. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [COMMITTERS] pgsql: Add noreturn attributes to some error reporting functions

2013-02-12 Thread Andres Freund
incatation is transparently. And perhaps other compilers in the future. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers

Re: [COMMITTERS] pgsql: Blind attempt at fixing the non-MSVC Windows builds

2013-02-22 Thread Andres Freund
On 2013-02-22 12:34:19 -0300, Alvaro Herrera wrote: Andres Freund wrote: On 2013-02-22 14:55:06 +, Alvaro Herrera wrote: Blind attempt at fixing the non-MSVC Windows builds Apparently, they need -DBUILDING_DLL for the Assert() declarations to work correctly. More

Re: [COMMITTERS] pgsql: Blind attempt at fixing the non-MSVC Windows builds

2013-02-28 Thread Andres Freund
assert_enabled; is one. So that seems like the appropriate fix. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org

Re: [COMMITTERS] pgsql: Avoid tricky race condition recording XLOG_HINT

2013-04-08 Thread Andres Freund
catversion's ;) Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

Re: [COMMITTERS] pgsql: Reorder 9.3 release note items

2013-04-21 Thread Andres Freund
mention bug fixes. I changed Correct to Fix in a later commit. But we usually don't if they have been fixed in a previous point release in the back branches, right? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [COMMITTERS] pgsql: Reorder 9.3 release note items

2013-04-21 Thread Andres Freund
facility Should mention Heikki as primary author instead of me. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make

Re: [COMMITTERS] pgsql: Reorder 9.3 release note items

2013-04-22 Thread Andres Freund
replication log shipping and standby promotion (Andres Freund, Simon Riggs) Um, it's hard to see how that text relates to what I requested. It's an important thing for High Availability that failover is now fast; a feature we have been waiting for some time. The point

Re: [COMMITTERS] pgsql: Permit super-MaxAllocSize allocations with MemoryContextAllocHug

2013-07-02 Thread Andres Freund
isn't good... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

Re: [COMMITTERS] pgsql: Allow background workers to be started dynamically.

2013-07-19 Thread Andres Freund
in releasing 9.3 when we already know which trivial but breaking change will be required for 9.4 Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list

Re: [COMMITTERS] pgsql: Stamp 9.3.0.

2013-09-09 Thread Andres Freund
Hi, On 2013-09-02 20:54:06 +, Tom Lane wrote: Stamp 9.3.0. Branch -- REL9_3_STABLE 9.3.0 seems to be officially released now, but there's no 9.3.0 tag yet... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [COMMITTERS] pgsql: Use a new hstore extension version for added json functions.

2013-09-30 Thread Andres Freund
is underspecified because it doesn't restrict classid, just refclassid. That might lead to problems if extensions depend on each others and such. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent

Re: [COMMITTERS] pgsql: Add WaitForLockers in lmgr, refactoring index.c code

2013-10-01 Thread Andres Freund
Hi, On 2013-10-01 21:00:43 +, Alvaro Herrera wrote: Add WaitForLockers in lmgr, refactoring index.c code This is in support of a future REINDEX CONCURRENTLY feature. I think this removes too many comments from index_drop that explains why it's done that way. Greetings, Andres Freund

Re: [COMMITTERS] pgsql: Fix pg_isolation_regress to work outside its build directory.

2013-11-09 Thread Andres Freund
think of is to store argv[0] in a global variable and to run the find_other_exec() in the first run through isolation_start_test() :/. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent

Re: [COMMITTERS] pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

2013-11-10 Thread Andres Freund
Hi, On 2013-06-06 14:22:12 +, Robert Haas wrote: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page. This didn't make it to the release notes for 9.2.5. Since there have been several people asking for it since, can we maybe add it retroactively? Greetings, Andres Freund

Re: [COMMITTERS] pgsql: Fix pg_isolation_regress to work outside its build directory.

2013-11-12 Thread Andres Freund
On 2013-11-09 15:13:14 +0100, Andres Freund wrote: Hi, On 2013-11-08 20:02:30 +, Robert Haas wrote: Fix pg_isolation_regress to work outside its build directory. This makes it possible to, for example, use the isolation tester to test a contrib module. Unfortunately this isn't

Re: [COMMITTERS] pgsql: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized pag

2013-11-18 Thread Andres Freund
On 2013-11-18 16:33:25 -0500, Bruce Momjian wrote: On Sun, Nov 10, 2013 at 11:51:06PM +0100, Andres Freund wrote: Hi, On 2013-06-06 14:22:12 +, Robert Haas wrote: Ensure that XLOG_HEAP2_VISIBLE always targets an initialized page. This didn't make it to the release notes

Re: [COMMITTERS] pgsql: Improve draft release notes.

2013-12-02 Thread Andres Freund
the back-branch notes, but this is just a working copy at the moment. FWIW I vote for leaving them in, even though it admittedly only helps the few people looking at the sgml, it is quite useful information. I wish it always had been in there. Greetings, Andres Freund -- Andres Freund

Re: [COMMITTERS] pgsql: Get rid of pg_class.reltoastidxid.

2014-01-15 Thread Andres Freund
because usually the older index will still be valid when we open the toast indexes when there are multiple ones and RelationGetIndexList() returns indexes in toast order. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Andres Freund
code to recreate pg_replslot on startup, similar to pg_xlog? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-01 Thread Andres Freund
On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-01 16:47:47 +0900, Fujii Masao wrote: This patch changed basebackup.c so that it skips pg_replslot. It's OK to skip all files in that directory

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-02 Thread Andres Freund
On 2014-02-02 14:44:17 +0900, Fujii Masao wrote: On Sat, Feb 1, 2014 at 6:37 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-01 18:33:08 +0900, Fujii Masao wrote: On Sat, Feb 1, 2014 at 6:09 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-01 16:47:47 +0900, Fujii

Re: [COMMITTERS] pgsql: Clean up some sloppy coding in repl_gram.y.

2014-02-03 Thread Andres Freund
? This seems to have fixed protosciurus. That's an odd cause for a segfault in bison... Thanks, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers

Re: [COMMITTERS] pgsql: Add pg_stat_archiver statistics view.

2014-02-03 Thread Andres Freund
). Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-06 Thread Andres Freund
pg_basebackup. Attached patch fixes this problem. Do you plan to commit this patch? It's clearly an improvement over the current situation... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent

Re: [COMMITTERS] pgsql: Minor pg_dump improvements

2014-02-11 Thread Andres Freund
] if ((AH-format = fgetc(fh)) == EOF) ^ ~~~ 1 warning generated. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql

Re: [COMMITTERS] pgsql: Assert(IsTransactionState()) in RelationIdGetRelation().

2014-02-11 Thread Andres Freund
with start processing, set current transaction state to in * progress */ s-state = TRANS_INPROGRESS; } Not immediately sure how to handle this, except adding another state test function allowing TRANS_START|INPROGRESS|COMMIT? Greetings, Andres Freund -- Andres Freund

Re: [COMMITTERS] pgsql: Assert(IsTransactionState()) in RelationIdGetRelation().

2014-02-11 Thread Andres Freund
On 2014-02-11 14:45:00 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-02-06 16:28:23 +, Tom Lane wrote: Assert(IsTransactionState()) in RelationIdGetRelation(). Hm, I am not sure if it works this way. In a patched postgres I just got: #2

Re: [COMMITTERS] pgsql: Kill pg_basebackup background process when exiting

2014-02-12 Thread Andres Freund
/pg_basebackup.c:105: error: (Each undeclared identifier is reported only once /pgbuild/root/HEAD/pgsql.39771/../pgsql/src/bin/pg_basebackup/pg_basebackup.c:105: error: for each function it appears in.) that's #include sys/types.h #include signal.h Greetings, Andres Freund -- Andres

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-14 Thread Andres Freund
). According to a quick search that's caused by a bug in mingw... http://sourceforge.net/p/mingw/bugs/2020/ and some others. Any chance you could update to a slighly newer version? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andres Freund
often does it build master? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription

Re: [COMMITTERS] pgsql: Use --disable-auto-import linker switch in Mingw builds, too.

2014-02-15 Thread Andres Freund
On 2014-02-15 10:02:39 -0500, Andrew Dunstan wrote: On 02/15/2014 09:49 AM, Andres Freund wrote: On 2014-02-15 09:47:08 -0500, Andrew Dunstan wrote: However, the build now fails like this: pg_buffercache_pages.o: In function `pg_buffercache_pages': c:/MinGW/msys/1.0/home/pgrunner

Re: [COMMITTERS] pgsql: First-draft release notes for 9.3.3.

2014-02-16 Thread Andres Freund
interrupts from taking control away from mainline code unless varnameImmediateInterruptOK/ is set (Andres Freund, Tom Lane) /para para This was initially reported as a quotestuck spinlock/ failure, but many other misbehaviors are possible after a statement timeout

Re: [COMMITTERS] pgsql: Add a GUC to report whether data page checksums are enabled.

2014-02-18 Thread Andres Freund
it a new feature, so not back-patching was the default. If you want to back-patch it, I won't object. Imo it's essentially a simple oversight in the checksum patch... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-19 Thread Andres Freund
))) possibly truncate the value if it's larger than 2^(63-1) as int is signed but XLogRecPtr is unsigned? I am afraid you're going to have to copy the whole #ifdef USE_FLOAT8_BYVAL dance. Not that it's too likely to have that big values in reality atm... Greetings, Andres Freund -- Andres Freund

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-19 Thread Andres Freund
On 2014-02-20 08:25:01 +0200, Heikki Linnakangas wrote: On 02/20/2014 02:56 AM, Andres Freund wrote: On 2014-02-19 15:10:52 +, Robert Haas wrote: Change input function error messages to be more consistent with what is done elsewhere. Remove a bunch of redundant type casts, so

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-20 Thread Andres Freund
On 2014-02-20 10:22:30 +0200, Heikki Linnakangas wrote: On 02/20/2014 09:47 AM, Andres Freund wrote: On 2014-02-20 08:25:01 +0200, Heikki Linnakangas wrote: On 02/20/2014 02:56 AM, Andres Freund wrote: Hm, won't #define DatumGetLSN(X) ((XLogRecPtr) DatumGetInt64(X)) #define LSNGetDatum(X

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-20 Thread Andres Freund
On 2014-02-20 09:59:51 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: 6.3.1.3 Signed and unsigned integers, paragraph 3: Otherwise, the new type is signed and the value cannot be represented in it; either the result is implementation-defined or an implementation

Re: [COMMITTERS] pgsql: Further code review for pg_lsn data type.

2014-02-20 Thread Andres Freund
On 2014-02-20 10:25:20 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-02-20 09:59:51 -0500, Tom Lane wrote: I think you're making a problem out of nothing. We have considerably more-real portability issues to worry about, like memory ordering. I don't think

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-27 Thread Andres Freund
Hi, Vik Faering noticed a couple of oversights in the replication slot function reference, and I noticed some more, including using the text type instead of name, while looking. Patch attached. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com

Re: [COMMITTERS] pgsql: Fix WAL replay of locking an updated tuple

2014-02-27 Thread Andres Freund
lock level. The bug exactly was that the ctid chain was destroyed when there were later tuples. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql

Re: [COMMITTERS] pgsql: Introduce replication slots.

2014-02-28 Thread Andres Freund
. libpqrcv_startstreaming is truncating the identifier if it's too long... Patch fixing that attached. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services diff --git a/src/backend/replication

Re: [COMMITTERS] pgsql: Add pg_recvlogical, a tool to receive data logical decoding data

2014-03-18 Thread Andres Freund
purposes, and this does provide it. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

Re: [COMMITTERS] pgsql: Add pg_recvlogical, a tool to receive data logical decoding data

2014-03-18 Thread Andres Freund
of mine, added when introducing the fsyncing of the outputfile. There's a unitialized variable usage when both --status-interval and --fsync-interval are set to zero/disabled. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-18 Thread Andres Freund
are always schema prefixed, instead of just when required because of search_path? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers

Re: [COMMITTERS] pgsql: Remove rm_safe_restartpoint machinery.

2014-03-18 Thread Andres Freund
Hi, On 2014-03-18 20:11:37 +, Heikki Linnakangas wrote: Remove rm_safe_restartpoint machinery. Neato, but I think you forgot to update contrib/pg_xlogdump. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-19 Thread Andres Freund
On 2014-03-19 21:59:25 +0900, Fujii Masao wrote: Attached patch changes the example that way and does some minor improvements. That patch is fine with me. Thanks, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription

Re: [COMMITTERS] pgsql: Documentation for logical decoding.

2014-03-19 Thread Andres Freund
receiving logical changes... I plan to make a pass through the file, but I probably won't get to it this week. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-21 Thread Andres Freund
to be an enum's name, not a variable name, right? -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services diff --git a/src/include/access/gin.h b/src/include/access/gin.h index 75a86c4..36a6c6b 100644 --- a/src/include/access/gin.h

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-21 Thread Andres Freund
On 2014-03-21 17:37:35 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: I think the GinLogicValueEnum is supposed to be an enum's name, not a variable name, right? I think the whole thing is too cute by half. Why isn't it just typedef enum GinLogicValue

Re: [COMMITTERS] pgsql: Allow opclasses to provide tri-valued GIN consistent functions.

2014-03-31 Thread Andres Freund
prohibits that... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http

Re: [COMMITTERS] pgsql: Get rid of the dynamic shared memory state file.

2014-04-08 Thread Andres Freund
would trigger during initdb. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription

Re: [COMMITTERS] pgsql: Get rid of the dynamic shared memory state file.

2014-04-08 Thread Andres Freund
On 2014-04-08 16:17:46 -0400, Robert Haas wrote: On Tue, Apr 8, 2014 at 4:14 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-04-08 15:45:39 +, Robert Haas wrote: Get rid of the dynamic shared memory state file. Instead of storing the ID of the dynamic shared memory control

Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Andres Freund
of, +* that gives the offset to the next element, if required +*/ Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers

Re: [COMMITTERS] pgsql: Several fixes to array handling in ecpg.

2014-04-09 Thread Andres Freund
to tell me here, other than that the wording is unclear. To me that looks like somebody tried to rewrite a comment and stopped somewhere in the middle. I don't think anybody trying to read that code in the future is going to understand it. Greetings, Andres Freund -- Andres Freund

Re: [COMMITTERS] pgsql: Fix quiet inline configure test for newer clang compilers.

2014-05-02 Thread Andres Freund
Hi, On 2014-05-01 20:16:48 +, Tom Lane wrote: Fix quiet inline configure test for newer clang compilers. Since it doesn't seem to have caused any problems I think this should be backpatched. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com

Re: [COMMITTERS] pgsql: Revive line type

2014-05-05 Thread Andres Freund
to the changed length of the line type. Patch attached. That oversight leads to accesses beyond the length of the tuple in routines like datumCopy(). Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services diff

Re: [COMMITTERS] pgsql: Revive line type

2014-05-05 Thread Andres Freund
On 2014-05-05 13:24:15 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2013-10-10 02:43:20 +, Peter Eisentraut wrote: Revive line type That commit missed to update pg_type.h to the changed length of the line type. Patch attached. Ouch. Good thing we caught

Re: [COMMITTERS] pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.

2014-05-05 Thread Andres Freund
://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouthdt=2014-05-05%2018%3A30%3A01 Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org

Re: [COMMITTERS] pgsql: Again fix initialization of auto-tuned effective_cache_size.

2014-05-05 Thread Andres Freund
have a function in costsize.c that returns the actual value and computes it based on NBuffers if set to -1? Which is also called by a show_hook? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services

Re: [COMMITTERS] pgsql: Properly detect read and write errors in pg_dump/dumpall, and pg

2014-05-06 Thread Andres Freund
’ but argument is of type ‘struct FILE *’ ZEXTERN int ZEXPORT gzeof OF((gzFile file)); ^ You're passing fh to GZEOF instead of th-zFH if I see that correctly. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [COMMITTERS] pgsql: Fix unaligned accesses in DecodeUpdate().

2014-05-17 Thread Andres Freund
is active. Yes, that's impossible. It'd be a bit pointless to decode an update where the new value isn't available. Would kinda hurt while replicability... Thanks for fixing. Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

[COMMITTERS] pgsql: Silence a couple of spurious valgrind warnings in inval.c.

2014-05-24 Thread Andres Freund
Silence a couple of spurious valgrind warnings in inval.c. Define padding bytes in SharedInvalidationMessage structs to be defined. Otherwise the sinvaladt.c ringbuffer, which is accessed by multiple processes, will cause spurious valgrind warnings about undefined memory being used. That's

[COMMITTERS] pgsql: Don't allocate memory inside an Assert() iff in a critical secti

2014-05-25 Thread Andres Freund
Don't allocate memory inside an Assert() iff in a critical section. HeapTupleHeaderGetCmax() asserts that it is only used if the tuple has been updated by the current transaction. That check is correct and sensible but requires allocating memory if xmax is a multixact. When wal_level is set to

[COMMITTERS] pgsql: Fix pg_recvlogical to accept the documented -I instead only --st

2014-05-25 Thread Andres Freund
Fix pg_recvlogical to accept the documented -I instead only --startpos. The bug was caused by omitting 'I:' from the short argument list to getopt_long(). To make similar bugs in the future less likely reorder options in --help, long and short option lists to be in the same, alphabetical within

Re: [COMMITTERS] pgsql: Improve generation algorithm for database system identifier.

2014-05-27 Thread Andres Freund
noticed that pg_resetxlog.c has a copy of the identifer generation algorithm that's not been adjusted by that commit. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql

Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

2014-05-28 Thread Andres Freund
and interpreted it differently: By accident *only* the = syntax worked for a long time. Then somewhere around 2.8 they added the syntax without =. That means that 2.8 versions are likely not to work anymore. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com

Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

2014-05-28 Thread Andres Freund
On 2014-05-28 22:55:28 +0200, Andres Freund wrote: Hi, On 2014-05-28 19:42:35 +, Tom Lane wrote: Fix bogus %name-prefix option syntax in all our Bison files. %name-prefix doesn't use an = sign according to the Bison docs, but it silently accepted one anyway, until Bison 3.0

[COMMITTERS] pgsql: Don't pay heed to wal_sender_timeout while creating a decoding s

2014-05-28 Thread Andres Freund
Don't pay heed to wal_sender_timeout while creating a decoding slot. Sometimes CREATE_REPLICATION_SLOT ... LOGICAL ... needs to wait for further WAL using WalSndWaitForWal(). That used to always respect wal_sender_timeout and kill the session when waiting long enough because no feedback/ping

Re: [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-05-28 Thread Andres Freund
. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [COMMITTERS] pgsql: Reset master xmin when hot_standby_feedback disabled.

2014-05-28 Thread Andres Freund
On 2014-05-28 23:39:56 +0100, Simon Riggs wrote: On 28 May 2014 23:36, Andres Freund and...@2ndquadrant.com wrote: On 2013-02-04 10:35:31 +, Simon Riggs wrote: Reset master xmin when hot_standby_feedback disabled. If walsender has xmin of standby then ensure we reset the value to 0

Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

2014-05-28 Thread Andres Freund
. Maybe after a configure test for the option. All deprecation warnings so far seem to be pretty unhelpful. Btw, the bison release process and documentation suck. Majorly. The most efficient way to learn about changes seems to be to look at the git repository. Andres -- Andres Freund

Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

2014-05-28 Thread Andres Freund
On 2014-05-28 19:12:44 -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-05-28 18:52:22 -0400, Tom Lane wrote: and IMO we should also lobby the Bison people to not emit the deprecation warnings yet. That's a good idea. What i've been thinking about is to add

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

2014-05-29 Thread Andres Freund
On 2014-05-29 08:33:05 -0400, Peter Eisentraut wrote: On 5/28/14, 7:02 PM, Andres Freund wrote: That's a good idea. What i've been thinking about is to add -Wno-deprecated to the bison rule in the interim. Maybe after a configure test for the option. All deprecation warnings so far seem

[COMMITTERS] pgsql: Improvements to the replication protocol documentation.

2014-05-31 Thread Andres Freund
Improvements to the replication protocol documentation. Document the CREATE_REPLICATION_SLOT's output_plugin parameter; that START_REPLICATION ... LOGICAL takes parameters; that START_REPLICATION ... LOGICAL uses the same messages as ... PHYSICAL; and be more consistent with the usage of

[COMMITTERS] pgsql: Use unaligned output in another regression test query to reduce

2014-06-03 Thread Andres Freund
Use unaligned output in another regression test query to reduce diff noise. Use the unaligned/no rowcount output mode in a regression tests that shows all built-in leakproof functions. Currently a new leakproof function will often change the alignment of all existing functions, making it hard to

[COMMITTERS] pgsql: Set the process latch when processing recovery conflict interrup

2014-06-03 Thread Andres Freund
Set the process latch when processing recovery conflict interrupts. Because RecoveryConflictInterrupt() didn't set the process latch anything using the latter to wait for events didn't get notified about recovery conflicts. Most latch users are never the target of recovery conflicts, which

[COMMITTERS] pgsql: Set the process latch when processing recovery conflict interrup

2014-06-03 Thread Andres Freund
Set the process latch when processing recovery conflict interrupts. Because RecoveryConflictInterrupt() didn't set the process latch anything using the latter to wait for events didn't get notified about recovery conflicts. Most latch users are never the target of recovery conflicts, which

[COMMITTERS] pgsql: Set the process latch when processing recovery conflict interrup

2014-06-03 Thread Andres Freund
Set the process latch when processing recovery conflict interrupts. Because RecoveryConflictInterrupt() didn't set the process latch anything using the latter to wait for events didn't get notified about recovery conflicts. Most latch users are never the target of recovery conflicts, which

[COMMITTERS] pgsql: Set the process latch when processing recovery conflict interrup

2014-06-03 Thread Andres Freund
Set the process latch when processing recovery conflict interrupts. Because RecoveryConflictInterrupt() didn't set the process latch anything using the latter to wait for events didn't get notified about recovery conflicts. Most latch users are never the target of recovery conflicts, which

[COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
Fix longstanding bug in HeapTupleSatisfiesVacuum(). HeapTupleSatisfiesVacuum() didn't properly discern between DELETE_IN_PROGRESS and INSERT_IN_PROGRESS for rows that have been inserted in the current transaction and deleted in a aborted subtransaction of the current backend. At the very least

[COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
Fix longstanding bug in HeapTupleSatisfiesVacuum(). HeapTupleSatisfiesVacuum() didn't properly discern between DELETE_IN_PROGRESS and INSERT_IN_PROGRESS for rows that have been inserted in the current transaction and deleted in a aborted subtransaction of the current backend. At the very least

[COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
Fix longstanding bug in HeapTupleSatisfiesVacuum(). HeapTupleSatisfiesVacuum() didn't properly discern between DELETE_IN_PROGRESS and INSERT_IN_PROGRESS for rows that have been inserted in the current transaction and deleted in a aborted subtransaction of the current backend. At the very least

[COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
Fix longstanding bug in HeapTupleSatisfiesVacuum(). HeapTupleSatisfiesVacuum() didn't properly discern between DELETE_IN_PROGRESS and INSERT_IN_PROGRESS for rows that have been inserted in the current transaction and deleted in a aborted subtransaction of the current backend. At the very least

[COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
Fix longstanding bug in HeapTupleSatisfiesVacuum(). HeapTupleSatisfiesVacuum() didn't properly discern between DELETE_IN_PROGRESS and INSERT_IN_PROGRESS for rows that have been inserted in the current transaction and deleted in a aborted subtransaction of the current backend. At the very least

[COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
Fix longstanding bug in HeapTupleSatisfiesVacuum(). HeapTupleSatisfiesVacuum() didn't properly discern between DELETE_IN_PROGRESS and INSERT_IN_PROGRESS for rows that have been inserted in the current transaction and deleted in a aborted subtransaction of the current backend. At the very least

Re: [COMMITTERS] pgsql: Fix longstanding bug in HeapTupleSatisfiesVacuum().

2014-06-04 Thread Andres Freund
On 2014-06-04 18:03:29 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: As this bug goes back all the way to the introduction of subtransactions in 573a71a5da backpatch to all supported releases. I see no patches against 9.1 or 9.3? Hm. I accidentally passed -n to push

  1   2   3   4   5   6   7   8   9   10   >