On 20.03.23 03:33, Andres Freund wrote:
I did end up getting stuck when hacking on this, and ended up adding css
support for nochunk and support for the website style for htmlhelp and
nochunk, as well as obsoleting the need for copying the css files... But
perhaps that's a bit too much.
Updated
po 20. 3. 2023 v 11:24 odesílatel Matthias van de Meent
napsal:
>
> On Mon, 20 Mar 2023 at 11:11, Tomas Vondra
> wrote:
> >
> > On 3/14/23 15:41, Matthias van de Meent wrote:
> > > On Tue, 14 Mar 2023 at 14:49, Tomas Vondra
> > > wrote:
> > >>
> > >>> ...
> > >
> > >> If you agree with these cha
On Sun, Mar 19, 2023 at 4:59 PM Jeevan Ladhe wrote:
>
> Hi,
>
> I observed absurd behaviour while using pg_logical_slot_peek_changes()
> and pg_logical_slot_get_changes(). Whenever any of these two functions
> are called to read the changes using a decoder plugin, the following
> messages are prin
On Mon, 20 Mar 2023 at 11:11, Tomas Vondra
wrote:
>
> On 3/14/23 15:41, Matthias van de Meent wrote:
> > On Tue, 14 Mar 2023 at 14:49, Tomas Vondra
> > wrote:
> >>
> >>> ...
> >
> >> If you agree with these changes, I'll get it committed.
> >
> > Yes, thanks!
> >
>
> I've tweaked the patch per th
On Mon, Mar 20, 2023 at 1:02 PM Peter Smith wrote:
>
>
> ==
> src/include/catalog/pg_proc.dat
>
> 4.
> +{ oid => '6119',
> + descr => 'get information of the tables in the given publication array',
>
> Should that be worded in a way to make it more clear that the
> "publication array" is real
On 3/14/23 15:41, Matthias van de Meent wrote:
> On Tue, 14 Mar 2023 at 14:49, Tomas Vondra
> wrote:
>>
>>> ...
>
>> If you agree with these changes, I'll get it committed.
>
> Yes, thanks!
>
I've tweaked the patch per the last round of comments, cleaned up the
commit message a bit (it still t
After the discussion in [0] ff., I was looking around in pg_attribute
and noticed that we could possibly save 4 bytes. We could change both
attstattarget and attinhcount from int4 to int2, which together with
some reordering would save 4 bytes from the fixed portion.
attstattarget is already
On 20/03/2023 09:17, Peter Eisentraut wrote:
I have committed the two documentation changes, with some minor
adjustments.
Thank you,
On 07.03.23 18:14, Sébastien Lardière wrote:
Maybe this could be fixed instead?
Indeed, and strtoul is probably a better option than sscanf, don't
you th
Hi Shi Yu, all
Thanks for updating the patches. It seems you forgot to attach the patches
> of
> dropped columns for HEAD and pg15, I think they are the same as v2.
>
>
Yes, it seems I forgot. And, yes they were the same as v2.
> On HEAD, we can re-use clusters in other test cases, which can sav
On Friday, March 17, 2023 11:49 AM Peter Smith wrote:
>
> On Wed, Mar 15, 2023 at 7:30 PM houzj.f...@fujitsu.com
> wrote:
> >
> > Hi,
> >
> > I noticed that there are some duplicated codes in pgoutput_change()
> > function which can be simplified, and here is an attempt to do that.
>
> Hi Hou-s
On Thursday, March 16, 2023 12:30 PM Amit Kapila
wrote:
>
> On Wed, Mar 15, 2023 at 2:00 PM houzj.f...@fujitsu.com
> wrote:
> >
> > I noticed that there are some duplicated codes in pgoutput_change()
> function
> > which can be simplified, and here is an attempt to do that.
> >
>
> For REORDE
Hi,
On 3/20/23 8:32 AM, Michael Paquier wrote:
/* Total time previously charged to function, as of function start */
- instr_time save_f_total_time;
+ instr_time save_total_time;
I have something to say about this one, though.. I find this change a
bit confusing.
At Sat, 18 Mar 2023 10:26:42 +0530, Bharath Rupireddy
wrote in
> Hi,
>
> I'm attaching a patch to do $subject in autoprewarm.c and worker_spi
> extensions. The way it is right now doesn't hurt anyone, but why to
> fail after defining custom GUCs if we aren't loading them via
> shared_preload_li
On Mon, Mar 20, 2023 at 1:02 PM Peter Smith wrote:
>
>
> 2. pg_get_publication_tables
>
> + else
> + {
> + List*relids,
> +*schemarelids;
> +
> + relids = GetPublicationRelations(pub_elem->oid,
> + pub_elem->pubviaroot ?
> + PUBLICATION_PART_ROOT :
> + PUBLICATION_PART_LEAF);
> + schemarel
On 10.03.2023 15:06, Pavel Luzanov wrote:
I missed the comment at the beginning of the file about version 9.2. I
will return the version check for rolbypassrls.
+
+ Shown within each row, in newline-separated format, are the
memberships granted to
+ the role. The prese
On 3/19/23 20:31, Justin Pryzby wrote:
> On Fri, Mar 17, 2023 at 05:41:11PM +0100, Tomas Vondra wrote:
* Patch 2 is worth considering to backpatch
>>
>> I'm not quite sure what exactly are the numbered patches, as some of the
>> threads had a number of different patch ideas, and I'm not sure w
Le vendredi 17 mars 2023, 17:03:09 CET Paul Jungwirth a écrit :
> I added the code about RTEqualStrategyNumber because that's what we need
> to find an equals operator when the index is GiST (except if it's using
> an opclass from btree_gist; then it needs to be BTEqual again). But then
> I realize
On 3/20/23 04:42, Amit Kapila wrote:
> On Sat, Mar 18, 2023 at 8:49 PM Tomas Vondra
> wrote:
>>
>> On 3/18/23 06:35, Amit Kapila wrote:
>>> On Sat, Mar 18, 2023 at 3:13 AM Tomas Vondra
>>> wrote:
...
Clearly, for sequences we can't quite rely on snapshots/slots, we need
>>>
I have committed the two documentation changes, with some minor adjustments.
On 07.03.23 18:14, Sébastien Lardière wrote:
Maybe this could be fixed instead?
Indeed, and strtoul is probably a better option than sscanf, don't
you think ?
Yeah, the use of sscanf() is kind of weird here. We ha
I found an error message added by de4d456b406bf502341ef526710d3f764b41e2c8.
When I incorrectly configured the primary_conninfo with the wrong
user, I received the following message on the server logs of both
servers involved in a physical replcation set.
[27022:walsender] FATAL: permission denie
On Mon, Mar 20, 2023 at 3:49 PM Daniel Gustafsson wrote:
> > On 20 Mar 2023, at 08:46, Michael Paquier wrote:
> > How about removing the "fout/five" entirely here
> > and make that simpler? I would propose:
> > "For some classes of node types, you don't need all the support
> > functions."
>
>
> On 20 Mar 2023, at 08:46, Michael Paquier wrote:
> How about removing the "fout/five" entirely here
> and make that simpler? I would propose:
> "For some classes of node types, you don't need all the support
> functions."
Yes please, keeping such counts in sync is always error-prone.
--
Dani
On Mon, Mar 20, 2023 at 03:18:17PM +0800, Richard Guo wrote:
> A minor comment for the README is that now we have five support
> functions not four.
>
> - outcome. (For some classes of node types, you don't need all four support
> + outcome. (For some classes of node types, you don't need all fi
Here are some review comments for v17-0001.
==
src/backend/catalog/pg_publication.c
1. filter_partitions
-static List *
-filter_partitions(List *relids)
+static void
+filter_partitions(List *table_infos)
{
- List*result = NIL;
ListCell *lc;
- ListCell *lc2;
- foreach(lc, relids)
On Thu, Jan 12, 2023 at 10:07:33AM -0800, Andres Freund wrote:
> The problem with that is that the prefixes are used completely inconsistently
> - and have been for a long time. And not just between the different type of
> stats. Compare e.g. PgStat_TableCounts with PgStat_TableXactStatus and
> PgS
On Fri, Mar 17, 2023 11:29 PM Önder Kalacı wrote:
>
> Thanks for sharing. Fixed
>
>
> This time I was able to run all the tests with all the patches applied.
>
> Again, the generated column fix also has some minor differences
> per version. So, overall we have 6 patches with very minor
> diff
On Mon, Mar 20, 2023 at 2:43 PM Michael Paquier wrote:
> Nathan has reported to me offlist that maintainer-clean was not doing
> its job for the files generated by gen_node_support.pl in
> src/backend/nodes/ for the query jumbling. Attached is a patch to
> take care of this issue.
>
> While on i
ne 19. 3. 2023 v 15:01 odesílatel Justin Pryzby
napsal:
> On Thu, Mar 16, 2023 at 01:05:41PM +0100, Pavel Stehule wrote:
> > rebase + enhancing about related option from a563c24
>
> Thanks.
>
> It looks like this doesn't currently handle extensions, which were added
> at 6568cef26e.
>
> > +
101 - 128 of 128 matches
Mail list logo
