Re: WIP Incremental JSON Parser

2024-04-02 Thread Andrew Dunstan
On 2024-04-02 Tu 15:38, Jacob Champion wrote: On Mon, Apr 1, 2024 at 4:53 PM Andrew Dunstan wrote: Anyway, here are new patches. I've rolled the new semantic test into the first patch. Looks good! I've marked RfC. Thanks! I appreciate all the work you've done on this. I wi

meson vs windows perl

2024-04-02 Thread Andrew Dunstan
file assumed cl : Command line warning D9024 : unrecognized source file type 'Files\Microsoft', object file assumed cl : Command line warning D9024 : unrecognized source file type 'Visual', object file assumed cl : Command line warning D9024 : unrecognized source file type 'C:\Program', object file assumed cl : Command line warning D9024 : unrecognized source file type 'Files', object file assumed cl : Command line warning D9024 : unrecognized source file type '(x86)\Windows', object file assumed It looks like we need to get smarter about how we process the ldopts and strip out the ccdlflags and ldflags cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Extension for PostgreSQL cast jsonb to hstore WIP

2024-04-02 Thread Andrew Dunstan
's not always an object / hash. Thus it's easy to reliably cast hstore to json but far less easy to cast json to hstore in the general case. What do you propose to do in the case or json consisting of scalars, or arrays, or with nested elements? cheers andrew --

Re: Security lessons from liblzma

2024-04-01 Thread Andrew Dunstan
s andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Broken error detection in genbki.pl

2024-04-01 Thread Andrew Dunstan
fix this problem with zero change in the callers, and also buy back a little bit of the cost compared to this quick hack. Thoughts? regards, tom lane [1] https://www.postgresql.org/message-id/60EF4E11-BC1C-4034-B37B-695662D28AD2%40justatheory.com Makes sense cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-03-29 Thread Andrew Dunstan
irly comprehensive set of JSON errors. I'll play with that. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Possibility to disable `ALTER SYSTEM`

2024-03-26 Thread Andrew Dunstan
> On Mar 27, 2024, at 3:53 AM, Tom Lane wrote: > > Bruce Momjian writes: >> I am thinking "enable_alter_system_command" is probably good because we >> already use "enable" so why not reuse that idea, and I think "command" >> is needed because we need to clarify we are talking about the comma

Re: WIP Incremental JSON Parser

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 7:12 PM Jacob Champion < jacob.champ...@enterprisedb.com> wrote: > On Mon, Mar 25, 2024 at 4:02 PM Andrew Dunstan > wrote: > > Well, what's the alternative? The current parser doesn't check stack > depth in frontend code. Presumably it too

Re: session username in default psql prompt?

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 9:14 AM Jelte Fennema-Nio wrote: > On Mon, 25 Mar 2024 at 14:06, Robert Haas wrote: > > On Mon, Mar 25, 2024 at 4:30 AM Jelte Fennema-Nio > wrote: > > > That problem seems easy to address by adding a newline into the > > > default prompt. > > > > Ugh. Please, no! > > I g

Re: WIP Incremental JSON Parser

2024-03-25 Thread Andrew Dunstan
On Mon, Mar 25, 2024 at 6:15 PM Jacob Champion < jacob.champ...@enterprisedb.com> wrote: > On Wed, Mar 20, 2024 at 11:56 PM Andrew Dunstan > wrote: > > Thanks, included that and attended to the other issues we discussed. I > think this is pretty close now. > > Ok

Re: pg_dump versus enum types, round N+1

2024-03-23 Thread Andrew Dunstan
On Sat, Mar 23, 2024 at 3:00 PM Tom Lane wrote: > I have a patch in the queue [1] that among other things tries to > reduce the number of XIDs consumed during pg_upgrade by making > pg_restore group its commands into batches of a thousand or so > per transaction. This had been passing tests, so

Re: session username in default psql prompt?

2024-03-22 Thread Andrew Dunstan
On Fri, Mar 22, 2024 at 7:34 PM Tom Lane wrote: > > On the whole, I think we'd get more complaints about the default > prompt having more-or-less doubled in length than we'd get kudos > about this being a great usability improvement. Prompt space is > expensive and precious, at least for people

Re: session username in default psql prompt?

2024-03-22 Thread Andrew Dunstan
On Fri, Mar 22, 2024 at 4:04 PM Robert Haas wrote: > On Wed, Mar 13, 2024 at 4:56 AM Andrew Dunstan > wrote: > > Reposting as the archive mail processor doesn't seem to like the Apple > > mail attachment. > > I'm not really a fan of this. Right now my promp

Re: automating RangeTblEntry node support

2024-03-21 Thread Andrew Dunstan
On Mon, Mar 11, 2024 at 5:29 AM Peter Eisentraut wrote: > On 20.02.24 08:57, Peter Eisentraut wrote: > > On 18.02.24 00:06, Matthias van de Meent wrote: > >> I'm not sure that the cleanup which is done when changing a RTE's > >> rtekind is also complete enough for this purpose. > >> Things like i

Re: Trying to build x86 version on windows using meson

2024-03-20 Thread Andrew Dunstan
On Wed, Mar 20, 2024 at 6:21 PM Andres Freund wrote: > Hi, > > On 2024-03-21 11:02:27 +1300, David Rowley wrote: > > On Thu, 21 Mar 2024 at 11:00, Andres Freund wrote: > > > > > > On 2024-03-20 17:49:14 -0400, Dave Cramer wrote: > > > > First off this is on an ARM64 machine > > > > > > Uh, that'

Re: WIP Incremental JSON Parser

2024-03-20 Thread Andrew Dunstan
On Tue, Mar 19, 2024 at 6:07 PM Andrew Dunstan wrote: > > > > > It also removes the frontend exits I had. In the case of stack depth, we > follow the example of the RD parser and only check stack depth for backend > code. In the case of the check that the lexer is s

Re: Possibility to disable `ALTER SYSTEM`

2024-03-19 Thread Andrew Dunstan
On Tue, Mar 19, 2024 at 2:28 PM Magnus Hagander wrote: > On Tue, Mar 19, 2024 at 3:52 PM Tom Lane wrote: > > > > Heikki Linnakangas writes: > > > Perhaps we could make that even better with a GUC though. I propose a > > > GUC called 'configuration_managed_externally = true / false". If you > se

Re: documentation structure

2024-03-19 Thread Andrew Dunstan
On Mon, Mar 18, 2024 at 10:12 AM Robert Haas wrote: > I was looking at the documentation index this morning[1], and I can't > help feeling like there are some parts of it that are over-emphasized > and some parts that are under-emphasized. I'm not sure what we can do > about this exactly, but I t

Re: Possibility to disable `ALTER SYSTEM`

2024-03-19 Thread Andrew Dunstan
On Tue, Mar 19, 2024 at 5:26 AM Heikki Linnakangas wrote: > I want to remind everyone of this from Gabriele's first message that > started this thread: > > > At the moment, a possible workaround is that `ALTER SYSTEM` can be > blocked > > by making the postgresql.auto.conf read only, but the retu

Re: What about Perl autodie?

2024-03-17 Thread Andrew Dunstan
On Mon, Mar 18, 2024 at 2:28 AM Peter Eisentraut wrote: > On 21.02.24 08:26, Peter Eisentraut wrote: > > On 14.02.24 17:52, Peter Eisentraut wrote: > >> A gentler way might be to start using some perlcritic policies like > >> InputOutput::RequireCheckedOpen or the more general > >> InputOutput::R

Re: Support json_errdetail in FRONTEND builds

2024-03-15 Thread Andrew Dunstan
> On Mar 16, 2024, at 8:53 AM, Daniel Gustafsson wrote: > >  >> >> On 15 Mar 2024, at 21:56, Andrew Dunstan wrote: >> On Fri, Mar 15, 2024 at 10:15 AM Tom Lane > <mailto:t...@sss.pgh.pa.us>> wrote: >> Daniel Gustafsson mailto:dan...@yesql.se&g

Re: Support json_errdetail in FRONTEND builds

2024-03-15 Thread Andrew Dunstan
On Fri, Mar 15, 2024 at 10:15 AM Tom Lane wrote: > Daniel Gustafsson writes: > > I can't see how refusing to free memory owned and controlled by someone > else, > > and throwing an error if attempted, wouldn't be a sound defensive > programming > > measure. > > I think the argument is about what

Re: session username in default psql prompt?

2024-03-13 Thread Andrew Dunstan
On 2024-02-27 Tu 19:19, Kori Lane wrote: Here’s a patch for this. Reposting as the archive mail processor doesn't seem to like the Apple mail attachment. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgm

Re: meson vs tarballs

2024-03-12 Thread Andrew Dunstan
On 2024-03-13 We 02:31, Andrew Dunstan wrote: On 2024-03-13 We 02:22, Peter Eisentraut wrote: On 13.03.24 07:11, Andrew Dunstan wrote: I and several colleagues have just been trying to build from a tarball with meson. That seems pretty awful and unfriendly and I didn't see anything

Re: meson vs tarballs

2024-03-12 Thread Andrew Dunstan
On 2024-03-13 We 02:22, Peter Eisentraut wrote: On 13.03.24 07:11, Andrew Dunstan wrote: I and several colleagues have just been trying to build from a tarball with meson. That seems pretty awful and unfriendly and I didn't see anything about it in the docs. At https://www.postgresq

meson vs tarballs

2024-03-12 Thread Andrew Dunstan
n the docs. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: perl: unsafe empty pattern behavior

2024-03-12 Thread Andrew Dunstan
obody else does it I'll have a go, but it might take a while. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Support json_errdetail in FRONTEND builds

2024-03-12 Thread Andrew Dunstan
aths, where in many cases the program will just exit anyway. 2. the fix is simple where it's needed. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PROPOSAL] Skip test citext_utf8 on Windows

2024-03-12 Thread Andrew Dunstan
On 2024-03-11 Mo 22:50, Thomas Munro wrote: On Tue, Mar 12, 2024 at 2:56 PM Andrew Dunstan wrote: On 2024-03-11 Mo 04:21, Oleg Tselebrovskiy wrote: Greetings, everyone! While running "installchecks" on databases with UTF-8 encoding the test citext_utf8 fails because of Turkis

Re: [PROPOSAL] Skip test citext_utf8 on Windows

2024-03-11 Thread Andrew Dunstan
27;); the output will be this:  lower ---  İ (1 row) Which I find strange since lower() uses collation that was passed (default in this case but still) Wouldn't we be better off finding a Windows fix for this, instead of sweeping it under the rug? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-03-07 Thread Andrew Dunstan
is particularly helpful when a test fails spuriously due to code coverage spray on stderr. Makes sense, thanks. I'll have a fresh patch set soon which will also take care of the bitrot. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: speed up a logical replica setup

2024-02-28 Thread Andrew Dunstan
%3Dfilename [2]: ``` The target server must be shut down cleanly before running pg_rewind ``` Even though that is a difference I'd still rather we did more or less the same thing more or less the same way across utilities, so I agree with Euler's suggestion. cheers andrew -- Andrew D

Re: [PoC] Federated Authn/z with OAUTHBEARER

2024-02-28 Thread Andrew Dunstan
give some more details about what this python gadget would buy us? I note that there are a couple of CPAN modules that provide OAuth2 servers, not sure if they would be of any use. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Logging parallel worker draught

2024-02-27 Thread Andrew Dunstan
" work "1066 And All That": "For 'pheasant' read 'peasant' throughout." cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: More new SQL/JSON item methods

2024-02-26 Thread Andrew Dunstan
te error messages for > string input as well, which currently has the following form: > > "string argument of jsonpath item method .%s() is not a valid > representation.." Agreed. Attached are patches based on the discussion. Thanks, I combined these and pushed the result. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-02-26 Thread Andrew Dunstan
On 2024-02-26 Mo 19:20, Andrew Dunstan wrote: On 2024-02-26 Mo 10:10, Jacob Champion wrote: On Mon, Feb 26, 2024 at 7:08 AM Jacob Champion wrote: As a brute force example of the latter, with the attached diff I get test failures at chunk sizes 1, 2, 3, 4, 6, and 12. But this time with the

Re: WIP Incremental JSON Parser

2024-02-26 Thread Andrew Dunstan
hanks! cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Can we include capturing logs of pgdata/pg_upgrade_output.d/*/log in buildfarm

2024-02-25 Thread Andrew Dunstan
TAP test and this module does nothing. More generally, the collection of logs etc. for pg_upgrade will improve with the next release, which will be soon after I return from a vacation in about 2 weeks - experience shows that making releases just before a vacation is not a good idea :-) ch

Re: WIP Incremental JSON Parser

2024-02-22 Thread Andrew Dunstan
On 2024-02-22 Th 15:29, Jacob Champion wrote: On Thu, Feb 22, 2024 at 1:38 AM Andrew Dunstan wrote: Patch 5 in this series fixes those issues and adjusts most of the tests to add some trailing junk to the pieces of json, so we can be sure that this is done right. This fixes the test failure

Re: WIP Incremental JSON Parser

2024-02-20 Thread Andrew Dunstan
On 2024-02-20 Tu 19:53, Jacob Champion wrote: On Tue, Feb 20, 2024 at 2:10 PM Andrew Dunstan wrote: Well, that didn't help a lot, but meanwhile the CFBot seems to have decided in the last few days that it's now happy, so full steam aead! ;-) I haven't been able to track down

Re: WIP Incremental JSON Parser

2024-02-19 Thread Andrew Dunstan
On 2024-01-26 Fr 12:15, Andrew Dunstan wrote: On 2024-01-24 We 13:08, Robert Haas wrote: Maybe you should adjust your patch to dump the manifests into the log file with note(). Then when cfbot runs on it you can see exactly what the raw file looks like. Although I wonder if it's pos

Re: What about Perl autodie?

2024-02-18 Thread Andrew Dunstan
d add explicit error checking at the sites it points out.  And then if we start using autodie in the future, any inappropriate backpatching of calls lacking error checks would be caught. Yeah, that should work. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andrew Dunstan
On 2024-02-12 Mo 11:44, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Mon, 12 Feb 2024 at 09:19, Andrew Dunstan wrote: On 2024-02-12 Mo 08:51, Dave Cramer wrote: On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: On 2024-02-10 Sa 12:20, Dave Cramer wrote

Re: [PATCH] Add native windows on arm64 support

2024-02-12 Thread Andrew Dunstan
On 2024-02-12 Mo 08:51, Dave Cramer wrote: On Sat, 10 Feb 2024 at 13:28, Andrew Dunstan wrote: On 2024-02-10 Sa 12:20, Dave Cramer wrote: On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer

Re: Feature request support MS Entra ID Authentication from On-premises PostreSQL server

2024-02-11 Thread Andrew Dunstan
. What is the difference between this and ActiveDirectory? AD is already usable as an authentication mechanism. See for example <https://www.crunchydata.com/blog/windows-active-directory-postgresql-gssapi-kerberos-authentication> cheers andrew -- Andrew Dunstan EDB

Re: [PATCH] Add native windows on arm64 support

2024-02-10 Thread Andrew Dunstan
On 2024-02-10 Sa 12:20, Dave Cramer wrote: On Sat, 10 Feb 2024 at 11:19, Andrew Dunstan wrote: On 2024-02-09 Fr 14:23, Dave Cramer wrote: Dave Cramer www.postgres.rocks <http://www.postgres.rocks> On Fri, 9 Feb 2024 at 07:18, Dave Cramer <mailto:d

Re: recently added jsonpath method change jsonb_path_query, jsonb_path_query_first immutability

2024-02-10 Thread Andrew Dunstan
inion, though. That seems fine as well. Let's leave that to the committer. I edited slightly to my taste, and committed the patch. Thanks. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-02-10 Thread Andrew Dunstan
stmaster[10672] LOG:  all server processes terminated; reinitializing 2024-02-09 13:31:11.034 -05 startup[6152] LOG:  database system was interrupted; last known up at 2024-02-09 13:31:01 -05 Yes, this is pretty much what I saw. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Possibility to disable `ALTER SYSTEM`

2024-02-10 Thread Andrew Dunstan
not handling read-only files in PGDATA. This seems like the simplest solution. And maybe we should be fixing pg_rewind regardless of this issue? cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: What about Perl autodie?

2024-02-10 Thread Andrew Dunstan
elopers then it is like you say, far from guaranteed to work. +1 from me too. We kept 5.8 going for a while because it was what the Msys (v1) DTK perl was, but that doesn't matter any more I think. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: recently added jsonpath method change jsonb_path_query, jsonb_path_query_first immutability

2024-02-06 Thread Andrew Dunstan
x27;::text, 'date'::text from cte union all select jsonb_path_query(s, '$.time_tz()')::text,'-8'::text, 'time_tz'::text from cte; commit; [0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=66ea94e8e606529bb334515f388c62314956739e ouch. Good catch. Clearly we need to filter these like we do for the .datetime() method. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

2024-02-01 Thread Andrew Dunstan
::Utils::windows_os" used only once: possible typo at t/003_extrafiles.pl line 85. in v14. v15 and up are OK. *sigh* Have pushed a fix. Thanks for noticing. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-01-31 Thread Andrew Dunstan
On 2024-01-31 We 10:34, Peter Eisentraut wrote: On 31.01.24 16:20, Andrew Dunstan wrote: - PostgreSQL will only build for the x64 architecture on 64-bit Windows. + PostgreSQL will only build for the x64 and ARM64 architecture on 64-bit Windows. Are there any other 64-bit architectures for

Re: [PATCH] Add native windows on arm64 support

2024-01-31 Thread Andrew Dunstan
On 2024-01-30 Tu 17:54, Dave Cramer wrote: On Tue, Jan 30, 2024 at 4:56 PM Andrew Dunstan wrote: On 2024-01-30 Tu 09:50, Dave Cramer wrote: On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: On 2024-01-29 Mo 11:20, Dave Cramer wrote: Dave Cramer

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

2024-01-30 Thread Andrew Dunstan
On 2024-01-30 Tu 18:06, Tom Lane wrote: Andrew Dunstan writes: Pushed to all live branches. Thanks for the patch. v12 and v13 branches aren't looking good: Global symbol "$test_primary_datadir" requires explicit package name (did you forget to declare "my $test_pri

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

2024-01-30 Thread Andrew Dunstan
On 2024-01-30 Tu 06:49, Andrew Dunstan wrote: On 2024-01-30 Tu 06:21, Nazir Bilal Yavuz wrote: Hi, I was trying to install newer Perl versions to Windows CI images and found that 003_extrafiles.pl test fails on Windows with: (0.183s) not ok 2 - file lists match (0.000s) #   Failed test

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Andrew Dunstan
On 2024-01-30 Tu 09:50, Dave Cramer wrote: On Tue, 30 Jan 2024 at 08:38, Andrew Dunstan wrote: On 2024-01-29 Mo 11:20, Dave Cramer wrote: Dave Cramer www.postgres.rocks <http://www.postgres.rocks> On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote:

Re: [PATCH] Add native windows on arm64 support

2024-01-30 Thread Andrew Dunstan
On 2024-01-29 Mo 11:20, Dave Cramer wrote: Dave Cramer www.postgres.rocks On Mon, 29 Jan 2024 at 11:16, Andrew Dunstan wrote: On 2024-01-26 Fr 09:18, Dave Cramer wrote: On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: On 2024-01-25 Th 20:32, Michael Paquier

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

2024-01-30 Thread Andrew Dunstan
ted. Looks reasonable on the face of it. I'll see about pushing this today. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Should we remove -Wdeclaration-after-statement?

2024-01-29 Thread Andrew Dunstan
hat at least I think there's close to unanimous agreement. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-01-29 Thread Andrew Dunstan
On 2024-01-26 Fr 09:18, Dave Cramer wrote: On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: On 2024-01-25 Th 20:32, Michael Paquier wrote: > On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: >> On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote:

Re: [PATCH] Add native windows on arm64 support

2024-01-29 Thread Andrew Dunstan
On 2024-01-26 Fr 09:18, Dave Cramer wrote: On Fri, 26 Jan 2024 at 07:36, Andrew Dunstan wrote: On 2024-01-25 Th 20:32, Michael Paquier wrote: > On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: >> On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote:

Re: psql: add \create_function command

2024-01-29 Thread Andrew Dunstan
is far too narrow and would not cater for many use cases I have had in the past. I like your ideas upthread about \file_read and :{filename} cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: PG versus libxml2 2.12.x

2024-01-29 Thread Andrew Dunstan
27;s still there, given that we disabled external DTD access ages ago. I propose we just remove it. In short, I suggest the attached. Looks reasonable. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-01-26 Thread Andrew Dunstan
On 2024-01-25 Th 20:32, Michael Paquier wrote: On Thu, Jan 25, 2024 at 04:52:30PM -0500, Dave Cramer wrote: On Thu, 25 Jan 2024 at 16:32, Andrew Dunstan wrote: On 2024-01-25 Th 16:17, Dave Cramer wrote: Yeah, I think the default Developer Command Prompt for VS2022 is set up for x86 builds

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
rer and right click, in the compatibility tab if the "Windows on ARM" is greyed out it is an arm binary. So far mine are not :( Yeah, I think the default Developer Command Prompt for VS2022 is set up for x86 builds. AIUI you should start by executing "vcvarsall x64_arm64"

Re: More new SQL/JSON item methods

2024-01-25 Thread Andrew Dunstan
e also late-model clang. Anyway, I did note that the preceding line res = jperOk; is dead code and might as well get removed while you're at it. OK, pushed those. Thanks. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 15:56, Dave Cramer wrote: On Thu, 25 Jan 2024 at 14:31, Andrew Dunstan wrote: On 2024-01-25 Th 08:45, Dave Cramer wrote: I tried running my buildfarm using my git repo and my branch, but get the following error Status Line: 492 bad branch parameter

Re: More new SQL/JSON item methods

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 15:33, Tom Lane wrote: Andrew Dunstan writes: On 2024-01-25 Th 14:31, Tom Lane wrote: (The reported crashes seem to be happening later during a recursive invocation, seemingly because JsonbType(jb) is returning garbage. So there may be another bug after this one.) I don&#

Re: More new SQL/JSON item methods

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 14:31, Tom Lane wrote: Andrew Dunstan writes: Thanks, I have pushed this. The buildfarm is pretty widely unhappy, mostly failing on select jsonb_path_query('1.23', '$.string()'); On a guess, I tried running that under valgrind, and behold it said ==00

Re: More new SQL/JSON item methods

2024-01-25 Thread Andrew Dunstan
On 2024-01-25 Th 14:31, Tom Lane wrote: Andrew Dunstan writes: Thanks, I have pushed this. The buildfarm is pretty widely unhappy, mostly failing on select jsonb_path_query('1.23', '$.string()'); On a guess, I tried running that under valgrind, and behold it said ==00

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
h the buildfarm, you need to let it set up its own branches. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: [PATCH] Add native windows on arm64 support

2024-01-25 Thread Andrew Dunstan
erver. AFAICT they still only sell versions for x86_64 cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: More new SQL/JSON item methods

2024-01-25 Thread Andrew Dunstan
nfirmation. Attached merged single patch along these lines. Thanks, I have pushed this. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: WIP Incremental JSON Parser

2024-01-24 Thread Andrew Dunstan
On 2024-01-22 Mo 21:02, Andrew Dunstan wrote: On 2024-01-22 Mo 18:01, Andrew Dunstan wrote: On 2024-01-22 Mo 14:16, Andrew Dunstan wrote: On 2024-01-22 Mo 01:29, Peter Smith wrote: 2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems there

Re: Make COPY format extendable: Extract COPY TO format implementations

2024-01-24 Thread Andrew Dunstan
? The loss with csv could be blamed on the extra manipulations of the function pointers, likely. I don't think that's at all acceptable. We've spent quite a lot of blood sweat and tears over the years to make COPY fast, and we should not sacrifice any of that lightly. cheers

Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI)

2024-01-22 Thread Andrew Dunstan
e's a consensus that we want this. It should probably be returned with feedback. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Simplify documentation related to Windows builds

2024-01-19 Thread Andrew Dunstan
uldn't be recommending any particular perl distro, especially not ASPerl which now has annoying license issues. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: More new SQL/JSON item methods

2024-01-17 Thread Andrew Dunstan
, but they do care about docs have sensible structure. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs

2024-01-17 Thread Andrew Dunstan
-liner change needed to teach buildfarm animals to ignore READMEs. - trigger_exclude => qr[^doc/|\.po$], + trigger_exclude => qr[^doc/|/README$|\.po$], I've put that in the sample config file for the next release. cheers andre

Re: psql JSON output format

2024-01-17 Thread Andrew Dunstan
On 2024-01-17 We 03:52, Laurenz Albe wrote: On Tue, 2024-01-16 at 11:49 -0500, Andrew Dunstan wrote: On 2024-01-16 Tu 11:07, Laurenz Albe wrote: On Tue, 2024-01-09 at 16:51 +, Dean Rasheed wrote: On Tue, 9 Jan 2024 at 14:35, Christoph Berg wrote: Getting it print numeric/boolean

Re: psql JSON output format

2024-01-16 Thread Andrew Dunstan
ed empty string, while an empty string data value is written with double quotes (""). CSV format with default settings is and has been from the beginning designed to be round trippable. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com

Re: plperl and perl 5.38

2024-01-14 Thread Andrew Dunstan
: 10, _b: 20 DROP PROCEDURE test_proc1; Same problem in 17devel and 16. (Did not try the older branches yet.) I can't reproduce this on my Ubuntu 22.04 ARM64 instance with perl 5.38.2 installed via perlbrew, nor on a fresh Debian unstable with it's perl 5.38.2. In both insta

Re: WIP Incremental JSON Parser

2024-01-10 Thread Andrew Dunstan
On 2024-01-09 Tu 13:46, Jacob Champion wrote: On Tue, Dec 26, 2023 at 8:49 AM Andrew Dunstan wrote: Quite a long time ago Robert asked me about the possibility of an incremental JSON parser. I wrote one, and I've tweaked it a bit, but the performance is significantly worse that that o

Re: WIP Incremental JSON Parser

2024-01-03 Thread Andrew Dunstan
On 2024-01-03 We 10:12, Robert Haas wrote: On Wed, Jan 3, 2024 at 9:59 AM Andrew Dunstan wrote: Say we have a document with an array 1m objects, each with a field called "color". As it stands we'll allocate space for that field name 1m times. Using a hash table we'd al

Re: WIP Incremental JSON Parser

2024-01-03 Thread Andrew Dunstan
On 2024-01-03 We 08:45, Robert Haas wrote: On Wed, Jan 3, 2024 at 6:57 AM Andrew Dunstan wrote: Yeah. One idea I had yesterday was to stash the field names, which in large JSON docs tent to be pretty repetitive, in a hash table instead of pstrduping each instance. The name would be valid

Re: WIP Incremental JSON Parser

2024-01-03 Thread Andrew Dunstan
On 2024-01-02 Tu 10:14, Robert Haas wrote: On Tue, Dec 26, 2023 at 11:49 AM Andrew Dunstan wrote: Quite a long time ago Robert asked me about the possibility of an incremental JSON parser. I wrote one, and I've tweaked it a bit, but the performance is significantly worse that that o

Re: authentication/t/001_password.pl trashes ~/.psql_history

2023-12-23 Thread Andrew Dunstan
    my $history_file = $params{history_file}; +    $history_file ||= '/dev/null'; +    $ENV{PSQL_HISTORY} = $history_file; to just $ENV{PSQL_HISTORY} = $params{history_file} || '/dev/null'; cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Remove MSVC scripts from the tree

2023-12-22 Thread Andrew Dunstan
On 2023-12-21 Th 18:20, Michael Paquier wrote: On Thu, Dec 21, 2023 at 03:43:32PM -0500, Andrew Dunstan wrote: On 2023-12-21 Th 03:01, Michael Paquier wrote: Andrew, was the original target of pgperlsyncheck committers and hackers who played with the MSVC scripts but could not run sanity

Re: Remove MSVC scripts from the tree

2023-12-21 Thread Andrew Dunstan
n32. I wonder who has actually run the script any time recently? In any case, we can probably work around the syncheck issue by making the module a runtime requirement rather than a compile time requirement, by using "require" instead of "use". cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Add --check option to pgindent

2023-12-20 Thread Andrew Dunstan
On 2023-12-20 We 11:05, Andrew Dunstan wrote: On 2023-12-19 Tu 08:57, Daniel Gustafsson wrote:   The posted v5 seems like a good compromise I reckon. Andrew: When applying this, how do we synchronize with the buildfarm to avoid false negatives due to the BF using the wrong options? The

Re: Remove MSVC scripts from the tree

2023-12-20 Thread Andrew Dunstan
On 2023-12-20 We 11:32, Robert Haas wrote: On Wed, Dec 20, 2023 at 11:03 AM Andrew Dunstan wrote: This could perhaps be related to this patch removing the module in src/tools/msvc/dummylib/Win32/Registry.pm ? It is. I've fixed the buildfarm to stop checking this script. Thanks!

Re: Add --check option to pgindent

2023-12-20 Thread Andrew Dunstan
On 2023-12-19 Tu 08:57, Daniel Gustafsson wrote: On 19 Dec 2023, at 14:51, Andrew Dunstan wrote: On 2023-12-18 Mo 11:14, Jelte Fennema-Nio wrote: On Mon, 18 Dec 2023 at 13:42, Daniel Gustafsson wrote: I think this is pretty much ready to go, the attached v4 squashes the changes and fixes

Re: Remove MSVC scripts from the tree

2023-12-20 Thread Andrew Dunstan
the module in src/tools/msvc/dummylib/Win32/Registry.pm ? It is. I've fixed the buildfarm to stop checking this script. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Add --check option to pgindent

2023-12-19 Thread Andrew Dunstan
t to run it. In any case, as you say it's a different topic. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Andrew Dunstan
On 2023-12-15 Fr 11:06, Tom Lane wrote: Andrew Dunstan writes: Here's more or less what I had in mind. Do we really need the dependency on an install tree? Can't we just find the executables (or .o files for Darwin) in the build tree? Seems like that would simplify usage, and

Re: Clean up find_typedefs and add support for Mac

2023-12-15 Thread Andrew Dunstan
On 2023-12-14 Th 10:36, Tristan Partin wrote: On Thu Dec 14, 2023 at 9:16 AM CST, Andrew Dunstan wrote: On 2023-12-13 We 15:59, Tristan Partin wrote: > On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote: >> >> On 2023-12-12 Tu 18:02, Tom Lane wrote: >> >

Re: Clean up find_typedefs and add support for Mac

2023-12-14 Thread Andrew Dunstan
On 2023-12-13 We 15:59, Tristan Partin wrote: On Wed Dec 13, 2023 at 2:35 PM CST, Andrew Dunstan wrote: On 2023-12-12 Tu 18:02, Tom Lane wrote: > "Tristan Partin" writes: >> The big patch here is adding support for Mac. objdump -W doesn't work on >> Mac. So,

Re: Remove MSVC scripts from the tree

2023-12-13 Thread Andrew Dunstan
? TBH I'd prefer to wait. But I have had a couple more urgent things on my plate. I hope to get back to it before New Year. In the meantime I have switched bowerbird to building only STABLE branches. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

Re: Add --check option to pgindent

2023-12-13 Thread Andrew Dunstan
ng. But note: --show-diff doesn't apply the diff, it's intentionally non-destructive. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com

<    1   2   3   4   5   6   7   8   9   10   >