Re: Commitfest manager for 2022-03

Hi Greg, On 2/25/22 12:39, Greg Stark wrote: I would like to volunteer. On Fri, 25 Feb 2022 at 05:31, Julien Rouhaud wrote: Is there any volunteer? Since I've done the March CF for the last seven years, I thought it would be good if I chimed in. I've been agonizing a bit because I have t

Re: Allow root ownership of client certificate key

On 2/28/22 13:20, Tom Lane wrote: David Steele writes: [ client-key-perm-003.patch ] Pushed with a bit of copy-editing of the comments. Thank you! Any thoughts on back-patching at least the client portion of this? Probably hard to argue that it's a bug, but it is certainly pa

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 2/28/22 23:51, Nathan Bossart wrote: On Sat, Feb 26, 2022 at 02:06:14PM -0800, Nathan Bossart wrote: On Sat, Feb 26, 2022 at 04:48:52PM +, Chapman Flack wrote: Assuming the value is false, so no error is thrown, is it practical to determine from flinfo->fn_expr whether the value was defa

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 3/1/22 11:32, Nathan Bossart wrote: On Tue, Mar 01, 2022 at 11:09:13AM -0500, Chapman Flack wrote: On 03/01/22 09:44, David Steele wrote: Personally, I am in favor of removing it. We change/rename functions/tables/views when we need to, and this happens in almost every release. For

Re: Allow root ownership of client certificate key

On 3/2/22 08:40, Tom Lane wrote: Chris Bandy writes: On 3/1/22 3:15 AM, Tom Lane wrote: Anyway, I'd be happier about back-patching if we could document actual requests to make it work like the server side does. PGO runs PostgreSQL 10 through 14 in Kubernetes, and we have to work around this

Re: pg_stop_backup() v2 incorrectly marked as proretset

On 3/2/22 11:04, Chapman Flack wrote: On 03/02/22 02:46, Michael Paquier wrote: system function marked as proretset while it builds and returns only one record. And this is a popular one: pg_stop_backup(), labelled v2. I had just recently noticed that while reviewing [0], but shrugged, as I d

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 3/8/22 14:01, Nathan Bossart wrote: On Wed, Mar 02, 2022 at 02:23:51PM -0500, Chapman Flack wrote: I did not notice this earlier (sorry), but there seems to remain in backup.sgml a programlisting example that shows a psql invocation for pg_backup_start, then a tar command, then another psql i

Re: Document what is essential and undocumented in pg_basebackup

On 3/9/22 13:46, Stephen Frost wrote: I don't think it is as reasonable to say, effectively, that you learn what the irreducibly essential steps of an online base backup are by reading the source of pg_basebackup, and then intuiting which of the details you find there are the essential ones and

Re: Commitfest 2022-03 One Week in. 3 Commits 213 Patches Remaining

On 3/9/22 13:38, Greg Stark wrote: Is there anything I can do to get committers assigned to these patches? Should I do a round-robin style assignment for any of these? I don't think this is a good idea. Committers pick the patches they are going to commit. What prefer to do is bump any comm

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 3/9/22 18:06, Nathan Bossart wrote: On Wed, Mar 09, 2022 at 06:11:19PM -0500, Chapman Flack wrote: I think the listitem In the same connection as before, issue the command: SELECT * FROM pg_backup_stop(true); would be clearer if it used named-parameter form, wait_for_archive => true.

Re: Online verification of checksums

On 11/30/20 9:27 AM, Stephen Frost wrote: Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: On Fri, Nov 27, 2020 at 11:15:27AM -0500, Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Thu, Nov 26, 2020 at 8:42 AM Michael Paquier wrote: But here the checksum is b

Re: Commitfest 2020-11 is closed

On 12/2/20 4:15 PM, Thomas Munro wrote: On Thu, Dec 3, 2020 at 10:00 AM Tom Lane wrote: This is actually a bit problematic, because now the cfbot is ignoring those patches (or if it's not, I don't know where it's displaying the results). Please go ahead and move the remaining open patches, or

Re: Commitfest 2020-11 is closed

On 12/2/20 5:13 PM, Thomas Munro wrote: On Thu, Dec 3, 2020 at 10:51 AM David Steele wrote: On 12/2/20 4:15 PM, Thomas Munro wrote: On Thu, Dec 3, 2020 at 10:00 AM Tom Lane wrote: This is actually a bit problematic, because now the cfbot is ignoring those patches (or if it's not, I

Re: data_checksums enabled by default (was: Move --data-checksums to common options in initdb --help)

On 1/8/21 5:03 AM, Andres Freund wrote: On Fri, Jan 8, 2021, at 01:53, Laurenz Albe wrote: The serious crowd are more likely to choose a non-default setting to avoid paying the price for a feature that they don't need. I don't really buy this argument. That way we're going to have an ever gro

2019-03 CF now in progress

Hackers, The 2019-03 commitfest is now in progress. It's a big one as usual. Needs review: 213. Waiting on Author: 21. Ready for Committer: 28. Committed: 29. Withdrawn: 3. Total: 294. If you are a patch author please check http://commitfest.cputube.org to be sure your patch still applies, com

Re: 2019-03 CF now in progress

Hi Justin, On 3/1/21 6:19 PM, Justin Pryzby wrote: Could I suggest to update the CF APP to allow: | Target version: 15 I don't have permission to add target versions (or at least I can't find it in the admin interface) so hopefully Michael or Magnus can do it. Regards, -- -David da...@pgmas

Re: archive_command / pg_stat_archiver & documentation

On 3/1/21 8:29 PM, Michael Paquier wrote: On Mon, Mar 01, 2021 at 05:17:06PM +0800, Julien Rouhaud wrote: Maybe this can be better addressed than with a link in the documentation. The final outcome is that it can be difficult to monitor the archiver state in such case. That's orthogonal to thi

Re: [PATCH] Identify LWLocks in tracepoints

On 1/22/21 6:02 AM, Peter Eisentraut wrote: On 2021-01-14 09:39, Craig Ringer wrote: On Thu, 14 Jan 2021 at 15:56, Peter Eisentraut > wrote:     On 2020-12-19 06:00, Craig Ringer wrote: > Patch 1 fixes a bogus tracepoint where an lwlock__acquire e

Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW

Hi Japin, On 1/8/21 9:02 PM, japin wrote: On Sat, 09 Jan 2021 at 09:38, Bharath Rupireddy wrote: On Fri, Jan 8, 2021 at 9:50 PM japin wrote: I ran pgindent on 0001 patch to fix the above. 0002 patch has no changes. If I'm correct, pgindent will be run periodically on master. Thanks for yo

Re: Huge memory consumption on partitioned table with FKs

On 12/7/20 10:59 PM, Amit Langote wrote: On Tue, Dec 8, 2020 at 12:04 PM Kyotaro Horiguchi wrote: At Tue, 8 Dec 2020 01:16:00 +0900, Amit Langote wrote in On Mon, Dec 7, 2020 at 23:48 Alvaro Herrera wrote: I think this bit about splitting the struct is a distraction. Let's get a patch th

Re: 回复：Re: Cache relation sizes?

Hi Thomas, On 1/18/21 10:42 PM, 陈佳昕(步真) wrote: I want to share a patch with you, I change the replacement algorithm from fifo to a simple lru. What do you think of this change? Also, your patch set from [1] no longer applies (and of course this latest patch is confusing the tester as well).

Re: "has_column_privilege()" issue with attnums and non-existent columns

On 1/29/21 4:56 AM, Joe Conway wrote: On 1/29/21 12:13 AM, Ian Lawrence Barwick wrote: 2021年1月28日(木) 17:18 Peter Eisentraut: I'm not convinced the current behavior is wrong.  Is there some practical use case that is affected by this behavior? I was poking around at the function with

Re: jsonpath syntax extensions

On 3/4/20 3:18 PM, Nikita Glukhov wrote: On 04.03.2020 19:13, David Steele wrote: On 2/27/20 10:57 AM, Nikita Glukhov wrote: Attached patches implement several useful jsonpath syntax extensions. I already published them two years ago in the original SQL/JSON thread, but then after creation of

Re: Let people set host(no)ssl settings from initdb

On 3/3/21 9:07 AM, Peter Eisentraut wrote: On 01.01.21 14:12, Magnus Hagander wrote: That said, I agree with not adding it as an option to initdb. You'll quickly get to the point where you specify the whole pg_hba file on the commandline to initdb -- and most people today who actually care tha

Re: Make mesage at end-of-recovery less scary.

Hi Kyotaro, On 3/27/20 10:25 PM, James Coleman wrote: On Thu, Mar 26, 2020 at 12:41 PM Robert Haas wrote: I'm just spitballing here, but it would be really good if there's a way to know definitely whether or not you should be scared. Corrupted WAL segments are definitely a thing that happens,

Re: [PATCH] Implement INSERT SET syntax

On 4/23/20 8:04 PM, Gareth Palmer wrote: Thank you for the review, attached is v7 of the patch which should apply correcly to HEAD. This version now uses it's own production rule for the SET clause to avoid the issue with MultiAssigmentRef nodes in the targetList. Ibrar, Movead, you are the r

Re: WIP: Aggregation push-down

On 7/3/20 6:07 AM, Laurenz Albe wrote: On Thu, 2020-07-02 at 14:39 +0200, Daniel Gustafsson wrote: This version now fails to apply to HEAD, with what looks like like a trivial error in the expected test output. Can you please submit a rebased version so we can see it run in the patch tester CI?

Re: proposal - psql - possibility to redirect only tabular output

On 7/3/20 11:27 PM, Pavel Stehule wrote: pá 3. 7. 2020 v 12:16 odesílatel Artur Zakirov > napsal: The patch looks interesting. As far as I understand the purpose of the patch is to hide status messages from result output. So maybe it would be enough just t

Re: proposal: type info support functions for functions that use "any" type

pá 31. 7. 2020 v 2:32 odesílatel Tom Lane > napsal: So my opinion is still what it was in January. Since there does not appear to be support for this patch and it has not attracted any new review or comment in the last year I'm planning to close it on MAR 8 unle

Re: WIP: document the hook system

On 3/4/21 10:00 AM, Peter Eisentraut wrote: On 15.01.21 08:28, Peter Eisentraut wrote: On 2020-12-31 04:28, David Fetter wrote: This could probably use a lot of filling in, but having it in the actual documentation beats needing to know folklore even to know that the capability is there. This

Re: [PATCH] postgres-fdw: column option to override foreign types

On 3/4/21 9:28 AM, Georgios Kokolatos wrote: I am afraid I will have to :-1: this patch. Of course it is possible that I am wrong, so please correct me if you, or any other reviewers, think so. I'm inclined to agree and it seems like a view on the source server is a good compromise and elimi

Re: Nicer error when connecting to standby with hot_standby=off

Hi Fujii, On 9/8/20 1:17 PM, James Coleman wrote: On Tue, Aug 18, 2020 at 12:25 PM Fujii Masao wrote: Thanks for updating the patch! But it failed to be applied to the master branch cleanly because of the recent commit 0038f94387. So could you update the patch again? Updated patch attached.

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

Hi Georgios, On 9/13/20 12:04 PM, Nikolay Shaplov wrote: В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios Kokolatos написал: thank you for the patch. It applies cleanly, compiles and passes check, check-world. Thank you for reviewing efforts. Please find new v

Re: pgbench - add pseudo-random permutation function

Hi Álvaro, On 4/2/20 3:01 AM, Alvaro Herrera wrote: On 2020-Apr-02, Fabien COELHO wrote: I'm planning to mark this patch RwF on April 8 and I suggest you resubmit if you are able to get some consensus. People interested in non-uniform benchmarks would see the point. Why many people would be

Re: DROP INDEX CONCURRENTLY on partitioned index

Hi Michael, On 10/27/20 8:44 PM, Justin Pryzby wrote: 3. I have a patch which changes index_drop() to "expand" a partitioned index into its list of children. Each of these becomes a List: | indexId, heapId, userIndexRelation, userHeapRelation, heaplocktag, heaprelid, indexrelid The same pro

Re: problem with RETURNING and update row movement

On 10/30/20 6:00 AM, Amit Langote wrote: The question I guess is whether that thread must conclude before the fix here can be committed. Indeed. But it seems like there is a candidate patch on [1] though that thread has also stalled. I'll try to get some status on that thread but the question

Re: How to retain lesser paths at add_path()?

On 11/5/20 10:41 AM, Dmitry Dolgov wrote: On Tue, Jan 14, 2020 at 12:46:02AM +0900, Kohei KaiGai wrote: The v2 patch is attached. Thanks for the patch! I had a quick look at it and have a few questions: KaiGai, any thoughts on Dmitry's questions? Regards, -- -David da...@pgmasters.net

Re: Allow an alias to be attached directly to a JOIN ... USING

On 11/14/20 3:49 AM, Peter Eisentraut wrote: On 2020-11-10 16:15, Georgios Kokolatos wrote: I noticed that this patch fails on the cfbot. For this, I changed the status to: 'Waiting on Author'. Cheers, //Georgios The new status of this patch is: Waiting on Author Here is a rebased and lightl

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

Hi David, On 11/23/20 3:31 PM, Anastasia Lubennikova wrote: On 30.09.2020 05:00, David G. Johnston wrote: v5 attached, looking at this fresh and with some comments to consider. I ended up just combining both patches into one. I did away with the glossary changes altogether, and the invention

Re: Enhance traceability of wal_level changes for backup management

On 3/7/21 9:45 PM, osumi.takami...@fujitsu.com wrote: On Sun, Mar 7, 2021 3:48 AM Peter Eisentraut wrote: On 28.01.21 01:44, osumi.takami...@fujitsu.com wrote: (1) writing the time or LSN in the control file to indicate when/where wal_level is changed to 'minimal' from upper level to invalida

Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?

Hi David, On 11/24/20 10:28 PM, Euler Taveira wrote: I also reviewed your patch. This feature would be really useful for replication scenarios. Supporting this feature means that you don't need to use a table to pass messages from one node to another one. Here are a few comments/ideas. Do

Re: default result formats setting

On 11/25/20 2:06 AM, Peter Eisentraut wrote: On 2020-11-16 16:15, Andrew Dunstan wrote: I think this is conceptually OK, although it feels a bit odd. Might it be better to have the values as typename={binary,text} pairs instead of oid={0,1} pairs, which are fairly opaque? That might make things

Re: DROP relation IF EXISTS Docs and Tests - Bug Fix

On 3/9/21 10:08 AM, David G. Johnston wrote: On Tuesday, March 9, 2021, David Steele <mailto:da...@pgmasters.net>> wrote: Further, I think we should close this entry at the end of the CF if it does not attract committer interest. Tom is not in favor of the patch and i

Re: A problem about partitionwise join

On 11/27/20 7:05 AM, Ashutosh Bapat wrote: On Tue, Nov 10, 2020 at 2:43 PM Richard Guo wrote: To recap, the problem we are fixing here is when generating join clauses from equivalence classes, we only select the joinclause with the 'best score', or the first joinclause with a score of 3. This

Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs

On 11/30/20 10:37 AM, Pavel Stehule wrote: po 30. 11. 2020 v 16:06 odesílatel David G. Johnston ok This patch looks reasonable to me overall. A few comments: 1) PL/SQL seems to be used in a few places where I believe PL/pgSQL is meant. This was pre-existing but now seems like a good opportu

Re: Online verification of checksums

On 11/30/20 6:38 PM, David Steele wrote: On 11/30/20 9:27 AM, Stephen Frost wrote: * Michael Paquier (mich...@paquier.xyz) wrote: On Fri, Nov 27, 2020 at 11:15:27AM -0500, Stephen Frost wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Thu, Nov 26, 2020 at 8:42 AM Michael Paquier

Re: [patch] [doc] Minor variable related cleanup and rewording of plpgsql docs

On 3/9/21 1:08 PM, Tom Lane wrote: David Steele writes: 1) PL/SQL seems to be used in a few places where I believe PL/pgSQL is meant. This was pre-existing but now seems like a good opportunity to fix it, unless I am misunderstanding. PL/SQL is Oracle's function language, which PL/pgS

Re: Change JOIN tutorial to focus more on explicit joins

On 12/1/20 3:38 AM, Jürgen Purtz wrote: On 30.11.20 21:25, David G. Johnston wrote: Sorry, I managed to overlook the most recent patch. I admitted my use of parentheses was incorrect and I don't see anyone else defending them.  Please remove them. Minor typos: "the database compare" -> need

Re: error_severity of brin work item

On 12/1/20 5:25 PM, Justin Pryzby wrote: On Tue, Dec 01, 2020 at 03:57:24PM -0300, Alvaro Herrera wrote: Another idea is if perform_work_item() were responsible for discarding relations which disappear. Currently it does this, which is racy since it holds no lock. That has the property that

Re: proposal: unescape_text function

On 12/2/20 1:30 PM, Pavel Stehule wrote: st 2. 12. 2020 v 11:37 odesílatel Pavel Stehule st 2. 12. 2020 v 9:23 odesílatel Peter Eisentraut Heh.  The fact that there is a table of two dozen possible representations kind of proves my point that we should be deliberate i

Re: [PATCH] SET search_path += octopus

On 12/1/20 9:49 AM, Abhijit Menon-Sen wrote: Therefore, for lack of any plausible way to proceed, I do not plan to work on this feature any more. It sounds like this CF entry should be closed. I'll do that on March 12 unless somebody beats me to it. Regards, -- -David da...@pgmasters.net

Re: WIP: document the hook system

On 3/9/21 12:20 PM, Bruce Momjian wrote: On Sat, Mar 6, 2021 at 08:32:43PM -0500, Tom Lane wrote: I think that the best you should hope for here is that people are willing to add a short, not-too-detailed para to a markup-free plain-text README file that lists all the hooks. As soon as it gets

Re: [PATCH] Covering SPGiST index

On 12/4/20 12:31 PM, Pavel Borisov wrote: The cfbot's still unhappy --- looks like you omitted a file from the patch? You are right, thank you. Corrected this. PFA v13 Tom, do the changes as enumerated in [1] look like they are going in the right direction? Regards, -- -David da...@

Re: Add header support to text format and matching feature

On 12/7/20 6:40 PM, Rémi Lapeyre wrote: Hi, here’s a rebased version of the patch. Michael, since the issue of duplicated options has been fixed do either of these patches look like they are ready for commit? Regards, -- -David da...@pgmasters.net

Re: Consider parallel for lateral subqueries with limit

On 12/7/20 6:45 PM, James Coleman wrote: On Sun, Dec 6, 2020 at 7:34 PM Brian Davis wrote: Played around with this a bit, here's a non-correlated subquery that gets us to that if statement While I haven't actually tracked down to guarantee this is handled elsewhere, a thought experiment --

Re: [PATCH] Hooks at XactCommand level

Hi Julien, On 12/8/20 5:15 AM, Gilles Darold wrote: Based on a PoC reported in a previous thread [1] I'd like to propose new hooks around transaction commands. The objective of this patch is to allow PostgreSQL extension to act at start and end (including abort) of a SQL statement in a transact

Re: Disallow cancellation of waiting for synchronous replication

On 12/9/20 4:07 AM, Andrey Borodin wrote: 9 июня 2020 г., в 23:32, Jeff Davis написал(а): After using a patch for a while it became obvious that PANICing during termination is not a good idea. Even when we wait for synchronous replication. It generates undesired coredumps. I think in presenc

Re: WIP: Aggregation push-down

On 3/11/21 5:10 AM, Antonin Houska wrote: David Steele wrote: On 7/3/20 6:07 AM, Laurenz Albe wrote: On Thu, 2020-07-02 at 14:39 +0200, Daniel Gustafsson wrote: This version now fails to apply to HEAD, with what looks like like a trivial error in the expected test output. Can you please

Re: Autovacuum on partitioned table (autoanalyze)

On 12/14/20 8:46 PM, yuzuko wrote: On Thu, Dec 3, 2020 at 10:28 PM Alvaro Herrera wrote: Attach the new patch based on his patch. What do you think? Álvaro, Justin, Kyotaro, thoughts on this latest patch? Regards, -- -David da...@pgmasters.net

Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch

On 12/15/20 9:03 AM, Peter Eisentraut wrote: Here is a new patch for this.  This now follows the implementation that Tom has suggested:  Leave date_part() alone, add a new set of extract() functions, and map the SQL EXTRACT construct to those.  I have basically just copied over the implementati

Re: jsonpath syntax extensions

On 3/3/21 9:44 AM, David Steele wrote: On 3/4/20 3:18 PM, Nikita Glukhov wrote: On 04.03.2020 19:13, David Steele wrote: On 2/27/20 10:57 AM, Nikita Glukhov wrote: Attached patches implement several useful jsonpath syntax extensions. I already published them two years ago in the original SQL

Re: Strange behavior with polygon and NaN

On 12/21/20 3:30 AM, Kyotaro Horiguchi wrote: At Tue, 01 Dec 2020 10:03:42 -0500, Tom Lane wrote in I think it should be "needs review" now. Conflicted with some commit(s) uncertain to me. Rebased. Tom, Georgios, thoughts on the new patch? Regards, -- -David da...@pgmasters.net

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

On 12/23/20 2:27 PM, Stephen Frost wrote: * Justin Pryzby (pry...@telsasoft.com) wrote: On Mon, Nov 23, 2020 at 04:14:18PM -0500, Tom Lane wrote: * I don't think it's okay to change the existing signatures of pg_ls_logdir() et al. Even if you can make an argument that it's not too harmful to a

Re: Detecting File Damage & Inconsistencies

On 11/18/20 5:23 AM, Simon Riggs wrote: On Wed, 18 Nov 2020 at 06:42, Craig Ringer wrote: On Fri, Nov 13, 2020 at 7:24 PM Simon Riggs wrote: What I'm proposing is an option to add 16 bytes onto each COMMIT record Would it make sense to write this at the time we write a topxid assignment

Re: allow partial union-all and improve parallel subquery costing

Hi Luc, On 12/30/20 8:54 AM, Luc Vlaming wrote: Created a commitfest entry assuming this is the right thing to do so that someone can potentially pick it up during the commitfest. Providing an updated patch based on latest master. Looks like you need another rebase: http://cfbot.cputube.o

Re: dynamic result sets support in extended query protocol

Hi Peter, On 12/30/20 9:33 AM, Peter Eisentraut wrote: On 2020-10-09 20:46, Andres Freund wrote: Is there really a good reason for forcing the client to issue NextResult, Describe, Execute for each of the dynamic result sets? It's not like there's really a case for allowing the clients to skip

Re: 2019-03 CF now in progress

On 3/1/21 10:30 AM, David Steele wrote: Hackers, The 2019-03 commitfest is now in progress. It's a big one as usual. Needs review: 213. Waiting on Author: 21. Ready for Committer: 28. Committed: 29. Withdrawn: 3. Total: 294. We are now halfway through the 2021-03 commitfest, t

Re: Online verification of checksums

Hi Michael, On 11/20/20 2:28 AM, Michael Paquier wrote: On Mon, Nov 16, 2020 at 11:41:51AM +0100, Magnus Hagander wrote: I was referring to the latest patch on the thread. But as I said, I have not read up on all the different issues raised in the thread, so take it with a big grain os salt. A

Re: Online verification of checksums

Hi Michael, On 11/23/20 8:10 PM, Michael Paquier wrote: On Mon, Nov 23, 2020 at 10:35:54AM -0500, Stephen Frost wrote: Also- what is the point of reading the page from shared buffers anyway..? All we need to do is prove that the page will be rewritten during WAL replay. If we can prove that,

Re: Next Commitfest Manager.

last opportunity for features to land in time for the next major release and, for my part at least, I think it'd be best to have someone who has experience running a CF previously manage it. To that end, I've talked to David Steele, who has run this last CF for the past few years and we&

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 12/2/21 11:00, Andrew Dunstan wrote: On 12/1/21 19:30, Bossart, Nathan wrote: On 12/1/21, 10:37 AM, "Bossart, Nathan" wrote: On 12/1/21, 8:27 AM, "David Steele" wrote: On 11/30/21 18:31, Bossart, Nathan wrote: Do you think it's still worth trying to make it

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 12/2/21 12:38, David Steele wrote: On 12/2/21 11:00, Andrew Dunstan wrote: Should we really be getting rid of PostgreSQL::Test::Cluster::backup_fs_hot() ? Agreed, it would be better to update backup_fs_hot() to use exclusive mode and save out backup_label instead. Oops, of course I

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 1/6/22 20:20, Euler Taveira wrote: On Thu, Jan 6, 2022, at 9:48 PM, Bossart, Nathan wrote: After a quick glance, I didn't see an easy way to hold a session open while the test does other things.  If there isn't one, modifying backup_fs_hot() to work with non-exclusive mode might be more troub

Re: pg_stat_statements and "IN" conditions

On 1/5/21 10:51 AM, Zhihong Yu wrote: +   int         lastExprLenght = 0; Did you mean to name the variable lastExprLenghth ? w.r.t. extracting to helper method, the second and third if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar. It is up to you whether to create the hel

Re: [PATCH] Partial foreign key updates in referential integrity triggers

On 1/5/21 4:40 PM, Paul Martinez wrote: I've created a patch to better support referential integrity constraints when using composite primary and foreign keys. This patch allows creating a foreign key using the syntax: I previously proposed this feature about a year ago [1], but I don't fee

Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.

On 1/7/21 2:55 AM, shinya11.k...@nttdata.com wrote: But 0 value maybe looks strange, so in current version I show it like below: Type N (%) Record size (%) FPI size (%) Combined size (%) - --- --- --- --- - --- ... XLOG/SWITCH_JUNK - ( -) 11006248 ( 72.26) - ( -)

Re: Reloptions for table access methods

On 1/7/21 2:32 PM, Simon Riggs wrote: On Sat, Jan 2, 2021 at 6:44 PM Jeff Davis wrote: On Wed, 2020-12-30 at 21:23 +, Simon Riggs wrote: But you cannot seriously argue that a one line patch that changes user visible behavior can be acceptable in Postgres core without tests or docs or code

Re: Reduce the time required for a database recovery from archive.

Hi Dimtry, On 1/11/21 2:51 AM, Dmitry Shulga wrote: Hi Stephen Based on our last discussion I redesigned the implementation of WAL archive recovery speed-up. Seems like there should have been a patch attached? In any case the current patch no longer applies so marked Waiting on Author. P

Re: Implement for window functions

Hi Vik, On 1/11/21 5:00 PM, Tom Lane wrote: I started to look through this patch... I see you moved this patch to PG15. If you won't be working on the patch in this CF perhaps it would be better to close it as Returned with Feedback for now and reopen it when you have a new patch? I'll do

Re: [patch] [doc] Further note required activity aspect of automatic checkpoint and archving

Hi David, On 1/15/21 2:50 PM, David G. Johnston wrote: If the above wants to be made more explicit in this change maybe: "This is mitigated by the fact that archiving, and thus filling, the active WAL segment will not happen if that segment is empty; it will continue as the active segment."

Re: Reduce the time required for a database recovery from archive.

On 3/18/21 11:37 AM, Andrey Borodin wrote: 18 марта 2021 г., в 20:04, David Steele написал(а): it would be nice to support an interface that simply says to the restore_command, "go get 1gb of WAL and write the files here." +1 to redesigning restore_command and archive_command

Re: Rename of triggers for partitioned tables

On 1/15/21 5:26 PM, Alvaro Herrera wrote: On 2020-Nov-27, Arne Roland wrote: I got too annoyed at building queries for gexec all the time. So wrote a patch to fix the issue that the rename of partitioned trigger doesn't affect children. As you say, triggers on children don't necessarily have

Re: Implement for window functions

On 3/18/21 12:03 PM, Vik Fearing wrote: On 3/18/21 4:12 PM, David Steele wrote: Hi Vik, On 1/11/21 5:00 PM, Tom Lane wrote: I started to look through this patch... I see you moved this patch to PG15. If you won't be working on the patch in this CF Correct. I won't be worki

Re: invalid data in file backup_label problem on windows

On 1/14/21 10:50 PM, Wang, Shenhao wrote: Please feel free to, under the section "Bug fixes". This way, it won't get lost in the traffic of this list. -- Michael Thank you for your advise, added it I'm not sure how I feel about this patch (not really a Windows person) but I do think that

Re: Disable WAL logging to speed up data loading

On 1/17/21 12:16 AM, tsunakawa.ta...@fujitsu.com wrote: From: Osumi, Takamichi/大墨 昂道 I updated my patch to take in those feedbacks ! Have a look at the latest patch. Looks good to me (the status remains ready for committer.) After reading through the thread (but not reading the patch) I am

Re: Reduce the time required for a database recovery from archive.

On 3/19/21 4:32 AM, Marina Polyakova wrote: On 2021-03-18 18:04, David Steele wrote: Seems like there should have been a patch attached? IMO there's a technical problem with sending, receiving (or displaying on the site) emails from the list pgsql-hackers. By subsribing to this l

Re: invalid data in file backup_label problem on windows

On 3/19/21 6:11 AM, wangsh.f...@fujitsu.com wrote: David Steele wrote: I'm not sure how I feel about this patch (not really a Windows person) but I do think that you shouldn't modify the backup_label when writing it, i.e. you should be writing backup_label in binary mode to avoid

Re: fdatasync performance problem with large number of DB files

On 3/19/21 1:28 AM, Thomas Munro wrote: On Fri, Mar 19, 2021 at 3:23 PM Fujii Masao wrote: Thanks for updating the patch! It looks good to me! I have one minor comment for the patch. + elog(LOG, "could not open %s: %m", path); + return; + } + if (syncfs(

Re: support for MERGE

On 1/18/21 11:48 AM, Alvaro Herrera wrote: On 2021-Jan-18, Robert Haas wrote: On Thu, Dec 31, 2020 at 8:48 AM Alvaro Herrera wrote: Here's a rebase of Simon/Pavan's MERGE patch to current sources. I cleaned up some minor things in it, but aside from rebasing, it's pretty much their work (eve

Re: support for MERGE

On 3/19/21 10:44 AM, Alvaro Herrera wrote: On 2021-Mar-19, David Steele wrote: Since it does not appear this is being worked on for PG14 perhaps we should close it in this CF and then reopen it when a patch is available? No, please move it to the next CF. Thanks Ugh. I clicked wrong and

Re: truncating timestamps on arbitrary intervals

On 1/18/21 3:54 PM, John Naylor wrote: On Mon, Nov 23, 2020 at 1:44 PM John Naylor mailto:john.nay...@enterprisedb.com>> wrote: > > On Thu, Nov 12, 2020 at 9:56 AM Peter Eisentraut > wrote: > > - After reading the discussion a few times, I'm not so

Re: [PATCH] ProcessInterrupts_hook

On 1/19/21 1:42 AM, Craig Ringer wrote: On Tue, 19 Jan 2021 at 12:44, Craig Ringer mailto:craig.rin...@enterprisedb.com>> wrote: > We're about halfway there already, see 7e784d1dc.  I didn't do the > other half because it wasn't necessary to the problem, but e

Re: psql \df choose functions by their arguments

On 1/19/21 11:58 AM, Greg Sabino Mullane wrote: Ha ha ha, my bad, I am not sure why I left those out. Here is a new patch with int2, int4, and int8. Thanks for the email. Ian, does the new patch look good to you? Also, not sure why the target version for this patch is stable so I have updated

Re: create table like: ACCESS METHOD

On 1/19/21 4:03 PM, Justin Pryzby wrote: On Wed, Dec 30, 2020 at 12:33:56PM +, Simon Riggs wrote: There are no tests for the new functionality, please could you add some? Did you look at the most recent patch? +CREATE ACCESS METHOD heapdup TYPE TABLE HANDLER heap_tableam_handler; +CREATE

Re: Change default of checkpoint_completion_target

On 1/19/21 2:47 PM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Any further comments or thoughts on this one? This: +total time between checkpoints. The default is 0.9, which spreads the +checkpoint across the entire checkpoint timeout

Re: [HACKERS] Custom compression methods

On 3/19/21 8:00 PM, Andres Freund wrote: On 2021-03-19 15:44:34 -0400, Robert Haas wrote: I committed the core patch (0003) with a bit more editing. Let's see what the buildfarm thinks. Congrats Dilip, Robert, All. The slow toast compression has been a significant issue for a long time. Yes

Re: fdatasync performance problem with large number of DB files

On 3/19/21 7:16 PM, Thomas Munro wrote: Thanks Justin and David. Replies to two emails inline: Fair point. Here's what I went with: When set to fsync, which is the default, PostgreSQL will recursively open and synchronize all files in the data directory before crash

Re: [PATCH] Partial foreign key updates in referential integrity triggers

On 3/18/21 9:52 AM, David Steele wrote: On 1/5/21 4:40 PM, Paul Martinez wrote: I've created a patch to better support referential integrity constraints when using composite primary and foreign keys. This patch allows creating a foreign key using the syntax: I previously proposed

Re: Add Nullif case for eval_const_expressions_mutator

On 1/19/21 8:16 PM, Hou, Zhijie wrote: Attatching v3 patch, please consider it for further review. Peter, thoughts on the new patch in [1]? -- -David da...@pgmasters.net [1] https://www.postgresql.org/message-id/ab53b3dbdbd6436f970f33b51ccd7dd3%40G08CNEXMBPEKD05.g08.fujitsu.local

Re: SQL/JSON: JSON_TABLE

On 1/20/21 8:42 PM, Nikita Glukhov wrote: Thank you for review. Attached 45th version of the patches. "SQL/JSON functions" patch corresponds to v52 patch set posted in the separate thread. Another rebase needed (http://cfbot.cputube.org/patch_32_2902.log), marked Waiting on Author. I can se

  1   2   3   4   5   6   7   8   9   10   >