ing things
> along.
> > I've switched the 2023-07 CF to in-progress and 2023-09 to open, let's
> try to
> > close patches!
>
> Thanks, Daniel!
> --
> Michael
>
If nobody taking that, I can take the responsibility.--
Ibrar Ahmed
On Mon, Mar 20, 2023 at 7:56 PM Gregory Stark (as CFM)
wrote:
> On Wed, 4 Jan 2023 at 10:05, Ibrar Ahmed wrote:
> >
> > Thanks, I have modified everything as suggested, except one point
> >
> > > Don't use variable format strings. They're hard to read and they
>
> back something like that.
>
> * Another thought is that the non-text formats tend to prize output
> consistency over readability, so maybe we should just always use 2
> fractional digits there, rather than trying to minimize visible changes.
>
> In that, we need to adjust a lot of test case outputs.
* We need some doc adjustments, surely, to explain what the heck this
> means.
>
> regards, tom lane
>
--
Ibrar Ahmed
On Wed, Oct 5, 2022 at 3:01 PM Julien Rouhaud wrote:
> Hi,
>
> On Wed, Oct 05, 2022 at 02:50:58PM +0500, Ibrar Ahmed wrote:
> > On Wed, 5 Oct 2022 at 1:43 PM, Alvaro Herrera
> > wrote:
> >
> > > On 2022-Oct-03, Ibrar Ahmed wrote:
> > >
> > &
On Wed, 5 Oct 2022 at 1:43 PM, Alvaro Herrera
wrote:
> On 2022-Oct-03, Ibrar Ahmed wrote:
>
> > The date of the current commitfest is over, here is the current status of
> > the "September 2022 commitfest."
> > There were 296 patches in the commitfest and
next CF: 8.
Returned with Feedback: 5.
Rejected: 2. Withdrawn: 8.
--
Ibrar Ahmed.
with Feedback" and send the appropriate email
- For patches marked "Needs review
* If it received at least one good review, move it to the next CF
(removing the current reviewer reservation)
* Otherwise, leave them pending
--
Ibrar Ahmed
t;
> Ibrar, Hamid, have the checklist rewrites been helpful so far? Are you
> planning on doing an (optional!) triage, and if so, are there any
> pieces in particular you'd like me to document?
>
> --Jacob
>
I think we are good now, thanks Jacob, for the effort.
--
Ibrar Ahmed
kend/storage/file/fd.c
Hunk #1 FAILED at 2503.
1 out of 1 hunk FAILED -- saving rejects to file
src/backend/storage/file/fd.c.rej
patching file src/backend/utils/error/elog.c
Hunk #1 FAILED at 643.
Hunk #2 FAILED at 670.
--
Ibrar Ahmed
and the list tool is smart enough not to send duplicates to
> > people who are direct recipients).
>
> Ok - will do, thanks.
>
> --
> Reid Thompson
> Senior Software Engineer
> Crunchy Data, Inc.
>
> reid.thomp...@crunchydata.com
> www.crunchydata.com
>
>
> The patch does not apply; please rebase the patch.
patching file src/backend/utils/misc/guc.c
Hunk #1 FAILED at 3664.
1 out of 1 hunk FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/backend/utils/misc/postgresql.conf.sample
--
Ibrar Ahmed
ease rebase the patch.
patching file src/backend/utils/misc/guc.c
Hunk #1 FAILED at 642.
Hunk #2 FAILED at 3943.
2 out of 2 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/backend/utils/misc/postgresql.conf.sample
patching file src/include/jit/jit.h
--
Ibrar Ahmed
e number.
I will keep sending the emails for the reminder and change the status
of the patches entries accordingly.
Thanks to everyone who is participating in commitfest.
--
Ibrar Ahmed.
Senior Software Engineer, PostgreSQL Consultant.
Perhaps, futex was much slower than this
> days.
>
>
>
> The patch requires a rebase; please do that.
Hunk #1 FAILED at 231.
Hunk #2 succeeded at 409 (offset 82 lines).
1 out of 2 hunks FAILED -- saving rejects to file
src/include/storage/buf_internals.h.rej
--
Ibrar Ahmed
een executed before the SET ROLE.
>
>
> I left that last query in place as a sanity check to ensure that
> role_read_12's privileges were indeed not in effect after the call to SET
> ROLE.
>
> As we appear to now be working through the minutiae, it is my hope that
> this will soon be ready for merge.
>
> - Kenaniah
>
The patch requires a rebase, please do that.
Hunk #5 succeeded at 454 (offset 28 lines). 1 out of 5 hunks FAILED
-- saving rejects to file doc/src/sgml/ref/grant.sgml.rej
...
...
--
Ibrar Ahmed
6:17:08.194] Result: FAIL
[06:17:08.194] make[2]: *** [Makefile:23: check] Error 1
[06:17:08.194] make[1]: *** [Makefile:52: check-recovery-recurse] Error 2
[06:17:08.194] make: *** [GNUmakefile:71: check-world-src/test-recurse]
Error 2
--
Ibrar Ahmed
AT INT64_FORMAT
> "kB\n",
> +sortMethod, spaceType, avgSpaceUsed,
> peakSpaceUsed);
>
>
>
>
> ⚠ External Email: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender.
>
The patch failed different regression tests on all platforms. Please
correct that and send an updated patch.
[06:40:02.370] Test Summary Report
[06:40:02.370] ---
[06:40:02.370] t/002_pg_upgrade.pl (Wstat: 256 Tests: 13 Failed: 1)
[06:40:02.370] Failed test: 4
[06:40:02.370] Non-zero exit status: 1
[06:40:02.370] Files=2, Tests=21, 45 wallclock secs ( 0.02 usr 0.00 sys +
3.52 cusr 2.06 csys = 5.60 CPU)
--
Ibrar Ahmed
de.
Hunk #5 succeeded at 147 with fuzz 2 (offset -3 lines).
Hunk #6 FAILED at 170.
Hunk #7 succeeded at 165 (offset -69 lines).
2 out of 7 hunks FAILED -- saving rejects to file
src/include/portability/instr_time.h.rej
patching file src/tools/msvc/Mkvcbuild.pm
--
Ibrar Ahmed
6.
1 out of 4 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/include/miscadmin.h
--
Ibrar Ahmed
n this scope
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
[03:08:46.087] | ^~
[03:08:46.087] /tmp/cirrus-ci-build/contrib/cube/cubeparse.h:77:40: error:
expected primary-expression before ‘scanbuflen’
[03:08:46.087] 77 | int cube_yyparse (NDBOX **result, Size scanbuflen);
...
--
Ibrar Ahmed
n't* want.
>
> This is still listed in the CF as needing review, so I went and marked
> it rejected.
>
> +1, Thanks
> --
> John Naylor
> EDB: http://www.enterprisedb.com
>
--
Ibrar Ahmed
On Sat, Sep 3, 2022 at 12:09 PM Julien Rouhaud wrote:
> Hi,
>
> On Sat, Sep 03, 2022 at 10:36:37AM +0500, Ibrar Ahmed wrote:
> >
> > Hi Kyotaro Horiguchi, Fabien Coelho, Daniel Gustafsson,
> >
> > Since you haven't had time to write a review the last ma
backend/access/heap/rewriteheap.c
Hunk #1 FAILED at 113.
Hunk #2 FAILED at 1213.
Hunk #3 FAILED at 1221.
3 out of 3 hunks FAILED -- saving rejects to file
src/backend/access/heap/rewriteheap.c.rej
--
Ibrar Ahmed
his patch. Of course, you are still welcome to
review it if you can
find the time. We're removing your name so that other reviewers know the
patch still needs
attention. We understand that day jobs and other things get in the way of
doing patch
reviews when you want to, so please come back and review a patch or two
later when you
have more time.
--
Ibrar Ahmed
PostgreSQL 15)
22.
Unit tests for SLRU
Currently, we have 31 patches which require the author's attention.
If you already fixed and replied, change the status.
I'll send out reminders this week to get your patches
registered/rebased, I'll update stale statuses in the CF app.
Thanks,
--
Ibrar Ahmed.
emove all the hints like this from foreign data commands.
>
> - Don't show the hint when there are more than N valid options.
>
> - Do some kind of "did you mean" like we have for column names.
>
> Thoughts?
--
Ibrar Ahmed
On Tue, Aug 23, 2022 at 1:46 AM Hamid Akhtar wrote:
>
>
> On Tue, 23 Aug 2022 at 1:26 AM, Ibrar Ahmed
> wrote:
>
>>
>>
>> On Mon, Aug 22, 2022 at 9:47 PM Jacob Champion
>> wrote:
>>
>>> On Mon, Aug 22, 2022 at 9:40 AM Tom Lane wrote:
>&
https://wiki.postgresql.org/wiki/CommitFest_Checklist
>
>
> Thanks, I will start working.
--
Ibrar Ahmed.
Senior Software Engineer, PostgreSQL Consultant.
On Tue, Jul 5, 2022 at 4:31 PM Ibrar Ahmed wrote:
>
>
> On Tue, Jul 5, 2022 at 8:50 AM Michael Paquier
> wrote:
>
>> On Tue, Jul 05, 2022 at 08:17:26AM +0500, Ibrar Ahmed wrote:
>> > If nobody has already volunteered for the next upcoming commitfest.
>> &g
On Mon, Aug 8, 2022 at 10:11 PM Julien Rouhaud wrote:
> Hi,
>
> On Mon, Aug 08, 2022 at 08:21:06PM +0500, Ibrar Ahmed wrote:
> > While working on pg_stat_stements, I got some questions from customers to
> > have statistics by application and IP address.
> > [...]
>
based on IP and application
name. I did some POC and had a patch. But before sharing the patch.
I need to know if there has been any previous discussion about this topic;
by the way,
I did some Googling to find that but failed.
Thoughts?
--
Ibrar Ahmed.
Senior Software Engineer, PostgreSQL
On Sat, Jul 9, 2022 at 10:28 AM Thomas Munro wrote:
> On Sat, Jul 9, 2022 at 2:02 PM Ibrar Ahmed wrote:
> > Thanks for looking at that, yes you are right, the attached patch do
> that now
> >
> > if test "$PORTNAME" = "solaris"; then
> >
>
On Sat, Jul 9, 2022 at 6:46 AM Tom Lane wrote:
> Ibrar Ahmed writes:
> > While compiling the PostgreSQL I have found that *memset_s function
> > requires a define "*__STDC_WANT_LIB_EXT1__*" *
> > *explicit_bzero.c:* In function ‘*explicit_bzero*’:
> &
-Wimplicit-function-declaration*]
(void) *memset_s*(buf, len, 0, len);
*^~~~*
Attached is the patch to define that in the case of Solaris.
--
Ibrar Ahmed
solaris_memset_s_v1.patch
Description: Binary data
loops=1)
Output: objectid, fire_name, fire_year, discovery_date,
discovery_time, stat_cause_descr, fire_size, fire_size_class, latitude,
longitude, state, county,
discovery_date_j, discovery_date_d
Planning Time: 0.094 ms
Execution Time: 13.201 ms
(6 rows)
--
Ibrar Ahmed
> greg
>
+ -> Parallel Seq Scan on tenk1 (actual rows=1960.00
I have added a new check to remove any ".00" from the output because in
the case of parallel queries we are getting that. Secondly, it is
disturbing many test case outputs.
--
Ibrar Ahmed
On Thu, Jul 7, 2022 at 3:14 PM vignesh C wrote:
> On Thu, Jun 23, 2022 at 2:25 AM Ibrar Ahmed wrote:
> >
> >
> >
> > On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston <
> david.g.johns...@gmail.com> wrote:
> >>
> >> On Wed, Jun 22, 2022 at
On Thu, Jul 7, 2022 at 2:41 PM Amit Kapila wrote:
> On Thu, Jun 23, 2022 at 2:25 AM Ibrar Ahmed wrote:
> >
> > On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston <
> david.g.johns...@gmail.com> wrote:
> >>
> >> - WRITE_FLOAT_FIELD(rows, &qu
On Tue, Jul 5, 2022 at 8:50 AM Michael Paquier wrote:
> On Tue, Jul 05, 2022 at 08:17:26AM +0500, Ibrar Ahmed wrote:
> > If nobody has already volunteered for the next upcoming commitfest.
> > I'd like to volunteer. I think early to say is better as always.
>
> Jacob an
If nobody has already volunteered for the next upcoming commitfest.
I'd like to volunteer. I think early to say is better as always.
--
Ibrar Ahmed
On Mon, Jul 4, 2022 at 6:12 PM Drouvot, Bertrand
wrote:
> Hi,
> On 7/1/22 10:03 PM, Ibrar Ahmed wrote:
>
>
> On Thu, Jun 30, 2022 at 1:49 PM Drouvot, Bertrand
> wrote:
>
>> I'm going to re-create a CF entry for it, as:
>>
>> - It seems there is a clear i
gt; > "easily", what do you think?
> >
> > Thanks
> >
> > Bertrand
> >
> I'm going to re-create a CF entry for it, as:
>
> - It seems there is a clear interest for the feature (given the time
> already spend on it and the number of people that worked on)
>
> - I've in mind to resume working on it
>
> I have already done some research on that, I can definitely look at it.
> - It would give more visibility in case others want to jump in
>
> Hope that makes sense,
>
> Thanks,
>
> Bertrand
>
>
--
Ibrar Ahmed
On Thu, Jun 23, 2022 at 1:04 AM David G. Johnston <
david.g.johns...@gmail.com> wrote:
> On Wed, Jun 22, 2022 at 12:11 PM Ibrar Ahmed
> wrote:
>
>> On Thu, Jun 23, 2022 at 12:01 AM Tom Lane wrote:
>>
>>> Robert Haas writes:
>>> > On Jun 2, 200
loops=1
Workers Planned: 2
Workers Launched: 2
-> Parallel Seq Scan on bar (cost=0.00..7094.27 rows=1
width=4) (actual time=41.931..65.382 rows=0.33 loops=3)
Filter: (c = 1)
Rows Removed by Filter: 245457
Planning Time: 0.27
://www.postgresql.org/mailpref/pgsql-hackers
>
>
> Hi,
Do we still have some interest in this? People generally like that
the idea, if yes I am happy to work on that and can send the complete
design first.
--
Ibrar Ahmed
> kill list.
>
> I would still ask for someone to spend a little time triaging things,
> so as to direct people who volunteer to be so directed. Many will not
> want to be directed, but I'm sure there must be 5-10 people who would
> do that? (Volunteers?)
>
Count me as a Volunteer.
> --
> Simon Riggshttp://www.EnterpriseDB.com/
>
>
>
--
Ibrar Ahmed
to just
> automatically slide through?
>
+1 for the idea of allowed CFs. Secondly we can think about the patches
which
have not had a response from the author since long.
>
> regards, tom lane
>
>
>
--
Ibrar Ahmed
On Mon, Jul 26, 2021 at 5:52 PM Ibrar Ahmed wrote:
>
>
> On Mon, Jul 19, 2021 at 4:37 PM Ibrar Ahmed wrote:
>
>>
>>
>> On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed
>> wrote:
>>
>>>
>>> Hackers,
>>>
>>> The Commitf
On Mon, Jul 19, 2021 at 4:37 PM Ibrar Ahmed wrote:
>
>
> On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed wrote:
>
>>
>> Hackers,
>>
>> The Commitfest 2021-07 is now in progress. It is one of the biggest one.
>> Total number of patches of this commitfest i
On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed wrote:
>
> Hackers,
>
> The Commitfest 2021-07 is now in progress. It is one of the biggest one.
> Total number of patches of this commitfest is 342.
>
> Needs review: 204.
> Waiting on Author: 40.
> Ready for Committer: 1
plement some kid of adaptive query
> optimization based online_analyze extension and building extended
> statistic on demand.
> I have change clausesel.c because right now extended statistic is not
> used for join selectivity estimation and manual or automatic adding such
> statistic can help to
> choose more efficient plan for queries with joins.
> I agree wit you that it can be done in better way, handling more use cases.
> I will be glad to cooperate with you in improving join selectivity
> estimation using extended statistic.
>
>
>
> The patch does not compile, and needs your attention.
https://cirrus-ci.com/task/6397726985289728
clausesel.c:74:28: error: too few arguments to function
‘choose_best_statistics’
StatisticExtInfo *stat = choose_best_statistics(rel->statlist,
STATS_EXT_DEPENDENCIES,
^~
In file included from clausesel.c:24:
../../../../src/include/statistics/statistics.h:123:26: note: declared here
exter
I am changing the status to "Waiting on Author".
--
Ibrar Ahmed
/backend/postmaster/checkpointer.c
Hunk #3 succeeded at 496 with fuzz 1.
Hunk #4 FAILED at 576.
1 out of 6 hunks FAILED -- saving rejects to file
src/backend/postmaster/checkpointer.c.rej
patching file src/backend/postmaster/pgstat.c
I am changing the status to "Waiting on Author".
--
Ibrar Ahmed
gt;>
> Thank you for the report, This is fixed in the attached version, now all
> publication
> function calls accept the PublicationTableInfo list.
>
> Thank you,
> Rahila Syed
>
>
>
The patch does not apply, and an rebase is required
Hunk #8 succeeded at 1259 (offset 99 lines).
Hunk #9 succeeded at 1360 (offset 99 lines).
1 out of 9 hunks FAILED -- saving rejects to file
src/backend/replication/pgoutput/pgoutput.c.rej
patching file src/include/catalog/pg_publication.h
Changing the status to "Waiting on Author"
--
Ibrar Ahmed
gt; Regards,
> Greg Nancarrow
> Fujitsu Australia
>
The patch does not apply, and rebase is required.
Hunk #1 FAILED at 93.
1 out of 1 hunk FAILED -- saving rejects to file
src/test/regress/expected/sysviews.out.rej
I am not changing the status because it is a minor change and the
patch is already "Ready for Committer".
--
Ibrar Ahmed
ve the useless eval()
> >
> > - remove the "Catalog xmins should advance after standby logical slot
> > fetches the changes" test
> >
> > One thing that's not clear to me is your remark "There's also no test
> > for a recovery conflict due to row removal": Don't you think that the
> > "vacuum full" conflict test is enough? if not, what kind of additional
> > tests would you like to see?
> >
> >>
> >> There is also the 10s delay to work on, do you already have an idea
> >> on how we should handle it?
> >>
> >> Thanks
> >>
> >> Bertrand
> >>
> > Thanks
> >
> > Bertrand
> >
> Please find enclosed v20 a needed rebase (nothing serious worth
> mentioning) of v19.
>
> FWIW, just to sum up that v19 (and so v20):
>
> - contained the changes (see details above) related to your TAP tests
> remarks
>
> - contained the changes (see details above) related to your code remarks
>
> There is still the 10s delay thing that need work: do you already have
> an idea on how we should handle it?
>
> And still one thing that's not clear to me is your remark "There's also
> no test for a recovery conflict due to row removal": Don't you think
> that the "vacuum full" conflict test is enough? if not, what kind of
> additional tests would you like to see?
>
> Thanks
>
> Bertrand
>
>
>
>
>
The patch does not apply and an updated patch is required.
patching file src/include/replication/slot.h
Hunk #1 FAILED at 214.
1 out of 2 hunks FAILED -- saving rejects to file
src/include/replication/slot.h.rej
--
Ibrar Ahmed
Regards,
> --
> -David
> da...@pgmasters.net
Based on last comments of Paul and David S I am changing the status to
"Waiting on Author".
--
Ibrar Ahmed
.
> Also, choosing of a cheapest path after appendrel creation was added.
> Unstable tests were fixed.
>
> --
> regards,
> Andrey Lepikhov
> Postgres Professional
>
Patch is failing the regression, can you please take a look at that.
partition_join ... FAILED 6328 ms
--
Ibrar Ahmed
On Thu, Jul 15, 2021 at 2:35 PM Etsuro Fujita
wrote:
> On Thu, Jul 15, 2021 at 4:17 AM Ibrar Ahmed wrote:
> > On Wed, Jul 14, 2021 at 1:41 AM Tom Lane wrote:
> >> Seems to just need an update of the expected-file to account for test
> >> cases added recently. (I
re Center
>
>
> Yes, rebase is required, therefore I am changing the status to "Waiting On
Author"
http://cfbot.cputube.org/patch_33_2113.log
--
Ibrar Ahmed
ature requires specifying a fixed column or columns to update, so
> it cannot react differently to what column actually updated. In fact,
> you might want different referential actions depending on what columns
> are updated, like what you can do with general triggers.
>
> So, unless I'm missing an angle here, I would suggest leaving out the ON
> UPDATE variant of this feature.
>
>
>
Patch does not apply on head, I am marking the status "Waiting on author"
http://cfbot.cputube.org/patch_33_2932.log
--
Ibrar Ahmed
On Wed, Jul 14, 2021 at 1:41 AM Tom Lane wrote:
> Ibrar Ahmed writes:
> > The patch is failing the regression, @Tom Lane can
> you
> > please take a look at that.
>
> Seems to just need an update of the expected-file to account for test
> cases added recently. (I
regards
>
> --
> Tomas Vondra
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
The patch does not apply successfully, can you please take a look at that
http://cfbot.cputube.org/patch_33_1651.log
=== applying patch ./0001-v12-20210309.patch
atching file src/include/utils/selfuncs.h
Hunk #1 FAILED at 198.
1 out of 1 hunk FAILED -- saving rejects to file
src/include/utils/selfuncs.h.rej
Based on @Tomas Vondra comments, and patch does not apply, I am changing
the status to "Waiting On Author".
--
Ibrar Ahmed
d
> shortcoming of the previous approach, but here is a rebased version in
> the meantime.
>
>
> --
> Amit Langote
> EDB: http://www.enterprisedb.com
>
@Amit patch is not successfully applying, can you please rebase that.
Masahiko Sawada, it's been a bit long since you reviewed the patch, are you
still interested to review that?
--
Ibrar Ahmed
fdw ... FAILED 2782 ms
== shutting down postmaster ==
==
1 of 1 tests failed.
==
The differences that caused some tests to fail can be viewed in the
file "/tmp/cirrus-ci-build/contrib/postgres_fdw/regression.diffs". A copy
of the test summary that you see
above is saved in the file
"/tmp/cirrus-ci-build/contrib/postgres_fdw/regression.out".
--
Ibrar Ahmed
yes, that was my mistake.
>
> Regards,
> --
> -David
> da...@pgmasters.net
>
>
>
The status of the patch is "Need Review" which was previously "Ready for
Committer ''. After @David G
and @David Steele comments, it's not clear whether it
should be "Read for commit" or "Need Review".
--
Ibrar Ahmed
: 342.
If you are a patch author, please check http://commitfest.cputube.org to be
sure your patch still applies, compiles, and passes tests.
We need your involvement and participation in reviewing the patches. Let's
try and make this happen.
--
Regards.
Ibrar Ahmed
e negative but the chances of the LSN ascending N
> times but staying within the backup LSN range due to corruption seems to
> be approaching zero.
>
> I think Michael's method is unlikely to throw false positives, but it
> seems at least possible that a block would be hot enough to be appear
> torn N times in a row. Torn pages themselves are really easy to reproduce.
>
> If we do go forward with this method I would likely propose the
> LSN-based approach as a future improvement.
>
> Regards,
> --
> -David
> da...@pgmasters.net
>
>
>
I am changing the status to "Waiting on Author" based on the latest
comments of @David Steele
and secondly the patch does not apply cleanly.
http://cfbot.cputube.org/patch_33_2719.log
--
Ibrar Ahmed
this.
>
> >As I understand, this is a backpatchable bug-fix.
>
> Yes.
>
> Thanks.
>
> Patch does not apply successfully,
http://cfbot.cputube.org/patch_33_2161.log
Can you please rebase the patch.
--
Ibrar Ahmed
On Tue, Jul 6, 2021 at 3:58 PM Michael Paquier wrote:
> On Tue, Jul 06, 2021 at 03:38:23PM +0500, Ibrar Ahmed wrote:
> > Any update and decision on this? so I can start working on this.
>
> Working on the CF does not strongly require the admin permissions. I
> have already sw
On Fri, Jul 2, 2021 at 7:15 PM Ibrar Ahmed wrote:
>
>
> On Fri, 2 Jul 2021 at 7:06 PM, vignesh C wrote:
>
>> On Fri, Jul 2, 2021 at 6:05 PM Ibrar Ahmed wrote:
>> >
>> >
>> >
>> > On Fri, 2 Jul 2021 at 1:47 PM, David Rowley
>> wrot
On Fri, 2 Jul 2021 at 7:06 PM, vignesh C wrote:
> On Fri, Jul 2, 2021 at 6:05 PM Ibrar Ahmed wrote:
> >
> >
> >
> > On Fri, 2 Jul 2021 at 1:47 PM, David Rowley
> wrote:
> >>
> >> On Fri, 2 Jul 2021 at 15:04, vignesh C wrote:
> >> >
On Fri, 2 Jul 2021 at 1:47 PM, David Rowley wrote:
> On Fri, 2 Jul 2021 at 15:04, vignesh C wrote:
> > I'm interested in assisting Ibrar Ahmed.
>
> It might be worth talking to Ibrar to see where you can lend a hand. I
> think in terms of the number of patches, this mi
gt; > role is not filled and there are no objections.
>
> Ibrar Ahmed has already volunteered since a while back, so let's see if he
> is
> still keen to take it on:
>
>
> https://postgr.es/m/caltqxtcgbfeuwg-8mgmsaojp8te61_qaedjbnexjbybeeyz...@mail.gmail.com
>
> -
On Thu, Feb 4, 2021 at 1:13 AM Stephen Frost wrote:
> Greetings,
>
> * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
> > Anyone else already volunteers that? It is my first time so need some
> > access, if all agree.
>
> Thanks for volunteering!
>
> Tha
: *** Waiting for unfinished jobs
make[3]: *** [../../../src/backend/common.mk:39: transam-recursive] Error 2
make[2]: *** [common.mk:39: access-recursive] Error 2
make[1]: *** [Makefile:42: all-backend-recurse] Error 2
make: *** [GNUmakefile:11: all-src-recurse] Error 2
I am changing the status to "Waiting on Author"
--
Ibrar Ahmed
>
> Best regards,
> houzj
>
>
> One of the patch
(v10-0001-INSERT-SELECT-to-use-BulkInsertState-and-multi_i.patch) from the
patchset does not apply.
http://cfbot.cputube.org/patch_32_2553.log
1 out of 13 hunks FAILED -- saving rejects to file
src/backend/commands/copyfrom.c.rej
> EDB: https://www.enterprisedb.com/
>
>
>
Regression is failing, can you please take a look.
https://cirrus-ci.com/task/5522445932167168
t/080_pg_isready.pl ... ok
# Failed test 'parallel reindexdb for system with --concurrently skips
catalogs status (got 1 vs expected 0)'
# at t/090_reindexdb.pl line 191.
Bailout called. Further testing stopped: system pg_ctl failed
FAILED--Further testing stopped: system pg_ctl failed
make[2]: *** [Makefile:57: check] Error 255
make[1]: *** [Makefile:43: check-scripts-recurse] Error 2
make: *** [GNUmakefile:71: check-world-src/bin-recurse] Error 2
=== ./contrib/hstore_plperl/log/initdb.log ===
Running in no-clean mode. Mistakes will not be cleaned up.
The files belonging to this database system will be owned by user
"postgres".
This user must also own the server process.
--
--
Ibrar Ahmed
oes not apply successfully.
http://cfbot.cputube.org/patch_32_2901.log
=== Applying patches on top of PostgreSQL commit ID
0ce4cd04da558178b0186057b721c50a00b7a945 ===
=== applying patch ./func.sgml.20210123.diff
patching file doc/src/sgml/func.sgml
Hunk #1 FAILED at 16968.
Hunk #2 FAILED at 17034.
...
Hunk #19 FAILED at 18743.
19 out of 19 hunks FAILED -- saving rejects to file doc/src/sgml/func.sgml.rej
Can we get a rebase?
I am marking the patch "Waiting on Author".
--
Ibrar Ahmed
0 a 1
step c1: COMMIT;
----
Can you please take a look at that?
--
Ibrar Ahmed
atching file contrib/postgres_fdw/expected/postgres_fdw.out
Hunk #2 FAILED at 9179.
1 out of 2 hunks FAILED -- saving rejects to file
contrib/postgres_fdw/expected/postgres_fdw.out.rej
As this is a minor change therefore I have updated the patch. Please take a
look.
--
Ibrar Ahmed
pgsql14-truncate-on-foreign-table.v3.patch
Description: Binary data
'pgstat_temp_directory';
did you mean 'pgstat_stat_directory'?
_temp_directory,
^
pgstat_stat_directory
../../../../src/include/pgstat.h:922:14: note: 'pgstat_stat_directory'
declared here
extern char *pgstat_stat_directory;
^
guc.c:4373:3: error: use of undeclared identifier 'PG_STAT_TMP_DIR'
PG_STAT_TMP_DIR,
^
guc.c:4374:25: error: use of undeclared identifier
'assign_pgstat_temp_directory'
check_canonical_path, assign_pgstat_temp_directory, NULL
---
Can we get an updated patch?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
.c.rej
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
On Mon, Mar 8, 2021 at 8:59 PM Peter Geoghegan wrote:
> On Mon, Mar 8, 2021 at 6:41 AM Ibrar Ahmed wrote:
> > The patch
> (0001-Add-bool-column-for-LP_DEAF-flag-to-GiST-pageinspect.patch)
> > does not apply successfully and has multiple hanks failed.
>
> That's
rebased the patch, please take a look.
--
Ibrar Ahmed
null_check_on_pkey_optimization_v3.patch
Description: Binary data
.patch)
does
not apply successfully and has some hunks failed.
http://cfbot.cputube.org/patch_32_2918.log
1 out of 23 hunks FAILED -- saving rejects to file
src/backend/utils/misc/guc.c.rej
patching file src/include/catalog/catversion.h
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file
src/include/catalog/catversion.h.rej
patching file src/include/catalog/pg_authid.dat
Can we get a rebase?
I am marking the patch "Waiting on Author".
--
Ibrar Ahmed
ot;
I have regenerated the patch, can you please take a look.
http://cfbot.cputube.org/patch_32_2917.log
=== applying patch ./v4-0001-popcount.patch
can't find file to patch at input line 21
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--
--
Ibrar Ahmed
v5-0001-popcount.patch
Description: Binary data
_32_2824.log
patching file contrib/pageinspect/gistfuncs.c
Hunk #1 FAILED at 151.
Hunk #2 FAILED at 175.
Hunk #3 FAILED at 245.
Hunk #4 FAILED at 271.
...
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
it just saves
> > the failure case so +1 for back-patching.
>
> Thanks for the review! New patch version attached.
>
> - Heikki
>
The patch does not apply successfully
http://cfbot.cputube.org/patch_32_2864.log
1 out of 10 hunks FAILED -- saving rejects to file
src/bin/pg_rewind/pg_rewind.c.rej
There is a minor issue therefore I rebase the patch. Please take a look at
that.
--
Ibrar Ahmed
v3-0001-pg_rewind-Fix-determining-TLI-when-server-was-jus.patch
Description: Binary data
op the table
created in a test
case (aggregates), It's a bit minor change so the attached patch fixes
that issue.
https://cirrus-ci.com/task/6704792446697472
--
Ibrar Ahmed
v12-0001-GROUP-BY-optimization-made-compatible-with-chang.patch
Description: Binary data
rep.pl ok
Bailout called. Further testing stopped: system pg_ctl failed
FAILED--Further testing stopped: system pg_ctl failed
make[2]: *** [Makefile:19: check] Error 255
make[1]: *** [Makefile:49: check-recovery-recurse] Error 2
make: *** [GNUmakefile:71: check-world-src/test-recurse] Error 2
...
--
Ibrar Ahmed
changed by
another patch
-/* Define to build with OpenSSL support. (--with-ssl=openssl) */
+/* Define to 1 if you have OpenSSL support. */
Do you mind sending an updated patch?
http://cfbot.cputube.org/patch_32_2980.log.
I am changing the status to "Waiting for Author"
In my opini
has the previous thread. The old thread
has the v18 as the latest patch which is failing. The new thread which (
https://www.postgresql.org/message-id/CAJkzx4T5E-2cQe3dtv2R78dYFvz%2Bin8PY7A8MArvLhs_pg75gg%40mail.gmail.com
)
has the new patch.
--
Ibrar Ahmed
Y ON UPDATE
> referential_action`
> + `ALTER CONSTRAINT constraint_name [ALTER] FOREIGN KEY ON DELETE
> referential_action`
>
> This does not imply any changes, that are not in the command - very much
> analog to the ALTER COLUMN variants.
>
> This could also be extended in
gt; >>
> >> +/*
> >> + * Send WAL statistics only if WalWriterDelay has elapsed
> to
> >> minimize
> >> + * the overhead in WAL-writing.
> >> + */
> >> +if (rc & WL_TIMEOUT)
> >> +pgstat_send_wal();
> >>
> >> On second thought, this change means that it always takes
> >> wal_writer_delay
> >> before walwriter's WAL stats is sent after XLogBackgroundFlush() is
> >> called.
> >> For example, if wal_writer_delay is set to several seconds, some
> >> values in
> >> pg_stat_wal would be not up-to-date meaninglessly for those seconds.
> >> So I'm thinking to withdraw my previous comment and it's ok to send
> >> the stats every after XLogBackgroundFlush() is called. Thought?
> >
> > Thanks, I didn't notice that.
> >
> > Although PGSTAT_STAT_INTERVAL is 500msec, wal_writer_delay's
> > default value is 200msec and it may be set shorter time.
> >
> > Why don't to make another way to check the timestamp?
> >
> > + /*
> > +* Don't send a message unless it's been at least
> > PGSTAT_STAT_INTERVAL
> > +* msec since we last sent one
> > +*/
> > + now = GetCurrentTimestamp();
> > + if (TimestampDifferenceExceeds(last_report, now,
> > PGSTAT_STAT_INTERVAL))
> > + {
> > + pgstat_send_wal();
> > + last_report = now;
> > + }
> > +
> >
> > Although I worried that it's better to add the check code in
> > pgstat_send_wal(),
> > I didn't do so because to avoid to double check PGSTAT_STAT_INTERVAL.
> > pgstat_send_wal() is invoked pg_report_stat() and it already checks the
> > PGSTAT_STAT_INTERVAL.
>
> I forgot to remove an unused variable.
> The attached v13 patch is fixed.
>
> Regards
> --
> Masahiro Ikeda
> NTT DATA CORPORATION
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2859.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
that shouldn't be needed in a use like
> this? Especially not on stderr, which ought to be unbuffered?
>
>
> > + /*
> > + * Enter batch mode and dispatch a set of operations, which we'll
> then
> > + * process the results of as they come in.
> > + *
> > + * For a simple case we should be able to do this without interim
> > + * processing of results since our out buffer will give us enough
> slush to
> > + * work with and we won't block on sending. So blocking mode is
> fine.
> > + */
> > + if (PQisnonblocking(conn))
> > + {
> > + fprintf(stderr, "Expected blocking connection mode\n");
> > + goto fail;
> > + }
>
> Perhaps worth adding a helper for this?
>
> #define EXPECT(condition, explanation) \
> ...
> or such?
>
> Greetings,
>
> Andres Freund
>
>
>
The build is failing for this patch, can you please take a look at this?
https://cirrus-ci.com/task/4568547922804736
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.129221
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
more.
>
> regards, tom lane
>
>
>
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2569.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
range is neither left nor right any element */
>
> I these comments should all say ".. left nor right OF any ..."
>
> --
> Justin
>
>
>
This patch set no longer applies.
http://cfbot.cputube.org/patch_32_2747.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
hich in turn makes PQgetResult() return non-COMMAND_OK.
>
>
> Regards
> Takayuki Tsunakawa
>
>
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2601.log
Can we get a rebase?
I am marking the patch "Waiting on Author"
--
Ibrar Ahmed
to recreate OpenSSL's custom format.
>
> --Jacob
>
> [1]
> https://lists.apache.org/thread.html/2055b56985c69e7a6977151bf9817a0f982a4ad3b78a6a1984977fd0%401289507617%40%3Cusers.httpd.apache.org%3E
>
This patch set no longer applies
http://cfbot.cputube.org/patch_32_2835.log
Can we get a rebase?
I marked the patch "Waiting on Author".
--
Ibrar Ahmed
On Thu, Feb 4, 2021 at 2:00 AM David Steele wrote:
> On 2/3/21 3:13 PM, Stephen Frost wrote:
> > Greetings,
> >
> > * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
> >> Anyone else already volunteers that? It is my first time so need some
> >> access, if all
1 - 100 of 214 matches
Mail list logo
