Re: COPY table FROM STDIN via SPI

2023-07-12 Thread Joe Conway
On 7/12/23 14:43, c...@anastigmatix.net wrote: On 2023-07-12 14:18, Joe Conway wrote: On 7/11/23 22:52, James Sewell wrote: What about running a COPY directly from C - is that possible? https://www.postgresql.org/docs/current/libpq-copy.html Or is the question about a COPY kicked off from

Re: COPY table FROM STDIN via SPI

2023-07-12 Thread Joe Conway
-copy.html -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: RFC: pg_stat_logmsg

2023-07-09 Thread Joe Conway
On 7/7/23 01:38, Gurjeet Singh wrote: On Thu, Jul 6, 2023 at 12:37 AM Masahiko Sawada wrote: On Sat, Jul 1, 2023 at 8:57 AM Joe Conway wrote: > > The basic idea is to mirror how pg_stat_statements works, except the > logged messages keyed by filename, lineno, and elevel

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-07-03 Thread Joe Conway
On 7/3/23 12:25, Tristan Partin wrote: On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote: Although I have not looked yet, presumably we could have similar problems with plpython. I would like to get agreement on this approach against plperl before diving into that though. Thoughts? I

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-07-03 Thread Joe Conway
On 7/3/23 12:17, Tristan Partin wrote: The Reply-To header in your email is pointing at joe@cd, fyi. Pretty strange. I noticed that -- it happened only the one time, and I am not sure why. Seems fine now though. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon

Re: Optionally using a better backtrace library?

2023-07-02 Thread Joe Conway
it straightforward to add support for other object file and debugging formats. The state I currently have is very hacky, but if there's interest in upstreaming something like this, I could clean it up. +1 Seems useful! -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services

Re: RFC: pg_stat_logmsg

2023-07-01 Thread Joe Conway
On 6/30/23 23:20, Pavel Stehule wrote: so 1. 7. 2023 v 1:57 odesílatel Joe Conway <mailto:m...@joeconway.com>> napsal: Part of the thinking is that people with fleets of postgres instances can use this to scan for various errors that they care about. Additionally it would

RFC: pg_stat_logmsg

2023-06-30 Thread Joe Conway
8<-- Part of the thinking is that people with fleets of postgres instances can use this to scan for various errors that they care about. Additionally it would be useful to look for "should not happen" errors. I will register this in the July CF and will appreciate feedb

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-06-30 Thread Joe Conway
is still needed. 3/ I believe it is probably the right way to go for pg17+, but I would love to hear opinions from Jeff Davis, Peter Eisentraut, and/or Thomas Munroe (the locale code "usual suspects" ;-)), and others, about that. -- Joe Conway PostgreSQL Contributors Team RDS Open Source

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-06-24 Thread Joe Conway
On 6/22/23 03:26, Heikki Linnakangas wrote: On 21/06/2023 01:02, Joe Conway wrote: On 6/19/23 19:30, Heikki Linnakangas wrote: I think we should call "uselocale(LC_GLOBAL_LOCALE)" immediately after returning from the perl interpreter, instead of before setlocale() calls, if w

Re: EBCDIC sorting as a use case for ICU rules

2023-06-21 Thread Joe Conway
oking over-quoted contents. I'm open to suggestions on whether this EBCDIC example is worth being in the doc in some form or putting this in the wiki would be good enough. I would definitely favor adding to the docs, but no idea how to deal with the length issue. -- Joe Conway PostgreSQL Contrib

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-06-20 Thread Joe Conway
On 6/19/23 19:30, Heikki Linnakangas wrote: On 18/06/2023 21:27, Joe Conway wrote: I have proposed a targeted fix that I believe is safe to backpatch -- attached. IIUC, Tom was +1, but Heikki was looking for a more general solution. My issue with the more general solution

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-06-18 Thread Joe Conway
On 6/12/23 17:28, Joe Conway wrote: On 6/12/23 10:44, Joe Conway wrote: 1/ how do we fix the misbehavior reported due to libperl in existing stable branches I was mostly trying to concentrate on #1, but 2 & 3 are worthy of discussion. Hmm, browsing through the perl source I came ac

Re: [17] collation provider "builtin"

2023-06-15 Thread Joe Conway
change semantics; therefore they need no version and indexes are not at risk of corruption. See previous discussion[1]. I haven't studied the details yet but +1 for this idea. It models what we are actually doing. +1 agreed -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-06-12 Thread Joe Conway
On 6/12/23 10:44, Joe Conway wrote: 1/ how do we fix the misbehavior reported due to libperl in existing stable branches I was mostly trying to concentrate on #1, but 2 & 3 are worthy of discussion. Hmm, browsing through the perl source I came across a reference to this (from h

Re: BUG #17946: LC_MONETARY & DO LANGUAGE plperl - BUG

2023-06-12 Thread Joe Conway
(moving to hackers) On 6/12/23 05:13, Heikki Linnakangas wrote: On 10/06/2023 22:28, Joe Conway wrote: On 6/10/23 15:07, Joe Conway wrote: On 6/10/23 14:42, Tom Lane wrote: Joe Conway writes: 5/ The attached fixes the issue for me on pg10 and passes check-world. Comments? The call

Re: Cleaning up threading code

2023-06-10 Thread Joe Conway
that I missed? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: git.postgresql.org seems to be down

2023-06-08 Thread Joe Conway
On 6/8/23 20:02, Jaime Casanova wrote: Hi, Someone made https://git.postgresql.org/ depressed After not being able to pull, I dropped and tried to clone again: Try now -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Order changes in PG16 since ICU introduction

2023-06-08 Thread Joe Conway
On 6/8/23 17:15, Jeff Davis wrote: On Wed, 2023-06-07 at 20:52 -0400, Joe Conway wrote: If the provider has no such thing, throw an error. Just to be clear, that implies that users (and buildfarm members) with LANG=C.UTF-8 in their environment would not be able to run a plain "initdb -D

Re: Order changes in PG16 since ICU introduction

2023-06-07 Thread Joe Conway
UTF-8" explicitly as some distributions do, then use it. If the provider has no such thing, throw an error. Somewhere we should document that "C.UTF-8" from the provider might not be as stable or working as they expect. -- Joe Conway PostgreSQL Contributors Team RDS Open Source

Re: Let's make PostgreSQL multi-threaded

2023-06-07 Thread Joe Conway
where we are will be enormous. I seriously doubt that the net benefits could justify that work, no matter how long you want to look forward. It's not really significantly different from "let's rewrite the server in C++/Rust/$latest_hotness". Agreed. -- Joe Conway PostgreSQL Contributor

Re: Inconsistent results with libc sorting on Windows

2023-06-07 Thread Joe Conway
created libc collations that can be used with UTF-8 are affected, plus the default collation (French_France.1252 in my case). Wow, that sounds pretty horrid -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Order changes in PG16 since ICU introduction

2023-06-06 Thread Joe Conway
rnal" made more sense. Or perhaps "builtin" or "postgresql". Either OK by me Same here -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pg_collation.collversion for C.UTF-8

2023-06-06 Thread Joe Conway
be (a). However we should also clearly document that the semantics of such is provider/OS dependent and therefore may not be what is expected/desired. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Order changes in PG16 since ICU introduction

2023-06-06 Thread Joe Conway
does not behave like an ICU collation, even though pg_collation.collprovider='i' To me it's neither desirable nor necessary that a collation that has collprovider='i' is diverted to non-ICU semantics. It's not very principled, but it matches what libc does. Makes sense to me -- Joe Conway P

Re: Order changes in PG16 since ICU introduction

2023-06-06 Thread Joe Conway
On 6/6/23 15:15, Jeff Davis wrote: On Tue, 2023-06-06 at 14:11 -0400, Joe Conway wrote: This discussion makes me wonder (though probably too late for the v16 cycle) if we shouldn't treat "C" and "POSIX" locales to be a third provider, something like "internal"

Re: Order changes in PG16 since ICU introduction

2023-06-06 Thread Joe Conway
n, even though pg_collation.collprovider='i' To me it's neither desirable nor necessary that a collation that has collprovider='i' is diverted to non-ICU semantics. This discussion makes me wonder (though probably too late for the v16 cycle) if we shouldn't treat "C" and "POSIX"

Re: Inconsistent results with libc sorting on Windows

2023-06-05 Thread Joe Conway
is disabled. This is a wild shot in the dark, but I wonder if somehow the locale is being initialized (i.e. setlocale) differently in the parallel workers than the backend due to some Windows specific behavior differences? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases

Re: Let's make PostgreSQL multi-threaded

2023-06-05 Thread Joe Conway
and the prospect of fairly modest advantages. The risk to reward doesn't look great. That's my initial reaction. I could be convinced otherwise. I read through the thread thus far, and Andrew's response is the one that best aligns with my reaction. -- Joe Conway PostgreSQL Contributors Team

Re: Order changes in PG16 since ICU introduction

2023-05-24 Thread Joe Conway
e experience should be unified to the degree possible. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Bancolombia Open Source Program Office - Proposal of contribution on lock inactive users

2023-05-06 Thread Joe Conway
the folks on your team should follow the discussions on this list to become familiar with the people and the ways of the community. Hope this helps, -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: check_strxfrm_bug()

2023-04-19 Thread Joe Conway
s.c still ok. Has anyone taken a hard look at that? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Direct I/O

2023-04-19 Thread Joe Conway
how large the cache would need to be in order to be useful, or what we ought to be storing in it. The tactic TMO uses is basically to tune the available memory to get a target memory pressure. That seems like it could work. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Ama

Re: testing sepgsql in CI

2023-04-12 Thread Joe Conway
On 4/12/23 14:17, Andres Freund wrote: Hi, Forking of [1]. On 2023-04-12 14:11:10 -0400, Joe Conway wrote: On 4/12/23 13:44, Alvaro Herrera wrote: > Revert "Catalog NOT NULL constraints" and fallout > > This reverts commit e056c557aef4 and minor later fixes thereof. Seems

Re: Add standard collation UNICODE

2023-03-28 Thread Joe Conway
, I think it would be less confusing to keep the ICU locale on the same language. I definitely agree with that. If we ever manage to get rid of that, then I would also support making the ICU locale the root collation by default. +1 -- Joe Conway PostgreSQL Contributors Team RDS Open Source

Re: Improving inferred query column names

2023-02-23 Thread Joe Conway
soon be hitting NAMEDATALEN limits ... Probably an unpalatable idea, but if we did something like md5('avg(reltuples / relpages)') for the column name, it would be (reasonably) unique and deterministic. Not pretty, but possibly useful in some cases. -- Joe Conway PostgreSQL Contributors

Re: Non-superuser subscription owners

2023-02-22 Thread Joe Conway
tps://docs.oracle.com/javase/8/docs/api/java/security/AccessController.html#doPrivileged-java.security.PrivilegedAction-java.security.AccessControlContext- https://learn.microsoft.com/en-us/dotnet/api/system.security.permissions.dataprotectionpermission.intersect?view=dotnet-plat-ext-7.0 -- Joe Con

Re: [PATCH] Add <> support to sepgsql_restorecon

2023-01-18 Thread Joe Conway
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested This needs regression test support for the feature and some minimal

Re: [PATCH] Add <> support to sepgsql_restorecon

2023-01-16 Thread Joe Conway
On 1/16/23 09:55, Ted Toth wrote: On Sun, Jan 15, 2023 at 1:11 PM Joe Conway <mailto:m...@joeconway.com>> wrote: On 11/21/22 17:35, Joe Conway wrote: > On 11/21/22 15:57, Ted Toth wrote: >> In SELinux file context files you can specify <> for a file

Re: [PATCH] Add <> support to sepgsql_restorecon

2023-01-15 Thread Joe Conway
On 11/21/22 17:35, Joe Conway wrote: On 11/21/22 15:57, Ted Toth wrote: In SELinux file context files you can specify <> for a file meaning you don't want restorecon to relabel it. <> is especially useful in an SELinux MLS environment when objects are created at a specific se

Re: drop postmaster symlink

2023-01-12 Thread Joe Conway
On 1/12/23 12:00, Peter Eisentraut wrote: On 23.11.22 21:32, Joe Conway wrote: Yeah. Also, I don't think it's generally too hard to find the parent process anyway, because at least on my system, the other ones end up with ps display that looks like "postgres: logical replication lau

Re: drop postmaster symlink

2023-01-07 Thread Joe Conway
y understanding too. If it's trying to get rid of the "postmaster" terminology for our parent process, I'm very strongly against that, either as regards to code or documentation. +1 -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] random_normal function

2022-12-09 Thread Joe Conway
not be the only one. Thanks for the patch. What do you think about these results? Angels on pins time! :) I just noticed this thread -- what is lacking in the normal_rand() function in the tablefunc contrib? https://www.postgresql.org/docs/current/tablefunc.html#id-1.11.7.52.5 -- Joe Conway PostgreSQL

Re: Collation version tracking for macOS

2022-12-05 Thread Joe Conway
a specific collation behavior (I think, ignoring bugs?) -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Error-safe user functions

2022-12-05 Thread Joe Conway
-- nice word! I won't comment on its applicability to you in particular ;-P -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Error-safe user functions

2022-12-05 Thread Joe Conway
Maybe eretort? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Collation version tracking for macOS

2022-11-29 Thread Joe Conway
On 11/29/22 13:59, Jeff Davis wrote: On Tue, 2022-11-29 at 11:27 -0500, Joe Conway wrote: My vote is for something like #5. The collversion should indicate a specific immutable ordering behavior. Easier said than done: https://www.postgresql.org/message-id

Re: Collation version tracking for macOS

2022-11-29 Thread Joe Conway
d for each collation is explicitly specified in some way, and you just have to get it to match what you want to have happen. My vote is for something like #5. The collversion should indicate a specific immutable ordering behavior. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases

Re: drop postmaster symlink

2022-11-23 Thread Joe Conway
nk in the first place a few years ago was because selinux treats execution of programs from symlinks differently than from actual files. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: drop postmaster symlink

2022-11-23 Thread Joe Conway
pointing out that the PGDG RPMs still use the symlink in the included systemd service file: 8<-- ExecStart=/usr/pgsql-15/bin/postmaster -D ${PGDATA} 8<-- -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: fixing CREATEROLE

2022-11-22 Thread Joe Conway
attributes of roles, membership, when things are inherited versus not, settings bound to roles, etc). I don't know what to do about it, but yeah, fixing the documentation would be a noble goal. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] Add <> support to sepgsql_restorecon

2022-11-21 Thread Joe Conway
n to relabel them to the wrong security level. +1 Please add to the next commitfest here: https://commitfest.postgresql.org/41/ Thanks, -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: pgsql: Fix typos and bump catversion.

2022-11-19 Thread Joe Conway
On 11/19/22 17:24, Tom Lane wrote: Andres Freund writes: On 2022-11-19 17:10:57 -0500, Joe Conway wrote: Rishu Bagga pointed out to me offlist that this catversion bump seems flawed: /* mmddN */ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO

Re: pgsql: Fix typos and bump catversion.

2022-11-19 Thread Joe Conway
*/ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO 202211821 #endif I think that should be 202211181, no? I am not clear on the desirable way to fix though :-/ Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: out of memory in crosstab()

2022-11-16 Thread Joe Conway
be fixed and the fix be back-patched? -1 on backpatching -- this is not a bug, and the changes are non-trivial Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: RLS + XPATH

2022-10-31 Thread Joe Conway
. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: use has_privs_of_role() for pg_hba.conf

2022-10-08 Thread Joe Conway
omments or concerns, I will commit/push by the end of the weekend. -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: use has_privs_of_role() for pg_hba.conf

2022-10-06 Thread Joe Conway
the next week. Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: has_privs_of_role vs. is_member_of_role, redux

2022-08-25 Thread Joe Conway
e about these last two. Does it matter that object creation is being logged, maybe for auditing purposes, under a different user than the owner of the object? -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] Expose port->authn_id to extensions and triggers

2022-08-06 Thread Joe Conway
tification name" Oracle: "SYSTEM_USER Returns the name of the current data store user as identified by the operating system." I am not sure how else we should interpret SYSTEM_USER -- if it isn't port->authn_id what else would you propose it should be? -- Joe Conway RDS

Re: Proposal to provide the facility to set binary format output for specific OID's per session

2022-07-25 Thread Joe Conway
of the session. +1 makes a lot of sense to me. Dave please add this to the open commitfest (202209) -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Support logical replication of DDLs

2022-07-23 Thread Joe Conway
handy when there is a large number of databases to configure for logical replication. I would strongly favor #2, although I admittedly have no idea what complexities it adds. -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: let's disallow ALTER ROLE bootstrap_superuser NOSUPERUSER

2022-07-22 Thread Joe Conway
t/set_user/blob/1335cd34ca91b6bd19d5e910cc93c831d1ed0db0/README.md?plain=1#L612 https://github.com/pgaudit/set_user/blob/1335cd34ca91b6bd19d5e910cc93c831d1ed0db0/README.md?plain=1#L618 -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: [PATCH] Introduce array_shuffle() and array_sample()

2022-07-22 Thread Joe Conway
subarrays. Or else be lazy and reject more-than-one-D arrays; but it's probably not that hard to handle them. +1 Joe [1] https://www.postgresql.org/message-id/flat/Pine.LNX.4.44.0306281418020.2178-10%40peter.localdomain#a064d6dd8593993d799db453a3ee04d1 -- Joe Conway RDS Open Source Databases

Re: [Commitfest 2022-07] Begins Now

2022-07-19 Thread Joe Conway
reviewing a patch. So we definitely expect an email "soon" from someone in the second column, but not from somebody who is only in the first column. +1 -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Patch proposal: New hooks in the connection path

2022-07-07 Thread Joe Conway
On 7/6/22 04:13, Drouvot, Bertrand wrote: On 7/6/22 12:11 AM, Joe Conway wrote: On 7/5/22 03:37, Bharath Rupireddy wrote: 2. Timeout Handler is a signal handler, called as part of SIGALRM signal handler, most of the times, signal handlers ought to be doing small things, now that we are handing

Re: pg_parameter_aclcheck() and trusted extensions

2022-07-07 Thread Joe Conway
? Well there are other API breaks that affect me in v15, and to be honest I have done little except keep an eye out for the ones likely to affect extensions I maintain so far, so may as well inflict the pain now as later ¯\_(ツ)_/¯ Joe -- Joe Conway RDS Open Source Databases Amazon Web Services

Re: tuplesort Generation memory contexts don't play nicely with index builds

2022-07-07 Thread Joe Conway
r good question is why the email address no longer confirmed... -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Patch proposal: New hooks in the connection path

2022-07-05 Thread Joe Conway
8<-- + if (status != STATUS_OK) + { + if (FailedConnection_hook) 8<-- -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Hardening PostgreSQL via (optional) ban on local file system access

2022-07-01 Thread Joe Conway
ve a non-privileged NOINHERIT user for logging in and then do SET ROLE=; when needed, similar to using su/sudo in shell. This practice both reduces the attack surface and also provides auditability by knowing who logged in for superuser work. +many -- Joe Conway RDS Open Source Databas

Re: replacing role-level NOINHERIT with a grant-level option

2022-07-01 Thread Joe Conway
On 7/1/22 07:48, Robert Haas wrote: On Fri, Jul 1, 2022 at 6:17 AM Joe Conway wrote: Would this allow for an explicit REVOKE to override a default INHERIT along a specific path? Can you give an example? If you mean that A is granted to B which is granted to C which is granted to D and you

Re: replacing role-level NOINHERIT with a grant-level option

2022-07-01 Thread Joe Conway
-level option always takes precedence over the role-level option). Also, AFAICT this strategy still provides the full set of behavior that would be possible if only the grant-level option existed. Would this allow for an explicit REVOKE to override a default INHERIT along a specific path? -- Joe

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
On 6/22/22 12:28, Tom Lane wrote: Joe Conway writes: On 6/22/22 11:52, Tom Lane wrote: I think a case could be made for ONLY returning non-null when authn_id represents some externally-verified identifier (OS user ID gotten via peer identification, Kerberos principal, etc). But -1

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
On 6/22/22 11:35, Jacob Champion wrote: On Wed, Jun 22, 2022 at 8:10 AM Joe Conway wrote: --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -473,6 +473,7 @@ static OidAuthenticatedUserId = InvalidOid; static OidSessionUserId = InvalidOid; static Oid

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
On 6/22/22 11:52, Tom Lane wrote: Jacob Champion writes: On Wed, Jun 22, 2022 at 8:10 AM Joe Conway wrote: In case port->authn_id is NULL then the patch is returning the SESSION_USER for the SYSTEM_USER. Perhaps it should return NULL instead. If the spec says that SYSTEM_USER "re

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
, I would argue that not having the identifier for the external "user" available is a security concern. Ideally you want to be able to trace actions inside Postgres to the actual user that invoked them. -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: SYSTEM_USER reserved word implementation

2022-06-22 Thread Joe Conway
m#i1120532 "SYSTEM_USER Returns the name of the current data store user as identified by the operating system." Seems equivalent. -- Joe Conway RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

Re: Limiting memory allocation

2022-05-18 Thread Joe Conway
On 5/18/22 16:20, Alvaro Herrera wrote: On 2022-May-18, Joe Conway wrote: On 5/18/22 11:11, Alvaro Herrera wrote: > Apparently, if the cgroup goes over the "high" limit, the processes are > *throttled*. Then if the group goes over the "max" limit, OOM-kille

Re: Limiting memory allocation

2022-05-18 Thread Joe Conway
a container. And in fact most non-container installations these days are also running in a cgroup under systemd. The only difference is that you are more likely to see a memory limit set in a container than under systemd. [1] https://github.com/torvalds/linux/blob/master/Documentation/admi

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Joe Conway
On 4/7/22 12:37, Tom Lane wrote: Mark Dilger writes: On Apr 7, 2022, at 9:29 AM, Tom Lane wrote: I wouldn't fight too hard if people want to lengthen it to \dconfig for consistency with set_config(). I'd prefer \dconfig, but if the majority on this list view that as pedantically forcing

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Joe Conway
On 4/6/22 23:02, Tom Lane wrote: "Jonathan S. Katz" writes: +1 for \dconf Here's a draft patch using \dconf. No tests or docs yet. WFM -- using some form of \d makes more sense than \s, and I can't think of anything better that \dconf. I will say that I care about context far more

Re: How about a psql backslash command to show GUCs?

2022-04-06 Thread Joe Conway
On 4/6/22 13:58, Alvaro Herrera wrote: On 2022-Apr-06, Tom Lane wrote: However, I very often find myself resorting to the much more tedious select * from pg_settings where name like '%foo%'; when I want to see some related parameters, or when I'm a bit fuzzy on the exact name of the

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-04-02 Thread Joe Conway
On 3/28/22 15:56, Robert Haas wrote: On Mon, Mar 21, 2022 at 4:15 PM Joe Conway wrote: Robert -- any opinion on this? If I am not mistaken it is code that you are actively working on. Woops, I only just saw this. I don't mind if you want to change the calls to is_member_of_role

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-03-28 Thread Joe Conway
On 3/28/22 15:56, Robert Haas wrote: On Mon, Mar 21, 2022 at 4:15 PM Joe Conway wrote: Robert -- any opinion on this? If I am not mistaken it is code that you are actively working on. Woops, I only just saw this. I don't mind if you want to change the calls to is_member_of_role

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-03-28 Thread Joe Conway
On 3/21/22 16:15, Joe Conway wrote: On 3/20/22 12:38, Stephen Frost wrote: Greetings, On Sun, Mar 20, 2022 at 18:31 Joshua Brindle mailto:joshua.brin...@crunchydata.com>> wrote: On Sun, Mar 20, 2022 at 12:27 PM Joe Conway mailto:m...@joeconway.com>> wrote: > &g

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-03-21 Thread Joe Conway
On 3/20/22 12:38, Stephen Frost wrote: Greetings, On Sun, Mar 20, 2022 at 18:31 Joshua Brindle mailto:joshua.brin...@crunchydata.com>> wrote: On Sun, Mar 20, 2022 at 12:27 PM Joe Conway mailto:m...@joeconway.com>> wrote: > > On 3/3/22 11:26, Jo

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-03-20 Thread Joe Conway
On 3/20/22 12:31, Joshua Brindle wrote: On Sun, Mar 20, 2022 at 12:27 PM Joe Conway wrote: On 3/3/22 11:26, Joshua Brindle wrote: > On Thu, Feb 10, 2022 at 2:37 PM Joe Conway wrote: >> >> On 2/10/22 14:28, Nathan Bossart wrote: >> > On Wed, Feb 09, 2022 at 04:39:11PM

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-03-20 Thread Joe Conway
On 3/3/22 11:26, Joshua Brindle wrote: On Thu, Feb 10, 2022 at 2:37 PM Joe Conway wrote: On 2/10/22 14:28, Nathan Bossart wrote: > On Wed, Feb 09, 2022 at 04:39:11PM -0500, Joe Conway wrote: >> On 2/9/22 13:13, Nathan Bossart wrote: >>> I do wonder if users find the d

Re: List of all* PostgreSQL EXTENSIONs in the world

2022-02-23 Thread Joe Conway
On 2/23/22 09:52, Aleksander Alekseev wrote: > What about scanning for "PG_MODULE_MAGIC"? An extension can be written without using C at all. BTW some extensions [1] are written in Rust these days. Sure, but scanning for PG_MODULE_MAGIC may well pick up repos that would otherwise have been

Re: List of all* PostgreSQL EXTENSIONs in the world

2022-02-23 Thread Joe Conway
On 2/23/22 09:33, Euler Taveira wrote: On Wed, Feb 23, 2022, at 6:00 AM, Joel Jacobson wrote: On Fri, Feb 11, 2022, at 04:46, Noah Misch wrote: > How did you make the list?  (I'd imagine doing it by searching for > repositories containing evidence like \bpgxs\b matches.) Searching Github for

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/18/22 15:53, Andres Freund wrote: the next run succeeded, with 'PYTHON' => 'python3' in build env. But presumably this just was because you installed the python3-devel package? Ok, I guess I got confused when it failed due to the missing devel package, because I removed the PYTHON =>

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/18/22 15:25, Andres Freund wrote: On 2022-02-18 14:46:39 -0500, Joe Conway wrote: $ ll /usr/bin/python lrwxrwxrwx. 1 root root 7 Mar 13 2021 /usr/bin/python -> python2 8<--- Yea, that all looks fine. What's the problem if you don't specify the PYTHON=python3?

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/18/22 14:37, Andres Freund wrote: Hi, On 2022-02-18 14:19:49 -0500, Joe Conway wrote: On 2/17/22 13:08, Andres Freund wrote: > On 2022-02-16 23:14:46 -0800, Andres Freund wrote: > > > Done. Curious how red the BF will turn out to be. Let's hope it's not > > > too b

Re: Time to drop plpython2?

2022-02-18 Thread Joe Conway
On 2/17/22 13:08, Andres Freund wrote: On 2022-02-16 23:14:46 -0800, Andres Freund wrote: > Done. Curious how red the BF will turn out to be. Let's hope it's not > too bad. - rhinoceros Joe replied that he is afk, looking into it tomorrow. I installed python3 packages (initially

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Joe Conway
On 2/15/22 13:47, Robert Haas wrote: On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: (moving to hackers) I guess shame on me for not noticing the thread, but I don't see any discussion about the potential for breakage to external projects. scanint8() is exported, and this change breaks

Re: pgsql: Move scanint8() to numutils.c

2022-02-15 Thread Joe Conway
On 2/14/22 16:18, Peter Eisentraut wrote: Move scanint8() to numutils.c Move scanint8() to numutils.c and rename to pg_strtoint64(). We already have a "16" and "32" version of that, and the code inside the functions was aligned, so this move makes all three versions consistent. The API is

Re: Observability in Postgres

2022-02-15 Thread Joe Conway
On 2/15/22 07:30, Dave Page wrote: On Mon, 14 Feb 2022 at 20:16, Greg Stark > wrote: So I've been dealing a lot with building and maintaining dashboards for (fleets of) Postgres servers. And it's a pain. I have a few strongly held ideas about where the pain

Re: List of all* PostgreSQL EXTENSIONs in the world

2022-02-10 Thread Joe Conway
On 2/10/22 15:35, Robert Haas wrote: On Thu, Feb 10, 2022 at 3:19 PM Joel Jacobson wrote: I've compiled a list of all* PostgreSQL EXTENSIONs in the world: https://gist.github.com/joelonsql/e5aa27f8cc9bd22b8999b7de8aee9d47 *) It's not all, but 1041, compared to the 338 found on PGXN. Maybe

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-02-10 Thread Joe Conway
On 2/10/22 14:28, Nathan Bossart wrote: On Wed, Feb 09, 2022 at 04:39:11PM -0500, Joe Conway wrote: On 2/9/22 13:13, Nathan Bossart wrote: I do wonder if users find the differences between predefined roles and role attributes confusing. INHERIT doesn't govern role attributes

Re: [PATCH v2] use has_privs_for_role for predefined roles

2022-02-09 Thread Joe Conway
On 2/9/22 13:13, Nathan Bossart wrote: On Tue, Feb 08, 2022 at 10:54:50PM -0500, Robert Haas wrote: On Tue, Feb 8, 2022 at 7:38 PM Joe Conway wrote: If we were to start all over again with this feature my vote would be to do things differently than we have done. I would not have called them

<    1   2   3   4   >