Tom pointed out two errors that could effect the HS startup code, which
is fairly subtle.
Attached patch is small with these changes
* adds new section comment as posted to hackers earlier
* adds comments to other functions
* makes minor corrections to a few existing comments
* fixes the two bugs
It is an announcement that long-waited bug-fix of pg_lesslog is now
released. This includes the following.
1. Error in calculation of GiST-related WAL record length was fixed.
2. pg_compresslog now has an option to print WAL segment analysis.
3. New test script is added which analyzes what WAL r
On Wed, May 12, 2010 at 2:50 AM, Simon Riggs wrote:
> On Tue, 2010-05-11 at 14:01 +0900, Fujii Masao wrote:
>> On Mon, May 10, 2010 at 3:27 PM, Simon Riggs wrote:
>> > I already explained that killing the startup process first is a bad idea
>> > for many reasons when shutdown was discussed. Can't
On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
> I'm not sure what to make of this. Sometimes not shutting down
> doesn't sound like a feature to me.
It acts exactly the same in recovery as in normal running. It is not a
special feature of recovery at all, bug or otherwise.
You may think
On Wed, May 12, 2010 at 12:26 PM, Simon Riggs wrote:
> On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
>
>> I'm not sure what to make of this. Sometimes not shutting down
>> doesn't sound like a feature to me.
>
> It acts exactly the same in recovery as in normal running. It is not a
> spec
On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
> On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
>
>> I'm not sure what to make of this. Sometimes not shutting down
>> doesn't sound like a feature to me.
>
> It acts exactly the same in recovery as in normal running. It is not a
> speci
On Wed, 2010-05-12 at 08:52 -0400, Robert Haas wrote:
> On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
> > On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
> >
> >> I'm not sure what to make of this. Sometimes not shutting down
> >> doesn't sound like a feature to me.
> >
> > It acts ex
Simon Riggs wrote:
On Wed, 2010-05-12 at 08:52 -0400, Robert Haas wrote:
On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
I'm not sure what to make of this. Sometimes not shutting down
doesn't sound like a feature to me.
It acts exac
On Tue, 11 May 2010, Alvaro Herrera wrote:
Excerpts from Marc G. Fournier's message of mar may 11 09:58:34 -0400 2010:
If list traffic, especially on -hackers, is getting so large, should we
look at maybe splitting it? I could easily enough split things such that
I duplicate the subscriber li
Hackers,
The current version of levenshtein function in fuzzystrmatch contrib modulte
doesn't work properly with multibyte charater sets.
test=# select levenshtein('фыва','аыва');
levenshtein
-
2
(1 row)
My patch make this function works properly with multibyte charater s
Excerpts from Marc G. Fournier's message of mar may 11 09:58:34 -0400 2010:
> If list traffic, especially on -hackers, is getting so large, should we
> look at maybe splitting it? I could easily enough split things such that
> I duplicate the subscriber list, so nobody would have to subscribe,
Getting significantly lower performance on a specific query after upgrading
from 8.3 -> 8.4 (windows). I'm not expecting a quick fix from the mail
lists, but I would appreciate any indications as to where else I could look
or what tools I could employ to investigae further. Details below.
-Bren
Brendan,
* Brendan Hill (brend...@jims.net) wrote:
> Getting significantly lower performance on a specific query after upgrading
> from 8.3 -> 8.4 (windows). I'm not expecting a quick fix from the mail
> lists, but I would appreciate any indications as to where else I could look
> or what tools I
"Brendan Hill" wrote:
> AND Notes.Person_ID IN (SELECT
> ISNULL(Personnel.Person_ID, Businesses.Main_Person_ID)
You might try switching this to an EXISTS test.
If you post on this topic again, really it should be on the -perform
list, as Stephen mentioned, and review this page for ideas on o
On Wed, 2010-05-12 at 16:03 +0200, Stefan Kaltenbrunner wrote:
> Simon Riggs wrote:
> > On Wed, 2010-05-12 at 08:52 -0400, Robert Haas wrote:
> >> On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
> >>> On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
> >>>
> I'm not sure what to make
Hello
I would to repeatably update non indexed column of temp table. I
expected cheap operation, but it isn't true.
p ostgres=# create temp table x(a int primary key, b int);
NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index
"x_pkey" for table "x"
CREATE TABLE
Time: 363,339 ms
postgr
On Wed, 2010-05-12 at 14:18 +0100, Simon Riggs wrote:
> On Wed, 2010-05-12 at 08:52 -0400, Robert Haas wrote:
> > On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
> > > On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
> > >
> > >> I'm not sure what to make of this. Sometimes not shutting
Pavel Stehule wrote:
> I would to repeatably update non indexed column of temp table. I
> expected cheap operation, but it isn't true.
You're updating the row 10 times within a single transaction. I
don't *think* HOT will reclaim a version of a row until the
transaction which completed it
On Wed, May 12, 2010 at 11:34 AM, Kevin Grittner
wrote:
> Pavel Stehule wrote:
>
>> I would to repeatably update non indexed column of temp table. I
>> expected cheap operation, but it isn't true.
>
> You're updating the row 10 times within a single transaction. I
> don't *think* HOT will re
"Kevin Grittner" writes:
> You're updating the row 10 times within a single transaction. I
> don't *think* HOT will reclaim a version of a row until the
> transaction which completed it is done and no other transactions can
> see that version any longer. It does raise the question, though --
momj...@postgresql.org (Bruce Momjian) writes:
> Add PGAPPICON to all executable makefiles.
Is it really a good idea to have done that to the server, in particular?
I can't imagine it being a good idea to launch the postmaster from a
GUI, which is what I suppose this is good for.
Tom Lane wrote:
> The correct question to ask is whether we could
> vacuum away the older elements of the HOT chain on the grounds that they
> are no longer of interest. What we would see is tuples with xmin equal
> to xmax and cmin different from cmax. The problem then is to determine
> whether
On Wed, May 12, 2010 at 11:47 AM, Tom Lane wrote:
> "Kevin Grittner" writes:
>> You're updating the row 10 times within a single transaction. I
>> don't *think* HOT will reclaim a version of a row until the
>> transaction which completed it is done and no other transactions can
>> see that v
Heikki Linnakangas writes:
> Tom Lane wrote:
>> The correct question to ask is whether we could
>> vacuum away the older elements of the HOT chain on the grounds that they
>> are no longer of interest. What we would see is tuples with xmin equal
>> to xmax and cmin different from cmax. The probl
Merlin Moncure writes:
> isn't it possible to skip the snapshot check for temp tables though?
No, it's no different from the regular-table case. There could be
snapshots that could see the older tuple versions --- consider
functions inside queries, etc.
regards, tom lane
On Wed, May 12, 2010 at 11:28 AM, Simon Riggs wrote:
> On Wed, 2010-05-12 at 14:18 +0100, Simon Riggs wrote:
>> On Wed, 2010-05-12 at 08:52 -0400, Robert Haas wrote:
>> > On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
>> > > On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
>> > >
>> > >
The server's messages and the documentation uses all of these terms in
mixed ways. Maybe we could decide on some preferred terminology and
adjust the existing texts. Ideas?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.po
On Wed, May 12, 2010 at 07:33:53PM +0300, Peter Eisentraut wrote:
> The server's messages and the documentation uses all of these terms in
> mixed ways. Maybe we could decide on some preferred terminology and
> adjust the existing texts. Ideas?
How about origin/subscriber? More descriptive than
Peter Eisentraut writes:
> The server's messages and the documentation uses all of these terms in
> mixed ways. Maybe we could decide on some preferred terminology and
> adjust the existing texts. Ideas?
Primary/secondary seem like a poor choice because they're such generic
terms. Master/slave
David Fetter wrote:
> How about origin/subscriber?
Seems like a mixed metaphor. Publisher normally goes with
subscriber. I've heard and used origin and replica.
Are we planning to support a subscriber which also publishes (to
randomly pick one for purposes of discussion)? If so, that shou
On Wed, 2010-05-12 at 12:04 -0400, Robert Haas wrote:
> Huh?? The evidence that this bug is linked with HS is that it occurs
> on a server running in HS mode, and not otherwise. As for whether the
> bug is code I committed, that's certainly possible, but keep in mind
> it didn't work at all befor
On Wed, May 12, 2010 at 5:49 PM, Simon Riggs wrote:
> On Wed, 2010-05-12 at 12:04 -0400, Robert Haas wrote:
>
>> Huh?? The evidence that this bug is linked with HS is that it occurs
>> on a server running in HS mode, and not otherwise. As for whether the
>> bug is code I committed, that's certain
On Wed, 2010-05-12 at 18:05 +0100, Greg Stark wrote:
> I'm not sure who to blame for the shouting match over whose commit
> introduced the bug -- it doesn't seem like a relevant or useful thing
> to argue about, please both stop.
I haven't blamed Robert's code, merely asked him to consider that i
Tom Lane wrote:
> momj...@postgresql.org (Bruce Momjian) writes:
> > Add PGAPPICON to all executable makefiles.
>
> Is it really a good idea to have done that to the server, in particular?
> I can't imagine it being a good idea to launch the postmaster from a
> GUI, which is what I suppose this is
Bruce Momjian writes:
> Tom Lane wrote:
>> momj...@postgresql.org (Bruce Momjian) writes:
>>> Add PGAPPICON to all executable makefiles.
>>
>> Is it really a good idea to have done that to the server, in particular?
>> I can't imagine it being a good idea to launch the postmaster from a
>> GUI, w
On Wed, 2010-05-12 at 09:37 -0700, David Fetter wrote:
> On Wed, May 12, 2010 at 07:33:53PM +0300, Peter Eisentraut wrote:
> > The server's messages and the documentation uses all of these terms in
> > mixed ways. Maybe we could decide on some preferred terminology and
> > adjust the existing text
On Wed, 2010-05-12 at 17:49 +0100, Simon Riggs wrote:
> On Wed, 2010-05-12 at 12:04 -0400, Robert Haas wrote:
> Normal shutdown didn't work on a standby before HS was committed and it
> didn't work afterwards either. Use all the capitals you like but if you
> use poor arguments and combine that wi
A look at the MSVC buildfarm members shows that they are not building
most of the files added to contrib/pg_upgrade. The reason seems to be
that that module tries to build both an executable program *and* a
shared library, which it does by dint of setting both PROGRAM and
MODULES in its Makefile.
Hi
I just tried to checkout REL9_0_BETA1 from my local clone of the GIT repository
at git.postgresql.org and discovered that none of the tags from CVS seem to
exist in there. For alpha1 to alpha1 each tag is accompanied by a corresponding
brach, and those *do* exist on the GIT mirror. For beta1
On Wed, May 12, 2010 at 1:21 PM, Simon Riggs wrote:
> On Wed, 2010-05-12 at 18:05 +0100, Greg Stark wrote:
>
>> I'm not sure who to blame for the shouting match over whose commit
>> introduced the bug -- it doesn't seem like a relevant or useful thing
>> to argue about, please both stop.
>
> I hav
On Wed, May 12, 2010 at 8:27 PM, Florian Pflug wrote:
> Hi
>
> I just tried to checkout REL9_0_BETA1 from my local clone of the GIT
> repository at git.postgresql.org and discovered that none of the tags from
> CVS seem to exist in there. For alpha1 to alpha1 each tag is accompanied by a
> corr
While fooling around with Hot Standby today, I did this on the master:
rhaas=# begin work;
BEGIN
rhaas=# lock table pgbench_accounts;
LOCK TABLE
Then on slave I did this:
rhaas=# select * from pgbench_accounts;
ERROR: canceling statement due to conflict with recovery
DETAIL: User query might h
Tom Lane wrote:
> If so, master/standby would probably work.
+1 for master/standby.
It's worth remembering that a "standby server" might not be actively
connected to a master server. A server that's reading WAL from an
archive backup, for example, can be put to standby mode. "Standby"
covers that
On Wed, 2010-05-12 at 19:33 +0300, Peter Eisentraut wrote:
> The server's messages and the documentation uses all of these terms in
> mixed ways. Maybe we could decide on some preferred terminology and
> adjust the existing texts. Ideas?
Never user the term "secondary" myself.
I deliberately us
Excerpts from Alexander Korotkov's message of lun may 10 11:35:02 -0400 2010:
> Hackers,
>
> The current version of levenshtein function in fuzzystrmatch contrib modulte
> doesn't work properly with multibyte charater sets.
> My patch make this function works properly with multibyte charater sets
On 05/12/2010 05:28 PM, Simon Riggs wrote:
On Wed, 2010-05-12 at 14:18 +0100, Simon Riggs wrote:
On Wed, 2010-05-12 at 08:52 -0400, Robert Haas wrote:
On Wed, May 12, 2010 at 7:26 AM, Simon Riggs wrote:
On Wed, 2010-05-12 at 07:10 -0400, Robert Haas wrote:
I'm not sure what to make of this.
Excerpts from Tom Lane's message of mié may 12 14:07:13 -0400 2010:
> We could try to make this a supported build arrangement, but I'm
> inclined to think that a cleaner solution is to split out the loadable
> module as a separate contrib subdirectory. Thoughts?
Do you mean contrib/pg_upgrade/so
Alvaro Herrera writes:
> Excerpts from Tom Lane's message of mié may 12 14:07:13 -0400 2010:
>> We could try to make this a supported build arrangement, but I'm
>> inclined to think that a cleaner solution is to split out the loadable
>> module as a separate contrib subdirectory. Thoughts?
> Do
On May 12, 2010, at 1:43 PM, Magnus Hagander wrote:
> On Wed, May 12, 2010 at 8:27 PM, Florian Pflug wrote:
>> Hi
>>
>> I just tried to checkout REL9_0_BETA1 from my local clone of the GIT
>> repository at git.postgresql.org and discovered that none of the tags from
>> CVS seem to exist in th
postmaster.c contains the following comment just above the definition
of PMState. It appears to be out of date:
* After reaching a consistent point in WAL redo, startup process signals
* us again, and we switch to PM_RECOVERY_CONSISTENT state. There's currently
* no difference between PM_RECOV
Tom Lane wrote:
Alvaro Herrera writes:
Excerpts from Tom Lane's message of mié may 12 14:07:13 -0400 2010:
We could try to make this a supported build arrangement, but I'm
inclined to think that a cleaner solution is to split out the loadable
module as a separate contrib subdirector
On Wed, May 12, 2010 at 3:01 PM, Heikki Linnakangas
wrote:
> Tom Lane wrote:
>> If so, master/standby would probably work.
>
> +1 for master/standby.
>
> It's worth remembering that a "standby server" might not be actively
> connected to a master server. A server that's reading WAL from an
> archi
On Wed, 2010-05-12 at 21:10 +0200, Stefan Kaltenbrunner wrote:
> > There is no evidence to link this behaviour with HS, as yet, and you
> > should be considering the possibility the problem lies elsewhere,
> > especially since it could be code you committed that is at fault.
>
> Well I'm not sure
Andrew Dunstan writes:
> Tom Lane wrote:
>> Alvaro Herrera writes:
>>> Do you mean contrib/pg_upgrade/somelib? If so, +1.
>>
>> Hmm. I had been thinking the other way, but I'll see if that can be
>> made to work.
> Not sure this will work on its own with the MSVC build system - I don't
> thi
Excerpts from Stefan Kaltenbrunner's message of mié may 12 15:10:28 -0400 2010:
> the startup process has the following backtrace:
>
> (gdb) bt
> #0 0x7fbe24cb2c83 in select () from /lib/libc.so.6
> #1 0x006e811a in pg_usleep ()
> #2 0x0048c333 in XLogPageRead ()
> #3 0x00
Subject line kind of says it all: LANGUAGE replacement was
introduced in 9.0, but pg_dump is trying it on all versions.
--
Greg Sabino Mullane g...@turnstep.com
End Point Corporation
PGP Key: 0x14964AC8 201005121537
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
diff --gi
On Wed, 2010-05-12 at 15:36 -0400, Alvaro Herrera wrote:
> I just noticed that we have some code assigning the return value of
> time() to a pg_time_t variable. Is this supposed to work reliably?
> (xlog.c lines 9267ff)
Code's used that for a while now. Checkpoints and everywhere.
--
Simon Rig
On Tue, May 11, 2010 at 1:32 PM, Marc G. Fournier wrote:
> On Tue, 11 May 2010, Alvaro Herrera wrote:
>
>> Excerpts from Marc G. Fournier's message of mar may 11 09:58:34 -0400
>> 2010:
>>
>>> If list traffic, especially on -hackers, is getting so large, should we
>>> look at maybe splitting it?
On Wed, May 12, 2010 at 3:36 PM, Alvaro Herrera wrote:
> Excerpts from Stefan Kaltenbrunner's message of mié may 12 15:10:28 -0400
> 2010:
>
>> the startup process has the following backtrace:
>>
>> (gdb) bt
>> #0 0x7fbe24cb2c83 in select () from /lib/libc.so.6
>> #1 0x006e811a in p
David Christensen wrote:
Is there anything to do about the missing tags in git? I've wished for those
to be available as well.
Sure, fix fromcvs to emit them. How is your ruby?
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to y
Tom Lane wrote:
> Bruce Momjian writes:
> > Tom Lane wrote:
> >> momj...@postgresql.org (Bruce Momjian) writes:
> >>> Add PGAPPICON to all executable makefiles.
> >>
> >> Is it really a good idea to have done that to the server, in particular?
> >> I can't imagine it being a good idea to launch t
On Wed, May 12, 2010 at 3:51 PM, Robert Haas wrote:
> On Wed, May 12, 2010 at 3:36 PM, Alvaro Herrera
> wrote:
>> Excerpts from Stefan Kaltenbrunner's message of mié may 12 15:10:28 -0400
>> 2010:
>>
>>> the startup process has the following backtrace:
>>>
>>> (gdb) bt
>>> #0 0x7fbe24cb2c8
Bruce Momjian writes:
> All other binaries had such a designation, and all /contrib binaries
> were missing them. I assume I was doing cleanup. You want the icon
> removed from the backend makefile?
Yes. I'm prepared to believe that not having the icons set on the
contrib executables was an ov
On May 12, 2010, at 21:52 , Andrew Dunstan wrote:
> David Christensen wrote:
>>
>> Is there anything to do about the missing tags in git? I've wished for
>> those to be available as well.
>>
>
> Sure, fix fromcvs to emit them. How is your ruby?
Where does one find the version of fromcvs use
Andrew Dunstan writes:
> David Christensen wrote:
>> Is there anything to do about the missing tags in git? I've wished for
>> those to be available as well.
> Sure, fix fromcvs to emit them. How is your ruby?
Per Magnus' comment, there isn't anything "missing". We don't make
branches for be
Greg Sabino Mullane writes:
> Subject line kind of says it all: LANGUAGE replacement was
> introduced in 9.0, but pg_dump is trying it on all versions.
So? pg_dump output is never promised to load into older server
versions.
The proposed patch is quite wrong anyway, because it is looking at
th
Florian Pflug wrote:
On May 12, 2010, at 21:52 , Andrew Dunstan wrote:
David Christensen wrote:
Is there anything to do about the missing tags in git? I've wished for those
to be available as well.
Sure, fix fromcvs to emit them. How is your ruby?
Where does one fi
On May 12, 2010, at 22:03 , Tom Lane wrote:
> Andrew Dunstan writes:
>> David Christensen wrote:
>>> Is there anything to do about the missing tags in git? I've wished for
>>> those to be available as well.
>
>> Sure, fix fromcvs to emit them. How is your ruby?
>
> Per Magnus' comment, there
Florian Pflug writes:
> Yeah, but CVS has tags for the alphas and betas. Those are missing from the
> GIT mirror as the CVS-to-GIT converter apparently ignores tags completely
> :-(. Since there are no branches for the betas, this leaves the GIT
> repository without any trace that beta1 exists
Tom Lane wrote:
Andrew Dunstan writes:
David Christensen wrote:
Is there anything to do about the missing tags in git? I've wished for those
to be available as well.
Sure, fix fromcvs to emit them. How is your ruby?
Per Magnus' comment, there isn't anything "mi
Tom Lane wrote:
Florian Pflug writes:
Yeah, but CVS has tags for the alphas and betas. Those are missing from the GIT
mirror as the CVS-to-GIT converter apparently ignores tags completely :-(.
Since there are no branches for the betas, this leaves the GIT repository
without any trace th
Koichi Suzuki wrote:
> It is an announcement that long-waited bug-fix of pg_lesslog is now
> released. This includes the following.
>
> 1. Error in calculation of GiST-related WAL record length was fixed.
> 2. pg_compresslog now has an option to print WAL segment analysis.
> 3. New test script i
On 12.05.2010, at 22:22, Tom Lane wrote:
Florian Pflug writes:
Yeah, but CVS has tags for the alphas and betas. Those are missing
from the GIT mirror as the CVS-to-GIT converter apparently ignores
tags completely :-(. Since there are no branches for the betas,
this leaves the GIT reposit
Bruce Momjian writes:
> Yes, I would love to get this into /contrib for PG 9.1!
How much are people really going to care about pg_lesslog now that
we've got streaming replication? There might be some small use-case
still left, but it's hard to believe that it would be worth carrying
it in contri
On Wed, May 12, 2010 at 11:03 PM, Tom Lane wrote:
> Bruce Momjian writes:
>> Yes, I would love to get this into /contrib for PG 9.1!
>
> How much are people really going to care about pg_lesslog now that
> we've got streaming replication? There might be some small use-case
> still left, but it's
On Wed, 2010-05-12 at 23:09 +0200, Magnus Hagander wrote:
> On Wed, May 12, 2010 at 11:03 PM, Tom Lane wrote:
> > Bruce Momjian writes:
> >> Yes, I would love to get this into /contrib for PG 9.1!
> >
> > How much are people really going to care about pg_lesslog now that
> > we've got streaming r
> Until we have a tool to use streaming replication to actually archive
> backups, there's still a fairly large usecase for it...
yes, pglesslog is for PITR. We have a client who keeps 3 days of log
files a time for forensic reasons, and I doubt they're the only one.
--
On Wed, 2010-05-12 at 14:43 -0400, Robert Haas wrote:
> I thought that it
> would be a good idea for Simon to look at it because, on the surface,
> it APPEARS to have something to do with Hot Standby, since that's what
> Stefan was testing when he found it.
He was also testing SR, yet you haven't
Simon, Robert,
> He was also testing SR, yet you haven't breathed a word about that for
> some strange reason. It didn't APPEAR like it was HS at all, not from
> basic logic or from technical knowledge. So you'll have to forgive me if
> I don't leap into action when you say something is an HS prob
On Wed, 2010-05-12 at 22:34 +0100, Simon Riggs wrote:
> On Wed, 2010-05-12 at 14:43 -0400, Robert Haas wrote:
>
> > I thought that it
> > would be a good idea for Simon to look at it because, on the surface,
> > it APPEARS to have something to do with Hot Standby, since that's what
> > Stefan was
Tom Lane wrote:
> Bruce Momjian writes:
> > All other binaries had such a designation, and all /contrib binaries
> > were missing them. I assume I was doing cleanup. You want the icon
> > removed from the backend makefile?
>
> Yes. I'm prepared to believe that not having the icons set on the
>
Tom Lane wrote:
> Peter Eisentraut writes:
> > The server's messages and the documentation uses all of these terms in
> > mixed ways. Maybe we could decide on some preferred terminology and
> > adjust the existing texts. Ideas?
>
> Primary/secondary seem like a poor choice because they're such
Tom Lane wrote:
> A look at the MSVC buildfarm members shows that they are not building
> most of the files added to contrib/pg_upgrade. The reason seems to be
> that that module tries to build both an executable program *and* a
> shared library, which it does by dint of setting both PROGRAM and
>
Tom Lane wrote:
> Andrew Dunstan writes:
> > Tom Lane wrote:
> >> Alvaro Herrera writes:
> >>> Do you mean contrib/pg_upgrade/somelib? If so, +1.
> >>
> >> Hmm. I had been thinking the other way, but I'll see if that can be
> >> made to work.
>
> > Not sure this will work on its own with the
Bruce Momjian writes:
> Uh, if you do 'make install' in the pg_upgrade directory, would it also
> install the shared lib contrib? If not, it seems kind of complicated
> from a user perspective. Can't we pass a 'make' down into a
> subdirectory and have a separate Makefile just run?
No. You're
Bruce Momjian wrote:
Can't we pass a 'make' down into a
subdirectory and have a separate Makefile just run? pg_migrator had
this rule:
all install installdirs uninstall distprep clean distclean
maintainer-clean:
$(MAKE) -C src $@
$(MAKE) -C func $@
Tom Lane wrote:
> Bruce Momjian writes:
> > Uh, if you do 'make install' in the pg_upgrade directory, would it also
> > install the shared lib contrib? If not, it seems kind of complicated
> > from a user perspective. Can't we pass a 'make' down into a
> > subdirectory and have a separate Makefi
Bruce Momjian writes:
> If we make it /contrib/pg_upgrade_shlibs, will it need a documentation
> page?
I don't see a need for that. Also, why would you make the directory
name different from the name of the shlib it's building --- or are
you having second thoughts about the present name?
> Can
On Wed, May 12, 2010 at 5:34 PM, Simon Riggs wrote:
> On Wed, 2010-05-12 at 14:43 -0400, Robert Haas wrote:
>
>> I thought that it
>> would be a good idea for Simon to look at it because, on the surface,
>> it APPEARS to have something to do with Hot Standby, since that's what
>> Stefan was testin
Tom Lane wrote:
> Bruce Momjian writes:
> > If we make it /contrib/pg_upgrade_shlibs, will it need a documentation
> > page?
>
> I don't see a need for that. Also, why would you make the directory
> name different from the name of the shlib it's building --- or are
> you having second thoughts a
Bruce Momjian writes:
> Now that it only targets the packaged version, I can do with a single
> shared object, but maybe it needs to be more generic, like
> pg_upgrade_tools.so or something like that.
+1 for pg_upgrade_tools or pg_upgrade_support or some such name.
> I realize we need a separate
Tom Lane wrote:
> Bruce Momjian writes:
> > Now that it only targets the packaged version, I can do with a single
> > shared object, but maybe it needs to be more generic, like
> > pg_upgrade_tools.so or something like that.
>
> +1 for pg_upgrade_tools or pg_upgrade_support or some such name.
I
On May 12, 2010, at 4:07 PM, Bruce Momjian wrote:
> I like 'pg_upgrade_support'. I could also do 'pg_upgrade_funcs'.
I misread the second one at a glance, so I recommend the first.
Best,
David
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subs
bruce wrote:
> Tom Lane wrote:
> > Bruce Momjian writes:
> > > All other binaries had such a designation, and all /contrib binaries
> > > were missing them. I assume I was doing cleanup. You want the icon
> > > removed from the backend makefile?
> >
> > Yes. I'm prepared to believe that not ha
Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian writes:
> > > If we make it /contrib/pg_upgrade_shlibs, will it need a documentation
> > > page?
> >
> > I don't see a need for that. Also, why would you make the directory
> > name different from the name of the shlib it's building --- or
On Wed, 12 May 2010, Greg Stark wrote:
I'm thinking I'll move -general (and the useless -novice) to another
folder. But I'm left wondering what to do with -admin and -performance.
They're a random mix of user content and developer content. I'll
probably move them along with -general but that m
Hi,
If a backend killed by pg_terminate_backend(), the backend returns
57P01 which is identical to the one when it's killed by postmaster.
Problem is, pgpool-II needs to trigger failover if postmaster goes
down because apparently pgpool-II cannot use the PostgreSQL server
anymore.
On the otherha
On Wed, May 12, 2010 at 3:55 PM, Robert Haas wrote:
> I am wondering if we are not correctly handling the case where we get
> a shutdown request while we are still in the PM_STARTUP state. It
> looks like we might go ahead and switch to PM_RECOVERY and then
> PM_RECOVERY_CONSISTENT without notici
On Wed, May 12, 2010 at 5:44 PM, Bruce Momjian wrote:
> Tom Lane wrote:
>> Peter Eisentraut writes:
>> > The server's messages and the documentation uses all of these terms in
>> > mixed ways. Maybe we could decide on some preferred terminology and
>> > adjust the existing texts. Ideas?
>>
>> P
When firing up a properly shut down HS slave, I get:
LOG: database system was interrupted while in recovery at log time
2010-05-12 20:35:24 EDT
HINT: If this has occurred more than once some data might be
corrupted and you might need to choose an earlier recovery target.
But this is kind of an
1 - 100 of 118 matches
Mail list logo
