Re: [HACKERS] SKIP LOCKED DATA

2012-01-16 Thread Ilya Kosmodemiansky
That is quite useful feature to implement smth. like message queues based on database and so on. Now there is possibility to jump over luck of such feature in Postgres using current advisory lock implementation (pg_try_advisory_xact_lock to determine if somebody already acquired log on particular

Re: [HACKERS] Group commit, revised

2012-01-16 Thread Heikki Linnakangas
On 16.01.2012 00:42, Peter Geoghegan wrote: I've also attached the results of a pgbench-tools driven benchmark, which are quite striking (Just the most relevant image - e-mail me privately if you'd like a copy of the full report, as I don't want to send a large PDF file to the list as a courtesy

Re: [HACKERS] Standalone synchronous master

2012-01-16 Thread Fujii Masao
On Mon, Jan 16, 2012 at 7:01 AM, Jeff Janes jeff.ja...@gmail.com wrote: On Fri, Jan 13, 2012 at 10:12 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Jeff Janes jeff.ja...@gmail.com wrote:\ I don't understand why this is controversial. I'm having a hard time seeing why this is

Re: [HACKERS] logging in high performance systems.

2012-01-16 Thread Greg Smith
On 11/23/2011 09:28 PM, Theo Schlossnagle wrote: The first thing I did was add hook points where immediate statement logging happens pre_exec and those that present duration post_exec. These should, with optimization turned on, have only a few instructions of impact when no hooks are registered

Re: [HACKERS] SKIP LOCKED DATA

2012-01-16 Thread Simon Riggs
On Mon, Jan 16, 2012 at 5:33 AM, Tom Lane t...@sss.pgh.pa.us wrote: Thomas Munro mu...@ip9.org writes: I am wondering out loud whether I am brave enough to try to propose SKIP LOCKED DATA support and would be grateful for any feedback and/or {en|dis}couragement.  I don't see it on the todo

[HACKERS] CommitFest 2012-01 kick-off

2012-01-16 Thread Greg Smith
Despite the best attempts of all my neighbors to distract me, as if there was something more important going on Sunday afternoon in Baltimore than preparing for the CommitFest, I've tried to get all the loose patches onto the CommitFest app and get the early reviews accounted for on there too.

Re: [HACKERS] Measuring relation free space

2012-01-16 Thread Noah Misch
On Sat, Jan 14, 2012 at 02:40:46PM -0500, Jaime Casanova wrote: On Sat, Jan 14, 2012 at 6:26 AM, Noah Misch n...@leadboat.com wrote: - pgstattuple() and relation_free_space() should emit the same number, even if ?that means improving pgstattuple() at the same time. yes, i just wanted

Re: [HACKERS] New replication mode: write

2012-01-16 Thread Fujii Masao
On Fri, Jan 13, 2012 at 9:27 PM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Jan 13, 2012 at 7:30 PM, Simon Riggs si...@2ndquadrant.com wrote: On Fri, Jan 13, 2012 at 9:15 AM, Simon Riggs si...@2ndquadrant.com wrote: On Fri, Jan 13, 2012 at 7:41 AM, Fujii Masao masao.fu...@gmail.com wrote:

Re: [HACKERS] Generate call graphs in run-time

2012-01-16 Thread Martin Pihlak
On 01/09/2012 10:00 PM, Joel Jacobson wrote: Because of this I decided to sample data in run-time to get a real-life picture of the system. Any functions not being called in productions are not that important to include in the documentation anyway. FWIW I have a similar problem - with a

Re: [HACKERS] age(xid) on hot standby

2012-01-16 Thread Alvaro Herrera
Excerpts from Peter Eisentraut's message of dom ene 15 10:00:03 -0300 2012: On ons, 2011-12-28 at 14:35 -0500, Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Peter Eisentraut's message of mié dic 28 15:04:09 -0300 2011: On a hot standby, this fails

Re: [HACKERS] Concurrent CREATE TABLE/DROP SCHEMA leaves inconsistent leftovers

2012-01-16 Thread Robert Haas
On Sun, Jan 15, 2012 at 11:03 AM, Hitoshi Harada umi.tan...@gmail.com wrote: On Sat, Jan 14, 2012 at 6:48 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jan 14, 2012 at 5:25 AM, Hitoshi Harada umi.tan...@gmail.com wrote: The patch looks ok, though I wonder if we could have a way to

[HACKERS] inconsistent comparison of CHECK constraints

2012-01-16 Thread Alvaro Herrera
While reviewing Nikhil Sontakke's fix for the inherited constraints open item we have, I noticed that MergeWithExistingConstraint and MergeConstraintsIntoExisting are using rather different mechanism to compare equality of the constraint expressions; the former does this: { Datum

Re: [HACKERS] age(xid) on hot standby

2012-01-16 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Peter Eisentraut's message of dom ene 15 10:00:03 -0300 2012: On ons, 2011-12-28 at 14:35 -0500, Tom Lane wrote: The trouble with using ReadNewTransactionId is that it makes the results volatile, not stable as the function is

Re: [HACKERS] reprise: pretty print viewdefs

2012-01-16 Thread Andrew Dunstan
On 01/13/2012 02:50 PM, Andrew Dunstan wrote: On 01/13/2012 12:31 AM, Hitoshi Harada wrote: So my conclusion is it's better than nothing, but we could do better job here. From timeline perspective, it'd be ok to apply this patch and improve more later in 9.3+. I agree, let's look

Re: [HACKERS] inconsistent comparison of CHECK constraints

2012-01-16 Thread Tom Lane
Alvaro Herrera alvhe...@alvh.no-ip.org writes: While reviewing Nikhil Sontakke's fix for the inherited constraints open item we have, I noticed that MergeWithExistingConstraint and MergeConstraintsIntoExisting are using rather different mechanism to compare equality of the constraint

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2012-01-16 Thread Alvaro Herrera
Excerpts from Jaime Casanova's message of lun ene 16 03:23:30 -0300 2012: On Tue, Dec 13, 2011 at 12:29 PM, Julien Tachoires jul...@gmail.com wrote: OK, considering that, I don't see any way to handle the case raised by Jaime :( Did you consider what Álvaro suggested? anyway, seems is

Re: [HACKERS] Standalone synchronous master

2012-01-16 Thread Robert Haas
On Sun, Jan 15, 2012 at 5:01 PM, Jeff Janes jeff.ja...@gmail.com wrote: Since synchronous_standby_names cannot be changed without bouncing the server, we do not provide the tools for an external tool to make this change cleanly. Yes, it can. It's PGC_SIGHUP. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Checkpoint sync pause

2012-01-16 Thread Robert Haas
On Mon, Jan 16, 2012 at 2:57 AM, Greg Smith g...@2ndquadrant.com wrote: ... 2012-01-16 02:39:01.184 EST [25052]: DEBUG:  checkpoint sync: number=34 file=base/16385/11766 time=0.006 msec 2012-01-16 02:39:01.184 EST [25052]: DEBUG:  checkpoint sync delay: seconds left=3 2012-01-16 02:39:01.284

Re: [HACKERS] pgstat documentation tables

2012-01-16 Thread Alvaro Herrera
Bruce had a patch to turn SGML descriptions of system view into comments via some Perl program or something. He posted it many moons ago and I haven't seen an updated version. Bruce, do you have something to say on this topic? -- Álvaro Herrera alvhe...@commandprompt.com The PostgreSQL

Re: [HACKERS] Should I implement DROP INDEX CONCURRENTLY?

2012-01-16 Thread Robert Haas
On Sat, Dec 31, 2011 at 8:26 AM, Simon Riggs si...@2ndquadrant.com wrote: On Fri, Dec 30, 2011 at 10:20 PM, Peter Eisentraut pete...@gmx.net wrote: On ons, 2011-08-24 at 11:24 -0700, Daniel Farina wrote: I was poking around at tablecmds and index.c and wonder if a similar two-pass approach as

Re: [HACKERS] New replication mode: write

2012-01-16 Thread Simon Riggs
On Mon, Jan 16, 2012 at 12:45 PM, Fujii Masao masao.fu...@gmail.com wrote: Done. Attached is the updated version of the patch. Thanks. I'll review this first, but can't start immediately. Please expect something back in 2 days. --  Simon Riggs   http://www.2ndQuadrant.com/  

Re: [HACKERS] patch : Allow toast tables to be moved to a different tablespace

2012-01-16 Thread Julien Tachoires
Hi, 2012/1/16 Alvaro Herrera alvhe...@commandprompt.com: Excerpts from Jaime Casanova's message of lun ene 16 03:23:30 -0300 2012: On Tue, Dec 13, 2011 at 12:29 PM, Julien Tachoires jul...@gmail.com wrote: OK, considering that, I don't see any way to handle the case raised by Jaime :(

[HACKERS] Caching for stable expressions with constant arguments v6

2012-01-16 Thread Marti Raudsepp
Hi list, Here's v6 of my expression caching patch. The only change in v6 is added expression cost estimation in costsize.c. I'm setting per-tuple cost of CacheExpr to 0 and moving sub-expression tuple costs into the startup cost. As always, this work is also available from my Github cache

Re: [HACKERS] Caching for stable expressions with constant arguments v6

2012-01-16 Thread Jaime Casanova
On Mon, Jan 16, 2012 at 12:06 PM, Marti Raudsepp ma...@juffo.org wrote: I will add it to the 2012-01 commitfest now, I hope that's OK. If not, feel free to remove it and I'll put it in 2012-Next. i'm not the CF manager so he can disagree with me... but IMHO your patch has been almost complete

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Robert Haas
On Sun, Jan 15, 2012 at 3:45 AM, Magnus Hagander mag...@hagander.net wrote: On Sun, Jan 15, 2012 at 09:37, Greg Smith g...@2ndquadrant.com wrote: On 01/15/2012 03:17 AM, Magnus Hagander wrote: And FWIW, I'd find it a lot more useful for the CF app to have the ability to post *reviews* in it,

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Magnus Hagander
On Mon, Jan 16, 2012 at 18:57, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 15, 2012 at 3:45 AM, Magnus Hagander mag...@hagander.net wrote: On Sun, Jan 15, 2012 at 09:37, Greg Smith g...@2ndquadrant.com wrote: On 01/15/2012 03:17 AM, Magnus Hagander wrote: And FWIW, I'd find it a lot

Re: [HACKERS] pgstat documentation tables

2012-01-16 Thread Peter Eisentraut
On sön, 2012-01-15 at 12:20 -0500, Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: Right now we have a single table on http://www.postgresql.org/docs/devel/static/monitoring-stats.html#MONITORING-STATS-VIEWS that lists all our statistics views ... I'd like to turn that into

Re: [HACKERS] PL/Python result metadata

2012-01-16 Thread Peter Eisentraut
On ons, 2012-01-11 at 17:16 -0300, Alvaro Herrera wrote: I propose to add two functions to the result object: .colnames() returns a list of column names (strings) .coltypes() returns a list of type OIDs (integers) No typmods? Didn't think about that, but could be added using similar

Re: [HACKERS] PL/Python result metadata

2012-01-16 Thread Peter Eisentraut
On ons, 2012-01-11 at 22:52 +0100, Dimitri Fontaine wrote: Peter Eisentraut pete...@gmx.net writes: .colnames() returns a list of column names (strings) .coltypes() returns a list of type OIDs (integers) I just made that up because there is no guidance in the other standard PLs for this

Re: [HACKERS] pgstat documentation tables

2012-01-16 Thread Magnus Hagander
On Mon, Jan 16, 2012 at 19:41, Peter Eisentraut pete...@gmx.net wrote: On sön, 2012-01-15 at 12:20 -0500, Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: Right now we have a single table on http://www.postgresql.org/docs/devel/static/monitoring-stats.html#MONITORING-STATS-VIEWS

Re: [HACKERS] pg_basebackup option for handling symlinks

2012-01-16 Thread Peter Eisentraut
On sön, 2012-01-08 at 22:22 +0100, Magnus Hagander wrote: On Sun, Jan 8, 2012 at 21:53, Peter Eisentraut pete...@gmx.net wrote: I've recently had a possible need for telling pg_basebackup how to handle symlinks in the remote data directory, instead of ignoring them, which is what currently

Re: [HACKERS] Should I implement DROP INDEX CONCURRENTLY?

2012-01-16 Thread Peter Eisentraut
On mån, 2012-01-16 at 11:17 -0500, Robert Haas wrote: I don't see how setting indisvalid to false helps with this, because IIUC when a session sees indisvalid = false, it is supposed to avoid using the index for queries but still make new index entries when a write operation happens - but to

Re: [HACKERS] foreign key locks, 2nd attempt

2012-01-16 Thread Heikki Linnakangas
On 15.01.2012 06:49, Alvaro Herrera wrote: --- 164,178 #define HEAP_HASVARWIDTH 0x0002 /* has variable-width attribute(s) */ #define HEAP_HASEXTERNAL 0x0004 /* has external stored attribute(s) */ #define HEAP_HASOID 0x0008 /*

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-16 Thread Robert Haas
On Sat, Jan 14, 2012 at 8:58 PM, Greg Smith g...@2ndquadrant.com wrote: I would have sworn I left this next to the bike shed...from the crickets chirping I guess not.  I did complete bumping forward the patches that slipped through the November CF the other day, and it's properly closed now.

Re: [HACKERS] Should I implement DROP INDEX CONCURRENTLY?

2012-01-16 Thread Robert Haas
On Mon, Jan 16, 2012 at 2:06 PM, Peter Eisentraut pete...@gmx.net wrote: On mån, 2012-01-16 at 11:17 -0500, Robert Haas wrote: I don't see how setting indisvalid to false helps with this, because IIUC when a session sees indisvalid = false, it is supposed to avoid using the index for queries

Re: [HACKERS] foreign key locks, 2nd attempt

2012-01-16 Thread Alvaro Herrera
Excerpts from Heikki Linnakangas's message of lun ene 16 16:17:42 -0300 2012: On 15.01.2012 06:49, Alvaro Herrera wrote: --- 164,178 #define HEAP_HASVARWIDTH0x0002/* has variable-width attribute(s) */ #define HEAP_HASEXTERNAL0x0004/* has external

Re: [HACKERS] PL/Python result metadata

2012-01-16 Thread Dimitri Fontaine
Peter Eisentraut pete...@gmx.net writes: I deliberately chose not to do that, because the PL/Python API is intentionally totally different from the standard DB-API, and mixing in some semi-conforming look-alike would be quite confusing from both ends. Fair enough. I think we should stick

[HACKERS] pg_stat_database deadlock counter

2012-01-16 Thread Magnus Hagander
Attached patch adds a counter for number of deadlocks in a database to pg_stat_database. While not enough to diagnose a problem on it's own, this is an easy way to get an indicator when for when you need to go look in the logs for details. Overhead should be very small - one counter per database

Re: [HACKERS] SKIP LOCKED DATA

2012-01-16 Thread Dimitri Fontaine
Thomas Munro mu...@ip9.org writes: A common usage for this is to increase parallelism in systems with multiple workers taking jobs from a queue. I've used it for this purpose myself on another RDBMS, having seen it recommended for some types of work queue implementation. It may have other

[HACKERS] Warning in views.c

2012-01-16 Thread Magnus Hagander
Seem 1575fbcb caused this warning: view.c: In function ‘DefineVirtualRelation’: view.c:105:6: warning: variable ‘namespaceId’ set but not used [-Wunused-but-set-variable] Attached seems to be the easy fix - or am I missing something obvious? --  Magnus Hagander  Me: http://www.hagander.net/  

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Josh Berkus
On 1/14/12 8:44 PM, Greg Smith wrote: Second, e-mail provides some level of validation that patches being submitted are coming from the person they claim. We currently reject patches that are only shared with the community on the web, via places like github. The process around this mailing

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Alvaro Herrera
Excerpts from Josh Berkus's message of lun ene 16 17:48:41 -0300 2012: Putting submitters aside, I have to say based on teaching people how to use the CF stuff on Thursday night that the process of submitting a review of a patch is VERY unintuitive, or in the words of one reviewer

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Josh Berkus
I mean, is email arcane? Surely not. Are summary lines arcane? Give me a break. So the only real complain point here is message-id, which normally people don't care about and don't even know they exist. So they have to learn about it. The complaint is that the reviewer is expected to

Re: [HACKERS] SKIP LOCKED DATA

2012-01-16 Thread Josh Berkus
On 1/15/12 3:01 PM, Thomas Munro wrote: 5. Probably many other things that I'm not aware of right now and won't discover until I dig/ask further and/or run into a brick wall! Useful? Doable? Useful, yes. Harder than it looks, probably. I tried to mock up a version of this years ago for a

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Jeff Janes
On Mon, Jan 16, 2012 at 1:10 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Josh Berkus's message of lun ene 16 17:48:41 -0300 2012: Putting submitters aside, I have to say based on teaching people how to use the CF stuff on Thursday night that the process of submitting a

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-16 Thread Josh Berkus
On 1/16/12 11:42 AM, Robert Haas wrote: But, I've noticed that nothing good comes of me pressing my own view too hard. Either we as a community value having the CommitFest wrap up in a reasonable period of time, or we don't. Reality is, alas, not nearly so binary as this, and therin lie the

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Alvaro Herrera
Excerpts from Jeff Janes's message of lun ene 16 18:37:59 -0300 2012: I mean, if getting a message-id from Gmail is all that complicated, please complain to Google. But after digging the message-id out of gmail and entering it into the commitfest app, the resulting link is broken

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Greg Smith
On 01/16/2012 03:48 PM, Josh Berkus wrote: 3. Dig the messageID out of your sent mail. 4. Add a comment to the patch, type Review with the messageID, and ideally a short summary comment of the review. This is the time consuming part that would benefit the most from some automation. The

Re: [HACKERS] Review: Non-inheritable check constraints

2012-01-16 Thread Alvaro Herrera
Excerpts from Nikhil Sontakke's message of vie dic 23 01:02:10 -0300 2011: FWIW, here's a quick fix for the issue that Robert pointed out. Thanks, applied. Again it's a variation of the first issue that he reported. We have two functions which try to merge existing constraints:

Re: [HACKERS] Review: Non-inheritable check constraints

2012-01-16 Thread Alvaro Herrera
Excerpts from Nikhil Sontakke's message of vie dic 23 01:02:10 -0300 2011: I have also tried to change the error message as per Alvaro's suggestions. I will really try to see if we have other issues. Really cannot have Robert reporting all the bugs and getting annoyed, but there are lotsa

Re: [HACKERS] inconsistent comparison of CHECK constraints

2012-01-16 Thread Alvaro Herrera
Excerpts from Tom Lane's message of lun ene 16 12:44:57 -0300 2012: Alvaro Herrera alvhe...@alvh.no-ip.org writes: While reviewing Nikhil Sontakke's fix for the inherited constraints open item we have, I noticed that MergeWithExistingConstraint and MergeConstraintsIntoExisting are using

Re: [HACKERS] IDLE in transaction introspection

2012-01-16 Thread Scott Mead
On Sun, Jan 15, 2012 at 4:28 AM, Greg Smith g...@2ndquadrant.com wrote: On 01/12/2012 11:57 AM, Scott Mead wrote: Pretty delayed, but please find the attached patch that addresses all the issues discussed. The docs on this v4 look like they suffered a patch order problem here. In the v3,

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Alvaro Herrera
Excerpts from Daniel Farina's message of dom ene 15 08:41:55 -0300 2012: Onto the mechanism: the patch is both a contrib and changes to Postgres. The changes to postgres are mechanical in nature, but voluminous. The key change is to not only remember the position of Const nodes in the

Re: [HACKERS] automating CF submissions (was xlog location arithmetic)

2012-01-16 Thread Andrew Dunstan
On 01/16/2012 05:25 PM, Greg Smith wrote: The most reasonable answer to this is for people to publish a git repo URL in addition to the official submission of changes to the list in patch form. And momentum toward doing that just keeps going up, even among longer term contributors who

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Greg Smith
On 01/16/2012 06:19 PM, Alvaro Herrera wrote: I wonder if it would make sense to split out those changes from the patch, including a one-member struct definition to the lexer source, which could presumably be applied in advance of the rest of the patch. That way, if other parts of the main patch

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Daniel Farina's message of dom ene 15 08:41:55 -0300 2012: Onto the mechanism: the patch is both a contrib and changes to Postgres. The changes to postgres are mechanical in nature, but voluminous. The key change is to not only

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Peter Geoghegan
On 16 January 2012 23:43, Greg Smith g...@2ndquadrant.com wrote: While Peter had a version of this that worked completely within the boundaries of an extension, no one was really happy with that.  At a minimum the .length changes really need to land in 9.2 to enable this feature to work well.  

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-16 Thread Greg Smith
On 01/16/2012 02:42 PM, Robert Haas wrote: But, I've noticed that nothing good comes of me pressing my own view too hard. Either we as a community value having the CommitFest wrap up in a reasonable period of time, or we don't. If we do, then let's make it happen together. If we don't, then

[HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Daniel Farina
I have been working with xlogdump and noticed that unfortunately it cannot be installed without access to a postgres build directory, which makes the exported functionality in src/include/utils/pg_crc.h useless unless one has access to pg_crc.o -- which would only happen if a build directory is

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Peter Geoghegan
On 16 January 2012 23:53, Tom Lane t...@sss.pgh.pa.us wrote: Well, short of seeing an acceptable patch for the larger thing, I don't want to accept a patch to add that field to Const, because I think it's a kluge.  I'm still feeling that there must be a better way ... What does an acceptable

Re: [HACKERS] Review of: pg_stat_statements with query tree normalization

2012-01-16 Thread Daniel Farina
On Mon, Jan 16, 2012 at 3:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, short of seeing an acceptable patch for the larger thing, I don't want to accept a patch to add that field to Const, because I think it's a kluge.  I'm still feeling that there must be a better way ... Hm. Maybe it is

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Daniel Farina
On Mon, Jan 16, 2012 at 4:56 PM, Daniel Farina dan...@heroku.com wrote: I have been working with xlogdump and noticed that unfortunately it cannot be installed without access to a postgres build directory, which makes the exported functionality in src/include/utils/pg_crc.h useless unless one

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-16 Thread Robert Haas
On Mon, Jan 16, 2012 at 7:01 PM, Greg Smith g...@2ndquadrant.com wrote: I think this is getting more predictable simply based on having some history.  The trail blazing you led here for some time didn't know what was and wasn't possible yet.  I feel that the basic shape of things, while still

Re: [HACKERS] Checkpoint sync pause

2012-01-16 Thread Greg Smith
On 01/16/2012 11:00 AM, Robert Haas wrote: Also, I am still struggling with what the right benchmarking methodology even is to judge whether any patch in this area works. Can you provide more details about your test setup? The test setup is a production server with a few hundred users at

Re: [HACKERS] age(xid) on hot standby

2012-01-16 Thread Alvaro Herrera
Excerpts from Tom Lane's message of lun ene 16 12:27:03 -0300 2012: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Peter Eisentraut's message of dom ene 15 10:00:03 -0300 2012: On ons, 2011-12-28 at 14:35 -0500, Tom Lane wrote: The trouble with using ReadNewTransactionId

Re: [HACKERS] Checkpoint sync pause

2012-01-16 Thread Josh Berkus
On 1/16/12 5:59 PM, Greg Smith wrote: What I think is needed instead is a write-heavy benchmark with a think time in it, so that we can dial the workload up to, say, 90% of I/O capacity, but that spikes to 100% when checkpoint sync happens. Then rearrangements in syncing that reduces

Re: [HACKERS] [v9.2] sepgsql's DROP Permission checks

2012-01-16 Thread Robert Haas
On Tue, Jan 10, 2012 at 7:51 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The attached patch adds OAT_DROP object-access-hook around permission checks of object deletion. Due to the previous drop statement reworks, the number of places to put this hook is limited to these six points:

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Robert Haas
On Mon, Jan 16, 2012 at 8:09 PM, Daniel Farina dan...@heroku.com wrote: On Mon, Jan 16, 2012 at 4:56 PM, Daniel Farina dan...@heroku.com wrote: I have been working with xlogdump and noticed that unfortunately it cannot be installed without access to a postgres build directory, which makes the

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Daniel Farina
On Mon, Jan 16, 2012 at 6:18 PM, Robert Haas robertmh...@gmail.com wrote: I think you make a compelling case. That's enough for me to just do it. Expect a patch soon. -- fdr -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-16 Thread Greg Smith
On 01/16/2012 08:27 PM, Robert Haas wrote: the last two release cycles I've put huge amounts of energy into trying to get the release stable enough to release before July and August roll around and everybody disappears. It didn't work, either time. If that's not going to happen anyway, then

Re: [HACKERS] Why is CF 2011-11 still listed as In Progress?

2012-01-16 Thread Robert Haas
On Mon, Jan 16, 2012 at 10:00 PM, Greg Smith g...@2ndquadrant.com wrote: On 01/16/2012 08:27 PM, Robert Haas wrote: the last two release cycles I've put huge amounts of energy into trying to get the release stable enough to release before July and August roll around and everybody disappears.  

Re: [HACKERS] Should we add crc32 in libpgport?

2012-01-16 Thread Tom Lane
Daniel Farina dan...@heroku.com writes: Copying CRC32 implementations everywhere is not the worst thing, but I find it inadequately explained why it's necessary for now, at least. Agreed, but I don't care for your proposed solution (put it in libpgport) because that assumes a fact not in

Re: [HACKERS] Arithmetic operators for macaddr type

2012-01-16 Thread Fujii Masao
On Tue, Dec 13, 2011 at 2:16 PM, Brendan Jurd dire...@gmail.com wrote: On 12 December 2011 15:59, Pavel Stehule pavel.steh...@gmail.com wrote: 2011/12/12 Brendan Jurd dire...@gmail.com: I just bumped into a situation where I wanted to do a little macaddr arithmetic in postgres.  I note that

Re: [HACKERS] foreign key locks, 2nd attempt

2012-01-16 Thread Heikki Linnakangas
On 16.01.2012 21:52, Alvaro Herrera wrote: Excerpts from Heikki Linnakangas's message of lun ene 16 16:17:42 -0300 2012: On 15.01.2012 06:49, Alvaro Herrera wrote: - pg_upgrade bits are missing. I guess we'll need to rewrite pg_multixact contents in pg_upgrade. Is the page format

Re: [HACKERS] Review: Non-inheritable check constraints

2012-01-16 Thread Nikhil Sontakke
I have also tried to change the error message as per Alvaro's suggestions. I will really try to see if we have other issues. Really cannot have Robert reporting all the bugs and getting annoyed, but there are lotsa variations possible with inheritance.. So did you find anything?

Re: [HACKERS] Review: Non-inheritable check constraints

2012-01-16 Thread Nikhil Sontakke
I will really try to see if we have other issues. Really cannot have Robert reporting all the bugs and getting annoyed, but there are lotsa variations possible with inheritance.. BTW thank you for doing the work on this. Probably the reason no one bothers too much with inheritance is

Re: [HACKERS] WAL Restore process during recovery

2012-01-16 Thread Fujii Masao
On Mon, Jan 16, 2012 at 2:06 AM, Simon Riggs si...@2ndquadrant.com wrote: WALRestore process asynchronously executes restore_command while recovery continues working. Overlaps downloading of next WAL file to reduce time delays in file based archive recovery. Handles cases of file-only and

Re: [HACKERS] psql case preserving completion

2012-01-16 Thread Fujii Masao
On Thu, Jan 12, 2012 at 5:29 AM, Peter Eisentraut pete...@gmx.net wrote: In psql, the tab completion always converts key words to upper case.  In practice, I and I think most users type in lower case.  So then you end up with commands looking like this: = alter TABLE foo add CONSTRAINT bar