Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Andres Freund
Hi, On Thursday, July 19, 2012 07:18:08 PM Satoshi Nagayasu wrote: I agree with that we need more sophisticated way to share the code between the backend and several utilities (including xlogdump), but AFAIK, a contrib module must allow to be built *without* the core source tree. I don't

Re: [HACKERS] enhanced error fields

2012-07-23 Thread Peter Geoghegan
On 18 July 2012 19:13, Pavel Stehule pavel.steh...@gmail.com wrote: * renamed erritem to err_generic_string * fixed CSVlog generation * new file /utils/error/relerror.c with axillary functions - declarations are in utils/rel.h Why has this revision retained none of my editorialisations? In

Re: [HACKERS] embedded list v2

2012-07-23 Thread Peter Geoghegan
On 5 July 2012 02:49, Peter Geoghegan pe...@2ndquadrant.com wrote: On 28 June 2012 19:20, Andres Freund and...@2ndquadrant.com wrote: 0001-Add-embedded-list-interface.patch Looks good now? I have a few gripes. We are passed the nominal deadline. Had you planned on getting back to me this

Re: [HACKERS] enhanced error fields

2012-07-23 Thread Pavel Stehule
2012/7/23 Peter Geoghegan pe...@2ndquadrant.com: On 18 July 2012 19:13, Pavel Stehule pavel.steh...@gmail.com wrote: * renamed erritem to err_generic_string * fixed CSVlog generation * new file /utils/error/relerror.c with axillary functions - declarations are in utils/rel.h Why has this

Re: [HACKERS] embedded list v2

2012-07-23 Thread Andres Freund
On Monday, July 23, 2012 12:55:01 PM Peter Geoghegan wrote: On 5 July 2012 02:49, Peter Geoghegan pe...@2ndquadrant.com wrote: On 28 June 2012 19:20, Andres Freund and...@2ndquadrant.com wrote: 0001-Add-embedded-list-interface.patch Looks good now? I have a few gripes. We are

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread Andrew Dunstan
On 07/23/2012 12:37 AM, David Fetter wrote: On Tue, Jul 17, 2012 at 06:56:50PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jul 16, 2012 at 3:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: BTW, while we are on the subject: hasn't this split completely broken the

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread David Fetter
On Mon, Jul 23, 2012 at 08:29:16AM -0400, Andrew Dunstan wrote: On 07/23/2012 12:37 AM, David Fetter wrote: On Tue, Jul 17, 2012 at 06:56:50PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jul 16, 2012 at 3:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: BTW, while we

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread Andrew Dunstan
On 07/23/2012 08:41 AM, David Fetter wrote: The buildfarm is not at all designed to test performance. That's why we want a performance farm. Right. Apart from hardware, what are we stalled on? Software :-) I am trying to find some cycles to get something going. cheers andrew -- Sent

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread Craig Ringer
On 07/23/2012 08:29 PM, Andrew Dunstan wrote: I'm not sure how you automate testing a pull-the-plug scenario. fire up kvm or qemu instances, then kill 'em. -- Craig Ringer -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread Andrew Dunstan
On 07/23/2012 09:04 AM, Craig Ringer wrote: On 07/23/2012 08:29 PM, Andrew Dunstan wrote: I'm not sure how you automate testing a pull-the-plug scenario. fire up kvm or qemu instances, then kill 'em. Yeah, maybe. Knowing just when to kill them might be an interesting question. I'm

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread Craig Ringer
On 07/23/2012 09:47 PM, Andrew Dunstan wrote: On 07/23/2012 09:04 AM, Craig Ringer wrote: On 07/23/2012 08:29 PM, Andrew Dunstan wrote: I'm not sure how you automate testing a pull-the-plug scenario. fire up kvm or qemu instances, then kill 'em. Yeah, maybe. Knowing just when to kill

Re: [HACKERS] Using pg_upgrade on log-shipping standby servers

2012-07-23 Thread Robert Haas
On Sat, Jul 21, 2012 at 8:57 AM, Bruce Momjian br...@momjian.us wrote: On Sat, Jul 21, 2012 at 11:24:21AM +0300, Peter Eisentraut wrote: On fre, 2012-07-20 at 13:11 -0400, Bruce Momjian wrote: I think the commands to run after pg_upgrade --link completes on both primary and standby might be

Re: [HACKERS] 9.2 release schedule

2012-07-23 Thread Robert Haas
On Sat, Jul 21, 2012 at 6:23 PM, Tom Lane t...@sss.pgh.pa.us wrote: It looks like the most optimistic schedule we could possibly make, assuming no show-stopper bugs are reported, is: * Wrap beta3 on August 2 for release Monday Aug 6 * RC1 two weeks later (release Aug 20) * 9.2.0 two weeks

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 3:19 AM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, July 19, 2012 07:18:08 PM Satoshi Nagayasu wrote: I agree with that we need more sophisticated way to share the code between the backend and several utilities (including xlogdump), but AFAIK, a contrib

Re: [HACKERS] enhanced error fields

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 7:03 AM, Pavel Stehule pavel.steh...@gmail.com wrote: You don't have to agree with all of those things of course, but you should have at least commented on them. I didn't spend time cleaning things up only to have those changes ignored. I'm particularly surprised that

Re: [HACKERS] 9.2 release schedule

2012-07-23 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Seems OK, but I think we need to work a little harder on evicting some things from the list of open items. I don't think all of the things listed in the blockers section really are, and I'm not sure what needs to be done about some of the things that

Re: [HACKERS] enhanced error fields

2012-07-23 Thread Peter Geoghegan
On 23 July 2012 15:23, Robert Haas robertmh...@gmail.com wrote: It seems clear that it's not reasonable to expect any more review to be done here this CommitFest, given that the changes from reviews already made haven't been incorporated into the patch. Therefore, I'm going to mark this one

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-23 Thread Jeff Janes
On Mon, Jul 23, 2012 at 5:41 AM, David Fetter da...@fetter.org wrote: On Mon, Jul 23, 2012 at 08:29:16AM -0400, Andrew Dunstan wrote: I'm not sure how you automate testing a pull-the-plug scenario. I have a dim memory of how the FreeBSD project was alleged to have done it, namely by rigging

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Andres Freund
On Monday, July 23, 2012 04:17:39 PM Robert Haas wrote: On Mon, Jul 23, 2012 at 3:19 AM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, July 19, 2012 07:18:08 PM Satoshi Nagayasu wrote: I agree with that we need more sophisticated way to share the code between the backend and

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Robert Haas
On Fri, Jun 15, 2012 at 6:10 PM, Tom Lane t...@sss.pgh.pa.us wrote: I would be concerned about this if it were per-sort-tuple wastage, but what I understood to be happening was that this was a single instance of an expansible buffer (per sort, perhaps, but still just one buffer). And, as you

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 11:04 AM, Andres Freund and...@2ndquadrant.com wrote: On Monday, July 23, 2012 04:17:39 PM Robert Haas wrote: On Mon, Jul 23, 2012 at 3:19 AM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, July 19, 2012 07:18:08 PM Satoshi Nagayasu wrote: I agree with that

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Peter Geoghegan
On 23 July 2012 16:09, Robert Haas robertmh...@gmail.com wrote: However, what this really boils down to is that you and Peter don't like this line of code: + tss-buflen1 = TYPEALIGN(TEXTBUFLEN, len1); I can only speak for myself, though I agree with your summary here. What

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 11:34 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 23 July 2012 16:09, Robert Haas robertmh...@gmail.com wrote: However, what this really boils down to is that you and Peter don't like this line of code: + tss-buflen1 = TYPEALIGN(TEXTBUFLEN, len1);

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Peter Geoghegan
On 23 July 2012 16:36, Robert Haas robertmh...@gmail.com wrote: On Mon, Jul 23, 2012 at 11:34 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: tss-buflen = 1 ffs(len1); I'm sorry, I don't follow you here. What is ffs() ? Sorry, fls, not ffs. I always get those mixed up. See

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 12:07 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 23 July 2012 16:36, Robert Haas robertmh...@gmail.com wrote: On Mon, Jul 23, 2012 at 11:34 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: tss-buflen = 1 ffs(len1); I'm sorry, I don't follow you here. What

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Andres Freund
On Monday, July 23, 2012 05:11:20 PM Robert Haas wrote: On Mon, Jul 23, 2012 at 11:04 AM, Andres Freund and...@2ndquadrant.com wrote: On Monday, July 23, 2012 04:17:39 PM Robert Haas wrote: On Mon, Jul 23, 2012 at 3:19 AM, Andres Freund and...@2ndquadrant.com wrote: On Thursday, July

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 12:13 PM, Andres Freund and...@2ndquadrant.com wrote: Could that be fixed by moving the debugging routines into a separate set of files, instead of having them lumped in with the code that applies those xlog records? Its a major effort. Those function use elog(),

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Satoshi Nagayasu
2012/07/24 1:15, Robert Haas wrote: On Mon, Jul 23, 2012 at 12:13 PM, Andres Freund and...@2ndquadrant.com wrote: Could that be fixed by moving the debugging routines into a separate set of files, instead of having them lumped in with the code that applies those xlog records? Its a major

Re: [HACKERS] [PATCH] XLogReader v2

2012-07-23 Thread Robert Haas
On Mon, Jul 23, 2012 at 1:03 PM, Satoshi Nagayasu sn...@uptime.jp wrote: The stringinfo thing has long been an annoyance to me. libpq has PQExpBuffer which is the exact same thing. I don't like that we have two implementations of that in two different code bases, and you have to remember to

[HACKERS] postgres 9 bind address for replication

2012-07-23 Thread Adam Crews
On Mon, Jul 23, 2012 at 8:34 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jul 21, 2012 at 1:24 AM, Adam Crews adam.cr...@gmail.com wrote: Hello, I'm sorry for cross-posting, however I originally posted this to pgsql-general list, but didnt get any replies. Then I posted to

Re: [HACKERS] [BUGS] BUG #6748: sequence value may be conflict in some cases

2012-07-23 Thread Tom Lane
meixiangm...@huawei.com writes: [ freshly-created sequence has wrong state after crash ] I didn't believe this at first, but sure enough, it fails just as described if you force a crash between the first and second nextval calls for the sequence. This used to work ... The change that broke it

Re: [HACKERS] pgbench -i order of vacuum

2012-07-23 Thread Robert Haas
On Fri, Jul 20, 2012 at 12:26 PM, Tom Lane t...@sss.pgh.pa.us wrote: Jeff Janes jeff.ja...@gmail.com writes: On Fri, Jul 20, 2012 at 7:57 AM, Amit Kapila amit.kap...@huawei.com wrote: The command it executes is vacuum analyze .., so it will do analyze also on table which means it will collect

Re: [HACKERS] postgres 9 bind address for replication

2012-07-23 Thread Andrew Dunstan
On 07/23/2012 02:23 PM, Adam Crews wrote: On Mon, Jul 23, 2012 at 8:34 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jul 21, 2012 at 1:24 AM, Adam Crews adam.cr...@gmail.com wrote: Hello, I'm sorry for cross-posting, however I originally posted this to pgsql-general list, but didnt

Re: [HACKERS] [patch] libpq one-row-at-a-time API

2012-07-23 Thread Marko Kreen
Here is a simple test program that takes a SELECT query, reads it and outputs a COPY-formatted stream to standard output, to simulate some activity. It operates on 3 modes, specified by commant-line switches: -f Load full resultset at once - old way. -s Single-Row mode using PQgetResult().

Re: [HACKERS] 9.2 release schedule

2012-07-23 Thread Noah Misch
On Mon, Jul 23, 2012 at 10:29:06AM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: Seems OK, but I think we need to work a little harder on evicting some things from the list of open items. I don't think all of the things listed in the blockers section really are, and I'm

Re: [HACKERS] Using pg_upgrade on log-shipping standby servers

2012-07-23 Thread Peter Eisentraut
On mån, 2012-07-23 at 10:08 -0400, Robert Haas wrote: Relying on the number of hard links seems very fragile. For example, it'll break if you are using copy mode. And it won't work on Windows, either. pg_upgrade could remember the list of files that the user would need to copy to the remote

Re: [HACKERS] [patch] libpq one-row-at-a-time API

2012-07-23 Thread Merlin Moncure
On Mon, Jul 23, 2012 at 2:05 PM, Marko Kreen mark...@gmail.com wrote: Here is a simple test program that takes a SELECT query, reads it and outputs a COPY-formatted stream to standard output, to simulate some activity. It operates on 3 modes, specified by commant-line switches: -f Load

Re: [HACKERS] [patch] libpq one-row-at-a-time API

2012-07-23 Thread Marko Kreen
On Tue, Jul 24, 2012 at 12:27 AM, Merlin Moncure mmonc...@gmail.com wrote: On Mon, Jul 23, 2012 at 2:05 PM, Marko Kreen mark...@gmail.com wrote: It seems odd (but maybe ok) that you have to set the single row mode on the connection only to have the server reset it whenever you call a send

[HACKERS] Tab completion for INHERIT and NO INHERIT

2012-07-23 Thread Jeff Janes
I was playing around with partitioning recently, and was annoyed that tab completion doesn't work for setting the table to (dis)inherit. It seemed easy enough to add. For the NO INHERIT case, it would be nice to complete only table names currently being inherited by the first table, but I don't

Re: [HACKERS] postgres 9 bind address for replication

2012-07-23 Thread Adam Crews
On Jul 23, 2012, at 11:45 AM, Andrew Dunstan and...@dunslane.net wrote: On 07/23/2012 02:23 PM, Adam Crews wrote: On Mon, Jul 23, 2012 at 8:34 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jul 21, 2012 at 1:24 AM, Adam Crews adam.cr...@gmail.com wrote: Hello, I'm sorry for

Re: [HACKERS] isolation check takes a long time

2012-07-23 Thread Peter Eisentraut
On fre, 2012-07-20 at 13:15 -0400, Andrew Dunstan wrote: On 07/19/2012 09:54 AM, Andrew Dunstan wrote: Meanwhile, I would like to remove the prepared_transactions test from the main isolation schedule, and add a new Make target which runs that test explicitly. Is there any objection