Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao wrote: > On Wed, Jan 27, 2016 at 7:34 PM, Shulgin, Oleksandr > wrote: > > Hi, > > > > Please find attached a simple copy-paste fix for CREATE_REPLICATION_SLOT > > syntax. > > We should change also START_REPLICATION SLOT syntax document as follows? > >

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

On 28 January 2016 at 16:36, Shulgin, Oleksandr < oleksandr.shul...@zalando.de> wrote: > On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao > wrote: > >> On Wed, Jan 27, 2016 at 7:34 PM, Shulgin, Oleksandr >> wrote: >> > Hi, >> > >> > Please find attached a simple copy-paste fix for CREATE_REPLICATION

Re: [HACKERS] Declarative partitioning

Hi Tomas, Thanks for your comments and sorry for replying so late. On 2016/01/22 22:54, Tomas Vondra wrote: > thanks for working on this. Seems the last version of the patch was > submitted more than 2 months ago and I believe large parts of it will get > reworked based on the extensive discussi

[HACKERS] Template for commit messages

There has been a request in the FOSDEM developers meeting that committers use a more consistent format for commit messages. This is the format I use: -- email subject limit - -- gitweb summary limit --

Re: [HACKERS] [PATCH] better systemd integration

Hi 2016-01-28 3:50 GMT+01:00 Peter Eisentraut : > On 1/27/16 7:02 AM, Pavel Stehule wrote: > > The issues: > > > > 1. configure missing systemd integration test, compilation fails: > > > > postmaster.o postmaster.c > > postmaster.c:91:31: fatal error: systemd/sd-daemon.h: No such file or > > dire

Re: [HACKERS] Trivial doc fix in logicaldecoding.sgml

On Thu, Jan 28, 2016 at 9:42 AM, Craig Ringer wrote: > > > On 28 January 2016 at 16:36, Shulgin, Oleksandr < oleksandr.shul...@zalando.de> wrote: >> >> On Thu, Jan 28, 2016 at 5:55 AM, Fujii Masao wrote: >>> >>> >>> We should change also START_REPLICATION SLOT syntax document as follows? >>> >>>

Re: [HACKERS] [PATCH] better systemd integration

> > > Second issue: > > > > Mapping of levels between pg and journal levels is moved by1 > > This is the same as how the "syslog" destination works. > > I understand to this logic, but I miss any documentation. Regards Pavel

Re: [HACKERS] Minor code improvements to create_foreignscan_plan/ExecInitForeignScan

Etsuro Fujita wrote: > On 2016/01/28 12:13, Robert Haas wrote: > >I don't think this is a good idea. Most of the time, no system > >columns will be present, and we'll just be scanning the Bitmapset > >twice rather than once. Sure, that doesn't take many extra cycles, > >but if the point of all t

Re: [HACKERS] extend pgbench expressions with functions

I do not think that it is really worth fixing, but I will not prevent anyone to fix it. I still think it does. Well, if there is consensus to address this one and optionally the other integer overflows even on back branches, I'll write a patch and let's call that a deal. This is not a problem

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 03:52:00AM -0500, Bruce Momjian wrote: > There has been a request in the FOSDEM developers meeting that > committers use a more consistent format for commit messages. This is > the format I use: Here is an updated version that includes a potential bug number: -- e

Re: [HACKERS] Template for commit messages

Hi, On 01/28/2016 11:06 AM, Bruce Momjian wrote: On Thu, Jan 28, 2016 at 03:52:00AM -0500, Bruce Momjian wrote: There has been a request in the FOSDEM developers meeting that committers use a more consistent format for commit messages. This is the format I use: Here is an updated version tha

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

>+if(!scan_all) >+scanned_heap_pages = scanned_heap_pages + >next_not_all_visible_block; >I don't want to be too much of a stickler for details here, but it >seems to me that this is an outright lie. Initially the scanned_heap_pages were meant to report just th

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 11:30:58AM +0100, Tomas Vondra wrote: > Any reason why not to adapt the git message conventions from kernel? > > https://git.wiki.kernel.org/index.php/CommitMessageConventions > > I'd expect there are tools already working with that format, making > the life easier for us.

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 11:49 AM, Bruce Momjian wrote: > On Thu, Jan 28, 2016 at 11:30:58AM +0100, Tomas Vondra wrote: > > Any reason why not to adapt the git message conventions from kernel? > > > > https://git.wiki.kernel.org/index.php/CommitMessageConventions > > > > I'd expect there are tools

Re: [HACKERS] Template for commit messages

Bruce Momjian wrote: > There has been a request in the FOSDEM developers meeting that > committers use a more consistent format for commit messages. Let me point out that the reason this is being put forward is to make sure we have the reviewers listed for each patch, so that we can add a paragrap

Re: [HACKERS] Template for commit messages

Magnus Hagander wrote: > They also had tested-by, it might be an idea to include that as well? How about User-Interface-Bikeshedded-By: ? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hacke

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 11:53:44AM +0100, Magnus Hagander wrote: > The original format uses the author for that (author != committer in git), but > that changes how we work a bit more. I'd be happy to just clal it "Author" > rather than "Patch-by". > > I also suggest a - in "Backpatch-through:" --

Re: [HACKERS] Support for N synchronous standby servers - take 2

On Wed, Jan 20, 2016 at 2:35 PM, Masahiko Sawada wrote: > On Tue, Jan 19, 2016 at 1:52 AM, Thom Brown wrote: >> On 3 January 2016 at 13:26, Masahiko Sawada wrote: >>> On Fri, Dec 25, 2015 at 7:21 AM, Thomas Munro >>> wrote: On Fri, Dec 25, 2015 at 8:50 AM, Masahiko Sawada wrote: >>>

Re: [HACKERS] Weighted Stats

I'm closing this for the current commitfest as returned-with-feedback. Please resubmit for the 2016-03 CF once you have it. Thanks! -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mail

Re: [HACKERS] dblink: add polymorphic functions.

Joe Conway wrote: > Ok, back to the drawing board. Thanks for the feedback. Closing this one as returned-with-feedback. Please do resubmit for CF 2016-03. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Se

Re: [HACKERS] Template for commit messages

Dne 28. 1. 2016 11:57 napsal uživatel "Alvaro Herrera" < alvhe...@2ndquadrant.com>: > > Magnus Hagander wrote: > > > They also had tested-by, it might be an idea to include that as well? > > How about > User-Interface-Bikeshedded-By: > ? +1 > > -- > Álvaro Herrerahttp://www.2ndQua

Re: [HACKERS] POC, WIP: OR-clause support for indexes

I think this is very exciting stuff, but since you didn't submit an updated patch after David's review, I'm closing it for now as returned-with-feedback. Please submit a new version once you have it. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Suppor

Re: [HACKERS] [PROPOSAL] Improvements of Hunspell dictionaries support

Artur Zakirov wrote: > I undo the changes and the error will be raised. I will update the patch > soon. I don't think you ever did this. I'm closing it now, but it sounds useful stuff so please do resubmit for 2016-03. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Dev

Re: [HACKERS] Relation extension scalability

On Mon, Jan 25, 2016 at 11:59 AM, Dilip Kumar wrote: 1. >> Patch is not getting compiled. >> >> 1>src/backend/access/heap/hio.c(480): error C2065: 'buf' : undeclared >> identifier >> > Oh, My mistake, my preprocessor is ignoring this error and relacing it > with BLKSIZE > FIXED > 3. I think yo

Re: [HACKERS] Relation extension scalability

On Thu, Jan 28, 2016 at 4:53 PM, Dilip Kumar wrote: > I did not find in regression in normal case. > Note: I tested it with previous patch extend_num_pages=10 (guc parameter) > so that we can see any impact on overall system. > Just forgot to mentioned That i have run pgbench read-write case. S

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

Michael Paquier wrote: Many companies use it, including mine, and likely EDB. Ok, why? I wonder why it is? -- Yury Zhuravlev Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to y

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

So even if the main packages switched to compiling with mingw, we'd probably still want to support MSVC. MinGV more accessible. We can always say that after the release of X is not supported by the MSVC. I do not propose to abandon the MSVC but its use to be justified. Are we moving forward wi

Re: [HACKERS] [PROPOSAL] Improvements of Hunspell dictionaries support

On 28.01.2016 14:19, Alvaro Herrera wrote: Artur Zakirov wrote: I undo the changes and the error will be raised. I will update the patch soon. I don't think you ever did this. I'm closing it now, but it sounds useful stuff so please do resubmit for 2016-03. I'm working on the patch. I wan

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

Craig Ringer wrote: Yeah, strongly agree there. CMake has excellent MSVC support btw. Yes... but I found only hack way for call gendef.pl in pre_link stage (get objects folder name). CMake suggests that we use for normal MSVC ways to create dll. OTOH MinGW relies on reverse-engineered hea

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

Craig Ringer wrote: I strongly disagree. MSVC is a high quality compiler and the primary tool for the platform. Ok. And we not suport MSVC2015 now. Either we support the platform normally or throwing it. Now it all looks like a zombie. -- Yury Zhuravlev Postgres Professional: http://www.postgr

Re: [HACKERS] [PROPOSAL] Improvements of Hunspell dictionaries support

Sorry, I don't know why this thread was moved to another thread. I duplicate the patch here. On 28.01.2016 14:19, Alvaro Herrera wrote: Artur Zakirov wrote: I undo the changes and the error will be raised. I will update the patch soon. I don't think you ever did this. I'm closing it now, b

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

On Thu, Jan 28, 2016 at 8:51 PM, Yury Zhuravlev wrote: > Craig Ringer wrote: >> >> I strongly disagree. MSVC is a high quality compiler and the primary tool >> for the platform. > > Ok. And we not suport MSVC2015 now. Either we support the platform normally > or throwing it. Now it all looks like

[HACKERS] Several problems in tab-completions for SET/RESET

Hi, I found that the following tab-completions for SET/RESET which worked properly before doesn't work properly now in the master. 1. ALTER SYSTEM SET|RESET lists nothing. 2. ALTER DATABASE xxx SET lists nothing. 3. ALTER DATABASE xxx SET yyy lists nothing. 4. ALTER DATABASE xxx SET datestyle

[HACKERS] Comment typos in source code: s/thats/that is/

Hi all, I found a couple of typos as per the $subject. A patch is attached. Regards, -- Michael diff --git a/contrib/pgcrypto/fortuna.c b/contrib/pgcrypto/fortuna.c index 7ab888f..5028203 100644 --- a/contrib/pgcrypto/fortuna.c +++ b/contrib/pgcrypto/fortuna.c @@ -304,7 +304,7 @@ get_rand_pool(FS

Re: Odd behavior in foreign table modification (Was: Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW)

On 2016/01/28 12:58, Robert Haas wrote: On Thu, Jan 21, 2016 at 4:05 AM, Etsuro Fujita wrote: By the way, I'm not too sure I understand the need for the core changes that are part of this patch, and I think that point merits some discussion. Whenever you change core like this, you're changing

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 3:52 AM, Bruce Momjian wrote: > There has been a request in the FOSDEM developers meeting that > committers use a more consistent format for commit messages. This is > the format I use: > > -- email subject limit - >

Re: [HACKERS] Minor code improvements to create_foreignscan_plan/ExecInitForeignScan

On 2016/01/28 18:15, Alvaro Herrera wrote: Etsuro Fujita wrote: On 2016/01/28 12:13, Robert Haas wrote: I don't think this is a good idea. Most of the time, no system columns will be present, and we'll just be scanning the Bitmapset twice rather than once. Sure, that doesn't take many extra

Re: [HACKERS] Template for commit messages

On 01/28/2016 01:57 PM, Robert Haas wrote: ... One of the things I like about the current free-form approach is that you can indicate nuances, like: Person X reviewed an earlier version of this patch that was a lot different than this one. Person X reviewed this patch but didn't totally endorse

Re: [HACKERS] Support for N synchronous standby servers - take 2

On Thu, Jan 28, 2016 at 8:05 PM, Fujii Masao wrote: > On Wed, Jan 20, 2016 at 2:35 PM, Masahiko Sawada > wrote: >> On Tue, Jan 19, 2016 at 1:52 AM, Thom Brown wrote: >>> On 3 January 2016 at 13:26, Masahiko Sawada wrote: On Fri, Dec 25, 2015 at 7:21 AM, Thomas Munro wrote: > On

Re: [HACKERS] Several problems in tab-completions for SET/RESET

On Thu, Jan 28, 2016 at 9:32 PM, Fujii Masao wrote: > I found that the following tab-completions for SET/RESET which > worked properly before doesn't work properly now in the master. > > 1. ALTER SYSTEM SET|RESET lists nothing. > 2. ALTER DATABASE xxx SET lists nothing. > 3. ALTER DATABASE xxx S

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

Hi, On Thu, Jan 28, 2016 at 7:38 PM, Rahila Syed wrote: >>+if(!scan_all) >>+scanned_heap_pages = scanned_heap_pages + >>next_not_all_visible_block; > >>I don't want to be too much of a stickler for details here, but it >>seems to me that this is an outright lie

Re: [HACKERS] Several problems in tab-completions for SET/RESET

On Thu, Jan 28, 2016 at 10:15 PM, Michael Paquier wrote: > On Thu, Jan 28, 2016 at 9:32 PM, Fujii Masao wrote: >> I found that the following tab-completions for SET/RESET which >> worked properly before doesn't work properly now in the master. >> >> 1. ALTER SYSTEM SET|RESET lists nothing. >> 2.

Re: [HACKERS] tiny doc patch

right. On Thu, Jan 14, 2016 at 5:46 PM, Robert Haas wrote: > On Thu, Jan 14, 2016 at 8:40 AM, Filip Rembiałkowski > wrote: > > (include RLS option in CREATE USER doc) > > > > should go into HEAD and REL9_5_STABLE > > Doesn't ALTER USER need the same fix? > > -- > Robert Haas > EnterpriseDB: ht

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

31.08.2015 10:41, Anastasia Lubennikova: Hi, hackers! I'm going to begin work on effective storage of duplicate keys in B-tree index. The main idea is to implement posting lists and posting trees for B-tree index pages as it's already done for GIN. In a nutshell, effective storing of duplicat

Re: [HACKERS] [PATCH] better systemd integration

On 1/28/16 4:00 AM, Pavel Stehule wrote: > Hi > > 2016-01-28 3:50 GMT+01:00 Peter Eisentraut >: > > On 1/27/16 7:02 AM, Pavel Stehule wrote: > > The issues: > > > > 1. configure missing systemd integration test, compilation fails: > > > > postmaste

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra wrote: > On 01/28/2016 01:57 PM, Robert Haas wrote: >> One of the things I like about the current free-form approach is that >> you can indicate nuances, like: >> >> Person X reviewed an earlier version of this patch that was a lot >> different than th

Re: [HACKERS] extend pgbench expressions with functions

On Thu, Jan 28, 2016 at 1:36 AM, Fabien COELHO wrote: > So I'm arguing that exiting, with an error message, is better than handling > user errors. I'm not objecting to exiting with an error message, but I think letting ourselves be killed by a signal is no good. -- Robert Haas EnterpriseDB: htt

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra wrote: >> How about >> User-Interface-Bikeshedded-By: >> ? > > +1 That's sort of implicitly pejorative. Maybe we could find another way to phrase that, like "Design-suggestions-by" or maybe a more general "Suggestions-by". -- Robert Haas Enterpris

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 09:31:46AM -0500, Robert Haas wrote: > On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra > wrote: > >> How about > >> User-Interface-Bikeshedded-By: > >> ? > > > > +1 > > That's sort of implicitly pejorative. Maybe we could find another > way to phrase that, like "Design-sug

[HACKERS] New committer

Hello! The PostgreSQL core team would like to welcome Dean Rasheed as a new committer for the PostgreSQL project. Dean - welcome! Now let's see how quickly you can break the buildfarm! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 9:34 AM, Bruce Momjian wrote: > On Thu, Jan 28, 2016 at 09:31:46AM -0500, Robert Haas wrote: >> On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra >> wrote: >> >> How about >> >> User-Interface-Bikeshedded-By: >> >> ? >> > >> > +1 >> >> That's sort of implicitly pejorative. M

Re: [HACKERS] Mac OS: invalid byte sequence for encoding "UTF8"

On 27.01.2016 15:28, Artur Zakirov wrote: On 27.01.2016 14:14, Stas Kelvich wrote: Hi. I tried that and confirm strange behaviour. It seems that problem with small cyrillic letter ‘х’. (simplest obscene language filter? =) That can be reproduced with simpler test Stas The test program was

Re: [HACKERS] New committer

On 01/28/2016 06:37 AM, Magnus Hagander wrote: Hello! The PostgreSQL core team would like to welcome Dean Rasheed as a new committer for the PostgreSQL project. Dean - welcome! Now let's see how quickly you can break the buildfarm! Congrats! -- Magnus Hagander Me: http://www.hagander.n

Re: [HACKERS] [PATCH] better systemd integration

Hi Peter, thanks for working on this, I'm looking forward to make Debian's pg_*cluster tools work with that (and hopefully be able to remove tons of legacy code). If a cluster is configured for non-hot-standby replication, the READY=1 seems to never happen. Did you check if that doesn't trigger a

Re: [HACKERS] New committer

On Thu, Jan 28, 2016 at 9:43 AM, Joshua D. Drake wrote: > On 01/28/2016 06:37 AM, Magnus Hagander wrote: >> The PostgreSQL core team would like to welcome Dean Rasheed as a new >> committer for the PostgreSQL project. >> >> Dean - welcome! Now let's see how quickly you can break the buildfarm! > >

Re: [HACKERS] Set search_path + server-prepared statements = cached plan must not change result type

Robert>Hmm, so in your example, you actually want replanning to be able to Robert>change the cached plan's result type? I want backend to cache _several_ plans behind a single "statement name". I want to treat "prepare...exec...deallocate" dance as an optimization step for a simple "exec...exec...

Re: [HACKERS] Template for commit messages

Robert Haas wrote: > On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra > wrote: > >> How about > >> User-Interface-Bikeshedded-By: > >> ? > > > > +1 > > That's sort of implicitly pejorative. Maybe we could find another > way to phrase that, like "Design-suggestions-by" or maybe a more > general "Su

Re: [HACKERS] New committer

On Thu, Jan 28, 2016 at 5:37 PM, Magnus Hagander wrote: > Hello! > > The PostgreSQL core team would like to welcome Dean Rasheed as a new > committer for the PostgreSQL project. > > Dean - welcome! Now let's see how quickly you can break the buildfarm! > Congratulations, of course ! I'd like to

Re: [HACKERS] Template for commit messages

Robert Haas writes: > On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra > wrote: >> Why can't we do both? That is, have a free-form text with the nuances, and >> then Reviewed-By listing the main reviewers? The first one is for humans, >> the other one for automated tools. > I'm not objecting to or

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

On Thu, Jan 28, 2016 at 8:41 AM, Amit Langote wrote: > Or keep scanned_heap_pages as is and add a skipped_pages (or > skipped_heap_pages). I guess the latter would be updated not only for > all visible skipped pages but also pin skipped pages. That is, > updating its counter right after vacrelstat

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 9:52 AM, Tom Lane wrote: > Robert Haas writes: >> On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra >> wrote: >>> Why can't we do both? That is, have a free-form text with the nuances, and >>> then Reviewed-By listing the main reviewers? The first one is for humans, >>> the o

[HACKERS] HEADSUP: gitmaster.postgresql.org - upgrade NOW

Hi all! Per discussion in the afternoon break at FOSDEM/PGDay 2016 Developer Meeting we are going to upgrade gemulon.postgresql.org aka "gitmaster" today (the upgrade was originally scheduled end of last year but due to release and other constraints was never executed). The upgrade is going to st

Re: [HACKERS] [PATCH] better systemd integration

I wonder if instead of HAVE_SYSTEMD at each callsite we shouldn't instead have a pg_sd_notify() call that's a no-op when not systemd. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mai

Re: [HACKERS] New committer

On Thu, Jan 28, 2016 at 8:07 PM, Magnus Hagander wrote: > Hello! > > The PostgreSQL core team would like to welcome Dean Rasheed as a new > committer for the PostgreSQL project. > > Many Congratulation Dean! With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

On 28 January 2016 at 14:06, Anastasia Lubennikova < a.lubennik...@postgrespro.ru> wrote: > > 31.08.2015 10:41, Anastasia Lubennikova: > > Hi, hackers! > I'm going to begin work on effective storage of duplicate keys in B-tree > index. > The main idea is to implement posting lists and posting tree

Re: [HACKERS] extend pgbench expressions with functions

So I'm arguing that exiting, with an error message, is better than handling user errors. I'm not objecting to exiting with an error message, but I think letting ourselves be killed by a signal is no good. Ok, I understand this point for this purpose. -- Fabien. -- Sent via pgsql-hackers m

Re: [HACKERS] New committer

On Thu, Jan 28, 2016 at 03:37:33PM +0100, Magnus Hagander wrote: > Hello! > > The PostgreSQL core team would like to welcome Dean Rasheed as a new > committer for the PostgreSQL project. > > Dean - welcome! Now let's see how quickly you can break the > buildfarm! Kudos! Cheers, David. -- David

Re: [HACKERS] HEADSUP: gitmaster.postgresql.org - upgrade NOW

On 01/28/2016 04:00 PM, Stefan Kaltenbrunner wrote: > Hi all! > > Per discussion in the afternoon break at FOSDEM/PGDay 2016 Developer > Meeting we are going to upgrade gemulon.postgresql.org aka "gitmaster" > today (the upgrade was originally scheduled end of last year but due to > release and o

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 03:52:25PM +0100, Tom Lane wrote: > Robert Haas writes: > > On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra > > wrote: > >> Why can't we do both? That is, have a free-form text with the nuances, and > >> then Reviewed-By listing the main reviewers? The first one is for human

Re: [HACKERS] Template for commit messages

On 01/28/2016 06:57 AM, Robert Haas wrote: I'm on board with Bruce's template as being a checklist of points to be sure to cover when composing a commit message. I'm not sure we need fixed-format rules. Well, I think what people are asking for is precisely a fixed format, and I do think there

Re: [HACKERS] Template for commit messages

On 01/28/2016 06:34 AM, Bruce Momjian wrote: On Thu, Jan 28, 2016 at 09:31:46AM -0500, Robert Haas wrote: On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra wrote: How about User-Interface-Bikeshedded-By: ? +1 That's sort of implicitly pejorative. Maybe we could find another way to phrase tha

Re: [HACKERS] Template for commit messages

* Joshua D. Drake (j...@commandprompt.com) wrote: > On 01/28/2016 06:57 AM, Robert Haas wrote: > > >>I'm on board with Bruce's template as being a checklist of points to be > >>sure to cover when composing a commit message. I'm not sure we need > >>fixed-format rules. > > > >Well, I think what pe

Re: [HACKERS] CustomScan under the Gather node?

> If I would make a proof-of-concept patch with interface itself, it > seems to me file_fdw may be a good candidate for this enhancement. > It is not a field for postgres_fdw. > The attached patch is enhancement of FDW/CSP interface and PoC feature of file_fdw to scan source file partially. It was

Re: [HACKERS] Additional role attributes && superuser review

* Robert Haas (robertmh...@gmail.com) wrote: > On Sun, Jan 17, 2016 at 6:58 PM, Stephen Frost wrote: > > I'm not against that idea, though I continue to feel that there are > > common sets of privileges which backup tools could leverage. > > > > The other issue that I'm running into, again, while

Re: [HACKERS] Fwd: Core dump with nested CREATE TEMP TABLE

On Wed, Jan 27, 2016 at 11:47 PM, Noah Misch wrote: > On Wed, Jan 27, 2016 at 11:04:33PM -0500, Robert Haas wrote: >> +Assert(portal->status != PORTAL_ACTIVE); >> if (portal->status == PORTAL_ACTIVE) >> MarkPortalFailed(portal); >> >> Now that

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

28.01.2016 18:12, Thom Brown: On 28 January 2016 at 14:06, Anastasia Lubennikova mailto:a.lubennik...@postgrespro.ru>> wrote: 31.08.2015 10:41, Anastasia Lubennikova: Hi, hackers! I'm going to begin work on effective storage of duplicate keys in B-tree index. The main ide

[HACKERS] insufficient qualification of some objects in dump files

Some dump objects whose names are not unique on a schema level have insufficient details in the dump TOC. For example, a column default might have a TOC entry like this: 2153; 2604 39696 DEFAULT public a rolename Note that this only contains the schema name and the column name, but not the table

Re: [HACKERS] Additional role attributes && superuser review

On Thu, Jan 28, 2016 at 11:04 AM, Stephen Frost wrote: >> So, this seems like a case where a built-in role would be >> well-justified. I don't really believe in built-in roles as a way of >> bundling related permissions; I know you do, but I don't. I'd rather >> see the individual function permi

Re: [HACKERS] HEADSUP: gitmaster.postgresql.org - upgrade NOW

On Thu, Jan 28, 2016 at 10:25 AM, Stefan Kaltenbrunner wrote: > On 01/28/2016 04:00 PM, Stefan Kaltenbrunner wrote: >> Per discussion in the afternoon break at FOSDEM/PGDay 2016 Developer >> Meeting we are going to upgrade gemulon.postgresql.org aka "gitmaster" >> today (the upgrade was originall

Re: [HACKERS] CustomScan under the Gather node?

On Thu, Jan 28, 2016 at 10:50 AM, Kouhei Kaigai wrote: >> If I would make a proof-of-concept patch with interface itself, it >> seems to me file_fdw may be a good candidate for this enhancement. >> It is not a field for postgres_fdw. >> > The attached patch is enhancement of FDW/CSP interface and

Re: [HACKERS] Template for commit messages

On Thu, Jan 28, 2016 at 10:40:09AM -0500, Stephen Frost wrote: > * Joshua D. Drake (j...@commandprompt.com) wrote: > > On 01/28/2016 06:57 AM, Robert Haas wrote: > > > > >>I'm on board with Bruce's template as being a checklist of points to be > > >>sure to cover when composing a commit message.

Re: [HACKERS] tiny doc patch

On Thu, Jan 28, 2016 at 9:09 AM, Filip Rembiałkowski wrote: > right. Committed and back-patched to 9.5. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your sub

Re: [HACKERS] New committer

On Thu, Jan 28, 2016 at 6:37 AM, Magnus Hagander wrote: > The PostgreSQL core team would like to welcome Dean Rasheed as a new > committer for the PostgreSQL project. Congratulations, Dean. Well deserved. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or

Re: [HACKERS] Set search_path + server-prepared statements = cached plan must not change result type

On Thu, Jan 28, 2016 at 7:48 AM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Robert>Hmm, so in your example, you actually want replanning to be able to > Robert>change the cached plan's result type? > > I want backend to cache _several_ plans behind a single "statement name". > I wan

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

On 28 January 2016 at 16:12, Anastasia Lubennikova < a.lubennik...@postgrespro.ru> wrote: > > 28.01.2016 18:12, Thom Brown: > > On 28 January 2016 at 14:06, Anastasia Lubennikova < > a.lubennik...@postgrespro.ru> wrote: > >> >> 31.08.2015 10:41, Anastasia Lubennikova: >> >> Hi, hackers! >> I'm goi

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

On Thu, Jan 28, 2016 at 9:03 AM, Thom Brown wrote: > I'm surprised that efficiencies can't be realised beyond this point. Your > results show a sweet spot at around 1000 / 1000, with it getting slightly > worse beyond that. I kind of expected a lot of efficiency where all the > values are

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

On 28 January 2016 at 17:09, Peter Geoghegan wrote: > On Thu, Jan 28, 2016 at 9:03 AM, Thom Brown wrote: >> I'm surprised that efficiencies can't be realised beyond this point. Your >> results show a sweet spot at around 1000 / 1000, with it getting >> slightly worse beyond that. I kind o

Re: [HACKERS] HEADSUP: gitmaster.postgresql.org - upgrade NOW

On 01/28/2016 05:24 PM, Robert Haas wrote: > On Thu, Jan 28, 2016 at 10:25 AM, Stefan Kaltenbrunner > wrote: >> On 01/28/2016 04:00 PM, Stefan Kaltenbrunner wrote: >>> Per discussion in the afternoon break at FOSDEM/PGDay 2016 Developer >>> Meeting we are going to upgrade gemulon.postgresql.org a

Re: [HACKERS] Using user mapping OID as hash key for connection hash

On Wed, Jan 27, 2016 at 6:32 AM, Ashutosh Bapat wrote: > As discussed in postgres_fdw join pushdown thread [1], for two different > effective local users which use public user mapping we will be creating two > different connections to the foreign server with the same credentials. > > Robert sugges

Re: [HACKERS] Template for commit messages

On 01/28/2016 03:37 PM, Robert Haas wrote: On Thu, Jan 28, 2016 at 9:34 AM, Bruce Momjian wrote: On Thu, Jan 28, 2016 at 09:31:46AM -0500, Robert Haas wrote: On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra wrote: How about User-Interface-Bikeshedded-By: ? +1 That's sort of implicitly pejor

Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

Michael Paquier wrote: Well, 2015 is not making things easy visibly by not providing direct ways to get locale information. pgwin32_putenv broken too... -- Yury Zhuravlev Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)

On Thu, Jan 28, 2016 at 11:26 AM, Ashutosh Bapat wrote: > 1. pg_fdw_core_v3.patch: changes in core - more description below I've committed most of this patch, with some modifications. In particular, I moved CachedPlanSource's hasForeignJoin flag to the CachedPlan and renamed it has_foreign_join,

Re: [HACKERS] Template for commit messages

* Bruce Momjian (br...@momjian.us) wrote: > On Thu, Jan 28, 2016 at 10:40:09AM -0500, Stephen Frost wrote: > > * Joshua D. Drake (j...@commandprompt.com) wrote: > > > On 01/28/2016 06:57 AM, Robert Haas wrote: > > > > > > >>I'm on board with Bruce's template as being a checklist of points to be >

Re: [HACKERS] extend pgbench expressions with functions

v22 compared to previous: - remove the short macros (although IMO it is a code degradation) - try not to remove/add blanks lines - let some assert "as is" - still exit on float to int overflow, see arguments in other mails - check for INT64_MIN / -1 (although I think it is useless) -- Fab

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

On 28 January 2016 at 17:03, Thom Brown wrote: > > On 28 January 2016 at 16:12, Anastasia Lubennikova < > a.lubennik...@postgrespro.ru> wrote: > >> >> 28.01.2016 18:12, Thom Brown: >> >> On 28 January 2016 at 14:06, Anastasia Lubennikova < >> a.lubennik...@postgrespro.ru> wrote: >> >>> >>> 31.08.

[HACKERS] thanks for FOSDEM/PGDay 2016 Developer Meeting

I read https://wiki.postgresql.org/wiki/FOSDEM/PGDay_2016_Developer_Meeting and would like to say thanks for such nice review of meeting. Oleg

Re: [HACKERS] thanks for FOSDEM/PGDay 2016 Developer Meeting

On Friday, 29 January 2016, Oleg Bartunov wrote: > I read > https://wiki.postgresql.org/wiki/FOSDEM/PGDay_2016_Developer_Meeting and > would like to say thanks for such nice review of meeting. > +many Thanks, Amit

Re: [HACKERS] Additional role attributes && superuser review

* Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Jan 28, 2016 at 11:04 AM, Stephen Frost wrote: > >> So, this seems like a case where a built-in role would be > >> well-justified. I don't really believe in built-in roles as a way of > >> bundling related permissions; I know you do, but I do

Re: [HACKERS] CustomScan under the Gather node?

> On Thu, Jan 28, 2016 at 10:50 AM, Kouhei Kaigai wrote: > >> If I would make a proof-of-concept patch with interface itself, it > >> seems to me file_fdw may be a good candidate for this enhancement. > >> It is not a field for postgres_fdw. > >> > > The attached patch is enhancement of FDW/CSP in

Re: [HACKERS] New committer

On Fri, Jan 29, 2016 at 1:42 AM, Peter Geoghegan wrote: > On Thu, Jan 28, 2016 at 6:37 AM, Magnus Hagander wrote: >> The PostgreSQL core team would like to welcome Dean Rasheed as a new >> committer for the PostgreSQL project. > > Congratulations, Dean. Well deserved. Congratulations, Dean! --

  1   2   >